Re: [PATCH] drm/radeon: fix a missing-check bug

2018-10-19 Thread Koenig, Christian
Am 18.10.18 um 19:13 schrieb Wenwen Wang: > In radeon_read_bios(), the bios rom is firstly mapped to the IO memory > region 'bios' through pci_map_rom(). Then the first two bytes of 'bios' are > copied to 'val1' and 'val2' respectively through readb(). After that, > 'val1' and 'val2' are checked to

Re: [PATCH 1/3] drm/sched: Add callback to mark if sched is ready to work.

2018-10-19 Thread Koenig, Christian
Am 18.10.18 um 20:44 schrieb Andrey Grodzovsky: > Problem: > A particular scheduler may become unsuable (underlying HW) after > some event (e.g. GPU reset). If it's later chosen by > the get free sched. policy a command will fail to be > submitted. > > Fix: > Add a driver specific callback to repor

Re: [PULL] drm-intel-next-fixes

2018-10-19 Thread Daniel Vetter
On Fri, Oct 19, 2018 at 8:59 AM Joonas Lahtinen wrote: > > Quoting Daniel Vetter (2018-10-18 22:32:00) > > On Thu, Oct 18, 2018 at 6:57 PM Joonas Lahtinen > > wrote: > > > > > > Hi Dave, > > > > > > Here comes the final set of fixes under -next-fixes umbrella. > > > Next one will be then from -fi

Re: [PATCH 3/3] drm/amdgpu: Refresh rq selection for job after ASIC reset

2018-10-19 Thread Koenig, Christian
Am 18.10.18 um 20:44 schrieb Andrey Grodzovsky: > A ring might become unusable after reset, if that the case > drm_sched_entity_select_rq will choose another, working rq > to run the job if there is one. > Also, skip recovery of ring which is not ready. Well that is not even remotely sufficient.

Re: [Patch v4 5/8] drm/omap: Add global state as a private atomic object

2018-10-19 Thread Daniel Vetter
On Thu, Oct 18, 2018 at 08:11:30AM -0500, Benoit Parrot wrote: > Daniel Vetter wrote on Tue [2018-Oct-16 14:29:46 +0200]: > > On Fri, Oct 12, 2018 at 03:17:00PM -0500, Benoit Parrot wrote: > > > Global shared resources (like hw overlays) for omapdrm are implemented > > > as a part of atomic state

Re: [PATCH 1/3] drm/sched: Add callback to mark if sched is ready to work.

2018-10-19 Thread Michel Dänzer
On 2018-10-18 8:44 p.m., Andrey Grodzovsky wrote: > Problem: > A particular scheduler may become unsuable (underlying HW) after > some event (e.g. GPU reset). If it's later chosen by > the get free sched. policy a command will fail to be > submitted. > > Fix: > Add a driver specific callback to re

Re: [git pull] drm fixes for 4.19 final

2018-10-19 Thread Greg Kroah-Hartman
On Fri, Oct 19, 2018 at 02:59:11PM +1000, Dave Airlie wrote: > Hi Greg, > > Just a last set of misc core fixes for final. > > 4 fixes, one use after free, one fb integration fix, one EDID fix, and > one laptop panel quirk, > > Thanks, > Dave. > > drm-fixes-2018-10-19: > drm: one set of misc fix

Re: [Outreachy kernel] [PATCH DRM] drm: msm: adreno: Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) +PTR_ERR

2018-10-19 Thread Daniel Vetter
On Fri, Oct 19, 2018 at 08:18:52AM +0200, Julia Lawall wrote: > On Fri, 19 Oct 2018, Mamta Shukla wrote: > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR because its > > better to have inlined function rather than code-opened implementation. > > > Just for your information, people ha

[Bug 107928] Screen regularly turns black, reboot needed

2018-10-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107928 --- Comment #12 from Michel Dänzer --- (In reply to Matthew Vaughn from comment #11) > Downgrading from x11-drivers/xf86-video-amdgpu-18.1.0 to > x11-drivers/xf86-video-amdgpu-18.0.1 has prevented the issue from occurring > on my system. Can yo

Re: [PATCH 0/3] Provide struct ttm_global for TTM global state

2018-10-19 Thread Koenig, Christian
Hi Thomas, I honestly still find that way to complicated compared to what it actually does. Both ttm_mem_global and ttm_bo_global can just be some static variables. E.g. the whole handling with drm_global_reference is just superfluous. Can I just write a patch to clean up the mess we created?

Re: [PATCH] drm: panel-orientation-quirks: Do rotation quirk for new GPD Win2 FW

2018-10-19 Thread Hans de Goede
Hi, On 18-10-18 21:31, Gabriel Krisman Bertazi wrote: I just got a new GDP Win2 device with an updated firmware, which still requires this quirk to get the rotation right, so add the new firmware date to the quirk matching table. This should go to drm-misc-next. Signed-off-by: Gabriel Krisman

Re: [PATCH 2/3] drm/amdgpu: Replace TTM initialization/release with ttm_global

2018-10-19 Thread Thomas Zimmermann
Hi, thanks for reviewing the patch. Am 19.10.18 um 08:18 schrieb Zhang, Jerry(Junwei): > On 10/19/2018 12:27 AM, Thomas Zimmermann wrote: >>   /** >>    * amdgpu_ttm_global_init - Initialize global TTM memory reference >> structures. >>    * >> @@ -102,35 +75,15 @@ static void amdgpu_ttm_mem_glob

Re: [PATCH 1/3] drm/ttm: Provide struct ttm_global for referencing TTM global state

2018-10-19 Thread Thomas Zimmermann
Hi, thanks for the review. Am 19.10.18 um 05:30 schrieb Huang Rui: > On Fri, Oct 19, 2018 at 12:27:50AM +0800, Thomas Zimmermann wrote: >> +int ttm_global_init(struct ttm_global *glob) >> +{ >> +int ret; >> + > > We would better add a protection here to make sure the glob is not NULL. > > i

Re: [PATCH 0/3] Provide struct ttm_global for TTM global state

2018-10-19 Thread Thomas Zimmermann
Hi Am 19.10.18 um 09:24 schrieb Koenig, Christian: > Hi Thomas, > > I honestly still find that way to complicated compared to what it > actually does. > > Both ttm_mem_global and ttm_bo_global can just be some static variables. > E.g. the whole handling with drm_global_reference is just superf

Re: [PATCH 1/3] drm/ttm: Provide struct ttm_global for referencing TTM global state

2018-10-19 Thread Daniel Vetter
On Fri, Oct 19, 2018 at 9:38 AM Thomas Zimmermann wrote: > > Hi, > > thanks for the review. > > Am 19.10.18 um 05:30 schrieb Huang Rui: > > On Fri, Oct 19, 2018 at 12:27:50AM +0800, Thomas Zimmermann wrote: > >> +int ttm_global_init(struct ttm_global *glob) > >> +{ > >> +int ret; > >> + > > >

Re: [PATCH 1/3] drm/ttm: Provide struct ttm_global for referencing TTM global state

2018-10-19 Thread Koenig, Christian
Am 19.10.18 um 09:49 schrieb Daniel Vetter: > On Fri, Oct 19, 2018 at 9:38 AM Thomas Zimmermann wrote: >> Hi, >> >> thanks for the review. >> >> Am 19.10.18 um 05:30 schrieb Huang Rui: >>> On Fri, Oct 19, 2018 at 12:27:50AM +0800, Thomas Zimmermann wrote: +int ttm_global_init(struct ttm_globa

Re: [PATCH 0/3] Provide struct ttm_global for TTM global state

2018-10-19 Thread Koenig, Christian
Am 19.10.18 um 09:44 schrieb Thomas Zimmermann: > Hi > > Am 19.10.18 um 09:24 schrieb Koenig, Christian: >> Hi Thomas, >> >> I honestly still find that way to complicated compared to what it >> actually does. >> >> Both ttm_mem_global and ttm_bo_global can just be some static variables. >> E.g. the

Re: [PATCH v2 2/2] drm/exynos: decon: Make pixel blend mode configurable

2018-10-19 Thread kbuild test robot
Hi Christoph, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-exynos/exynos-drm-next] [also build test ERROR on v4.19-rc8 next-20181019] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https

[PATCH] drm/doc: Update errno handbook

2018-10-19 Thread Daniel Vetter
We recently bikeshedded this to a different flavour, but forgot to update the recommendations. Cc: Chris Wilson Cc: Ville Syrjälä Signed-off-by: Daniel Vetter --- Documentation/gpu/drm-uapi.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/gpu/drm-uapi.rst b/Documentatio

Re: [PATCH 2/7] drm: add syncobj timeline support v8

2018-10-19 Thread Chris Wilson
Quoting Chunming Zhou (2018-10-15 09:55:48) > This patch is for VK_KHR_timeline_semaphore extension, semaphore is called > syncobj in kernel side: > This extension introduces a new type of syncobj that has an integer payload > identifying a point in a timeline. Such timeline syncobjs support the >

[PATCH] RFC: Make igts for cross-driver stuff mandatory?

2018-10-19 Thread Daniel Vetter
Hi all, This is just to collect feedback on this idea, and see whether the overall dri-devel community stands on all this. I think the past few cross-vendor uapi extensions all came with igts attached, and personally I think there's lots of value in having them: A cross-vendor interface isn't usef

Re: [PATCH] amdgpu/gmc : fix compile warning

2018-10-19 Thread Daniel Vetter
On Mon, Oct 08, 2018 at 06:13:56PM +, Koenig, Christian wrote: > Am 08.10.2018 um 19:46 schrieb Guenter Roeck: > > On Mon, Oct 08, 2018 at 05:22:24PM +, Koenig, Christian wrote: > >> Am 08.10.2018 um 17:57 schrieb Deucher, Alexander: > >> One thing I found missing in the discussion was

[PATCH 02/18] drm/amdgpu: Replace TTM initialization/release with ttm_global

2018-10-19 Thread Thomas Zimmermann
Unified initialization and relesae of the global TTM state is provided by struct ttm_global and its interfaces. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 63 ++--- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h | 4 +- 2 files changed, 7 inserti

[PATCH 01/18] drm/ttm: Provide struct ttm_global for referencing TTM global state

2018-10-19 Thread Thomas Zimmermann
The new struct ttm_global provides drivers with TTM's global memory and BO in a unified way. Initialization and release is handled internally. The functionality provided by struct ttm_global is currently re-implemented by a dozen individual DRM drivers using struct drm_global. The implementation o

[RFC][PATCH 00/18] Provide a nice interface for TTM global state

2018-10-19 Thread Thomas Zimmermann
This is the full patch set for cleaning up the TTM global-state handling and offering a nice interface for drivers. The first 3 patches have been discussed on dri-devel already. Patch [01] adds struct ttm_global, a data structure that gives drivers a handle ot the global TTM state. Patches [02] t

[PATCH 04/18] drm/ast: Replace TTM initialization/release with ttm_global

2018-10-19 Thread Thomas Zimmermann
Unified initialization and release of the global TTM state is provided by struct ttm_global and its interfaces. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_drv.h | 5 ++-- drivers/gpu/drm/ast/ast_ttm.c | 49 ++- 2 files changed, 11 insertions(+),

[PATCH 05/18] drm/bochs: Replace TTM initialization/release with ttm_global

2018-10-19 Thread Thomas Zimmermann
Unified initialization and release of the global TTM state is provided by struct ttm_global and its interfaces. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/bochs/bochs.h| 5 ++-- drivers/gpu/drm/bochs/bochs_mm.c | 47 +--- 2 files changed, 10 insertions(

[PATCH 12/18] drm/vmwgfx: Replace TTM initialization/release with ttm_global

2018-10-19 Thread Thomas Zimmermann
Unified initialization and release of the global TTM state is provided by struct ttm_global and its interfaces. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 6 ++-- drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 6 ++-- drivers/gpu/drm/vmwgfx/vmwgfx_ttm_glue.c |

[PATCH 03/18] drm/radeon: Replace TTM initialization/release with ttm_global

2018-10-19 Thread Thomas Zimmermann
Unified initialization and release of the global TTM state is provided by struct ttm_global and its interfaces. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/radeon/radeon.h | 4 +-- drivers/gpu/drm/radeon/radeon_ttm.c | 40 - 2 files changed, 7 insertions

[PATCH 10/18] drm/qlx: Replace TTM initialization/release with ttm_global

2018-10-19 Thread Thomas Zimmermann
Unified initialization and release of the global TTM state is provided by struct ttm_global and its interfaces. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/qxl/qxl_drv.h | 4 ++-- drivers/gpu/drm/qxl/qxl_ttm.c | 40 --- 2 files changed, 6 insertions(+),

[PATCH 06/18] drm/cirrus: Replace TTM initialization/release with ttm_global

2018-10-19 Thread Thomas Zimmermann
Unified initialization and release of the global TTM state is provided by struct ttm_global and its interfaces. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/cirrus/cirrus_drv.h | 5 +-- drivers/gpu/drm/cirrus/cirrus_ttm.c | 49 + 2 files changed, 11 insertion

[PATCH 14/18] drm/ttm: Remove struct ttm_bo_global_ref and helpers

2018-10-19 Thread Thomas Zimmermann
The struct ttm_bo_global_ref data type providede a workaround for passing an instance of struct ttm_mem_global to ttm_bo_global_init(). This functionality has been replaced by struct ttm_global and all drivers have been converted. struct ttm_bo_global_ref is obsolete. Signed-off-by: Thomas Zimmer

[PATCH 09/18] drm/nouveau: Replace TTM initialization/release with ttm_global

2018-10-19 Thread Thomas Zimmermann
Unified initialization and release of the global TTM state is provided by struct ttm_global and its interfaces. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/nouveau/nouveau_drv.h | 5 +-- drivers/gpu/drm/nouveau/nouveau_ttm.c | 48 --- 2 files changed, 9 insertio

[PATCH 07/18] drm/hisilicon: Replace TTM initialization/release with ttm_global

2018-10-19 Thread Thomas Zimmermann
Unified initialization and release of the global TTM state is provided by struct ttm_global and its interfaces. Signed-off-by: Thomas Zimmermann --- .../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h | 4 +-- drivers/gpu/drm/hisilicon/hibmc/hibmc_ttm.c | 36 ++- 2 files changed, 5

[PATCH 15/18] drm: Remove DRM_GLOBAL_TTM_OBJECT

2018-10-19 Thread Thomas Zimmermann
The constant DRM_GLOBAL_TTM_OBJECT is unused and not obviously useful. Signed-off-by: Thomas Zimmermann --- include/drm/drm_global.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/drm/drm_global.h b/include/drm/drm_global.h index 4482a9bbd6e9..63ffdcec6690 100644 --- a/include/drm/dr

Re: [PATCH] amdgpu/gmc : fix compile warning

2018-10-19 Thread Daniel Vetter
On Fri, Oct 19, 2018 at 10:53 AM Daniel Vetter wrote: > > On Mon, Oct 08, 2018 at 06:13:56PM +, Koenig, Christian wrote: > > Am 08.10.2018 um 19:46 schrieb Guenter Roeck: > > > On Mon, Oct 08, 2018 at 05:22:24PM +, Koenig, Christian wrote: > > >> Am 08.10.2018 um 17:57 schrieb Deucher, Ale

Re: [PATCH 2/7] drm: add syncobj timeline support v8

2018-10-19 Thread Daniel Vetter
On Fri, Oct 19, 2018 at 10:29:55AM +0800, zhoucm1 wrote: > > > On 2018年10月18日 19:50, Christian König wrote: > > Am 18.10.18 um 05:11 schrieb zhoucm1: > > > > > > > > > On 2018年10月17日 18:24, Daniel Vetter wrote: > > > > On Wed, Oct 17, 2018 at 11:29 AM Koenig, Christian > > > > wrote: > > > > >

[PATCH 13/18] staging/vboxvideo: Replace TTM initialization/release with ttm_global

2018-10-19 Thread Thomas Zimmermann
Unified initialization and release of the global TTM state is provided by struct ttm_global and its interfaces. Signed-off-by: Thomas Zimmermann --- drivers/staging/vboxvideo/vbox_drv.h | 4 +-- drivers/staging/vboxvideo/vbox_ttm.c | 42 +++- 2 files changed, 6 insertion

[PATCH 16/18] drm/ttm: Implement struct ttm_global_item and helpers

2018-10-19 Thread Thomas Zimmermann
The data structure struct ttm_global_item is a replacement for struct drm_global_item. While struct drm_global_item depends on global data instances, struct ttm_global_item allows drivers to use their own privat instances. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ttm/ttm_global.c | 9

[PATCH 17/18] drm/ttm: Implement struct ttm_global with struct ttm_global_ref

2018-10-19 Thread Thomas Zimmermann
Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ttm/ttm_global.c | 28 +++- include/drm/ttm/ttm_global.h | 5 ++--- 2 files changed, 17 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_global.c b/drivers/gpu/drm/ttm/ttm_global.c index 1e5c2f5e

[PATCH 18/18] drm: Remove drm_global.{c,h}

2018-10-19 Thread Thomas Zimmermann
The content of drm_global.{c,h} is obsolete. The functionality is provided in ttm_global.{c,h}. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/Makefile | 2 +- drivers/gpu/drm/drm_drv.c| 2 - drivers/gpu/drm/drm_global.c | 137 --- driver

[PATCH 11/18] drm/virtio: Replace TTM initialization/release with ttm_global

2018-10-19 Thread Thomas Zimmermann
Unified initialization and release of the global TTM state is provided by struct ttm_global and its interfaces. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/virtio/virtgpu_drv.h | 4 +-- drivers/gpu/drm/virtio/virtgpu_ttm.c | 40 +++- 2 files changed, 6 insertion

[PATCH 08/18] drm/mgag200: Replace TTM initialization/release with ttm_global

2018-10-19 Thread Thomas Zimmermann
Unified initialization and release of the global TTM state is provided by struct ttm_global and its interfaces. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_drv.h | 7 ++-- drivers/gpu/drm/mgag200/mgag200_ttm.c | 49 +-- 2 files changed, 12 insert

Re: [PATCH 2/7] drm: add syncobj timeline support v8

2018-10-19 Thread zhoucm1
On 2018年10月19日 16:55, Daniel Vetter wrote: On Fri, Oct 19, 2018 at 10:29:55AM +0800, zhoucm1 wrote: On 2018年10月18日 19:50, Christian König wrote: Am 18.10.18 um 05:11 schrieb zhoucm1: On 2018年10月17日 18:24, Daniel Vetter wrote: On Wed, Oct 17, 2018 at 11:29 AM Koenig, Christian wrote: Am

Re: [PATCH v2 2/2] drm/i915/intel_dsi: Read back pclk set by GOP and use that as pclk v2

2018-10-19 Thread Jani Nikula
On Wed, 17 Oct 2018, Hans de Goede wrote: > On BYT and CHT the GOP sometimes initializes the pclk at a (slightly) > different frequency then the pclk which we've calculated. > > This commit makes the DSI code read-back the pclk set by the GOP and > if that is within a reasonable margin of the calc

Re: [PATCH v2 2/2] drm/selftest: Add drm damage helper selftest

2018-10-19 Thread Alexandru-Cosmin Gheorghe
Hi Deepak, Something to consider, with this approach we kind of break the following behaviour: "Only tests enabled as module parameters are run, if no test is explicitly enabled then all of them are run" What I think we should do is have just one header where we put the selftest(check_plane_stat

[PATCH] drm: Revert "add syncobj timeline support v9"

2018-10-19 Thread Christian König
From: Christian König Still contains some bugs. This reverts commit 48197bc564c7a1888c86024a1ba4f956e0ec2300. Bugs: https://bugs.freedesktop.org/show_bug.cgi?id=108490 Signed-off-by: Christian König --- drivers/gpu/drm/drm_syncobj.c | 306 +++-- drivers/gpu/drm/i9

Re: [PATCH v2 2/2] drm/selftest: Add drm damage helper selftest

2018-10-19 Thread Daniel Vetter
On Fri, Oct 19, 2018 at 11:21 AM Alexandru-Cosmin Gheorghe wrote: > > Hi Deepak, > > Something to consider, with this approach we kind of break the > following behaviour: > "Only tests enabled as module parameters are run, if no test is > explicitly enabled then all of them are run" > > What I thi

Re: [PATCH] drm: Revert "add syncobj timeline support v9"

2018-10-19 Thread Daniel Vetter
On Fri, Oct 19, 2018 at 11:27:11AM +0200, Christian König wrote: > From: Christian König > > Still contains some bugs. > > This reverts commit 48197bc564c7a1888c86024a1ba4f956e0ec2300. Thanks for the super-quick handling, much appreciated. > > Bugs: https://bugs.freedesktop.org/show_bug.cgi?i

Re: [PATCH 01/18] drm/ttm: Provide struct ttm_global for referencing TTM global state

2018-10-19 Thread Christian König
In general I'm really graceful that you look into this, but you are just moving the complexity around instead of cleaning it up. This whole global reference stuff is just going into the wrong direction. Please let me clean that up instead, Christian. Am 19.10.18 um 10:54 schrieb Thomas Zimmerm

Re: [PULL] drm-intel-next-fixes

2018-10-19 Thread Joonas Lahtinen
Quoting Daniel Vetter (2018-10-19 10:05:32) > On Fri, Oct 19, 2018 at 8:59 AM Joonas Lahtinen > wrote: > > > > Quoting Daniel Vetter (2018-10-18 22:32:00) > > > On Thu, Oct 18, 2018 at 6:57 PM Joonas Lahtinen > > > wrote: > > > > > > > > Hi Dave, > > > > > > > > Here comes the final set of fixes

Re: [PATCH 01/18] drm/ttm: Provide struct ttm_global for referencing TTM global state

2018-10-19 Thread Thomas Zimmermann
Hi Am 19.10.18 um 11:30 schrieb Christian König: > In general I'm really graceful that you look into this, but you are just > moving the complexity around instead of cleaning it up. > > This whole global reference stuff is just going into the wrong direction. > > Please let me clean that up inst

Re: [PATCH 01/18] drm/ttm: Provide struct ttm_global for referencing TTM global state

2018-10-19 Thread Koenig, Christian
Am 19.10.18 um 11:41 schrieb Thomas Zimmermann: > Hi > > Am 19.10.18 um 11:30 schrieb Christian König: >> In general I'm really graceful that you look into this, but you are just >> moving the complexity around instead of cleaning it up. >> >> This whole global reference stuff is just going into th

Re: [PATCH 2/7] drm: add syncobj timeline support v8

2018-10-19 Thread zhoucm1
On 2018年10月19日 17:20, zhoucm1 wrote: On 2018年10月19日 16:55, Daniel Vetter wrote: On Fri, Oct 19, 2018 at 10:29:55AM +0800, zhoucm1 wrote: On 2018年10月18日 19:50, Christian König wrote: Am 18.10.18 um 05:11 schrieb zhoucm1: On 2018年10月17日 18:24, Daniel Vetter wrote: On Wed, Oct 17, 2018 at

Re: [PATCH v2] drm/sun4i: Fix an ulong overflow in the dotclock driver

2018-10-19 Thread Maxime Ripard
On Thu, Oct 18, 2018 at 12:02:50PM +0200, Boris Brezillon wrote: > The calculated ideal rate can easily overflow an unsigned long, thus > making the best div selection buggy as soon as no ideal match is found > before the overflow occurs. > > Fixes: 4731a72df273 ("drm/sun4i: request exact rates to

[Bug 108493] Unigine Heaven at 4K crashes amdgpu and causes a GPU hang

2018-10-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108493 Bug ID: 108493 Summary: Unigine Heaven at 4K crashes amdgpu and causes a GPU hang Product: DRI Version: unspecified Hardware: x86-64 (AMD64) OS: Linux (All

[PATCH] drm: fix deadlock of syncobj

2018-10-19 Thread Chunming Zhou
Signed-off-by: Chunming Zhou Cc: Daniel Vetter Cc: Chris Wilson Cc: Christian König --- drivers/gpu/drm/drm_syncobj.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c index 57bf6006394d..2f3c14cb5156 100644

[PULL] drm-intel-next-fixes

2018-10-19 Thread Joonas Lahtinen
Hi Dave, Here are the promised MST fixes that were missing due to being in i915 tree, yet outside i915 directory. Further explanation in the previous PR's thread. Regards, Joonas *** drm-intel-next-fixes-2018-10-19: - The missing 4 MST patches that tooling didn't pick from drm core/nouveau The

Re: [PATCH 2/7] drm: add syncobj timeline support v8

2018-10-19 Thread zhoucm1
[snip] Went boom: https://bugs.freedesktop.org/show_bug.cgi?id=108490 Can we revert pls? Sorry for bug, please. In fact, the bug is already caught and fixed, just the fix part isn't in patch#1, but in patch#2: Have you reverted? If not, I can send that fix in one minute. Regards, David Z

Re: [PATCH] drm: fix deadlock of syncobj

2018-10-19 Thread Chris Wilson
Quoting Chunming Zhou (2018-10-19 11:26:41) > Signed-off-by: Chunming Zhou > Cc: Daniel Vetter > Cc: Chris Wilson > Cc: Christian König > --- > drivers/gpu/drm/drm_syncobj.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers

[PULL] drm-misc-fixes

2018-10-19 Thread Maarten Lankhorst
Hey Dave, The GPF issue was serious enough to send a second pull request for drm-misc-fixes. :) Cheers, ~Maarten drm-misc-fixes-2018-10-19: Second pull request for v4.19: - Fix ulong overflow in sun4i - Fix a serious GPF in waiting for flip_done from commit_tail(). The following changes since

[PATCH v5 2/9] drm/fourcc: Add char_per_block, block_w and block_h in drm_format_info

2018-10-19 Thread Alexandru Gheorghe
For some pixel formats .cpp structure in drm_format info it's not enough to describe the peculiarities of the pixel layout, for example tiled formats or packed formats at bit level. What's implemented here is to add three new members to drm_format_info that could describe such formats: - char_per

[PATCH v5 1/9] drm: fourcc: Convert drm_format_info kerneldoc to in-line member documentation

2018-10-19 Thread Alexandru Gheorghe
In-line member documentation seems to be desired way of documenting structure members. This change had been suggested by Daniel Vetter here: https://lists.freedesktop.org/archives/dri-devel/2018-October/192176.html Signed-off-by: Alexandru Gheorghe --- include/drm/drm_fourcc.h | 30

[PATCH v5 6/9] drm/fourcc: Add AFBC yuv fourccs for Mali

2018-10-19 Thread Alexandru Gheorghe
From: Brian Starkey As we look to enable AFBC using DRM format modifiers, we run into problems which we've historically handled via vendor-private details (i.e. gralloc, on Android). AFBC (as an encoding) is fully flexible, and for example YUV data can be encoded into 1, 2 or 3 encoded "planes",

[PATCH v5 8/9] drm/selftest: Refactor test-drm_plane_helper

2018-10-19 Thread Alexandru Gheorghe
The idea is to split test implementations in different compilation units, but have one single place where we define the list of tests, in this case(drm_modeset_selftests.h). Signed-off-by: Alexandru Gheorghe --- ...er_selftests.h => drm_modeset_selftests.h} | 0 .../drm/selftests/test-drm_modes

[PATCH v5 0/9] Add method to describe tile/bit_level_packed formats

2018-10-19 Thread Alexandru Gheorghe
Changes since v4: - Rebased selftests on latest drm-misc-next Changes since v3: - added an utility function that computes the minimum pitch. - switched drm_format_info to in-line member documentation. - Cleanup/Improved the kernel doc. - Added selftests for: drm_format_info* helpers. Th

[PATCH v5 4/9] drm: mali-dp: Enable Mali-DP tiled buffer formats

2018-10-19 Thread Alexandru Gheorghe
Enable the following formats - DRM_FORMAT_X0L0: DP650 - DRM_FORMAT_X0L2: DP550, DP650 Signed-off-by: Alexandru Gheorghe --- drivers/gpu/drm/arm/malidp_hw.c | 14 +++--- drivers/gpu/drm/arm/malidp_planes.c | 23 +-- 2 files changed, 32 insertions(+), 5 deletions(-)

[PATCH v5 3/9] drm/fourcc: Add fourcc for Mali linear tiled formats

2018-10-19 Thread Alexandru Gheorghe
Mali-DP implements a number of tiled yuv formats which are not currently described in drm_fourcc.h. This adds those definitions and describes their memory layout by using the newly added char_per_block, block_w, block_h. Signed-off-by: Alexandru Gheorghe --- drivers/gpu/drm/drm_fourcc.c | 12 ++

[PATCH v5 7/9] drm/afbc: Add AFBC modifier usage documentation

2018-10-19 Thread Alexandru Gheorghe
From: Brian Starkey AFBC is a flexible, proprietary, lossless compression protocol and format, with a number of defined DRM format modifiers. To facilitate consistency and compatibility between different AFBC producers and consumers, document the expectations for usage of the AFBC DRM format modi

[PATCH v5 9/9] drm/selftests: Add tests for drm_format_info* helpers

2018-10-19 Thread Alexandru Gheorghe
Add selftests for the following newly added functions: - drm_format_info_block_width - drm_format_info_block_height - drm_format_info_min_pitch Signed-off-by: Alexandru Gheorghe --- drivers/gpu/drm/selftests/Makefile| 3 +- .../gpu/drm/selftests/drm_modeset_selftests.h | 3 +

[PATCH v5 5/9] drm: Extend framebuffer_check to handle formats with cpp/char_per_block 0

2018-10-19 Thread Alexandru Gheorghe
For formats that are supported only with non-linear modifiers it doesn't make to much sense to define cpp or char_per_block, so that will be set to 0. This patch adds a restriction to force having a modifier attached when cpp/char_per_block is 0, and to bypass checking the pitch restriction. This

Re: [PATCH] MAINTAINERS: Add entry for VKMS

2018-10-19 Thread Rodrigo Siqueira
On 10/17, Joe Perches wrote: > On Wed, 2018-10-17 at 19:51 -0300, Rodrigo Siqueira wrote: > > Add maintainers and reviewers for VKMS driver > > > > Signed-off-by: Rodrigo Siqueira > > --- > > MAINTAINERS | 10 ++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/MAINTAINERS b/MA

Re: [PATCH] drm: fix deadlock of syncobj

2018-10-19 Thread zhoucm1
On 2018年10月19日 18:50, Chris Wilson wrote: Quoting Chunming Zhou (2018-10-19 11:26:41) Signed-off-by: Chunming Zhou Cc: Daniel Vetter Cc: Chris Wilson Cc: Christian König --- drivers/gpu/drm/drm_syncobj.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/

Re: [PATCH] drm: fix deadlock of syncobj

2018-10-19 Thread zhoucm1
On 2018年10月19日 19:26, zhoucm1 wrote: On 2018年10月19日 18:50, Chris Wilson wrote: Quoting Chunming Zhou (2018-10-19 11:26:41) Signed-off-by: Chunming Zhou Cc: Daniel Vetter Cc: Chris Wilson Cc: Christian König ---   drivers/gpu/drm/drm_syncobj.c | 7 +--   1 file changed, 5 insertions(+

Re: [PATCH] drm: fix deadlock of syncobj

2018-10-19 Thread Koenig, Christian
Am 19.10.18 um 14:01 schrieb zhoucm1: > > > On 2018年10月19日 19:26, zhoucm1 wrote: >> >> >> On 2018年10月19日 18:50, Chris Wilson wrote: >>> Quoting Chunming Zhou (2018-10-19 11:26:41) Signed-off-by: Chunming Zhou Cc: Daniel Vetter Cc: Chris Wilson Cc: Christian König --- >>

[Bug 108496] Non functional -d, --dry-run option for the igt_runner

2018-10-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108496 Bug ID: 108496 Summary: Non functional -d, --dry-run option for the igt_runner Product: DRI Version: DRI git Hardware: Other OS: All Status: NEW Severity

Re: [PATCH] drm: fix deadlock of syncobj

2018-10-19 Thread zhoucm1
On 2018年10月19日 20:08, Koenig, Christian wrote: Am 19.10.18 um 14:01 schrieb zhoucm1: On 2018年10月19日 19:26, zhoucm1 wrote: On 2018年10月19日 18:50, Chris Wilson wrote: Quoting Chunming Zhou (2018-10-19 11:26:41) Signed-off-by: Chunming Zhou Cc: Daniel Vetter Cc: Chris Wilson Cc: Christian

Re: [PULL] drm-intel-next-fixes

2018-10-19 Thread Daniel Vetter
On Fri, Oct 19, 2018 at 12:38 PM Joonas Lahtinen wrote: > > Hi Dave, > > Here are the promised MST fixes that were missing due to being > in i915 tree, yet outside i915 directory. > > Further explanation in the previous PR's thread. fwiw, lgtm. Cheers, Daniel > > Regards, Joonas > > *** > > drm-

Re: [PATCH] drm: fix deadlock of syncobj

2018-10-19 Thread Christian König
Am 19.10.18 um 14:19 schrieb zhoucm1: On 2018年10月19日 20:08, Koenig, Christian wrote: Am 19.10.18 um 14:01 schrieb zhoucm1: On 2018年10月19日 19:26, zhoucm1 wrote: On 2018年10月19日 18:50, Chris Wilson wrote: Quoting Chunming Zhou (2018-10-19 11:26:41) Signed-off-by: Chunming Zhou Cc: Daniel V

Re: [PATCH v5 1/9] drm: fourcc: Convert drm_format_info kerneldoc to in-line member documentation

2018-10-19 Thread Maxime Ripard
On Fri, Oct 19, 2018 at 11:57:44AM +0100, Alexandru Gheorghe wrote: > In-line member documentation seems to be desired way of documenting > structure members. > > This change had been suggested by Daniel Vetter here: > https://lists.freedesktop.org/archives/dri-devel/2018-October/192176.html > >

[Bug 108498] ir_dereference_record nullptr segfault in radeonsi_dri.so

2018-10-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108498 Bug ID: 108498 Summary: ir_dereference_record nullptr segfault in radeonsi_dri.so Product: Mesa Version: 18.1 Hardware: x86-64 (AMD64) OS: Linux (All)

[Bug 108486] Incompatible result.json generation between igt_runner and piglit summary

2018-10-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108486 --- Comment #2 from Petri Latvala --- https://patchwork.freedesktop.org/series/51238/ sent for a fix. Won't merge it yet until it gets through the currently overloaded CI. -- You are receiving this mail because: You are the assignee for the bu

Re: [PATCH v5 2/9] drm/fourcc: Add char_per_block, block_w and block_h in drm_format_info

2018-10-19 Thread Brian Starkey
Hi Alex, On Fri, Oct 19, 2018 at 11:57:45AM +0100, Alexandru Gheorghe wrote: For some pixel formats .cpp structure in drm_format info it's not enough to describe the peculiarities of the pixel layout, for example tiled formats or packed formats at bit level. What's implemented here is to add th

Re: [PATCH v5 3/9] drm/fourcc: Add fourcc for Mali linear tiled formats

2018-10-19 Thread Brian Starkey
Hi Alex, On Fri, Oct 19, 2018 at 11:57:46AM +0100, Alexandru Gheorghe wrote: Mali-DP implements a number of tiled yuv formats which are not currently described in drm_fourcc.h. This adds those definitions and describes their memory layout by using the newly added char_per_block, block_w, block_h

Re: [PATCH v5 4/9] drm: mali-dp: Enable Mali-DP tiled buffer formats

2018-10-19 Thread Brian Starkey
Hi Alex, On Fri, Oct 19, 2018 at 11:57:47AM +0100, Alexandru Gheorghe wrote: Enable the following formats - DRM_FORMAT_X0L0: DP650 - DRM_FORMAT_X0L2: DP550, DP650 Signed-off-by: Alexandru Gheorghe A couple of suggestions below, but with or without you can add my r-b. --- drivers/gpu/drm/ar

[Bug 108487] Wayland compositors are unable to use hardware acceleration on i915: missing EGL_ANDROID_native_fence_sync extension

2018-10-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108487 Chris Wilson changed: What|Removed |Added Summary|Wayland compositors are |Wayland compositors are

Re: [PATCH v5 5/9] drm: Extend framebuffer_check to handle formats with cpp/char_per_block 0

2018-10-19 Thread Brian Starkey
Hi Alex, On Fri, Oct 19, 2018 at 11:57:48AM +0100, Alexandru Gheorghe wrote: For formats that are supported only with non-linear modifiers it doesn't make to much sense to define cpp or char_per_block, so that will be set to 0. This patch adds a restriction to force having a modifier attached w

[Bug 108498] ir_dereference_record nullptr segfault in radeonsi_dri.so

2018-10-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108498 Michel Dänzer changed: What|Removed |Added QA Contact|dri-devel@lists.freedesktop |intel-3d-bugs@lists.freedes

Re: [PATCH v2 2/2] drm/i915/intel_dsi: Read back pclk set by GOP and use that as pclk v2

2018-10-19 Thread Hans de Goede
Hi, On 19-10-18 11:20, Jani Nikula wrote: On Wed, 17 Oct 2018, Hans de Goede wrote: On BYT and CHT the GOP sometimes initializes the pclk at a (slightly) different frequency then the pclk which we've calculated. This commit makes the DSI code read-back the pclk set by the GOP and if that is w

Re: [PATCH 2/2] drm/panel: Add driver for Samsung S6D16D0 panel

2018-10-19 Thread Linus Walleij
Hi Andrzej, I was just looking at this (which confused me and was not fixed in v2): On Tue, Oct 9, 2018 at 8:46 PM Linus Walleij wrote: > On Tue, Oct 9, 2018 at 10:29 AM Andrzej Hajda wrote: > > On 08.10.2018 12:58, Linus Walleij wrote: > > > > +static const struct drm_display_mode samsung_s6d1

[PATCH v2] drm/atomic: integrate modeset lock with private objects

2018-10-19 Thread Boris Brezillon
From: Rob Clark Follow the same pattern of locking as with other state objects. This avoids boilerplate in the driver. Signed-off-by: Rob Clark Signed-off-by: Boris Brezillon --- Changes in v2: - Make sure all priv objs are locked from drm_modeset_lock_all_ctx(). This implies adding all priv

[Bug 108487] Wayland compositors are unable to use hardware acceleration on i915: missing EGL_ANDROID_native_fence_sync extension

2018-10-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108487 --- Comment #1 from Daniel Stone --- Chris, how do you make this as missing dma-fence support? -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-

[Bug 108487] Wayland compositors are unable to use hardware acceleration on i915: missing EGL_ANDROID_native_fence_sync extension

2018-10-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108487 --- Comment #2 from Chris Wilson --- Just realised I missed the "timeline" part of [17:35:45.463] warning: Disabling render GPU timeline due to missing EGL_ANDROID_native_fence_sync extension (read as "disabling render GPU due to missing exten

[Bug 108487] Wayland compositors are unable to use hardware acceleration on i915: missing EGL_ANDROID_native_fence_sync extension

2018-10-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108487 --- Comment #3 from Daniel Stone --- The fatal bit is probably the GBM surface creation: my guess is that the KMS driver exposes IN_MODIFIERS so we try to use gbm_surface_create_with_modifiers and when it fails because i915 Mesa is blissfully un

Re: [PATCH v2 2/2] drm/i915/intel_dsi: Read back pclk set by GOP and use that as pclk v2

2018-10-19 Thread Daniel Vetter
On Fri, Oct 19, 2018 at 03:49:15PM +0200, Hans de Goede wrote: > Hi, > > On 19-10-18 11:20, Jani Nikula wrote: > > On Wed, 17 Oct 2018, Hans de Goede wrote: > > > On BYT and CHT the GOP sometimes initializes the pclk at a (slightly) > > > different frequency then the pclk which we've calculated.

Re: [PATCH 1/3] drm/sched: Add callback to mark if sched is ready to work.

2018-10-19 Thread Grodzovsky, Andrey
Eclipse Andrey On 10/19/2018 03:13 AM, Michel Dänzer wrote: > ... and the new line here. > > Which editor are you using? ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 3/3] drm/amdgpu: Refresh rq selection for job after ASIC reset

2018-10-19 Thread Grodzovsky, Andrey
On 10/19/2018 03:08 AM, Koenig, Christian wrote: > Am 18.10.18 um 20:44 schrieb Andrey Grodzovsky: >> A ring might become unusable after reset, if that the case >> drm_sched_entity_select_rq will choose another, working rq >> to run the job if there is one. >> Also, skip recovery of ring which is

Re: [PATCH v2] drm/atomic: integrate modeset lock with private objects

2018-10-19 Thread Daniel Vetter
On Fri, Oct 19, 2018 at 03:55:03PM +0200, Boris Brezillon wrote: > From: Rob Clark > > Follow the same pattern of locking as with other state objects. This > avoids boilerplate in the driver. > > Signed-off-by: Rob Clark > Signed-off-by: Boris Brezillon > --- > Changes in v2: > - Make sure all

Re: [PATCH v5 8/9] drm/selftest: Refactor test-drm_plane_helper

2018-10-19 Thread Daniel Vetter
On Fri, Oct 19, 2018 at 11:57:51AM +0100, Alexandru Gheorghe wrote: > The idea is to split test implementations in different compilation > units, but have one single place where we define the list of tests, > in this case(drm_modeset_selftests.h). > > Signed-off-by: Alexandru Gheorghe > --- > ..

Re: [PATCH v5 9/9] drm/selftests: Add tests for drm_format_info* helpers

2018-10-19 Thread Daniel Vetter
On Fri, Oct 19, 2018 at 11:57:52AM +0100, Alexandru Gheorghe wrote: > Add selftests for the following newly added functions: > - drm_format_info_block_width > - drm_format_info_block_height > - drm_format_info_min_pitch > > Signed-off-by: Alexandru Gheorghe > --- > drivers/gpu/drm/selftests/M

  1   2   >