Re: [PATCH libdrm] intel: annotate the intel genx helpers as private

2018-09-13 Thread Chih-Wei Huang
Note this patch breaks drm_gralloc: FAILED: out/target/product/x86_64/obj_x86/SHARED_LIBRARIES/libgralloc_drm_intermediates/LINKED/libgralloc_drm.so /bin/bash -c "prebuilts/clang/host/linux-x86/clang-4053586/bin/clang++ -nostdlib -Wl,-soname,libgralloc_drm.so -Wl,--gc-sections -shared out/target/

Re: [PATCH 02/10] phy: Add configuration interface

2018-09-13 Thread Kishon Vijay Abraham I
Hi, On Thursday 06 September 2018 08:26 PM, Maxime Ripard wrote: > Hi Kishon, > > On Thu, Sep 06, 2018 at 02:57:58PM +0530, Kishon Vijay Abraham I wrote: >> On Wednesday 05 September 2018 02:46 PM, Maxime Ripard wrote: >>> The phy framework is only allowing to configure the power state of the PHY

[PATCH v2 15/24] powerpc/mm: move __P and __S tables in the common pgtable.h

2018-09-13 Thread Christophe Leroy
__P and __S flags are the same for all platform and should remain as is in the future, so avoid duplication. Reviewed-by: Aneesh Kumar K.V Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/book3s/64/pgtable.h | 20 arch/powerpc/include/asm/pgtable.h | 1

[PATCH v2 03/24] drivers/block/z2ram: use ioremap_wt() instead of __ioremap(_PAGE_WRITETHRU)

2018-09-13 Thread Christophe Leroy
_PAGE_WRITETHRU is a target specific flag. Prefer generic functions. Acked-by: Geert Uytterhoeven Signed-off-by: Christophe Leroy --- drivers/block/z2ram.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/block/z2ram.c b/drivers/block/z2ram.c index d0c5bc4e0703..cfb

Re: [PATCH] drm/amdgpu: Add braces to initialize task_info subojects

2018-09-13 Thread Nathan Chancellor
On Wed, Sep 12, 2018 at 10:38:30AM -0700, Nick Desaulniers wrote: > On Tue, Sep 11, 2018 at 5:26 PM Nathan Chancellor > wrote: > > > > Clang warns if there are missing braces around a subobject > > initializer. > > > > drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c:1447:41: warning: suggest braces > > arou

Re: [PATCH v3 1/3] udmabuf: add documentation

2018-09-13 Thread Randy Dunlap
Hi Gerd, Missed one from yesterday: On 9/11/18 11:33 PM, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > include/uapi/linux/udmabuf.h | 51 > +--- > Documentation/driver-api/dma-buf.rst | 8 ++ > 2 files changed, 56 insertions(+), 3 dele

[PATCH v2 05/24] powerpc: don't use ioremap_prot() nor __ioremap() unless really needed.

2018-09-13 Thread Christophe Leroy
In many places, ioremap_prot() and __ioremap() can be replaced with higher level functions like ioremap(), ioremap_coherent(), ioremap_cache(), ioremap_wc() ... Signed-off-by: Christophe Leroy --- arch/powerpc/kernel/btext.c | 2 +- arch/powerpc/kernel/crash_dump.c | 2 +-

Re: [PATCH v2 05/17] compat_ioctl: move more drivers to generic_compat_ioctl_ptrarg

2018-09-13 Thread Jason Gunthorpe
On Wed, Sep 12, 2018 at 05:08:52PM +0200, Arnd Bergmann wrote: > The .ioctl and .compat_ioctl file operations have the same prototype so > they can both point to the same function, which works great almost all > the time when all the commands are compatible. > > One exception is the s390 architect

Re: [PATCH] drm/amdgpu: Add braces to initialize task_info subojects

2018-09-13 Thread Nick Desaulniers
On Wed, Sep 12, 2018 at 1:24 PM Richard Smith wrote: > > On Wed, Sep 12, 2018 at 10:38 AM Nick Desaulniers > wrote: >> >> On Tue, Sep 11, 2018 at 5:26 PM Nathan Chancellor >> wrote: >> > >> > Clang warns if there are missing braces around a subobject >> > initializer. >> > >> > drivers/gpu/drm/

[PATCH v2 02/24] drivers/video/fbdev: use ioremap_wc/wt() instead of __ioremap()

2018-09-13 Thread Christophe Leroy
_PAGE_NO_CACHE is a platform specific flag. In addition, this flag is misleading because one would think it requests a noncached page whereas a noncached page is _PAGE_NO_CACHE | _PAGE_GUARDED _PAGE_NO_CACHE alone means write combined noncached page, so lets use ioremap_wc() instead. _PAGE_WRITET

[PATCH v2 22/24] powerpc/mm: Get rid of pte-common.h

2018-09-13 Thread Christophe Leroy
Do not include pte-common.h in nohash/32/pgtable.h As that was the last includer, get rid of pte-common.h Reviewed-by: Aneesh Kumar K.V Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/nohash/32/pgtable.h | 23 +-- arch/powerpc/include/asm/pte-common.h|

[PATCH v2 19/24] powerpc/nohash/64: do not include pte-common.h

2018-09-13 Thread Christophe Leroy
nohash/64 only uses book3e PTE flags, so it doesn't need pte-common.h This also allows to drop PAGE_SAO and H_PAGE_4K_PFN from pte_common.h as they are only used by PPC64 Reviewed-by: Aneesh Kumar K.V Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/nohash/64/pgtable.h | 16 +++

[PATCH v2 24/24] powerpc/book3s64: Avoid multiple endian conversion in pte helpers

2018-09-13 Thread Christophe Leroy
In the same spirit as already done in pte query helpers, this patch changes pte setting helpers to perform endian conversions on the constants rather than on the pte value. In the meantime, it changes pte_access_permitted() to use pte helpers for the same reason. Signed-off-by: Christophe Leroy

[PATCH v2 08/24] powerpc/mm: don't use _PAGE_EXEC in book3s/32

2018-09-13 Thread Christophe Leroy
book3s/32 doesn't define _PAGE_EXEC, so no need to use it. All other platforms define _PAGE_EXEC so no need to check it is not NUL when not book3s/32. Reviewed-by: Aneesh Kumar K.V Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/book3s/32/pgtable.h | 2 +- arch/powerpc/mm/pgtable.

[PATCH v2 00/24] ban the use of _PAGE_XXX flags outside platform specific code

2018-09-13 Thread Christophe Leroy
Today flags like for instance _PAGE_RW or _PAGE_USER are used through common parts of code. Using those directly in common parts of code have proven to lead to mistakes or misbehaviour, because their use is not always as trivial as one could think. For instance, (flags & _PAGE_USER) == 0 isn't eno

[PATCH v2 12/24] powerpc/mm: use pte helpers in generic code

2018-09-13 Thread Christophe Leroy
Get rid of platform specific _PAGE_ in powerpc common code and use helpers instead. mm/dump_linuxpagetables.c will be handled separately Reviewed-by: Aneesh Kumar K.V Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/book3s/32/pgtable.h | 9 +++-- arch/powerpc/include/asm/n

[PATCH] drm/i915/dp: fix shifting by a negative number of bits

2018-09-13 Thread Gustavo A. R. Silva
Function intel_port_to_tc() returns PORT_TC_NONE on error, which is a negative value -1. In case PORT_TC_NONE is returned, there is an undefined behavior when shifting by a negative number of bits in both DP_PHY_MODE_STATUS_NOT_SAFE and P_PHY_MODE_STATUS_COMPLETED macros. Fix this by adding sanity

[PATCH v2 07/24] powerpc: handover page flags with a pgprot_t parameter

2018-09-13 Thread Christophe Leroy
In order to avoid multiple conversions, handover directly a pgprot_t to map_kernel_page() as already done for radix. Do the same for __ioremap_caller() and __ioremap_at(). Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/book3s/32/pgtable.h | 2 +- arch/powerpc/include/asm/book3s/6

[PATCH v2 18/24] powerpc/mm: Distribute platform specific PAGE and PMD flags and definitions

2018-09-13 Thread Christophe Leroy
The base kernel PAGE_ definition sets are more or less platform specific. Lets distribute them close to platform _PAGE_XXX flags definition, and customise them to their exact platform flags. Also defines _PAGE_PSIZE and _PTE_NONE_MASK for each platform allthough they are defined as 0. Do the

[PATCH v2 16/24] powerpc/book3s/32: do not include pte-common.h

2018-09-13 Thread Christophe Leroy
As done for book3s/64, add necessary flags/defines in book3s/32/pgtable.h and do not include pte-common.h It allows in the meantime to remove all related hash definitions from pte-common.h and to also remove _PAGE_EXEC default as _PAGE_EXEC is defined on all platforms except book3s/32. Reviewed-b

[PATCH v2 20/24] powerpc/mm: Allow platforms to redefine some helpers

2018-09-13 Thread Christophe Leroy
The 40xx defines _PAGE_HWWRITE while others don't. The 8xx defines _PAGE_RO instead of _PAGE_RW. The 8xx defines _PAGE_PRIVILEGED instead of _PAGE_USER. The 8xx defines _PAGE_HUGE and _PAGE_NA while others don't. Lets those platforms redefine pte_write(), pte_wrprotect() and pte_mkwrite() and get

[PATCH v2 11/24] powerpc/mm: don't use _PAGE_EXEC for calling hash_preload()

2018-09-13 Thread Christophe Leroy
The 'access' parameter of hash_preload() is either 0 or _PAGE_EXEC. Among the two versions of hash_preload(), only the PPC64 one is doing something with this 'access' parameter. In order to remove the use of _PAGE_EXEC outside platform code, 'access' parameter is replaced by 'is_exec' which will b

Re: [PATCH] drm/amdgpu: Add braces to initialize task_info subojects

2018-09-13 Thread Nathan Chancellor
On Wed, Sep 12, 2018 at 02:44:34PM -0400, Alex Deucher wrote: > On Wed, Sep 12, 2018 at 2:40 PM Nathan Chancellor > wrote: > > > > On Wed, Sep 12, 2018 at 10:38:30AM -0700, Nick Desaulniers wrote: > > > On Tue, Sep 11, 2018 at 5:26 PM Nathan Chancellor > > > wrote: > > > > > > > > Clang warns if

Re: [PATCH 08/27] clk: sunxi-ng: Add support for H6 DE3 clocks

2018-09-13 Thread Jernej Škrabec
Dne sreda, 12. september 2018 ob 14:20:08 CEST je Chen-Yu Tsai napisal(a): > On Wed, Sep 5, 2018 at 1:46 AM Jernej Škrabec wrote: > > Dne torek, 04. september 2018 ob 11:04:21 CEST je Chen-Yu Tsai napisal(a): > > > On Sun, Sep 2, 2018 at 3:27 PM Jernej Skrabec > > > > wrote: > > > > Support for

[PATCH v2 14/24] powerpc/mm: drop unused page flags

2018-09-13 Thread Christophe Leroy
The following page flags in pte-common.h can be dropped: _PAGE_ENDIAN is only used in mm/fsl_booke_mmu.c and is defined in asm/nohash/32/pte-fsl-booke.h _PAGE_4K_PFN is nowhere defined nor used _PAGE_READ, _PAGE_WRITE and _PAGE_PTE are only defined and used in book3s/64 The following page flags

Re: [PATCH] drm/amdgpu: Add braces to initialize task_info subojects

2018-09-13 Thread Nathan Chancellor
On Wed, Sep 12, 2018 at 01:24:34PM -0700, Richard Smith wrote: > On Wed, Sep 12, 2018 at 10:38 AM Nick Desaulniers > wrote: > > > On Tue, Sep 11, 2018 at 5:26 PM Nathan Chancellor > > wrote: > > > > > > Clang warns if there are missing braces around a subobject > > > initializer. > > > > > > dri

[PATCH v2 06/24] powerpc/mm: properly set PAGE_KERNEL flags in ioremap()

2018-09-13 Thread Christophe Leroy
Set PAGE_KERNEL directly in the caller and do not rely on a hack adding PAGE_KERNEL flags when _PAGE_PRESENT is not set. As already done for PPC64, use pgprot_cache() helpers instead of _PAGE_XXX flags in PPC32 ioremap() derived functions. Signed-off-by: Christophe Leroy --- arch/powerpc/includ

[PATCH v2 10/24] powerpc/mm: add pte helpers to query and change pte flags

2018-09-13 Thread Christophe Leroy
In order to avoid using generic _PAGE_XXX flags in powerpc core functions, define helpers for all needed flags: - pte_mkuser() and pte_mkprivileged() to set/unset and/or unset/set _PAGE_USER and/or _PAGE_PRIVILEGED - pte_hashpte() to check if _PAGE_HASHPTE is set. - pte_ci() check if cache is inhib

Re: [linux-sunxi] Re: [PATCH 02/27] arm64: allwinner: h6: add system controller device tree node

2018-09-13 Thread Icenowy Zheng
于 2018年9月12日 GMT+08:00 下午10:49:12, Chen-Yu Tsai 写到: >On Tue, Sep 4, 2018 at 4:44 PM Icenowy Zheng wrote: >> >> >> >> 于 2018年9月4日 GMT+08:00 下午4:40:56, Chen-Yu Tsai 写到: >> >On Sun, Sep 2, 2018 at 3:27 PM Jernej Skrabec > >> >wrote: >> >> >> >> From: Icenowy Zheng >> >> >> >> As we have already

[PATCH v2 23/24] powerpc/8xx: change name of a few page flags to avoid confusion

2018-09-13 Thread Christophe Leroy
_PAGE_PRIVILEGED corresponds to the SH bit which doesn't protect against user access but only disables ASID verification on kernel accesses. User access is controlled with _PMD_USER flag. Name it _PAGE_SH instead of _PAGE_PRIVILEGED _PAGE_HUGE corresponds to the SPS bit which doesn't really tells

[PATCH v2 17/24] powerpc/mm: Move pte_user() into nohash/pgtable.h

2018-09-13 Thread Christophe Leroy
Now the pte-common.h is only for nohash platforms, lets move pte_user() helper out of pte-common.h to put it together with other helpers. Reviewed-by: Aneesh Kumar K.V Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/nohash/pgtable.h | 10 ++ arch/powerpc/include/asm/pte-com

Re: [PATCH] drm/amdgpu: Add braces to initialize task_info subojects

2018-09-13 Thread Nick Desaulniers
On Tue, Sep 11, 2018 at 5:26 PM Nathan Chancellor wrote: > > Clang warns if there are missing braces around a subobject > initializer. > > drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c:1447:41: warning: suggest braces > around initialization of subobject [-Wmissing-braces] > struct amdgpu_

[PATCH v2 21/24] powerpc/mm: Define platform default caches related flags

2018-09-13 Thread Christophe Leroy
Cache related flags like _PAGE_COHERENT and _PAGE_WRITETHRU are defined on most platforms. The platforms not defining them don't define any alternative. So we can give them a NUL value directly for those platforms directly. Reviewed-by: Aneesh Kumar K.V Signed-off-by: Christophe Leroy --- arch/

[PATCH v2 09/24] powerpc/mm: move some nohash pte helpers in nohash/[32:64]/pgtable.h

2018-09-13 Thread Christophe Leroy
In order to allow their use in nohash/32/pgtable.h, we have to move the following helpers in nohash/[32:64]/pgtable.h: - pte_mkwrite() - pte_mkdirty() - pte_mkyoung() - pte_wrprotect() Reviewed-by: Aneesh Kumar K.V Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/nohash/32/pgtable.h

[PATCH v2 04/24] soc/fsl/qbman: use ioremap_cache() instead of ioremap_prot(0)

2018-09-13 Thread Christophe Leroy
ioremap_prot() with flag set to 0 relies on a hack in __ioremap_caller() which adds PAGE_KERNEL flags when the handed flags don't look like a valid set of flags (ie don't include _PAGE_PRESENT) The intention being to map cached memory, use ioremap_cache() instead. Signed-off-by: Christophe Leroy

Re: [PATCH] [v3] drm/sun4i: fix build failure with CONFIG_DRM_SUN8I_MIXER=m

2018-09-13 Thread Matt Hart
On 7 September 2018 at 12:42, Maxime Ripard wrote: > On Fri, Sep 07, 2018 at 01:26:30PM +0200, Arnd Bergmann wrote: >> On Fri, Sep 7, 2018 at 11:41 AM Jon Hunter wrote: >> > >> > >> > On 11/07/18 15:43, Arnd Bergmann wrote: >> > > Having DRM_SUN4I built-in but DRM_SUN8I_MIXER as a loadable module

[PATCH v2 13/24] powerpc/mm: Split dump_pagelinuxtables flag_array table

2018-09-13 Thread Christophe Leroy
To reduce the complexity of flag_array, and allow the removal of default 0 value of non existing flags, lets have one flag_array table for each platform family with only the really existing flags. Reviewed-by: Aneesh Kumar K.V Signed-off-by: Christophe Leroy --- arch/powerpc/mm/Makefile

[PATCH v2 01/24] powerpc/32: Add ioremap_wt() and ioremap_coherent()

2018-09-13 Thread Christophe Leroy
Other arches have ioremap_wt() to map IO areas write-through. Implement it on PPC as well in order to avoid drivers using __ioremap(_PAGE_WRITETHRU) Also implement ioremap_coherent() to avoid drivers using __ioremap(_PAGE_COHERENT) Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/io

[PATCH v2] drm/amd: Properly initialize all subobjects in structures

2018-09-13 Thread Nathan Chancellor
Clang warns if there are missing braces around a subobject initializer. Adding these braces only initializes the first subobject; an empty set of braces initializes the structure and all of its subobjects. drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c:1447:41: warning: suggest braces around initialization

RE: [PATCH 1/3] [RFC]drm: add syncobj timeline support v4

2018-09-13 Thread Zhou, David(ChunMing)
> -Original Message- > From: Koenig, Christian > Sent: Thursday, September 13, 2018 2:56 PM > To: Zhou, David(ChunMing) ; Zhou, > David(ChunMing) ; dri- > de...@lists.freedesktop.org > Cc: Dave Airlie ; Rakos, Daniel > ; amd-...@lists.freedesktop.org > Subject: Re: [PATCH 1/3] [RFC]drm: a

[PATCH] MAINTAINERS: drm: Remove myself as drm-bridge maintainer

2018-09-13 Thread Archit Taneja
I have moved on to other stuff for now. Haven't been able to make time to review bridge related work. Andrzej has been doing it by himself for a while now. Cc: Andrzej Hajda Cc: Laurent Pinchart Cc: Gustavo Padovan Cc: Maarten Lankhorst Cc: Sean Paul Cc: Daniel Vetter Signed-off-by: Archit T

Re: [PATCH] drm/sun4i: fix build failure with CONFIG_DRM_SUN8I_MIXER=m

2018-09-13 Thread Maxime Ripard
On Wed, Sep 12, 2018 at 05:53:39PM +0200, Daniel Vetter wrote: > On Wed, Sep 12, 2018 at 5:47 PM, Maxime Ripard > wrote: > > On Wed, Sep 12, 2018 at 04:25:36PM +0200, Daniel Vetter wrote: > >> On Wed, Sep 12, 2018 at 11:53 AM, Maxime Ripard > >> wrote: > >> > On Tue, Sep 11, 2018 at 10:17:02PM +0

Re: [PATCH 0/2] intel: hide library symbols by default

2018-09-13 Thread Eric Engestrom
On Wednesday, 2018-09-12 14:05:34 -0700, Lucas De Marchi wrote: > Rely on -fvisibility=hidden to hide the symbols. This only applies to > drm_intel.so sice there's no point in extending this if it receives a > nack for some reason. For the same reason, only done on meson as well. > > drm_private c

Re: [PATCH 2/3] drm/exynos: scaler: Add support for tiled formats

2018-09-13 Thread Marek Szyprowski
Hi Inki, On 2018-09-13 07:14, Inki Dae wrote: > 2018년 09월 12일 15:59에 Andrzej Pietrasiewicz 이(가) 쓴 글: >> W dniu 12.09.2018 o 01:54, Inki Dae pisze: >>> Hi Marek and Andrzej, >>> >>> 2018년 08월 10일 22:29에 Marek Szyprowski 이(가) 쓴 글: From: Andrzej Pietrasiewicz Add support for 16x16 til

[PATCH 0/3] virtio-gpu: add VIRTIO_GPU_F_EDID feature

2018-09-13 Thread Gerd Hoffmann
Gerd Hoffmann (3): drm: virtual connectors can have edid too virtio-gpu: add VIRTIO_GPU_F_EDID feature drm/virtio: add edid support drivers/gpu/drm/virtio/virtgpu_drv.h | 3 ++ include/uapi/linux/virtio_gpu.h | 17 + drivers/gpu/drm/drm_connector.c | 3 +-

[PATCH 3/3] drm/virtio: add edid support

2018-09-13 Thread Gerd Hoffmann
linux guest driver implementation of the VIRTIO_GPU_F_EDID feature. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_drv.h | 3 ++ drivers/gpu/drm/virtio/virtgpu_display.c | 6 drivers/gpu/drm/virtio/virtgpu_drv.c | 1 + drivers/gpu/drm/virtio/virtgpu_kms.c |

[PATCH 2/3] virtio-gpu: add VIRTIO_GPU_F_EDID feature

2018-09-13 Thread Gerd Hoffmann
The feature allows the guest request an EDID blob (describing monitor capabilities) for a given scanout (aka virtual monitor connector). It brings a new command message, which has just a scanout field (beside the standard virtio-gpu header) and a response message which carries the EDID data. Sign

[PATCH 1/3] drm: virtual connectors can have edid too

2018-09-13 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/drm_connector.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c index 6011d769d5..95cbbf7ee5 100644 --- a/drivers/gpu/drm/drm_connector.c +++ b/drivers/gpu/drm/

Re: [PATCH] drm/sun4i: fix build failure with CONFIG_DRM_SUN8I_MIXER=m

2018-09-13 Thread Arnd Bergmann
On Thu, Sep 13, 2018 at 10:02 AM Maxime Ripard wrote: > On Wed, Sep 12, 2018 at 05:53:39PM +0200, Daniel Vetter wrote: > > On Wed, Sep 12, 2018 at 5:47 PM, Maxime Ripard > > wrote: > > > On Wed, Sep 12, 2018 at 04:25:36PM +0200, Daniel Vetter wrote: > > Yup, if you want to make drm_edid.c optiona

Re: [PATCH 2/3] drm/exynos: scaler: Add support for tiled formats

2018-09-13 Thread Inki Dae
Hi Marek, 2018년 09월 13일 17:03에 Marek Szyprowski 이(가) 쓴 글: > Hi Inki, > > On 2018-09-13 07:14, Inki Dae wrote: >> 2018년 09월 12일 15:59에 Andrzej Pietrasiewicz 이(가) 쓴 글: >>> W dniu 12.09.2018 o 01:54, Inki Dae pisze: Hi Marek and Andrzej, 2018년 08월 10일 22:29에 Marek Szyprowski 이(가) 쓴 글:

Re: [PATCH] drm/ttm: once more fix ttm_bo_bulk_move_lru_tail

2018-09-13 Thread Michel Dänzer
[ Moving to dri-devel, where TTM patches are reviewed ] On 2018-09-12 9:23 p.m., Christian König wrote: > While cutting the lists we sometimes accidentally added a list_head from > the stack to the LRUs, effectively corrupting the list. > > Remove the list cutting and use explicit list manipulat

Re: drm/imx: Crash in drm_mode_config_cleanup

2018-09-13 Thread Philipp Zabel
Hi Stefan, thank you for the report. I think what happens is the following: On Wed, 2018-09-12 at 15:26 -0700, Stefan Agner wrote: > Hi, > > While working on Apalis iMX6 with four displays, I encountered the > following crash: > [...] > [3.781163] imx-drm display-subsystem: bound 12.hdm

Re: [PATCH v2 6/8] drm/imx: support handling bridge timings bus flags

2018-09-13 Thread Philipp Zabel
On Wed, 2018-09-12 at 11:32 -0700, Stefan Agner wrote: > A bridge might require specific settings for the pixel data on > the bus. On which bus? The bridge has input and output. > Copy the bus flags from the bridge timings if a bridge > is in use. > > Signed-off-by: Stefan Agner > --- > driver

Re: [PATCH libdrm] intel: annotate the intel genx helpers as private

2018-09-13 Thread Eric Engestrom
On Thursday, 2018-09-13 15:19:00 +0800, Chih-Wei Huang wrote: > Note this patch breaks drm_gralloc: > > FAILED: > out/target/product/x86_64/obj_x86/SHARED_LIBRARIES/libgralloc_drm_intermediates/LINKED/libgralloc_drm.so > /bin/bash -c "prebuilts/clang/host/linux-x86/clang-4053586/bin/clang++ > -no

Re: [PATCH 2/3] drm/exynos: scaler: Add support for tiled formats

2018-09-13 Thread Marek Szyprowski
Hi Inki, On 2018-09-13 10:23, Inki Dae wrote: > 2018년 09월 13일 17:03에 Marek Szyprowski 이(가) 쓴 글: >> On 2018-09-13 07:14, Inki Dae wrote: >>> 2018년 09월 12일 15:59에 Andrzej Pietrasiewicz 이(가) 쓴 글: W dniu 12.09.2018 o 01:54, Inki Dae pisze: > Hi Marek and Andrzej, > > 2018년 08월 10일 22:

Re: [PATCH 1/3] [RFC]drm: add syncobj timeline support v4

2018-09-13 Thread Christian König
Am 13.09.2018 um 09:43 schrieb Zhou, David(ChunMing): -Original Message- From: Koenig, Christian Sent: Thursday, September 13, 2018 2:56 PM To: Zhou, David(ChunMing) ; Zhou, David(ChunMing) ; dri- de...@lists.freedesktop.org Cc: Dave Airlie ; Rakos, Daniel ; amd-...@lists.freedesktop.or

Re: [PATCH] drm/ttm: once more fix ttm_bo_bulk_move_lru_tail

2018-09-13 Thread Christian König
Am 13.09.2018 um 10:35 schrieb Michel Dänzer: [ Moving to dri-devel, where TTM patches are reviewed ] On 2018-09-12 9:23 p.m., Christian König wrote: While cutting the lists we sometimes accidentally added a list_head from the stack to the LRUs, effectively corrupting the list. Remove the list

Re: [PATCH] drm/ttm: once more fix ttm_bo_bulk_move_lru_tail

2018-09-13 Thread Michel Dänzer
On 2018-09-13 10:55 a.m., Christian König wrote: > Am 13.09.2018 um 10:35 schrieb Michel Dänzer: >> [ Moving to dri-devel, where TTM patches are reviewed ] >> >> On 2018-09-12 9:23 p.m., Christian König wrote: >>> While cutting the lists we sometimes accidentally added a list_head from >>> the stac

Re: [PATCH] drm/bridge: analogix_dp: Downgrade "Link Training" messages to dev_dbg

2018-09-13 Thread Andrzej Hajda
On 05.08.2018 19:28, Marc Zyngier wrote: > The Analogix DP bridge driver is pretty verbose, and outputs > things like > > [ 619.414067] rockchip-dp ff97.edp: Link Training Clock Recovery success > [ 619.429233] rockchip-dp ff97.edp: Link Training success! > > each time the display gets un

RE: [PATCH 1/3] [RFC]drm: add syncobj timeline support v4

2018-09-13 Thread Zhou, David(ChunMing)
> -Original Message- > From: Christian König > Sent: Thursday, September 13, 2018 4:50 PM > To: Zhou, David(ChunMing) ; Koenig, Christian > ; dri-devel@lists.freedesktop.org > Cc: Dave Airlie ; Rakos, Daniel > ; amd-...@lists.freedesktop.org > Subject: Re: [PATCH 1/3] [RFC]drm: add synco

Re: [PATCH v3 09/23] v4l: fwnode: Make use of newly specified bus types

2018-09-13 Thread jacopo mondi
Hi Sakari, On Thu, Sep 13, 2018 at 12:29:28AM +0300, Sakari Ailus wrote: > Add support for parsing CSI-2 D-PHY, parallel or Bt.656 bus explicitly. > > Signed-off-by: Sakari Ailus > Tested-by: Steve Longerbeam > --- > drivers/media/v4l2-core/v4l2-fwnode.c | 53 >

Re: [PATCH v3 15/23] v4l: fwnode: Use default parallel flags

2018-09-13 Thread jacopo mondi
Hi Sakari, On Thu, Sep 13, 2018 at 12:29:34AM +0300, Sakari Ailus wrote: > The caller may provide default flags for the endpoint. Change the > configuration based on what is available through the fwnode property API. > > Signed-off-by: Sakari Ailus > Tested-by: Steve Longerbeam Reviewed-by: Jac

Re: [PATCH 2/3] drm/exynos: scaler: Add support for tiled formats

2018-09-13 Thread Inki Dae
2018년 09월 13일 17:49에 Marek Szyprowski 이(가) 쓴 글: > Hi Inki, > > On 2018-09-13 10:23, Inki Dae wrote: >> 2018년 09월 13일 17:03에 Marek Szyprowski 이(가) 쓴 글: >>> On 2018-09-13 07:14, Inki Dae wrote: 2018년 09월 12일 15:59에 Andrzej Pietrasiewicz 이(가) 쓴 글: > W dniu 12.09.2018 o 01:54, Inki Dae pisz

Re: [PATCH 1/3] [RFC]drm: add syncobj timeline support v4

2018-09-13 Thread Christian König
Am 13.09.2018 um 11:11 schrieb Zhou, David(ChunMing): -Original Message- From: Christian König Sent: Thursday, September 13, 2018 4:50 PM To: Zhou, David(ChunMing) ; Koenig, Christian ; dri-devel@lists.freedesktop.org Cc: Dave Airlie ; Rakos, Daniel ; amd-...@lists.freedesktop.org Subj

Re: [PATCH] drm/i2c/tda9950.c: set MAX_RETRIES for errors only

2018-09-13 Thread Gustavo Padovan
Hi Hans, Thanks for the patch. On Mon, Aug 27, 2018 at 02:28:50PM +0200, Hans Verkuil wrote: > The CEC_TX_STATUS_MAX_RETRIES should be set for errors only to > prevent the CEC framework from retrying the transmit. If the > transmit was successful, then don't set this flag. > > Found by running '

Re: [PATCH v2 2/2] drm: bridge: document bridge attach/detach imbalance

2018-09-13 Thread Andrzej Hajda
On 06.08.2018 08:19, Peter Rosin wrote: > Since 4a878c03d562 ("drm: bridge: Detach bridge from encoder at encoder > cleanup time"), it is generally no longer correct to detach bridges from > encoders manually. Document that. > > Signed-off-by: Peter Rosin > --- > drivers/gpu/drm/drm_bridge.c | 4

Re: [PATCH] drm/i2c/tda9950.c: set MAX_RETRIES for errors only

2018-09-13 Thread Russell King - ARM Linux
Hi Hans, I'll pick it up in due course. Thanks. On Tue, Sep 11, 2018 at 08:41:59AM +0200, Hans Verkuil wrote: > Russell (or someone else), can you Ack this patch? I'd like to get this > for 4.20. > > Thanks! > > Hans > > On 08/27/2018 02:28 PM, Hans Verkuil wrote: > > The CEC_TX_STATUS_

RE: [PATCH 1/3] [RFC]drm: add syncobj timeline support v4

2018-09-13 Thread Zhou, David(ChunMing)
> -Original Message- > From: Koenig, Christian > Sent: Thursday, September 13, 2018 5:20 PM > To: Zhou, David(ChunMing) ; dri- > de...@lists.freedesktop.org > Cc: Dave Airlie ; Rakos, Daniel > ; amd-...@lists.freedesktop.org > Subject: Re: [PATCH 1/3] [RFC]drm: add syncobj timeline suppor

Re: [PATCH 1/4] MAINTAINERS: rcar-du: Add co-maintainer

2018-09-13 Thread jacopo mondi
Hi Kieran, Laurent On Mon, Aug 06, 2018 at 03:39:01PM +0100, Kieran Bingham wrote: > From: Kieran Bingham > > Add myself as a co-maintainer for the Renesas DRM drivers. > > Signed-off-by: Kieran Bingham > --- > Cc: Laurent Pinchart > Cc: dri-devel@lists.freedesktop.org > Cc: linux-renesas-...@v

[PATCH v3.1 09/23] v4l: fwnode: Make use of newly specified bus types

2018-09-13 Thread Sakari Ailus
Add support for parsing CSI-2 D-PHY, parallel or Bt.656 bus explicitly. Signed-off-by: Sakari Ailus Tested-by: Steve Longerbeam Reviewed-by: Jacopo Mondi --- since v3: - Use PARALLEL_MBUS_FLAGS where appropriate --- thanks, Jacopo! drivers/media/v4l2-core/v4l2-fwnode.c | 48 +

Re: [PATCH v3 16/23] v4l: fwnode: Initialise the V4L2 fwnode endpoints to zero

2018-09-13 Thread jacopo mondi
Hi Sakari, On Thu, Sep 13, 2018 at 12:29:35AM +0300, Sakari Ailus wrote: > Initialise the V4L2 fwnode endpoints to zero in all drivers using > v4l2_fwnode_endpoint_parse(). This prepares for setting default endpoint > flags as well as the bus type. Setting bus type to zero will continue to > guess

Re: [PATCH v3 00/23] V4L2 fwnode rework; support for default configuration

2018-09-13 Thread jacopo mondi
Hi Sakari, On Thu, Sep 13, 2018 at 12:29:19AM +0300, Sakari Ailus wrote: > Hello everyone, > > I've long thought the V4L2 fwnode framework requires some work (it's buggy > and it does not adequately serve common needs). This set should address in > particular these matters: > > - Most devices supp

Re: [PATCH v3 16/23] v4l: fwnode: Initialise the V4L2 fwnode endpoints to zero

2018-09-13 Thread Sakari Ailus
Hi Jacopo, On Thu, Sep 13, 2018 at 11:46:14AM +0200, jacopo mondi wrote: > Hi Sakari, > > On Thu, Sep 13, 2018 at 12:29:35AM +0300, Sakari Ailus wrote: > > Initialise the V4L2 fwnode endpoints to zero in all drivers using > > v4l2_fwnode_endpoint_parse(). This prepares for setting default endpoin

Re: [PATCH v3 1/5] drm/rockchip: prepare common code for cdns and rk dpi/dp driver

2018-09-13 Thread Andrzej Hajda
Hi Damian, Quite late but. On 28.08.2018 12:24, Damian Kos wrote: > - Extracted common fields from cdn_dp_device to a new cdns_mhdp_device > structure which will be used by two separate drivers later on. > - Moved some datatypes (audio_format, audio_info, vic_pxl_encoding_format, > video_info

Re: [PATCH v3 00/23] V4L2 fwnode rework; support for default configuration

2018-09-13 Thread Sakari Ailus
On Thu, Sep 13, 2018 at 11:54:50AM +0200, jacopo mondi wrote: > Hi Sakari, > > On Thu, Sep 13, 2018 at 12:29:19AM +0300, Sakari Ailus wrote: > > Hello everyone, > > > > I've long thought the V4L2 fwnode framework requires some work (it's buggy > > and it does not adequately serve common needs). Th

Re: [PATCH v3 16/23] v4l: fwnode: Initialise the V4L2 fwnode endpoints to zero

2018-09-13 Thread Sakari Ailus
On Thu, Sep 13, 2018 at 12:55:33PM +0300, Sakari Ailus wrote: > Hi Jacopo, > > On Thu, Sep 13, 2018 at 11:46:14AM +0200, jacopo mondi wrote: > > Hi Sakari, > > > > On Thu, Sep 13, 2018 at 12:29:35AM +0300, Sakari Ailus wrote: > > > Initialise the V4L2 fwnode endpoints to zero in all drivers using

Re: [PATCH 1/3] [RFC]drm: add syncobj timeline support v4

2018-09-13 Thread Christian König
Am 13.09.2018 um 11:35 schrieb Zhou, David(ChunMing): -Original Message- From: Koenig, Christian Sent: Thursday, September 13, 2018 5:20 PM To: Zhou, David(ChunMing) ; dri- de...@lists.freedesktop.org Cc: Dave Airlie ; Rakos, Daniel ; amd-...@lists.freedesktop.org Subject: Re: [PATCH 1/

[Bug 107607] Problems with MST display (REG_WAIT takes a while or times out)

2018-09-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107607 --- Comment #2 from tomas.v...@showmax.com --- I have (maybe?) the same issue ``` [ 36.787663] [drm:generic_reg_wait [amdgpu]] *ERROR* REG_WAIT timeout 10us * 3000 tries - enc1_stream_encoder_dp_blank line:800 [ 36.787785] WARNING: CPU: 2 PI

Re: [PATCH v3 2/5] drm/dp: fix link probing for devices supporting DP 1.4+

2018-09-13 Thread Andrzej Hajda
On 28.08.2018 12:24, Damian Kos wrote: > From: Quentin Schulz > > DP 1.4 introduced a DP_EXTENDED_RCVR_CAPA_FIELD_PRESENT bit in > DP_TRAINING_AUX_RD_INTERVAL register. If set, DPCD registers from DP_DPCD_REV > to DP_ADAPTER_CAP should be retrieved starting from DP_DPCD_REV_EXTENDED. > All registe

Re: [PATCH v3 3/5] drm/dp: make dp_link_status and dp_get_lane_status usable from outside of the core

2018-09-13 Thread Andrzej Hajda
On 28.08.2018 12:24, Damian Kos wrote: > From: Quentin Schulz > > dp_link_status and dp_get_lane_status are pretty generic and can be used for > other means, so let's make it "public". > > This adds drm_dp_link_status and drm_dp_get_lane_status to the header file and > add the appropriate EXPORT_S

[PATCH 1/2] list: introduce list_bulk_move_tail helper

2018-09-13 Thread Christian König
Move all entries between @first and including @last before @head. This is useful for LRU lists where a whole block of entries should be moved to the end of an list. Signed-off-by: Christian König --- include/linux/list.h | 23 +++ 1 file changed, 23 insertions(+) diff --git

[PATCH 2/2] drm/ttm: once more fix ttm_bo_bulk_move_lru_tail v2

2018-09-13 Thread Christian König
While cutting the lists we sometimes accidentally added a list_head from the stack to the LRUs, effectively corrupting the list. Remove the list cutting and use explicit list manipulation instead. v2: separate out new list_bulk_move_tail helper Signed-off-by: Christian König --- drivers/gpu/dr

Re: [PATCH v3 4/5] dt-bindings: drm/bridge Document Cadence MHDP DPI/DP bridge bindings

2018-09-13 Thread Andrzej Hajda
On 28.08.2018 12:24, Damian Kos wrote: > From: Quentin Schulz > > Signed-off-by: Damian Kos No commit message, no author's signoff. -- Regards Andrzej > --- > .../bindings/display/bridge/cdns,mhdp.txt | 43 +++ > 1 file changed, 43 insertions(+) > create mode 100644 > Doc

[PATCH 4/5] drm/bridge/synopsys/dw-hdmi.h: rename ADOBE to OP

2018-09-13 Thread Hans Verkuil
From: Hans Verkuil The CTA-861 standard renamed this from ADOBE to OP. Make the same change to sync with the standard. Signed-off-by: Hans Verkuil --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/synops

[PATCH 2/5] media colorspaces*.rst: rename AdobeRGB to opRGB

2018-09-13 Thread Hans Verkuil
From: Hans Verkuil Drop all Adobe references and use the official opRGB standard instead. Signed-off-by: Hans Verkuil --- Documentation/media/uapi/v4l/biblio.rst | 10 -- Documentation/media/uapi/v4l/colorspaces-defs.rst | 8 .../media/uapi/v4l/colorspaces-detai

[PATCH 1/5] media: replace ADOBERGB by OPRGB

2018-09-13 Thread Hans Verkuil
From: Hans Verkuil The CTA-861 standards have been updated to refer to opRGB instead of AdobeRGB. The official standard is in fact named opRGB, so switch to that. The two old defines referring to ADOBERGB in the public API are put under #ifndef __KERNEL__ and a comment mentions that they are dep

[PATCH 5/5] drm/amd: rename ADOBE to OP

2018-09-13 Thread Hans Verkuil
From: Hans Verkuil The CTA-861 standard renamed ADOBE to OP, so do the same to remain in sync with the standard. Signed-off-by: Hans Verkuil Cc: amd-...@lists.freedesktop.org --- drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c | 4 ++-- drivers/gpu/drm/amd/display/dc/core/dc_resour

[PATCH 0/5] Rename AdobeRGB to opRGB

2018-09-13 Thread Hans Verkuil
From: Hans Verkuil This patch series replaces all AdobeRGB references by opRGB references. In November last year all references to the AdobeRGB colorspace were removed from the CTA-861 standards (all versions) and replaced with the corresponding international opRGB standard (IEC 61966-2-5) due t

[PATCH 3/5] hdmi.h: rename ADOBE_RGB to OPRGB and ADOBE_YCC to OPYCC

2018-09-13 Thread Hans Verkuil
From: Hans Verkuil These names have been renamed in the CTA-861 standard due to trademark issues. Replace them here as well so they are in sync with the standard. Signed-off-by: Hans Verkuil --- drivers/media/i2c/adv7511.c | 4 ++-- drivers/media/v4l2-core/v4l2-dv-timings.c | 4 +

[PATCH -fixes 2/5] drm/vmwgfx: limit screen size to stdu_max during check_modeset

2018-09-13 Thread Thomas Hellstrom
From: Deepak Rawat For STDU individual screen target size is limited by SVGA_REG_SCREENTARGET_MAX_WIDTH/HEIGHT registers so add that limit during atomic check_modeset. An additional limit is placed in the update_layout ioctl to avoid requesting layouts that current user-space typically can't sup

[PATCH -fixes 1/5] drm/vmwgfx: don't check for old_crtc_state enable status

2018-09-13 Thread Thomas Hellstrom
From: Deepak Rawat During atomic check to prepare the new topology no need to check if old_crtc_state was enabled or not. This will cause atomic_check to fail because due to connector routing a crtc can be in atomic_state even if there was no change to enable status. Detected this issue with igt

[PATCH -fixes 3/5] drm/vmwgfx: limit mode size for all display unit to texture_max

2018-09-13 Thread Thomas Hellstrom
From: Deepak Rawat For all display units, limit mode size exposed to texture_max_width/ height as this is the maximum framebuffer size that virtual device can create. Signed-off-by: Deepak Rawat Reviewed-by: Sinclair Yeh Reviewed-by: Thomas Hellstrom Signed-off-by: Thomas Hellstrom --- driv

[PATCH -fixes 5/5] drm/vmwgfx: Fix a buffer object eviction regression

2018-09-13 Thread Thomas Hellstrom
Commit 4eb085e42fde ("drm/vmwgfx: Convert to new IDA API") indroduced an incorrect return value from the function vmw_gmrid_man_get_node(), when we run out if integer ids. Instead of returning 0 (meaning non-fatal error) we forward the ida_simple_get error code -ENOSPC. This causes TTM not to retry

[PATCH -fixes 4/5] drm/vmwgfx: Don't impose STDU limits on framebuffer size

2018-09-13 Thread Thomas Hellstrom
From: Deepak Rawat If framebuffers are larger, we create bounce surfaces that are within STDU limits. Signed-off-by: Deepak Rawat Reviewed-by: Thomas Hellstrom Signed-off-by: Thomas Hellstrom --- drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c| 25 - drivers/gpu/drm/vmwgfx/v

Re: [PATCH v3 5/5] drm/bridge: add preliminary driver for cadence dpi/dp bridge

2018-09-13 Thread Heiko Stuebner
Am Dienstag, 28. August 2018, 12:24:48 CEST schrieb Damian Kos: > From: Quentin Schulz > > This patch finally adds the preliminary driver for Cadence MHDP DPI/DP bridge. > > Changes made in the low level driver (cdn-dp-reg.*): > - moved it to from drivers/gpu/drm/rockchip to > drivers/gpu/drm/

Re: [PATCH v3 0/5] drm: add support for Cadence MHDP DPI/DP bridge.

2018-09-13 Thread Heiko Stuebner
Am Dienstag, 28. August 2018, 12:24:43 CEST schrieb Damian Kos: > Hello! > > This is the series of patches that will add support for the Cadence's DPI/DP > bridge. Please note that this is a preliminary version of the driver and there > will be more patches in the future with updates, fixes and im

Re: [PATCH 04/16] drm: bridge: thc63: Restrict modes based on hardware operating frequency

2018-09-13 Thread Andrzej Hajda
On 04.09.2018 14:10, Laurent Pinchart wrote: > The THC63LVD1024 is restricted to a pixel clock frequency in the range > of 8 to 135 MHz. Implement the bridge .mode_valid() operation > accordingly. > > Signed-off-by: Laurent Pinchart Reviewed-by: Andrzej Hajda  -- Regards Andrzej _

[PULL] drm-misc-next

2018-09-13 Thread Sean Paul
Hi Dave, Coming to you from stormy North Carolina! It looks like Florence will wrap right around us, so hopefully no drm-misc service interruptions will occur in the next week :-) Quite a lot of activity this week, both in volume and UAPI. Two of the line items in UAPI section are functionality c

[PATCH 2/2] drm/i915: Clear DRIVER_ATOMIC on a per-device basis

2018-09-13 Thread Ville Syrjala
From: Ville Syrjälä Currently we're clearing DRIVER_ATOMIC in driver.driver_features for older platforms. This will not work correctly should we ever have a system with and old and new GPU in it. While that is not possible currently let's make the code more correct and use the per-device driver_f

Re: [PATCH] drm/i2c/tda9950.c: set MAX_RETRIES for errors only

2018-09-13 Thread Daniel Vetter
On Thu, Sep 13, 2018 at 10:33:35AM +0100, Russell King - ARM Linux wrote: > Hi Hans, > > I'll pick it up in due course. > > Thanks. > > On Tue, Sep 11, 2018 at 08:41:59AM +0200, Hans Verkuil wrote: > > Russell (or someone else), can you Ack this patch? I'd like to get this > > for 4.20. > > > >

  1   2   >