Re: [PATCH] drm/fourcc: Add DOC: overview comment

2018-08-24 Thread Matthew Wilcox
On Wed, Aug 22, 2018 at 04:57:33PM +0100, Brian Starkey wrote: > On Wed, Aug 22, 2018 at 05:11:55PM +0200, Daniel Vetter wrote: > > On Wed, Aug 22, 2018 at 4:59 PM, Eric Engestrom > > wrote: > > > On Tuesday, 2018-08-21 17:44:17 +0100, Brian Starkey wrote: > > > > On Tue, Aug 21, 2018 at 09:26:39A

[PATCH 2/4] drm: rcar-du: Write OTAR for DPAD channels only

2018-08-24 Thread Jacopo Mondi
According to revision 1.00 of R-Car Gen3 SoC manual, writing to OTAR register is valid only if the channel is equipped with a digital output pad (DPAD). Signed-off-by: Jacopo Mondi --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/

[PATCH] drm/sun4i: tcon-top: Use struct_size() in devm_kzalloc()

2018-08-24 Thread Gustavo A. R. Silva
One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example: struct foo { int stuff; void *entry[]; }; instance = devm_kzalloc(dev,

Re: [PATCH v2 1/5] drm/vc4: Fix TILE_Y_OFFSET definitions

2018-08-24 Thread Boris Brezillon
On Fri, 3 Aug 2018 11:22:27 +0200 Boris Brezillon wrote: > From: Eric Anholt > > Y_OFFSET field starts at bit 8 not 7. > > Signed-off-by: Eric Anholt > Signed-off-by: Boris Brezillon As discussed with Eric 2 weeks ago, I'm about to apply this series to drm-misc-fixes. The rational behind t

[PATCH 4/4] drm: rcar-du: Fix handling of PnMR register

2018-08-24 Thread Jacopo Mondi
According to revision 1.00 of R-Car Gen3 Soc manual, setting bits PnMR[13:12] is only valid if the DU group has two channels. It is then valid writing to PnMR[13:12] for: R-Car H3 = DU group 0 and DU group 1 R-Car M3-W, M3-N: DU group 0 only R-Car D3/E3: DU group 0 (no group 1) It is always inval

Re: [PATCH] drm/sun4i: tcon-top: Use struct_size() in devm_kzalloc()

2018-08-24 Thread Kees Cook
On Thu, Aug 23, 2018 at 6:05 PM, Gustavo A. R. Silva wrote: > One of the more common cases of allocation size calculations is finding > the size of a structure that has a zero-sized array at the end, along > with memory for some number of elements for that array. For example: > > struct foo { >

[PATCH 3/4] drm: rcar-du: Fix handling of DORCR for group 1

2018-08-24 Thread Jacopo Mondi
According to revision 1.00 of R-Car Gen3 Soc manual, only DU channels of group 0 (DU0 and DU1) supports output control routing through register DORCR0. For channels of group 1 (DU2 and DU3) which are only present on H3/M3-W/M3-N SoCs, no routing options are available between super-imposition proce

[PATCH 1/4] drm: rcar-du: Do not write ESCR for DPLL channels

2018-08-24 Thread Jacopo Mondi
According to revision 1.00 of R-Car Gen3 Soc manual, writing to ESCR register of DU channels equipped with a display PLL (DPLL) is invalid. Fix this by writing ESCR only for channels making use of the DU internal post-divider to generate the dotclockout signal, with R-Car H3 ES1.x being a notable

[PATCH] drm/vkms: Fix race condition around accessing frame number

2018-08-24 Thread Haneen Mohammed
crtc_state is accessed by both vblank_handle() and the ordered work_struct handle vkms_crc_work_handle() to retrieve and or update the frame number for computed CRC. Since work_struct can fail, add frame_end to account for missing frame numbers. use atomic_t witth appropriate flags for synchroniz

[PATCH 0/4] drm: rcar-du: Update to SoC manual revision 1.00

2018-08-24 Thread Jacopo Mondi
Hello Laurent, Revision 1.00 has brought several updates on how to handle some registers in the DU. In particular - ESCR cannot be written for channels with a DPLL - OTAR cannot be written for channels without a digital output pad - routing superimposition processor output to pincontrollers thr

Re: [Linux-graphics-maintainer] [PATCH] drm/vmwgfx: Fix potential Spectre v1

2018-08-24 Thread Gustavo A. R. Silva
Hi all, On 8/21/18 3:19 AM, Thomas Hellstrom wrote: >>>   #include "vmwgfx_drv.h" >>>   #include "vmwgfx_reg.h" >>> @@ -4520,8 +4521,10 @@ int vmw_execbuf_ioctl(struct drm_device *dev, >>> unsigned long data, >>>   return -EINVAL; >>>   } >>> >>> -    if (arg.version > 1 && >>> - 

Re: [PATCH (repost) 5/5] drm/amdgpu: add DisplayPort CEC-Tunneling-over-AUX support

2018-08-24 Thread Hans Verkuil
On 08/23/2018 08:38 PM, Harry Wentland wrote: > On 2018-08-17 10:11 AM, Hans Verkuil wrote: >> From: Hans Verkuil >> >> Add DisplayPort CEC-Tunneling-over-AUX support to amdgpu. >> >> Signed-off-by: Hans Verkuil >> Acked-by: Alex Deucher >> --- >> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm

Re: [PATCH 1/1] drm/ttm: Set memory as decrypted for ttm framebuffer mappings

2018-08-24 Thread Christian König
Am 24.08.2018 um 01:05 schrieb Jiandi An: On 08/23/2018 01:47 AM, Christian König wrote: Am 22.08.2018 um 22:57 schrieb Jiandi An: On 08/22/2018 02:09 PM, Christian König wrote: Am 22.08.2018 um 20:57 schrieb Jiandi An: Framebuffer memory needs to be accessed decrypted.  Ensure the memory

Re: [igt-dev] [PATCH v2 1/3] lib/igt_kms: Add try_prop_enum and set_prop_enum for mode objects, v2.

2018-08-24 Thread Mika Kahola
Looks ok to me. Reviewed-by: Mika Kahola On Wed, 2018-08-15 at 12:08 +0200, Maarten Lankhorst wrote: > This adds the possibility to test arbitrary enumerations in IGT > without > having to define mappings for each and every one. > > Changes since v1: > - Add commit description. > - Add try_prop

[Bug 107545] radeon - ring 0 stalled - GPU lockup - SI

2018-08-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107545 --- Comment #9 from Michel Dänzer --- (In reply to Christopher from comment #7) > After I first boot into gnome, with it running on xorg, as soon as I have > logged in and click on activities on the gnome menu and select terminal, > then the lit

[Bug 107627] Shader cache causes Dota 2 crashes on amdgpu

2018-08-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107627 Daniel Stone changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVALID

Re: [PATCH v2 1/5] drm/vc4: Fix TILE_Y_OFFSET definitions

2018-08-24 Thread Boris Brezillon
On Fri, 24 Aug 2018 09:09:26 +0200 Boris Brezillon wrote: > On Fri, 3 Aug 2018 11:22:27 +0200 > Boris Brezillon wrote: > > > From: Eric Anholt > > > > Y_OFFSET field starts at bit 8 not 7. > > > > Signed-off-by: Eric Anholt > > Signed-off-by: Boris Brezillon > > As discussed with Eric

Re: [PATCH v8 3/4] drm/atmel-hlcdc: iterate over all output endpoints

2018-08-24 Thread Boris Brezillon
On Tue, 14 Aug 2018 17:05:29 +0200 Peter Rosin wrote: > >> @@ -77,13 +79,29 @@ static int atmel_hlcdc_attach_endpoint(struct > >> drm_device *dev, int endpoint) > >> > >> int atmel_hlcdc_create_outputs(struct drm_device *dev) > >> { > >> -int endpoint, ret = 0; > >>

Re: [PATCH] drm: Fix crtc color management when doing suspend/resume

2018-08-24 Thread Maarten Lankhorst
Op 23-08-18 om 17:11 schreef Alexandru Gheorghe: > When doing suspend/resume drivers usually use the > drm_atomic_helper_suspend/drm_atomic_helper_resume pair for saving the > state and then re-comitting it. > > The problems is that drm_crtc_state has a bool field called > color_mgmt_changed, which

Re: [PATCH v8 0/4] drm/atmel-hlcdc: bus-width override support

2018-08-24 Thread Boris Brezillon
Hi Peter, On Fri, 10 Aug 2018 15:03:55 +0200 Peter Rosin wrote: > Hi! > > The background for these patches is that our PCB interface between > the SAMA5D3 and the ds90c185 lvds encoder is only using 16 bits, and > this has to be described somewhere, or the atmel-hlcdc driver have no > chance of

Re: atmel-hlcdc select pixel-clock outside of given range

2018-08-24 Thread Boris Brezillon
Hi Peter, On Wed, 22 Aug 2018 13:50:47 +0200 Peter Rosin wrote: > Hi! > > I just discovered that the atmel-hlcdc driver picks a pixel-clock > way outside the given range when used with a panel with these > timings from the device tree. > > panel-timing { > // 1024x768 @ 60H

Re: [ANNOUNCE] libdrm 2.4.94

2018-08-24 Thread Michel Dänzer
On 2018-08-24 12:37 a.m., Kristian H. Kristensen wrote: > Benjamin Gaignard (2): > tests/modetest: Add atomic support > tests/util: Add support for stm module > > Christian König (7): > amdgpu: stop using the hash table for fd_tab > amdgpu: add handle table implementation v

Re: [PATCH v1 3/7] mfd: add atmel-lcdc driver

2018-08-24 Thread Boris Brezillon
Hi Lee, On Wed, 15 Aug 2018 06:24:35 +0100 Lee Jones wrote: > > +static const struct mfd_cell lcdc_cells[] = { > > + { > > + .name = "atmel-lcdc-pwm", > > + .of_compatible = "atmel,lcdc-pwm", > > + }, > > + { > > + .name = "atmel-lcdc-dc", > > + .of_

Re: [PATCH] drm: Fix crtc color management when doing suspend/resume

2018-08-24 Thread Alexandru-Cosmin Gheorghe
Hi, On Fri, Aug 24, 2018 at 09:51:03AM +0200, Maarten Lankhorst wrote: > Op 23-08-18 om 17:11 schreef Alexandru Gheorghe: > > When doing suspend/resume drivers usually use the > > drm_atomic_helper_suspend/drm_atomic_helper_resume pair for saving the > > state and then re-comitting it. > > > > The

Re: [RFC PATCH 0/7] add at91sam9 LCDC DRM driver

2018-08-24 Thread Boris Brezillon
Hi Sam, On Sun, 12 Aug 2018 20:41:52 +0200 Sam Ravnborg wrote: > New DRM based driver for at91sam9 SOC's that uses the > Atmel LCDC IP core. First of all, thanks for this contribution. > > This is first version of a patch set that adds > drivers for the Atmel LCDC IP core. > Posted for review

Re: [PATCH v1 1/7] atmel-hlcdc: renamed directory to drm/atmel/

2018-08-24 Thread Boris Brezillon
On Sun, 12 Aug 2018 20:46:23 +0200 Sam Ravnborg wrote: > Use vendor name for directory, adding a suitable place > for more atmel DRM drivers. > > Signed-off-by: Sam Ravnborg > Cc: Boris Brezillon > --- > MAINTAINERS | 2 +- > drivers/gpu/drm/Kco

Re: [PATCH v1 3/7] mfd: add atmel-lcdc driver

2018-08-24 Thread Boris Brezillon
On Thu, 16 Aug 2018 10:28:54 +0200 Nicolas Ferre wrote: > On 15/08/2018 at 22:40, Sam Ravnborg wrote: > > Hi Lee. > > > >>> + > >>> +static const struct mfd_cell lcdc_cells[] = { > >>> + { > >>> + .name = "atmel-lcdc-pwm", > >>> + .of_compatible = "atmel,lcdc-pwm", > >>> + }, >

Re: [PATCH v1 2/7] dt-binding: add bindings for Atmel LCDC mfd

2018-08-24 Thread Boris Brezillon
On Sun, 12 Aug 2018 20:46:24 +0200 Sam Ravnborg wrote: > The LCDC IP used by some Atmel SOC's have a > multifunction device that include two sub-devices: > - pwm > - display controller > > This binding describe the multi function device > that act as root for the sub-devices > > The Atmel SOC's

Re: [PATCH v1 3/7] mfd: add atmel-lcdc driver

2018-08-24 Thread Boris Brezillon
On Sun, 12 Aug 2018 20:46:25 +0200 Sam Ravnborg wrote: > The LCDC IP used by some Atmel SOC's have a > multifunction device that include two sub-devices: > - pwm > - display controller > > This mfd device provide a regmap that can be used by the > sub-devices to safely access the reg

[PATCH RFC] drm: omapdrm: do not allow kmalloc to fail

2018-08-24 Thread Nicholas Mc Guire
cinelle script Patch was compile tested with: omap2plus_defconfig (implies OMAP2_DSS_INIT=y) Patch is against 4.18 (localversion-next is next-20180824) drivers/gpu/drm/omapdrm/dss/omapdss-boot-init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/omapdrm/ds

Re: [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-24 Thread Laurent Pinchart
Hi John, On Friday, 24 August 2018 00:12:46 EEST John Stultz wrote: > On Thu, Aug 23, 2018 at 1:49 PM, Laurent Pinchart wrote: > > On Thursday, 23 August 2018 20:48:40 EEST John Stultz wrote: > >> On Thu, Aug 23, 2018 at 1:09 AM, Daniel Vetter wrote: > >>> On Thu, Aug 23, 2018 at 10:46:15AM +0300

Re: [PATCH 1/2] drm/atmel-hlcdc: prefer a higher rate clock as pixel-clock base

2018-08-24 Thread Boris Brezillon
On Fri, 24 Aug 2018 10:55:00 +0200 Peter Rosin wrote: > If the divider used to get the pixel-clock is small, the granularity > of the frequencies possible for the pixel-clock is quite coarse. E.g. > requesting a pixel-clock of 65MHz with a sys_clk of 132MHz results > in the divider being set to 3

[Bug 107545] radeon - ring 0 stalled - GPU lockup - SI

2018-08-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107545 --- Comment #10 from Christopher --- (In reply to Michel Dänzer from comment #9) > (In reply to Christopher from comment #7) > > After I first boot into gnome, with it running on xorg, as soon as I have > > logged in and click on activities on t

Re: [PATCH 2/2] drm/atmel-hlcdc: allow selecting a higher pixel-clock that requested

2018-08-24 Thread Boris Brezillon
On Fri, 24 Aug 2018 10:55:01 +0200 Peter Rosin wrote: > But only if the highest pixel-clock frequency lower than requested > is significantly much less accurate that the lowest frequency higher > than requested. > > I pulled "10 times" as the discriminator out of the hat, and went with > that.

Re: [PATCH] drm: Fix crtc color management when doing suspend/resume

2018-08-24 Thread Maarten Lankhorst
Op 24-08-18 om 10:18 schreef Alexandru-Cosmin Gheorghe: > Hi, > > On Fri, Aug 24, 2018 at 09:51:03AM +0200, Maarten Lankhorst wrote: >> Op 23-08-18 om 17:11 schreef Alexandru Gheorghe: >>> When doing suspend/resume drivers usually use the >>> drm_atomic_helper_suspend/drm_atomic_helper_resume pair

Re: [Intel-gfx] [PATCH 4/4] drm/i915: enable P010, P012, P016 formats for primary and sprite planes

2018-08-24 Thread Sharma, Swati2
On 16-Aug-18 9:21 PM, Maarten Lankhorst wrote: Op 16-08-18 om 14:55 schreef Juha-Pekka Heikkila: Enabling of P010, P012 and P016 formats. These formats will extend NV12 for larger bit depths. Signed-off-by: Juha-Pekka Heikkila Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_

Re: [Freedreno] [PATCH 5/5] drm/msm/A6x: Add devfreq support in A6x

2018-08-24 Thread Sharat Masetty
On 8/23/2018 9:30 PM, Jordan Crouse wrote: On Thu, Aug 23, 2018 at 02:48:31PM +0530, Sharat Masetty wrote: Implement routines to estimate GPU busy time and fetching the current frequency for the polling interval. This is required by the devfreq framework which recommends a frequency change if

[Bug 106707] [CI] igt@gem_exec_schedule@deep-* - fail - Failed assertion: __vgem_fence_signal(fd, fence) == 0

2018-08-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106707 Lakshmi changed: What|Removed |Added Status|RESOLVED|CLOSED --- Comment #12 from Lakshmi --- Clos

Re: [PATCH v1 3/7] mfd: add atmel-lcdc driver

2018-08-24 Thread Lee Jones
On Fri, 24 Aug 2018, Boris Brezillon wrote: > Hi Lee, > > On Wed, 15 Aug 2018 06:24:35 +0100 > Lee Jones wrote: > > > > +static const struct mfd_cell lcdc_cells[] = { > > > + { > > > + .name = "atmel-lcdc-pwm", > > > + .of_compatible = "atmel,lcdc-pwm", > > > + }, > > > + { > >

[Bug 107337] [CI][DRMTIP] igt@kms_3d - fail - Failed assertion: debugfs_fd != -1 / Last errno: 2, No such file or directory

2018-08-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107337 Lakshmi changed: What|Removed |Added Status|RESOLVED|CLOSED --- Comment #2 from Lakshmi --- Last

Re: [PATCH 1/2] dt-bindings: display: renesas: lvds: document R8A77980 bindings

2018-08-24 Thread Laurent Pinchart
Hi Sergei, Thank you for the patch. On Tuesday, 5 June 2018 23:28:58 EEST Sergei Shtylyov wrote: > Document the R-Car V3H (R8A77980) SoC in the R-Car LVDS bindings. > > Signed-off-by: Sergei Shtylyov Reviewed-by: Laurent Pinchart and taken in my tree. > --- > Documentation/devicetree/bindi

Re: [PATCH 2/2] drm: rcar-du: lvds: add R8A77980 support

2018-08-24 Thread Laurent Pinchart
Hi Sergei, Thank you for the patch. On Tuesday, 5 June 2018 23:30:36 EEST Sergei Shtylyov wrote: > Add support for the R-Car V3H (R8A77980) SoC to the LVDS encoder driver. > > Signed-off-by: Sergei Shtylyov Reviewed-by: Laurent Pinchart and applied to my tree. > --- > drivers/gpu/drm/rcar-

Re: [PATCH 0/2] Add R-Car V3H (R8A77980) support to the R-Car LVDS driver

2018-08-24 Thread Laurent Pinchart
Hi Sergei, On Thursday, 23 August 2018 19:53:33 EEST Sergei Shtylyov wrote: > On 06/05/2018 11:25 PM, Sergei Shtylyov wrote: > > Here's the set of 2 patches against the 'drm-next' branch of the 'drm.git' > > repo. The purpose of these patches is to add the R-Car V3H (R8A77980) > > support to the R

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Michal Hocko
On Fri 24-08-18 19:54:19, Tetsuo Handa wrote: > Two more worries for this patch. > > > > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c > > @@ -178,12 +178,18 @@ void amdgpu_mn_unlock(struct amdgpu_mn *mn) > > * > > * @amn: our notifier > >

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Michal Hocko
On Fri 24-08-18 19:54:19, Tetsuo Handa wrote: [...] > > --- a/mm/hmm.c > > +++ b/mm/hmm.c > > @@ -177,16 +177,19 @@ static void hmm_release(struct mmu_notifier *mn, > > struct mm_struct *mm) > > up_write(&hmm->mirrors_sem); > > } > > > > -static void hmm_invalidate_range_start(struct mmu

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Christian König
Am 24.08.2018 um 13:32 schrieb Michal Hocko: On Fri 24-08-18 19:54:19, Tetsuo Handa wrote: Two more worries for this patch. --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c @@ -178,12 +178,18 @@ void amdgpu_mn_unlock(struct amdgpu_mn *mn) * * @a

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Michal Hocko
On Fri 24-08-18 13:43:16, Christian König wrote: > Am 24.08.2018 um 13:32 schrieb Michal Hocko: > > On Fri 24-08-18 19:54:19, Tetsuo Handa wrote: > > > Two more worries for this patch. > > > > > > > > > > > > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c > > > > +++ b/drivers/gpu/drm/amd/amdgpu

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Christian König
Am 24.08.2018 um 13:52 schrieb Michal Hocko: On Fri 24-08-18 13:43:16, Christian König wrote: Am 24.08.2018 um 13:32 schrieb Michal Hocko: On Fri 24-08-18 19:54:19, Tetsuo Handa wrote: Two more worries for this patch. --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c +++ b/drivers/gpu/drm/amd/a

Re: [PATCH] mach64: detect the dot clock divider correctly on sparc

2018-08-24 Thread Ville Syrjälä
On Thu, Aug 23, 2018 at 05:17:20PM -0400, Mikulas Patocka wrote: > > > On Sun, 19 Aug 2018, Ville Syrjälä wrote: > > > On Fri, Aug 17, 2018 at 03:19:37PM -0400, Mikulas Patocka wrote: > > > On Sun Ultra 5, it happens that the dot clock is not set up properly for > > > some videomodes. For exampl

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Michal Hocko
On Fri 24-08-18 13:57:52, Christian König wrote: > Am 24.08.2018 um 13:52 schrieb Michal Hocko: > > On Fri 24-08-18 13:43:16, Christian König wrote: [...] > > > That won't work like this there might be multiple > > > invalidate_range_start()/invalidate_range_end() pairs open at the same > > > time

Re: [igt-dev] RFC: Migration to Gitlab

2018-08-24 Thread Daniel Vetter
On Fri, Aug 24, 2018 at 8:52 AM, Jani Nikula wrote: > On Wed, 22 Aug 2018, Rodrigo Vivi wrote: >> On Wed, Aug 22, 2018 at 10:19:19AM -0400, Adam Jackson wrote: >>> On Wed, 2018-08-22 at 16:13 +0300, Jani Nikula wrote: >>> >>> > - Sticking to fdo bugzilla and disabling gitlab issues for at least >

[PATCH 1/8] drm: fix syncobj null_fence_enable_signaling

2018-08-24 Thread Chunming Zhou
That is certainly totally nonsense. dma_fence_enable_sw_signaling() is the function who is calling this callback. Signed-off-by: Chunming Zhou Cc: Jason Ekstrand Reviewed-by: Christian König Acked-by: Daniel Vetter --- drivers/gpu/drm/drm_syncobj.c | 1 - 1 file changed, 1 deletion(-) diff -

[PATCH 2/8] drm: rename null fence to stub fence in syncobj

2018-08-24 Thread Chunming Zhou
stub fence will be used by timeline syncobj as well. Signed-off-by: Chunming Zhou Cc: Jason Ekstrand --- drivers/gpu/drm/drm_syncobj.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c index d

[PATCH 3/8] drm: expand drm_syncobj_find_fence to support timeline point v2

2018-08-24 Thread Chunming Zhou
we can fetch timeline point fence after expanded. v2: The parameter fence is the result of the function and should come last. Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +- drivers/gpu/drm/drm_syncobj.c | 5 +++-- drivers/gpu/drm/v3d/v3d_gem.c |

[PATCH 4/8] drm: expand replace_fence to support timeline point v2

2018-08-24 Thread Chunming Zhou
we can place a fence to a timeline point after expanded. v2: change func parameter order Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +- drivers/gpu/drm/drm_syncobj.c | 14 -- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 2 +- driver

[PATCH 5/8] [RFC]drm: add syncobj timeline support v2

2018-08-24 Thread Chunming Zhou
VK_KHR_timeline_semaphore: This extension introduces a new type of semaphore that has an integer payload identifying a point in a timeline. Such timeline semaphores support the following operations: * CPU query - A host operation that allows querying the payload of the timeline semaphore.

[PATCH 8/8] drm: clean up syncobj->fence and cb

2018-08-24 Thread Chunming Zhou
syncobj fence and cb aren't need any more. wait pt already contains sumission wait. Signed-off-by: Chunming Zhou --- drivers/gpu/drm/drm_syncobj.c | 69 --- include/drm/drm_syncobj.h | 56 +--- 2 files changed, 1 insertion(+), 124 delet

[PATCH 7/8] drm: export syncobj search fence to replace fence_get

2018-08-24 Thread Chunming Zhou
Signed-off-by: Chunming Zhou --- drivers/gpu/drm/drm_syncobj.c | 5 +++-- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 4 +++- include/drm/drm_syncobj.h | 2 ++ 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu

[PATCH 6/8] drm: merge normal syncobj to timeline syncobj

2018-08-24 Thread Chunming Zhou
normal syncobj can be unified to timeline syncobj. The thingking is: a. singal op always append to sinal list tail. b. wait op always wait on last sinal point. the driver indeed be simplified more. Signed-off-by: Chunming Zhou --- drivers/gpu/drm/drm_syncobj.c | 113

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Christian König
Am 24.08.2018 um 14:03 schrieb Michal Hocko: On Fri 24-08-18 13:57:52, Christian König wrote: Am 24.08.2018 um 13:52 schrieb Michal Hocko: On Fri 24-08-18 13:43:16, Christian König wrote: [...] That won't work like this there might be multiple invalidate_range_start()/invalidate_range_end() p

Re: [PATCH 1/8] drm: fix syncobj null_fence_enable_signaling

2018-08-24 Thread Christian König
Patches #1-#4 are Reviewed-by: Christian König I would squash patches #5-#8 into one and make sure that the patch is a clean replacement of the existing functionality with the new one. For example patch #5 still has some code move for the stub fence which now seems unnecessary. Regards, Ch

[PATCH 2/2] drm/bridge: Add support for a virtual display bridge

2018-08-24 Thread Linus Walleij
This adds a very small and simple driver to read a virtual display characteristic from the device tree and reflect it back into DRM so a display driver in a virtual environment knows how to configure its output. This was created for the ARM RTSM aemv8a emulator as a way forward to convert all ARM

[PATCH 1/2] drm/bridge: Add virtual display DT bindings

2018-08-24 Thread Linus Walleij
This adds bindings for a virtual display to be used with displays inside entirely virtual environments which do not emulate things like monitors but just need timing information to be supplied to its display controller. This is inspired by earlier work by Liviu Dudau. Cc: Liviu Dudau Cc: Ryan Ha

Re: [PATCH v1 7/7] drm: add Atmel LCDC display controller support

2018-08-24 Thread Boris Brezillon
+Noralf Hi Sam, On Sun, 12 Aug 2018 20:46:29 +0200 Sam Ravnborg wrote: > This is a DRM based driver for the Atmel LCDC IP. > There exist today a framebuffer based driver and > this is a re-implmentation of the same on top of DRM. > > The rewrite was based on the original fbdev driver > but the

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Michal Hocko
On Fri 24-08-18 14:18:44, Christian König wrote: > Am 24.08.2018 um 14:03 schrieb Michal Hocko: > > On Fri 24-08-18 13:57:52, Christian König wrote: > > > Am 24.08.2018 um 13:52 schrieb Michal Hocko: > > > > On Fri 24-08-18 13:43:16, Christian König wrote: > > [...] > > > > > That won't work like t

[Bug 105733] Amdgpu randomly hangs and only ssh works. Mouse cursor moves sometimes but does nothing. Keyboard stops working.

2018-08-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105733 --- Comment #30 from Jan Jurzitza --- (In reply to Andrey Grodzovsky from comment #29) > > ... > This is just a warning meaning you use CPU to update GPU page tables, any > reason why ? try passing kernel > amdgpu.vm_update_mode=0 instead. Y

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Christian König
Am 24.08.2018 um 14:33 schrieb Michal Hocko: On Fri 24-08-18 14:18:44, Christian König wrote: Am 24.08.2018 um 14:03 schrieb Michal Hocko: On Fri 24-08-18 13:57:52, Christian König wrote: Am 24.08.2018 um 13:52 schrieb Michal Hocko: On Fri 24-08-18 13:43:16, Christian König wrote: [...] Tha

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Michal Hocko
On Fri 24-08-18 14:52:26, Christian König wrote: > Am 24.08.2018 um 14:33 schrieb Michal Hocko: [...] > > Thiking about it some more, I can imagine that a notifier callback which > > performs an allocation might trigger a memory reclaim and that in turn > > might trigger a notifier to be invoked an

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Christian König
Am 24.08.2018 um 15:01 schrieb Michal Hocko: On Fri 24-08-18 14:52:26, Christian König wrote: Am 24.08.2018 um 14:33 schrieb Michal Hocko: [...] Thiking about it some more, I can imagine that a notifier callback which performs an allocation might trigger a memory reclaim and that in turn might

[Bug 107635] Internal display always be blank in mirror, extended and built-in only display mode

2018-08-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107635 --- Comment #1 from Harry Wentland --- Have you tried with nouveau disabled? https://askubuntu.com/questions/841876/how-to-disable-nouveau-kernel-driver/951892#951892 -- You are receiving this mail because: You are the assignee for the bug.__

[Bug 107623] (4.18.3)[drm:hwss_edp_wait_for_hpd_ready [amdgpu]] *ERROR* hwss_edp_wait_for_hpd_ready: wait timed out!

2018-08-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107623 --- Comment #4 from Harry Wentland --- Have you tried with nouveau disabled? https://askubuntu.com/questions/841876/how-to-disable-nouveau-kernel-driver/951892#951892 -- You are receiving this mail because: You are the assignee for the bug.__

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Michal Hocko
On Fri 24-08-18 15:10:08, Christian König wrote: > Am 24.08.2018 um 15:01 schrieb Michal Hocko: > > On Fri 24-08-18 14:52:26, Christian König wrote: > > > Am 24.08.2018 um 14:33 schrieb Michal Hocko: > > [...] > > > > Thiking about it some more, I can imagine that a notifier callback which > > > >

[Bug 107593] spam in dmesg about "SADs count" since recent Radeon RX550 install using amdgpu driver

2018-08-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107593 --- Comment #6 from Fermulator --- "current kernels", more specifically? (Fedora runs pretty bleeding edge kernel-wise) If we have a "fix in kernel version X", and a different bug report to duplicate against, we can close then then? -- You ar

[Bug 107560] radeon (amdgpu) GDM flip queue failed invalid argument, DisplayPort issues

2018-08-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107560 --- Comment #8 from Fermulator --- (fyi, to update, the issue hasn't presented itself in the past week, which is a bit frustrating) - i had even ordered an HDMI cable to workaround the DisplayPort problem ... but haven't installed it yet waiting

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Christian König
Am 24.08.2018 um 15:24 schrieb Michal Hocko: On Fri 24-08-18 15:10:08, Christian König wrote: Am 24.08.2018 um 15:01 schrieb Michal Hocko: On Fri 24-08-18 14:52:26, Christian König wrote: Am 24.08.2018 um 14:33 schrieb Michal Hocko: [...] Thiking about it some more, I can imagine that a noti

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Michal Hocko
On Fri 24-08-18 22:02:23, Tetsuo Handa wrote: > On 2018/08/24 20:36, Michal Hocko wrote: > >> That is, this API seems to be currently used by only out-of-tree users. > >> Since > >> we can't check that nobody has memory allocation dependency, I think that > >> hmm_invalidate_range_start() should r

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Michal Hocko
On Fri 24-08-18 15:28:33, Christian König wrote: > Am 24.08.2018 um 15:24 schrieb Michal Hocko: > > On Fri 24-08-18 15:10:08, Christian König wrote: > > > Am 24.08.2018 um 15:01 schrieb Michal Hocko: > > > > On Fri 24-08-18 14:52:26, Christian König wrote: > > > > > Am 24.08.2018 um 14:33 schrieb M

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Christian König
Am 24.08.2018 um 15:40 schrieb Michal Hocko: On Fri 24-08-18 15:28:33, Christian König wrote: Am 24.08.2018 um 15:24 schrieb Michal Hocko: On Fri 24-08-18 15:10:08, Christian König wrote: Am 24.08.2018 um 15:01 schrieb Michal Hocko: On Fri 24-08-18 14:52:26, Christian König wrote: Am 24.08.2

Re: [PATCH] drm/kms/crtc: Improving the func drm_mode_setcrtc

2018-08-24 Thread Jani Nikula
On Fri, 27 Jul 2018, Satendra Singh Thakur wrote: > Following changes are done to this func: Just a drive-by observation, if your commit message lists a number of changes, with "also", it's usually an indication they should be separate patches. BR, Jani. > 1. Currently there are many redundant

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Michal Hocko
On Fri 24-08-18 15:44:03, Christian König wrote: > Am 24.08.2018 um 15:40 schrieb Michal Hocko: > > On Fri 24-08-18 15:28:33, Christian König wrote: > > > Am 24.08.2018 um 15:24 schrieb Michal Hocko: > > > > On Fri 24-08-18 15:10:08, Christian König wrote: > > > > > Am 24.08.2018 um 15:01 schrieb M

Re: [PATCH] drm/kms/crtc: Improving the func drm_mode_setcrtc

2018-08-24 Thread Daniel Stone
Hi Satendra, On Fri, 27 Jul 2018 at 11:13, Satendra Singh Thakur wrote: > Following changes are done to this func: I would certainly agree with Sean, Martin, and Jani's comments. This patch was difficult to follow as it made so many changes at once. Being a crucial function which has many subtle

[Bug 107593] spam in dmesg about "SADs count" since recent Radeon RX550 install using amdgpu driver

2018-08-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107593 --- Comment #7 from Michel Dänzer --- (In reply to Fermulator from comment #6) > "current kernels", more specifically? 4.16 or newer. > If we have a "fix in kernel version X", and a different bug report to > duplicate against, we can close the

[Bug 105251] [Vega10] GPU lockup on boot: VMC page fault

2018-08-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105251 --- Comment #24 from CheatCodesOfLife --- (In reply to Andrey Grodzovsky from comment #23) > (In reply to CheatCodesOfLife from comment #22) > > You're welcome. > > > > Not the exact same problem, no. I can get a hard-lock by trying to use > >

[Bug 105251] [Vega10] GPU lockup on boot: VMC page fault

2018-08-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105251 --- Comment #25 from CheatCodesOfLife --- Created attachment 141269 --> https://bugs.freedesktop.org/attachment.cgi?id=141269&action=edit debug files -- You are receiving this mail because: You are the assignee for the bug.__

[Bug 105251] [Vega10] GPU lockup on boot: VMC page fault

2018-08-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105251 --- Comment #26 from Andrey Grodzovsky --- (In reply to CheatCodesOfLife from comment #25) > Created attachment 141269 [details] > debug files Thanks a lot, i will find some time in the next few days to analyze it. -- You are receiving this m

Re: [PATCH] drm/sun4i: tcon-top: Use struct_size() in devm_kzalloc()

2018-08-24 Thread Maxime Ripard
On Thu, Aug 23, 2018 at 07:56:12PM -0700, Kees Cook wrote: > On Thu, Aug 23, 2018 at 6:05 PM, Gustavo A. R. Silva > wrote: > > One of the more common cases of allocation size calculations is finding > > the size of a structure that has a zero-sized array at the end, along > > with memory for some

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Jerome Glisse
On Fri, Aug 24, 2018 at 07:54:19PM +0900, Tetsuo Handa wrote: > Two more worries for this patch. [...] > > > --- a/mm/hmm.c > > +++ b/mm/hmm.c > > @@ -177,16 +177,19 @@ static void hmm_release(struct mmu_notifier *mn, > > struct mm_struct *mm) > > up_write(&hmm->mirrors_sem); > > } > >

Re: [Freedreno] [PATCH 5/5] drm/msm/A6x: Add devfreq support in A6x

2018-08-24 Thread Jordan Crouse
On Fri, Aug 24, 2018 at 03:24:04PM +0530, Sharat Masetty wrote: > > > On 8/23/2018 9:30 PM, Jordan Crouse wrote: > >On Thu, Aug 23, 2018 at 02:48:31PM +0530, Sharat Masetty wrote: > >>Implement routines to estimate GPU busy time and fetching the > >>current frequency for the polling interval. Thi

Re: [PATCH (repost) 5/5] drm/amdgpu: add DisplayPort CEC-Tunneling-over-AUX support

2018-08-24 Thread Alex Deucher
On Fri, Aug 24, 2018 at 3:20 AM Hans Verkuil wrote: > > On 08/23/2018 08:38 PM, Harry Wentland wrote: > > On 2018-08-17 10:11 AM, Hans Verkuil wrote: > >> From: Hans Verkuil > >> > >> Add DisplayPort CEC-Tunneling-over-AUX support to amdgpu. > >> > >> Signed-off-by: Hans Verkuil > >> Acked-by: A

Re: [BUG] i915 HDMI connector status is connected after disconnection

2018-08-24 Thread Jani Nikula
On Wed, 22 Aug 2018, Chris Chiu wrote: > On Fri, Jul 6, 2018 at 2:44 PM, Chris Chiu wrote: >> On Thu, Jul 5, 2018 at 10:40 PM, Ville Syrjälä >> wrote: >>> On Thu, Jul 05, 2018 at 03:58:36PM +0800, Chris Chiu wrote: Hi, We have few ASUS laptops X705FD (The new WiskyLake), X560UD (in

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Jerome Glisse
On Fri, Aug 24, 2018 at 02:33:41PM +0200, Michal Hocko wrote: > On Fri 24-08-18 14:18:44, Christian König wrote: > > Am 24.08.2018 um 14:03 schrieb Michal Hocko: > > > On Fri 24-08-18 13:57:52, Christian König wrote: > > > > Am 24.08.2018 um 13:52 schrieb Michal Hocko: > > > > > On Fri 24-08-18 13:

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Jerome Glisse
On Fri, Aug 24, 2018 at 11:52:25PM +0900, Tetsuo Handa wrote: > On 2018/08/24 22:32, Michal Hocko wrote: > > On Fri 24-08-18 22:02:23, Tetsuo Handa wrote: > >> I worry that (currently > >> out-of-tree) users of this API are involving work / recursion. > > > > I do not give a slightest about out-of

Re: [PATCH v1 1/7] atmel-hlcdc: renamed directory to drm/atmel/

2018-08-24 Thread Sam Ravnborg
Hi Boris. On Fri, Aug 24, 2018 at 10:28:43AM +0200, Boris Brezillon wrote: > On Sun, 12 Aug 2018 20:46:23 +0200 > Sam Ravnborg wrote: > > > Use vendor name for directory, adding a suitable place > > for more atmel DRM drivers. > > > > Signed-off-by: Sam Ravnborg > > Cc: Boris Brezillon > > --

Re: [RFC PATCH 0/7] add at91sam9 LCDC DRM driver

2018-08-24 Thread Sam Ravnborg
Hi Boris. > > > > Both devices are supported today by the atmel_lcdfb driver. > > For this new set of drivers the compatible strings was > > selected to avoid clash with the existing compatible > > strings used for the atmel_lcdfb driver to allow them > > to co-exist. > > Hm, I think Rob comment

Re: [PATCH v1 2/7] dt-binding: add bindings for Atmel LCDC mfd

2018-08-24 Thread Sam Ravnborg
Hi Boris. > > +The LCDC IP exposes two subdevices: > > + - a PWM chip: see ../pwm/atmel-lcdc-pwm.txt > > + - a Display Controller: see ../display/atmel/lcdc-display-controller.txt > > + > > +Example: > > + lcdc0: lcdc@70 { > > + compatible = "atmel,at91sam9263-lcdc-mfd"; > > +

Re: [ANNOUNCE] libdrm 2.4.94

2018-08-24 Thread Kristian Høgsberg
On Thu, Aug 23, 2018 at 10:44 PM Laurent Carlier wrote: > > Le vendredi 24 août 2018, 00:37:51 CEST Kristian H. Kristensen a écrit : > > https://dri.freedesktop.org/libdrm/libdrm-2.4.94.tar.bz2 > > -> Forbidden > > You don't have permission to access /libdrm/libdrm-2.4.94.tar.bz2 on this > server.

Re: [ANNOUNCE] libdrm 2.4.94

2018-08-24 Thread Kristian Høgsberg
On Fri, Aug 24, 2018 at 1:13 AM Michel Dänzer wrote: > > On 2018-08-24 12:37 a.m., Kristian H. Kristensen wrote: > > Benjamin Gaignard (2): > > tests/modetest: Add atomic support > > tests/util: Add support for stm module > > > > Christian König (7): > > amdgpu: stop using the ha

Re: [PATCH v8 3/4] drm/atmel-hlcdc: iterate over all output endpoints

2018-08-24 Thread Rob Herring
On Fri, Aug 24, 2018 at 2:47 AM Boris Brezillon wrote: > > On Tue, 14 Aug 2018 17:05:29 +0200 > Peter Rosin wrote: > > > >> @@ -77,13 +79,29 @@ static int atmel_hlcdc_attach_endpoint(struct > > >> drm_device *dev, int endpoint) > > >> > > >> int atmel_hlcdc_create_outputs(struct

Re: [ANNOUNCE] libdrm 2.4.94

2018-08-24 Thread Michel Dänzer
On 2018-08-24 6:27 p.m., Kristian Høgsberg wrote: > > I don't know what all is pending for libdrm, but I know that we've > agreed on a very low bar for when to release libdrm: > >"The release criteria for libdrm is essentially "if you need a release, > make one". There is no designated r

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Michal Hocko
On Fri 24-08-18 23:52:25, Tetsuo Handa wrote: > On 2018/08/24 22:32, Michal Hocko wrote: > > On Fri 24-08-18 22:02:23, Tetsuo Handa wrote: > >> I worry that (currently > >> out-of-tree) users of this API are involving work / recursion. > > > > I do not give a slightest about out-of-tree modules. T

  1   2   >