From: Ville Syrjälä
Yank out the code for the plane->fb/old_fb/crtc handling from
the page flip path into page_flip_internal(), and provide a
simpler variant for atomic drivers.
We'll also move the fb vs. src viewport checks into the new
functions as they are slightly different between the two p
From: Ville Syrjälä
Instead of doing the things in a convoluted way with the failure and
success paths mixed up let's just clear old_fb when we encounter an
error and bail out immediately.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/drm_plane.c | 32 +---
1 fil
From: Ville Syrjälä
Can't see why we need to delay the page flip event allocation until the
last moment. Move it earlier to simplify error handling.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/drm_plane.c | 45 +++--
1 file changed, 23 insertions(+)
On Fri, Jul 13, 2018 at 11:34:44AM -0400, Sean Paul wrote:
> Noticed this while browsing the docs.
>
> Signed-off-by: Sean Paul
> ---
> include/drm/drm_property.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/drm/drm_property.h b/include/drm/drm_property.h
On Fri, Jul 13, 2018 at 11:47:33AM -0400, Sean Paul wrote:
> On Fri, Jul 13, 2018 at 11:40:13AM -0400, Sean Paul wrote:
> > On Fri, Jul 13, 2018 at 04:11:00PM +0100, Alexandru Gheorghe wrote:
> > > Set possible_clones field to report that the writeback connector and
> > > the one driving the displa
On Fri, Jul 13, 2018 at 08:41:37AM +0200, Christian König wrote:
> Am 13.07.2018 um 04:37 schrieb Sinclair Yeh:
> >On Mon, Jul 09, 2018 at 10:24:47AM -0500, Gustavo A. R. Silva wrote:
> >>Make use of the swap macro and remove unnecessary variable *tmp_mem*.
> >>This makes the code easier to read an
On Fri, Jul 13, 2018 at 10:59:06AM -0400, Sean Paul wrote:
> On Mon, Jul 09, 2018 at 10:40:06AM +0200, Daniel Vetter wrote:
> > Just makes it longer, and for most things in drm_connector.[hc] we
> > just use the drm_connector_ prefix. Done with sed + a bit of manual
> > fixup for the indenting.
> >
On Fri, Jul 13, 2018 at 04:55:41PM +0100, Alexandru-Cosmin Gheorghe wrote:
> On Fri, Jul 13, 2018 at 11:47:33AM -0400, Sean Paul wrote:
> > On Fri, Jul 13, 2018 at 11:40:13AM -0400, Sean Paul wrote:
> > > On Fri, Jul 13, 2018 at 04:11:00PM +0100, Alexandru Gheorghe wrote:
> > > > Set possible_clone
On Fri, Jul 13, 2018 at 06:51:36PM +0300, Ville Syrjälä wrote:
> On Fri, Jul 13, 2018 at 11:34:44AM -0400, Sean Paul wrote:
> > Noticed this while browsing the docs.
> >
> > Signed-off-by: Sean Paul
> > ---
> > include/drm/drm_property.h | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions
Every codepath in nouveau that loops through the connector list
currently does so using the old method, which is prone to race
conditions from MST connectors being created and destroyed. This has
been causing a multitude of problems, including memory corruption from
trying to access connectors that
This fixes some nasty issues I found in nouveau that were being caused
looping through connectors using racy legacy methods, along with some
caused by making incorrect assumptions about the drm_connector structs
in nouveau's connector list. Most of these memory corruption issues
could be reproduced
When MST and atomic were introduced to nouveau, another structure that
could contain a drm_connector embedded within it was introduced; struct
nv50_mstc. This meant that we no longer would be able to simply loop
through our connector list and assume that nouveau_connector() would
return a proper po
https://bugs.freedesktop.org/show_bug.cgi?id=107204
Miłosz Rachwał changed:
What|Removed |Added
Summary|GPU hang (ring gfx timeout) |GPU hang (ring gfx timeout)
https://bugs.freedesktop.org/show_bug.cgi?id=107204
--- Comment #1 from Miłosz Rachwał ---
It turned out that the cause was uninitialized UBO, which depending on memory
contents leaded to out of bounds UBO array read in fragment shader.
It probably shouldn't bring down whole GPU, though.
--
You
On Fri, 13 Jul 2018 17:25:39 +0200,
jimqu wrote:
>
>
>
> 在 2018/7/13 16:46, Takashi Iwai 写道:
> > On Fri, 13 Jul 2018 10:06:02 +0200,
> > Jim Qu wrote:
> >> On modern laptop, there are more and more platforms
> >> have two GPUs, and each of them maybe have audio codec
> >> for HDMP/DP output. For
On Thu, Jul 12, 2018 at 09:51:33AM -0400, Sean Paul wrote:
> On Mon, Jul 09, 2018 at 10:40:16AM +0200, Daniel Vetter wrote:
> > This is starting to become easy!
> >
> > Note: This needs the patch to move for_each_if from drmP.h to kernel.h
> > or it won't compile.
> >
> > Signed-off-by: Daniel Ve
On Fri, Jul 13, 2018 at 12:24:41PM -0400, Lyude Paul wrote:
> When MST and atomic were introduced to nouveau, another structure that
> could contain a drm_connector embedded within it was introduced; struct
> nv50_mstc. This meant that we no longer would be able to simply loop
> through our connect
On Thu, Jul 12, 2018 at 08:40:55PM +0100, Chris Wilson wrote:
> Quoting Jordan Crouse (2018-07-12 19:59:19)
> > Add a drm printer suitable for use with the read callback for
> > devcoredump or other suitable buffer based output format that
> > isn't otherwise covered by seq_file.
> >
> > Signed-of
在 2018/7/14 0:38, Takashi Iwai 写道:
On Fri, 13 Jul 2018 17:25:39 +0200,
jimqu wrote:
在 2018/7/13 16:46, Takashi Iwai 写道:
On Fri, 13 Jul 2018 10:06:02 +0200,
Jim Qu wrote:
On modern laptop, there are more and more platforms
have two GPUs, and each of them maybe have audio codec
for HDMP/DP o
On Thu, Jul 12, 2018 at 09:46:58PM +0200, Daniel Vetter wrote:
> On Thu, Jul 12, 2018 at 12:59:19PM -0600, Jordan Crouse wrote:
> > Add a drm printer suitable for use with the read callback for
> > devcoredump or other suitable buffer based output format that
> > isn't otherwise covered by seq_file
Every codepath in nouveau that loops through the connector list
currently does so using the old method, which is prone to race
conditions from MST connectors being created and destroyed. This has
been causing a multitude of problems, including memory corruption from
trying to access connectors that
This fixes some nasty issues I found in nouveau that were being caused
looping through connectors using racy legacy methods, along with some
caused by making incorrect assumptions about the drm_connector structs
in nouveau's connector list. Most of these memory corruption issues
could be reproduced
When MST and atomic were introduced to nouveau, another structure that
could contain a drm_connector embedded within it was introduced; struct
nv50_mstc. This meant that we no longer would be able to simply loop
through our connector list and assume that nouveau_connector() would
return a proper po
Hi Dave,
A few more fixes for 4.18. Two display fixes and a fix to avoid a segfault if
the GPU does not power up properly on resume. These are on top of my pull
from earlier this week.
The following changes since commit 9d4a0d4cdc8b5904ec7c9b9e04bab3e9e60d7a74:
drm/amdgpu: Verify root PD is m
On Fri, Jul 13, 2018 at 06:27:23PM +0530, Rajesh Yadav wrote:
> The vblank on/off calls were missing in dpu_crtc
> leading to "driver forgot to call drm_crtc_vblank_off()"
> warning while entering suspend state.
> Also handle the state update completion event for
> a crtc being disabled in current
https://bugs.freedesktop.org/show_bug.cgi?id=107224
Bug ID: 107224
Summary: Incorrect Rendering in Deus Ex: Mankind Divided
in-game menu
Product: Mesa
Version: git
Hardware: Other
OS: All
Status:
https://bugs.freedesktop.org/show_bug.cgi?id=107066
--- Comment #12 from Lyude Paul ---
Created attachment 140629
--> https://bugs.freedesktop.org/attachment.cgi?id=140629&action=edit
dmesg after fix
So the patch actually works, hooray! There are some pretty annoying dmesg
warnings leftover th
https://bugs.freedesktop.org/show_bug.cgi?id=107066
--- Comment #13 from Mikita Lipski ---
Which patch did you try? Or did you apply all of them?
Warnings: hmm, haven't seen those before, seems like something new got exposed.
Will look into them more in depth.
--
You are receiving this mail be
https://bugs.freedesktop.org/show_bug.cgi?id=107066
--- Comment #14 from Lyude Paul ---
(In reply to Mikita Lipski from comment #13)
> Which patch did you try? Or did you apply all of them?
>
> Warnings: hmm, haven't seen those before, seems like something new got
> exposed. Will look into them
https://bugs.freedesktop.org/show_bug.cgi?id=107066
--- Comment #15 from Mikita Lipski ---
Could you try building without the last patch if possible:
0001-Disable-source-clock-sharing-between-multiple-connec.patch .
Thanks
--
You are receiving this mail because:
You are the assignee for the bu
This patch unifies the naming of DRM functions for reference counting
of struct drm_device. The resulting code is more aligned with the rest
of the Linux kernel interfaces.
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/udl/udl_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
d
https://bugs.freedesktop.org/show_bug.cgi?id=104817
James Le Cuirot changed:
What|Removed |Added
CC||ch...@gentoo.org
--- Comment #7 from
https://bugzilla.kernel.org/show_bug.cgi?id=199653
--- Comment #8 from James Le Cuirot (ch...@gentoo.org) ---
OP also filed a freedesktop.org bug report with more information.
https://bugs.freedesktop.org/104817
Still the same with 4.18-rc4. :(
--
You are receiving this mail because:
You are w
https://bugs.freedesktop.org/show_bug.cgi?id=107065
--- Comment #21 from Andrey Grodzovsky ---
(In reply to dwagner from comment #20)
> (In reply to Andrey Grodzovsky from comment #19)
> > I was able to reproduce this instantly without even using page tables CPU
> > update mode. Looks like a regr
https://bugs.freedesktop.org/show_bug.cgi?id=105760
--- Comment #45 from Thomas Martitz ---
> Most importantly, my observation that reading toc->num_entries returns -1 is
> still occuring:
> [ 368.991914] amdgpu: [powerplay] smu7_request_smu_load_fw: 10
> b456a0081000 0 1
> [ 368.991927]
Hi Dave,
This is probably the last pull request for 4.19 from our side.
Please remind about the gvt-fixes vs gvt-next conflict that I mentioned
yesterday on drm-intel-fixes pull request.
Here goes drm-intel-next-2018-07-12:
On GVT there's the addition of vGPU huge page support for guest,
with on
tree: git://people.freedesktop.org/~agd5f/linux.git drm-next-4.19-wip
head: 638d758f0bb28342123d87dbd8a4190a55e74771
commit: 522e6b434a61f8be910560969386a2b3ce113c1b [93/102] drm/amd/display:
Initialize data structure for DalMpVisualConfirm.
config: x86_64-randconfig-g0-07132339 (attached as .
https://bugs.freedesktop.org/show_bug.cgi?id=107065
--- Comment #22 from dwagner ---
(In reply to Andrey Grodzovsky from comment #21)
> I found the offending patch - drm: Stop updating plane->crtc/fb/old_fb on
> atomic drivers
> Not sure yet what's going on there and not sure it will fix you issu
Hi Andre,
Thanks for your info. What a surprise that exist such a SoC. That
means I have to
judge if it's a 64bit CPU in other way than just check ARM64 config.
Regards,
Qiang
On Sat, Jun 16, 2018 at 1:23 AM Andre Przywara wrote:
>
> On 05/23/2018 17:16, Marek Vasut wrote:
> > On 05/18/2018 11:2
https://bugs.freedesktop.org/show_bug.cgi?id=107066
--- Comment #16 from Lyude Paul ---
(In reply to Mikita Lipski from comment #15)
> Could you try building without the last patch if possible:
> 0001-Disable-source-clock-sharing-between-multiple-connec.patch .
>
> Thanks
Nope, doesn't get rid
The sequence for HDCP2.2 authentication and encryption is implemented
in I915. Encoder specific implementations are moved into hdcp_shim.
Intel HWs supports HDCP2.2 through ME FW. Hence this series
introduces a client driver for mei bus, so that for HDCP2.2
authentication, HDCP2.2 stack in I915 ca
From: Tomas Winkler
Whitelist HDCP client for in kernel drm use
v2:
Rebased.
v3:
No changes.
v4:
No changes.
v5:
No changes.
v6:
No changes
Signed-off-by: Tomas Winkler
---
drivers/misc/mei/bus-fixup.c | 16
1 file changed, 16 insertions(+)
diff --git a/drivers/mis
Considering significant number of HDCP specific variables, it will
be clean to have separate struct for HDCP.
New structure called intel_hdcp is added within intel_connector.
v2:
struct hdcp statically allocated. [Sean Paul]
enable and disable function parameters are retained.[Sean Paul]
v3:
This patch adds HDCP register definitions for HDMI and DP HDCP
adaptations.
HDMI specific HDCP2.2 register definitions are added into drm_hdcp.h,
where as HDCP2.2 register offsets in DPCD offsets are defined at
drm_dp_helper.h.
v2:
bit_field definitions are replaced by macros. [Tomas and Jani]
This patch defines the hdcp2.2 protocol messages for authentication.
v2:
bit_fields are removed. Instead bitmasking used. [Tomas and Jani]
prefix HDCP_2_2_ is added to the macros. [Tomas]
v3:
No Changes.
v4:
Style and spellings are fixed [Uma]
v5:
Fix for macros.
v6:
comment for Type i
Data structures and Enum for the I915-MEI_HDCP interface are defined
at
v2:
Rebased.
v3:
mei_cl_device is removed from mei_hdcp_data [Tomas]
v4:
Comment style and typo fixed [Uma]
v5:
Rebased.
v6:
No changes.
Signed-off-by: Ramalingam C
---
include/linux/mei_hdcp.h | 100
Intel HDCP2.2 registers are defined with addr offsets and bit details.
v2:
Replaced the arith calc with _PICK [Sean Paul]
v3:
No changes.
v4:
%s/HDCP2_CTR_DDI/HDCP2_CTL_DDI [Uma]
v5:
Added parentheses for the parameters of macro.
v6:
No changes
Signed-off-by: Ramalingam C
Reviewed-by:
If all the components associated to a component master is not added
to the component framework due to the HW capability or Kconfig
selection, component_match will be NULL at
component_master_add_with_match().
To avoid this, component_match_alloc() is added to the framework,
to allcoate the struct
A generic component master is added to hold the i915 registration
until all required kernel modules are up and active.
This is achieved through following steps:
- moving the i915 driver registration to the component master's
bind call
- all required kernel modules w
For reusability purpose, this patch implements the hdcp1.4 bksv's
read and validation as a functions.
For detecting the HDMI panel's HDCP capability this fucntions will be
used.
v2:
Rebased.
v3:
No Changes.
v4:
inline tag is removed with modified error msg.
v5:
No Changes.
v6:
No Change
Initialize HDCP2.2 support. This includes the mei interface
initialization along with required component registration.
v2:
mei interface handle is protected with mutex. [Chris Wilson]
v3:
Notifiers are used for the mei interface state.
v4:
Poll for mei client device state
Error msg for out
When repeater notifies a downstream topology change, this patch
reauthenticate the repeater alone without disabling the hdcp
encryption. If that fails then complete reauthentication is executed.
v2:
Rebased.
v3:
No Changes.
v4:
Typo in commit msg is fixed [Uma]
v5:
Rebased as part of patch
Implements the HDCP2.2 repeaters authentication steps such as verifying
the downstream topology and sending stream management information.
v2:
Rebased.
v3:
No Changes.
v4:
-EINVAL is returned for topology error and rollover scenario.
Endianness conversion func from drm_hdcp.h is used [Uma]
Implements HDCP2.2 authentication for hdcp2.2 receivers, with
following steps:
Authentication and Key exchange (AKE).
Locality Check (LC).
Session Key Exchange(SKE).
DP Errata for stream type configuration for receivers.
At AKE, the HDCP Receiver’s public key certif
Considering that HDCP2.2 is more secure than HDCP1.4, When a setup
supports HDCP2.2 and HDCP1.4, HDCP2.2 will be enabled.
When HDCP2.2 enabling fails and HDCP1.4 is supported, HDCP1.4 is
enabled.
This change implements a sequence of enabling and disabling of
HDCP2.2 authentication and HDCP2.2 por
Implements the link integrity check once in 500mSec.
Once encryption is enabled, an ongoing Link Integrity Check is
performed by the HDCP Receiver to check that cipher synchronization
is maintained between the HDCP Transmitter and the HDCP Receiver.
On the detection of synchronization lost, the H
Implements the DP adaptation specific HDCP2.2 functions.
These functions perform the DPCD read and write for communicating the
HDCP2.2 auth message back and forth.
Note: Chris Wilson suggested alternate method for waiting for CP_IRQ,
than completions concept. WIP to understand and implement that,
On DP connector init, intel_hdcp_init is passed with a flag for hdcp2.2
support based on the platform capability.
v2:
Rebased.
v3:
No Changes.
v4:
Collected the reviewed-by received.
v5:
No change.
v6:
No change.
Signed-off-by: Ramalingam C
Reviewed-by: Uma Shankar
---
drivers/gpu/dr
HDCP check link is invoked only on CP_IRQ detection, instead of all
short pulses.
v3:
No Changes.
v4:
Added sean in cc and collected the reviewed-by received.
v5:
No Change.
v6:
No Change.
Signed-off-by: Ramalingam C
cc: Sean Paul
Reviewed-by: Uma Shankar
Reviewed-by: Sean Paul
---
d
On DP HDCP1.4 and 2.2, when CP_IRQ is received, start the link
integrity check for the HDCP version that is enabled.
v2:
Rebased. Function name is changed.
v3:
No Changes.
v4:
No Changes.
v5:
No Changes.
v6:
%s/_in_force/_in_use [Sean Paul]
Signed-off-by: Ramalingam C
cc: Sean Paul
Re
Implements the HDMI adaptation specific HDCP2.2 operations.
Basically these are DDC read and write for authenticating through
HDCP2.2 messages.
v2:
Rebased.
v3:
No Changes.
v4:
No more special handling of Gmbus burst read for AKE_SEND_CERT.
Style fixed with few naming. [Uma]
%s/PARING/P
On HDMI connector init, intel_hdcp_init is passed with a flag for hdcp2.2
support based on the platform capability.
v2:
Rebased.
v3:
No Changes.
v4:
Collected the reviewed-by received.
v5:
No change.
v6:
No change.
Signed-off-by: Ramalingam C
Reviewed-by: Uma Shankar
---
drivers/gpu/
ME FW is contributes a vital role in HDCP2.2 authentication.
HDCP2.2 driver needs to communicate to ME FW for each step of the
HDCP2.2 authentication.
ME FW prepare and HDCP2.2 authentication parameters and encrypt them
as per spec. With such parameter Driver prepares HDCP2.2 auth messages
and co
Defines the HDCP specific ME FW interfaces such as Request CMDs,
payload structure for CMDs and their response status codes.
This patch defines payload size(Excluding the Header)for each WIRED
HDCP2.2 CMDs.
v2:
Rebased.
v3:
Extra comments are removed.
v4:
%s/\/\*\*/\/\*
v5:
Extra lines ar
Mei hdcp driver is designed as component slave for the I915 component
master.
v2:
Rebased.
v3:
Notifier chain is adopted for cldev state update [Tomas]
v4:
Made static dummy functions as inline in mei_hdcp.h
API for polling client device status
IS_ENABLED used in header, for config statu
Requests ME to start the second stage of HDCP2.2 authentication,
called Locality Check.
On Success, ME FW will provide LC_Init message to send to hdcp sink.
v2:
Rebased.
v3:
cldev is passed as first parameter [Tomas]
Redundant comments and cast are removed [Tomas]
v4:
%zd used for ssize_t
Requests for the verification of AKE_Send_H_prime.
ME will calculate the H and comparing it with received H_Prime.
The result will be returned as status.
Here AKE_Send_H_prime is a HDCP2.2 Authentication msg.
v2:
Rebased.
v3:
cldev is passed as first parameter [Tomas]
Redundant comments an
Provides Pairing info to ME to store.
Pairing is a process to fast track the subsequent authentication
with the same HDCP sink.
On Success, received HDCP pairing info is stored in non-volatile
memory of ME.
v2:
Rebased.
v3:
cldev is passed as first parameter [Tomas]
Redundant comments and
Requests for verification for receiver certification and also the
preparation for next AKE auth message with km.
On Success ME FW validate the HDCP2.2 receivers certificate and do the
revocation check on the receiver ID. AKE_Stored_Km will be prepared if
the receiver is already paired, else AKE_No
Request ME FW to start the HDCP2.2 session for an intel port.
Prepares payloads for command WIRED_INITIATE_HDCP2_SESSION and sends
to ME FW.
On Success, ME FW will start a HDCP2.2 session for the port and
provides the content for HDCP2.2 AKE_Init message.
v2:
Rebased.
v3:
cldev is add as a se
Request to ME to prepare the encrypted session key.
On Success, ME provides Encrypted session key. Function populates
the HDCP2.2 authentication msg SKE_Send_Eks.
v2:
Rebased.
v3:
cldev is passed as first parameter [Tomas]
Redundant comments and cast are removed [Tomas]
v4:
%zd for ssize_
Request the ME to terminate the HDCP2.2 session for a port.
On Success, ME FW will mark the intel port as Deauthenticated and
terminate the wired HDCP2.2 Tx session started due to the cmd
WIRED_INITIATE_HDCP2_SESSION.
v2:
Rebased.
v3:
cldev is passed as first parameter [Tomas]
Redundant com
Request ME to verify the downstream topology information received.
ME FW will validate the Repeaters receiver id list and
downstream topology.
On Success ME FW will provide the Least Significant
128bits of VPrime, which forms the repeater ack.
v2:
Rebased.
v3:
cldev is passed as first parame
Request to ME to verify the LPrime received from HDCP sink.
On Success, ME FW will verify the received Lprime by calculating and
comparing with L.
This represents the completion of Locality Check.
v2:
Rebased.
v3:
cldev is passed as first parameter [Tomas]
Redundant comments and cast are r
Request to ME to configure a port as authenticated.
On Success, ME FW will mark the port as authenticated and provides
HDCP cipher with the encryption keys.
Enabling the Authentication can be requested once all stages of
HDCP2.2 authentication is completed by interacting with ME FW.
Only after t
Request to ME to verify the M_Prime received from the HDCP sink.
ME FW will calculate the M and compare with M_prime received
as part of RepeaterAuth_Stream_Ready, which is HDCP2.2 protocol msg.
On successful completion of this stage, downstream propagation of
the stream management info is comple
https://bugs.freedesktop.org/show_bug.cgi?id=107065
--- Comment #23 from Andrey Grodzovsky ---
(In reply to dwagner from comment #22)
> (In reply to Andrey Grodzovsky from comment #21)
> > I found the offending patch - drm: Stop updating plane->crtc/fb/old_fb on
> > atomic drivers
> > Not sure ye
在 2018/7/13 17:27, Lukas Wunner 写道:
On Fri, Jul 13, 2018 at 04:06:02PM +0800, Jim Qu wrote:
On modern laptop, there are more and more platforms
have two GPUs, and each of them maybe have audio codec
for HDMP/DP output. For some dGPU which is no output,
audio codec usually is disabled.
In curr
https://bugs.freedesktop.org/show_bug.cgi?id=107153
Patrik Kullman changed:
What|Removed |Added
CC||mikita.lip...@amd.com
--- Comment #10
https://bugzilla.kernel.org/show_bug.cgi?id=199749
--- Comment #33 from notsyncing (song...@gmail.com) ---
Now about half a month passed, and my machine is running fine with zram
disabled. No more freezes. Seems my problem is related to zram, not this bug,
while the "ring gfx timeout" error never
101 - 180 of 180 matches
Mail list logo
