[GIT PULL] drm/tegra: Fixes for v4.18-rc5

2018-07-12 Thread Thierry Reding
Hi Dave, The following changes since commit ce397d215ccd07b8ae3f71db689aedb85d56ab40: Linux 4.18-rc1 (2018-06-17 08:04:49 +0900) are available in the Git repository at: git://anongit.freedesktop.org/tegra/linux tags/drm/tegra/for-4.18-rc5 for you to fetch changes up to 5265f0338bc0feec6c0d

Re: [PATCH 0/3] drm/scheduler: preparation for load balancing

2018-07-12 Thread Christian König
Only a few more style nit picks: Patches #1 and #2 need a commit message. A one liner why we do this should be fine. On Patch #3 you have a couple of places like this: - r = drm_sched_entity_init(&ring->sched, &adev->mman.entity, - rq, NULL); + r =

Re: [PATCH -next] drm/sun4i: DW HDMI: Make symbol sun8i_dw_hdmi_pltfm_driver static

2018-07-12 Thread Maxime Ripard
On Wed, Jul 11, 2018 at 01:22:47PM +, Wei Yongjun wrote: > Fixes the following sparse warning: > > drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c:228:24: warning: > symbol 'sun8i_dw_hdmi_pltfm_driver' was not declared. Should it be static? > > Signed-off-by: Wei Yongjun Applied, thanks! Maxime --

Re: [PATCH v3] drm/sun4i: mixer: Read id from DT

2018-07-12 Thread Maxime Ripard
On Wed, Jul 11, 2018 at 01:27:06PM +0200, Jernej Skrabec wrote: > Currently, TCON supports 2 ways to match TCON with engine (mixer in this > case). Old way is to just traverse of graph backwards and compare node > pointer. New way is to match TCON and engine by their respective ids. > All SoCs with

Re: [PATCH] [v3] drm/sun4i: fix build failure with CONFIG_DRM_SUN8I_MIXER=m

2018-07-12 Thread Maxime Ripard
On Wed, Jul 11, 2018 at 04:43:10PM +0200, Arnd Bergmann wrote: > Having DRM_SUN4I built-in but DRM_SUN8I_MIXER as a loadable module results in > a link error, as we try to access a symbol from the sun8i_tcon_top.ko module: > > ERROR: "sun8i_tcon_top_of_table" [drivers/gpu/drm/sun4i/sun8i-drm-hdmi.

Re: [PATCH v2] i915/intel_tv_get_modes: fix strncpy truncation warning

2018-07-12 Thread Chris Wilson
Quoting Dominique Martinet (2018-07-12 00:24:46) > Change it to use strlcpy instead > > Signed-off-by: Dominique Martinet Reviewed-by: Chris Wilson -Chris ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/

[Bug 107082] With 4.18 rc kernel stop working video output on AMD GPU Vega 56

2018-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107082 --- Comment #2 from Michel Dänzer --- (In reply to Nicholas Kazlauskas from comment #1) > This should be fixed with: https://patchwork.freedesktop.org/patch/233283/ > The fix is also availble if you use amd-staging-drm-next. Since the regressio

[Bug 105760] [4.17-rc1] RIP: smu7_populate_single_firmware_entry.isra.6+0x57/0xc0 [amdgpu] RSP: ffffa17901efb930

2018-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105760 --- Comment #34 from Thomas Martitz --- Created attachment 140585 --> https://bugs.freedesktop.org/attachment.cgi?id=140585&action=edit dmesg with 0001-drm-amdgpu-pp-smu7-cache-smu-firmware-toc.patch This patch makes resume work, attached is

[PATCH] drm/sun4i: tcon-top: Fix return type warning

2018-07-12 Thread Maxime Ripard
When commit af11942ee44e ("drm/sun4i: tcon-top: Cleanup clock handling") was merged, the error handling path of the of_property_match_string was changed to take into account the fact that the returned value of that function wasn't an error pointer but an error code. Unfortunately, this introduced

[PATCH 01/10] drm: crc: Introduce verify_crc_source callback

2018-07-12 Thread Mahesh Kumar
This patch adds a new callback function "verify_crc_source" which will be used during setting the crc source in control node. This will help in avoiding setting of wrong string for source. Changes since V1: - do not yet verify_crc_source during open. Signed-off-by: Mahesh Kumar Cc: dri-devel@li

[PATCH 00/10] Improve crc-core driver interface

2018-07-12 Thread Mahesh Kumar
This series improves crc-core <-> driver interface. This series adds following functionality in the crc-core - Now control node will print all the available sources if implemented by driver along with current source. - Setting of sorce will fail if provided source is not supported - cleanup o

[PATCH 04/10] drm/amdgpu_dm/crc: Implement verify_crc_source callback

2018-07-12 Thread Mahesh Kumar
This patch implements "verify_crc_source" callback function for AMD drm driver. Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Reviewed-by: Maarten Lankhorst Acked-by: Leo Li --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 + drivers/gpu/drm/amd/display/amdgpu_d

[PATCH 05/10] drm/rcar-du/crc: Implement verify_crc_source callback

2018-07-12 Thread Mahesh Kumar
This patch implements "verify_crc_source" callback function for rcar drm driver. Changes Since V1: - avoid duplication of code Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Cc: Laurent Pinchart Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 66 +

[PATCH 02/10] drm: crc: Introduce get_crc_sources callback

2018-07-12 Thread Mahesh Kumar
This patch introduce a callback function "get_crc_sources" which will be called during read of control node. It is an optional callback function and if driver implements this callback, driver should return a constant pointer to an array of crc sources list and update count according to the number o

[PATCH 03/10] drm/rockchip/crc: Implement verify_crc_source callback

2018-07-12 Thread Mahesh Kumar
This patch implements "verify_crc_source" callback function for rockchip drm driver. Changes since V1: - simplify the verification (Jani N) Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Reviewed-by: Maarten Lankhorst Acked-by: Heiko Stuebner --- drivers/gpu/drm/rockchip/roc

Re: [PATCH] drm/sun4i: tcon-top: Fix return type warning

2018-07-12 Thread Daniel Vetter
On Thu, Jul 12, 2018 at 10:08:18AM +0200, Maxime Ripard wrote: > When commit af11942ee44e ("drm/sun4i: tcon-top: Cleanup clock handling") > was merged, the error handling path of the of_property_match_string was > changed to take into account the fact that the returned value of that > function wasn

[PATCH 07/10] drm/i915/crc: implement get_crc_sources callback

2018-07-12 Thread Mahesh Kumar
This patch implements get_crc_sources callback, which returns list of all the valid crc sources supported by driver in current platform. Changes since V1: - Return array of crc sources Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Reviewed-by: Maarten Lankhorst --- drivers/g

[PATCH 09/10] Revert "drm: crc: Wait for a frame before returning from open()"

2018-07-12 Thread Mahesh Kumar
This reverts commit e8fa5671183c80342d520ad81d14fa79a9d4a680. Don't wait for first CRC during crtc_crc_open. It avoids one frame wait during open. If application want to wait after read call, it can use poll/read blocking read() call. Suggested-by: Ville Syrjälä Signed-off-by: Mahesh Kumar Cc:

[PATCH 06/10] drm/i915/crc: implement verify_crc_source callback

2018-07-12 Thread Mahesh Kumar
This patch implements verify_crc_source callback function introduced earlier in this series. Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_display.c | 1 + drivers/gpu/drm/i915/intel_drv.h | 3 + drivers/g

[PATCH 08/10] drm/crc: Cleanup crtc_crc_open function

2018-07-12 Thread Mahesh Kumar
This patch make changes to allocate crc-entries buffer before enabling CRC generation. It moves all the failure check early in the function before setting the source or memory allocation. Now set_crc_source takes only two variable inputs, values_cnt we already gets as part of verify_crc_source. Ch

Re: [PATCH v5 2/3] fbcon: Call WARN_CONSOLE_UNLOCKED() where applicable

2018-07-12 Thread Sergey Senozhatsky
Hi, On (07/11/18 16:46), Thomas Zimmermann wrote: > Am 28.06.2018 um 11:03 schrieb Hans de Goede: > > Replace comments about places where the console lock should be held with > > calls to WARN_CONSOLE_UNLOCKED() to assert that it is actually held. > > Debugging fbcon sometimes requires to not tak

[PATCH] i915/intel_tv_get_modes: fix strncpy truncation warning

2018-07-12 Thread Dominique Martinet
This is effectively no-op as the next line writes a nul at the final byte of the buffer, so copying one letter less does not change the behaviour. Signed-off-by: Dominique Martinet --- gcc 8 gives the following warning, which I am not sure why is treated as error for this file, thus making me fi

[PATCH -next] drm/sun4i: DW HDMI: Make symbol sun8i_dw_hdmi_pltfm_driver static

2018-07-12 Thread Wei Yongjun
Fixes the following sparse warning: drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c:228:24: warning: symbol 'sun8i_dw_hdmi_pltfm_driver' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Regression on the sun4i-drm driver by cma helper change

2018-07-12 Thread Icenowy Zheng
Hi, Today, during testing the Banana Pi M2 Zero HDMI patch, I found a regression on the sun4i-drm driver, which happenes because of the cma helper change. The bad commit is 894a677f4b3e6d2ab8d01bb46c1fbd5f92e4591b ("drm/cma- helper: Use the generic fbdev emulation"). If this commit is present, s

Re: [BUG 4.17] etnaviv-gpu f1840000.gpu: recover hung GPU!

2018-07-12 Thread Russell King - ARM Linux
On Tue, Jun 19, 2018 at 02:28:46PM +0200, Lucas Stach wrote: > See attached patch (which I apparently forgot to send out). The DRM GPU > scheduler has some tracepoints, which might be helpful. The attached > patch adds a drm_sched_job_run tracepoint when a job is queued in the > hardware ring. Toge

Re: [PATCH 02/12] blk: use for_each_if

2018-07-12 Thread Jens Axboe
On 7/11/18 3:08 PM, Daniel Vetter wrote: > On Wed, Jul 11, 2018 at 10:06 PM, Tejun Heo wrote: >> On Wed, Jul 11, 2018 at 01:31:51PM -0600, Jens Axboe wrote: >>> I don't think there's a git easy way of sending it out outside of >>> just ensuring that everybody is CC'ed on everything. I don't mind >

Re: [PATCH] drm/client: Fix: drm_client_new: Don't require DRM to be registered

2018-07-12 Thread Icenowy Zheng
在 2018-07-11三的 17:56 +0200,Noralf Trønnes写道: > Commit 894a677f4b3e ("drm/cma-helper: Use the generic fbdev > emulation") > broke almost all drivers that use the CMA helper. > > The reason is that drm_client_new() requires that the DRM device has > been registered, but the drivers register fbdev be

Re: [PATCH 02/12] blk: use for_each_if

2018-07-12 Thread Jens Axboe
On 7/11/18 12:50 PM, Daniel Vetter wrote: > On Wed, Jul 11, 2018 at 8:30 PM, Jens Axboe wrote: >> On 7/11/18 10:45 AM, Tejun Heo wrote: >>> On Wed, Jul 11, 2018 at 09:40:58AM -0700, Tejun Heo wrote: On Mon, Jul 09, 2018 at 10:36:40AM +0200, Daniel Vetter wrote: > Makes the macros resilien

Re: [PATCH] drm/etnaviv: bring back progress check in job timeout handler

2018-07-12 Thread Russell King - ARM Linux
On Wed, Jun 27, 2018 at 04:34:27PM +0200, Lucas Stach wrote: > When the hangcheck handler was replaced by the DRM scheduler timeout > handling we dropped the forward progress check, as this might allow > clients to hog the GPU for a long time with a big job. > > It turns out that even reasonably w

Re: [PATCH 02/12] blk: use for_each_if

2018-07-12 Thread Jens Axboe
On 7/11/18 10:45 AM, Tejun Heo wrote: > On Wed, Jul 11, 2018 at 09:40:58AM -0700, Tejun Heo wrote: >> On Mon, Jul 09, 2018 at 10:36:40AM +0200, Daniel Vetter wrote: >>> Makes the macros resilient against if {} else {} blocks right >>> afterwards. >>> >>> Signed-off-by: Daniel Vetter >>> Cc: Tejun

Re: [PATCH v2 00/18] Allwinner R40 HDMI refactoring

2018-07-12 Thread Jernej Škrabec
Dne sreda, 11. julij 2018 ob 10:30:36 CEST je Maxime Ripard napisal(a): > On Tue, Jul 10, 2018 at 10:34:53PM +0200, Jernej Skrabec wrote: > > This series fixes several issues found in R40 HDMI patch series after > > it was applied. Conversation can be found here: > > http://lists.infradead.org/pipe

[PATCH v3] drm/sun4i: mixer: Read id from DT

2018-07-12 Thread Jernej Skrabec
Currently, TCON supports 2 ways to match TCON with engine (mixer in this case). Old way is to just traverse of graph backwards and compare node pointer. New way is to match TCON and engine by their respective ids. All SoCs with DE2 enabled till now used the old way, which means mixer id was never u

[PATCH v2] i915/intel_tv_get_modes: fix strncpy truncation warning

2018-07-12 Thread Dominique Martinet
Change it to use strlcpy instead Signed-off-by: Dominique Martinet --- drivers/gpu/drm/i915/intel_tv.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_tv.c b/drivers/gpu/drm/i915/intel_tv.c index b55b5c157e38..25fee7dba7e2 100644 --- a/drivers/gp

Re: [linux-sunxi] Re: [PATCH v2 00/18] Allwinner R40 HDMI refactoring

2018-07-12 Thread Jernej Škrabec
Dne sreda, 11. julij 2018 ob 11:30:16 CEST je Maxime Ripard napisal(a): > On Wed, Jul 11, 2018 at 10:41:54AM +0200, Jernej Škrabec wrote: > > Dne sreda, 11. julij 2018 ob 10:30:36 CEST je Maxime Ripard napisal(a): > > > On Tue, Jul 10, 2018 at 10:34:53PM +0200, Jernej Skrabec wrote: > > > > This se

Re: [Intel-gfx] [PATCH 11/12] sched: use for_each_if in topology.h

2018-07-12 Thread Mark Rutland
On Mon, Jul 09, 2018 at 07:55:20PM +0200, Daniel Vetter wrote: > On Mon, Jul 9, 2018 at 6:12 PM, Mark Rutland wrote: > > On Mon, Jul 09, 2018 at 06:03:42PM +0200, Peter Zijlstra wrote: > >> On Mon, Jul 09, 2018 at 05:52:04PM +0200, Daniel Vetter wrote: > >> > for_each_something(foo) > >> > if

[PATCH] drm/probe-helper: Fix modes reporting for writeback connector

2018-07-12 Thread Alexandru Gheorghe
Writeback connector is reported as disconnected, currently this causes the setting of the edid property to null and then exit. In order to properly get the modes for writeback we need to add an exception when connector type is DRM_MODE_CONNECTOR_WRITEBACK. Signed-off-by: Alexandru Gheorghe --- d

[PATCH] drm: mali-dp: Set encoder possible_clones

2018-07-12 Thread Alexandru Gheorghe
Set possible_clones field to report that the writeback connector and the one driving the display could be enabled at the same time. Signed-off-by: Alexandru Gheorghe --- drivers/gpu/drm/arm/malidp_drv.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/arm/malidp_dr

Re: [PATCH] drm/probe-helper: Fix modes reporting for writeback connector

2018-07-12 Thread Daniel Vetter
On Thu, Jul 12, 2018 at 09:48:02AM +0100, Alexandru Gheorghe wrote: > Writeback connector is reported as disconnected, currently this causes > the setting of the edid property to null and then exit. > In order to properly get the modes for writeback we need to add an > exception when connector type

[PATCH] drm/client: Fix double free in error path

2018-07-12 Thread Noralf Trønnes
This fixes a static checker warning: drivers/gpu/drm/drm_client.c:289 drm_client_buffer_create() error: double free of 'buffer' drm_client_buffer_delete() frees the buffer so remove the extra free. Fixes: c76f0f7cb546 ("drm: Begin an API for in-kernel clients") Reported-by: Dan C

Re: [PATCH v2] i915/intel_tv_get_modes: fix strncpy truncation warning

2018-07-12 Thread Chris Wilson
Quoting Dominique Martinet (2018-07-12 00:24:46) > Change it to use strlcpy instead > > Signed-off-by: Dominique Martinet Thanks for the spotting the issue and providing a fix, pushed. -Chris ___ dri-devel mailing list dri-devel@lists.freedesktop.org h

Re: [PATCH] drm/probe-helper: Fix modes reporting for writeback connector

2018-07-12 Thread Alexandru-Cosmin Gheorghe
On Thu, Jul 12, 2018 at 10:55:47AM +0200, Daniel Vetter wrote: > On Thu, Jul 12, 2018 at 09:48:02AM +0100, Alexandru Gheorghe wrote: > > Writeback connector is reported as disconnected, currently this causes > > the setting of the edid property to null and then exit. > > In order to properly get th

Re: [PATCH 1/3] drm: mxsfb: Change driver.name to mxsfb-drm

2018-07-12 Thread Stefan Agner
On 10.07.2018 11:11, Marek Vasut wrote: > On 07/10/2018 11:06 AM, Stefan Agner wrote: >> On 16.06.2018 01:32, Marek Vasut wrote: >>> On 06/16/2018 12:42 AM, Leonard Crestez wrote: On Fri, 2018-06-15 at 23:36 +0200, Marek Vasut wrote: > On 06/15/2018 10:58 PM, Leonard Crestez wrote: >>

Re: [PATCH v5 2/3] fbcon: Call WARN_CONSOLE_UNLOCKED() where applicable

2018-07-12 Thread Thomas Zimmermann
Am 11.07.2018 um 21:19 schrieb Steven Rostedt: > I just sent the patch. If the printk maintainers take it, then you can > update the fb driver to set the ignore_console_lock_warning when > lockless_fb_register is set. Thank you. > > -- Steve > ___ > dr

Re: [PATCH 01/10] drm: crc: Introduce verify_crc_source callback

2018-07-12 Thread Laurent Pinchart
Hi Mahesh, Thank you for the patch. On Thursday, 12 July 2018 11:36:26 EEST Mahesh Kumar wrote: > This patch adds a new callback function "verify_crc_source" which will > be used during setting the crc source in control node. This will help > in avoiding setting of wrong string for source. > > C

Re: [PATCH 00/10] Improve crc-core driver interface

2018-07-12 Thread Laurent Pinchart
Hi Mahesh, Thank you for the patches. When resubmitting patch series, could you please add a version number to the [PATCH] prefix ? Otherwise it gets difficult to figure out which version is the latest. This can be done automatically with the -v argument to git-format- patch. On Thursday, 12 J

Re: [PATCH 02/10] drm: crc: Introduce get_crc_sources callback

2018-07-12 Thread Laurent Pinchart
Hi Mahesh, Thank you for the patch. On Thursday, 12 July 2018 11:36:27 EEST Mahesh Kumar wrote: > This patch introduce a callback function "get_crc_sources" which > will be called during read of control node. It is an optional > callback function and if driver implements this callback, driver > s

Re: [PATCH 05/10] drm/rcar-du/crc: Implement verify_crc_source callback

2018-07-12 Thread Laurent Pinchart
Hi Mahesh, Thank you for the patch. On Thursday, 12 July 2018 11:36:30 EEST Mahesh Kumar wrote: > This patch implements "verify_crc_source" callback function for > rcar drm driver. > > Changes Since V1: > - avoid duplication of code > > Signed-off-by: Mahesh Kumar > Cc: dri-devel@lists.freede

Re: [PATCH 08/10] drm/crc: Cleanup crtc_crc_open function

2018-07-12 Thread Laurent Pinchart
Hi Mahesh, Thank you for the patch. On Thursday, 12 July 2018 11:36:33 EEST Mahesh Kumar wrote: > This patch make changes to allocate crc-entries buffer before > enabling CRC generation. > It moves all the failure check early in the function before setting > the source or memory allocation. > Now

[Bug 106258] AMD Xorg start failes with non-4K page sizes

2018-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106258 --- Comment #42 from Dan Horák --- for the record output of "git describe 38e624a18f9a05b" v4.18-rc1-36-g38e624a18f9a -- You are receiving this mail because: You are the assignee for the bug.___ dri-

Re: [PATCH v2] drm: Replace NULL with error value in drm_prime_pages_to_sg

2018-07-12 Thread Oleksandr Andrushchenko
On 06/18/2018 03:32 PM, Oleksandr Andrushchenko wrote: On 06/18/2018 03:29 PM, Dan Carpenter wrote: On Mon, Jun 18, 2018 at 09:07:09AM +0300, Oleksandr Andrushchenko wrote: drivers/gpu/drm/drm_gem_cma_helper.c    | 2 +-   drivers/gpu/drm/xen/xen_drm_front_gem.c | 2 +-   2 files changed, 2 inser

Re: [PATCH 1/3] drm: mxsfb: Change driver.name to mxsfb-drm

2018-07-12 Thread Stefan Agner
[adding Authors of the problematic device trees] On 10.07.2018 11:11, Marek Vasut wrote: > On 07/10/2018 11:06 AM, Stefan Agner wrote: >> On 16.06.2018 01:32, Marek Vasut wrote: >>> On 06/16/2018 12:42 AM, Leonard Crestez wrote: On Fri, 2018-06-15 at 23:36 +0200, Marek Vasut wrote: > On 0

Re: [PATCH v2] drm: Replace NULL with error value in drm_prime_pages_to_sg

2018-07-12 Thread Dan Carpenter
On Thu, Jul 12, 2018 at 02:58:00PM +0300, Oleksandr Andrushchenko wrote: > On 06/18/2018 03:32 PM, Oleksandr Andrushchenko wrote: > > On 06/18/2018 03:29 PM, Dan Carpenter wrote: > > > On Mon, Jun 18, 2018 at 09:07:09AM +0300, Oleksandr Andrushchenko wrote: > > > > drivers/gpu/drm/drm_gem_cma_helpe

Re: [PATCH 12/15] drm/doc: Group the fb gem helpers better

2018-07-12 Thread Noralf Trønnes
Den 09.07.2018 10.40, skrev Daniel Vetter: Instead of spreading them all over the place. Cc: Noralf Trønnes Signed-off-by: Daniel Vetter --- Acked-by: Noralf Trønnes Documentation/gpu/drm-kms-helpers.rst | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --

Re: [PATCH v8 3/6] mfd: cros-ec: Increase maximum mkbp event size

2018-07-12 Thread Lee Jones
On Wed, 04 Jul 2018, Neil Armstrong wrote: > Having a 16 byte mkbp event size makes it possible to send CEC > messages from the EC to the AP directly inside the mkbp event > instead of first doing a notification and then a read. > > Signed-off-by: Stefan Adolfsson > Signed-off-by: Neil Armstrong

Re: [PATCH v8 0/6] Add ChromeOS EC CEC Support

2018-07-12 Thread Lee Jones
On Wed, 04 Jul 2018, Neil Armstrong wrote: > Hi All, > > The new Google "Fizz" Intel-based ChromeOS device is gaining CEC support > through it's Embedded Controller, to enable the Linux CEC Core to communicate > with it and get the CEC Physical Address from the correct HDMI Connector, the > follo

Re: [PATCH] drm: mali-dp: Set encoder possible_clones

2018-07-12 Thread Ville Syrjälä
On Thu, Jul 12, 2018 at 09:48:56AM +0100, Alexandru Gheorghe wrote: > Set possible_clones field to report that the writeback connector and > the one driving the display could be enabled at the same time. > > Signed-off-by: Alexandru Gheorghe > --- > drivers/gpu/drm/arm/malidp_drv.c | 10

Re: [PATCH v8 0/6] Add ChromeOS EC CEC Support

2018-07-12 Thread Neil Armstrong
Hi Lee, On 12/07/2018 14:26, Lee Jones wrote: > On Wed, 04 Jul 2018, Neil Armstrong wrote: > >> Hi All, >> >> The new Google "Fizz" Intel-based ChromeOS device is gaining CEC support >> through it's Embedded Controller, to enable the Linux CEC Core to communicate >> with it and get the CEC Physic

Re: [Intel-gfx] [PATCH] i915/intel_tv_get_modes: fix strncpy truncation warning

2018-07-12 Thread Ville Syrjälä
On Wed, Jul 11, 2018 at 09:46:15AM +0200, Dominique Martinet wrote: > This is effectively no-op as the next line writes a nul at the final What is "This". Please write self contained commit messages. > byte of the buffer, so copying one letter less does not change the > behaviour. > > Signed-off

[Bug 107204] GPU hang (ring gfx timeout) in OpenGL game

2018-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107204 Bug ID: 107204 Summary: GPU hang (ring gfx timeout) in OpenGL game Product: Mesa Version: git Hardware: All OS: All Status: NEW Severity: normal

Re: [PATCH] drm: mali-dp: Set encoder possible_clones

2018-07-12 Thread Alexandru-Cosmin Gheorghe
On Thu, Jul 12, 2018 at 03:37:36PM +0300, Ville Syrjälä wrote: > On Thu, Jul 12, 2018 at 09:48:56AM +0100, Alexandru Gheorghe wrote: > > Set possible_clones field to report that the writeback connector and > > the one driving the display could be enabled at the same time. > > > > Signed-off-by: Al

Re: [PATCH v8 0/6] Add ChromeOS EC CEC Support

2018-07-12 Thread Hans Verkuil
On 12/07/18 14:42, Neil Armstrong wrote: > Hi Lee, > > On 12/07/2018 14:26, Lee Jones wrote: >> On Wed, 04 Jul 2018, Neil Armstrong wrote: >> >>> Hi All, >>> >>> The new Google "Fizz" Intel-based ChromeOS device is gaining CEC support >>> through it's Embedded Controller, to enable the Linux CEC C

Re: [PATCH] drm/probe-helper: Fix modes reporting for writeback connector

2018-07-12 Thread Daniel Vetter
On Thu, Jul 12, 2018 at 10:20:35AM +0100, Alexandru-Cosmin Gheorghe wrote: > On Thu, Jul 12, 2018 at 10:55:47AM +0200, Daniel Vetter wrote: > > On Thu, Jul 12, 2018 at 09:48:02AM +0100, Alexandru Gheorghe wrote: > > > Writeback connector is reported as disconnected, currently this causes > > > the

Re: [PATCH] drm: mali-dp: Set encoder possible_clones

2018-07-12 Thread Ville Syrjälä
On Thu, Jul 12, 2018 at 01:54:07PM +0100, Alexandru-Cosmin Gheorghe wrote: > On Thu, Jul 12, 2018 at 03:37:36PM +0300, Ville Syrjälä wrote: > > On Thu, Jul 12, 2018 at 09:48:56AM +0100, Alexandru Gheorghe wrote: > > > Set possible_clones field to report that the writeback connector and > > > the on

[Bug 105760] [4.17-rc1] RIP: smu7_populate_single_firmware_entry.isra.6+0x57/0xc0 [amdgpu] RSP: ffffa17901efb930

2018-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105760 --- Comment #35 from Alex Deucher --- Created attachment 140590 --> https://bugs.freedesktop.org/attachment.cgi?id=140590&action=edit use gtt for firmware buffers I still don't understand what's corrupting the cpu pointer. Ultimately, it loo

[Bug 105760] [4.17-rc1] RIP: smu7_populate_single_firmware_entry.isra.6+0x57/0xc0 [amdgpu] RSP: ffffa17901efb930

2018-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105760 Thomas Martitz changed: What|Removed |Added Attachment #140560|0 |1 is obsolete|

[Bug 105760] [4.17-rc1] RIP: smu7_populate_single_firmware_entry.isra.6+0x57/0xc0 [amdgpu] RSP: ffffa17901efb930

2018-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105760 --- Comment #37 from Thomas Martitz --- Created attachment 140592 --> https://bugs.freedesktop.org/attachment.cgi?id=140592&action=edit dmesg with 0001-workaround-v2.patch -- You are receiving this mail because: You are the assignee for the

[Bug 105760] [4.17-rc1] RIP: smu7_populate_single_firmware_entry.isra.6+0x57/0xc0 [amdgpu] RSP: ffffa17901efb930

2018-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105760 --- Comment #38 from Alex Deucher --- (In reply to Thomas Martitz from comment #36) > Created attachment 140591 [details] [review] > workaround without memcpy > > I made the following patch as an alternative workaround. The printks I added > in

Re: [PATCH] drm/client: Fix double free in error path

2018-07-12 Thread Daniel Vetter
On Thu, Jul 12, 2018 at 11:18:40AM +0200, Noralf Trønnes wrote: > This fixes a static checker warning: > > drivers/gpu/drm/drm_client.c:289 drm_client_buffer_create() > error: double free of 'buffer' > > drm_client_buffer_delete() frees the buffer so remove the extra free. > > Fixes:

[Bug 105760] [4.17-rc1] RIP: smu7_populate_single_firmware_entry.isra.6+0x57/0xc0 [amdgpu] RSP: ffffa17901efb930

2018-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105760 Alex Deucher changed: What|Removed |Added Attachment #140584|0 |1 is obsolete|

[PATCH v2] console: Replace #if 1 with a bool to ignore

2018-07-12 Thread Steven Rostedt
From: Steven Rostedt (VMware) There's been discussion on the fb list about the addition of WARN_CONSOLE_UNLOCKED() inside the fb code. The complaint is that when the fb module is loaded with lockless_register_fb the console lock is not taken for debugging reasons. With the addition of WARN_CONSO

Re: [PATCH v2] console: Replace #if 1 with a bool to ignore

2018-07-12 Thread Steven Rostedt
On Thu, 12 Jul 2018 09:29:38 -0400 Steven Rostedt wrote: > From: Steven Rostedt (VMware) > > There's been discussion on the fb list about the addition of > WARN_CONSOLE_UNLOCKED() inside the fb code. The complaint is that when > the fb module is loaded with lockless_register_fb the console lock

[Bug 105760] [4.17-rc1] RIP: smu7_populate_single_firmware_entry.isra.6+0x57/0xc0 [amdgpu] RSP: ffffa17901efb930

2018-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105760 --- Comment #40 from Thomas Martitz --- Further investigations show that toc->num_entires and toc->structure_version are set to -1 after the first call to smu7_request_smu_load_fw(). Does that makes sense? Since you say the GPU does not properl

[Bug 105760] [4.17-rc1] RIP: smu7_populate_single_firmware_entry.isra.6+0x57/0xc0 [amdgpu] RSP: ffffa17901efb930

2018-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105760 --- Comment #41 from Alex Deucher --- (In reply to Thomas Martitz from comment #40) > Further investigations show that toc->num_entires and toc->structure_version > are set to -1 after the first call to smu7_request_smu_load_fw(). Does that > ma

[PATCH V4 0/4] Add infrastructure for vblank and page flip events in vkms

2018-07-12 Thread Rodrigo Siqueira
Currently, we are working to make VKMS pass in the kms_flip test (IGT). As a result, we made a series of changes in the module with the goal to meet some of the necessary steps required by kms_flip. This patchset comprises all the modifications needed to make kms_flip partially pass. Finally, this

[PATCH V4 3/4] drm/vkms: Add connectors helpers

2018-07-12 Thread Rodrigo Siqueira
This patch adds the struct drm_connector_helper_funcs with some necessary hooks. Additionally, it also adds some missing hooks at drm_connector_funcs. Changes since V1: - None Changes since V2: Daniel Vetter: - Remove vkms_conn_mode_valid Changes since V3: - None Signed-off-by: Rodrigo Siqueira

[PATCH V4 1/4] drm/vkms: Add dumb operations

2018-07-12 Thread Rodrigo Siqueira
VKMS currently does not handle dumb data, and as a consequence, it does not provide mechanisms for handling gem. This commit adds the necessary support for gem object/handler and the dumb functions. Changes since V1: Daniel Vetter: - Add dumb buffer support to the same patchset Changes since V2:

[PATCH V4 2/4] drm/vkms: Add framebuffer and plane helpers

2018-07-12 Thread Rodrigo Siqueira
This patch appends the minimum helpers related to framebuffer and plane to make vkms minimally usable. Changes since V1: - None Changes since V2: - Squash "Add plane helper struct" and "Add helper for framebuffer create" Changes since V3: Daniel Vetter: - Remove atomic_check from plane helper

[PATCH V4 4/4] drm/vkms: Add vblank events simulated by hrtimers

2018-07-12 Thread Rodrigo Siqueira
This commit adds regular vblank events simulated through hrtimers, which is a feature required by VKMS to mimic real hardware. Additionally, all the vblank event send after pageflip is kept in the atomic_flush function. Changes since V1: - Compute the vblank timer interval per interruption Ville

Re: [PATCH] ARM: dts: imx6sl: Add vivante gpu nodes

2018-07-12 Thread Fabio Estevam
Hi Leonard, On Thu, Jul 12, 2018 at 10:37 AM, Leonard Crestez wrote: > diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi > index a6bc21433839..49a56b4fd393 100644 > --- a/arch/arm/boot/dts/imx6sl.dtsi > +++ b/arch/arm/boot/dts/imx6sl.dtsi > @@ -130,10 +130,30 @@ >

Re: [PATCH 1/3] drm: mxsfb: Change driver.name to mxsfb-drm

2018-07-12 Thread Stefan Agner
On 12.07.2018 15:03, Leonard Crestez wrote: > On Thu, 2018-07-12 at 11:21 +0200, Stefan Agner wrote: >> On 10.07.2018 11:11, Marek Vasut wrote: >> > On 07/10/2018 11:06 AM, Stefan Agner wrote: >> > > This is one of the situation where states quo is kinda the worst >> > > situation. >> > > >> > > Cu

Re: [PATCH 15/15] drm: drop drmP.h include from drm_crtc.c

2018-07-12 Thread Sean Paul
On Mon, Jul 09, 2018 at 10:40:16AM +0200, Daniel Vetter wrote: > This is starting to become easy! > > Note: This needs the patch to move for_each_if from drmP.h to kernel.h > or it won't compile. > > Signed-off-by: Daniel Vetter Once for_each_if gets sorted out (however it goes). Reviewed-by:

Re: [PATCH 01/15] drm: move drv test macros out of drmP.h

2018-07-12 Thread Sean Paul
On Mon, Jul 09, 2018 at 10:40:02AM +0200, Daniel Vetter wrote: > Last bit the prevented us from starting to delete the drmP.h monster > includes from source files! > > Also add kernel-doc while moving them. > > A nice consistent drm_dev_ prefix would be cute for these, but since > they're used ev

Re: [PATCH 02/15] drm: Drop drmP.h from drm_connector.c

2018-07-12 Thread Sean Paul
On Mon, Jul 09, 2018 at 10:40:03AM +0200, Daniel Vetter wrote: > Only needed minimal changes in drm_internal.h (for the drm_ioctl_t > type and a few forward declarations), plus a few missing includes in > drm_connector.c. > > Yay, the last stage of the drm header cleanup can finally commence! > >

Re: [PATCH] ARM: dts: imx6sl: Add vivante gpu nodes

2018-07-12 Thread Lucas Stach
Am Donnerstag, den 12.07.2018, 16:37 +0300 schrieb Leonard Crestez: > The imx6sl soc has gpu_2d and gpu_vg, no 3d support: > > etnaviv-gpu 220.gpu: model: GC320, revision: 5007 > etnaviv-gpu 2204000.gpu: model: GC355, revision: 1215 > > The IP blocks are close enough to supported hardware tha

Re: [PATCH 03/15] drm/doc: switch drm_connector_state to inline comments

2018-07-12 Thread Sean Paul
On Mon, Jul 09, 2018 at 10:40:04AM +0200, Daniel Vetter wrote: > For consistency. Also spelled out the docs for ->best_encoder a bit > more while at it. > > Signed-off-by: Daniel Vetter Reviewed-by: Sean Paul > --- > include/drm/drm_connector.h | 14 ++ > 1 file changed, 10 insert

[Bug 107082] With 4.18 rc kernel stop working video output on AMD GPU Vega 56

2018-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107082 --- Comment #3 from Harry Wentland --- Created attachment 140594 --> https://bugs.freedesktop.org/attachment.cgi?id=140594&action=edit [PATCH] drm/amd/display: Convert 10kHz clks from PPLib into kHz for Vega Don't think the other patch would

Re: [PATCH 04/15] drm/doc: polish for sturct drm_connector

2018-07-12 Thread Sean Paul
On Mon, Jul 09, 2018 at 10:40:05AM +0200, Daniel Vetter wrote: > - switch everything over to inline comments > - add notes about locking, links to functions and other related stuff > - also include a note about Ville's soon-to-be-merged > drm_connector_for_each_possible_encoder(). > > Also check

Re: [Intel-gfx] [PATCH] i915/intel_tv_get_modes: fix strncpy truncation warning

2018-07-12 Thread Ville Syrjälä
On Thu, Jul 12, 2018 at 03:55:26PM +0200, Dominique Martinet wrote: > Ville Syrjälä wrote on Thu, Jul 12, 2018: > > On Wed, Jul 11, 2018 at 09:46:15AM +0200, Dominique Martinet wrote: > > > This is effectively no-op as the next line writes a nul at the final > > > > What is "This". Please write se

[Bug 104611] [fiji, polaris10] BUG: unable to handle kernel NULL pointer dereference when waking up displays with amdgpu.dc=1

2018-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104611 --- Comment #8 from Vedran Miletić --- This still occurs on 4.17, despite bug 106194 suggesting otherwise: [ 7670.095885] BUG: unable to handle kernel NULL pointer dereference at 0208 [ 7670.095899] PGD 8003fcee8067 P4D 8003

[Bug 104611] [fiji, polaris10] BUG: unable to handle kernel NULL pointer dereference when waking up displays with amdgpu.dc=1

2018-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104611 --- Comment #9 from Vedran Miletić --- Created attachment 140595 --> https://bugs.freedesktop.org/attachment.cgi?id=140595&action=edit dmesg with fiji amdgpu.dc_log=1 -- You are receiving this mail because: You are the assignee for the bug._

Re: [PATCH V4 2/4] drm/vkms: Add framebuffer and plane helpers

2018-07-12 Thread Daniel Vetter
On Thu, Jul 12, 2018 at 10:41:02AM -0300, Rodrigo Siqueira wrote: > This patch appends the minimum helpers related to framebuffer and plane > to make vkms minimally usable. > > Changes since V1: > - None > Changes since V2: > - Squash "Add plane helper struct" and "Add helper for framebuffer > c

Re: [PATCH v5 11/40] drm/i915: Enable superior HDCP ver that is capable

2018-07-12 Thread Ramalingam C
On Tuesday 10 July 2018 02:14 AM, Sean Paul wrote: On Wed, Jun 27, 2018 at 02:10:00PM +0530, Ramalingam C wrote: Considering that HDCP2.2 is more secure than HDCP1.4, When a setup supports HDCP2.2 and HDCP1.4, HDCP2.2 will be enabled. v2: Included few optimization suggestions [Chris Wilson

Re: [Intel-gfx] [PATCH v5 12/40] drm/i915: Enable HDCP1.4 incase of HDCP2.2 failure

2018-07-12 Thread Ramalingam C
On Tuesday 10 July 2018 02:14 AM, Sean Paul wrote: On Wed, Jun 27, 2018 at 02:10:01PM +0530, Ramalingam C wrote: When HDCP2.2 enabling fails and HDCP1.4 is supported, HDCP1.4 is enabled. Just squash this into patch 11, no need for a separate patch. Doing it in the next version of the series

Re: [Intel-gfx] [PATCH v5 06/40] drm/i915: Define HDCP2.2 related variables

2018-07-12 Thread Ramalingam C
On Tuesday 10 July 2018 02:01 AM, Sean Paul wrote: On Wed, Jun 27, 2018 at 02:09:55PM +0530, Ramalingam C wrote: For upcoming implementation of HDCP2.2 in I915, important variable required for HDCP2.2 are defined. Please just introduce them when you use them. I can't provide useful review on

Re: [Intel-gfx] [PATCH v5 13/40] drm/i915: Implement HDCP2.2 Enable and Disable

2018-07-12 Thread Ramalingam C
On Tuesday 10 July 2018 02:18 AM, Sean Paul wrote: On Wed, Jun 27, 2018 at 02:10:02PM +0530, Ramalingam C wrote: Implements a sequence of enabling and disabling the HDCP2.2 (auth and encryption). This is really hard to review, since all I see are stubs. I'd much rather have each patch do some

[PATCH v2] drm/client: Fix double free in error path

2018-07-12 Thread Noralf Trønnes
This fixes a static checker warning: drivers/gpu/drm/drm_client.c:289 drm_client_buffer_create() error: double free of 'buffer' Extend drm_client_buffer_delete() to handle the case when there's no dumb buffer attached and drop the extra kfree. Fixes: c76f0f7cb546 ("drm: Begin an

[Bug 106225] Kernel panic after modesetting (not on every boot) on ryzen 5 2400g

2018-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106225 --- Comment #33 from Andrea Vettorello --- Created attachment 140596 --> https://bugs.freedesktop.org/attachment.cgi?id=140596&action=edit relevant kernel 4.17.5 log of the oops -- You are receiving this mail because: You are the assignee fo

[PATCH] drm/sti: Replace drm_dev_unref with drm_dev_put

2018-07-12 Thread Thomas Zimmermann
This patch unifies the naming of DRM functions for reference counting of struct drm_device. The resulting code is more aligned with the rest of the Linux kernel interfaces. Signed-off-by: Thomas Zimmermann Acked-by: Benjamin Gaignard --- drivers/gpu/drm/sti/sti_drv.c | 8 1 file change

[Bug 106225] Kernel panic after modesetting (not on every boot) on ryzen 5 2400g

2018-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106225 --- Comment #34 from Andrea Vettorello --- Created attachment 140597 --> https://bugs.freedesktop.org/attachment.cgi?id=140597&action=edit relevant kernel 4.17.5 source of the oops -- You are receiving this mail because: You are the assignee

Re: [PATCH 02/12] blk: use for_each_if

2018-07-12 Thread Joe Perches
On Thu, 2018-07-12 at 07:54 -0600, Jens Axboe wrote: > > Thanks for your invaluable and useful feedback, sharing your vast > experience in patchsets with dependencies. I've probably more experience sending patchsets with dependencies across subsystems than anyone. There is no single style that w

  1   2   >