Re: [PATCH 4/4] drm/i915/intel_dsi: Read back pclk set by GOP and use that as pclk

2018-07-10 Thread Hans de Goede
Hi, On 07/09/2018 08:14 PM, Ville Syrjälä wrote: On Sat, Jul 07, 2018 at 08:32:16AM +0200, Hans de Goede wrote: Any kind of hack that involves reading out the hardware state should go into something like intel_sanitize_encoder(). Actually by that time we have already read out the hw state,

[Bug 107154] [drm] GPU recovery disabled.

2018-07-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107154 Christian König changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

Re: [PATCH 1/3] vulkan: Define new VK_MESA_query_timestamp extension [v2]

2018-07-10 Thread Pekka Paalanen
On Sat, 23 Jun 2018 12:13:53 -0500 Jason Ekstrand wrote: > I haven't thought through this comment all that hard but would it make > sense to have three timestamps, CPU, GPU, CPU so that you have error bars > on the GPU timestamp? At the very least, two timestamps would be better > than one so

[Bug 107175] [CI][SKL][IOMMU] i915: probe of 0000:00:02.0 failed with error -25

2018-07-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107175 Chris Wilson changed: What|Removed |Added QA Contact|intel-gfx-bugs@lists.freede | |sktop.org

[Bug 107175] [CI][SKL][IOMMU] i915: probe of 0000:00:02.0 failed with error -25

2018-07-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107175 --- Comment #1 from Chris Wilson --- Not really IGT either since piglit isn't a part of IGT... -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-

答复: 答复: [alsa-devel] 答复: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

2018-07-10 Thread Qu, Jim
Hi Takashi, I am not expert in audio driver, so I just update some test result, please help triage the issue. With audio runtime pm: 1. ubuntu audio setting use pactl to query audio card/output sink. Attachment is pactl output with audio runtime pm. 2. cat /proc/asound/card0/eld* can get nothi

答复: 答复: [alsa-devel] 答复: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

2018-07-10 Thread Qu, Jim
Sorry, correct the typo. IMO, the issue should be: Current operations like HDMI hotplug in/out, pactl command, they do not access audio HW, so the audio could not resume back at this period. Therefore, upper software could not get HDMI ELD info, it can not select an available card/output sink.

Re: [PATCH] kernel.h: Add for_each_if()

2018-07-10 Thread Daniel Vetter
On Mon, Jul 09, 2018 at 04:30:01PM -0700, Andrew Morton wrote: > On Mon, 9 Jul 2018 18:25:09 +0200 Daniel Vetter > wrote: > > > To avoid compilers complainig about ambigious else blocks when putting > > an if condition into a for_each macro one needs to invert the > > condition and add a dummy

[Bug 106928] When starting a match Rocket League crashes on "Go"

2018-07-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106928 --- Comment #19 from Miroslav Šustek --- By the way, I can reproduce the same problem when I open Google Maps in Firefox. The tab crashes during loading. After few crashes it stops to use WebGL and then it starts to work. -- You are receiving

[Bug 104347] AMD RX 580: Hide/Show Chromium sometimes corrupts screen (see screenshot)

2018-07-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104347 Thomas Rohloff changed: What|Removed |Added CC||v10la...@myway.de --- Comment #18 from

Re: [PATCH 1/4] drm/vkms: Add functions to map GEM backing storage

2018-07-10 Thread Daniel Vetter
On Mon, Jul 09, 2018 at 06:44:26PM +0300, Haneen Mohammed wrote: > This patch add the necessary functions to map GEM > backing memory into the kernel's virtual address space. > > Signed-off-by: Haneen Mohammed > --- > drivers/gpu/drm/vkms/vkms_drv.c | 2 ++ > drivers/gpu/drm/vkms/vkms_drv.h |

Re: 答复: 答复: [alsa-devel] 答复: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

2018-07-10 Thread Takashi Iwai
On Tue, 10 Jul 2018 09:44:42 +0200, Qu, Jim wrote: > > Hi Takashi, > > I am not expert in audio driver, so I just update some test result, please > help triage the issue. > > With audio runtime pm: What does this mean? Is it the stock 4.17.x (or 4.18-rc)? Please clarify your test environment

Re: [PATCH 2/4] drm/vkms: map/unmap buffers in [prepare/cleanup]_fb hooks

2018-07-10 Thread Daniel Vetter
On Mon, Jul 09, 2018 at 06:46:49PM +0300, Haneen Mohammed wrote: > This patch map/unmap GEM backing memory to kernel address space > in prepare/cleanup_fb respectively and cache the virtual address > for later use. > > Signed-off-by: Haneen Mohammed > --- > drivers/gpu/drm/vkms/vkms_plane.c | 41

Re: [PATCH 3/4] drm/vkms: Add atomic_helper_check_plane_state

2018-07-10 Thread Daniel Vetter
On Mon, Jul 09, 2018 at 06:47:34PM +0300, Haneen Mohammed wrote: > Call atomic_helper_check_plane_state to clip plane coordinates. > > Signed-off-by: Haneen Mohammed > --- > drivers/gpu/drm/vkms/vkms_plane.c | 18 -- > 1 file changed, 16 insertions(+), 2 deletions(-) > > diff --

Re: [PATCH 4/4] drm/vkms: subclass CRTC state

2018-07-10 Thread Daniel Vetter
On Mon, Jul 09, 2018 at 06:48:36PM +0300, Haneen Mohammed wrote: > Subclass CRTC state struct to enable storing driver's private > state. This patch only adds the base drm_crtc_state struct and > the atomic functions that handle it. > > Signed-off-by: Haneen Mohammed Reviewed-by: Daniel Vetter

Re: [PATCH 1/4] drm/vkms: Add functions to map GEM backing storage

2018-07-10 Thread Chris Wilson
Quoting Haneen Mohammed (2018-07-09 16:44:26) > +struct page **get_pages(struct vkms_gem_object *vkms_obj) > +{ > + struct drm_gem_object *gem_obj = &vkms_obj->gem; > + struct page **pages = vkms_obj->pages; > + > + if (!pages) { > + mutex_lock(&vkms_obj->pages_lock)

[Bug 106928] When starting a match Rocket League crashes on "Go"

2018-07-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106928 --- Comment #20 from Miroslav Šustek --- Sorry for the unnecessary bump. I did not notice that a patch is already in the staging/18.1 branch: https://github.com/mesa3d/mesa/commit/d68f2d7edeedebf2db58b28a9ac6befb7757afb7 -- You are receiving t

Re: [PATCH] backlight: adp8860: Mark expected switch fall-through

2018-07-10 Thread Daniel Thompson
On Mon, Jul 09, 2018 at 04:51:56PM -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva Having checked the datasheets... Reviewed-by: Daniel Thompson > --- > d

Re: [PATCH 1/3] drm: mxsfb: Change driver.name to mxsfb-drm

2018-07-10 Thread Stefan Agner
On 16.06.2018 01:32, Marek Vasut wrote: > On 06/16/2018 12:42 AM, Leonard Crestez wrote: >> On Fri, 2018-06-15 at 23:36 +0200, Marek Vasut wrote: >>> On 06/15/2018 10:58 PM, Leonard Crestez wrote: On Fri, 2018-06-15 at 16:47 -0300, Fabio Estevam wrote: > On Fri, Jun 15, 2018 at 4:43 PM, Le

Re: 答复: 答复: [alsa-devel] 答复: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

2018-07-10 Thread jimqu
On 2018年07月10日 16:01, Takashi Iwai wrote: On Tue, 10 Jul 2018 09:44:42 +0200, Qu, Jim wrote: Hi Takashi, I am not expert in audio driver, so I just update some test result, please help triage the issue. With audio runtime pm: What does this mean? Is it the stock 4.17.x (or 4.18-rc)? Pleas

Re: [PATCH v3 0/4] drm/panel: Handle the "panel is missing" case properly

2018-07-10 Thread Thierry Reding
On Wed, May 09, 2018 at 03:00:38PM +0200, Boris Brezillon wrote: > Hello, > > This is a new attempt at fixing the "panel is missing" issue (described > in this thread [1]). I lost track of Eric's proposal, but I recently > proposed to address this problem through a new ->detect() hook in the > pan

[Bug 107149] Resuming from suspend can cause not working hw acceleration

2018-07-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107149 --- Comment #1 from Michel Dänzer --- Please attach the dmesg output here directly. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists

Re: [PATCH v4 1/2] drm/panel: Add support for Truly NT35597 panel

2018-07-10 Thread Thierry Reding
On Wed, May 30, 2018 at 03:37:26PM -0700, abhin...@codeaurora.org wrote: > Hi Sean > > Thanks for your review. > > Some responses below. Please help to check. > > Thanks > > Abhinav Looks like this got stuck in review. Some comments below, which I hope will match Sean's opinion. > On 2018-05-

Re: 答复: 答复: [alsa-devel] 答复: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

2018-07-10 Thread Takashi Iwai
On Tue, 10 Jul 2018 11:13:27 +0200, jimqu wrote: > > > > On 2018年07月10日 16:01, Takashi Iwai wrote: > > On Tue, 10 Jul 2018 09:44:42 +0200, > > Qu, Jim wrote: > >> Hi Takashi, > >> > >> I am not expert in audio driver, so I just update some test result, please > >> help triage the issue. > >> >

Re: [PATCH v3 5/9] drm/panel: add support for BOE HV070WSA-100 panel to simple-panel

2018-07-10 Thread Thierry Reding
On Tue, Jun 19, 2018 at 10:19:26AM +0200, Maciej Purski wrote: > From: Andrzej Hajda > > The patch adds support for BOE HV070WSA-100 WSVGA 7.01 inch panel > in panel-simple driver. The panel is used in Exynos5250-arndale boards. > > Signed-off-by: Andrzej Hajda > Signed-off-by: Maciej Purski >

Re: [PATCH v3 4/9] dt-bindings: display: add DT bindings for BOE HV070WSA-100 panel

2018-07-10 Thread Thierry Reding
On Tue, Jun 19, 2018 at 10:19:25AM +0200, Maciej Purski wrote: > From: Andrzej Hajda > > The patch adds bindings to BOE HV070-WSA WSVGA panel. > Bindings are compatible with simple panel bindings. > > Signed-off-by: Andrzej Hajda > Signed-off-by: Maciej Purski > --- > .../bindings/display/pan

Re: [RFC PATCHv2 7/9] drm/panel: simple: add newhaven,nhd-4.3-480272ef-atxl LCD

2018-07-10 Thread Thierry Reding
On Mon, Jun 18, 2018 at 04:22:40PM +0300, Tomi Valkeinen wrote: > Add support for newhaven,nhd-4.3-480272ef-atxl to panel-simple. > > Signed-off-by: Tomi Valkeinen > Cc: Thierry Reding > --- > .../panel/newhaven,nhd-4.3-480272ef-atxl.txt | 7 + > drivers/gpu/drm/panel/panel-simple.c

Re: [PATCH] drm/panel: simple: Add support for Innolux G070Y2-L01

2018-07-10 Thread Thierry Reding
On Mon, Jun 04, 2018 at 01:16:48PM +0200, Christoph Fritz wrote: > This patch adds support for Innolux G070Y2-L01 7" WVGA (800x480) TFT LCD > panel. > > Signed-off-by: Christoph Fritz > --- > .../bindings/display/panel/innolux,g070y2-l01.txt | 12 +++ > drivers/gpu/drm/panel/panel-simple.c

[PATCH 3/3] ARM: dts: cubox: add LCD controller and TDA998x configuration

2018-07-10 Thread Russell King
Add DT configuration for the HDMI display output on the Dove Cubox. This adds support for the LCD0 controller which is connected to a TDA19988 HDMI encoder. Signed-off-by: Russell King --- arch/arm/boot/dts/dove-cubox.dts | 43 1 file changed, 43 insertio

Re: [PATCH v2 1/1] drm/panel: Add support for Olimex LCD-OLinuXino panel

2018-07-10 Thread Thierry Reding
On Mon, Jun 25, 2018 at 09:44:35AM +0300, Stefan Mavrodiev wrote: > This patch adds Olimex Ltd. LCD-OLinuXino bridge panel driver. The > panel is used with different LCDs (currently from 480x272 to 1280x800). > Small EEPROM chip is used for identification, which holds some > factory data and timing

Re: [PATCH 1/2] dt-bindings: Add DataImage, Inc. vendor prefix

2018-07-10 Thread Thierry Reding
On Mon, Jun 25, 2018 at 02:41:29PM +0200, Michal Vokáč wrote: > DataImage is a Taiwan-based manufacturer of LCD panels. > > Signed-off-by: Michal Vokáč > --- > Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + > 1 file changed, 1 insertion(+) Applied, thanks. Thierry signature.asc

Re: [PATCH 2/2] drm/panel: simple: Add support for DataImage SCF0700C48GGU18

2018-07-10 Thread Thierry Reding
On Mon, Jun 25, 2018 at 02:41:30PM +0200, Michal Vokáč wrote: > This adds support for the DataImage SCF0700C48GGU18 7.0" WVGA (800x480) > TFT LCD panel. The panel has 24-bit parallel interface and can be > supported by the simple panel driver. > > Signed-off-by: Michal Vokáč > --- > .../display/

Re: [PATCH][next] drm/panel: ILI9881c: fix missing assignment to error return ret

2018-07-10 Thread Thierry Reding
On Tue, Jun 26, 2018 at 05:03:54PM +0100, Colin King wrote: > From: Colin Ian King > > Currently, ret is being checked for an error condition however it > is not being assigned in the previous statement on the call of > function mipi_dsi_dcs_exit_sleep_mode. Add in the missing assignment > of re

Re: [PATCH v5 1/4] drm/panel: p079zca: refactor panel driver to support multiple panels

2018-07-10 Thread Thierry Reding
On Mon, Jul 02, 2018 at 12:27:18PM +0200, Heiko Stuebner wrote: > From: huang lin > > Refactor Innolux P079ZCA panel driver, let it support > multi panels from Innolux that share similar power sequences. > > Panels may require different power supplies so use regulator bulk > interfaces and defin

Re: [PATCH v5 2/4] drm/panel: p079zca: add variable unprepare_delay properties

2018-07-10 Thread Thierry Reding
On Mon, Jul 02, 2018 at 12:27:19PM +0200, Heiko Stuebner wrote: > From: Lin Huang > > When panel power down, p079zca need delay between reset and disable > power supply, but p097pfg does not need it. Similarly p097zca needs > a delay after entering panel sleep mode. So add two delay properties, >

Re: [PATCH v5 3/4] dt-bindings: Add Innolux P097PFG panel bindings

2018-07-10 Thread Thierry Reding
On Mon, Jul 02, 2018 at 12:27:20PM +0200, Heiko Stuebner wrote: > From: huang lin > > The Innolux P097PFG panel is 9.7" panel with 1536X2048 > resolution, it reuse P079ZCA panel driver, so improve > p079ZCA dt-binding to support P097PFG. > > Changes in v2: > - None > Changes in v3: > - None > Ch

Re: [PATCH v5 4/4] drm/panel: p079zca: support Innolux P097PFG panel

2018-07-10 Thread Thierry Reding
On Mon, Jul 02, 2018 at 12:27:21PM +0200, Heiko Stuebner wrote: > From: Lin Huang > > Support Innolux P097PFG 9.7" 1536x2048 TFT LCD panel, it reuse > the Innolux P079ZCA panel driver. > > Changes in v2: > - None > Changes in v3: > - None > Changes in v4: > - None > Changes in v5: > - Document s

[PATCH] drm/panel: innolux-p079zca: Use of_device_get_match_data()

2018-07-10 Thread Thierry Reding
From: Thierry Reding Use this helper to get rid of some extra boilerplate code. Signed-off-by: Thierry Reding --- drivers/gpu/drm/panel/panel-innolux-p079zca.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-innolux-p079zca.c b/drivers/gpu

Re: [PATCH v2 1/3] dt-bindings: Add vendor prefix for kingdisplay

2018-07-10 Thread Thierry Reding
On Mon, Jul 02, 2018 at 12:32:27PM +0200, Heiko Stuebner wrote: > From: Nickey Yang > > Kingdisplay Technology Co., Ltd, established in > China Shenzhen in 2006, is a national high-tech > enterprise specializing in the R&D, manufacturing > and marketing of TFT-LCM and touch panel. > > Signed-off

Re: [PATCH v2 2/3] dt-bindings: Add KINGDISPLAY KD097D04 panel bindings

2018-07-10 Thread Thierry Reding
On Mon, Jul 02, 2018 at 12:32:28PM +0200, Heiko Stuebner wrote: > From: Nickey Yang > > The KINGDISPLAY KD097D04 is a 9.7" panel with a 1536x2048 > resolution and connected to DSI using 8 lanes. > > Signed-off-by: Nickey Yang > Acked-by: Rob Herring > Signed-off-by: Heiko Stuebner > --- > ..

Re: [PATCH v2 3/3] drm/panel: add Kingdisplay kd097d04 panel driver

2018-07-10 Thread Thierry Reding
On Mon, Jul 02, 2018 at 12:32:29PM +0200, Heiko Stuebner wrote: > From: Nickey Yang > > Support Kingdisplay kd097d04 9.7" 1536x2048 TFT LCD panel, > it is a MIPI dual-DSI panel. > > v2: > - update timing + cmds from chromeos kernel > - new backlight API including switch to devm_of_find_backlight

Re: 答复: 答复: [alsa-devel] 答复: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

2018-07-10 Thread jimqu
On 2018年07月10日 17:50, Takashi Iwai wrote: On Tue, 10 Jul 2018 11:13:27 +0200, jimqu wrote: On 2018年07月10日 16:01, Takashi Iwai wrote: On Tue, 10 Jul 2018 09:44:42 +0200, Qu, Jim wrote: Hi Takashi, I am not expert in audio driver, so I just update some test result, please help triage the i

Re: [PATCH] drm/panel: type promotion bug in s6e8aa0_read_mtp_id()

2018-07-10 Thread Thierry Reding
On Wed, Jul 04, 2018 at 12:38:09PM +0300, Dan Carpenter wrote: > The ARRAY_SIZE() macro is type size_t. If s6e8aa0_dcs_read() returns a > negative error code, then "ret < ARRAY_SIZE(id)" is false because the > negative error code is type promoted to a high positive value. > > Fixes: 02051ca06371

Re: 答复: 答复: [alsa-devel] 答复: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

2018-07-10 Thread Takashi Iwai
On Tue, 10 Jul 2018 13:11:20 +0200, jimqu wrote: > > > > On 2018年07月10日 17:50, Takashi Iwai wrote: > > On Tue, 10 Jul 2018 11:13:27 +0200, > > jimqu wrote: > >> > >> > >> On 2018年07月10日 16:01, Takashi Iwai wrote: > >>> On Tue, 10 Jul 2018 09:44:42 +0200, > >>> Qu, Jim wrote: > Hi Takashi, >

Re: [PATCH 02/10] drm: crc: Introduce get_crc_sources callback

2018-07-10 Thread Laurent Pinchart
Hi Mahesh, Thank you for the patch. On Monday, 2 July 2018 14:07:21 EEST Mahesh Kumar wrote: > This patch introduce a callback function "get_crc_sources" which > will be called during read of control node. It is an optional > callback function and if driver implements this callback, driver > shou

Re: [PATCH 01/10] drm: crc: Introduce verify_crc_source callback

2018-07-10 Thread Laurent Pinchart
Hi Mahesh, Thank you for the patch. On Monday, 2 July 2018 14:07:20 EEST Mahesh Kumar wrote: > This patch adds a new callback function "verify_crc_source" which will > be used during setting the crc source in control node and while opening > data node for crc reading. This will help in avoiding s

Re: [PATCH 05/10] drm/rcar-du/crc: Implement verify_crc_source callback

2018-07-10 Thread Laurent Pinchart
Hi Mahesh, Thank you for the patch. On Monday, 2 July 2018 14:07:24 EEST Mahesh Kumar wrote: > This patch implements "verify_crc_source" callback function for > rcar drm driver. > > Signed-off-by: Mahesh Kumar > Cc: dri-devel@lists.freedesktop.org > Reviewed-by: Maarten Lankhorst > --- > driv

Re: [PATCH 08/10] drm/crc: Cleanup crtc_crc_open function

2018-07-10 Thread Laurent Pinchart
Hi Mahesh, Thank you for the patch. On Monday, 2 July 2018 14:07:27 EEST Mahesh Kumar wrote: > This patch make changes to allocate crc-entries buffer before > enabling CRC generation. > It moves all the failure check early in the function before setting > the source or memory allocation. > Now se

Re: [PATCH 01/10] drm: crc: Introduce verify_crc_source callback

2018-07-10 Thread Kumar, Mahesh
Hi, Thanks for the review, On 7/10/2018 4:56 PM, Laurent Pinchart wrote: Hi Mahesh, Thank you for the patch. On Monday, 2 July 2018 14:07:20 EEST Mahesh Kumar wrote: This patch adds a new callback function "verify_crc_source" which will be used during setting the crc source in control node an

Re: [PATCH 02/10] drm: crc: Introduce get_crc_sources callback

2018-07-10 Thread Kumar, Mahesh
Hi, thanks for the review. On 7/10/2018 4:52 PM, Laurent Pinchart wrote: Hi Mahesh, Thank you for the patch. On Monday, 2 July 2018 14:07:21 EEST Mahesh Kumar wrote: This patch introduce a callback function "get_crc_sources" which will be called during read of control node. It is an optional

Re: [PATCH 09/10] Revert "drm: crc: Wait for a frame before returning from open()"

2018-07-10 Thread Laurent Pinchart
Hi Mahesh, Thank you for the patch. On Monday, 2 July 2018 14:07:28 EEST Mahesh Kumar wrote: > This reverts commit e8fa5671183c80342d520ad81d14fa79a9d4a680. > > Don't wait for first CRC during crtc_crc_open. It avoids one frame wait > during open. If application want to wait after read call, it

Re: [PATCH 10/10] drm: crc: Introduce pre_crc_read function

2018-07-10 Thread Laurent Pinchart
Hi Mahesh, Thank you for the patch. On Monday, 2 July 2018 14:07:29 EEST Mahesh Kumar wrote: > This patch implements a callback function "pre_crc_read" which will > be called before crc read. In this function driver can implement and > preparation work required for successfully reading CRC data.

Re: [PATCH 02/10] drm: crc: Introduce get_crc_sources callback

2018-07-10 Thread Laurent Pinchart
Hi Mahesh, On Tuesday, 10 July 2018 15:01:38 EEST Kumar, Mahesh wrote: > On 7/10/2018 4:52 PM, Laurent Pinchart wrote: > > Hi Mahesh, > > On Monday, 2 July 2018 14:07:21 EEST Mahesh Kumar wrote: > >> This patch introduce a callback function "get_crc_sources" which > >> will be called during read o

Re: [PATCH 01/10] drm: crc: Introduce verify_crc_source callback

2018-07-10 Thread Laurent Pinchart
Hi Mahesh, On Tuesday, 10 July 2018 14:54:11 EEST Kumar, Mahesh wrote: > On 7/10/2018 4:56 PM, Laurent Pinchart wrote: > > On Monday, 2 July 2018 14:07:20 EEST Mahesh Kumar wrote: > >> This patch adds a new callback function "verify_crc_source" which will > >> be used during setting the crc source

Re: [PATCH 02/10] drm: crc: Introduce get_crc_sources callback

2018-07-10 Thread Kumar, Mahesh
Hi, On 7/10/2018 5:39 PM, Laurent Pinchart wrote: Hi Mahesh, On Tuesday, 10 July 2018 15:01:38 EEST Kumar, Mahesh wrote: On 7/10/2018 4:52 PM, Laurent Pinchart wrote: Hi Mahesh, On Monday, 2 July 2018 14:07:21 EEST Mahesh Kumar wrote: This patch introduce a callback function "get_crc_source

Re: [PATCH 01/10] drm: crc: Introduce verify_crc_source callback

2018-07-10 Thread Kumar, Mahesh
Hi, On 7/10/2018 5:40 PM, Laurent Pinchart wrote: Hi Mahesh, On Tuesday, 10 July 2018 14:54:11 EEST Kumar, Mahesh wrote: On 7/10/2018 4:56 PM, Laurent Pinchart wrote: On Monday, 2 July 2018 14:07:20 EEST Mahesh Kumar wrote: This patch adds a new callback function "verify_crc_source" which w

Re: [RFC PATCH 3/4] drm/arm/malidp: Set the AFBC register bits if the framebuffer has AFBC modifier

2018-07-10 Thread Ayan Halder
Hi Liviu, On Thu, Jul 05, 2018 at 06:38:21PM +0100, Liviu Dudau wrote: > On Thu, Jul 05, 2018 at 02:31:47PM +0100, Ayan Halder wrote: > > On Tue, Jun 26, 2018 at 02:17:17PM +0100, Liviu Dudau wrote: > > > Hi Ayan, > > > > > > Thanks for the patch! I have some small comments to make: > > > > > > O

Re: [PATCH] drm/panel: innolux-p079zca: Use of_device_get_match_data()

2018-07-10 Thread Heiko Stuebner
Am Dienstag, 10. Juli 2018, 13:01:27 CEST schrieb Thierry Reding: > From: Thierry Reding > > Use this helper to get rid of some extra boilerplate code. > > Signed-off-by: Thierry Reding Reviewed-by: Heiko Stuebner ___ dri-devel mailing list dri-d

Re: [PATCH 05/10] drm/rcar-du/crc: Implement verify_crc_source callback

2018-07-10 Thread Kumar, Mahesh
Hi, thanks foe the review. On 7/10/2018 5:07 PM, Laurent Pinchart wrote: Hi Mahesh, Thank you for the patch. On Monday, 2 July 2018 14:07:24 EEST Mahesh Kumar wrote: This patch implements "verify_crc_source" callback function for rcar drm driver. Signed-off-by: Mahesh Kumar Cc: dri-devel@l

Re: [PATCH v5 0/8] drm: Add generic fbdev emulation

2018-07-10 Thread Noralf Trønnes
Den 03.07.2018 18.03, skrev Noralf Trønnes: This patchset adds generic fbdev emulation for drivers that supports GEM based dumb buffers which support .gem_prime_vmap and gem_prime_mmap. An API is begun to support in-kernel clients in general. I've squashed the client patches to ease review. All

Re: [PATCH 08/10] drm/crc: Cleanup crtc_crc_open function

2018-07-10 Thread Kumar, Mahesh
Hi, Thanks for the review. On 7/10/2018 5:19 PM, Laurent Pinchart wrote: Hi Mahesh, Thank you for the patch. On Monday, 2 July 2018 14:07:27 EEST Mahesh Kumar wrote: This patch make changes to allocate crc-entries buffer before enabling CRC generation. It moves all the failure check early in

[PATCH v2 4/4] drm/arm/malidp: Added support for AFBC modifiers for all layers except DE_SMART

2018-07-10 Thread Ayan Kumar Halder
On planes which support AFBC, expose an AFBC modifier for use with BGR888. Signed-off-by: Ayan Kumar halder Reviewed-by: Brian Starkey Reviewed-by: Liviu Dudau Changes from v2: - Removed the gerrit change-id - Replaced DRM_ERROR() with DRM_DEBUG_KMS() in malidp_format_mod_supported() to report

[PATCH v2 2/4] drm/arm/malidp: Implemented the size validation for AFBC framebuffers

2018-07-10 Thread Ayan Kumar Halder
AFBC buffers include additional metadata which increases the required allocation size. Implement the appropriate size validation and sanity checking for AFBC buffers. Added malidp specific function for framebuffer creation. This checks if the framebuffer has AFBC modifiers and if so, it verifies th

[PATCH v2 3/4] drm/arm/malidp: Set the AFBC register bits if the framebuffer has AFBC modifier

2018-07-10 Thread Ayan Kumar Halder
Added the AFBC decoder registers for DP500 , DP550 and DP650. These registers control the processing of AFBC buffers. It controls various features like AFBC decoder enable, lossless transformation and block split as well as setting of the left, right, top and bottom cropping of AFBC buffers (in num

[PATCH v2 1/4] drm/arm/malidp: Add modifier definitions for describing Arm Framebuffer Compression (AFBC).

2018-07-10 Thread Ayan Kumar Halder
AFBC is a proprietary lossless image compression protocol and format. It provides fine-grained random access and minimizes the amount of data transferred between IP blocks. AFBC has several features which may be supported and/or used, which are represented using bits in the modifier. Not all combin

[PATCH v2 0/4] Add support for Arm Framebuffer Compression(AFBC)

2018-07-10 Thread Ayan Kumar Halder
In the current series of patches, we are trying to add support for AFBC modifiers in malidp. AFBC modifiers adds some constraints to framebuffer size, alignment, pitch, formats, etc. Here we are trying to add support for one combination of AFBC modifier ie AFBC_FORMAT_MOD_BLOCK_SIZE_16x16 | AFBC_FO

Re: [[DPU]PATCH] drm/msm/dsi: move the API setting PLL src to modeset_init()

2018-07-10 Thread ryadav
A brief update on this topic: The DSI clock warnings are addressed after adding runtime_pm support to DPU driver [1]. MDSS GDSC is used as genpd w/ above series and is requested by parent MDSS device on behalf of all child devices (like DPU, DSI etc). Before adding the runtime_pm support, DSI

Re: [PATCH v2 1/1] drm/panel: Add support for Olimex LCD-OLinuXino panel

2018-07-10 Thread Greg Kroah-Hartman
On Tue, Jul 10, 2018 at 04:08:54PM +0300, Stefan Mavrodiev wrote: > On 07/10/2018 01:32 PM, Thierry Reding wrote: > > > +MODULE_AUTHOR("Stefan Mavrodiev "); > > > +MODULE_DESCRIPTION("LCD-OLinuXino driver"); > > > +MODULE_LICENSE("GPL v2"); > > This seems to contradict the GPL-2.0+ in the SPDX head

Re: [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-07-10 Thread Leon Romanovsky
On Mon, Jul 09, 2018 at 02:29:08PM +0200, Michal Hocko wrote: > On Wed 27-06-18 09:44:21, Michal Hocko wrote: > > This is the v2 of RFC based on the feedback I've received so far. The > > code even compiles as a bonus ;) I haven't runtime tested it yet, mostly > > because I have no idea how. > > >

Re: [RFC PATCHv2 1/9] drm: Add support for extracting sync signal drive edge from videomode

2018-07-10 Thread Thierry Reding
On Mon, Jun 18, 2018 at 04:22:34PM +0300, Tomi Valkeinen wrote: > From: Peter Ujfalusi > > The sync in some panels needs to be driven by different edge of the pixel > clock compared to data. This is reflected by the > DISPLAY_FLAGS_SYNC_(POS|NEG)EDGE in videmode flags. > Add similar similar defin

Re: [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-07-10 Thread Michal Hocko
On Tue 10-07-18 16:40:40, Leon Romanovsky wrote: > On Mon, Jul 09, 2018 at 02:29:08PM +0200, Michal Hocko wrote: > > On Wed 27-06-18 09:44:21, Michal Hocko wrote: > > > This is the v2 of RFC based on the feedback I've received so far. The > > > code even compiles as a bonus ;) I haven't runtime tes

Re: [PATCH] drm/panel: innolux-p079zca: Use of_device_get_match_data()

2018-07-10 Thread Thierry Reding
On Tue, Jul 10, 2018 at 01:01:27PM +0200, Thierry Reding wrote: > From: Thierry Reding > > Use this helper to get rid of some extra boilerplate code. > > Signed-off-by: Thierry Reding > --- > drivers/gpu/drm/panel/panel-innolux-p079zca.c | 7 +-- > 1 file changed, 1 insertion(+), 6 deletio

Re: [PATCH] drm/panel: innolux-p079zca: Use of_device_get_match_data()

2018-07-10 Thread Thierry Reding
On Tue, Jul 10, 2018 at 01:01:27PM +0200, Thierry Reding wrote: > From: Thierry Reding > > Use this helper to get rid of some extra boilerplate code. > > Signed-off-by: Thierry Reding > --- > drivers/gpu/drm/panel/panel-innolux-p079zca.c | 7 +-- > 1 file changed, 1 insertion(+), 6 deletio

[Bug 93746] Black screen when reconnecting display

2018-07-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93746 Michel Dänzer changed: What|Removed |Added Resolution|--- |FIXED QA Contact|xorg-t...@lists

Re: [PATCH v2 1/1] drm/panel: Add support for Olimex LCD-OLinuXino panel

2018-07-10 Thread Thierry Reding
On Tue, Jul 10, 2018 at 04:08:54PM +0300, Stefan Mavrodiev wrote: > On 07/10/2018 01:32 PM, Thierry Reding wrote: > > On Mon, Jun 25, 2018 at 09:44:35AM +0300, Stefan Mavrodiev wrote: [...] > > > diff --git a/drivers/gpu/drm/panel/panel-olimex-lcd-olinuxino.c > > > b/drivers/gpu/drm/panel/panel-ol

[PATCH] drm/tinydrm: Fix doc build warnings

2018-07-10 Thread Noralf Trønnes
include/drm/tinydrm/tinydrm.h:34: warning: Function parameter or member 'fb_dirty' not described in 'tinydrm_device' drivers/gpu/drm/tinydrm/mipi-dbi.c:272: warning: Function parameter or member 'crtc_state' not described in 'mipi_dbi_enable_flush' drivers/gpu/drm/tinydrm/mipi-dbi.c:272: warning:

Re: [PATCH 01/17] dt-bindings: display: sun4i-drm: Add R40 display engine compatible

2018-07-10 Thread Chen-Yu Tsai
On Sat, Jul 7, 2018 at 1:50 AM, Jernej Skrabec wrote: > R40 has pretty unique display pipeline. It supports two outputs at the > same time. > > Possible outputs: > - 1x HDMI, > - 2x TV output > - 1x VGA, > - 1x MIPI DSI and > - 2x LCD outputs > > That is the biggest number of possible outputs from

Re: [PATCH 02/17] drm/sun4i: Add R40 display engine compatible

2018-07-10 Thread Chen-Yu Tsai
On Sat, Jul 7, 2018 at 1:50 AM, Jernej Skrabec wrote: > R40 has versatile display pipeline. It supports two simultanious outputs > on various outputs (TVE, VGA, HDMI, MIPI DSI, LCD). > > Signed-off-by: Jernej Skrabec Reviewed-by: Chen-Yu Tsai ___ dri-

Re: [PATCH 03/17] ARM: dts: sun8i: r40: Remove fallback display engine compatible

2018-07-10 Thread Chen-Yu Tsai
On Sat, Jul 7, 2018 at 1:50 AM, Jernej Skrabec wrote: > R40 has pretty unique display pipeline. Because of that, H3 display > engine compatible fallback should be removed. > > Fixes: 05a43a262d03 ("ARM: dts: sun8i: r40: Add HDMI pipeline") > > Signed-off-by: Jernej Skrabec Reviewed-by: Chen-Yu T

Re: [PATCH 04/17] drm/sun4i: tcon-top: Cleanup clock handling

2018-07-10 Thread Chen-Yu Tsai
On Sat, Jul 7, 2018 at 1:51 AM, Jernej Skrabec wrote: > There is no need to acquire reference to clock just to get its name. > > This commit just cleans up the code. There is no functional change. > > Signed-off-by: Jernej Skrabec Reviewed-by: Chen-Yu Tsai __

Re: [PATCH 05/17] drm/sun4i: tcon: Release node when traversing of graph

2018-07-10 Thread Chen-Yu Tsai
On Sat, Jul 7, 2018 at 1:51 AM, Jernej Skrabec wrote: > Function sun4i_tcon_find_engine_traverse() doesn't release node if it > needs to traverse of graph deeper than 1 level. > > Fix this by calling of_node_put(). > > Fixes: 49836b11fe71 ("drm/sun4i: tcon: Generalize engine search algorithm") > >

Re: [PATCH 06/17] dt-bindings: display: sun4i-drm: Add R40 TV TCON description

2018-07-10 Thread Chen-Yu Tsai
On Sat, Jul 7, 2018 at 1:51 AM, Jernej Skrabec wrote: > TCON description is expanded with R40 TV TCON compatible. It is a bit > special, because it is connected to TCON TOP instead directly to mixer > and it needs special handling. > > Signed-off-by: Jernej Skrabec Reviewed-by: Chen-Yu Tsai >

Re: [PATCH 07/17] drm/sun4i: DW HDMI: Release nodes if error happens during CRTC search

2018-07-10 Thread Chen-Yu Tsai
On Sat, Jul 7, 2018 at 1:51 AM, Jernej Skrabec wrote: > If error happens in sun8i_dw_hdmi_find_possible_crtcs(), nodes are not > released with of_node_put() before returning. > > Fix that by calling of_node_put() when necessary. While on it, clean up > the code by using of_graph_get_remote_node()

Re: [PATCH 08/17] ARM: dts: sun8i: r40: Add mixer ids to TCON TOP

2018-07-10 Thread Chen-Yu Tsai
On Sat, Jul 7, 2018 at 1:51 AM, Jernej Skrabec wrote: > Mixer has to have a way to read its id, if needed. You should mention that this is required by the device tree binding sun4i-drm, in the second paragraph of the first section: For all connections between components up to the TCONs in th

Re: [PATCH 09/17] drm/sun4i: mixer: Read id from DT

2018-07-10 Thread Chen-Yu Tsai
On Sat, Jul 7, 2018 at 1:51 AM, Jernej Skrabec wrote: > Currently, TCON supports 2 ways to match TCON with engine (mixer in this > case). Old way is to just traverse of graph backwards and compare node > pointer. New way is to match TCON and engine by their respective ids. > All SoCs with DE2 enab

[PATCH 20/21] drm/msm: Add SDM845 DPU support

2018-07-10 Thread Sean Paul
The patch was rejected for being too big. Please refer to https://gitlab.freedesktop.org/seanpaul/dpu-staging/commit/b4215cf040d1978287bd1403832ffc610659652b Sean -- Sean Paul, Software Engineer, Google / Chromium OS ___ dri-devel mailing list dri-deve

Re: [PATCH 13/17] ARM: dts: sun8i: r40: Remove fallback compatible for TCON TV

2018-07-10 Thread Chen-Yu Tsai
On Sat, Jul 7, 2018 at 1:51 AM, Jernej Skrabec wrote: > While registers between A83T and R40 TV TCON are the same, R40 TCON TV > driver has to set additional muxes in TCON TOP. Because of that, remove > fallback A83T TCON TV compatible. Nit: device tree doesn't care about the implementation. You

Re: [PATCH 14/17] ARM: dts: sun8i: r40: Add missing TCON-TOP - TCON connections

2018-07-10 Thread Chen-Yu Tsai
On Sat, Jul 7, 2018 at 1:51 AM, Jernej Skrabec wrote: > Current R40 is missing some graph connections between TCON TOP and > TCONs. > > Add them. > > Fixes: 05a43a262d03 ("ARM: dts: sun8i: r40: Add HDMI pipeline") > > Signed-off-by: Jernej Skrabec Reviewed-by: Chen-Yu Tsai _

Re: [PATCH] drm/tinydrm: add backlight dependency for ili9341

2018-07-10 Thread Noralf Trønnes
Den 09.07.2018 17.20, skrev Arnd Bergmann: This tinydrm driver fails to link without the backlight support: drivers/gpu/drm/tinydrm/ili9341.o: In function `ili9341_probe': ili9341.c:(.text+0x578): undefined reference to `devm_of_find_backlight' Fixes: 3fa0e8f6f960 ("drm/tinydrm: new driver for

Re: [PATCH 10/17] drm/sun4i: tcon-top: Add helpers for switching mux

2018-07-10 Thread Chen-Yu Tsai
On Sat, Jul 7, 2018 at 1:51 AM, Jernej Skrabec wrote: > We want to be able to set TCON TOP muxes at runtime. Add helpers for > that. > > Old, static configuration of muxes at probe time is preserved for now. > It will be removed when R40 TCON starts using them. > > Signed-off-by: Jernej Skrabec

Re: [PATCH 16/17] drm/sun4i: tcon-top: Remove mux configuration at probe time

2018-07-10 Thread Chen-Yu Tsai
On Sat, Jul 7, 2018 at 1:51 AM, Jernej Skrabec wrote: > Now that R40 TCON migrated to runtime mux configuration, old code can be > removed. > > Signed-off-by: Jernej Skrabec > --- > drivers/gpu/drm/sun4i/sun8i_tcon_top.c | 81 +++--- > 1 file changed, 7 insertions(+), 74 dele

Re: [PATCH 17/17] dt-bindings: display: sun4i-drm: Fix order of DW HDMI PHY compatibles

2018-07-10 Thread Chen-Yu Tsai
On Sat, Jul 7, 2018 at 1:51 AM, Jernej Skrabec wrote: > They are currently sorted alphabetically. However, they should be sorted > by release date of the family and then alphabetically. > > Fixes: 03c35dbf73e0 ("dt-bindings: display: sun4i-drm: Add description of A64 > HDMI PHY") > > Signed-off-b

Re: [PATCH] drm/tinydrm: add backlight dependency for ili9341

2018-07-10 Thread David Lechner
On 07/10/2018 10:55 AM, Noralf Trønnes wrote: Anyways, thanks for fixing this: Acked-by: Noralf Trønnes David Lechner do you apply this? Noralf. Yes, I will pick it up. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.free

Re: [PATCH 11/17] drm/sun4i: tcon: Add another way for matching mixers with tcon

2018-07-10 Thread Chen-Yu Tsai
On Sat, Jul 7, 2018 at 1:51 AM, Jernej Skrabec wrote: > Till now, new way of matching engines with TCONs was reading their > respective ids and match them by those ids. However, with introduction > of TCON TOP, that might not be so straightforward anymore. > - there might be more TCONs that engine

Re: [PATCH 12/17] drm/sun4i: tcon: Add support for R40 TCON

2018-07-10 Thread Chen-Yu Tsai
On Sat, Jul 7, 2018 at 1:51 AM, Jernej Skrabec wrote: > R40 TV TCON is basically the same as on A83T. However, it needs special > handling, because it has to set up TCON TOP muxes at runtime. > > Signed-off-by: Jernej Skrabec Reviewed-by: Chen-Yu Tsai The runtime muxing of mixer <-> TCON is qu

Re: [PATCH 15/17] ARM: dts: sun8i: r40: Disable TCONs by default.

2018-07-10 Thread Chen-Yu Tsai
On Sat, Jul 7, 2018 at 1:51 AM, Jernej Skrabec wrote: > R40 has 4 TCONs, but only 2 of them can receive some kind of output at > the same time. Let's disable them by default, so only those which are > really connected on board can be enabled in board dts file. > > Signed-off-by: Jernej Skrabec O

Re: [PATCH] drm/tinydrm: Fix doc build warnings

2018-07-10 Thread David Lechner
On 07/10/2018 10:05 AM, Noralf Trønnes wrote: include/drm/tinydrm/tinydrm.h:34: warning: Function parameter or member 'fb_dirty' not described in 'tinydrm_device' drivers/gpu/drm/tinydrm/mipi-dbi.c:272: warning: Function parameter or member 'crtc_state' not described in 'mipi_dbi_enable_flush'

Re: [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-07-10 Thread Leon Romanovsky
On Tue, Jul 10, 2018 at 04:14:10PM +0200, Michal Hocko wrote: > On Tue 10-07-18 16:40:40, Leon Romanovsky wrote: > > On Mon, Jul 09, 2018 at 02:29:08PM +0200, Michal Hocko wrote: > > > On Wed 27-06-18 09:44:21, Michal Hocko wrote: > > > > This is the v2 of RFC based on the feedback I've received so

Re: [PATCH] drm/tinydrm: Fix doc build warnings

2018-07-10 Thread Noralf Trønnes
Den 10.07.2018 18.18, skrev David Lechner: On 07/10/2018 10:05 AM, Noralf Trønnes wrote: include/drm/tinydrm/tinydrm.h:34: warning: Function parameter or member 'fb_dirty' not described in 'tinydrm_device' drivers/gpu/drm/tinydrm/mipi-dbi.c:272: warning: Function parameter or member 'crtc_stat

Re: [PATCH] drm/tinydrm: Fix doc build warnings

2018-07-10 Thread David Lechner
On 07/10/2018 11:31 AM, Noralf Trønnes wrote: Den 10.07.2018 18.18, skrev David Lechner: On 07/10/2018 10:05 AM, Noralf Trønnes wrote: include/drm/tinydrm/tinydrm.h:34: warning: Function parameter or member 'fb_dirty' not described in 'tinydrm_device' drivers/gpu/drm/tinydrm/mipi-dbi.c:272: w

  1   2   >