Re: [PATCH 6/6] drm/i915: Filter out modes that don't match the fixed mode vrefresh

On Mon, Jul 02, 2018 at 12:52:31PM +0300, Ville Syrjälä wrote: > On Mon, Jul 02, 2018 at 09:46:23AM +0200, Daniel Vetter wrote: > > On Thu, Jun 28, 2018 at 10:43:01PM +0300, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > We only ever drive the panel with the fixed mode, hence we don't

Re: [v3 01/10] dt-bindings: mediatek: mmsys: Add support for mfd

On Mon, 25 Jun 2018, Matthias Brugger wrote: > > > On 30/04/18 12:30, Lee Jones wrote: > > On Fri, 27 Apr 2018, matthias@kernel.org wrote: > > > >> From: Matthias Brugger > >> > >> Add binding description for the mmsys mfd for some Mediatek > >> devices. mmsys has some registers to control

[Bug 199655] amdgpu: XFX Radeon RX 580 runs its fans only in dangerously low speeds and ignores temperature

https://bugzilla.kernel.org/show_bug.cgi?id=199655 --- Comment #2 from Sergey Kondakov (virtuous...@gmail.com) --- Same thing with 4.17 kernel. It seems that any kind of fan speed control is happening only when pwm1_enable were completely untouched and there is high GPU load. However, it never cha

Re: [v3 03/10] mfd: mtk-mmsys: Add mmsys driver

On Mon, 25 Jun 2018, Matthias Brugger wrote: > On 30/04/18 12:18, Lee Jones wrote: > > On Fri, 27 Apr 2018, matthias@kernel.org wrote: > > > >> From: Matthias Brugger > >> > >> The MMSYS subsystem includes clocks and drm components. > >> This patch adds a MFD device to probe both drivers from

[PATCH] drm/via: mark expected switch fall-throughs

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva --- drivers/gpu/drm/via/via_dmablit.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/via/via_dmablit.c b/drivers/gpu/drm/via/v

Re: [PATCH v3] gpu: drm: gma500: Change return type to vm_fault_t

On Fri, Jun 15, 2018 at 12:42 AM, Souptick Joarder wrote: > On Mon, Jun 4, 2018 at 10:47 AM, Souptick Joarder > wrote: >> On Sun, May 27, 2018 at 6:15 AM, Souptick Joarder >> wrote: >>> Use new return type vm_fault_t for fault handler. For >>> now, this is just documenting that the function re

Re: [PATCH] gpu: drm: virito: code cleanup

On Tue, Jul 3, 2018 at 11:58 AM, Gerd Hoffmann wrote: > On Mon, Jul 02, 2018 at 11:57:28PM +0530, Souptick Joarder wrote: >> The fault handler code is commented since v4.2. >> If there is no plan to enable the fault handler >> code in future, we can remove this dead code. > > Indeed, but please wi

[Bug 200387] amdgpu uses unusually high memory

https://bugzilla.kernel.org/show_bug.cgi?id=200387 --- Comment #16 from Christian König (christian.koe...@amd.com) --- (In reply to phoenix from comment #15) > I hope this is helpful. Unfortunately not really, the only thing in there is a known issue with the IOVA cache. Can you try to bisect as

Re: [PATCH] drm: add missing ctx argument to plane transitional helpers

On Mon, Jul 02, 2018 at 05:21:23PM +0100, Russell King wrote: > In commits: > 34a2ab5e0689 ("drm: Add acquire ctx parameter to ->update_plane") > 1931529448bc ("drm: Add acquire ctx parameter to ->plane_disable") > > a pointer to a drm_modeset_acquire_ctx structure was added as an > argument to th

Re: [PATCH] video/console/vgacon: Print big fat warning with nomodeset

On Mon, Jul 02, 2018 at 05:04:40PM -0400, Lyude Paul wrote: > It's been a pretty good while since kernel modesetting was introduced. > It has almost entirely replaced previous solutions which required > userspace modesetting, and I can't even recall any drivers off the top > of my head for modern d

[Bug 200387] amdgpu uses unusually high memory

https://bugzilla.kernel.org/show_bug.cgi?id=200387 --- Comment #17 from phoenix (fe...@feldspaten.org) --- Sure, I'm going to investigate through the different kernel versions but that is gonna take me some time (I have to do this in my spare time) I'll post my progress and findings, when availab

Re: [PATCH v4 1/9] drm: Begin an API for in-kernel clients

On Mon, Jul 02, 2018 at 03:54:25PM +0200, Noralf Trønnes wrote: > This the beginning of an API for in-kernel clients. > First out is a way to get a framebuffer backed by a dumb buffer. > > Only GEM drivers are supported. > The original idea of using an exported dma-buf was dropped because it > als

Re: [PATCH v4 5/9] drm/client: Add client callbacks

On Mon, Jul 02, 2018 at 03:54:29PM +0200, Noralf Trønnes wrote: > Add client callbacks and hook them up. > Add a list of clients per drm_device. > > Signed-off-by: Noralf Trønnes btw for reviewing it'd be simpler if you merge the 2 patches that add the client library, avoids me having to jump ba

[PATCH v4 4/8] drm/vc4: Use wait_for_flip_done() instead of wait_for_vblanks()

drm_atomic_helper_wait_for_vblanks() assumes the CRTC will continuously generate VBLANK events and the vblank counter will keep increasing. While this work for a regular pipeline, it doesn't when you have the CRTC is feeding the transposer block, because this block works in oneshot mode, and, by th

[PATCH v4 6/8] drm/atomic: Call fake_vblank() from the generic commit_tail() helpers

Now that we have a way to fake VBLANK events when requested by the CRTC hook it up to the generic commit_tail() helpers. Signed-off-by: Boris Brezillon Reviewed-by: Liviu Dudau Reviewed-by: Daniel Vetter --- Changes in v4: - None Changes in v3: - Add R-b tags Changes in v2: - New patch --- d

[PATCH v4 1/8] drm/atomic: Avoid connector to writeback_connector casts

Use container_of() instead of type casting so that it keeps working even if base is moved inside the drm_writeback_connector struct. Signed-off-by: Boris Brezillon Reviewed-by: Liviu Dudau Reviewed-by: Daniel Vetter --- Changes in v4: - None Changes in v3: - Add Daniel's and Liviu's R-b Chang

[PATCH v4 0/8] drm/vc4: Add support for the transposer IP

Hello, This is the third version of this series adding writeback support to the VC4 display engine. This version is based on drm-misc-next and include a bunch of modifications to the core that I had to add to make it work on VC4. The only change in this v4 is a build failure fix in patch 3. See

[PATCH v4 2/8] drm/connector: Pass a drm_connector_state to ->atomic_commit()

Other atomic hooks are passed state objects, let's change this one to be consistent. Signed-off-by: Boris Brezillon Acked-by: Liviu Dudau Reviewed-by: Daniel Vetter --- Changes in v4: - None Changes in v3: - Add Liviu's A-b and Daniel's R-b Changes in v2: - New patch --- drivers/gpu/drm/drm_

[PATCH v4 5/8] drm/crtc: Add a generic infrastructure to fake VBLANK events

In some cases CRTCs are active but are not able to generating events, at least not at every frame at it's expected to. This is typically the case when the CRTC is feeding a writeback connector that has no job queued. In this situation the CRTC is usually stopped until a new job is queued, and this

[PATCH v4 7/8] drm/vc4: Call drm_atomic_helper_fake_vblank() in the commit path

Mimic what is done in drm_atomic_commit_tail() and call drm_atomic_helper_fake_vblank() so that VBLANK events are faked when the drm_crtc_state.no_vblank is true. Will be needed when we'll add support for the transposer block. Signed-off-by: Boris Brezillon Reviewed-by: Eric Anholt --- Changes i

[PATCH v4 3/8] drm/connector: Make ->atomic_commit() optional

Not all writeback connector implementations might want to commit things from the connector driver. Some, like the malidp driver, commit things from their main commit_tail() function, and would rather not have to implement a dummy hook for drm_connector_helper_funcs.atomic_commit(). Make this funct

[PATCH v4 8/8] drm/vc4: Add support for the transposer block

From: Boris Brezillon The transposer block is providing support for mem-to-mem composition, which is exposed as a drm_writeback connector in DRM. Add a driver to support this feature. Signed-off-by: Boris Brezillon Reviewed-by: Eric Anholt --- Changes in v4: - Actually add Eric's R-b :-) Cha

[PATCH v6] Add udmabuf misc device

A driver to let userspace turn memfd regions into dma-bufs. Use case: Allows qemu create dmabufs for the vga framebuffer or virtio-gpu ressources. Then they can be passed around to display those guest things on the host. To spice client for classic full framebuffer display, and hopefully some d

[Bug 200387] amdgpu uses unusually high memory

https://bugzilla.kernel.org/show_bug.cgi?id=200387 --- Comment #18 from Michel Dänzer (mic...@daenzer.net) --- Does the memory usage go back down when you quit the game? Or when you restart X? Or never? -- You are receiving this mail because: You are watching the assignee of the bug. ___

[Bug 200387] amdgpu uses unusually high memory

https://bugzilla.kernel.org/show_bug.cgi?id=200387 --- Comment #19 from phoenix (fe...@feldspaten.org) --- The memory usage goes immediately down once the game quits. No X restart necessary -- You are receiving this mail because: You are watching the assignee of the bug.

[Bug 200387] amdgpu uses unusually high memory

https://bugzilla.kernel.org/show_bug.cgi?id=200387 --- Comment #20 from Michel Dänzer (mic...@daenzer.net) --- In that case, the output of running the game in valgrind --leak-check=full might be interesting. -- You are receiving this mail because: You are watching the assignee of the bug. ___

[Bug 200387] amdgpu uses unusually high memory

https://bugzilla.kernel.org/show_bug.cgi?id=200387 --- Comment #21 from phoenix (fe...@feldspaten.org) --- Jep, I'll have a look this evening. Maybe I can reproduce the issue with another program as well to exclude exclusive problems with a single userland program. -- You are receiving this mail

[Bug 107095] Artifacts in X sessions, GPU fault 147

https://bugs.freedesktop.org/show_bug.cgi?id=107095 Michel Dänzer changed: What|Removed |Added Attachment #140442|text/x-log |text/plain mime type|

[Bug 107095] Artifacts in X sessions, GPU fault 147

https://bugs.freedesktop.org/show_bug.cgi?id=107095 Michel Dänzer changed: What|Removed |Added QA Contact||dri-devel@lists.freedesktop

Re: [PATCH v6] Add udmabuf misc device

On Tue, Jul 03, 2018 at 09:53:58AM +0200, Gerd Hoffmann wrote: > A driver to let userspace turn memfd regions into dma-bufs. > > Use case: Allows qemu create dmabufs for the vga framebuffer or > virtio-gpu ressources. Then they can be passed around to display > those guest things on the host. T

Re: [amdgpu][tahiti xt] cursor motion smoothness

On 2018-07-02 10:10 PM, sylvain.bertr...@gmail.com wrote: > On Mon, Jul 02, 2018 at 06:43:48PM +0200, Michel Dänzer wrote: >>> Sending the logs as direct email to your personal email box. >> >> Does using xf86-input-libinput instead of xf86-input-evdev help? > > I did plan to switch to libinput in

Re: [amdgpu][tahiti xt] cursor motion smoothness

On 2018-07-03 10:54 AM, Michel Dänzer wrote: > On 2018-07-02 10:10 PM, sylvain.bertr...@gmail.com wrote: >> On Mon, Jul 02, 2018 at 06:43:48PM +0200, Michel Dänzer wrote: Sending the logs as direct email to your personal email box. >>> >>> Does using xf86-input-libinput instead of xf86-input-e

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Filter out modes that don't match the fixed mode vrefresh

Quoting Daniel Vetter (2018-07-03 08:03:09) > On Mon, Jul 02, 2018 at 12:52:31PM +0300, Ville Syrjälä wrote: > > On Mon, Jul 02, 2018 at 09:46:23AM +0200, Daniel Vetter wrote: > > > On Thu, Jun 28, 2018 at 10:43:01PM +0300, Ville Syrjala wrote: > > > > From: Ville Syrjälä > > > > > > > > We only

Re: [PATCH] drm/etnaviv: bring back progress check in job timeout handler

Hi Russell, can you tell me if you will be able to provide some test feedback for this patch during this week? I would like to get this into a fixes pull towards the end of the week and would feel a bit more confident to do so knowing that this really fixes the issue you are hitting on GC600. Reg

Re: [PATCH v1 2/7] drm: add hook to print encoder status

On Tue, Jun 05, 2018 at 03:54:02PM +0200, Benjamin Gaignard wrote: > Even if encoders don't have state it could be useful to get information > from them when dumping of the other elements state. > Add an optional hook in drm_encoder_funcs structure and call it after crtc > print state. > > Signed-

Re: [PATCH v7 3/6] mfd: cros-ec: Increase maximum mkbp event size

On Mon, 18 Jun 2018, Neil Armstrong wrote: > Hi Lee, > > On 18/06/2018 09:44, Lee Jones wrote: > > On Fri, 01 Jun 2018, Neil Armstrong wrote: > > > >> Having a 16 byte mkbp event size makes it possible to send CEC > >> messages from the EC to the AP directly inside the mkbp event > >> instead of

Re: [PATCH] drm/etnaviv: bring back progress check in job timeout handler

Am Dienstag, den 03.07.2018, 10:44 +0100 schrieb Russell King - ARM Linux: > On Wed, Jun 27, 2018 at 04:34:27PM +0200, Lucas Stach wrote: > > When the hangcheck handler was replaced by the DRM scheduler timeout > > handling we dropped the forward progress check, as this might allow > > clients to h

Re: [PATCH 03/10] drm/rockchip/crc: Implement verify_crc_source callback

Op 02-07-18 om 13:07 schreef Mahesh Kumar: > This patch implements "verify_crc_source" callback function for > rockchip drm driver. > > Changes since V1: > - simplify the verification (Jani N) > > Signed-off-by: Mahesh Kumar > Cc: dri-devel@lists.freedesktop.org > Reviewed-by: Maarten Lankhorst

Re: [PATCH 04/10] drm/amdgpu_dm/crc: Implement verify_crc_source callback

Op 02-07-18 om 13:07 schreef Mahesh Kumar: > This patch implements "verify_crc_source" callback function for > AMD drm driver. > > Signed-off-by: Mahesh Kumar > Cc: dri-devel@lists.freedesktop.org > Reviewed-by: Maarten Lankhorst > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1

Re: [PATCH 05/10] drm/rcar-du/crc: Implement verify_crc_source callback

Op 02-07-18 om 13:07 schreef Mahesh Kumar: > This patch implements "verify_crc_source" callback function for > rcar drm driver. > > Signed-off-by: Mahesh Kumar > Cc: dri-devel@lists.freedesktop.org > Reviewed-by: Maarten Lankhorst > --- > drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 40 > ++

Re: [PATCH v2 1/8] drm/bridge/synopsys: dsi: move mipi_dsi_host_unregister to __dw_mipi_dsi_remove

On 18.06.2018 12:27, Heiko Stuebner wrote: > Right now the host is only unregistered when the driver is used via the > bridge api and not via the component api, leading to the host staying > registered in cases like probe deferral. > > So move the host unregister to the general remove function, so

Re: [PATCH 03/10] drm/rockchip/crc: Implement verify_crc_source callback

Hi Maarten, Am Dienstag, 3. Juli 2018, 12:16:41 CEST schrieb Maarten Lankhorst: > Op 02-07-18 om 13:07 schreef Mahesh Kumar: > > This patch implements "verify_crc_source" callback function for > > rockchip drm driver. > > > > Changes since V1: > > - simplify the verification (Jani N) > > > > Si

[git pull] vmwgfx-next WW mutex update

Hi, Dave. A patchset worked out together with Peter Zijlstra. Ingo is OK with taking it through the DRM tree: This is a small fallout from a work to allow batching WW mutex locks and unlocks. Our Wound-Wait mutexes actually don't use the Wound-Wait algorithm but the Wait-Die algorithm. One could

Re: [PATCH] drm/stm: ltdc: rework reset sequence

Hi Yannick, On 06/29/2018 01:22 PM, Yannick Fertre wrote: > Reset must be properly assert before deassert. > This is important if there is an early boot splash screen > before the kernel start up. > > Signed-off-by: Yannick Fertre > --- > drivers/gpu/drm/stm/ltdc.c | 5 - > 1 file change

Re: [PATCH] drm/stm: ltdc: filter mode pixel clock vs pad constraint

Hi Yannick, On 06/29/2018 01:22 PM, Yannick Fertre wrote: > Filter the requested mode pixel clock frequency according > to the pad maximum supported frequency. > > Signed-off-by: Yannick Fertre > --- > drivers/gpu/drm/stm/ltdc.c | 16 > drivers/gpu/drm/stm/ltdc.h | 1 + > 2

Re: [PATCH 12/12] drm/rockchip: add support for CDNS MHDP IP controller.

Hi Damien, it's very cool to see collaboration from vendors on this. Am Dienstag, 3. Juli 2018, 12:02:23 CEST schrieb Damian Kos: > It would be really nice to explain a bit about the added controller support in the commit message, so that people reviewing the patch can get a feeling for it. >

Re: [PATCH 14/15] drm/virtio: Remove unecessary dma_fence_ops

On Thu, May 03, 2018 at 04:26:02PM +0200, Daniel Vetter wrote: > dma_fence_default_wait is the default now, same for the trivial > enable_signaling implementation. > > Reviewed-by: Eric Anholt > Signed-off-by: Daniel Vetter > Cc: David Airlie > Cc: Gerd Hoffmann > Cc: virtualizat...@lists.linu

Re: [PATCH 3/4] drm/amdgpu: add independent DMA-buf export v3

Am 28.06.2018 um 11:58 schrieb Zhang, Jerry (Junwei): On 06/22/2018 10:11 PM, Christian König wrote: The caching of SGT's done by the DRM code is actually quite harmful and should probably removed altogether in the long term. Start by providing a separate DMA-buf export implementation in amdgp

Re: [PATCH 1/4] dma-buf: add dma_buf_(un)map_attachment_locked variants v2

Am 28.06.2018 um 11:53 schrieb Zhang, Jerry (Junwei): On 06/22/2018 10:11 PM, Christian König wrote: Add function variants which can be called with the reservation lock already held. v2: reordered, add lockdep asserts, fix kerneldoc Signed-off-by: Christian König ---   drivers/dma-buf/dma-buf

Re: [PATCH 2/4] dma-buf: lock the reservation object during (un)map_dma_buf v2

Am 25.06.2018 um 11:12 schrieb Daniel Vetter: On Mon, Jun 25, 2018 at 10:22:31AM +0200, Daniel Vetter wrote: On Fri, Jun 22, 2018 at 04:11:01PM +0200, Christian König wrote: First step towards unpinned DMA buf operation. I've checked the DRM drivers to potential locking of the reservation obje

Re: [PATCH v2 3/8] drm/bridge/synopsys: dsi: defer probing if panel not available in bridge-attach

Hi Heiko, On 06/18/2018 12:28 PM, Heiko Stuebner wrote: > When the panel-driver is build as a module it currently fails hard as the > panel cannot be probed directly: > > dw_mipi_dsi_bind() >__dw_mipi_dsi_probe() > creates dsi bus > creates panel device > triggers panel module

Re: [PATCH] video/console/vgacon: Print big fat warning with nomodeset

On Tue, 03 Jul 2018, Daniel Vetter wrote: > On Mon, Jul 02, 2018 at 05:04:40PM -0400, Lyude Paul wrote: >> It's been a pretty good while since kernel modesetting was introduced. >> It has almost entirely replaced previous solutions which required >> userspace modesetting, and I can't even recall a

Re: [PATCH v2 1/8] drm/bridge/synopsys: dsi: move mipi_dsi_host_unregister to __dw_mipi_dsi_remove

Hi Heiko, On 06/18/2018 12:27 PM, Heiko Stuebner wrote: > Right now the host is only unregistered when the driver is used via the > bridge api and not via the component api, leading to the host staying > registered in cases like probe deferral. > > So move the host unregister to the general remo

Re: [PATCH v2 7/8] drm/bridge/synopsys: dsi: add dual-dsi support

Hi Heiko, Thank you for your patch, On 06/18/2018 12:28 PM, Heiko Stuebner wrote: > From: Nickey Yang > > Allow to also drive a slave dw-mipi-dsi controller in a dual-dsi > setup. This will require additional implementation-specific > code to look up the slave instance and do specific setup. > A

Re: [PATCH v2 0/8] drm/rockchip: migrate to common dw-mipi-dsi bridge and dual-dsi

Hi Heiko, and many thanks for this serie. I tested "partly" it successfully on stm32 (single-dsi, no bind/unbind). Many thanks, Philippe :-) On 06/18/2018 12:27 PM, Heiko Stuebner wrote: > The Rockchip DSI driver was separate till now, not using the common > bridge driver that was introduced a

Re: [PATCH v2 2/8] drm/bridge/synopsys: dsi: don't call __dw_mipi_dsi_probe from dw_mipi_dsi_bind

On 18.06.2018 12:28, Heiko Stuebner wrote: > __dw_mipi_dsi_probe() does all the grabbing of resources and does it using > devm-helpers. So this is happening on each try of master bringup possibly > slowing down things a lot. > > Drivers using the component framework may instead want call dw_mipi_ds

Re: [PATCH v7 3/6] mfd: cros-ec: Increase maximum mkbp event size

Hi Lee, On 03/07/2018 11:43, Lee Jones wrote: > On Mon, 18 Jun 2018, Neil Armstrong wrote: > >> Hi Lee, >> >> On 18/06/2018 09:44, Lee Jones wrote: >>> On Fri, 01 Jun 2018, Neil Armstrong wrote: >>> Having a 16 byte mkbp event size makes it possible to send CEC messages from the EC to t

[PATCH] video: fbdev: metronomefb: fix some off by one bugs

The "mem" buffer has "size" bytes. The ">" should be ">=" to prevent reading one character beyond the end of the array. Signed-off-by: Dan Carpenter --- Not tested. diff --git a/drivers/video/fbdev/metronomefb.c b/drivers/video/fbdev/metronomefb.c index 9085e9525341..bb4fee52e501 100644 --- a/

[PATCH] drm/vgem: off by one in vgem_gem_fault()

If page_offset is == num_pages then we end up reading beyond the end of obj->pages[]. Fixes: af33a9190d02 ("drm/vgem: Enable dmabuf import interfaces") Signed-off-by: Dan Carpenter --- Static analysis. Not tested diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c ind

[PATCH] drm/i810: off by one in i810_dma_vertex()

If vertex->idx == dma->buf_count then we end up reading one element beyond the end of the dma->buflist[] array. Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/i810/i810_dma.c b/drivers/gpu/drm/i810/i810_dma.c index 576a417690d4..3b378936f575 100644 --- a/drivers/gpu/drm/i810/i810_dma.

Re: [PATCH v2 2/8] drm/bridge/synopsys: dsi: don't call __dw_mipi_dsi_probe from dw_mipi_dsi_bind

Am Dienstag, 3. Juli 2018, 14:16:28 CEST schrieb Andrzej Hajda: > On 18.06.2018 12:28, Heiko Stuebner wrote: > > __dw_mipi_dsi_probe() does all the grabbing of resources and does it using > > devm-helpers. So this is happening on each try of master bringup possibly > > slowing down things a lot. >

Re: [PATCH 10/10] drm/vmwgfx: Use drm_plane_mask() & co.

On Mon, Jul 02, 2018 at 10:00:35AM -0700, Sinclair Yeh wrote: > Reviewed-by: Sinclair Yeh > > I assume you'll upstream this as part of your series? Already pushed actually. In my haste I failed to realize I was still missing an ack/rb for vmwgfx. Sorry about that. > > On Tue, Jun 26, 2018 at 1

Re: [PATCH v2 3/8] drm/bridge/synopsys: dsi: defer probing if panel not available in bridge-attach

On 18.06.2018 12:28, Heiko Stuebner wrote: > When the panel-driver is build as a module it currently fails hard as the > panel cannot be probed directly: > > dw_mipi_dsi_bind() > __dw_mipi_dsi_probe() > creates dsi bus > creates panel device > triggers panel module load > panel no

Re: [PATCH 2/4] dma-buf: lock the reservation object during (un)map_dma_buf v2

On Tue, Jul 03, 2018 at 01:46:44PM +0200, Christian König wrote: > Am 25.06.2018 um 11:12 schrieb Daniel Vetter: > > On Mon, Jun 25, 2018 at 10:22:31AM +0200, Daniel Vetter wrote: > > > On Fri, Jun 22, 2018 at 04:11:01PM +0200, Christian König wrote: > > > > First step towards unpinned DMA buf oper

Re: [PATCH] drm/i810: off by one in i810_dma_vertex()

On Tue, Jul 03, 2018 at 03:30:16PM +0300, Dan Carpenter wrote: > If vertex->idx == dma->buf_count then we end up reading one element > beyond the end of the dma->buflist[] array. > > Signed-off-by: Dan Carpenter This driver is a full-on root hole no matter what, but applied to appease the checke

Re: [PATCH 2/4] dma-buf: lock the reservation object during (un)map_dma_buf v2

Am 03.07.2018 um 14:52 schrieb Daniel Vetter: On Tue, Jul 03, 2018 at 01:46:44PM +0200, Christian König wrote: Am 25.06.2018 um 11:12 schrieb Daniel Vetter: On Mon, Jun 25, 2018 at 10:22:31AM +0200, Daniel Vetter wrote: On Fri, Jun 22, 2018 at 04:11:01PM +0200, Christian König wrote: First st

Re: [PATCH 04/10] drm/amdgpu_dm/crc: Implement verify_crc_source callback

On 2018-07-03 06:19 AM, Maarten Lankhorst wrote: Op 02-07-18 om 13:07 schreef Mahesh Kumar: This patch implements "verify_crc_source" callback function for AMD drm driver. Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Reviewed-by: Maarten Lankhorst Acked-by: Leo Li --

Re: [PATCH 08/10] drm/crc: Cleanup crtc_crc_open function

On 2018-07-02 07:07 AM, Mahesh Kumar wrote: This patch make changes to allocate crc-entries buffer before enabling CRC generation. It moves all the failure check early in the function before setting the source or memory allocation. Now set_crc_source takes only two variable inputs, values_cnt w

Re: [PATCH] drm/vgem: off by one in vgem_gem_fault()

On Tue, Jul 03, 2018 at 03:29:21PM +0300, Dan Carpenter wrote: > If page_offset is == num_pages then we end up reading beyond the end of > obj->pages[]. > > Fixes: af33a9190d02 ("drm/vgem: Enable dmabuf import interfaces") > Signed-off-by: Dan Carpenter > --- > Static analysis. Not tested Appli

Re: [PATCH v2 5/8] drm/rockchip: dsi: migrate to use dw-mipi-dsi bridge driver

On 18.06.2018 12:28, Heiko Stuebner wrote: > From: Nickey Yang > > Add the ROCKCHIP DSI controller driver that uses the Synopsys DesignWare > MIPI DSI host controller bridge and remove the old separate one. > > changes: > > v2: >add err_pllref, remove unnecessary encoder.enable & disable >

Re: [PATCH v4 5/9] drm/client: Add client callbacks

Den 03.07.2018 09.46, skrev Daniel Vetter: On Mon, Jul 02, 2018 at 03:54:29PM +0200, Noralf Trønnes wrote: Add client callbacks and hook them up. Add a list of clients per drm_device. Signed-off-by: Noralf Trønnes btw for reviewing it'd be simpler if you merge the 2 patches that add the clie

Re: [PATCH 2/4] dma-buf: lock the reservation object during (un)map_dma_buf v2

On Tue, Jul 03, 2018 at 03:02:11PM +0200, Christian König wrote: > Am 03.07.2018 um 14:52 schrieb Daniel Vetter: > > On Tue, Jul 03, 2018 at 01:46:44PM +0200, Christian König wrote: > > > Am 25.06.2018 um 11:12 schrieb Daniel Vetter: > > > > On Mon, Jun 25, 2018 at 10:22:31AM +0200, Daniel Vetter w

Re: [PATCH v4 5/9] drm/client: Add client callbacks

On Tue, Jul 03, 2018 at 03:07:50PM +0200, Noralf Trønnes wrote: > > Den 03.07.2018 09.46, skrev Daniel Vetter: > > On Mon, Jul 02, 2018 at 03:54:29PM +0200, Noralf Trønnes wrote: > > > Add client callbacks and hook them up. > > > Add a list of clients per drm_device. > > > > > > Signed-off-by: No

Re: [PATCH 2/4] dma-buf: lock the reservation object during (un)map_dma_buf v2

Am 03.07.2018 um 15:11 schrieb Daniel Vetter: On Tue, Jul 03, 2018 at 03:02:11PM +0200, Christian König wrote: Am 03.07.2018 um 14:52 schrieb Daniel Vetter: On Tue, Jul 03, 2018 at 01:46:44PM +0200, Christian König wrote: Am 25.06.2018 um 11:12 schrieb Daniel Vetter: On Mon, Jun 25, 2018 at 1

Re: [PATCH v2 1/3] video: fbdev: Fix checkpatch warnings in goldfishfb.c

On Friday, June 08, 2018 12:10:58 PM r...@google.com wrote: > From: Roman Kiryanov > > Address issues pointed by checkpatch.pl > > Signed-off-by: Roman Kiryanov Patch queued for 4.19, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics

Re: [PATCH v2 2/3] video: fbdev: Enable ACPI-based enumeration for goldfishfb

On Friday, June 08, 2018 12:10:59 PM r...@google.com wrote: > From: Yu Ning > > Add an ACPI id to make goldfish framebuffer to support ACPI enumeration. > > Signed-off-by: Yu Ning > Signed-off-by: Roman Kiryanov Patch queued for 4.19, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsun

Re: [PATCH v2 3/3] video: fbdev: Set pixclock = 0 in goldfishfb

On Friday, June 08, 2018 12:11:00 PM r...@google.com wrote: > From: Christoffer Dall > > User space Android code identifies pixclock == 0 as a sign for emulation > and will set the frame rate to 60 fps when reading this value, which is > the desired outcome. > > Signed-off-by: Christoffer Dall

Re: [PATCH] omapfb: encoder-tpd12s015: fix error return code

On Sunday, June 10, 2018 04:24:13 PM Julia Lawall wrote: > Return an error code on failure. > > Problem found using Coccinelle. > > Signed-off-by: Julia Lawall Patch queued for 4.19, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics __

Re: [amdgpu][tahiti xt] cursor motion smoothness

On Tue, Jul 03, 2018 at 10:54:15AM +0200, Michel Dänzer wrote: > Unless your xserver build ends up with INPUTTHREAD undefined for some > reason, input events are processed in a separate thread, and the HW > cursor position is updated accordingly ASAP. I did check on that: INPUTTHREAD is properly d

Re: [amdgpu][tahiti xt] cursor motion smoothness

On Tue, Jul 03, 2018 at 11:01:46AM +0200, Michel Dänzer wrote: > Also make sure you do not pass -dumbSched on the Xorg command line, and > do not disable Option "SilkenMouse" in xorg.conf. No pb on this side. I tried to enable -dumbSched, I could not see any difference. I did run a fast moving ga

Re: [PATCH] fb: fix lost console when the user unplugs a USB adapter

Hi, On Sunday, June 03, 2018 11:46:29 AM Mikulas Patocka wrote: > I have a USB display adapter using the udlfb driver and I use it on an ARM > board that doesn't have any graphics card. When I plug the adapter in, the > console is properly displayed, however when I unplug and re-plug the > adapte

Re: [PATCH 18/21] udlfb: allow reallocating the framebuffer

On Tuesday, June 12, 2018 12:32:34 PM Mikulas Patocka wrote: > > On Mon, 4 Jun 2018, kbuild test robot wrote: > > > Hi Mikulas, > > > > I love your patch! Perhaps something to improve: > > > > [auto build test WARNING on drm/drm-next] > > [also build test WARNING on v4.17-rc7 next-20180601] > >

Re: [PATCH v2 6/8] drm/dsi: add helper function to find the second host in a dual-dsi setup

On 18.06.2018 12:28, Heiko Stuebner wrote: > >From a specified output port of one dsi controller this function allows to > iterate over the list of registered dsi controllers trying to find a second > instance connected to the same display, like it is used in dual-dsi setups. > > Signed-off-by: Hei

Re: [PATCH] video: fbdev: simplefb: Stop including

On Tuesday, June 19, 2018 07:22:21 PM Geert Uytterhoeven wrote: > Simplefb is not a clock provider, but it uses of_clk_get_parent_count(), > so it can just include instead. > > Signed-off-by: Geert Uytterhoeven Patch queued for 4.19, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R

[Bug 107066] [Regression] Tonga can't bring up > 1 display since DC enablement

https://bugs.freedesktop.org/show_bug.cgi?id=107066 mikita.lip...@amd.com changed: What|Removed |Added CC||mikita.lip...@amd.com --- Comme

Re: [PATCH v2 1/2] efi/bgrt: Drop __initdata from bgrt_image_size

On Monday, July 02, 2018 02:02:47 PM Ard Biesheuvel wrote: > On 2 July 2018 at 13:57, Bartlomiej Zolnierkiewicz > wrote: > > On Monday, July 02, 2018 01:46:09 PM Ard Biesheuvel wrote: > >> On 2 July 2018 at 13:26, Hans de Goede wrote: > >> > Bartlomiej, > >> > > >> > Now that the fbcon deferred c

Re: [PATCH] drm/sun4i: Implement zpos for DE2

On Wed, 2018-06-27 at 18:45 +0200, Jernej Skrabec wrote: > Initial implementation of DE2 planes only supported fixed zpos. > > Expand implementation with configurable zpos property. Thanks for adding support for this! Tested with the Sunxi-Cedrus VPU driver on H3 with: https://github.com/free-ele

[PATCH v5 5/8] drm/debugfs: Add internal client debugfs file

Print the names of the internal clients currently attached. Reviewed-by: Daniel Vetter Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_client.c | 28 drivers/gpu/drm/drm_debugfs.c | 7 +++ include/drm/drm_client.h | 3 +++ 3 files changed, 38 inser

[PATCH v5 0/8] drm: Add generic fbdev emulation

This patchset adds generic fbdev emulation for drivers that supports GEM based dumb buffers which support .gem_prime_vmap and gem_prime_mmap. An API is begun to support in-kernel clients in general. I've squashed the client patches to ease review. All patches have ack's and rb's so I'll apply this

[PATCH v5 2/8] drm/fb-helper: Add generic fbdev emulation .fb_probe function

This is the first step in getting generic fbdev emulation. A drm_fb_helper_funcs.fb_probe function is added which uses the DRM client API to get a framebuffer backed by a dumb buffer. Signed-off-by: Noralf Trønnes Reviewed-by: Daniel Vetter --- drivers/gpu/drm/drm_fb_helper.c | 199

[PATCH v5 3/8] drm/pl111: Set .gem_prime_vmap and .gem_prime_mmap

These are needed for pl111 to use the generic fbdev emulation. Cc: Eric Anholt Signed-off-by: Noralf Trønnes Reviewed-by: Eric Anholt --- drivers/gpu/drm/pl111/pl111_drv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/pl111/pl111_drv.c b/drivers/gpu/drm/pl111/pl111_drv

[PATCH v5 1/8] drm: Begin an API for in-kernel clients

This the beginning of an API for in-kernel clients. First out is a way to get a framebuffer backed by a dumb buffer. Only GEM drivers are supported. The original idea of using an exported dma-buf was dropped because it also creates an anonomous file descriptor which doesn't work when the buffer is

[PATCH v5 6/8] drm/fb-helper: Finish the generic fbdev emulation

This adds a drm_fbdev_generic_setup() function that sets up generic fbdev emulation with client callbacks for restore, hotplug and unregister. Signed-off-by: Noralf Trønnes Reviewed-by: Daniel Vetter --- drivers/gpu/drm/drm_fb_helper.c | 117 include/drm

[PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

This switches the CMA helper drivers that use its fbdev emulation over to the generic fbdev emulation. It's the first phase of using generic fbdev. A later phase will use DRM client callbacks for the lastclose/hotplug/remove callbacks. There are currently 2 fbdev init/fini functions: - drm_fb_cma_

[PATCH v5 8/8] drm/cma-helper: Remove drm_fb_cma_fbdev_init_with_funcs()

Remove drm_fb_cma_fbdev_init_with_funcs(), its only user tinydrm has moved to drm_fbdev_generic_setup(). Cc: Laurent Pinchart Signed-off-by: Noralf Trønnes Reviewed-by: David Lechner --- drivers/gpu/drm/drm_fb_cma_helper.c | 21 - include/drm/drm_fb_cma_helper.h | 3 --

[PATCH v5 7/8] drm/tinydrm: Use drm_fbdev_generic_setup()

Make full use of the generic fbdev client. Cc: David Lechner Signed-off-by: Noralf Trønnes Reviewed-by: David Lechner --- drivers/gpu/drm/tinydrm/core/tinydrm-core.c | 3 +-- drivers/gpu/drm/tinydrm/ili9225.c | 1 - drivers/gpu/drm/tinydrm/ili9341.c | 1 - drivers/gpu/drm/t

Re: [PATCH v5 3/3] console/fbcon: Add support for deferred console takeover

On (06/28/18 11:03), Hans de Goede wrote: [..] > > +config FRAMEBUFFER_CONSOLE_DEFERRED_TAKEOVER > + bool "Framebuffer Console Deferred Takeover" > + depends on FRAMEBUFFER_CONSOLE=y && DUMMY_CONSOLE=y + default n > + help > + If enabled this defers the framebuffer conso

Re: [PATCH v5 3/3] console/fbcon: Add support for deferred console takeover

On Wed, 4 Jul 2018 01:13:27 +0900 Sergey Senozhatsky wrote: > On (06/28/18 11:03), Hans de Goede wrote: > [..] > > > > +config FRAMEBUFFER_CONSOLE_DEFERRED_TAKEOVER > > + bool "Framebuffer Console Deferred Takeover" > > + depends on FRAMEBUFFER_CONSOLE=y && DUMMY_CONSOLE=y > > + defa

Re: [PATCH] drm/amdgpu/acp: Fix slab-out-of-bounds in mfd_add_device in acp_hw_init

On Mon, Jul 2, 2018 at 5:48 PM, Daniel Kurtz wrote: > Hi Alex, > > On Sun, Apr 15, 2018 at 9:48 PM Agrawal, Akshu wrote: >> >> >> >> On 4/13/2018 9:45 PM, Daniel Kurtz wrote: >> > Commit 51f7415039d4 ("drm/amd/amdgpu: creating two I2S instances for >> > stoney/cz") added support for the "BT_I2S"

[Bug 200387] amdgpu uses unusually high memory

https://bugzilla.kernel.org/show_bug.cgi?id=200387 --- Comment #22 from phoenix (fe...@feldspaten.org) --- Apperently it's not that easy to attach valgrind to any Steam game, so I'm going the suggested approach of trying it out using different Kernel version. Interestingly I could observe similar

  1   2   >