[PATCH] drm/msm: Fix possible null dereference on failure of get_pages()

2018-04-04 Thread Ben Hutchings
Commit 62e3a3e342af changed get_pages() to initialise msm_gem_object::pages before trying to initialise msm_gem_object::sgt, so that put_pages() would properly clean up pages in the failure case. However, this means that put_pages() now needs to check that msm_gem_object::sgt is not null before tr

Re: Signal handling in a page fault handler

2018-04-04 Thread Matthew Wilcox
On Tue, Apr 03, 2018 at 02:20:43PM +0100, Chris Wilson wrote: > Quoting Matthew Wilcox (2018-04-03 14:10:25) > > On Tue, Apr 03, 2018 at 01:33:15PM +0100, Chris Wilson wrote: > > > Quoting Matthew Wilcox (2018-04-02 15:10:58) > > > > I don't think the graphics drivers really want to be interrupted

Re: Signal handling in a page fault handler

2018-04-04 Thread Matthew Wilcox
On Tue, Apr 03, 2018 at 03:12:35PM +0200, Thomas Hellstrom wrote: > I think the TTM page fault handler originally set the standard for this. > First, IMO any critical section that waits for the GPU (like typically the > page fault handler does), should be locked at least killable. The need for > in

[PATCH 1/1] drm/i915:Do not use kfree() to free kmem_cache_alloc() return value

2018-04-04 Thread Xidong Wang
In eb_lookup_vmas(), lut, the return value of kmem_cache_alloc(), is freed with kfree().I think the expected paired function is kmem_cache_free(). Signed-off-by: Xidong Wang --- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

DRM MIPI DSI device and I2C device?

2018-04-04 Thread Carsten Behling
Hi, I would like to write a DRM bridge driver that is an I2C device and a DRM MIPI DSI device. It looks like that both - 'i2c-core.c: of_i2c_register_devices' and 'drm_mipi_dsi.c: mipi_dsi_host_register' are registering their devices by iterating over devicetree child nodes with for_each_availab

[Bug 199101] AMDGPU Fury X random screen flicker on Linux kernel 4.16rc5

2018-04-04 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=199101 Martin Babutzka (martin.babut...@web.de) changed: What|Removed |Added CC||martin.babut...

Re: drm/scheduler for vc5

2018-04-04 Thread Christian König
Am 04.04.2018 um 01:08 schrieb Eric Anholt: Christian König writes: Hi Eric, nice to see that the scheduler gets used more and more. The feature your need to solve both your binning/rendering as well as your MMU problem is dependency handling. See the "dependency" callback of the backend ope

Re: [PATCH v2 2/2] drm/omap: partial workaround for DRA7xx DMM errata i878

2018-04-04 Thread Tomi Valkeinen
On 04/04/18 00:11, Laurent Pinchart wrote: > I assume access to DMM-mapped buffers to be way more frequent than access to > the DMM registers. If that's the case, this partial workaround should only > slightly lower the probability of system lock-up. Do you have plans to > implement a workaroun

Re: [PATCH 1/1] drm/i915: Do not use kfree() to free kmem_cache_alloc() return value

2018-04-04 Thread Chris Wilson
Quoting Xidong Wang (2018-04-04 08:37:54) > In eb_lookup_vmas(), the return value of kmem_cache_alloc() is freed > with kfree(). I think the expected paired function is kmem_cahce_free(). > > Signed-off-by: Xidong Wang That is indeed what it should be doing, Fixes: d1b48c1e7184 ("drm/i915: Repl

[PATCH v5 0/5] drm/blend: Support generic plane-wide alpha

2018-04-04 Thread Maxime Ripard
Hi, This serie aims at enhancing the support for plane-wide alpha in the drivers that are implementing it at the moment, by turning it into a generic property and converting the drivers (rcar-du and atmel-hclcdc). It also introduces support for it in the sun4i driver. Let me know what you think,

[PATCH v5 3/5] drm/rcar-du: Convert to the new generic alpha property

2018-04-04 Thread Maxime Ripard
Now that we have support for per-plane alpha in the core, let's use it. Reviewed-by: Laurent Pinchart Signed-off-by: Maxime Ripard --- drivers/gpu/drm/rcar-du/rcar_du_drv.h | 1 +- drivers/gpu/drm/rcar-du/rcar_du_kms.c | 5 +--- drivers/gpu/drm/rcar-du/rcar_du_plane.c | 15 +++-- driv

[PATCH v5 1/5] drm/blend: Add a generic alpha property

2018-04-04 Thread Maxime Ripard
Some drivers duplicate the logic to create a property to store a per-plane alpha. This is especially useful if we ever want to support extra protocols for Wayland like: https://lists.freedesktop.org/archives/wayland-devel/2017-August/034741.html Let's create a helper in order to move that to the

[PATCH v5 2/5] drm/atmel-hclcdc: Convert to the new generic alpha property

2018-04-04 Thread Maxime Ripard
Now that we have support for per-plane alpha in the core, let's use it. Acked-by: Boris Brezillon Signed-off-by: Maxime Ripard --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h| 13 +--- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 89 ++ 2 files changed, 14 insertions(+

[PATCH v5 5/5] drm/docs: Remove the rcar alpha from the csv file

2018-04-04 Thread Maxime Ripard
Now that we moved the rcar-du DRM driver has been switched to the generic alpha property, remove the former property documentation from the deperecated CSV file. Signed-off-by: Maxime Ripard --- Documentation/gpu/kms-properties.csv | 1 - 1 file changed, 1 deletion(-) diff --git a/Documentation

[PATCH v5 4/5] drm/sun4i: Add support for plane alpha

2018-04-04 Thread Maxime Ripard
Our backend supports a per-plane alpha property. Support it through our new helper. Reviewed-by: Chen-Yu Tsai Signed-off-by: Maxime Ripard --- drivers/gpu/drm/sun4i/sun4i_backend.c | 16 +--- drivers/gpu/drm/sun4i/sun4i_backend.h | 3 +++ drivers/gpu/drm/sun4i/sun4i_layer.c | 2

Re: [PATCH v3 6/7] arm: dts: sun8i: a33: Add the DSI-related nodes

2018-04-04 Thread Maxime Ripard
Hi, On Thu, Mar 22, 2018 at 10:23:32AM +0800, Chen-Yu Tsai wrote: > On Tue, Mar 6, 2018 at 9:56 PM, Maxime Ripard > wrote: > > From: Maxime Ripard > > > > The A33 has a MIPI-DSI block, along with its D-PHY. Let's add it in order > > to use it in the relevant boards. > > > > Signed-off-by: Maxim

Re: [PATCH 1/1] drm/i915:Do not use kfree() to free kmem_cache_alloc() return value

2018-04-04 Thread Jani Nikula
On Wed, 04 Apr 2018, Xidong Wang wrote: > In eb_lookup_vmas(), lut, the return value of kmem_cache_alloc(), is freed > with kfree().I think the expected paired function is kmem_cache_free(). Agreed. But did you try to compile your patch before sending? Fixes: d1b48c1e7184 ("drm/i915: Replace exe

Re: [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

2018-04-04 Thread Thomas Hellstrom
Hi, On 04/04/2018 08:58 AM, Daniel Vetter wrote: On Wed, Apr 4, 2018 at 12:42 AM, Rob Clark wrote: Add an atomic helper to implement dirtyfb support. This is needed to support DSI command-mode panels with x11 userspace (ie. when we can't rely on pageflips to trigger a flush to the panel). To

[Bug 105680] [CI] igt@kms_frontbuffer_tracking@* - fail - FBC disabled: mode too large for compression

2018-04-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105680 --- Comment #5 from Marta Löfstedt --- (In reply to Jose Roberto de Souza from comment #4) > This one is not related to memory, it is because the resolution is bigger > than the resolution that hardware track can handle, so there is not fix for

Re: [PATCH] drm/imx: Remove last traces of struct imx_drm_crtc

2018-04-04 Thread Philipp Zabel
On Tue, 2018-04-03 at 20:56 -0300, Fabio Estevam wrote: > On Tue, Mar 27, 2018 at 6:39 PM, Leonard Crestez > wrote: > > When the definition of this struct was removed a forward declaration and an > > unused struct member were still left around. Remove them because they serve > > no purpose. > > >

Re: [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

2018-04-04 Thread Daniel Vetter
On Wed, Apr 04, 2018 at 10:22:21AM +0200, Thomas Hellstrom wrote: > Hi, > > On 04/04/2018 08:58 AM, Daniel Vetter wrote: > > On Wed, Apr 4, 2018 at 12:42 AM, Rob Clark wrote: > > > Add an atomic helper to implement dirtyfb support. This is needed to > > > support DSI command-mode panels with x11

Re: [drm:drm_dp_dual_mode_detect [drm_kms_helper]] DP dual mode HDMI ID:  (err -6)

2018-04-04 Thread Jani Nikula
On Tue, 03 Apr 2018, genpur wrote: > Hello, I don't know where I can/should write this > question... Please refer if I should write any post/bug/question > somewhere... Please file a bug over at [1]. Please describe your problem clearly and conscisely. Please add drm.debug=14 module parameter and

Re: [PATCH v4 1/5] drm/blend: Add a generic alpha property

2018-04-04 Thread Paul Kocialkowski
Hi, On Tue, 2018-03-13 at 21:54 +0100, Maxime Ripard wrote: > Some drivers duplicate the logic to create a property to store a per- > plane alpha. > > This is especially useful if we ever want to support extra protocols > for > Wayland like: > https://lists.freedesktop.org/archives/wayland-devel/

Re: [PATCH v4 4/5] drm/sun4i: Add support for plane alpha

2018-04-04 Thread Paul Kocialkowski
Hi, On Tue, 2018-03-13 at 21:54 +0100, Maxime Ripard wrote: > Our backend supports a per-plane alpha property. Support it through > our new > helper. See one comment below. Otherwise, this is: Reviewed-by: Paul Kocialkowski > Reviewed-by: Chen-Yu Tsai > Signed-off-by: Maxime Ripard > --- > d

[DPU PATCH v2 0/2] Remove DPU RSC support

2018-04-04 Thread Rajesh Yadav
MSM display controller hardware (DPU) has an inbuilt RSC block which can control power resources and bus bandwidth voting based on frame timing parameters w/o DPU driver intervention. In absence of RSC HW, DPU driver controls these resources. Downstream driver relies on RSC driver for controlling

[DPU PATCH v2 1/2] dt-bindings: msm/disp: Remove DPU RSC device bindings

2018-04-04 Thread Rajesh Yadav
Display controller's power resources and bus bandwidth voting is controlled by DPU device. Remove DPU RSC (hardware block for DPU power resource control) device support. Signed-off-by: Rajesh Yadav --- .../devicetree/bindings/display/msm/dpu-rsc.txt| 96 -- 1 file changed

Re: [PATCH v2 0/5] allow override of bus format in bridges

2018-04-04 Thread Laurent Pinchart
Hi Daniel, On Wednesday, 4 April 2018 09:34:41 EEST Daniel Vetter wrote: > On Wed, Apr 4, 2018 at 12:28 AM, Laurent Pinchart wrote: > > On Wednesday, 28 March 2018 10:08:26 EEST Daniel Vetter wrote: > >> On Mon, Mar 26, 2018 at 11:24:42PM +0200, Peter Rosin wrote: > >>> Hi! > >>> > >>> [I got to

Re: [RFC] Per file OOM badness

2018-04-04 Thread Michel Dänzer
On 2018-03-26 04:36 PM, Lucas Stach wrote: > Am Dienstag, den 30.01.2018, 11:28 +0100 schrieb Michal Hocko: >> On Tue 30-01-18 10:29:10, Michel Dänzer wrote: >>> On 2018-01-24 12:50 PM, Michal Hocko wrote: On Wed 24-01-18 12:23:10, Michel Dänzer wrote: > On 2018-01-24 12:01 PM, Michal Hock

Re: [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

2018-04-04 Thread Thomas Hellstrom
On 04/04/2018 10:43 AM, Daniel Vetter wrote: On Wed, Apr 04, 2018 at 10:22:21AM +0200, Thomas Hellstrom wrote: Hi, On 04/04/2018 08:58 AM, Daniel Vetter wrote: On Wed, Apr 4, 2018 at 12:42 AM, Rob Clark wrote: Add an atomic helper to implement dirtyfb support. This is needed to support DSI

Re: [PATCH v4 1/5] drm/blend: Add a generic alpha property

2018-04-04 Thread Paul Kocialkowski
Hi, On Fri, 2018-03-30 at 13:37 -0700, Eric Anholt wrote: > Maxime Ripard writes: > > > Some drivers duplicate the logic to create a property to store a > > per-plane > > alpha. > > > > This is especially useful if we ever want to support extra protocols > > for > > Wayland like: > > https://li

[Bug 105880] [dc][kabini] Cannot find any crtc or sizes

2018-04-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105880 Bug ID: 105880 Summary: [dc][kabini] Cannot find any crtc or sizes Product: DRI Version: XOrg git Hardware: Other OS: All Status: NEW Severity: normal

[Bug 105880] [dc][kabini] Cannot find any crtc or sizes

2018-04-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105880 --- Comment #1 from Chí-Thanh Christopher Nguyễn --- Created attachment 138571 --> https://bugs.freedesktop.org/attachment.cgi?id=138571&action=edit dmesg with cik_support=1 dc=0 -- You are receiving this mail because: You are the assignee f

[Bug 105880] [dc][kabini] Cannot find any crtc or sizes

2018-04-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105880 --- Comment #2 from Chí-Thanh Christopher Nguyễn --- Created attachment 138572 --> https://bugs.freedesktop.org/attachment.cgi?id=138572&action=edit dmesg with radeon -- You are receiving this mail because: You are the assignee for the bug._

Re: [PATCH v5 1/5] drm/blend: Add a generic alpha property

2018-04-04 Thread Laurent Pinchart
Hi Maxime, Thank you for the patch. On Wednesday, 4 April 2018 11:04:19 EEST Maxime Ripard wrote: > Some drivers duplicate the logic to create a property to store a per-plane > alpha. > > This is especially useful if we ever want to support extra protocols for > Wayland like: > https://lists.fre

Re: [PATCH v5 2/5] drm/atmel-hclcdc: Convert to the new generic alpha property

2018-04-04 Thread Laurent Pinchart
Hi Maxime, Thank you for the patch. On Wednesday, 4 April 2018 11:04:20 EEST Maxime Ripard wrote: > Now that we have support for per-plane alpha in the core, let's use it. > > Acked-by: Boris Brezillon > Signed-off-by: Maxime Ripard Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/atm

Re: [RFC][PATCH v2] drm_hwcomposer: Rework platformdrmgeneric.cpp to use libdrm's gralloc handle

2018-04-04 Thread Robert Foss
Hey, Builds for hikey960, pushed upstream. Rob. On 04/03/2018 05:57 AM, John Stultz wrote: Rework the platformdrmgeneric buffer importer to use the libdrm generic gralloc handle definition. This is just to get the drm_hwcomposer project building in AOSP along with the libdrm freedesktop/mast

Re: [PATCH v5 5/5] drm/docs: Remove the rcar alpha from the csv file

2018-04-04 Thread Laurent Pinchart
Hi Maxime, Thank you for the patch. On Wednesday, 4 April 2018 11:04:23 EEST Maxime Ripard wrote: > Now that we moved the rcar-du DRM driver has been switched to the generic > alpha property, remove the former property documentation from the > deperecated CSV file. > > Signed-off-by: Maxime Ripa

Re: Signal handling in a page fault handler

2018-04-04 Thread Daniel Vetter
On Mon, Apr 02, 2018 at 07:10:58AM -0700, Matthew Wilcox wrote: > > Souptick and I have been auditing the various page fault handler routines > and we've noticed that graphics drivers assume that a signal should be > able to interrupt a page fault. In contrast, the page cache takes great > care t

Re: [RFC] Per file OOM badness

2018-04-04 Thread Lucas Stach
Am Mittwoch, den 04.04.2018, 11:09 +0200 schrieb Michel Dänzer: > On 2018-03-26 04:36 PM, Lucas Stach wrote: > > Am Dienstag, den 30.01.2018, 11:28 +0100 schrieb Michal Hocko: > > > On Tue 30-01-18 10:29:10, Michel Dänzer wrote: > > > > On 2018-01-24 12:50 PM, Michal Hocko wrote: > > > > > On Wed 2

Re: [PATCH v4 1/5] drm/blend: Add a generic alpha property

2018-04-04 Thread Laurent Pinchart
Hi Paul, On Wednesday, 4 April 2018 12:15:04 EEST Paul Kocialkowski wrote: > On Fri, 2018-03-30 at 13:37 -0700, Eric Anholt wrote: > > Maxime Ripard writes: > >> Some drivers duplicate the logic to create a property to store a > >> per-plane alpha. > >> > >> This is especially useful if we ever

Re: [RFC] Per file OOM badness

2018-04-04 Thread Michel Dänzer
On 2018-04-04 11:36 AM, Lucas Stach wrote: > Am Mittwoch, den 04.04.2018, 11:09 +0200 schrieb Michel Dänzer: >> On 2018-03-26 04:36 PM, Lucas Stach wrote: >>> Am Dienstag, den 30.01.2018, 11:28 +0100 schrieb Michal Hocko: On Tue 30-01-18 10:29:10, Michel Dänzer wrote: > On 2018-01-24 12:50

Re: [PATCH v2 2/2] drm/omap: partial workaround for DRA7xx DMM errata i878

2018-04-04 Thread Laurent Pinchart
Hi Tomi, On Wednesday, 4 April 2018 10:37:05 EEST Tomi Valkeinen wrote: > On 04/04/18 00:11, Laurent Pinchart wrote: > > I assume access to DMM-mapped buffers to be way more frequent than access > > to the DMM registers. If that's the case, this partial workaround should > > only slightly lower th

Re: [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

2018-04-04 Thread Daniel Vetter
On Wed, Apr 04, 2018 at 11:10:08AM +0200, Thomas Hellstrom wrote: > On 04/04/2018 10:43 AM, Daniel Vetter wrote: > > On Wed, Apr 04, 2018 at 10:22:21AM +0200, Thomas Hellstrom wrote: > > > Hi, > > > > > > On 04/04/2018 08:58 AM, Daniel Vetter wrote: > > > > On Wed, Apr 4, 2018 at 12:42 AM, Rob Cla

[PATCH v4 4/8] drm/sun4i: Tie the DSI controller in the TCON

2018-04-04 Thread Maxime Ripard
The DSI controller needs a particular interface (CPU aka 8080) with some modifications from the TCON in order to run. Make sure the TCON is able to provide it when we are using the DSI output. Reviewed-by: Chen-Yu Tsai Signed-off-by: Maxime Ripard --- drivers/gpu/drm/sun4i/sun4i_tcon.c | 77 ++

[PATCH v4 7/8] ARM: dts: sun8i: a33: Add the DSI-related nodes

2018-04-04 Thread Maxime Ripard
The A33 has a MIPI-DSI block, along with its D-PHY. Let's add it in order to use it in the relevant boards. Reviewed-by: Chen-Yu Tsai Signed-off-by: Maxime Ripard --- arch/arm/boot/dts/sun8i-a33.dtsi | 44 +- 1 file changed, 44 insertions(+) diff --git a/arch/ar

[PATCH v4 0/8] drm/sun4i: Allwinner MIPI-DSI support

2018-04-04 Thread Maxime Ripard
Hi, Here is an preliminary version of the MIPI-DSI support for the Allwinner SoCs. This controller can be found on a number of recent SoCs, such as the A31, A33 or the A64. Given the sparse documentation, there's a number of obscure areas, but the current implementation has been tested with a 4-

[PATCH v4 1/8] drm/sun4i: tcon: Add TRI finish interrupt for vblank

2018-04-04 Thread Maxime Ripard
The "CPU" (or Intel 8080) interface uses a different interrupt called TRI_FINISH (most likely TRI being for trigger) to notify the end of frames, and hence the VBLANK period. And that interrupt to the possible VBLANK interrupts source. Reviewed-by: Chen-Yu Tsai Signed-off-by: Maxime Ripard ---

[PATCH v4 3/8] drm/sun4i: Add Allwinner A31 MIPI-DSI controller support

2018-04-04 Thread Maxime Ripard
Most of the Allwinner SoCs since the A31 share the same MIPI-DSI controller. While that controller is mostly undocumented, the code is out there and has been cleaned up in order to be integrated into DRM. However, there's still some dark areas that are a bit unclear about how the block exactly ope

[PATCH v4 5/8] dt-bindings: panel: Add the Ilitek ILI9881c panel documentation

2018-04-04 Thread Maxime Ripard
The LHR050H41 from BananaPi is a 1280x700 4-lanes DSI panel based on the ILI9881c from Ilitek. Acked-by: Rob Herring Signed-off-by: Maxime Ripard --- Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.txt | 20 1 file changed, 20 insertions(+) create mode 100

[PATCH v4 2/8] dt-bindings: display: Add Allwinner MIPI-DSI bindings

2018-04-04 Thread Maxime Ripard
The Allwinner SoCs usually come with a DSI encoder. Add a binding for it. Reviewed-by: Rob Herring Signed-off-by: Maxime Ripard --- Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt | 93 +++- 1 file changed, 93 insertions(+) create mode 100644 Documentation/devicetree/binding

[PATCH v4 6/8] drm/panel: Add Ilitek ILI9881c panel driver

2018-04-04 Thread Maxime Ripard
The LHR050H41 panel is the panel shipped with the BananaPi M2-Magic, and is based on the Ilitek ILI9881c Controller. Add a driver for it, modelled after the other Ilitek controller drivers. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/panel/Kconfig | 9 +- drivers/gpu/drm/p

[PATCH v4 8/8] [DO NOT MERGE] arm: dts: sun8i: bpi-m2m: Add DSI display

2018-04-04 Thread Maxime Ripard
The BananaPi M2M has an optional 1280x720 DSI panel. Since that panel is optional, we can only show a DT patch that would show how to enable it. Signed-off-by: Maxime Ripard --- arch/arm/boot/dts/sun8i-r16-bananapi-m2m.dts | 39 +- 1 file changed, 39 insertions(+) diff --git

Re: [PATCH v2 2/2] drm/omap: partial workaround for DRA7xx DMM errata i878

2018-04-04 Thread Tomi Valkeinen
On 04/04/18 12:51, Laurent Pinchart wrote: > Hi Tomi, > > On Wednesday, 4 April 2018 10:37:05 EEST Tomi Valkeinen wrote: >> On 04/04/18 00:11, Laurent Pinchart wrote: >>> I assume access to DMM-mapped buffers to be way more frequent than access >>> to the DMM registers. If that's the case, this pa

Re: [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

2018-04-04 Thread Daniel Vetter
On Tue, Apr 03, 2018 at 06:42:23PM -0400, Rob Clark wrote: > Add an atomic helper to implement dirtyfb support. This is needed to > support DSI command-mode panels with x11 userspace (ie. when we can't > rely on pageflips to trigger a flush to the panel). > > To signal to the driver that the asyn

Re: [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

2018-04-04 Thread Daniel Vetter
On Wed, Apr 04, 2018 at 12:03:00PM +0200, Daniel Vetter wrote: > On Tue, Apr 03, 2018 at 06:42:23PM -0400, Rob Clark wrote: > > Add an atomic helper to implement dirtyfb support. This is needed to > > support DSI command-mode panels with x11 userspace (ie. when we can't > > rely on pageflips to tr

Re: [DPU PATCH v2 0/2] Remove DPU RSC support

2018-04-04 Thread Daniel Vetter
On Wed, Apr 04, 2018 at 02:34:40PM +0530, Rajesh Yadav wrote: > MSM display controller hardware (DPU) has an inbuilt RSC block > which can control power resources and bus bandwidth voting > based on frame timing parameters w/o DPU driver intervention. > In absence of RSC HW, DPU driver controls the

Re: [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

2018-04-04 Thread Thomas Hellstrom
On 04/04/2018 11:56 AM, Daniel Vetter wrote: On Wed, Apr 04, 2018 at 11:10:08AM +0200, Thomas Hellstrom wrote: On 04/04/2018 10:43 AM, Daniel Vetter wrote: On Wed, Apr 04, 2018 at 10:22:21AM +0200, Thomas Hellstrom wrote: Hi, On 04/04/2018 08:58 AM, Daniel Vetter wrote: On Wed, Apr 4, 2018 a

Re: [PATCH v2 2/2] drm/omap: partial workaround for DRA7xx DMM errata i878

2018-04-04 Thread Laurent Pinchart
Hi Tomi, On Wednesday, 4 April 2018 13:02:04 EEST Tomi Valkeinen wrote: > On 04/04/18 12:51, Laurent Pinchart wrote: > > On Wednesday, 4 April 2018 10:37:05 EEST Tomi Valkeinen wrote: > >> On 04/04/18 00:11, Laurent Pinchart wrote: > >>> I assume access to DMM-mapped buffers to be way more frequen

[PATCH] MAINTAINERS: add dri-devel&linaro-mm for Android ION

2018-04-04 Thread Daniel Vetter
Most of the other cross-driver gfx infrastructure (dma_buf, dma_fence) also gets cross posted to all the relevant gfx/memory lists. Doing the same for ION means people won't miss relevant patches. Cc: Laura Abbott Cc: Sumit Semwal Cc: de...@driverdev.osuosl.org Cc: dri-devel@lists.freedesktop.or

Re: [PATCH v2 2/2] drm/omap: partial workaround for DRA7xx DMM errata i878

2018-04-04 Thread Tomi Valkeinen
On 04/04/18 13:28, Laurent Pinchart wrote: > Hi Tomi, > > On Wednesday, 4 April 2018 13:02:04 EEST Tomi Valkeinen wrote: >> On 04/04/18 12:51, Laurent Pinchart wrote: >>> On Wednesday, 4 April 2018 10:37:05 EEST Tomi Valkeinen wrote: On 04/04/18 00:11, Laurent Pinchart wrote: > I assume a

Re: [git pull] drm for v4.17-rc1

2018-04-04 Thread Michel Dänzer
On 2018-04-03 02:03 PM, Daniel Vetter wrote: > On Tue, Apr 3, 2018 at 1:52 PM, Daniel Vetter wrote: >> On Tue, Apr 3, 2018 at 1:13 PM, Lucas Stach wrote: >>> Hi Daniel, >>> >>> Am Dienstag, den 03.04.2018, 12:01 +0200 schrieb Daniel Vetter: On Tue, Apr 3, 2018 at 11:58 AM, Daniel Vetter wro

Re: [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

2018-04-04 Thread Maarten Lankhorst
Op 04-04-18 om 12:21 schreef Daniel Vetter: > On Wed, Apr 04, 2018 at 12:03:00PM +0200, Daniel Vetter wrote: >> On Tue, Apr 03, 2018 at 06:42:23PM -0400, Rob Clark wrote: >>> Add an atomic helper to implement dirtyfb support. This is needed to >>> support DSI command-mode panels with x11 userspace

Re: [PATCH 1/4] drm/vgem: Fix vgem_init to get drm device avaliable.

2018-04-04 Thread Emil Velikov
On 29 March 2018 at 08:17, Daniel Vetter wrote: > On Wed, Mar 28, 2018 at 04:11:39PM +0100, Emil Velikov wrote: >> On 28 March 2018 at 15:49, Chris Wilson wrote: >> > Quoting Emil Velikov (2018-03-28 02:24:48) >> >> From: Deepak Sharma >> >> >> >> Modify vgem_init to take platform dev as parent

Re: [PATCH v2 2/2] drm/omap: partial workaround for DRA7xx DMM errata i878

2018-04-04 Thread Tomi Valkeinen
On 04/04/18 00:11, Laurent Pinchart wrote: >> +dma_async_issue_pending(dmm->wa_dma_chan); >> +status = dma_sync_wait(dmm->wa_dma_chan, cookie); > > dma_sync_wait() has a 5s timeout. You're calling this function with a > spinlock > held. The end result might be slightly better than a com

[Bug 99236] System (seems to) completely freeze when interacting with java swing applications.

2018-04-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99236 Timothy Arceri changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [PATCH v2 2/2] drm/omap: partial workaround for DRA7xx DMM errata i878

2018-04-04 Thread Laurent Pinchart
Hi Tomi, On Wednesday, 4 April 2018 13:50:43 EEST Tomi Valkeinen wrote: > On 04/04/18 00:11, Laurent Pinchart wrote: > >> + dma_async_issue_pending(dmm->wa_dma_chan); > >> + status = dma_sync_wait(dmm->wa_dma_chan, cookie); > > > > dma_sync_wait() has a 5s timeout. You're calling this function

Re: [Patch v2 1/6] drm/omap: Add ability to filter out modes which can't be supported

2018-04-04 Thread Tomi Valkeinen
On 26/03/18 19:21, Benoit Parrot wrote: > Currently available display mode from a connector are filtered out > based only on pixel clock capability. However we also need to filter > out wider mode if we cannot handle them based on available pipeline > capabilities. > > Signed-off-by: Benoit Parrot

Re: [PATCH v2 2/2] drm/omap: partial workaround for DRA7xx DMM errata i878

2018-04-04 Thread Laurent Pinchart
Hi Tomi, On Wednesday, 4 April 2018 13:33:02 EEST Tomi Valkeinen wrote: > On 04/04/18 13:28, Laurent Pinchart wrote: > > On Wednesday, 4 April 2018 13:02:04 EEST Tomi Valkeinen wrote: > >> On 04/04/18 12:51, Laurent Pinchart wrote: > >>> On Wednesday, 4 April 2018 10:37:05 EEST Tomi Valkeinen wrot

Re: [DPU PATCH v2 0/2] Remove DPU RSC support

2018-04-04 Thread ryadav
On 2018-04-04 15:56, Daniel Vetter wrote: On Wed, Apr 04, 2018 at 02:34:40PM +0530, Rajesh Yadav wrote: MSM display controller hardware (DPU) has an inbuilt RSC block which can control power resources and bus bandwidth voting based on frame timing parameters w/o DPU driver intervention. In absen

Re: [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

2018-04-04 Thread Rob Clark
On Wed, Apr 4, 2018 at 6:21 AM, Daniel Vetter wrote: > On Wed, Apr 04, 2018 at 12:03:00PM +0200, Daniel Vetter wrote: >> On Tue, Apr 03, 2018 at 06:42:23PM -0400, Rob Clark wrote: >> > Add an atomic helper to implement dirtyfb support. This is needed to >> > support DSI command-mode panels with x

[Bug 105883] booting with kernel using amd-staging-drm-next on 2400G hangs

2018-04-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105883 Bug ID: 105883 Summary: booting with kernel using amd-staging-drm-next on 2400G hangs Product: DRI Version: DRI git Hardware: x86-64 (AMD64) OS: Linux (All

Re: [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

2018-04-04 Thread Rob Clark
On Wed, Apr 4, 2018 at 6:36 AM, Maarten Lankhorst wrote: > Op 04-04-18 om 12:21 schreef Daniel Vetter: >> On Wed, Apr 04, 2018 at 12:03:00PM +0200, Daniel Vetter wrote: >>> On Tue, Apr 03, 2018 at 06:42:23PM -0400, Rob Clark wrote: Add an atomic helper to implement dirtyfb support. This is n

Re: [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

2018-04-04 Thread Rob Clark
On Wed, Apr 4, 2018 at 5:56 AM, Daniel Vetter wrote: > On Wed, Apr 04, 2018 at 11:10:08AM +0200, Thomas Hellstrom wrote: >> On 04/04/2018 10:43 AM, Daniel Vetter wrote: >> > On Wed, Apr 04, 2018 at 10:22:21AM +0200, Thomas Hellstrom wrote: >> > > Hi, >> > > >> > > On 04/04/2018 08:58 AM, Daniel Ve

Re: [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

2018-04-04 Thread Thomas Hellstrom
On 04/04/2018 12:28 PM, Thomas Hellstrom wrote: On 04/04/2018 11:56 AM, Daniel Vetter wrote: On Wed, Apr 04, 2018 at 11:10:08AM +0200, Thomas Hellstrom wrote: On 04/04/2018 10:43 AM, Daniel Vetter wrote: On Wed, Apr 04, 2018 at 10:22:21AM +0200, Thomas Hellstrom wrote: Hi, On 04/04/2018 08:5

Re: [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

2018-04-04 Thread Maarten Lankhorst
Op 04-04-18 om 13:37 schreef Rob Clark: > On Wed, Apr 4, 2018 at 6:36 AM, Maarten Lankhorst > wrote: >> Op 04-04-18 om 12:21 schreef Daniel Vetter: >>> On Wed, Apr 04, 2018 at 12:03:00PM +0200, Daniel Vetter wrote: On Tue, Apr 03, 2018 at 06:42:23PM -0400, Rob Clark wrote: > Add an atomic

Re: [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

2018-04-04 Thread Rob Clark
On Wed, Apr 4, 2018 at 7:49 AM, Maarten Lankhorst wrote: > Op 04-04-18 om 13:37 schreef Rob Clark: >> On Wed, Apr 4, 2018 at 6:36 AM, Maarten Lankhorst >> wrote: >>> Op 04-04-18 om 12:21 schreef Daniel Vetter: On Wed, Apr 04, 2018 at 12:03:00PM +0200, Daniel Vetter wrote: > On Tue, Apr 0

Re: [PATCH 1/4] drm/vgem: Fix vgem_init to get drm device avaliable.

2018-04-04 Thread Daniel Vetter
On Wed, Apr 04, 2018 at 11:46:30AM +0100, Emil Velikov wrote: > On 29 March 2018 at 08:17, Daniel Vetter wrote: > > On Wed, Mar 28, 2018 at 04:11:39PM +0100, Emil Velikov wrote: > >> On 28 March 2018 at 15:49, Chris Wilson wrote: > >> > Quoting Emil Velikov (2018-03-28 02:24:48) > >> >> From: Dee

Re: [git pull] drm for v4.17-rc1

2018-04-04 Thread Daniel Vetter
On Wed, Apr 04, 2018 at 12:36:20PM +0200, Michel Dänzer wrote: > On 2018-04-03 02:03 PM, Daniel Vetter wrote: > > On Tue, Apr 3, 2018 at 1:52 PM, Daniel Vetter wrote: > >> On Tue, Apr 3, 2018 at 1:13 PM, Lucas Stach wrote: > >>> Hi Daniel, > >>> > >>> Am Dienstag, den 03.04.2018, 12:01 +0200 schr

Re: [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

2018-04-04 Thread Daniel Vetter
On Wed, Apr 04, 2018 at 01:46:37PM +0200, Thomas Hellstrom wrote: > On 04/04/2018 12:28 PM, Thomas Hellstrom wrote: > > On 04/04/2018 11:56 AM, Daniel Vetter wrote: > > > On Wed, Apr 04, 2018 at 11:10:08AM +0200, Thomas Hellstrom wrote: > > > > On 04/04/2018 10:43 AM, Daniel Vetter wrote: > > > > >

Re: [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

2018-04-04 Thread Daniel Vetter
On Wed, Apr 04, 2018 at 07:40:32AM -0400, Rob Clark wrote: > On Wed, Apr 4, 2018 at 5:56 AM, Daniel Vetter wrote: > > On Wed, Apr 04, 2018 at 11:10:08AM +0200, Thomas Hellstrom wrote: > >> On 04/04/2018 10:43 AM, Daniel Vetter wrote: > >> > On Wed, Apr 04, 2018 at 10:22:21AM +0200, Thomas Hellstro

Re: [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

2018-04-04 Thread Daniel Vetter
On Wed, Apr 04, 2018 at 07:35:58AM -0400, Rob Clark wrote: > On Wed, Apr 4, 2018 at 6:21 AM, Daniel Vetter wrote: > > On Wed, Apr 04, 2018 at 12:03:00PM +0200, Daniel Vetter wrote: > >> On Tue, Apr 03, 2018 at 06:42:23PM -0400, Rob Clark wrote: > >> > Add an atomic helper to implement dirtyfb supp

Re: [DPU PATCH v2 0/2] Remove DPU RSC support

2018-04-04 Thread Daniel Vetter
On Wed, Apr 04, 2018 at 04:53:51PM +0530, rya...@codeaurora.org wrote: > On 2018-04-04 15:56, Daniel Vetter wrote: > > On Wed, Apr 04, 2018 at 02:34:40PM +0530, Rajesh Yadav wrote: > > > MSM display controller hardware (DPU) has an inbuilt RSC block > > > which can control power resources and bus b

Re: [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

2018-04-04 Thread Maarten Lankhorst
Op 04-04-18 om 14:05 schreef Rob Clark: > On Wed, Apr 4, 2018 at 7:49 AM, Maarten Lankhorst > wrote: >> Op 04-04-18 om 13:37 schreef Rob Clark: >>> On Wed, Apr 4, 2018 at 6:36 AM, Maarten Lankhorst >>> wrote: Op 04-04-18 om 12:21 schreef Daniel Vetter: > On Wed, Apr 04, 2018 at 12:03:00P

Re: [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

2018-04-04 Thread Daniel Vetter
On Wed, Apr 4, 2018 at 2:05 PM, Rob Clark wrote: > On Wed, Apr 4, 2018 at 7:49 AM, Maarten Lankhorst > wrote: >> Op 04-04-18 om 13:37 schreef Rob Clark: >>> On Wed, Apr 4, 2018 at 6:36 AM, Maarten Lankhorst >>> wrote: Op 04-04-18 om 12:21 schreef Daniel Vetter: > On Wed, Apr 04, 2018 at

Re: [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

2018-04-04 Thread Maarten Lankhorst
Op 04-04-18 om 14:26 schreef Daniel Vetter: > On Wed, Apr 4, 2018 at 2:05 PM, Rob Clark wrote: >> On Wed, Apr 4, 2018 at 7:49 AM, Maarten Lankhorst >> wrote: >>> Op 04-04-18 om 13:37 schreef Rob Clark: On Wed, Apr 4, 2018 at 6:36 AM, Maarten Lankhorst wrote: > Op 04-04-18 om 12:21

Re: [PATCH 1/1] drm/i915:Do not use kfree() to free kmem_cache_alloc() return value

2018-04-04 Thread kbuild test robot
://github.com/0day-ci/linux/commits/Xidong-Wang/drm-i915-Do-not-use-kfree-to-free-kmem_cache_alloc-return-value/20180404-193341 base: git://anongit.freedesktop.org/drm-intel for-linux-next config: i386-randconfig-a1-201813 (attached as .config) compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4 reproduce

Re: [PATCH v2 2/5] drm: bridge: add API to query the expected input formats of bridges

2018-04-04 Thread Laurent Pinchart
Hello, First of all, thank you for the patch. This generates more discussion than I had anticipated, which is both good and bad. I'll comment through the e-mail, and try to explain both my initial idea, and also where it could lead us. On Tuesday, 27 March 2018 16:02:31 EEST jacopo mondi wrote:

Re: [Patch v2 1/6] drm/omap: Add ability to filter out modes which can't be supported

2018-04-04 Thread Benoit Parrot
Tomi Valkeinen wrote on Wed [2018-Apr-04 14:12:13 +0300]: > On 26/03/18 19:21, Benoit Parrot wrote: > > Currently available display mode from a connector are filtered out > > based only on pixel clock capability. However we also need to filter > > out wider mode if we cannot handle them based on

Re: [PATCH 1/1] drm/i915:Do not use kfree() to free kmem_cache_alloc() return value

2018-04-04 Thread kbuild test robot
://github.com/0day-ci/linux/commits/Xidong-Wang/drm-i915-Do-not-use-kfree-to-free-kmem_cache_alloc-return-value/20180404-193341 base: git://anongit.freedesktop.org/drm-intel for-linux-next reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__

Re: [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

2018-04-04 Thread Rob Clark
On Wed, Apr 4, 2018 at 8:16 AM, Daniel Vetter wrote: > On Wed, Apr 04, 2018 at 07:40:32AM -0400, Rob Clark wrote: >> On Wed, Apr 4, 2018 at 5:56 AM, Daniel Vetter wrote: >> > On Wed, Apr 04, 2018 at 11:10:08AM +0200, Thomas Hellstrom wrote: >> >> On 04/04/2018 10:43 AM, Daniel Vetter wrote: >> >>

Re: [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

2018-04-04 Thread Rob Clark
On Wed, Apr 4, 2018 at 8:26 AM, Daniel Vetter wrote: > On Wed, Apr 4, 2018 at 2:05 PM, Rob Clark wrote: >> On Wed, Apr 4, 2018 at 7:49 AM, Maarten Lankhorst >> wrote: >>> Op 04-04-18 om 13:37 schreef Rob Clark: On Wed, Apr 4, 2018 at 6:36 AM, Maarten Lankhorst wrote: > Op 04-04-18

Re: [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

2018-04-04 Thread Daniel Vetter
On Wed, Apr 4, 2018 at 3:24 PM, Rob Clark wrote: > On Wed, Apr 4, 2018 at 8:16 AM, Daniel Vetter wrote: >> On Wed, Apr 04, 2018 at 07:40:32AM -0400, Rob Clark wrote: >>> On Wed, Apr 4, 2018 at 5:56 AM, Daniel Vetter wrote: >>> > On Wed, Apr 04, 2018 at 11:10:08AM +0200, Thomas Hellstrom wrote: >

Re: [PATCH 2/6] drm/omap: gem: Merge __omap_gem_get_pages() and omap_gem_attach_pages()

2018-04-04 Thread Lucas Stach
Am Montag, den 02.04.2018, 21:50 +0300 schrieb Laurent Pinchart: > The __omap_gem_get_pages() function is a wrapper around > omap_gem_attach_pages() that returns the omap_obj->pages pointer through > a function argument. Some callers don't need the pages pointer, and all > of them can access omap_o

Re: [PATCH 1/1] drm/i915:Do not use kfree() to free kmem_cache_alloc() return value

2018-04-04 Thread kbuild test robot
-ci/linux/commits/Xidong-Wang/drm-i915-Do-not-use-kfree-to-free-kmem_cache_alloc-return-value/20180404-193341 base: git://anongit.freedesktop.org/drm-intel for-linux-next config: i386-randconfig-x009-201813 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the

[Bug 105339] Deadlock inside glClientWaitSync [Regresion bc65dcab3bc48673ff6180afb036561a4b8b1119]

2018-04-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105339 --- Comment #6 from Ben Clapp --- With a TR 1950X CPU, RX 580 GPU, Debian testing branch (buster), Mesa 18.0, I'm also able to reproduce this bug. (I also discovered it using Dolphin.) The issue wasn't present in 17.3.7, but when I made the jump

Re: [PATCH] MAINTAINERS: add dri-devel&linaro-mm for Android ION

2018-04-04 Thread Laura Abbott
On 04/04/2018 03:30 AM, Daniel Vetter wrote: Most of the other cross-driver gfx infrastructure (dma_buf, dma_fence) also gets cross posted to all the relevant gfx/memory lists. Doing the same for ION means people won't miss relevant patches. No problem from me, the rate of checkpatch fixups sh

Re: [Patch v2 1/6] drm/omap: Add ability to filter out modes which can't be supported

2018-04-04 Thread Laurent Pinchart
Hi Benoit, On Wednesday, 4 April 2018 16:15:11 EEST Benoit Parrot wrote: > Tomi Valkeinen wrote on Wed [2018-Apr-04 14:12:13 +0300]: > > On 26/03/18 19:21, Benoit Parrot wrote: > >> Currently available display mode from a connector are filtered out > >> based only on pixel clock capability. Howeve

[Bug 105880] [dc][kabini] Cannot find any crtc or sizes

2018-04-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105880 --- Comment #3 from Harry Wentland --- Looks like we don't detect a display. Can you capture dmesg with cik_support=1 dc=1 dc_log=1 to get more log info? -- You are receiving this mail because: You are the assignee for the bug.

Re: [Patch v2 2/6] dt-bindings: display/ti: Move common dispc bindings to omap-dss.txt

2018-04-04 Thread Laurent Pinchart
Hi Benoit, Thank you for the patch. On Monday, 26 March 2018 19:21:24 EEST Benoit Parrot wrote: > Add common DISPC bindings into the top level bindings file. > Move common bindings here instead of having multiple copies of > the same information in all of the variant specific files. > > Signed-o

[Bug 105837] 0 AD Graphics Corruption

2018-04-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105837 Michel Dänzer changed: What|Removed |Added QA Contact|xorg-t...@lists.x.org |dri-devel@lists.freedesktop

  1   2   3   >