Re: [linux-sunxi] Preferring cursor plane over overlay plane

2018-03-27 Thread Maxime Ripard
On Mon, Mar 26, 2018 at 11:01:53PM +0800, Chen-Yu Tsai wrote: > On Mon, Mar 26, 2018 at 10:45 PM, Maxime Ripard > wrote: > > On Mon, Mar 26, 2018 at 10:22:45PM +0800, Chen-Yu Tsai wrote: > >> On Mon, Mar 26, 2018 at 10:14 PM, Joonas Kylmälä > >> wrote: > >> > Hi DRM subsystem developers, > >> >

Re: [PATCH v6 1/3] dt-bindings: display: bridge: Document THC63LVD1024 LVDS decoder

2018-03-27 Thread Andrzej Hajda
On 27.03.2018 08:15, Vladimir Zapolskiy wrote: > Hi Jacopo, > > On 03/27/2018 01:22 AM, Rob Herring wrote: >> On Tue, Mar 20, 2018 at 02:43:33PM +0200, Laurent Pinchart wrote: >>> Hi Jacopo, >>> >>> (CC'ing Rob) >>> >>> Thank you for the patch. >>> >>> On Friday, 16 March 2018 17:16:37 EET Jacopo M

Re: [PATCH v6 2/3] drm: bridge: Add thc63lvd1024 LVDS decoder driver

2018-03-27 Thread Andrzej Hajda
On 27.03.2018 08:24, Vladimir Zapolskiy wrote: > Hi Jacopo, > > On 03/16/2018 05:16 PM, Jacopo Mondi wrote: >> Add DRM bridge driver for Thine THC63LVD1024 LVDS to digital parallel >> output converter. >> >> Signed-off-by: Jacopo Mondi >> Reviewed-by: Andrzej Hajda >> Reviewed-by: Niklas Söderlun

Re: [PATCH] drm/syncobj: Stop reusing the same struct file for all syncobj -> fd

2018-03-27 Thread Greg KH
On Mon, Mar 26, 2018 at 12:00:37PM -0700, Jason Ekstrand wrote: > From: Chris Wilson > > The vk cts test: > dEQP-VK.api.external.semaphore.opaque_fd.export_multiple_times_temporary > > triggers a lot of > VFS: Close: file count is 0 > > Dave pointed out that clearing the syncobj->file from > dr

Re: [PATCH v6 2/3] drm: bridge: Add thc63lvd1024 LVDS decoder driver

2018-03-27 Thread jacopo mondi
HI Vladimir, On Tue, Mar 27, 2018 at 09:24:28AM +0300, Vladimir Zapolskiy wrote: > Hi Jacopo, > > On 03/16/2018 05:16 PM, Jacopo Mondi wrote: > > Add DRM bridge driver for Thine THC63LVD1024 LVDS to digital parallel > > output converter. > > > > Signed-off-by: Jacopo Mondi > > Reviewed-by: Andrze

Re: [PATCH v6 1/3] dt-bindings: display: bridge: Document THC63LVD1024 LVDS decoder

2018-03-27 Thread jacopo mondi
Hi Andrzej, On Tue, Mar 27, 2018 at 09:12:46AM +0200, Andrzej Hajda wrote: > On 27.03.2018 08:15, Vladimir Zapolskiy wrote: > > Hi Jacopo, > > > > On 03/27/2018 01:22 AM, Rob Herring wrote: > >> On Tue, Mar 20, 2018 at 02:43:33PM +0200, Laurent Pinchart wrote: > >>> Hi Jacopo, > >>> > >>> (CC'ing

Re: [Linaro-mm-sig] [PATCH 1/5] dma-buf: add optional invalidate_mappings callback v2

2018-03-27 Thread Christian König
Am 26.03.2018 um 17:42 schrieb Jerome Glisse: On Mon, Mar 26, 2018 at 10:01:21AM +0200, Daniel Vetter wrote: On Thu, Mar 22, 2018 at 10:58:55AM +0100, Christian König wrote: Am 22.03.2018 um 08:18 schrieb Daniel Vetter: [SNIP] Key take away from that was that you can't take any locks from neith

Re: [PATCH v6 2/3] drm: bridge: Add thc63lvd1024 LVDS decoder driver

2018-03-27 Thread Geert Uytterhoeven
Hi Andrzej, On Tue, Mar 27, 2018 at 9:28 AM, Andrzej Hajda wrote: >>> --- /dev/null >>> +++ b/drivers/gpu/drm/bridge/thc63lvd1024.c >>> +static void thc63_enable(struct drm_bridge *bridge) >>> +{ >>> +struct thc63_dev *thc63 = to_thc63(bridge); >>> +struct regulator *vcc; >>> +int i;

Re: [Intel-gfx] [PATCH 07/23] drm: Make the fb refcount handover less magic

2018-03-27 Thread Daniel Vetter
On Thu, Mar 22, 2018 at 05:22:57PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Instead of assigning the plane->fb pointer and clearing the fb pointer > to hand over the reference, let's just do it by grabbing another > referece for plane->fb and let fb keep its original one. > > Signed

Re: [Linaro-mm-sig] [PATCH 1/5] dma-buf: add optional invalidate_mappings callback v2

2018-03-27 Thread Daniel Vetter
On Tue, Mar 27, 2018 at 09:35:17AM +0200, Christian König wrote: > Am 26.03.2018 um 17:42 schrieb Jerome Glisse: > > On Mon, Mar 26, 2018 at 10:01:21AM +0200, Daniel Vetter wrote: > > > On Thu, Mar 22, 2018 at 10:58:55AM +0100, Christian König wrote: > > > > Am 22.03.2018 um 08:18 schrieb Daniel Ve

Re: [Intel-gfx] [PATCH 15/23] drm: Stop updating plane->crtc/fb/old_fb on atomic drivers

2018-03-27 Thread Daniel Vetter
On Thu, Mar 22, 2018 at 05:23:05PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Stop playing around with plane->crtc/fb/old_fb with atomic > drivers. Make life a lot simpler when we don't have to do the > magic old_fb vs. fb dance around plane updates. That way we > can't risk plane->fb

Re: [PATCHv2 6/7] cec-pin-error-inj.rst: document CEC Pin Error Injection

2018-03-27 Thread Jani Nikula
On Wed, 21 Mar 2018, Mauro Carvalho Chehab wrote: > Please notice that all debugfs/sysfs entries should *also* be > documented at the standard way, e. g. by adding the corresponding > documentation at Documentation/ABI. > > Please see Documentation/ABI/README. > > Additionally, there are a few min

Re: [PATCH 02/10] drm/sun4i: Disable YUV channel when using the frontend and set interlace

2018-03-27 Thread Paul Kocialkowski
Hi, On Fri, 2018-03-23 at 10:55 +0100, Maxime Ripard wrote: > On Wed, Mar 21, 2018 at 04:28:56PM +0100, Paul Kocialkowski wrote: > > The YUV channel was only disabled in > > sun4i_backend_update_layer_formats, > > which is not called when the frontend is selected. > > > > Thus, creating a layer w

Re: [Linaro-mm-sig] [PATCH 1/5] dma-buf: add optional invalidate_mappings callback v2

2018-03-27 Thread Christian König
Am 27.03.2018 um 09:53 schrieb Daniel Vetter: [SNIP] [SNIP] A slightly better solution is using atomic counter: driver_range_start() { atomic_inc(&mydev->notifier_count); ... Yeah, that is exactly what amdgpu is doing now. Sorry if my description didn't made that clear. I would lik

Re: [PATCHv2 6/7] cec-pin-error-inj.rst: document CEC Pin Error Injection

2018-03-27 Thread Wolfram Sang
> > I'll wait for a v3 with the debugfs ABI documentation in order to merge > > it. Feel free to put it on a separate patch. > > debugfs ABI? Sounds like an oxymoron to me. Heh, thought the same :) signature.asc Description: PGP signature ___ dri-de

Re: [PATCH 04/10] drm/sun4i: Explicitly list and check formats supported by the backend

2018-03-27 Thread Paul Kocialkowski
Hi, On Fri, 2018-03-23 at 11:03 +0100, Maxime Ripard wrote: > On Wed, Mar 21, 2018 at 04:28:58PM +0100, Paul Kocialkowski wrote: > > In order to check whether the backend supports a specific format, an > > explicit list and a related helper are introduced. > > > > They are then used to determine

Re: [Intel-gfx] [PATCH 08/23] drm: Use plane->state->fb over plane->fb

2018-03-27 Thread Daniel Vetter
On Thu, Mar 22, 2018 at 05:22:58PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Stop looking at plane->fb on atomic drivers. Use plane->state->fb > instead. > > Signed-off-by: Ville Syrjälä Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/drm_atomic_helper.c | 2 +- > drivers/gp

Re: [PATCH 14/23] drm/atmel-hlcdc: Stop using plane->fb

2018-03-27 Thread Daniel Vetter
On Thu, Mar 22, 2018 at 05:23:04PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > We want to get rid of plane->fb on atomic drivers. Stop looking at it. > > Cc: Boris Brezillon > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 12 +--- > 1

Re: [RFC PATCH 2/3] drm: bridge: panel: allow override of the bus format

2018-03-27 Thread jacopo mondi
HI Laurent, Peter, On Mon, Mar 26, 2018 at 10:03:31PM +0300, Laurent Pinchart wrote: > Hi Peter, > > (CC'ing Jacopo Mondi) > > On Sunday, 25 March 2018 15:01:11 EEST Peter Rosin wrote: > > On 2018-03-20 14:56, Laurent Pinchart wrote: > > > Hi Peter, > > > > > > Thank you for the patch. > > > > > >

Re: [PATCH 02/10] drm/sun4i: Disable YUV channel when using the frontend and set interlace

2018-03-27 Thread Maxime Ripard
On Tue, Mar 27, 2018 at 10:00:43AM +0200, Paul Kocialkowski wrote: > Hi, > > On Fri, 2018-03-23 at 10:55 +0100, Maxime Ripard wrote: > > On Wed, Mar 21, 2018 at 04:28:56PM +0100, Paul Kocialkowski wrote: > > > The YUV channel was only disabled in > > > sun4i_backend_update_layer_formats, > > > whi

Re: [PATCH] drm/scheduler: fix param documentation

2018-03-27 Thread Daniel Vetter
On Mon, Mar 26, 2018 at 08:51:14PM +0530, Nayan Deshmukh wrote: > Signed-off-by: Nayan Deshmukh You might want to add a kerneldoc page in Documentation/gpu/scheduler.rst, which pulls in all the nice kerneldoc you have here + has a short intro text what this is all about. Cheers, Daniel > --- >

Re: [PATCH 1/6] drm/tinydrm: Use gem_free_object_unlocked

2018-03-27 Thread Daniel Vetter
On Thu, Mar 22, 2018 at 02:46:45PM +0100, Noralf Trønnes wrote: > > Den 22.03.2018 11.51, skrev Daniel Vetter: > > tinydrm doesn't use dev->struct_mutex and therefore has no need to use > > gem_free_object. > > > > Signed-off-by: Daniel Vetter > > Cc: "Noralf Trønnes" > > --- > > Acked-by: Nor

Re: [PATCH 00/23] drm: Eliminate plane->fb/crtc usage for atomic drivers

2018-03-27 Thread Daniel Vetter
On Thu, Mar 22, 2018 at 05:22:50PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > I really just wanted to fix i915 to re-enable its planes afer load > detection (a two line patch). This is what I actually ended up with > after I ran into a framebuffer refcount leak with said two line patch

[PATCH 3/5] drm/udl: Get rid of dev->struct_mutex usage

2018-03-27 Thread Daniel Vetter
It's only used to protect our page list, and only when we know we have a full reference. This means none of these code paths can ever race with the final unref, and hence we do not need dev->struct_mutex serialization and can simply switch to our own locking. For more context the only magic the lo

[PATCH 5/5] drm/omapdrm: Switch to gem_free_object_unlocked

2018-03-27 Thread Daniel Vetter
The only thing that omap_gem_free_object does that might need the magic protection of struct_mutex (of keeping all objects alive if that lock is held, even if the last reference is gone) is the mm_list manipulation. But that is already protected by the separate omapdrm->list_lock, which means stru

[PATCH 4/5] drm/omapdrm: Fix mm_list locking

2018-03-27 Thread Daniel Vetter
- None of the list walkings where protected. - Switch to a mutex since the list walking could potentially take a very long time. Only thing we need to be careful with here is that while we walk the list we cant unreference any gem objects, since the final unref would result in a recursive deadl

[PATCH 2/5] drm/rockchip: fixup comment for gem_free_object_unlocked

2018-03-27 Thread Daniel Vetter
Just want to clean out all grep hits. gem_free_object is deprecated. Signed-off-by: Daniel Vetter Cc: Sandy Huang Cc: "Heiko Stübner" Cc: linux-arm-ker...@lists.infradead.org Cc: linux-rockc...@lists.infradead.org --- drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 4 ++-- 1 file changed, 2 inse

[PATCH 1/5] staging/vboxvideo: Use gem_free_object_unlocked

2018-03-27 Thread Daniel Vetter
vboxvideo doesn't use dev->struct_mutex and therefore has no need to use gem_free_object. Signed-off-by: Daniel Vetter Cc: Greg Kroah-Hartman Cc: Hans de Goede Cc: Michael Thayer Cc: Colin Ian King Cc: Daniel Vetter Cc: Stephen Rothwell --- drivers/staging/vboxvideo/vbox_drv.c | 2 +- 1 fi

Re: [PATCH 05/10] drm/sun4i: Explicitly list and check formats supported by the frontend

2018-03-27 Thread Paul Kocialkowski
Hi, On Fri, 2018-03-23 at 11:06 +0100, Maxime Ripard wrote: > On Wed, Mar 21, 2018 at 04:28:59PM +0100, Paul Kocialkowski wrote: > > In order to check whether the frontend supports a specific format, > > an > > explicit list and a related helper are introduced. > > > > They are then used to deter

Re: [Linaro-mm-sig] [PATCH 1/5] dma-buf: add optional invalidate_mappings callback v2

2018-03-27 Thread Daniel Vetter
On Tue, Mar 27, 2018 at 10:06:04AM +0200, Christian König wrote: > Am 27.03.2018 um 09:53 schrieb Daniel Vetter: > > [SNIP] > > > > [SNIP] > > > > A slightly better solution is using atomic counter: > > > > driver_range_start() { > > > > atomic_inc(&mydev->notifier_count); > > > ... > > >

Re: [PATCH v6 1/3] dt-bindings: display: bridge: Document THC63LVD1024 LVDS decoder

2018-03-27 Thread Sergei Shtylyov
Hello! On 3/27/2018 10:33 AM, jacopo mondi wrote: [...] Document Thine THC63LVD1024 LVDS decoder device tree bindings. Signed-off-by: Jacopo Mondi Reviewed-by: Andrzej Hajda Reviewed-by: Niklas Söderlund --- .../bindings/display/bridge/thine,thc63lvd1024.txt | 66 +++ 1 fi

Re: [PATCH 06/10] drm/sun4i: Move and extend format-related helpers and tables

2018-03-27 Thread Paul Kocialkowski
Hi, On Fri, 2018-03-23 at 11:13 +0100, Maxime Ripard wrote: > On Wed, Mar 21, 2018 at 04:29:00PM +0100, Paul Kocialkowski wrote: > > This moves the various helpers and tables related to format > > detection > > and conversion to a dedicated file, while adding a bunch of new > > helpers > > (especi

Re: [PATCH 8/8] drm/arm/malidp: Added the late system pm functions

2018-03-27 Thread Daniel Vetter
On Mon, Mar 26, 2018 at 06:03:20PM +0100, Ayan Kumar Halder wrote: > malidp_pm_suspend_late checks if the runtime status is not suspended > and if so, invokes malidp_runtime_pm_suspend which disables the > display engine/core interrupts and the clocks. It sets the runtime status > as suspended. Sub

Re: [PATCH v6 1/3] dt-bindings: display: bridge: Document THC63LVD1024 LVDS decoder

2018-03-27 Thread Vladimir Zapolskiy
Hi Sergei, On 03/27/2018 11:27 AM, Sergei Shtylyov wrote: > Hello! > > On 3/27/2018 10:33 AM, jacopo mondi wrote: > [...] >>> Document Thine THC63LVD1024 LVDS decoder device tree bindings. >>> >>> Signed-off-by: Jacopo Mondi >>> Reviewed-by: Andrzej Hajda >>> Reviewed-by: Ni

[PATCH][next] drm/amd/pp: Fix spelling mistake: "suppported" -> "supported"

2018-03-27 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in pr_warn warning message text Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/powerplay/hwmgr/pp_psm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/pp_psm.c b/drivers/gpu/dr

Re: [PATCH 1/5] staging/vboxvideo: Use gem_free_object_unlocked

2018-03-27 Thread Greg Kroah-Hartman
On Tue, Mar 27, 2018 at 10:23:52AM +0200, Daniel Vetter wrote: > vboxvideo doesn't use dev->struct_mutex and therefore has no need to use > gem_free_object. > > Signed-off-by: Daniel Vetter > Cc: Greg Kroah-Hartman > Cc: Hans de Goede > Cc: Michael Thayer > Cc: Colin Ian King > Cc: Daniel Vet

Re: [PATCH v6 2/3] drm: bridge: Add thc63lvd1024 LVDS decoder driver

2018-03-27 Thread Andrzej Hajda
On 27.03.2018 09:36, Geert Uytterhoeven wrote: > Hi Andrzej, > > On Tue, Mar 27, 2018 at 9:28 AM, Andrzej Hajda wrote: --- /dev/null +++ b/drivers/gpu/drm/bridge/thc63lvd1024.c +static void thc63_enable(struct drm_bridge *bridge) +{ +struct thc63_dev *thc63 = to_thc63(

Re: [PATCH 07/10] drm/sun4i: Add support for YUV formats through the frontend

2018-03-27 Thread Paul Kocialkowski
Hi, On Fri, 2018-03-23 at 11:30 +0100, Maxime Ripard wrote: > On Wed, Mar 21, 2018 at 04:29:01PM +0100, Paul Kocialkowski wrote: > > The frontend supports many YUV formats as input and also contains a > > color-space converter (CSC) block that can convert YUV input into > > RGB output. It also all

Re: [PATCH 09/10] drm/sun4i: Add a dedicated ioctl call for allocating tiled buffers

2018-03-27 Thread Paul Kocialkowski
On Fri, 2018-03-23 at 11:48 +0100, Maxime Ripard wrote: > Hi, > > On Wed, Mar 21, 2018 at 04:29:03PM +0100, Paul Kocialkowski wrote: > > This introduces a dedicated ioctl for allocating tiled buffers in > > the > > Allwinner MB32 format, that comes with a handful of specific > > constraints. In pa

Re: [PATCH 02/10] drm/sun4i: Disable YUV channel when using the frontend and set interlace

2018-03-27 Thread Paul Kocialkowski
Hi, On Tue, 2018-03-27 at 10:17 +0200, Maxime Ripard wrote: > On Tue, Mar 27, 2018 at 10:00:43AM +0200, Paul Kocialkowski wrote: > > Hi, > > > > On Fri, 2018-03-23 at 10:55 +0100, Maxime Ripard wrote: > > > On Wed, Mar 21, 2018 at 04:28:56PM +0100, Paul Kocialkowski wrote: > > > > The YUV channel

Re: [PATCH 02/10] drm/sun4i: Disable YUV channel when using the frontend and set interlace

2018-03-27 Thread Chen-Yu Tsai
On Tue, Mar 27, 2018 at 4:44 PM, Paul Kocialkowski wrote: > Hi, > > On Tue, 2018-03-27 at 10:17 +0200, Maxime Ripard wrote: >> On Tue, Mar 27, 2018 at 10:00:43AM +0200, Paul Kocialkowski wrote: >> > Hi, >> > >> > On Fri, 2018-03-23 at 10:55 +0100, Maxime Ripard wrote: >> > > On Wed, Mar 21, 2018 a

Re: [PATCH v6 1/3] dt-bindings: display: bridge: Document THC63LVD1024 LVDS decoder

2018-03-27 Thread jacopo mondi
Hi Vladimir, On Tue, Mar 27, 2018 at 11:30:29AM +0300, Vladimir Zapolskiy wrote: > Hi Sergei, > > On 03/27/2018 11:27 AM, Sergei Shtylyov wrote: > > Hello! > > > > On 3/27/2018 10:33 AM, jacopo mondi wrote: > > [...] > >>> Document Thine THC63LVD1024 LVDS decoder device tree bindings. > >>

[Bug 105760] [4.17-drm-wip] RIP: smu7_populate_single_firmware_entry.isra.6+0x57/0xc0 [amdgpu] RSP: ffffa17901efb930

2018-03-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105760 Bug ID: 105760 Summary: [4.17-drm-wip] RIP: smu7_populate_single_firmware_entry.isra.6+0x57/0xc0 [amdgpu] RSP: a17901efb930 Product: DRI Version: DRI git

Re: [PATCH][next] drm/amd/pp: Fix spelling mistake: "suppported" -> "supported"

2018-03-27 Thread Zhu, Rex
Applied and thanks. Best Regards Rex From: Colin King Sent: Tuesday, March 27, 2018 4:32 PM To: Deucher, Alexander; Koenig, Christian; Zhou, David(ChunMing); David Airlie; Zhu, Rex; Quan, Evan; amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org Cc

Re: [PATCH v6 2/3] drm: bridge: Add thc63lvd1024 LVDS decoder driver

2018-03-27 Thread Geert Uytterhoeven
Hi Andrezj, On Tue, Mar 27, 2018 at 10:36 AM, Andrzej Hajda wrote: > On 27.03.2018 09:36, Geert Uytterhoeven wrote: >> On Tue, Mar 27, 2018 at 9:28 AM, Andrzej Hajda wrote: > --- /dev/null > +++ b/drivers/gpu/drm/bridge/thc63lvd1024.c > +static void thc63_enable(struct drm_bridge *br

[bug report] drm/vmwgfx: Cursor update fixes

2018-03-27 Thread Dan Carpenter
Hello Thomas Hellstrom, The patch 25db875401c8: "drm/vmwgfx: Cursor update fixes" from Jan 16, 2018, leads to the following static checker warning: drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:513 vmw_du_cursor_plane_atomic_check() info: return a literal instead of 'ret' drivers/gpu/drm/

[PATCH] gpu: drm: nouveau: Use list_for_each_entry_from_reverse

2018-03-27 Thread Arushi Singhal
It's better to use "list_for_each_entry_from_reverse" for iterating list than "for loop" as it makes the code more clear to read. This patch replace "for loop" with "list_for_each_entry_from_reverse" and remove "cstate" variable as it is redundant in the code. Signed-off-by: Arushi Singhal --- d

Re: [PATCH] gpu: drm: nouveau: Use list_for_each_entry_from_reverse

2018-03-27 Thread Ben Skeggs
On 27 March 2018 at 19:11, Arushi Singhal wrote: > It's better to use "list_for_each_entry_from_reverse" for iterating list > than "for loop" as it makes the code more clear to read. > This patch replace "for loop" with "list_for_each_entry_from_reverse" > and remove "cstate" variable as it is red

Re: [bug report] drm/vmwgfx: Cursor update fixes

2018-03-27 Thread Daniel Vetter
On Tue, Mar 27, 2018 at 12:05:38PM +0300, Dan Carpenter wrote: > Hello Thomas Hellstrom, > > The patch 25db875401c8: "drm/vmwgfx: Cursor update fixes" from Jan > 16, 2018, leads to the following static checker warning: > > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:513 > vmw_du_cursor_plane_atomi

Re: [PATCH 1/5] staging/vboxvideo: Use gem_free_object_unlocked

2018-03-27 Thread Daniel Vetter
On Tue, Mar 27, 2018 at 10:34:07AM +0200, Greg Kroah-Hartman wrote: > On Tue, Mar 27, 2018 at 10:23:52AM +0200, Daniel Vetter wrote: > > vboxvideo doesn't use dev->struct_mutex and therefore has no need to use > > gem_free_object. > > > > Signed-off-by: Daniel Vetter > > Cc: Greg Kroah-Hartman >

Re: [PATCH] drm/amd/pp: silence a static checker warning

2018-03-27 Thread rezhu
Applied. Thanks. Best Regards Rex On 2018年03月26日 11:30, Huang Rui wrote: On Fri, Mar 23, 2018 at 02:39:03PM +0300, Dan Carpenter wrote: This has a static checker warning because "frev" and "crev" can be uninitialized if "info" is NULL. I just changed the order of the checks so that we check

Re: [PATCH 02/10] drm/sun4i: Disable YUV channel when using the frontend and set interlace

2018-03-27 Thread Maxime Ripard
On Tue, Mar 27, 2018 at 10:44:19AM +0200, Paul Kocialkowski wrote: > > > Also, is interlacing actually used on any of the video outputs we > > > support? Perhaps RGB? > > > > Composite would be a better guess :) > > Oh and I was wondering what CVBS was about. Now I know! > It seems that we don't s

Re: [PATCH 02/10] drm/sun4i: Disable YUV channel when using the frontend and set interlace

2018-03-27 Thread Paul Kocialkowski
On Tue, 2018-03-27 at 11:18 +0200, Maxime Ripard wrote: > On Tue, Mar 27, 2018 at 10:44:19AM +0200, Paul Kocialkowski wrote: > > > > Also, is interlacing actually used on any of the video outputs > > > > we > > > > support? Perhaps RGB? > > > > > > Composite would be a better guess :) > > > > Oh

Re: [PATCH v3] drm/xen-front: Add support for Xen PV display frontend

2018-03-27 Thread Oleksandr Andrushchenko
Hi, Daniel! On 03/26/2018 03:46 PM, Oleksandr Andrushchenko wrote: On 03/26/2018 11:18 AM, Daniel Vetter wrote: On Fri, Mar 23, 2018 at 05:54:49PM +0200, Oleksandr Andrushchenko wrote: My apologies, but I found a few more things that look strange and should be cleaned up. Sorry for this iterat

Re: [PATCH v6 1/3] dt-bindings: display: bridge: Document THC63LVD1024 LVDS decoder

2018-03-27 Thread Vladimir Zapolskiy
Hi Jacopo, On 03/27/2018 11:57 AM, jacopo mondi wrote: > Hi Vladimir, > > On Tue, Mar 27, 2018 at 11:30:29AM +0300, Vladimir Zapolskiy wrote: >> Hi Sergei, >> >> On 03/27/2018 11:27 AM, Sergei Shtylyov wrote: >>> Hello! >>> >>> On 3/27/2018 10:33 AM, jacopo mondi wrote: >>> [...] > Docume

Re: [Intel-gfx] [PATCH 15/23] drm: Stop updating plane->crtc/fb/old_fb on atomic drivers

2018-03-27 Thread Ville Syrjälä
On Tue, Mar 27, 2018 at 09:57:41AM +0200, Daniel Vetter wrote: > On Thu, Mar 22, 2018 at 05:23:05PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Stop playing around with plane->crtc/fb/old_fb with atomic > > drivers. Make life a lot simpler when we don't have to do the > > magic ol

Re: [PATCH v2 2/5] drm: bridge: add API to query the expected input formats of bridges

2018-03-27 Thread jacopo mondi
Hi Peter, thanks for the patches On Mon, Mar 26, 2018 at 11:24:44PM +0200, Peter Rosin wrote: > Bridges may affect the required bus output format of the encoder, in > which case it may be wrong to use the output format of the panel or > connector as is. Add infrastructure to address this proble

Re: [PATCH v3] drm/xen-front: Add support for Xen PV display frontend

2018-03-27 Thread Daniel Vetter
On Tue, Mar 27, 2018 at 11:34 AM, Oleksandr Andrushchenko wrote: > Hi, Daniel! > > > On 03/26/2018 03:46 PM, Oleksandr Andrushchenko wrote: >> >> On 03/26/2018 11:18 AM, Daniel Vetter wrote: >>> >>> On Fri, Mar 23, 2018 at 05:54:49PM +0200, Oleksandr Andrushchenko wrote: > > My apologies,

Re: [PATCH v6 2/3] drm: bridge: Add thc63lvd1024 LVDS decoder driver

2018-03-27 Thread Vladimir Zapolskiy
Hi Andrzej, On 03/27/2018 10:28 AM, Andrzej Hajda wrote: > On 27.03.2018 08:24, Vladimir Zapolskiy wrote: >> Hi Jacopo, >> >> On 03/16/2018 05:16 PM, Jacopo Mondi wrote: >>> Add DRM bridge driver for Thine THC63LVD1024 LVDS to digital parallel >>> output converter. >>> >>> Signed-off-by: Jacopo Mo

Re: [PATCH 8/8] drm/arm/malidp: Added the late system pm functions

2018-03-27 Thread Ayan Halder
On Tue, Mar 27, 2018 at 10:29:03AM +0200, Daniel Vetter wrote: > On Mon, Mar 26, 2018 at 06:03:20PM +0100, Ayan Kumar Halder wrote: > > malidp_pm_suspend_late checks if the runtime status is not suspended > > and if so, invokes malidp_runtime_pm_suspend which disables the > > display engine/core in

Re: [PATCH 1/2] drm/simple-kms-helper: Plumb plane state to the enable hook

2018-03-27 Thread Ville Syrjälä
On Sat, Mar 24, 2018 at 12:26:32PM -0500, David Lechner wrote: > On 03/22/2018 03:27 PM, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > We'll need access to the plane state during .atomic_enable(). > > > > Some more details in the commit message would be useful. It is > not clear to me wh

Re: [PATCH v3] drm/xen-front: Add support for Xen PV display frontend

2018-03-27 Thread Oleksandr Andrushchenko
On 03/27/2018 12:50 PM, Daniel Vetter wrote: On Tue, Mar 27, 2018 at 11:34 AM, Oleksandr Andrushchenko wrote: Hi, Daniel! On 03/26/2018 03:46 PM, Oleksandr Andrushchenko wrote: On 03/26/2018 11:18 AM, Daniel Vetter wrote: On Fri, Mar 23, 2018 at 05:54:49PM +0200, Oleksandr Andrushchenko wro

Re: [PATCH v6 1/3] dt-bindings: display: bridge: Document THC63LVD1024 LVDS decoder

2018-03-27 Thread jacopo mondi
Hi Vladimir, On Tue, Mar 27, 2018 at 12:37:31PM +0300, Vladimir Zapolskiy wrote: > Hi Jacopo, > > On 03/27/2018 11:57 AM, jacopo mondi wrote: > > Hi Vladimir, > > > > On Tue, Mar 27, 2018 at 11:30:29AM +0300, Vladimir Zapolskiy wrote: > >> Hi Sergei, > >> > >> On 03/27/2018 11:27 AM, Sergei Shtyly

Re: [PATCH v2 4/5] drm: bridge: lvds-encoder: allow specifying the input bus format

2018-03-27 Thread jacopo mondi
Hi Peter, Laurent, thanks for the patches, On Mon, Mar 26, 2018 at 11:24:46PM +0200, Peter Rosin wrote: > If the bridge changes the bus format, allow this to be described in > the bridge, instead of providing false information about the bus > format of the connector or panel. > > Signed-off-by:

Re: [PATCH v6 1/3] dt-bindings: display: bridge: Document THC63LVD1024 LVDS decoder

2018-03-27 Thread Vladimir Zapolskiy
Hi Jacopo, On 03/27/2018 01:10 PM, jacopo mondi wrote: > Hi Vladimir, > > On Tue, Mar 27, 2018 at 12:37:31PM +0300, Vladimir Zapolskiy wrote: >> Hi Jacopo, >> >> On 03/27/2018 11:57 AM, jacopo mondi wrote: >>> Hi Vladimir, >>> >>> On Tue, Mar 27, 2018 at 11:30:29AM +0300, Vladimir Zapolskiy wrote

Re: [PATCH 8/8] drm/arm/malidp: Added the late system pm functions

2018-03-27 Thread Daniel Vetter
On Tue, Mar 27, 2018 at 11:59 AM, Ayan Halder wrote: > On Tue, Mar 27, 2018 at 10:29:03AM +0200, Daniel Vetter wrote: >> On Mon, Mar 26, 2018 at 06:03:20PM +0100, Ayan Kumar Halder wrote: >> > malidp_pm_suspend_late checks if the runtime status is not suspended >> > and if so, invokes malidp_runti

Re: [PATCH xserver 3/3] modesetting/drmmode: Use drmModeGetFB2

2018-03-27 Thread Daniel Stone
Hi Emil, On 26 March 2018 at 16:22, Emil Velikov wrote: > On 23 March 2018 at 13:50, Daniel Stone wrote: >> Much like AddFB -> AddFB2, GetFB2 lets us get multiple buffers back as >> well as modifier information. This lets us use -background none with >> multiplanar formats, or modifiers which ca

Re: [PATCH] gpu: drm: nouveau: Use list_for_each_entry_from_reverse

2018-03-27 Thread Arushi Singhal
On Tue, Mar 27, 2018 at 2:44 PM, Ben Skeggs wrote: > On 27 March 2018 at 19:11, Arushi Singhal > wrote: > > It's better to use "list_for_each_entry_from_reverse" for iterating list > > than "for loop" as it makes the code more clear to read. > > This patch replace "for loop" with "list_for_each_

[Bug 105733] Amdgpu randomly hangs and only ssh works. Mouse cursor moves sometimes but does nothing. Keyboard stops working.

2018-03-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105733 --- Comment #4 from Allan --- If you set amdgpu.dc=1 as a boot parameter and then try openning pavucontrol, the screen hungs with artifacts (mouse cursor keeps moving) and you get this error : ``` [ 125.640254] amdgpu :0e:00.0: GPU fault

Re: [bug report] drm/vmwgfx: Cursor update fixes

2018-03-27 Thread Thomas Hellstrom
Hi! Thanks for the comments, I'll take a closer look. /Thomas On 03/27/2018 11:16 AM, Daniel Vetter wrote: On Tue, Mar 27, 2018 at 12:05:38PM +0300, Dan Carpenter wrote: Hello Thomas Hellstrom, The patch 25db875401c8: "drm/vmwgfx: Cursor update fixes" from Jan 16, 2018, leads to the follow

[Bug 105729] AMD Radeon flickering on Gnome Wayland after wake from suspend

2018-03-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105729 --- Comment #2 from Jan Vlug --- > I believe it's the same, > flickering when mouse movement occurs. However it's not flickering, it's > more like it's locking the framebuffer and preventing any draws. Try running > glxgears and moving your curs

[Bug 105747] TOPAZ: ring buffers not getting initialized with the amd-staging-drm-next branch

2018-03-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105747 Nayan Deshmukh changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #5 from Nayan Des

Re: [PATCH v2 2/5] drm: bridge: add API to query the expected input formats of bridges

2018-03-27 Thread jacopo mondi
Hi Peter, On Tue, Mar 27, 2018 at 02:12:42PM +0200, Peter Rosin wrote: > Hi Jacopo, > > Thanks for the feedback! > > On 2018-03-27 11:47, jacopo mondi wrote: > > Hi Peter, > >thanks for the patches > > > > On Mon, Mar 26, 2018 at 11:24:44PM +0200, Peter Rosin wrote: > >> Bridges may affect the

Re: [PATCH] drm/dp: Correctly mask DP_TRAINING_AUX_RD_INTERVAL values for DP 1.4

2018-03-27 Thread kbuild test robot
Hi Matt, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm/drm-next] [also build test ERROR on v4.16-rc7 next-20180326] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/com

Preferring cursor plane over overlay plane

2018-03-27 Thread Joonas Kylmälä
Hi DRM subsystem developers, I ran into this patch where overlay plane was switched to cursor plane because there was no proper cursor plane available on the display hardware: . Can we discuss whether to have a policy of using a normal plane for cursor plane in

[PATCH v2 4/5] drm: bridge: lvds-encoder: allow specifying the input bus format

2018-03-27 Thread Peter Rosin
If the bridge changes the bus format, allow this to be described in the bridge, instead of providing false information about the bus format of the connector or panel. Signed-off-by: Peter Rosin --- .../bindings/display/bridge/lvds-transmitter.txt | 6 ++ drivers/gpu/drm/bridge/lvds-encode

[PATCH] drm/atmel-hlcdc: add command line option to specify preferred depth

2018-03-27 Thread Peter Rosin
I have an sama5d31-based system with 64MB of memory and a 1920x1080 LVDS display wired for 16-bpp. When I enable legacy fbdev support, the contiguous memory allocator invariably fails with the order-11 allocation for a 1920x1080@24-bpp buffer (~6MB). But this HW can never make any good use of RGB88

Re: [PATCH] gpu: host1x: Fix compiler errors

2018-03-27 Thread Emil Goode
Hello, On Mon, Mar 26, 2018 at 04:57:34PM +0200, Thierry Reding wrote: > On Mon, Mar 26, 2018 at 04:44:14PM +0200, Emil Goode wrote: > > The compiler is complaining with the following errors: > > > > drivers/gpu/host1x/cdma.c:94:48: error: > > passing argument 3 of ‘dma_alloc_wc’ from incompa

Re: [PATCH v6] ARM: dts: wheat: Fix ADV7513 address usage

2018-03-27 Thread Simon Horman
On Mon, Mar 26, 2018 at 10:04:24AM +0100, Kieran Bingham wrote: > Hi Simon, > > On 26/03/18 09:31, Simon Horman wrote: > > On Fri, Mar 23, 2018 at 09:16:13PM +, Kieran Bingham wrote: > >> Hi Simon, > >> > >> On 23/03/18 08:51, Simon Horman wrote: > >>> On Thu, Mar 22, 2018 at 09:30:40PM +,

[PATCH v2 2/5] drm: bridge: add API to query the expected input formats of bridges

2018-03-27 Thread Peter Rosin
Bridges may affect the required bus output format of the encoder, in which case it may be wrong to use the output format of the panel or connector as is. Add infrastructure to address this problem. Signed-off-by: Peter Rosin --- drivers/gpu/drm/drm_bridge.c | 32

[PATCH] drm/mxsfb: add poll_changed event handler to set_par on startup

2018-03-27 Thread Michael Grzeschik
We move drm_kms_helper_poll_init behind the drm_fbdev_cma_init so the set_par will be called and fb will be active. Signed-off-by: Michael Grzeschik --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b

[PATCH v2 0/5] allow override of bus format in bridges

2018-03-27 Thread Peter Rosin
Hi! [I got to v2 sooner than expected] I have an Atmel sama5d31 hooked up to an lvds encoder and then on to an lvds panel. Which seems like something that has been done one or two times before... The problem is that the bus_format of the SoC and the panel do not agree. The SoC driver (atmel-hlcd

Re: [PATCH] drm/mxsfb: add poll_changed event handler to set_par on startup

2018-03-27 Thread Michael Grzeschik
On Mon, Mar 26, 2018 at 06:17:44PM +0200, Michael Grzeschik wrote: > We move drm_kms_helper_poll_init behind the drm_fbdev_cma_init so the > set_par will be called and fb will be active. > As this commit message is not very informative and digging deeper into the stubs I came up with another Idea

Re: [PATCH v2 4/5] drm: bridge: lvds-encoder: allow specifying the input bus format

2018-03-27 Thread Peter Rosin
Hi Jacopo, Thanks for you feedback! On 2018-03-27 12:27, jacopo mondi wrote: > Hi Peter, Laurent, >thanks for the patches, > > On Mon, Mar 26, 2018 at 11:24:46PM +0200, Peter Rosin wrote: >> If the bridge changes the bus format, allow this to be described in >> the bridge, instead of providi

Re: [PATCH v2 2/5] drm: bridge: add API to query the expected input formats of bridges

2018-03-27 Thread Peter Rosin
Hi Jacopo, Thanks for the feedback! On 2018-03-27 11:47, jacopo mondi wrote: > Hi Peter, >thanks for the patches > > On Mon, Mar 26, 2018 at 11:24:44PM +0200, Peter Rosin wrote: >> Bridges may affect the required bus output format of the encoder, in >> which case it may be wrong to use the o

Re: [PATCH v6] ARM: dts: wheat: Fix ADV7513 address usage

2018-03-27 Thread Simon Horman
On Fri, Mar 23, 2018 at 09:16:13PM +, Kieran Bingham wrote: > Hi Simon, > > On 23/03/18 08:51, Simon Horman wrote: > > On Thu, Mar 22, 2018 at 09:30:40PM +, Kieran Bingham wrote: > >> The r8a7792 Wheat board has two ADV7513 devices sharing a single I2C > >> bus, however in low power mode t

[PATCH v2 1/5] dt-bindings: display: bridge: lvds-transmitter: add ti, ds90c185

2018-03-27 Thread Peter Rosin
Start list of actual chips compatible with "lvds-encoder". Signed-off-by: Peter Rosin --- .../devicetree/bindings/display/bridge/lvds-transmitter.txt | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-transmitte

[PATCH v2 3/5] drm: of: add display bus-format parser

2018-03-27 Thread Peter Rosin
Add a common API to parse display bus format strings into fourcc codes. Signed-off-by: Peter Rosin --- .../devicetree/bindings/display/bus-format.txt | 35 + drivers/gpu/drm/drm_of.c | 59 ++ include/drm/drm_of.h

[PATCH v2 5/5] drm/atmel-hlcdc: take bridges into account when selecting output format

2018-03-27 Thread Peter Rosin
Bridges may affect the required bus output format of the encoder, in which case it may be wrong to use the output format of the panel or connector as is. So, examine if any of the intermediate bridges needs specific bus formats (if there are intermediate bridges). Signed-off-by: Peter Rosin ---

Re: [PATCH v2 2/5] drm: bridge: add API to query the expected input formats of bridges

2018-03-27 Thread Peter Rosin
On 2018-03-27 11:47, jacopo mondi wrote: >> + * RETURNS: >> + * The number of bus input formats the bridge accepts. Zero means that >> + * the chain of bridges are not converting the bus format and that the >> + * format of the drm_connector should be used. > > How do we get to the connector forma

Re: [PATCH libdrm 1/2] intel: Do not use libpciaccess on Android

2018-03-27 Thread Tomasz Figa
On Wed, Mar 21, 2018 at 2:36 AM, Emil Velikov wrote: > From: Tomasz Figa > > This patch makes the code not rely anymore on libpciaccess when compiled > for Android to eliminate ioperm() and iopl() syscalls required by that > library. As a side effect, the mappable aperture size is hardcoded to 64

[PATCH] gpu: host1x: Fix compiler errors

2018-03-27 Thread Emil Goode
The compiler is complaining with the following errors: drivers/gpu/host1x/cdma.c:94:48: error: passing argument 3 of ‘dma_alloc_wc’ from incompatible pointer type [-Werror=incompatible-pointer-types] drivers/gpu/host1x/cdma.c:113:48: error: passing argument 3 of ‘dma_alloc

[Bug 100069] Dirt: Showdown bad performance with enabled advanced lightning

2018-03-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100069 --- Comment #8 from Gregor Münch --- All graphic options are set to the maximum possible value including MSAA. Its not only about low performance, once advanced lightning is set, the graphic is also seriously bugged, including wrong textures.

[Bug 100069] Dirt: Showdown bad performance with enabled advanced lightning

2018-03-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100069 --- Comment #9 from Gregor Münch --- Found YouTube video on Nvidia showing same settings, including advanced lightning working flawless and good speed. https://youtu.be/hP4V5W-IRJ0?t=4m49s However in a phoronix article, Michael is showing inga

[PATCH] drm/vmwgfx: Fix vmw_du_cursor_plane_atomic_check

2018-03-27 Thread Thomas Hellstrom
Use the correct helper and also return early on helper success rather than on helper failure. Also explicitly return 0 in the case of no fb. Signed-off-by: Thomas Hellstrom Reported-by: Dan Carpenter Reported-by: Daniel Vetter --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 22 +++--

[git pull] amdkfd next 4.17

2018-03-27 Thread Oded Gabbay
Hi Dave, Last pull for 4.17. Highlights: - GPUVM support for dGPUs - KFD events support for dGPUs - Fix live-lock situation when restoring multiple evicted processes - Fix VM page table allocation on large-bar systems - Fix for build failure on frv architecture The following changes since commit

[Bug 105712] intel-gpu-overlay is showing insane power consumption amounts

2018-03-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105712 --- Comment #9 from Chris Wilson --- Created attachment 138378 --> https://bugs.freedesktop.org/attachment.cgi?id=138378&action=edit Use setlocale("C") around strtod Please try the attached patch. -- You are receiving this mail because: You

Re: [PATCH 06/10] drm/sun4i: Move and extend format-related helpers and tables

2018-03-27 Thread Maxime Ripard
On Tue, Mar 27, 2018 at 10:27:44AM +0200, Paul Kocialkowski wrote: > > > +bool sun4i_format_is_rgb(uint32_t format); > > > +bool sun4i_format_is_yuv(uint32_t format); > > > +bool sun4i_format_is_yuv411(uint32_t format); > > > +bool sun4i_format_is_yuv420(uint32_t format); > > > +bool sun4i_format_i

Re: [PATCH 09/10] drm/sun4i: Add a dedicated ioctl call for allocating tiled buffers

2018-03-27 Thread Maxime Ripard
On Tue, Mar 27, 2018 at 10:41:38AM +0200, Paul Kocialkowski wrote: > > > +int drm_sun4i_gem_create_tiled(struct drm_device *dev, void *data, > > > +struct drm_file *file_priv); > > > > Do you need it to be non-static, and part of the header as well? > > Here as well, I jus

[PULL] drm-intel-next-fixes

2018-03-27 Thread Joonas Lahtinen
Hi Dave, Two human-reported bugs to close for display and a more rare fix that could result in GPU hang. There was some unclarity about the GVT pull, so I'm not including it here. Happy Easter holidays! Regards, Joonas drm-intel-next-fixes-2018-03-27: - Display fixes for booting with MST hub l

  1   2   >