Re: [PATCH] fix double ;;s in code

2018-02-20 Thread Jani Nikula
On Mon, 19 Feb 2018, Pavel Machek wrote: > On Mon 2018-02-19 16:41:35, Daniel Vetter wrote: >> Yeah, pls split this into one patch per area, with a suitable patch >> subject prefix. Look at git log of each file to get a feeling for what's >> the standard in each area. > > Yeah I can spend hour spl

Re: [PATCH] fix double ;;s in code

2018-02-20 Thread Vineet Gupta
On 02/17/2018 01:19 PM, Pavel Machek wrote: Fix double ;;'s in code. Signed-off-by: Pavel Machek diff --git a/arch/arc/kernel/setup.c b/arch/arc/kernel/setup.c index 9d27331..ec12fe1 100644 --- a/arch/arc/kernel/setup.c +++ b/arch/arc/kernel/setup.c @@ -373,7 +373,7 @@ static void arc_chk_core_

Re: [PATCH] fix double ;;s in code

2018-02-20 Thread Michael Ellerman
Daniel Vetter writes: > On Sun, Feb 18, 2018 at 11:00:56AM +0100, Christophe LEROY wrote: >> Le 17/02/2018 à 22:19, Pavel Machek a écrit : >> > >> > Fix double ;;'s in code. >> > >> > Signed-off-by: Pavel Machek >> >> A summary of the files modified on top of the patch would help understand >>

Re: [RFC PATCH v2 1/6] dt-bindings: add bindings for USB physical connector

2018-02-20 Thread Andrzej Hajda
On 19.02.2018 15:28, Rob Herring wrote: > On Thu, Feb 15, 2018 at 11:39:15AM +0100, Andrzej Hajda wrote: >> These bindings allow to describe most known standard USB connectors >> and it should be possible to extend it if necessary. >> USB connectors, beside USB can be used to route other protocols,

[Bug 105170] Radeon R9 Nano failed testing IB on GFX ring (-110). [amd64, kernel 4.15.4]

2018-02-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105170 --- Comment #3 from Michel Dänzer --- I don't suppose it works better without amdgpu.vm_fragment_size=9 on the kernel command line? -- You are receiving this mail because: You are the assignee for the bug.__

[Bug 104194] HDMI with RX460 not working on linux 4.15-rc2 with DC enabled and linux-amd-staging-drm-next

2018-02-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104194 --- Comment #6 from Jordan L --- Hi, Would you mind posting your dmesg and X logs while the monitor is black? Does the monitor show up as enabled on xrandr? Thanks -- You are receiving this mail because: You are the assignee for the bug.___

[Bug 105171] Performance regression running glamor with PutImage workload

2018-02-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105171 Bug ID: 105171 Summary: Performance regression running glamor with PutImage workload Product: Mesa Version: 17.3 Hardware: Other OS: All Status

[Bug 105172] [bisected] Unable to start X on Vega (EE) AMDGPU(0): amdgpu_setup_kernel_mem failed

2018-02-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105172 Bug ID: 105172 Summary: [bisected] Unable to start X on Vega (EE) AMDGPU(0): amdgpu_setup_kernel_mem failed Product: DRI Version: unspecified Hardware: x86-64 (AMD64)

[Bug 105172] [bisected] Unable to start X on Vega (EE) AMDGPU(0): amdgpu_setup_kernel_mem failed

2018-02-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105172 --- Comment #1 from James Harvey --- Created attachment 137458 --> https://bugs.freedesktop.org/attachment.cgi?id=137458&action=edit dmesg with amdgpu.dc_log=1 drm.debug=6 -- You are receiving this mail because: You are the assignee for the

[Bug 105172] [bisected] Unable to start X on Vega (EE) AMDGPU(0): amdgpu_setup_kernel_mem failed

2018-02-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105172 Christian König changed: What|Removed |Added Attachment #137457|text/x-log |text/plain mime type|

[Bug 105172] [bisected] Unable to start X on Vega (EE) AMDGPU(0): amdgpu_setup_kernel_mem failed

2018-02-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105172 --- Comment #2 from Christian König --- Have you updated libdrm recently as well? -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.f

[Bug 105172] [bisected] Unable to start X on Vega (EE) AMDGPU(0): amdgpu_setup_kernel_mem failed

2018-02-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105172 --- Comment #3 from James Harvey --- I last updated libdrm from git on the 14th, I'll update it and see if that helps. -- You are receiving this mail because: You are the assignee for the bug.___ dri

[Bug 105172] [bisected] Unable to start X on Vega (EE) AMDGPU(0): amdgpu_setup_kernel_mem failed

2018-02-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105172 --- Comment #4 from Michel Dänzer --- https://cgit.freedesktop.org/mesa/drm/commit/?id=33a2851ab9bc3cd8a68bedf4cf0fdc549b0f3596 should fix this. -- You are receiving this mail because: You are the assignee for the bug._

Re: [PATCH] drm/meson: fix vsync buffer update

2018-02-20 Thread Neil Armstrong
On 19/02/2018 16:19, Daniel Vetter wrote: > On Thu, Feb 15, 2018 at 11:19:36AM +0100, Neil Armstrong wrote: >> The plane buffer address/stride/height was incorrectly updated in the >> plane_atomic_update operation instead of the vsync irq. >> This patch delays this operation in the vsync irq along

[Bug 104194] HDMI with RX460 not working on linux 4.15-rc2 with DC enabled and linux-amd-staging-drm-next

2018-02-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104194 --- Comment #7 from saunders...@wright.edu --- (In reply to Jordan L from comment #6) > Hi, > > Would you mind posting your dmesg and X logs while the monitor is black? > > Does the monitor show up as enabled on xrandr? > > Thanks Um... I can

[Bug 105172] [bisected] Unable to start X on Vega (EE) AMDGPU(0): amdgpu_setup_kernel_mem failed

2018-02-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105172 Christian König changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [PATCH] drm: Handle unexpected holes in color-eviction

2018-02-20 Thread Chris Wilson
Quoting Daniel Vetter (2018-02-19 15:52:34) > On Mon, Feb 19, 2018 at 02:43:59PM +, Chris Wilson wrote: > > Quoting Joonas Lahtinen (2018-02-19 14:40:32) > > > Quoting Chris Wilson (2018-02-19 13:35:43) > > > > +++ b/drivers/gpu/drm/drm_mm.c > > > > @@ -836,9 +836,24 @@ struct drm_mm_node *drm_

Re: [PATCH v3 03/12] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes

2018-02-20 Thread Laurent Pinchart
Hi Rob, On Tuesday, 20 February 2018 02:54:00 EET Rob Herring wrote: > On Wed, Feb 14, 2018 at 6:04 PM, Laurent Pinchart wrote: > > The internal LVDS encoders now have their own DT bindings. Before > > switching the driver infrastructure to those new bindings, implement > > backward-compatibility

[Bug 104194] HDMI with RX460 not working on linux 4.15-rc2 with DC enabled and linux-amd-staging-drm-next

2018-02-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104194 --- Comment #8 from saunders...@wright.edu --- Hmm... going by Arch Linux package differences, the dmesg output, and the fact I suddenly have working HDMI support, they seem to have set AMDGPU DC to be on by default now on the 4.15 kernels for pr

[Bug 105171] Performance regression running glamor with PutImage workload

2018-02-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105171 --- Comment #1 from Clemens Eisserer --- currently bisecting... -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.freedesktop.org htt

Re: [PATCH 1/2] drm/mm: Fix caching of leftmost node in the interval tree

2018-02-20 Thread Joonas Lahtinen
Quoting Chris Wilson (2018-02-19 10:57:27) > When we descend the tree to find our slot, if we step to the right, we > are no longer the leftmost node. > > Fixes: f808c13fd373 ("lib/interval_tree: fast overlap detection") > Signed-off-by: Chris Wilson > Cc: Davidlohr Bueso > Cc: Jérôme Glisse >

Re: [PATCH 1/8] clk: Add clk_bulk_alloc functions

2018-02-20 Thread Marek Szyprowski
Hi Robin, On 2018-02-19 17:29, Robin Murphy wrote: Hi Maciej, On 19/02/18 15:43, Maciej Purski wrote: When a driver is going to use clk_bulk_get() function, it has to initialize an array of clk_bulk_data, by filling its id fields. Add a new function to the core, which dynamically allocates cl

[CI] drm/mm: Fix caching of leftmost node in the interval tree

2018-02-20 Thread Chris Wilson
When we descend the tree to find our slot, if we step to the right, we are no longer the leftmost node. Fixes: f808c13fd373 ("lib/interval_tree: fast overlap detection") Signed-off-by: Chris Wilson Cc: Davidlohr Bueso Cc: Jérôme Glisse Cc: Christian König Reviewed-by: Joonas Lahtinen --- dri

Re: [PATCH 1/5] drm/docs: Discourage adding more to kms-properties.csv

2018-02-20 Thread Thierry Reding
On Mon, Feb 19, 2018 at 11:53:52PM +0100, Daniel Vetter wrote: > Motivated by patch review. > > The table is really hard to read in source form, hard to edit, and > we've moved away to more focused sections about specific features and > how they're exposed in properties. > > Those sections can th

Re: [PATCH 2/5] drm/docs: Align layout of optional plane blending properties

2018-02-20 Thread Thierry Reding
On Mon, Feb 19, 2018 at 11:53:53PM +0100, Daniel Vetter wrote: > Just a bit of drive-by OCD. All the other property docs use enumerations, > for some nice visual consistency. It also neatly highlights the property > name. > > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/drm_blend.c | 18

Re: [PATCH 1/3] locking/ww_mutex: cleanup lock->ctx usage in amdgpu

2018-02-20 Thread Christian König
Am 19.02.2018 um 17:43 schrieb Daniel Vetter: On Mon, Feb 19, 2018 at 05:29:46PM +0100, Christian König wrote: [SNIP] Well that is not a problem at all. See we don't nest trylock with normal lock acquiring, cause that would indeed bypass the whole deadlock detection. Instead we first use ww_mut

Re: [PATCH 3/5] drm/docs: Document "scaling mode" property better

2018-02-20 Thread Thierry Reding
On Mon, Feb 19, 2018 at 11:53:54PM +0100, Daniel Vetter wrote: > Move it out of the csv dungeon. > > While at it add the missing link to the helper functions for setting > up the "panel rotation" property. > > Also OCD how we list enum property values and their corresponding docs. > Going for a n

Re: [CI] drm/mm: Fix caching of leftmost node in the interval tree

2018-02-20 Thread Christian König
Am 20.02.2018 um 10:37 schrieb Chris Wilson: When we descend the tree to find our slot, if we step to the right, we are no longer the leftmost node. Fixes: f808c13fd373 ("lib/interval_tree: fast overlap detection") Signed-off-by: Chris Wilson Cc: Davidlohr Bueso Cc: Jérôme Glisse Cc: Christia

Re: [PATCH 4/5] drm/doc: Polish for drm_mode_parse_command_line_for_connector

2018-02-20 Thread Thierry Reding
On Mon, Feb 19, 2018 at 11:53:55PM +0100, Daniel Vetter wrote: > Quoting the module option format looks soo much nice, and avoids "nicer"? Other than that: Reviewed-by: Thierry Reding signature.asc Description: PGP signature ___ dri-devel mailing lis

[Bug 105173] With kernel >=4.15 nouveau - artefacts and freezes

2018-02-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105173 Bug ID: 105173 Summary: With kernel >=4.15 nouveau - artefacts and freezes Product: DRI Version: XOrg git Hardware: Other OS: All Status: NEW Severity: n

Re: [PATCH 5/5] drm/doc: Use new substruct support

2018-02-20 Thread Thierry Reding
On Mon, Feb 19, 2018 at 11:53:56PM +0100, Daniel Vetter wrote: > Note: This is untested because the new stuff hasn't landed in upstream > yet. But it should work. > > Signed-off-by: Daniel Vetter > --- > include/drm/drm_vblank.h | 16 > 1 file changed, 16 insertions(+) I couldn

[Bug 105173] With kernel >=4.15 nouveau - artefacts and freezes

2018-02-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105173 --- Comment #1 from Nick Lee --- Created attachment 137460 --> https://bugs.freedesktop.org/attachment.cgi?id=137460&action=edit dmesg log wayland after launch supertuxkart -- You are receiving this mail because: You are the assignee for the

[Bug 105173] With kernel >=4.15 nouveau - artefacts and freezes

2018-02-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105173 --- Comment #2 from Nick Lee --- Created attachment 137461 --> https://bugs.freedesktop.org/attachment.cgi?id=137461&action=edit xorg session dmesg log after launch supertuxkart -- You are receiving this mail because: You are the assignee fo

Re: [PATCH] drm: simple_kms_helper: Add mode_valid() callback support

2018-02-20 Thread Thierry Reding
On Tue, Feb 20, 2018 at 08:28:59AM +0100, Linus Walleij wrote: > The PL111 needs to filter valid modes based on memory bandwidth. > I guess it is a pretty simple operation, so we can still claim > the DRM KMS helper pipeline is simple after adding this (optional) > vtable callback. > > Reviewed-by

[Bug 105173] With kernel >=4.15 nouveau - artefacts and freezes

2018-02-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105173 Nick Lee changed: What|Removed |Added QA Contact||xorg-t...@lists.x.org Component|Gen

Re: [PATCH 2/2] drm/mm: Micro-optimise updating the upper layers of the interval tree

2018-02-20 Thread Joonas Lahtinen
Quoting Chris Wilson (2018-02-19 10:57:28) > When we insert a node into a hole inside the interval tree, we need to > climb the layers above us to update the cached interval. When doing so, > we know that the initial node exists as it is our starting hole. > > add/remove: 0/0 grow/shrink: 0/1 up/d

Re: linux-next: Tree for Feb 19 (gpu/drm/pl111/)

2018-02-20 Thread Thierry Reding
On Mon, Feb 19, 2018 at 10:30:06AM -0800, Randy Dunlap wrote: > [add Eric + dri-devel] > > On 02/19/18 09:26, Randy Dunlap wrote: > > On 02/18/18 18:14, Stephen Rothwell wrote: > >> Hi all, > >> > >> Changes since 20180216: > >> > >> The nand tree gained a conflict against Linus' tree. > >> > >> T

[Bug 105171] Performance regression running glamor with PutImage workload

2018-02-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105171 --- Comment #2 from Clemens Eisserer --- The commit causing this regression is: 8b3a257851905ff444d981e52938cbf2b36ba830 is the first bad commit commit 8b3a257851905ff444d981e52938cbf2b36ba830 Author: Marek Olšák Date: Tue Jul 18 16:08:44 20

[Bug 105172] [bisected] Unable to start X on Vega (EE) AMDGPU(0): amdgpu_setup_kernel_mem failed

2018-02-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105172 --- Comment #6 from James Harvey --- Thanks for your patience guys. Using kernel 4.16-rc2 (but with the bisected commit reverted) X and weston work. Updating libdrm to master-33a2851, X and weston work again (yay!). Updating also mesa (master

Re: [PATCH libdrm] configure.ac: pthread-stubs not present on OpenBSD

2018-02-20 Thread Eric Engestrom
On Tuesday, 2018-02-20 17:09:14 +1100, Jonathan Gray wrote: > pthread-stubs is no longer required on OpenBSD and has been removed. > libpthread parts involved moved to libc. Great news! Reviewed-by: Eric Engestrom Note that meson needs the same change: 8< diff --git a/meson.build b/meson

[PATCH] drm/pl111: Remove reverse dependency on DRM_DUMB_VGA_DAC

2018-02-20 Thread Thierry Reding
From: Thierry Reding DRM_DUMB_VGA_DAC is a user-visible symbol. Selecting it can cause unmet direct dependencies such as this (on i386, randconfig): warning: (DRM_PL111) selects DRM_DUMB_VGA_DAC which has unmet direct dependencies (HAS_IOMEM && DRM && DRM_BRIDGE && OF) This is because

Re: [PATCH] drm: simple_kms_helper: Add mode_valid() callback support

2018-02-20 Thread Daniel Vetter
On Tue, Feb 20, 2018 at 10:52:46AM +0100, Thierry Reding wrote: > On Tue, Feb 20, 2018 at 08:28:59AM +0100, Linus Walleij wrote: > > The PL111 needs to filter valid modes based on memory bandwidth. > > I guess it is a pretty simple operation, so we can still claim > > the DRM KMS helper pipeline is

Re: [PATCH RFC] drm/bridge: panel: Add module_get/but calls to attached panel driver

2018-02-20 Thread Thierry Reding
On Mon, Feb 19, 2018 at 11:59:23PM +0100, Daniel Vetter wrote: > On Mon, Feb 19, 2018 at 10:06:22PM +0200, Jyri Sarha wrote: > > Currently there is no way for a master drm driver to protect against an > > attached panel driver from being unloaded while it is in use. The > > least we can do is to in

[PATCH] drm/amdgpu: Remove duplicate setting of ->need_swiotlb

2018-02-20 Thread Thierry Reding
From: Thierry Reding There's no need to set this before the number of DMA bits has been properly determined. Signed-off-by: Thierry Reding --- drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c b/drivers/gpu/drm/amd/a

Re: [PATCH v2] drm: drm_memory: fix compiler warning on 32-bit targets

2018-02-20 Thread Thierry Reding
On Mon, Feb 19, 2018 at 05:08:54PM -0600, David Lechner wrote: > The end field of struct resource is resource_size_t, so on 32-bit > targets, this is a 32-bit value. That's not quite correct. resource_size_t is a phys_addr_t, which can be 64-bit also on 32-bit targets (if they've got CONFIG_PHYS_A

Re: [PATCH 5/5] drm/doc: Use new substruct support

2018-02-20 Thread Daniel Vetter
On Tue, Feb 20, 2018 at 10:49:52AM +0100, Thierry Reding wrote: > On Mon, Feb 19, 2018 at 11:53:56PM +0100, Daniel Vetter wrote: > > Note: This is untested because the new stuff hasn't landed in upstream > > yet. But it should work. Ok Jani put the patch into topic/core-for-CI temporarily, so I co

Re: [PATCH] drm/pl111: Remove reverse dependency on DRM_DUMB_VGA_DAC

2018-02-20 Thread Archit Taneja
On Tuesday 20 February 2018 03:59 PM, Thierry Reding wrote: From: Thierry Reding DRM_DUMB_VGA_DAC is a user-visible symbol. Selecting it can cause unmet direct dependencies such as this (on i386, randconfig): warning: (DRM_PL111) selects DRM_DUMB_VGA_DAC which has unmet direct depend

Re: [PATCH] drm/simple_kms_helper: Fix NULL pointer dereference with no active CRTC

2018-02-20 Thread Daniel Vetter
On Mon, Feb 19, 2018 at 04:58:43PM +0200, Oleksandr Andrushchenko wrote: > On 02/19/2018 04:30 PM, Daniel Vetter wrote: > > On Tue, Feb 13, 2018 at 10:44:16AM +0200, Oleksandr Andrushchenko wrote: > > > From: Oleksandr Andrushchenko > > > > > > It is possible that drm_simple_kms_plane_atomic_chec

Re: [PATCH 5/5] drm/doc: Use new substruct support

2018-02-20 Thread Thierry Reding
On Tue, Feb 20, 2018 at 12:10:35PM +0100, Daniel Vetter wrote: > On Tue, Feb 20, 2018 at 10:49:52AM +0100, Thierry Reding wrote: > > On Mon, Feb 19, 2018 at 11:53:56PM +0100, Daniel Vetter wrote: > > > Note: This is untested because the new stuff hasn't landed in upstream > > > yet. But it should w

Re: [PATCH 5/5] drm/doc: Use new substruct support

2018-02-20 Thread Jani Nikula
On Tue, 20 Feb 2018, Thierry Reding wrote: > On Mon, Feb 19, 2018 at 11:53:56PM +0100, Daniel Vetter wrote: >> Note: This is untested because the new stuff hasn't landed in upstream >> yet. But it should work. >> >> Signed-off-by: Daniel Vetter >> --- >> include/drm/drm_vblank.h | 16 ++

Re: [PATCH libdrm] configure.ac: pthread-stubs not present on OpenBSD

2018-02-20 Thread Jonathan Gray
On Tue, Feb 20, 2018 at 10:21:38AM +, Eric Engestrom wrote: > On Tuesday, 2018-02-20 17:09:14 +1100, Jonathan Gray wrote: > > pthread-stubs is no longer required on OpenBSD and has been removed. > > libpthread parts involved moved to libc. > > Great news! > Reviewed-by: Eric Engestrom > > No

Re: [PATCH v2 3/8] drm/atomic: Include color encoding/range in plane state dump

2018-02-20 Thread Daniel Vetter
On Mon, Feb 19, 2018 at 10:28:46PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Include color_enconding and color_range in the plane state dump. > > v2: Add kerneldoc (danvet) > > Cc: Harry Wentland > Cc: Daniel Vetter > Cc: Daniel Stone > Cc: Russell King - ARM Linux > Cc: Ilia Mi

Re: [PATCH v2 1/8] drm: Add optional COLOR_ENCODING and COLOR_RANGE properties to drm_plane

2018-02-20 Thread Daniel Vetter
On Mon, Feb 19, 2018 at 10:28:23PM +0200, Ville Syrjala wrote: > From: Jyri Sarha > > Add a standard optional properties to support different non RGB color > encodings in DRM planes. COLOR_ENCODING select the supported non RGB > color encoding, for instance ITU-R BT.709 YCbCr. COLOR_RANGE selects

Re: [PATCH 0/8] drm: Add COLOR_ENCODING and COLOR_RANGE plane properties

2018-02-20 Thread Daniel Vetter
On Wed, Feb 14, 2018 at 09:23:19PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Here's a refresh of Jyri's COLOR_ENCODING and COLOR_RANGE properties, > and the i915 implementation I did on top. I tossed in a few core > updates as well: plane state dump, and the BT.2020 constant luminance

Re: [PATCH RFC] drm/bridge: panel: Add module_get/but calls to attached panel driver

2018-02-20 Thread Jyri Sarha
On 20/02/18 12:34, Thierry Reding wrote: > On Mon, Feb 19, 2018 at 11:59:23PM +0100, Daniel Vetter wrote: >> On Mon, Feb 19, 2018 at 10:06:22PM +0200, Jyri Sarha wrote: >>> Currently there is no way for a master drm driver to protect against an >>> attached panel driver from being unloaded while it

Re: [PATCH 1/3] locking/ww_mutex: cleanup lock->ctx usage in amdgpu

2018-02-20 Thread Daniel Vetter
On Tue, Feb 20, 2018 at 10:43:48AM +0100, Christian König wrote: > Am 19.02.2018 um 17:43 schrieb Daniel Vetter: > > On Mon, Feb 19, 2018 at 05:29:46PM +0100, Christian König wrote: > > > [SNIP] > > > Well that is not a problem at all. See we don't nest trylock with normal > > > lock acquiring, cau

[Bug 105145] vaExportSurfaceHandle interaction with surface interlaced flag prevents switching on vaapi deinterlacing dynamically

2018-02-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105145 --- Comment #5 from k.phil...@gmail.com --- (In reply to Christian König from comment #4) > (In reply to k.philipp from comment #3) > > Also, that VAAPI has to weave the first few textures before they've been > > exported once is not very nice. I

Re: [PATCH 1/3] drm/edid: quirk Oculus Rift headsets as non-desktop

2018-02-20 Thread Jani Nikula
On Mon, 19 Feb 2018, Philipp Zabel wrote: > This uses the EDID info from Oculus Rift DK1 (OVR-0001), DK2 (OVR-0003), > and CV1 (OVR-0004) to mark them as non-desktop. Not that I know anything about this stuff, but should this series be cc: stable? BR, Jani. > Signed-off-by: Philipp Zabel > --

[4.4-stable 21/22] drm/gma500: remove helper function

2018-02-20 Thread Arnd Bergmann
From: Sudip Mukherjee commit db9b60400f9253c25ae639797df2d0ff7a35d9d8 upstream. We were getting build warning about: drivers/gpu/drm/gma500/mdfld_dsi_output.c:407:2: warning: initialization from incompatible pointer type The callback to dpms was pointing to a helper function which had a

Re: [PATCH RFC] drm/bridge: panel: Add module_get/but calls to attached panel driver

2018-02-20 Thread Thierry Reding
On Tue, Feb 20, 2018 at 01:28:48PM +0200, Jyri Sarha wrote: > On 20/02/18 12:34, Thierry Reding wrote: > > On Mon, Feb 19, 2018 at 11:59:23PM +0100, Daniel Vetter wrote: > >> On Mon, Feb 19, 2018 at 10:06:22PM +0200, Jyri Sarha wrote: > >>> Currently there is no way for a master drm driver to prote

Re: [PATCH libdrm] configure.ac: pthread-stubs not present on OpenBSD

2018-02-20 Thread Eric Engestrom
On Tuesday, 2018-02-20 22:23:41 +1100, Jonathan Gray wrote: > On Tue, Feb 20, 2018 at 10:21:38AM +, Eric Engestrom wrote: > > On Tuesday, 2018-02-20 17:09:14 +1100, Jonathan Gray wrote: > > > pthread-stubs is no longer required on OpenBSD and has been removed. > > > libpthread parts involved mo

Re: [PATCH 1/3] locking/ww_mutex: cleanup lock->ctx usage in amdgpu

2018-02-20 Thread Christian König
Am 20.02.2018 um 12:33 schrieb Daniel Vetter: [SNIP] Ah, so the ttm_ctx I've spotted was something entirely different and doesn't contain the ww_acquire_ctx (I didn't check)? I'd assume you have the same ctx passed around to everything in ttm, but if that doesn't exist then we can indeed not anno

Re: [PATCH] drm/simple_kms_helper: Fix NULL pointer dereference with no active CRTC

2018-02-20 Thread Oleksandr Andrushchenko
On 02/20/2018 01:17 PM, Daniel Vetter wrote: On Mon, Feb 19, 2018 at 04:58:43PM +0200, Oleksandr Andrushchenko wrote: On 02/19/2018 04:30 PM, Daniel Vetter wrote: On Tue, Feb 13, 2018 at 10:44:16AM +0200, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko It is possible that drm_si

Re: [PATCH] drm/simple_kms_helper: Fix NULL pointer dereference with no active CRTC

2018-02-20 Thread Daniel Vetter
On Tue, Feb 20, 2018 at 02:36:05PM +0200, Oleksandr Andrushchenko wrote: > On 02/20/2018 01:17 PM, Daniel Vetter wrote: > > On Mon, Feb 19, 2018 at 04:58:43PM +0200, Oleksandr Andrushchenko wrote: > > > On 02/19/2018 04:30 PM, Daniel Vetter wrote: > > > > On Tue, Feb 13, 2018 at 10:44:16AM +0200, O

Re: [PATCH] drm/simple_kms_helper: Fix NULL pointer dereference with no active CRTC

2018-02-20 Thread Oleksandr Andrushchenko
On 02/20/2018 02:49 PM, Daniel Vetter wrote: On Tue, Feb 20, 2018 at 02:36:05PM +0200, Oleksandr Andrushchenko wrote: On 02/20/2018 01:17 PM, Daniel Vetter wrote: On Mon, Feb 19, 2018 at 04:58:43PM +0200, Oleksandr Andrushchenko wrote: On 02/19/2018 04:30 PM, Daniel Vetter wrote: On Tue, Feb

[Bug 105145] vaExportSurfaceHandle interaction with surface interlaced flag prevents switching on vaapi deinterlacing dynamically

2018-02-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105145 Christian König changed: What|Removed |Added Severity|major |enhancement Status|RESOLV

[Bug 105145] vaExportSurfaceHandle interaction with surface interlaced flag prevents switching on vaapi deinterlacing dynamically

2018-02-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105145 Christian König changed: What|Removed |Added Resolution|NOTOURBUG |--- Status|VERIFIED

[PATCH 1/4] locking/ww_mutex: add ww_mutex_is_owned_by function v3

2018-02-20 Thread Christian König
amdgpu needs to verify if userspace sends us valid addresses and the simplest way of doing this is to check if the buffer object is locked with the ticket of the current submission. Clean up the access to the ww_mutex internals by providing a function for this and extend the check to the thread ow

[PATCH 3/4] drm/ttm: handle already locked BOs during eviction and swapout.

2018-02-20 Thread Christian König
This solves the problem that when we swapout a BO from a domain we sometimes couldn't make room for it because holding the lock blocks all other BOs with this reservation object. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 33 - 1 file change

[PATCH 2/4] drm/amdgpu: use new ww_mutex_is_owned_by function

2018-02-20 Thread Christian König
Instead of accessing ww_mutex internals directly use the provided function to check if the ww_mutex was indeed locked by the current command submission. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

[PATCH 4/4] drm/ttm: keep BOs reserved until end of eviction

2018-02-20 Thread Christian König
This avoids problems when BOs are evicted but directly moved back into the domain from other threads. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 37 + 1 file changed, 29 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm

Re: [PATCH 1/3] locking/ww_mutex: cleanup lock->ctx usage in amdgpu

2018-02-20 Thread Christian König
Am 20.02.2018 um 13:35 schrieb Peter Zijlstra: This really should've been Cc'ed to me. On Thu, Feb 15, 2018 at 03:19:42PM +0100, Christian König wrote: diff --git a/include/linux/ww_mutex.h b/include/linux/ww_mutex.h index 39fda195bf78..dd580db289e8 100644 --- a/include/linux/ww_mutex.h +++ b/i

Re: [PATCH 1/4] locking/ww_mutex: add ww_mutex_is_owned_by function v3

2018-02-20 Thread Peter Zijlstra
On Tue, Feb 20, 2018 at 01:58:26PM +0100, Christian König wrote: > amdgpu needs to verify if userspace sends us valid addresses and the simplest > way of doing this is to check if the buffer object is locked with the ticket > of the current submission. > > Clean up the access to the ww_mutex inter

Re: [PATCH libdrm] configure.ac: pthread-stubs not present on OpenBSD

2018-02-20 Thread Jonathan Gray
On Tue, Feb 20, 2018 at 12:18:45PM +, Eric Engestrom wrote: > On Tuesday, 2018-02-20 22:23:41 +1100, Jonathan Gray wrote: > > On Tue, Feb 20, 2018 at 10:21:38AM +, Eric Engestrom wrote: > > > On Tuesday, 2018-02-20 17:09:14 +1100, Jonathan Gray wrote: > > > > pthread-stubs is no longer requ

[PATCH] drm/todo: i915 could use device_link_add

2018-02-20 Thread Daniel Vetter
Noticed while reading some unrelated patches. Unfortunately Imre's patch to add our early/late hooks predated the device_link infrastructure by 2 years. Cc: Imre Deak Cc: Takashi Iwai Signed-off-by: Daniel Vetter --- Documentation/gpu/todo.rst | 7 +++ 1 file changed, 7 insertions(+) diff

Re: [PATCH 1/3] locking/ww_mutex: cleanup lock->ctx usage in amdgpu

2018-02-20 Thread Peter Zijlstra
On Tue, Feb 20, 2018 at 02:08:26PM +0100, Christian König wrote: > Am 20.02.2018 um 13:35 schrieb Peter Zijlstra: > > > +static inline bool ww_mutex_is_owned_by(struct ww_mutex *lock, > > > + struct task_struct *task, > > > + struct ww

Re: [PATCH 1/3] locking/ww_mutex: cleanup lock->ctx usage in amdgpu

2018-02-20 Thread Peter Zijlstra
This really should've been Cc'ed to me. On Thu, Feb 15, 2018 at 03:19:42PM +0100, Christian König wrote: > diff --git a/include/linux/ww_mutex.h b/include/linux/ww_mutex.h > index 39fda195bf78..dd580db289e8 100644 > --- a/include/linux/ww_mutex.h > +++ b/include/linux/ww_mutex.h > @@ -358,4 +358,

Re: [PATCH 5/5] drm/doc: Use new substruct support

2018-02-20 Thread Daniel Vetter
On Tue, Feb 20, 2018 at 12:22:18PM +0100, Thierry Reding wrote: > On Tue, Feb 20, 2018 at 12:10:35PM +0100, Daniel Vetter wrote: > > On Tue, Feb 20, 2018 at 10:49:52AM +0100, Thierry Reding wrote: > > > On Mon, Feb 19, 2018 at 11:53:56PM +0100, Daniel Vetter wrote: > > > > Note: This is untested be

Re: [PATCH 1/4] locking/ww_mutex: add ww_mutex_is_owned_by function v3

2018-02-20 Thread Christian König
Am 20.02.2018 um 14:12 schrieb Peter Zijlstra: On Tue, Feb 20, 2018 at 01:58:26PM +0100, Christian König wrote: amdgpu needs to verify if userspace sends us valid addresses and the simplest way of doing this is to check if the buffer object is locked with the ticket of the current submission. C

Re: [PATCH] drm/simple_kms_helper: Fix NULL pointer dereference with no active CRTC

2018-02-20 Thread Oleksandr Andrushchenko
On 02/20/2018 02:53 PM, Oleksandr Andrushchenko wrote: On 02/20/2018 02:49 PM, Daniel Vetter wrote: On Tue, Feb 20, 2018 at 02:36:05PM +0200, Oleksandr Andrushchenko wrote: On 02/20/2018 01:17 PM, Daniel Vetter wrote: On Mon, Feb 19, 2018 at 04:58:43PM +0200, Oleksandr Andrushchenko wrote: On

Re: [PATCH 0/8] drm: Add COLOR_ENCODING and COLOR_RANGE plane properties

2018-02-20 Thread Ville Syrjälä
On Tue, Feb 20, 2018 at 12:26:59PM +0100, Daniel Vetter wrote: > On Wed, Feb 14, 2018 at 09:23:19PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Here's a refresh of Jyri's COLOR_ENCODING and COLOR_RANGE properties, > > and the i915 implementation I did on top. I tossed in a few cor

[PATCH] drm/nouveau: Replace the iturbt_709 prop with the standarad COLOR_ENCODNIG prop

2018-02-20 Thread Ville Syrjala
From: Ville Syrjälä Replace the ad-hoc iturbt_709 property with the new standard COLOR_ENCODING property. Compiles, but not tested. Cc: Daniel Vetter Cc: nouv...@lists.freedesktop.org Cc: Ben Skeggs Cc: Ilia Mirkin Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/nouveau/dispnv04/overlay.c

[Bug 105145] vaExportSurfaceHandle interaction with surface interlaced flag prevents switching on vaapi deinterlacing dynamically

2018-02-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105145 --- Comment #7 from k.phil...@gmail.com --- (In reply to Christian König from comment #6) > But checking the documentation once more > VA_SURFACE_ATTRIB_USAGE_HINT_VPP_READ actually sounds exactly like what we > need. > > E.g. we switch over to

Re: [PATCH 1/4] locking/ww_mutex: add ww_mutex_is_owned_by function v3

2018-02-20 Thread Peter Zijlstra
On Tue, Feb 20, 2018 at 02:26:55PM +0100, Christian König wrote: > > > +static inline bool ww_mutex_is_owned_by(struct ww_mutex *lock, > > > + struct ww_acquire_ctx *ctx) > > > +{ > > > + if (ctx) > > > + return likely(READ_ONCE(lock->ctx) == ctx); > > > + el

Re: [PATCH 1/4] locking/ww_mutex: add ww_mutex_is_owned_by function v3

2018-02-20 Thread Daniel Vetter
On Tue, Feb 20, 2018 at 01:58:26PM +0100, Christian König wrote: > amdgpu needs to verify if userspace sends us valid addresses and the simplest > way of doing this is to check if the buffer object is locked with the ticket > of the current submission. > > Clean up the access to the ww_mutex inter

Re: [PATCH v3 03/12] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes

2018-02-20 Thread Rob Herring
On Tue, Feb 20, 2018 at 3:15 AM, Laurent Pinchart wrote: > Hi Rob, > > On Tuesday, 20 February 2018 02:54:00 EET Rob Herring wrote: >> On Wed, Feb 14, 2018 at 6:04 PM, Laurent Pinchart wrote: >> > The internal LVDS encoders now have their own DT bindings. Before >> > switching the driver infrastru

Re: [PATCH] drm: add documentation for tv connector state margins

2018-02-20 Thread Jani Nikula
On Mon, 19 Feb 2018, Daniel Vetter wrote: > On Mon, Feb 19, 2018 at 12:40:09PM +0200, Jani Nikula wrote: >> A bit boring documentation fix, but gets rid of the warnings: >> >> ./include/drm/drm_connector.h:370: warning: Function parameter or member >> 'margins.left' not described in 'drm_tv_conn

Re: [PATCH] drm/todo: i915 could use device_link_add

2018-02-20 Thread Imre Deak
On Tue, Feb 20, 2018 at 02:20:17PM +0100, Daniel Vetter wrote: > Noticed while reading some unrelated patches. Unfortunately Imre's > patch to add our early/late hooks predated the device_link > infrastructure by 2 years. > > Cc: Imre Deak > Cc: Takashi Iwai > Signed-off-by: Daniel Vetter Yep,

Re: amdgpu hangs on boot or shutdown on AMD Raven Ridge CPU (Engineer Sample)

2018-02-20 Thread Alex Deucher
On Tue, Feb 20, 2018 at 2:26 AM, Daniel Drake wrote: > Hi, > >> >>> We are working with new laptops that have the AMD Ravenl Ridge >> >>> chipset with this `/proc/cpuinfo` >> >>> https://gist.github.com/mschiu77/b06dba574e89b9a30cf4c450eaec49bc >> >>> >> >>> With the latest kernel 4.15, th

Re: [PATCH 1/8] clk: Add clk_bulk_alloc functions

2018-02-20 Thread Robin Murphy
Hi Marek, On 20/02/18 09:36, Marek Szyprowski wrote: Hi Robin, On 2018-02-19 17:29, Robin Murphy wrote: Hi Maciej, On 19/02/18 15:43, Maciej Purski wrote: When a driver is going to use clk_bulk_get() function, it has to initialize an array of clk_bulk_data, by filling its id fields. Add a n

[PATCH] drm/tve200: fix kernel-doc documentation comment include

2018-02-20 Thread Jani Nikula
The DOC: line acts as an identifier for the :doc: include. Fixes: ./drivers/gpu/drm/tve200/tve200_drv.c:1: warning: no structured comments found Cc: Linus Walleij Signed-off-by: Jani Nikula --- Documentation/gpu/tve200.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Doc

Re: [CI] drm/mm: Fix caching of leftmost node in the interval tree

2018-02-20 Thread Chris Wilson
Quoting Christian König (2018-02-20 09:45:54) > Am 20.02.2018 um 10:37 schrieb Chris Wilson: > > When we descend the tree to find our slot, if we step to the right, we > > are no longer the leftmost node. > > > > Fixes: f808c13fd373 ("lib/interval_tree: fast overlap detection") > > Signed-off-by: C

[Bug 105145] vaExportSurfaceHandle interaction with surface interlaced flag prevents switching on vaapi deinterlacing dynamically

2018-02-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105145 --- Comment #8 from Christian König --- (In reply to k.philipp from comment #7) > I did think about that, but it has the problem of breaking deinterlacing on > all clients that do *not* set VA_SURFACE_ATTRIB_USAGE_HINT_VPP_READ (which I > assume

Re: [PATCH] drm/nouveau: Replace the iturbt_709 prop with the standarad COLOR_ENCODNIG prop

2018-02-20 Thread Ilia Mirkin
On Tue, Feb 20, 2018 at 8:48 AM, Ville Syrjala wrote: > From: Ville Syrjälä > > Replace the ad-hoc iturbt_709 property with the new standard > COLOR_ENCODING property. Compiles, but not tested. > > Cc: Daniel Vetter > Cc: nouv...@lists.freedesktop.org > Cc: Ben Skeggs > Cc: Ilia Mirkin > Signe

Re: [PATCH v2 8/8] drm/rockchip: dw_hdmi: add dw-hdmi support for the rk3328

2018-02-20 Thread Rob Herring
On Mon, Feb 19, 2018 at 2:46 PM, Heiko Stuebner wrote: > Hi Rob, > > Am Montag, 19. Februar 2018, 21:28:53 CET schrieb Rob Herring: >> On Fri, Feb 16, 2018 at 09:41:58PM +0100, Heiko Stuebner wrote: >> > The rk3328 uses an external hdmi phy from Innosilicon which uses >> > the generic phy framewor

Re: [PATCH 1/4] locking/ww_mutex: add ww_mutex_is_owned_by function v3

2018-02-20 Thread Christian König
Am 20.02.2018 um 14:57 schrieb Peter Zijlstra: On Tue, Feb 20, 2018 at 02:26:55PM +0100, Christian König wrote: +static inline bool ww_mutex_is_owned_by(struct ww_mutex *lock, + struct ww_acquire_ctx *ctx) +{ + if (ctx) + return likely(RE

[Bug 104194] HDMI with RX460 not working on linux 4.15-rc2 with DC enabled and linux-amd-staging-drm-next

2018-02-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104194 Alex Deucher changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[PATCH] locking/ww_mutex: add ww_mutex_is_owned_by function v4

2018-02-20 Thread Christian König
amdgpu needs to verify if userspace sends us valid addresses and the simplest way of doing this is to check if the buffer object is locked with the ticket of the current submission. Clean up the access to the ww_mutex internals by providing a function for this and extend the check to the thread ow

Re: [PATCH] drm/msm/dpu: Remove unused code and move the header

2018-02-20 Thread Rob Clark
On Thu, Feb 15, 2018 at 3:45 PM, Jordan Crouse wrote: > Remove unused code from dpu_io_util.c. The functions are only > used inside of the msm driver so remove the EXPORT_SYMBOL > tags and move the header dpu_io_util.h from include/linux. > > Signed-off-by: Jordan Crouse Thanks, Reviewed-by: R

Re: [PATCH 1/4] locking/ww_mutex: add ww_mutex_is_owned_by function v3

2018-02-20 Thread Peter Zijlstra
On Tue, Feb 20, 2018 at 03:34:07PM +0100, Christian König wrote: > > OK, but neither case would in fact need the !ctx case right? That's just > > there for completeness sake? > > Unfortunately not. TTM uses trylock to lock BOs which are about to be > evicted to make room for all the BOs locked wit

  1   2   >