Re: [PATCH v3 6/8] drm: Expose modes with aspect ratio, only if requested

2018-01-31 Thread Nautiyal, Ankit K
Hi Ville, Thanks for the comments and suggestions. Please find my response inline: On 1/30/2018 12:28 AM, Ville Syrjälä wrote: On Fri, Jan 12, 2018 at 11:51:34AM +0530, Nautiyal, Ankit K wrote: From: Ankit Nautiyal We parse the EDID and add all the modes in the connector's modelist. This a

[PATCH v2] drm/stm: check pitch and size calculations even if !CONFIG_MMU

2018-01-31 Thread Benjamin Gaignard
In all cases we have to check pitch and size calculations to speed up data transfer. Fixes: 21f815bf773c ("drm/stm: drv: Improve data transfers") Signed-off-by: Benjamin Gaignard --- drivers/gpu/drm/stm/drv.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/stm/drv.c b/drive

Re: [PATCH] drm: Print the pid when debug logging an ioctl error.

2018-01-31 Thread Daniel Vetter
On Tue, Jan 30, 2018 at 01:56:43PM -0800, Eric Anholt wrote: > When we debug print what ioctl we're calling into, we include the pid. > If you have multiple processes rendering simulataneously, the error > return also needs the pid so you can see which of the ioctl calls was > the one to fail. > >

RE: [PATCH] mm/swap: add function get_total_swap_pages to expose total_swap_pages

2018-01-31 Thread He, Roger
I think this patch isn't need at all. You can directly read total_swap_pages variable in TTM. Because the variable is not exported by EXPORT_SYMBOL_GPL. So direct using will result in: "WARNING: "total_swap_pages" [drivers/gpu/drm/ttm/ttm.ko] undefined!". Thanks Roger(Hongbo.He) -Or

Re: [PATCH libdrm] drm: fix return value

2018-01-31 Thread Daniel Vetter
On Wed, Jan 31, 2018 at 10:49:47AM +0800, Chunming Zhou wrote: > > > On 2018年01月17日 17:31, Daniel Vetter wrote: > > On Wed, Jan 17, 2018 at 05:26:41PM +0800, Chunming Zhou wrote: > > > > > > On 2018年01月17日 17:24, Christian König wrote: > > > > Am 17.01.2018 um 09:53 schrieb Chunming Zhou: > > >

Re: [PATCH] drm: rcar-du: Remove zpos field from rcar_du_vsp_plane_state structure

2018-01-31 Thread Daniel Vetter
On Wed, Jan 17, 2018 at 08:44:29PM +0200, Laurent Pinchart wrote: > Since commit 2fc4d838aaf2 ("drm: rcar: use generic code for managing > zpos plane property") the rcar-du driver stores the plane zpos in the > drm_plane_state structure. The commit however forgot to remove the zpos > field from the

Re: [PATCH] mm/swap: add function get_total_swap_pages to expose total_swap_pages

2018-01-31 Thread Christian König
Yeah, indeed. But what we could do is to rely on a fixed limit like the Intel driver does and I suggested before. E.g. don't copy anything into a shmemfile when there is only x MB of swap space left. Roger can you test that approach once more with your fix for the OOM issues in the page faul

Re: [PATCH] drm: Check for lessee in DROP_MASTER ioctl

2018-01-31 Thread Daniel Vetter
On Tue, Jan 30, 2018 at 11:55:01AM -0800, Keith Packard wrote: > Daniel Vetter writes: > > > On Thu, Jan 18, 2018 at 05:51:59PM -0800, Keith Packard wrote: > >> Don't let a lessee control what the current DRM master is set to; > >> that's the job of the "real" master. Otherwise, the lessee would

[PATCH v3 33/43] drm/panel: simple: Change mode for Sharp lq123p1jx31

2018-01-31 Thread Thierry Escande
From: Sean Paul Change the mode for Sharp lq123p1jx31 panel to something more rockchip-friendly such that we can use the fixed PLLs to generate the pixel clock Cc: Chris Zhong Cc: Stéphane Marchesin Signed-off-by: Sean Paul Signed-off-by: Thierry Escande --- drivers/gpu/drm/panel/panel-simp

Re: [PATCH v3] Fix loading of module radeonfb on PowerMac

2018-01-31 Thread Mathieu Malaterre
Bartlomiej, On Wed, Jan 3, 2018 at 3:47 PM, Bartlomiej Zolnierkiewicz wrote: > > On Thursday, December 21, 2017 11:07:56 PM Mathieu Malaterre wrote: >> When the linux kernel is build with (typical kernel ship with Debian >> installer): >> >> CONFIG_FB_OF=y >> CONFIG_VT_HW_CONSOLE_BINDING=y >> CON

[PATCH v3 32/43] drm/bridge: analogix_dp: Properly disable aux chan retries on rockchip

2018-01-31 Thread Thierry Escande
From: Douglas Anderson The comments in analogix_dp_init_aux() claim that we're disabling aux channel retries, but then right below it for Rockchip it sets them to 3. If we actually need 3 retries for Rockchip then we could adjust the comment, but it seems more likely that we want the same retry

[PATCH v3 14/43] drm/bridge: analogix_dp: Check AUX_EN status when doing AUX transfer

2018-01-31 Thread Thierry Escande
From: Lin Huang We should check AUX_EN bit to confirm the AUX CH operation is completed. Cc: Stéphane Marchesin Signed-off-by: Lin Huang Signed-off-by: zain wang Signed-off-by: Sean Paul Signed-off-by: Thierry Escande --- drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c | 25 +

[PATCH v2] drm/edid: use true and false for boolean values

2018-01-31 Thread Gustavo A. R. Silva
Assign true or false to boolean variables instead of an integer value. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- Changes in v2: - Use true for boolean value in add_detailed_mode as suggested by Daniel Vetter. - Update subject. drivers/gpu/

Re: [PATCH] drm/arcpgu: remove drm_encoder_slave

2018-01-31 Thread Alexey Brodkin
Hi Daniel, On Tue, 2018-01-30 at 10:15 +0100, Daniel Vetter wrote: > On Wed, Jan 17, 2018 at 03:17:55PM +0100, Daniel Vetter wrote: > > drm_encoder_slave is the old way to write bridge drivers, for i2c > > bridges only. It's deprecated, and definitely should not be used in > > new drivers. This ha

Re: [PATCH] drm/arcpgu: remove drm_encoder_slave

2018-01-31 Thread Alexey Brodkin
Hi Daniel, On Tue, 2018-01-30 at 18:07 +0100, Daniel Vetter wrote: > On Tue, Jan 30, 2018 at 5:44 PM, Alexey Brodkin > wrote: > > Hi Daniel, > > > > On Tue, 2018-01-30 at 10:15 +0100, Daniel Vetter wrote: > > > On Wed, Jan 17, 2018 at 03:17:55PM +0100, Daniel Vetter wrote: > > > > drm_encoder_sl

[PATCH v3 06/43] drm/rockchip: Don't use atomic constructs for psr

2018-01-31 Thread Thierry Escande
From: Sean Paul Instead of using timer and spinlocks, use delayed_work and mutexes for rockchip psr. This allows us to make blocking calls when enabling/disabling psr (which is sort of important given we're talking over dpcd to the display). Cc: Caesar Wang Cc: 征增 王 Cc: Stéphane Marchesin Sig

[PATCH v3 02/43] drm/rockchip: support prime import sg table

2018-01-31 Thread Thierry Escande
From: Haixia Shi The prime fd to handle ioctl was not used with rockchip before. Support was added in order to pass graphics_Gbm and to support potential uses within Chrome OS (e.g. zero-copy video decode, camera). Signed-off-by: Haixia Shi Signed-off-by: Sean Paul Signed-off-by: Thierry Escan

[PATCH v3 04/43] drm/bridge: analogix_dp: set psr activate/deactivate when enable/disable bridge

2018-01-31 Thread Thierry Escande
From: zain wang There's a race between when bridge_disable and when vop_crtc_disable are called. If the flush timer triggers a new psr work between these, we will operate eDP without power shutdowned by bridge_disable. In this case, moving activate/deactivate to enable/disable bridge to avoid it.

[PATCH 02/10] video: fbdev: kconfig: Remove empty help text

2018-01-31 Thread Ulf Magnusson
In preparation for adding a warning ("kconfig: Warn if help text is blank"): https://lkml.org/lkml/2018/1/30/516 Signed-off-by: Ulf Magnusson --- drivers/video/fbdev/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig index 6962b45

[PATCH v3 16/43] drm/bridge: analogix_dp: Retry bridge enable when it failed

2018-01-31 Thread Thierry Escande
From: zain wang When we enable bridge failed, we have to retry it, otherwise we would get the abnormal display. Cc: Stéphane Marchesin Signed-off-by: zain wang Signed-off-by: Sean Paul Signed-off-by: Thierry Escande Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/bridge/analogix/analogix_dp

[PATCH v3 10/43] drm/rockchip: add mutex vop lock

2018-01-31 Thread Thierry Escande
From: zain wang Add a lock to vop to avoid disabling the crtc while waiting for a line flag while enabling psr. If we disable in the middle of waiting for the line flag, we'll end up timing out or worse. Signed-off-by: zain wang Signed-off-by: Sean Paul Signed-off-by: Thierry Escande --- dri

[PATCH v3 37/43] drm/rockchip: Disable PSR on input events

2018-01-31 Thread Thierry Escande
From: "Kristian H. Kristensen" To improve PSR exit latency, we speculatively start exiting when we receive input events. Occasionally, this may lead to false positives, but most of the time we get a head start on coming out of PSR. Depending on how userspace takes to produce a new frame in respon

[PATCH v3 20/43] drm/bridge: analogix_dp: Extend hpd check time to 100ms

2018-01-31 Thread Thierry Escande
From: Lin Huang There was a 1ms delay to detect the hpd signal, which is too short to detect a short pulse. This patch extends this delay to 100ms. Cc: Stéphane Marchesin Cc: 征增 王 Signed-off-by: Lin Huang Signed-off-by: Sean Paul Signed-off-by: Thierry Escande Reviewed-by: Andrzej Hajda --

[PATCH v3 09/43] drm/bridge: analogix_dp: Don't change psr while bridge is disabled

2018-01-31 Thread Thierry Escande
From: zain wang There is a race between AUX CH bring-up and enabling bridge which will cause link training to fail. To avoid hitting it, don't change psr state while enabling the bridge. Cc: Tomeu Vizoso Cc: Sean Paul Signed-off-by: zain wang Signed-off-by: Caesar Wang [seanpaul fixed up the

[PATCH v3 26/43] drm/bridge: analogix_dp: Don't use ANALOGIX_DP_PLL_CTL to control pll

2018-01-31 Thread Thierry Escande
From: zain wang There is no register named ANALOGIX_DP_PLL_CTL in Rockchip edp phy reg list. We should use BIT_4 in ANALOGIX_DP_PD to control the pll power instead of ANALOGIX_DP_PLL_CTL. Cc: Douglas Anderson Signed-off-by: zain wang Signed-off-by: Sean Paul Signed-off-by: Thierry Escande R

[PATCH v3 25/43] drm/rockchip: Restore psr->state when enable/disable psr failed

2018-01-31 Thread Thierry Escande
From: zain wang If we failed disable psr, it would hang the display until next psr cycle coming. So we should restore psr->state when it failed. Cc: Tomasz Figa Signed-off-by: zain wang Signed-off-by: Douglas Anderson Signed-off-by: Sean Paul Signed-off-by: Thierry Escande --- drivers/gpu/

[PATCH v3 43/43] drm/rockchip: psr: Remove flush by CRTC

2018-01-31 Thread Thierry Escande
From: Tomasz Figa It is not used anymore after last changes and it was not even correct to begin with as it assumed a 1:1 relation between a CRTC and encoder, while in fact a CRTC can be attached to multiple encoders. Signed-off-by: Tomasz Figa Signed-off-by: Thierry Escande --- drivers/gpu/d

[PATCH v3 41/43] drm/rockchip: Disable PSR from reboot notifier

2018-01-31 Thread Thierry Escande
From: Tomasz Figa It looks like the driver subsystem detaches devices from power domains at shutdown without consent of the drivers. This means that we might have our power domain turned off behind our back and the only way to avoid problems is to stop doing any hardware programming at some point

[PATCH v3 00/43] DRM Rockchip rk3399 (Kevin)

2018-01-31 Thread Thierry Escande
Hi, This patchset includes cleanups, improvements, and bug fixes for Rockchip DRM driver and PSR support. this patchset depends and needs to be applied on top of Rockchip rk3399 eDP support [1]. [1] https://lkml.org/lkml/2018/1/10/682 Regards, Thierry Changes in v3: - Addressed some of the com

[PATCH v3 42/43] drm/rockchip: Disallow PSR for the whole atomic commit

2018-01-31 Thread Thierry Escande
From: Tomasz Figa Currently PSR flush is triggered from CRTC's .atomic_begin() callback, which is executed after modeset disables and enables and before plane updates are committed. Since PSR flush and re-enable can be triggered asynchronously by external sources (input event, delayed work), it c

[PATCH v3 13/43] drm/bridge: analogix_dp: Move enable video into config_video()

2018-01-31 Thread Thierry Escande
From: Lin Huang We need to enable video before analogix_dp_is_video_stream_on(), so we can get the right video stream status. Cc: 征增 王 Cc: Stéphane Marchesin Signed-off-by: Lin Huang Signed-off-by: Sean Paul Signed-off-by: Thierry Escande Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/bri

[PATCH v3 39/43] drm/rockchip: psr: Avoid redundant calls to .set() callback

2018-01-31 Thread Thierry Escande
From: Tomasz Figa The first time after we call rockchip_drm_do_flush() after rockchip_drm_psr_register(), we go from PSR_DISABLE to PSR_FLUSH. The difference between PSR_DISABLE and PSR_FLUSH is whether or not we have a delayed work pending - PSR is off in either state. However psr_set_state() o

[PATCH v3 05/43] drm/bridge: analogix_dp: Don't power bridge in analogix_dp_bind

2018-01-31 Thread Thierry Escande
From: zain wang The bridge does not need to be powered in analogix_dp_bind(), so remove the calls to pm_runtime_get()/phy_power_on()/analogix_dp_init_dp() as well as their power-off counterparts. Cc: Stéphane Marchesin Signed-off-by: zain wang Signed-off-by: Caesar Wang [the patch originally

[PATCH v3 18/43] drm/bridge: analogix_dp: Set PD_INC_BG first when powering up edp phy

2018-01-31 Thread Thierry Escande
From: zain wang Following the correct power up sequence: dp_pd=ff => dp_pd=7f => wait 10us => dp_pd=00 Cc: Stéphane Marchesin Signed-off-by: zain wang Signed-off-by: Sean Paul Signed-off-by: Thierry Escande --- drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c | 10 -- drivers/gpu/d

[PATCH v3 31/43] drm/bridge: analogix_dp: Properly log AUX CH errors

2018-01-31 Thread Thierry Escande
From: Douglas Anderson The code in analogix_dp_transfer() that was supposed to print out: AUX CH error happened Was actually dead code. That's because the previous check (whether the interrupt status indicated any errors) would have hit for all errors anyway. Let's combine the two error check

[PATCH v3 08/43] drm/rockchip: Remove analogix psr worker

2018-01-31 Thread Thierry Escande
From: Sean Paul Now that the spinlocks and timers are gone, we can remove the psr worker located in rockchip's analogix driver and do the enable/disable directly. This should simplify the code and remove races on disable. Cc: 征增 王 Cc: Stéphane Marchesin Signed-off-by: Sean Paul Signed-off-by:

[PATCH v3 19/43] drm/bridge: analogix_dp: Ensure edp is disabled when shutting down the panel

2018-01-31 Thread Thierry Escande
From: Lin Huang When panel is shut down, we should make sure edp can be disabled to avoid undefined behavior. Cc: Stéphane Marchesin Signed-off-by: Lin Huang Signed-off-by: zain wang Signed-off-by: Sean Paul Signed-off-by: Thierry Escande Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/bri

[PATCH v3 23/43] drm/bridge: analogix_dp: Fix AUX_PD bit for Rockchip

2018-01-31 Thread Thierry Escande
From: zain wang There are some different bits between Rockchip and Exynos in register "AUX_PD". This patch fixes the incorrect operations about it. Cc: Douglas Anderson Signed-off-by: zain wang Signed-off-by: Sean Paul Signed-off-by: Thierry Escande Reviewed-by: Andrzej Hajda --- drivers/g

Re: [PATCH] drm/edid: use false for boolean value

2018-01-31 Thread Gustavo A. R. Silva
Hi Daniel, Quoting Daniel Vetter : On Tue, Jan 23, 2018 at 10:46:07AM -0600, Gustavo A. R. Silva wrote: Assign true or false to boolean variables instead of an integer value. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva Thanks for your patch. -

[PATCH v3 28/43] drm/bridge: analogix_dp: Fix incorrect operations with register ANALOGIX_DP_FUNC_EN_1

2018-01-31 Thread Thierry Escande
From: zain wang Register ANALOGIX_DP_FUNC_EN_1(offset 0x18), Rockchip is different to Exynos: on Exynos edp phy, BIT 7 MASTER_VID_FUNC_EN_N BIT 6 reserved BIT 5 SLAVE_VID_FUNC_EN_N on Rockchip edp phy, BIT 7 reserved BIT 6 RK_VID_CAP_FUNC_EN_N B

[PATCH v3 30/43] drm/bridge: analogix_dp: Reorder plat_data->power_off to happen sooner

2018-01-31 Thread Thierry Escande
From: Douglas Anderson The current user of the analogix power_off is "analogix_dp-rockchip". That driver does this: - deactivate PSR - turn off a clock Both of these things (especially deactive PSR) should be done before we turn the PHY power off and turn off analog power. Let's move the callba

[PATCH v3 22/43] drm/bridge: analogix_dp: Check dpcd write/read status

2018-01-31 Thread Thierry Escande
From: Lin Huang We need to check the dpcd write/read return value to see whether the write/read was successful Cc: Kristian H. Kristensen Signed-off-by: Lin Huang Signed-off-by: zain wang Signed-off-by: Douglas Anderson Signed-off-by: Sean Paul Signed-off-by: Thierry Escande Reviewed-by: A

[PATCH v2 02/10] video: fbdev: kconfig: Remove empty help text

2018-01-31 Thread Ulf Magnusson
In preparation for adding a warning ("kconfig: Warn if help text is blank"): https://lkml.org/lkml/2018/1/30/516 Signed-off-by: Ulf Magnusson --- drivers/video/fbdev/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig index 6962b45

[PATCH v3 15/43] drm/bridge: analogix_dp: Don't use fast link training when panel just powered up

2018-01-31 Thread Thierry Escande
From: zain wang Panel would reset its setting when it powers down. It would forget the last succeeded link training setting. So we can't use the last successful link training setting to do fast link training. Let's reset fast_train_enable in analogix_dp_bridge_disable(); Cc: Stéphane Marchesin

[PATCH v3 11/43] drm/bridge: analogix_dp: add fast link train for eDP

2018-01-31 Thread Thierry Escande
From: zain wang We would meet a short black screen when exit PSR with the full link training, In this case, we should use fast link train instead of full link training. Signed-off-by: zain wang Signed-off-by: Sean Paul Signed-off-by: Thierry Escande --- drivers/gpu/drm/bridge/analogix/analog

[PATCH v3 12/43] drm/rockchip: Only wait for panel ACK on PSR entry

2018-01-31 Thread Thierry Escande
From: zain wang We currently wait for the panel to mirror our intended PSR state before continuing on both PSR enter and PSR exit. This is really only important to do when we're entering PSR, since we want to be sure the last frame we pushed is being served from the panel's internal fb before shu

[PATCH v3 38/43] drm/rockchip: Cancel PSR enable work before changing the state

2018-01-31 Thread Thierry Escande
From: Tomasz Figa If we change the state first and reschedule later, we might have the work executed according to previous scheduled time and end up with PSR re-enabled instantly. Let's cancel the work before changing the state. While at it, consolidate psr_disable_handler() to just call rockchi

[PATCH v4] Fix loading of module radeonfb on PowerMac

2018-01-31 Thread Mathieu Malaterre
When the linux kernel is build with (typical kernel ship with Debian installer): CONFIG_FB_OF=y CONFIG_VT_HW_CONSOLE_BINDING=y CONFIG_FB_RADEON=m The offb driver takes precedence over module radeonfb. It is then impossible to load the module, error reported is: [ 96.551486] radeonfb :00:10

[PATCH v3 24/43] drm/bridge: analogix_dp: Reset aux channel if an error occurred

2018-01-31 Thread Thierry Escande
From: Lin Huang AUX errors are caused by many different reasons. We may not know what happened in aux channel on failure, so let's reset aux channel if some errors occurred. Cc: 征增 王 Cc: Douglas Anderson Signed-off-by: Lin Huang Signed-off-by: Sean Paul Signed-off-by: Thierry Escande Review

[PATCH v3 17/43] drm/bridge: analogix_dp: Wait for HPD signal before configuring link

2018-01-31 Thread Thierry Escande
From: zain wang According to DP spec v1.3 chap 3.5.1.2 Link Training, Link Policy Maker must first detect that the HPD signal is asserted high by the Downstream Device before establishing a link with it. Cc: Stéphane Marchesin Signed-off-by: zain wang Signed-off-by: Sean Paul Signed-off-by: T

[PATCH v3 21/43] drm/bridge: analogix_dp: Fix incorrect usage of enhanced mode

2018-01-31 Thread Thierry Escande
From: zain wang Enhanced mode is required by the eDP 1.2 specification, and not doing it early could result in a period of time where we have a link transmitting idle packets without it. Since there is no reason to disable it, we just enable it at the beginning of link training and then keep it o

[PATCH v3 07/43] drm/bridge: analogix_dp: detect Sink PSR state after configuring the PSR

2018-01-31 Thread Thierry Escande
From: Yakir Yang Make sure the request PSR state takes effect in analogix_dp_send_psr_spd() function, or print the sink PSR error state if we failed to apply the requested PSR setting. Cc: 征增 王 Cc: Stéphane Marchesin Signed-off-by: Yakir Yang [seanpaul changed timeout loop to a readx poll] Si

[PATCH v3 36/43] drm/rockchip: analogix_dp: Do not call Analogix code before bind

2018-01-31 Thread Thierry Escande
From: Tomasz Figa Driver callbacks, such as system suspend or resume can be called any time, specifically they can be called before the component bind callback. Let's use dp->adp pointer as a safeguard and skip calling Analogix entry points if it is an ERR_PTR(). Signed-off-by: Tomasz Figa Sign

[PATCH v3 03/43] drm/rockchip: Respect page offset for PRIME mmap calls

2018-01-31 Thread Thierry Escande
From: Ørjan Eide When mapping external DMA-bufs through the PRIME mmap call, we might be given an offset which has to be respected. However for the internal DRM GEM mmap path, we have to ignore the fake mmap offset used to identify the buffer only. Currently the code always zeroes out vma->vm_pgo

Re: [PATCH 2/5] drm: add ARM flush implementation

2018-01-31 Thread Russell King - ARM Linux
On Tue, Jan 30, 2018 at 11:14:36AM +0100, Daniel Vetter wrote: > On Tue, Jan 23, 2018 at 06:56:03PM -0800, Gurchetan Singh wrote: > > The dma_cache_maint_page function is important for cache maintenance on > > ARM32 (this was determined via testing). > > > > Since we desire direct control of the c

[PATCH v3 29/43] drm/bridge: analogix_dp: Move fast link training detect to set_bridge

2018-01-31 Thread Thierry Escande
From: zain wang It's too early to detect fast link training, if other step after it failed, we will set fast_link flag to 1, and retry set_bridge again. In this case we will power down and power up panel power supply, and we will do fast link training since we have set fast_link flag to 1. In fac

[PATCH v3 01/43] drm/rockchip: Get rid of unnecessary struct fields

2018-01-31 Thread Thierry Escande
From: Tomasz Figa This patch removes unused fields from vop structure. Signed-off-by: Tomasz Figa Signed-off-by: Sean Paul Signed-off-by: Thierry Escande --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_

[PATCH v3 27/43] drm/bridge: analogix_dp: Fix timeout of video streamclk config

2018-01-31 Thread Thierry Escande
From: zain wang The STRM_VALID bit in register ANALOGIX_DP_SYS_CTL_3 may be unstable, so we may hit the error log "Timeout of video streamclk ok" since checked this unstable bit. In fact, we can go continue and the streamclk is ok if we wait enough time, it does no effect on display. Let's change

[PATCH v3 40/43] drm/rockchip: psr: Sanitize semantics of allow/disallow API

2018-01-31 Thread Thierry Escande
From: Tomasz Figa Currently both rockchip_drm_psr_activate() and _deactivate() only set the boolean "active" flag without actually making sure that hardware state complies with it. Since we are going to extend the usage of this API to properly lock PSR for the duration of atomic commits, we chan

[PATCH v3 34/43] drm/rockchip: pre dither down when output bpc is 8bit

2018-01-31 Thread Thierry Escande
From: Mark Yao Some encoder have a crc verification check, crc check fail if input and output data is not equal. That means encoder input and output need use same color depth, vop can output 10bit data to encoder, but some panel only support 8bit depth, that would make crc check die. So pre dit

[PATCH v3 35/43] drm/bridge: analogix_dp: Split the platform-specific poweron in two parts

2018-01-31 Thread Thierry Escande
From: Douglas Anderson Some of the platform-specific stuff in rockchip_dp_poweron() needs to happen before the generic code. Some needs to happen after. Let's split the callback in two. Specifically we can't start doing PSR work until _after_ the whole controller is up, so don't set the enable

[Bug 104806] plasmashell and other KDE binaries start to segfault after updating Mesa to 18.0.0 (radeon)

2018-01-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104806 --- Comment #15 from Michel Dänzer --- (In reply to Matt Turner from comment #14) > That commit is not in any released version of libdrm. Please do a release > containing it. It'll be in the next release. I don't see the need to cut a release s

[Bug 104876] [CI] incompletes caused by temporary Jenkins configuration problem

2018-01-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104876 Bug ID: 104876 Summary: [CI] incompletes caused by temporary Jenkins configuration problem Product: DRI Version: XOrg git Hardware: Other OS: All

[Bug 104876] [CI] incompletes caused by temporary Jenkins configuration problem

2018-01-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104876 Marta Löfstedt changed: What|Removed |Added Whiteboard||ReadyForDev -- You are receiving this

[Bug 104876] [CI] incompletes caused by temporary Jenkins configuration problem

2018-01-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104876 Marta Löfstedt changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 104876] [CI] incompletes caused by temporary Jenkins configuration problem

2018-01-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104876 Marta Löfstedt changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this mail

Re: [PATCH] mm/swap: add function get_total_swap_pages to expose total_swap_pages

2018-01-31 Thread Chunming Zhou
Discussed with Roger just now, we can try "void si_swapinfo(struct sysinfo *val)" function to get the total swap space. Regards, David Zhou On 2018年01月31日 16:12, Christian König wrote: Yeah, indeed. But what we could do is to rely on a fixed limit like the Intel driver does and I suggested b

Re: [PATCH] dma-fence: add comment for WARN_ON in dma_fence_release()

2018-01-31 Thread Oded Gabbay
On Tue, Jan 30, 2018 at 12:33 PM, Daniel Vetter wrote: > On Mon, Jan 29, 2018 at 05:40:02PM +0200, Oded Gabbay wrote: >> In dma_fence_release() there is a WARN_ON which could be triggered by >> several cases of wrong dma-fence usage. This patch adds a comment to >> explain two use-cases to help dr

[Bug 104306] Mesa 17.3 breaks Firefox and other Xwayland apps on AMD HD7750

2018-01-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104306 Michel Dänzer changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Bug 104880] No sound via DP on R9 Fury (4.14 + DC patches)

2018-01-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104880 Bug ID: 104880 Summary: No sound via DP on R9 Fury (4.14 + DC patches) Product: DRI Version: DRI git Hardware: Other OS: All Status: NEW Severity: normal

[Bug 104880] No sound via DP on R9 Fury (4.14 + DC patches)

2018-01-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104880 Konstantin A. Lepikhov changed: What|Removed |Added Hardware|Other |x86-64 (AMD64)

[Bug 104880] No sound via DP on R9 Fury (4.14 + DC patches)

2018-01-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104880 --- Comment #1 from Konstantin A. Lepikhov --- Created attachment 137080 --> https://bugs.freedesktop.org/attachment.cgi?id=137080&action=edit dmesg w/ drm debug and dc_log=1 Added dmesg with enabled debugging from drm and dc_log=1 -- You a

Re: [PATCH] dma-fence: add comment for WARN_ON in dma_fence_release()

2018-01-31 Thread Daniel Vetter
On Wed, Jan 31, 2018 at 11:03:39AM +0200, Oded Gabbay wrote: > On Tue, Jan 30, 2018 at 12:33 PM, Daniel Vetter wrote: > > On Mon, Jan 29, 2018 at 05:40:02PM +0200, Oded Gabbay wrote: > >> In dma_fence_release() there is a WARN_ON which could be triggered by > >> several cases of wrong dma-fence us

[Bug 104082] amdgpu 0000:07:00.0: swiotlb buffer is full (sz: 2097152 bytes)

2018-01-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104082 --- Comment #11 from Przemek --- Similar with Radeon R4 APU - a6 6310 Kernel 4.15, mesa 17.3.3: "swiotlb_tbl_map_single: 10 callbacks suppressed [76882.115961] amdgpu :00:01.0: swiotlb buffer is full (sz: 2097152 bytes) [76882.115964] swiot

[PATCH] MAINTAINERS: Maarten for drm-misc co-maintainer

2018-01-31 Thread Daniel Vetter
I'm stepping down, also handing all the drm-misc stuff to the new team. Plan is that Sean handles 4.17, and Maarten then has fun with 4.18 as his first release. Cc: Maarten Lankhorst Cc: David Airlie Cc: Gustavo Padovan Cc: Sean Paul Acked-by: Sean Paul Acked-by: Maarten Lankhorst Signed-off

Re: [PATCH] dma-buf/dma-fence: Signal all callbacks from dma_fence_release()

2018-01-31 Thread Chris Wilson
Quoting Christian König (2017-08-13 14:04:29) > Am 11.08.2017 um 19:01 schrieb Chris Wilson: > > This is an illegal scenario, to free the fence whilst there are pending > > callbacks. Currently, we emit a WARN and then cast aside the callbacks > > leaving them dangling. Alternatively, we could set

Re: [PATCH 1/2] [WIP]drm/ttm: add waiter list to prevent allocation not in order

2018-01-31 Thread Chunming Zhou
On 2018年01月26日 22:35, Christian König wrote: I just realized that a change I'm thinking about for a while would solve your problem as well, but keep concurrent allocation possible. See ttm_mem_evict_first() unlocks the BO after evicting it:     ttm_bo_del_from_lru(bo);     spin_unloc

[Bug 198123] Console is the wrong color at boot with radeon 6670

2018-01-31 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=198123 --- Comment #26 from Daniel Vetter (dan...@ffwll.ch) --- Re #commment 24: crtc_commit is for modesets, the legacy helpers do _not_ call the DPMS functions in that case. radeon does what every reasonable legacy kms driver did and calls the dpms fun

[Bug 198123] Console is the wrong color at boot with radeon 6670

2018-01-31 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=198123 --- Comment #27 from Daniel Vetter (dan...@ffwll.ch) --- Ok I've reviewed all the drivers where Peter Rosin's patch series removed the load_lut hook: - ast: fixed with my patch - mga200g: already has a callchain like crtc_commit -> dpms -> load_lu

Re: [PATCH 1/2] [WIP]drm/ttm: add waiter list to prevent allocation not in order

2018-01-31 Thread Christian König
So I think preventing validation on same place is a simpler way: process B bo's place is fpfn~lpfn, it will only try to evict LRU BOs in that range, while eviction, we just prevent those validation to this range(fpfn~lpfn), if out of this range, the allocation/validation still can be go on. A

[Bug 100979] Radeon r4 on a6-6310(BEEMA) APU hard lockup on hibernate and on second resume from suspend

2018-01-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100979 --- Comment #9 from Przemek --- I have just upgraded kernel to 4.15. There is a big progress. Laptop can now successfully suspend (S3) and resume many times in a row. _Thank you very much for your hard work_. But unfortunately hibernate to di

Re: [PATCH] MAINTAINERS: Maarten for drm-misc co-maintainer

2018-01-31 Thread Gustavo Padovan
2018-01-31 Daniel Vetter : > I'm stepping down, also handing all the drm-misc stuff to the new > team. Plan is that Sean handles 4.17, and Maarten then has fun with > 4.18 as his first release. > > Cc: Maarten Lankhorst > Cc: David Airlie > Cc: Gustavo Padovan > Cc: Sean Paul > Acked-by: Sean

[PATCH] drm/cirrus: Load lut in crtc_commit

2018-01-31 Thread Daniel Vetter
In the past the ast driver relied upon the fbdev emulation helpers to call ->load_lut at boot-up. But since commit b8e2b0199cc377617dc238f5106352c06dcd3fa2 Author: Peter Rosin Date: Tue Jul 4 12:36:57 2017 +0200 drm/fb-helper: factor out pseudo-palette that's cleaned up and drivers are expect

Re: [PATCH 1/5] backlight: lp8788: document sysfs attributes

2018-01-31 Thread Daniel Thompson
On Fri, Jan 26, 2018 at 08:20:08PM +0530, Aishwarya Pant wrote: > Add documentation for sysfs interfaces of lp8788 backlight driver by > looking through the code and the git commit history. > > Signed-off-by: Aishwarya Pant > --- > Documentation/ABI/testing/sysfs-class-backlight-lp8788 | 10

[Bug 198123] Console is the wrong color at boot with radeon 6670

2018-01-31 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=198123 --- Comment #28 from Daniel Vetter (dan...@ffwll.ch) --- Created attachment 273941 --> https://bugzilla.kernel.org/attachment.cgi?id=273941&action=edit test patch for deposite pirate Should apply on any recent-ish kernel. Please apply, boot, an

Re: [Mesa-dev] [PATCH libdrm] meson: fix libdrm_nouveau pkgconfig include directories

2018-01-31 Thread Eric Engestrom
On Thursday, 2018-01-25 16:14:45 -0800, Dylan Baker wrote: > Signed-off-by: Dylan Baker Reviewed-by: Eric Engestrom > --- > > I have tested building every mesa driver against this (with and without udev!) > so I'm pretty sure that this is the last pkgbuild problem. > > I'm sure I'll be sad in

Re: [PATCH] MAINTAINERS: Maarten for drm-misc co-maintainer

2018-01-31 Thread Maarten Lankhorst
Op 31-01-18 om 12:02 schreef Gustavo Padovan: > 2018-01-31 Daniel Vetter : > >> I'm stepping down, also handing all the drm-misc stuff to the new >> team. Plan is that Sean handles 4.17, and Maarten then has fun with >> 4.18 as his first release. >> >> Cc: Maarten Lankhorst >> Cc: David Airlie >>

[Bug 104082] amdgpu 0000:07:00.0: swiotlb buffer is full (sz: 2097152 bytes)

2018-01-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104082 --- Comment #12 from Przemek --- I dont know if it is related, but: https://lkml.org/lkml/2018/1/16/106 -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing

Re: [PATCH] MAINTAINERS: Maarten for drm-misc co-maintainer

2018-01-31 Thread Jani Nikula
On Wed, 31 Jan 2018, Daniel Vetter wrote: > I'm stepping down, also handing all the drm-misc stuff to the new > team. Plan is that Sean handles 4.17, and Maarten then has fun with > 4.18 as his first release. > > Cc: Maarten Lankhorst > Cc: David Airlie > Cc: Gustavo Padovan > Cc: Sean Paul >

[Bug 100979] Radeon r4 on a6-6310(BEEMA) APU hard lockup on hibernate and on second resume from suspend

2018-01-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100979 --- Comment #10 from Przemek --- After some research I think that messages "swiotlb buffer is full" and "swiotlb: coherent allocation failed" are not related to this bug: https://lkml.org/lkml/2018/1/16/106 -- You are receiving this mail beca

Re: [PATCH 3/5] backlight: lm3639: document sysfs attributes

2018-01-31 Thread Daniel Thompson
On Fri, Jan 26, 2018 at 08:23:57PM +0530, Aishwarya Pant wrote: > Add documentation for sysfs interfaces of Texas Instruments lm3639 > backlight + flash led driver chip by looking through git commits and > reading code. > > Signed-off-by: Aishwarya Pant > --- > Documentation/ABI/testing/sysfs-cl

Re: [PATCH 1/5] backlight: lp8788: document sysfs attributes

2018-01-31 Thread Jani Nikula
On Wed, 31 Jan 2018, Daniel Thompson wrote: > On Fri, Jan 26, 2018 at 08:20:08PM +0530, Aishwarya Pant wrote: >> Add documentation for sysfs interfaces of lp8788 backlight driver by >> looking through the code and the git commit history. >> >> Signed-off-by: Aishwarya Pant >> --- >> Documentati

Re: [PATCH v3] Fix loading of module radeonfb on PowerMac

2018-01-31 Thread Bartlomiej Zolnierkiewicz
On Tuesday, January 30, 2018 02:14:10 PM Mathieu Malaterre wrote: > Bartlomiej, > > On Wed, Jan 3, 2018 at 3:47 PM, Bartlomiej Zolnierkiewicz > wrote: > > > > On Thursday, December 21, 2017 11:07:56 PM Mathieu Malaterre wrote: > >> When the linux kernel is build with (typical kernel ship with Deb

[Bug 100979] Radeon r4 on a6-6310(BEEMA) APU hard lockup on hibernate and on second resume from suspend

2018-01-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100979 --- Comment #11 from Przemek --- Created attachment 137085 --> https://bugs.freedesktop.org/attachment.cgi?id=137085&action=edit kernel log during hibernate Kernel log taken during hibernate process. Netbook was booted up with command line "i

Re: [PATCH v6 2/6] iommu/arm-smmu: Add pm_runtime/sleep ops

2018-01-31 Thread Robin Murphy
On 19/01/18 11:43, Vivek Gautam wrote: From: Sricharan R The smmu needs to be functional only when the respective master's using it are active. The device_link feature helps to track such functional dependencies, so that the iommu gets powered when the master device enables itself using pm_runt

Re: [PATCH] drm/cirrus: Load lut in crtc_commit

2018-01-31 Thread Gerd Hoffmann
On Wed, Jan 31, 2018 at 12:04:50PM +0100, Daniel Vetter wrote: > In the past the ast driver relied upon the fbdev emulation helpers to > call ->load_lut at boot-up. But since > > commit b8e2b0199cc377617dc238f5106352c06dcd3fa2 > Author: Peter Rosin > Date: Tue Jul 4 12:36:57 2017 +0200 > > drm

Re: [PATCH 7/9] dma-buf/dma-fence: Signal all callbacks from dma_fence_release()

2018-01-31 Thread Gustavo Padovan
Hi, 2017-08-11 Jason Ekstrand : > From: Chris Wilson > > This is an illegal scenario, to free the fence whilst there are pending > callbacks. Currently, we emit a WARN and then cast aside the callbacks > leaving them dangling. Alternatively, we could set an error on the fence > and then signal

Re: [PATCH v3 33/43] drm/panel: simple: Change mode for Sharp lq123p1jx31

2018-01-31 Thread Lucas Stach
Am Dienstag, den 30.01.2018, 21:29 +0100 schrieb Thierry Escande: > From: Sean Paul > > Change the mode for Sharp lq123p1jx31 panel to something more > rockchip-friendly such that we can use the fixed PLLs to > generate the pixel clock This should really switch to a display timing instead of exp

[Bug 104597] [bisected] Compton weird colors

2018-01-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104597 --- Comment #10 from Mario Kleiner --- Created attachment 137087 --> https://bugs.freedesktop.org/attachment.cgi?id=137087&action=edit Possible fix, tested against server 1.19 branch. This patch fixes the problem with compton, as tested again

Re: [PATCH v6 3/6] iommu/arm-smmu: Invoke pm_runtime during probe, add/remove device

2018-01-31 Thread Robin Murphy
On 19/01/18 11:43, Vivek Gautam wrote: From: Sricharan R The smmu device probe/remove and add/remove master device callbacks gets called when the smmu is not linked to its master, that is without the context of the master device. So calling runtime apis in those places separately. Signed-off-b

  1   2   >