Re: [PATCH] drm/arcpgu: remove drm_encoder_slave

2018-01-18 Thread Alexey Brodkin
Hi Daniel, On Wed, 2018-01-17 at 14:43 +0100, Daniel Vetter wrote: > drm_encoder_slave is the old way to write bridge drivers, for i2c > bridges only. It's deprecated, and definitely should not be used in > new drivers. > > What's even strange is that arcpgu doesn't even use any of this, it > rea

Re: [Intel-gfx] [PATCH] drm/atomic: Fix memleak on ERESTARTSYS during non-blocking commits

2018-01-18 Thread Maarten Lankhorst
Op 17-01-18 om 19:29 schreef Sean Paul: > On Wed, Jan 17, 2018 at 12:51:08PM +0100, Maarten Lankhorst wrote: >> From: "Leo (Sunpeng) Li" >> >> During a non-blocking commit, it is possible to return before the >> commit_tail work is queued (-ERESTARTSYS, for example). >> >> Since a reference on the

[PATCH] drm: rcar-du: Remove zpos field from rcar_du_vsp_plane_state structure

2018-01-18 Thread Laurent Pinchart
Since commit 2fc4d838aaf2 ("drm: rcar: use generic code for managing zpos plane property") the rcar-du driver stores the plane zpos in the drm_plane_state structure. The commit however forgot to remove the zpos field from the rcar_du_vsp_plane_state structure. Remove it. Fixes: 2fc4d838aaf2 ("drm:

[PATCH] drm: Fix trailing semicolon

2018-01-18 Thread Luis de Bethencourt
The trailing semicolon is an empty statement that does no operation. Removing it since it doesn't do anything. Signed-off-by: Luis de Bethencourt --- Hi, After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches suggested I fix it treewide [0]. Best regards Luis [0] http://dri

[Bug 102296] R9 285 VCE corruption since drm/amdgpu/gmc8: use the vram location programmed by the vbios

2018-01-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102296 Andy Furniss changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Intel-gfx] [PATCH] drm/atomic: Fix memleak on ERESTARTSYS during non-blocking commits

2018-01-18 Thread Sean Paul
On Wed, Jan 17, 2018 at 10:39 AM, Maarten Lankhorst wrote: > Op 17-01-18 om 19:29 schreef Sean Paul: >> On Wed, Jan 17, 2018 at 12:51:08PM +0100, Maarten Lankhorst wrote: >>> From: "Leo (Sunpeng) Li" >>> >>> During a non-blocking commit, it is possible to return before the >>> commit_tail work is

Re: [PATCH] [RESEND] drm/gma500: initialize gma_clock_t structures

2018-01-18 Thread Arnd Bergmann
On Wed, Jan 17, 2018 at 3:55 PM, Daniel Vetter wrote: > On Wed, Jan 17, 2018 at 3:36 PM, Arnd Bergmann wrote: >> On Wed, Jan 17, 2018 at 9:27 AM, Daniel Vetter wrote: >>> On Tue, Jan 16, 2018 at 03:57:10PM +0100, Arnd Bergmann wrote: The two functions pass a partially initialized structure

Re: [PATCH] drm/vc4: Fix NULL pointer dereference in vc4_save_hang_state()

2018-01-18 Thread Eric Anholt
Boris Brezillon writes: > When saving BOs in the hang state we skip one entry of the > kernel_state->bo[] array, thus leaving it to NULL. This leads to a NULL > pointer dereference when, later in this function, we iterate over all > BOs to check their ->madv state. > > Fixes: ca26d28bbaa3 ("drm/v

[RFC PATCH v3 12/13] tools/bootsplash: Add a basic splash file creation tool

2018-01-18 Thread Max Staudt
Signed-off-by: Max Staudt --- MAINTAINERS | 1 + tools/bootsplash/.gitignore | 1 + tools/bootsplash/Makefile| 9 + tools/bootsplash/bootsplash-packer.c | 471 +++ 4 files changed, 482 insertions(+) create mode 1

Re: [PATCH] [RESEND] drm/gma500: initialize gma_clock_t structures

2018-01-18 Thread Daniel Vetter
On Wed, Jan 17, 2018 at 8:44 PM, Arnd Bergmann wrote: > On Wed, Jan 17, 2018 at 3:55 PM, Daniel Vetter wrote: >> On Wed, Jan 17, 2018 at 3:36 PM, Arnd Bergmann wrote: >>> On Wed, Jan 17, 2018 at 9:27 AM, Daniel Vetter wrote: On Tue, Jan 16, 2018 at 03:57:10PM +0100, Arnd Bergmann wrote: >>

[RFC PATCH v3 09/13] fbcon: Disable bootsplash on oops

2018-01-18 Thread Max Staudt
Signed-off-by: Max Staudt Reviewed-by: Oliver Neukum --- drivers/video/fbdev/core/fbcon.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c index 9a39a6fcfe98..8a9c67e1c5d8 100644 --- a/drivers/video/fbdev/core/fbc

[RFC PATCH v3 07/13] vt: Add keyboard hook to disable bootsplash

2018-01-18 Thread Max Staudt
Let's disable the splash if the user presses ESC or F1-F12 on a VT. The F1-F12 check is to disable the splash on VT switches. Signed-off-by: Max Staudt --- drivers/tty/vt/keyboard.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/tty/vt/keyboard.c b/drivers

[RFC PATCH v3 06/13] vt: Redraw bootsplash fully on console_unblank

2018-01-18 Thread Max Staudt
After exiting a KD_GRAPHICS program and falling back to the text console, a previously enabled splash needs to be fully redrawn. This corner case was introduced with selective re-drawing while implementing animations. Without this patch, the following happens: 1. Switch to a text console 2. Enab

[RFC PATCH v3 08/13] sysrq: Disable bootsplash on SAK

2018-01-18 Thread Max Staudt
When the user requests a clean TTY via the SAK SysRq, that means he really wants to use the console. Let's disable the bootsplash, even if the request is not on a VT, as the user probably knows what he's doing and it's more helpful to get out of his way. Signed-off-by: Max Staudt Reviewed-by: Ol

[PATCH] drm/panel: panasonic-vvx10f034n00: More return value fixes

2018-01-18 Thread Sean Paul
A couple more return value fixes which Philippe brought up during our previous review. Suggested-by: Philippe CORNU Signed-off-by: Sean Paul --- drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/drivers/gp

[PATCH 10/12] drm: sti: Use drm_atomic_helper_shutdown() to disable planes on removal

2018-01-18 Thread Laurent Pinchart
The plane cleanup handlers currently call drm_plane_helper_disable(), which is a legacy helper function. Replace it with a call to drm_atomic_helper_shutdown() at removal time. The plane .destroy() handlers now consisting only of a call to drm_plane_cleanup(), replace them with direct calls to that

Re: [PATCH 3/4] drm: add ARM flush implementations

2018-01-18 Thread Daniel Vetter
On Wed, Jan 17, 2018 at 7:53 PM, Sean Paul wrote: > On Wed, Jan 17, 2018 at 09:31:05AM +0100, Daniel Vetter wrote: >> On Tue, Jan 16, 2018 at 04:35:58PM -0800, Gurchetan Singh wrote: >> > The DMA API can be used to flush scatter gather tables and physical >> > pages on ARM devices. >> > >> > Signe

[PATCH 00/12] Cargo cult cleanup in atomic drivers

2018-01-18 Thread Laurent Pinchart
Hello, This patch series removes a few cargo-cult constructs from a set of atomic drivers. Patches 01/12 and 02/12 remove the unneeded .mode_set() and .mode_set_base() CRTC handlers from the arc and atmel-hlcdc drivers. Patches 03/12 to 12/12 then remove the use of drm_plane_helper_disable() fro

Re: [PATCH 3/4] drm: add ARM flush implementations

2018-01-18 Thread Gurchetan Singh
> > dma api just isn't quite sufficient for implementing fast gpu drivers. Can you elaborate? IIRC the DMA API has strong synchronization guarantees and that can be problematic for GPU drivers. However, using the DMA API for flushing doesn't necessarily mean the driver has to use the rest of th

Re: [Freedreno] [PATCH 2/2] drm/msm/adreno: fix nvmem related link error

2018-01-18 Thread Jordan Crouse
On Mon, Jan 15, 2018 at 05:14:05PM +0100, Arnd Bergmann wrote: > When NVMEM is configured as a loadable module, and adreno > is built-in, we get a link failure: > > drivers/gpu/drm/msm/adreno/a5xx_gpu.o: In function `a5xx_gpu_init': > a5xx_gpu.c:(.text+0x15cc): undefined reference to `nvmem_cell_g

[RFC PATCH v3 01/13] bootsplash: Initial implementation showing black screen

2018-01-18 Thread Max Staudt
This is the initial prototype for a lean Linux kernel bootsplash. It works by replacing fbcon's FB manipulation routines (such as bitblit, tileblit) with dummy functions, effectively disabling text output, and drawing the splash directly onto the FB device. There is a userland API via sysfs, to s

[RFC PATCH v3 10/13] Documentation: Add bootsplash main documentation

2018-01-18 Thread Max Staudt
Signed-off-by: Max Staudt --- .../ABI/testing/sysfs-platform-bootsplash | 11 + Documentation/bootsplash.rst | 285 + MAINTAINERS| 2 + 3 files changed, 298 insertions(+) create mode 100644 Documentatio

[RFC PATCH v3 00/13] Kernel based bootsplash

2018-01-18 Thread Max Staudt
Dear fbdev/fbcon/dri developers, Thanks for all the valuable feedback. I've looked into the suggestions you made, and found that it doesn't currently make sense to continue working on the splash code, given the low practical interest I've received on LKML. The code is, and always has been, intend

[RFC PATCH v3 02/13] bootsplash: Add file reading and picture rendering

2018-01-18 Thread Max Staudt
Load logo(s) from a file and render them in the center of the screen. This removes the "black screen" functionality, which can now be emulated by providing a splash file with no pictures and a black background. To enable the bootsplash at boot, provide a theme file *in the initramfs* and tell the

[RFC PATCH v3 13/13] tools/bootsplash: Add script and data to create sample file

2018-01-18 Thread Max Staudt
Also, mention this in the bootsplash documentation. Signed-off-by: Max Staudt --- Documentation/bootsplash.rst | 10 ++ tools/bootsplash/.gitignore| 3 ++ tools/bootsplash/ajax-loader.gif | Bin 0 -> 3208 bytes tools/bootsplash/bootsplash-tux.sh | 66 +

[RFC PATCH v3 05/13] bootsplash: Add animation support

2018-01-18 Thread Max Staudt
Each 'picture' in the splash file can consist of multiple 'blobs'. If animation is enabled, these blobs become the frames of an animation, in the order in which they are stored in the file. Note: There is only one global timer, so all animations happen at the same frame rate. It doesn't rea

[PATCH] drm/ttm: Don't add swapped BOs to swap-LRU list

2018-01-18 Thread Felix Kuehling
A BO that's already swapped would be added back to the swap-LRU list for example if it validation failed under high memory pressure. This could later lead to swapping it out again and leaking previous swap storage. This commit adds a condition to prevent that from happening. Signed-off-by: Felix

[PATCH 05/12] drm: arm: hdlcd: Use drm_atomic_helper_shutdown() to disable planes on removal

2018-01-18 Thread Laurent Pinchart
The plane cleanup handler currently calls drm_plane_helper_disable(), which is a legacy helper function. Replace it with a call to drm_atomic_helper_shutdown() at removal time. The plane .destroy() handler now consisting only of a call to drm_plane_cleanup(), replace it with direct calls to that fu

Re: [PATCH] drm/vc4: Fix NULL pointer dereference in vc4_save_hang_state()

2018-01-18 Thread Boris Brezillon
On Wed, 17 Jan 2018 12:03:15 -0800 Eric Anholt wrote: > Boris Brezillon writes: > > > When saving BOs in the hang state we skip one entry of the > > kernel_state->bo[] array, thus leaving it to NULL. This leads to a NULL > > pointer dereference when, later in this function, we iterate over all

[Bug 198123] Console is the wrong color at boot with radeon 6670

2018-01-18 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=198123 --- Comment #20 from Bill Fraser (bill.fra...@gmail.com) --- Rebased on top of -rc8 also works for me. -- You are receiving this mail because: You are watching the assignee of the bug. ___ dri-devel ma

[PATCH 12/12] drm: zte: Use drm_atomic_helper_shutdown() to disable planes on removal

2018-01-18 Thread Laurent Pinchart
The plane cleanup handler currently calls drm_plane_helper_disable(), which is a legacy helper function. Replace it with a call to drm_atomic_helper_shutdown() at removal time. The plane .destroy() handler now consisting only of a call to drm_plane_cleanup(), replace it with direct calls to that fu

[RFC PATCH v3 11/13] bootsplash: sysfs entries to load and unload files

2018-01-18 Thread Max Staudt
Users can use this to replace their splash screen at runtime by writing a path and filename to /sys/devices/platform/bootsplash.0/load_file and making sure the splash is enabled. Notes: - The path has to be a path in /lib/firmware since request_firmware() is used to fetch the data. - When

[PATCH 01/12] drm: arc: Don't set CRTC .mode_set and .mode_set_base handlers

2018-01-18 Thread Laurent Pinchart
The .mode_set() and .mode_set_base() operation handlers are used by legacy non-atomic helpers only. There's no need to set them for atomic drivers. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/arc/arcpgu_crtc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/arc/arcpg

[PATCH 03/12] drm: arc: Use drm_atomic_helper_shutdown() to disable planes on removal

2018-01-18 Thread Laurent Pinchart
The plane cleanup handler currently calls drm_plane_helper_disable(), which is a legacy helper function. Replace it with a call to drm_atomic_helper_shutdown() at removal time. The plane .destroy() handler now consisting only of a call to drm_plane_cleanup(), replace it with direct calls to that fu

Re: [PATCH v3 1/8] drm/modes: Introduce drm_mode_match()

2018-01-18 Thread Sharma, Shashank
Regards Shashank On 1/17/2018 8:51 PM, Ville Syrjälä wrote: On Wed, Jan 17, 2018 at 02:11:55PM +0530, Sharma, Shashank wrote: On 1/12/2018 11:51 AM, Nautiyal, Ankit K wrote: From: Ville Syrjälä Make mode matching less confusing by allowing the caller to specify which parts of the modes sh

Re: [PATCH v16 01/10] video: backlight: Add helpers to enable and disable backlight

2018-01-18 Thread Daniel Vetter
On Wed, Jan 17, 2018 at 6:00 PM, Daniel Thompson wrote: > On 16/01/18 10:31, Meghana Madhyastha wrote: >> >> Add helper functions backlight_enable and backlight_disable to >> enable/disable a backlight device. These helper functions can >> then be used by different drm and tinydrm drivers to avoid

Re: [PATCH v3 09/13] drm/sun4i: backend: Wire in the frontend

2018-01-18 Thread Maxime Ripard
Hi, On Wed, Jan 17, 2018 at 09:46:13PM +0800, Chen-Yu Tsai wrote: > > + for_each_available_child_of_node(port, ep) { > > + remote = of_graph_get_remote_port_parent(ep); > > + if (!remote) > > + continue; > > + > > + /* does this

Re: [PATCH v3 08/13] drm/sun4i: Add a driver for the display frontend

2018-01-18 Thread Chen-Yu Tsai
On Thu, Jan 18, 2018 at 3:22 PM, Maxime Ripard wrote: > Hi, > > On Wed, Jan 17, 2018 at 09:43:31PM +0800, Chen-Yu Tsai wrote: >> > if (sun4i_drv_node_is_connector(node)) >> > return 0; >> > >> > - if (!sun4i_drv_node_is_frontend(node)) { >> > + /* >> > +

Re: [PATCH 2/2] drm/msm/adreno: fix nvmem related link error

2018-01-18 Thread Rob Clark
On Mon, Jan 15, 2018 at 11:14 AM, Arnd Bergmann wrote: > When NVMEM is configured as a loadable module, and adreno > is built-in, we get a link failure: > > drivers/gpu/drm/msm/adreno/a5xx_gpu.o: In function `a5xx_gpu_init': > a5xx_gpu.c:(.text+0x15cc): undefined reference to `nvmem_cell_get' > a5

[PATCH 11/12] drm: vc4: Use drm_atomic_helper_shutdown() to disable planes on removal

2018-01-18 Thread Laurent Pinchart
The plane cleanup handler currently calls drm_plane_helper_disable(), which is a legacy helper function. Replace it with a call to drm_atomic_helper_shutdown() at removal time. The plane .destroy() handler now consisting only of a call to drm_plane_cleanup(), replace it with direct calls to that fu

[PATCH 04/12] drm: arm: hdlcd: Don't destroy plane manually in hdlcd_setup_crtc()

2018-01-18 Thread Laurent Pinchart
The top-level error handler calls drm_mode_config_cleanup() which will destroy all planes. There's no need to destroy them manually in lower error handlers. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/arm/hdlcd_crtc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a

[RFC PATCH v3 04/13] bootsplash: Add corner positioning

2018-01-18 Thread Max Staudt
This allows showing multiple logos, each in its own position, relative to the eight screen corners. Signed-off-by: Max Staudt --- drivers/video/fbdev/core/bootsplash_render.c | 136 ++- include/uapi/linux/bootsplash_file.h | 45 - 2 files changed, 178 ins

Re: [PATCH 11/12] drm: vc4: Use drm_atomic_helper_shutdown() to disable planes on removal

2018-01-18 Thread Eric Anholt
Laurent Pinchart writes: > The plane cleanup handler currently calls drm_plane_helper_disable(), > which is a legacy helper function. Replace it with a call to > drm_atomic_helper_shutdown() at removal time. The plane .destroy() > handler now consisting only of a call to drm_plane_cleanup(), repl

[PATCH 06/12] drm: arm: malidp: Don't destroy planes manually in error handlers

2018-01-18 Thread Laurent Pinchart
The top-level error handler calls drm_mode_config_cleanup() which will destroy all planes. There's no need to destroy them manually in lower error handlers. As plane cleanup is now handled entirely by drm_mode_config_cleanup(), we must ensure that the plane .destroy() handler frees allocated memor

[PATCH 09/12] drm: sti: Cleanup KMS objects on removal

2018-01-18 Thread Laurent Pinchart
Call the drm_mode_config_cleanup() function on removal to ensure that all KMS objects are properly cleaned up and destroyed. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/sti/sti_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/sti/sti_drv.c b/drivers/gpu/drm/sti/s

[Bug 104611] [fiji, polaris10] BUG: unable to handle kernel NULL pointer dereference when waking up displays with amdgpu.dc=1

2018-01-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104611 --- Comment #5 from Roman Li --- So what was the repro rate for the issue? Can you try to reproduce on the latest rawhide 4.15.0-0.rc8.git0.1.fc28.x86_64 and/or collect dmesg with amdgpu.dc_log=1 for the bad case? Thank you. -- You are receiv

Re: [PATCH] drm/vc4: Fix NULL pointer dereference in vc4_save_hang_state()

2018-01-18 Thread Daniel Vetter
On Wed, Jan 17, 2018 at 12:03:15PM -0800, Eric Anholt wrote: > Boris Brezillon writes: > > > When saving BOs in the hang state we skip one entry of the > > kernel_state->bo[] array, thus leaving it to NULL. This leads to a NULL > > pointer dereference when, later in this function, we iterate over

[PATCH 07/12] drm: arm: malidp: Use drm_atomic_helper_shutdown() to disable planes on removal

2018-01-18 Thread Laurent Pinchart
The plane cleanup handler currently calls drm_plane_helper_disable(), which is a legacy helper function. Replace it with a call to drm_atomic_helper_shutdown() at removal time. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/arm/malidp_drv.c| 1 + drivers/gpu/drm/arm/malidp_planes.c | 4

Re: [PATCH 1/1] drm: add kernel doc for exported gem dmabuf_ops

2018-01-18 Thread Daniel Vetter
On Wed, Jan 17, 2018 at 11:47:40AM -0500, Samuel Li wrote: > Signed-off-by: Samuel Li Thanks a lot for updating the docs. > --- > drivers/gpu/drm/drm_prime.c | 81 > + > 1 file changed, 81 insertions(+) > > diff --git a/drivers/gpu/drm/drm_prime.c b

Re: [PATCH] drm: Remove bridge support from legacy helpers

2018-01-18 Thread Daniel Vetter
On Wed, Jan 17, 2018 at 12:40:23PM -0500, Sean Paul wrote: > On Wed, Jan 17, 2018 at 07:27:03PM +0200, Laurent Pinchart wrote: > > DRM bridges are only used by atomic drivers, and none of them use the > > legacy helpers. Drop bridge support from those helpers to prepare for > > making the bridge op

Re: [PATCH v16 01/10] video: backlight: Add helpers to enable and disable backlight

2018-01-18 Thread Noralf Trønnes
Den 17.01.2018 18.00, skrev Daniel Thompson: On 16/01/18 10:31, Meghana Madhyastha wrote: Add helper functions backlight_enable and backlight_disable to enable/disable a backlight device. These helper functions can then be used by different drm and tinydrm drivers to avoid repetition of code

RE: [PATCH] drm/vmwgfx: fix memory corruption with legacy/sou connectors

2018-01-18 Thread Deepak Singh Rawat
Thanks Rob for finding this one. Reviewed-by: Deepak Rawat > From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf > Of Rob Clark > Sent: Wednesday, January 17, 2018 7:16 AM > To: dri-devel@lists.freedesktop.org > Cc: Thomas Hellstrom ; Rob Clark > ; David Airlie ; linux- >

[RFC v2 0/2] dt-bindings: mipi-dsi: dual-channel DSI bindings

2018-01-18 Thread Archit Taneja
DSI host controllers these days can be ganged together to drive larger displays. Every SoC vendor supporting this is trying to add their own DT property so that the corresponding drivers can identify that they need to operate in the dual DSI mode. If we use the graph bindings, we don't really need

Re: [PATCH] drm/vc4: Flush the caches before the bin jobs, as well.

2018-01-18 Thread Eric Anholt
Eric Anholt writes: > If the frame samples from a render target that was just written, its > cache flush during the binning step may have occurred before the > previous frame's RCL was completed. Flush the texture caches again > before starting each RCL job to make sure that the sampling of the >

Re: [PATCH 4/4] drm/vgem: flush page during page fault

2018-01-18 Thread Gurchetan Singh
On Wed, Jan 17, 2018 at 12:39 AM, Daniel Vetter wrote: > On Tue, Jan 16, 2018 at 04:35:59PM -0800, Gurchetan Singh wrote: > > This is required to use buffers allocated by vgem on AMD and ARM devices. > > We're experiencing a case where eviction of the cache races with > userspace > > writes. To f

Re: [PATCH v3 08/13] drm/sun4i: Add a driver for the display frontend

2018-01-18 Thread Maxime Ripard
Hi, On Wed, Jan 17, 2018 at 09:43:31PM +0800, Chen-Yu Tsai wrote: > > if (sun4i_drv_node_is_connector(node)) > > return 0; > > > > - if (!sun4i_drv_node_is_frontend(node)) { > > + /* > > +* If the device is either just a regular device, or an > > +

[RFC v2 2/2] dt-bindings: mipi-dsi: Add dual-channel DSI related info

2018-01-18 Thread Archit Taneja
Add binding info for peripherals that support dual-channel DSI. Add corresponding optional bindings for DSI host controllers that may be configured in this mode. Add an example of an I2C controlled device operating in dual-channel DSI mode. Signed-off-by: Archit Taneja --- v2: - Specify that cloc

[RFC v2 1/2] dt-bindings: mipi-dsi: Add info about peripherals with non-DSI control bus

2018-01-18 Thread Archit Taneja
Add a section that describes dt-bindings for peripherals that support MIPI DSI, but have a different bus as the primary control bus, or no control bus at all. Add an example for a peripheral with a non-DSI control bus. Signed-off-by: Archit Taneja --- v2: - Mentioned what to do if peripheral has

Re: [PATCH 3/4] drm: add ARM flush implementations

2018-01-18 Thread Sean Paul
On Wed, Jan 17, 2018 at 09:31:05AM +0100, Daniel Vetter wrote: > On Tue, Jan 16, 2018 at 04:35:58PM -0800, Gurchetan Singh wrote: > > The DMA API can be used to flush scatter gather tables and physical > > pages on ARM devices. > > > > Signed-off-by: Gurchetan Singh > > --- > > drivers/gpu/drm/d

Re: [PATCH 3/6] backlight/pandora: Stop using BL_CORE_DRIVER1

2018-01-18 Thread Daniel Vetter
Thanks a lot for your comments. On Wed, Jan 17, 2018 at 04:47:41PM +, Daniel Thompson wrote: > On 17/01/18 14:01, Daniel Vetter wrote: > > Leaking driver internal tracking into the already massively confusing > > backlight power tracking is really confusing. > > > > Stop that by allocating a

Re: [PATCH 2/6] backlight/generic-bl: remove DRIVER1 state

2018-01-18 Thread Daniel Thompson
On 17/01/18 17:13, Daniel Vetter wrote: On Wed, Jan 17, 2018 at 04:44:00PM +, Daniel Thompson wrote: On 17/01/18 14:01, Daniel Vetter wrote: Nothing in the entire tree ever sets this, which means this is dead code. Remove it. Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han Signed-off

[PATCH 02/12] drm: atmel-hlcdc: Don't set CRTC .mode_set and .mode_set_base handlers

2018-01-18 Thread Laurent Pinchart
The .mode_set() and .mode_set_base() operation handlers are used by legacy non-atomic helpers only. There's no need to set them for atomic drivers. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/

Re: [PATCH 02/12] drm: atmel-hlcdc: Don't set CRTC .mode_set and .mode_set_base handlers

2018-01-18 Thread Boris Brezillon
On Wed, 17 Jan 2018 23:55:25 +0200 Laurent Pinchart wrote: > The .mode_set() and .mode_set_base() operation handlers are used by > legacy non-atomic helpers only. There's no need to set them for atomic > drivers. > > Signed-off-by: Laurent Pinchart Acked-by: Boris Brezillon > --- > drivers/

Re: [PATCH 3/4] drm: add ARM flush implementations

2018-01-18 Thread Daniel Vetter
On Wed, Jan 17, 2018 at 11:46 PM, Gurchetan Singh wrote: >> dma api just isn't quite sufficient for implementing fast gpu drivers. > > > Can you elaborate? IIRC the DMA API has strong synchronization guarantees > and that can be problematic for GPU drivers. However, using the DMA API for > flush

Re: [PATCH v3 3/8] drm/edid: Fix cea mode aspect ratio handling

2018-01-18 Thread Sharma, Shashank
Regards Shashank On 1/17/2018 8:59 PM, Ville Syrjälä wrote: On Wed, Jan 17, 2018 at 02:35:40PM +0530, Sharma, Shashank wrote: Regards Shashank On 1/12/2018 11:51 AM, Nautiyal, Ankit K wrote: From: Ville Syrjälä commit 6dffd431e229 ("drm: Add aspect ratio parsing in DRM layer") cause us

[Bug 104611] [fiji, polaris10] BUG: unable to handle kernel NULL pointer dereference when waking up displays with amdgpu.dc=1

2018-01-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104611 --- Comment #6 from Vedran Miletić --- (In reply to Roman Li from comment #5) > So what was the repro rate for the issue? > Can you try to reproduce on the latest rawhide > 4.15.0-0.rc8.git0.1.fc28.x86_64 and/or collect dmesg with amdgpu.dc_log

Re: [PATCH 3/6] backlight/pandora: Stop using BL_CORE_DRIVER1

2018-01-18 Thread Daniel Thompson
On 17/01/18 21:38, Daniel Vetter wrote: Thanks a lot for your comments. On Wed, Jan 17, 2018 at 04:47:41PM +, Daniel Thompson wrote: On 17/01/18 14:01, Daniel Vetter wrote: Leaking driver internal tracking into the already massively confusing backlight power tracking is really confusing.

[RFC PATCH v3 03/13] bootsplash: Flush framebuffer after drawing

2018-01-18 Thread Max Staudt
Framebuffers with deferred I/O need to be flushed to the screen explicitly, since we use neither the mmap nor the file I/O abstractions that handle this for userspace FB clients. Example: xenfb Some framebuffer drivers implement lazy access to the screen without actually exposing a fbdefio interf

Re: [PATCH 1/6] backlight: Nuke unused backlight.props.state states

2018-01-18 Thread Lee Jones
On Wed, 17 Jan 2018, Daniel Thompson wrote: > On 17/01/18 14:01, Daniel Vetter wrote: > > The backlight power state handling is supremely confusing. We have: > > - props.power, using FB_BLANK_* defines > > - props.fb_blank, using the same, but deprecated int favour of > >props.state > > - prop

Re: [PATCH] drm/ttm: Don't add swapped BOs to swap-LRU list

2018-01-18 Thread Christian König
Am 18.01.2018 um 06:16 schrieb Felix Kuehling: A BO that's already swapped would be added back to the swap-LRU list for example if it validation failed under high memory pressure. This could later lead to swapping it out again and leaking previous swap storage. This commit adds a condition to pr

Re: [PATCH 4/4] drm/vgem: flush page during page fault

2018-01-18 Thread Daniel Vetter
On Wed, Jan 17, 2018 at 11:49 PM, Gurchetan Singh wrote: > > On Wed, Jan 17, 2018 at 12:39 AM, Daniel Vetter wrote: >> >> On Tue, Jan 16, 2018 at 04:35:59PM -0800, Gurchetan Singh wrote: >> > This is required to use buffers allocated by vgem on AMD and ARM >> > devices. >> > We're experiencing a

[PULL] drm-intel-fixes

2018-01-18 Thread Jani Nikula
Hi Dave - Display corruption regression bugfix with both a prep patch and a follow-up fix. Up to you to pick this up, or punt until next merge window. BR, Jani. The following changes since commit a8750ddca918032d6349adbf9a4b6555e7db20da: Linux 4.15-rc8 (2018-01-14 15:32:30 -0800) are avai

[PATCH 08/12] drm: msm: Use drm_atomic_helper_shutdown() to disable planes on removal

2018-01-18 Thread Laurent Pinchart
The plane cleanup handler currently calls drm_plane_helper_disable(), which is a legacy helper function. Replace it with a call to drm_atomic_helper_shutdown() at removal time. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/msm/mdp/mdp4/mdp4_plane.c | 1 - drivers/gpu/drm/msm/mdp/mdp5/mdp5_

Re: [PATCH 2/2] drm/msm/adreno: fix nvmem related link error

2018-01-18 Thread Lucas Stach
Am Mittwoch, den 17.01.2018, 16:52 -0500 schrieb Rob Clark: > On Mon, Jan 15, 2018 at 11:14 AM, Arnd Bergmann > wrote: > > When NVMEM is configured as a loadable module, and adreno > > is built-in, we get a link failure: > > > > drivers/gpu/drm/msm/adreno/a5xx_gpu.o: In function `a5xx_gpu_init':

Re: [PATCH v3 4/8] drm: Add DRM client cap for aspect-ratio

2018-01-18 Thread Maarten Lankhorst
Op 12-01-18 om 07:21 schreef Nautiyal, Ankit K: > From: Ankit Nautiyal > > A new drm client cap is required to enable user-space to advertise > if it supports modes with aspect-ratio. Based on this cap value, the > kernel will take a call on exposing the aspect ratio information in > modes or not.

Re: [PATCH] drm/panel: panasonic-vvx10f034n00: More return value fixes

2018-01-18 Thread Philippe CORNU
Hi Sean, Reviewed-by: Philippe Cornu (do you mean you write patches during meetings :o ... I never did that and I will not ;-) Philippe :-) On 01/17/2018 10:37 PM, Sean Paul wrote: > A couple more return value fixes which Philippe brought up during our > previous review. > > Suggested-by: Ph

Re: [PATCH v3 01/12] clk: sunxi-ng: Mask nkmp factors when setting register

2018-01-18 Thread Maxime Ripard
On Wed, Jan 17, 2018 at 09:14:10PM +0100, Jernej Skrabec wrote: > Currently, if one of the factors isn't present, bit 0 gets always set to > 1. For example, A83T has NMP PLLs modelled as NKMP PLL without K. Since > K is not specified, it's offset, width and shift is 0. Driver assumes > that lowest

Re: [PATCH v16 01/10] video: backlight: Add helpers to enable and disable backlight

2018-01-18 Thread Meghana Madhyastha
On Wed, Jan 17, 2018 at 11:03:24PM +0100, Noralf Trønnes wrote: > > Den 17.01.2018 18.00, skrev Daniel Thompson: > > > > > >On 16/01/18 10:31, Meghana Madhyastha wrote: > >>Add helper functions backlight_enable and backlight_disable to > >>enable/disable a backlight device. These helper functions

Re: [PATCH v3 02/12] clk: sunxi-ng: Change formula for NKMP PLLs

2018-01-18 Thread Maxime Ripard
Hi, On Wed, Jan 17, 2018 at 09:14:11PM +0100, Jernej Skrabec wrote: > This commit changes formula from this: > > Freq = (parent_freq * N * K) / (M * P) > > to this: > > Freq = (parent_freq / M) * N * K / P > > This improves situation when N is in the range 1-255. PLL parent clock > is almost a

Re: [PATCH v16 05/10] video: backlight: Add devres versions of of_find_backlight

2018-01-18 Thread Meghana Madhyastha
On Wed, Jan 17, 2018 at 05:09:57PM +, Daniel Thompson wrote: > On 16/01/18 10:34, Meghana Madhyastha wrote: > >Add devm_of_find_backlight and the corresponding release > >function because some drivers use devres versions of functions > >for acquiring device resources. > > > >Signed-off-by: Megh

Re: [PATCH] drm/bridge/synopsys: dsi: use common mipi_dsi_create_packet()

2018-01-18 Thread Philippe CORNU
Hi Brian, On 01/11/2018 12:16 PM, Philippe CORNU wrote: > Hi Brian, > > On 01/09/2018 07:55 PM, Brian Norris wrote: >> Hi Philippe, >> >> On Tue, Jan 09, 2018 at 10:48:43AM +, Philippe CORNU wrote: >>> Hi Brian, >>> >>> And many thanks for implementing these TODOs. >> >> And thanks for adding

Re: [PATCH v16 05/10] video: backlight: Add devres versions of of_find_backlight

2018-01-18 Thread Daniel Thompson
On Thu, Jan 18, 2018 at 04:32:26PM +0530, Meghana Madhyastha wrote: > On Wed, Jan 17, 2018 at 05:09:57PM +, Daniel Thompson wrote: > > On 16/01/18 10:34, Meghana Madhyastha wrote: > > >Add devm_of_find_backlight and the corresponding release > > >function because some drivers use devres version

Re: [PATCH v16 01/10] video: backlight: Add helpers to enable and disable backlight

2018-01-18 Thread Daniel Thompson
On Thu, Jan 18, 2018 at 04:29:23PM +0530, Meghana Madhyastha wrote: > On Wed, Jan 17, 2018 at 11:03:24PM +0100, Noralf Trønnes wrote: > > > > Den 17.01.2018 18.00, skrev Daniel Thompson: > > > > > > > > >On 16/01/18 10:31, Meghana Madhyastha wrote: > > >>Add helper functions backlight_enable and b

Re: [PATCH v16 09/10] drm/panel: Use of_find_backlight helper

2018-01-18 Thread Meghana Madhyastha
On Tue, Jan 16, 2018 at 06:08:53PM +0100, Noralf Trønnes wrote: > > Den 16.01.2018 11.36, skrev Meghana Madhyastha: > >Replace of_find_backlight_by_node and of the code around it > >with of_find_backlight helper to avoid repetition of code. > > > >Signed-off-by: Meghana Madhyastha > >--- > > dri

Re: [PATCH v3 05/12] drm/bridge/synopsys: dw-hdmi: don't clobber drvdata

2018-01-18 Thread Neil Armstrong
On 17/01/2018 21:14, Jernej Skrabec wrote: > dw_hdmi shouldn't set drvdata since some drivers might need to store > it's own data there. Rework dw_hdmi in a way to return struct dw_hdmi > instead to store it in drvdata. This way drivers are responsible to > store and pass structure when needed. >

Re: [PATCH v3 04/12] drm/bridge/synopsys: dw-hdmi: Export some PHY related functions

2018-01-18 Thread Neil Armstrong
On 17/01/2018 21:14, Jernej Skrabec wrote: > Parts of PHY code could be useful also for custom PHYs. For example, > Allwinner A83T has custom PHY which is probably Synopsys gen2 PHY > with few additional memory mapped registers, so most of the Synopsys PHY > related code could be reused. > > Funct

Re: [PATCH 2/6] backlight/generic-bl: remove DRIVER1 state

2018-01-18 Thread Emil Velikov
On 17 January 2018 at 16:37, Daniel Thompson wrote: > > > On 17/01/18 14:36, Emil Velikov wrote: >> >> On 17 January 2018 at 14:01, Daniel Vetter wrote: >>> >>> Nothing in the entire tree ever sets this, which means this is dead >>> code. Remove it. >>> >>> Cc: Lee Jones >>> Cc: Daniel Thompson

Re: [PATCH v2] drm/bridge/synopsys: dsi: add optional pixel clock

2018-01-18 Thread Philippe CORNU
Hi Brian, On 01/15/2018 06:11 PM, Andrzej Hajda wrote: > On 15.01.2018 15:40, Philippe CORNU wrote: >> Hi Andrzej, >> >> On 01/15/2018 02:52 PM, Andrzej Hajda wrote: >>> On 12.01.2018 17:25, Philippe Cornu wrote: The pixel clock is optional. When available, it offers a better preciseness

[Bug 104683] WebGL crashes the kernel driver and Xorg

2018-01-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104683 Bug ID: 104683 Summary: WebGL crashes the kernel driver and Xorg Product: Mesa Version: 17.3 Hardware: Other OS: Linux (All) Status: NEW Severity: major

[PATCH v5 2/2] dt-bindings: drm/bridge: Document Cadence DSI bridge bindings

2018-01-18 Thread Boris Brezillon
Document the bindings used for the Cadence DSI bridge. Signed-off-by: Boris Brezillon Acked-by: Rob Herring --- Changes in v5: - Add optional reset line for the peripheral/APB logic Changes in v4: - Rename DSI clks (suggested by Tomi) - Drop the IP version in the compatible since it can be extr

[PATCH v5 1/2] drm/bridge: Add Cadence DSI driver

2018-01-18 Thread Boris Brezillon
Add a driver for Cadence DPI -> DSI bridge. This driver only support a subset of Cadence DSI bridge capabilities. Here is a non-exhaustive list of missing features: * burst mode * DPHY init/configuration steps * support for additional input interfaces (SDI input) Signed-off-by: Boris Brezillo

Re: [PATCH] drm/vc4: Flush the caches before the bin jobs, as well.

2018-01-18 Thread Boris Brezillon
On Thu, 21 Dec 2017 14:17:22 -0800 Eric Anholt wrote: > If the frame samples from a render target that was just written, its > cache flush during the binning step may have occurred before the > previous frame's RCL was completed. Flush the texture caches again > before starting each RCL job to m

[Bug 104685] [polaris10] amdgpu 0000:01:00.0: swiotlb buffer is full

2018-01-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104685 Bug ID: 104685 Summary: [polaris10] amdgpu :01:00.0: swiotlb buffer is full Product: DRI Version: DRI git Hardware: Other OS: All Status: N

[Bug 104082] amdgpu 0000:07:00.0: swiotlb buffer is full (sz: 2097152 bytes)

2018-01-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104082 Alex Deucher changed: What|Removed |Added CC||ved...@miletic.net --- Comment #8 from A

[Bug 104685] [polaris10] amdgpu 0000:01:00.0: swiotlb buffer is full

2018-01-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104685 Alex Deucher changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [PATCH v16 09/10] drm/panel: Use of_find_backlight helper

2018-01-18 Thread Noralf Trønnes
Den 18.01.2018 13.07, skrev Meghana Madhyastha: On Tue, Jan 16, 2018 at 06:08:53PM +0100, Noralf Trønnes wrote: Den 16.01.2018 11.36, skrev Meghana Madhyastha: Replace of_find_backlight_by_node and of the code around it with of_find_backlight helper to avoid repetition of code. Signed-off-by:

Re: [RFC v2 1/2] dt-bindings: mipi-dsi: Add info about peripherals with non-DSI control bus

2018-01-18 Thread Boris Brezillon
On Thu, 18 Jan 2018 10:23:54 +0530 Archit Taneja wrote: > Add a section that describes dt-bindings for peripherals that support > MIPI DSI, but have a different bus as the primary control bus, or no > control bus at all. Add an example for a peripheral with a non-DSI > control bus. > > Signed-of

[PATCH v2] drm/vc4: Fix NULL pointer dereference in vc4_save_hang_state()

2018-01-18 Thread Boris Brezillon
When saving BOs in the hang state we skip one entry of the kernel_state->bo[] array, thus leaving it to NULL. This leads to a NULL pointer dereference when, later in this function, we iterate over all BOs to check their ->madv state. Fixes: ca26d28bbaa3 ("drm/vc4: improve throughput by pipelining

[Bug 104685] [polaris10] amdgpu 0000:01:00.0: swiotlb buffer is full

2018-01-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104685 --- Comment #2 from Vedran Miletić --- Whoops. First time observed here, thought it was rare, should have searched. Sorry. -- You are receiving this mail because: You are the assignee for the bug.___

[Bug 104082] amdgpu 0000:07:00.0: swiotlb buffer is full (sz: 2097152 bytes)

2018-01-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104082 --- Comment #9 from Vedran Miletić --- Same on RX580 (polaris10). -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.freedesktop.org h

  1   2   >