Re: [PATCH v2 6/6] drm/tinydrm: Embed the mode in tinydrm_connector

2018-01-10 Thread Daniel Vetter
On Tue, Jan 09, 2018 at 09:09:32PM -0600, David Lechner wrote: > On 01/09/2018 08:05 AM, Noralf Trønnes wrote: > > > > Den 09.01.2018 11.08, skrev Daniel Vetter: > > > On Mon, Jan 08, 2018 at 07:46:27PM -0600, David Lechner wrote: > > > > On 01/07/2018 11:44 AM, Noralf Trønnes wrote: > > > > > Emb

Re: [PATCH 04/11] drm/bridge/synopsys: dw-hdmi: Export some PHY related functions

2018-01-10 Thread Jernej Škrabec
Hi Laurent, Dne torek, 09. januar 2018 ob 17:08:55 CET je Laurent Pinchart napisal(a): > Hello, > > On Tuesday, 9 January 2018 17:58:46 EET Jernej Škrabec wrote: > > Dne torek, 09. januar 2018 ob 11:43:08 CET je Archit Taneja napisal(a): > > > On 12/31/2017 02:31 AM, Jernej Skrabec wrote: > > >>

[PATCH v5 6/6] drm/msm: iommu: Replace runtime calls with runtime suppliers

2018-01-10 Thread Vivek Gautam
While handling the concerned iommu, there should not be a need to power control the drm devices from iommu interface. If these drm devices need to be powered around this time, the respective drivers should take care of this. Replace the pm_runtime_get/put_sync() with pm_runtime_get/put_suppliers()

[PATCH v5 2/6] iommu/arm-smmu: Add pm_runtime/sleep ops

2018-01-10 Thread Vivek Gautam
From: Sricharan R The smmu needs to be functional only when the respective master's using it are active. The device_link feature helps to track such functional dependencies, so that the iommu gets powered when the master device enables itself using pm_runtime. So by adapting the smmu driver for r

Re: [PATCH v5 0/6] iommu/arm-smmu: Add runtime pm/sleep support

2018-01-10 Thread Vivek Gautam
On 01/09/2018 04:53 PM, Rafael J. Wysocki wrote: On Tuesday, January 9, 2018 11:01:43 AM CET Vivek Gautam wrote: This series provides the support for turning on the arm-smmu's clocks/power domains using runtime pm. This is done using the recently introduced device links patches, which lets the

[PATCH v7 8/8] drm/rockchip: dw_hdmi: Fix error handling path

2018-01-10 Thread Thierry Escande
From: Jeffy Chen Add missing clk_disable_unprepare() in bind()'s error handling path and unbind(). Also inline clk_prepare_enable() with bind(). Fixes: 12b9f204e804 ("drm: bridge/dw_hdmi: add rockchip rk3288 support") Signed-off-by: Jeffy Chen Signed-off-by: Thierry Escande --- drivers/gpu/d

[PATCH v7 1/8] drm/bridge: analogix: Do not use device's drvdata

2018-01-10 Thread Thierry Escande
From: Jeffy Chen The driver that instantiates the bridge should own the drvdata, as all driver model callbacks (probe, remove, shutdown, PM ops, etc.) are also owned by its driver struct. Moreover, storing two different pointer types in driver data depending on driver initialization status is bar

[PATCH v5 3/6] iommu/arm-smmu: Invoke pm_runtime during probe, add/remove device

2018-01-10 Thread Vivek Gautam
From: Sricharan R The smmu device probe/remove and add/remove master device callbacks gets called when the smmu is not linked to its master, that is without the context of the master device. So calling runtime apis in those places separately. Signed-off-by: Sricharan R [vivek: Cleanup pm runtim

[PATCH v7 6/8] drm/bridge/synopsys: dw-hdmi: Add missing bridge detach

2018-01-10 Thread Thierry Escande
From: Jeffy Chen We inited connector in attach(), so need a detach() to cleanup. Also fix wrong use of dw_hdmi_remove() in bind(). Signed-off-by: Jeffy Chen Signed-off-by: Thierry Escande --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 10 +- 1 file changed, 9 insertions(+), 1 deleti

[PATCH v7 5/8] drm/rockchip: inno_hdmi: Fix error handling path

2018-01-10 Thread Thierry Escande
From: Jeffy Chen Add missing error handling in bind(). Fixes: 412d4ae6b7a5 ("drm/rockchip: hdmi: add Innosilicon HDMI support") Signed-off-by: Jeffy Chen Signed-off-by: Thierry Escande --- drivers/gpu/drm/rockchip/inno_hdmi.c | 22 +- 1 file changed, 17 insertions(+), 5 de

[PATCH v5 0/6] iommu/arm-smmu: Add runtime pm/sleep support

2018-01-10 Thread Vivek Gautam
This series provides the support for turning on the arm-smmu's clocks/power domains using runtime pm. This is done using the recently introduced device links patches, which lets the smmu's runtime to follow the master's runtime pm, so the smmu remains powered only when the masters use it. It also

[PATCH v7 3/8] drm/rockchip: analogix_dp: Add a sanity check for rockchip_drm_psr_register()

2018-01-10 Thread Thierry Escande
From: Jeffy Chen The rockchip_drm_psr_register() can fail, so add a sanity check for that. Also reorder the calls in unbind() to match bind(). Signed-off-by: Jeffy Chen Signed-off-by: Thierry Escande --- drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 15 +++ 1 file changed, 11

Re: [PATCH v6 4/9] drm: Add some HDCP related #defines

2018-01-10 Thread Philippe Ombredanne
Sean, On Mon, Jan 8, 2018 at 8:55 PM, Sean Paul wrote: > In preparation for implementing HDCP in i915, add some HDCP related > register offsets and defines. The dpcd register offsets will go in > drm_dp_helper.h whereas the ddc offsets along with generic HDCP stuff > will get stuffed in drm_hdcp.

[PATCH v7 00/10] rockchip: kevin: Enable edp display

2018-01-10 Thread Thierry Escande
Hi, This patchset makes edp display work on Chromebook kevin. This patchset has been originally posted by Jeffy Chen and the 2 first commits from the previous version (v6) are already merged in mainline. This v7 has been rebased on top of next-20180108 and a few conflicts have been fixed as well.

[PATCH v5 4/6] iommu/arm-smmu: Add the device_link between masters and smmu

2018-01-10 Thread Vivek Gautam
From: Sricharan R Finally add the device link between the master device and smmu, so that the smmu gets runtime enabled/disabled only when the master needs it. This is done from add_device callback which gets called once when the master is added to the smmu. Signed-off-by: Sricharan R --- driv

Re: [PATCH 04/11] drm/bridge/synopsys: dw-hdmi: Export some PHY related functions

2018-01-10 Thread Jernej Škrabec
Hi, Dne torek, 09. januar 2018 ob 17:08:55 CET je Laurent Pinchart napisal(a): > Hello, > > On Tuesday, 9 January 2018 17:58:46 EET Jernej Škrabec wrote: > > Dne torek, 09. januar 2018 ob 11:43:08 CET je Archit Taneja napisal(a): > > > On 12/31/2017 02:31 AM, Jernej Skrabec wrote: > > >> Parts of

Re: [PATCH 04/11] drm/bridge/synopsys: dw-hdmi: Export some PHY related functions

2018-01-10 Thread Jernej Škrabec
Hi Archit, Dne torek, 09. januar 2018 ob 11:43:08 CET je Archit Taneja napisal(a): > On 12/31/2017 02:31 AM, Jernej Skrabec wrote: > > Parts of PHY code could be useful also for custom PHYs. For example, > > Allwinner A83T has custom PHY which is probably Synopsys gen2 PHY > > with few additional

Re: [linux-sunxi] Re: [PATCH 01/11] clk: sunxi-ng: Don't set k if width is 0 for nkmp plls

2018-01-10 Thread Jernej Škrabec
Hi Chen-Yu, Dne ponedeljek, 08. januar 2018 ob 10:19:47 CET je Chen-Yu Tsai napisal(a): > On Fri, Jan 5, 2018 at 3:28 AM, Jernej Škrabec wrote: > > Hi, > > > > Dne četrtek, 04. januar 2018 ob 15:45:18 CET je Chen-Yu Tsai napisal(a): > >> On Sun, Dec 31, 2017 at 5:01 AM, Jernej Skrabec > > > >

[PATCH v5 1/6] base: power: runtime: Export pm_runtime_get/put_suppliers

2018-01-10 Thread Vivek Gautam
The device link allows the pm framework to tie the supplier and consumer. So, whenever the consumer is powered-on the supplier is powered-on first. There are however cases in which the consumer wants to power-on the supplier, but not itself. E.g., A Graphics or multimedia driver wants to power-on

[PATCH v5 5/6] iommu/arm-smmu: Add support for qcom,smmu-v2 variant

2018-01-10 Thread Vivek Gautam
qcom,smmu-v2 is an arm,smmu-v2 implementation with specific clock and power requirements. This smmu core is used with multiple masters on msm8996, viz. mdss, video, etc. Add bindings for the same. Signed-off-by: Vivek Gautam --- * Major change in this patch - Changed compatible string from '

[PATCH v7 2/8] drm/bridge: analogix_dp: Fix connector and encoder cleanup

2018-01-10 Thread Thierry Escande
From: Jeffy Chen Since we are initing connector in the core driver and encoder in the plat driver, let's clean them up in the right places. Signed-off-by: Jeffy Chen Signed-off-by: Thierry Escande Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 2 -- driv

[PATCH v7 7/8] drm/bridge/synopsys: dw-hdmi: Do not use device's drvdata

2018-01-10 Thread Thierry Escande
From: Jeffy Chen Let plat drivers own the drvdata, so that they could cleanup resources in their unbind(). Signed-off-by: Jeffy Chen Signed-off-by: Thierry Escande Reviewed-by: Neil Armstrong --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 43 ++--- drivers/gpu/drm/

Re: [PATCH 04/11] drm/bridge/synopsys: dw-hdmi: Export some PHY related functions

2018-01-10 Thread Jernej Škrabec
Hi Laurent, Dne torek, 09. januar 2018 ob 14:30:22 CET je Laurent Pinchart napisal(a): > Hi Jernej, > > Thank you for the patch. > > On Saturday, 30 December 2017 23:01:56 EET Jernej Skrabec wrote: > > Parts of PHY code could be useful also for custom PHYs. For example, > > Allwinner A83T has cu

[PATCH v7 4/8] drm/rockchip: dw-mipi-dsi: Fix error handling path

2018-01-10 Thread Thierry Escande
From: Jeffy Chen Add missing pm_runtime_disable() in bind()'s error handling path. Also cleanup encoder & connector in unbind(). Fixes: 80a9a059d4e4 ("drm/rockchip/dsi: add dw-mipi power domain support") Signed-off-by: Jeffy Chen Signed-off-by: Thierry Escande --- drivers/gpu/drm/rockchip/dw

Re: [RFC][PATCH 2/5] drm_hwcomposer: glworker: Add build time options for certain shader feature names

2018-01-10 Thread Daniel Vetter
On Tue, Jan 09, 2018 at 10:05:42PM -0800, John Stultz wrote: > In order to get the hikey960, which uses the mali bifrost driver > working with drm_hwcomposer, its needed to tweak some extension > and funciton names used in the shaders. > > Specifically: > * GL_OES_EGL_image_external_essl3 instead

Re: [PATCH 2/3] drm: export gem dmabuf_ops for drivers to reuse

2018-01-10 Thread Daniel Vetter
On Tue, Jan 09, 2018 at 01:13:08PM -0500, Alex Deucher wrote: > On Tue, Jan 9, 2018 at 10:56 AM, Deucher, Alexander > wrote: > > I'll can push this and a few other misc patches today. > > > > Pushed to drm-misc-next. One thing I just noticed: Some kerneldoc for the newly exported functions and m

[PATCH] radeon: completely remove lut leftovers

2018-01-10 Thread Daniel Vetter
This is an oversight from commit 42585395ebc1034a98937702849669f17eadb35f Author: Peter Rosin Date: Thu Jul 13 18:25:36 2017 +0200 drm: radeon: remove dead code and pointless local lut storage Cc: Peter Rosin Cc: Alex Deucher Cc: Michel Dänzer Signed-off-by: Daniel Vetter --- drivers

Re: [PATCH v7 6/8] drm/bridge/synopsys: dw-hdmi: Add missing bridge detach

2018-01-10 Thread Archit Taneja
On 01/09/2018 08:18 PM, Thierry Escande wrote: From: Jeffy Chen We inited connector in attach(), so need a detach() to cleanup. Also fix wrong use of dw_hdmi_remove() in bind(). Signed-off-by: Jeffy Chen Signed-off-by: Thierry Escande Reviewed-by: Archit Taneja --- drivers/gpu/drm/

Re: [PATCH] drm/atomic: Fix memleak on ERESTARTSYS during non-blocking commits

2018-01-10 Thread Daniel Vetter
On Tue, Jan 09, 2018 at 01:13:33PM -0500, Alex Deucher wrote: > On Mon, Jan 8, 2018 at 4:30 PM, Harry Wentland wrote: > > On 2018-01-04 02:47 PM, sunpeng...@amd.com wrote: > >> From: "Leo (Sunpeng) Li" > >> > >> During a non-blocking commit, it is possible to return before the > >> commit_tail wo

Re: [PATCH v7 7/8] drm/bridge/synopsys: dw-hdmi: Do not use device's drvdata

2018-01-10 Thread Archit Taneja
On 01/09/2018 08:18 PM, Thierry Escande wrote: From: Jeffy Chen Let plat drivers own the drvdata, so that they could cleanup resources in their unbind(). Signed-off-by: Jeffy Chen Signed-off-by: Thierry Escande Reviewed-by: Neil Armstrong Reviewed-by: Archit Taneja --- drivers/gpu/

[PATCH] drm/vmwgfx: Potential off by one in vmw_view_add()

2018-01-10 Thread Dan Carpenter
The vmw_view_cmd_to_type() function returns vmw_view_max (3) on error. It's one element beyond the end of the vmw_view_cotables[] table. My read on this is that it's possible to hit this failure. header->id comes from vmw_cmd_check() and it's a user controlled number between 1040 and 1225 so we c

Re: [PATCH] drm/atomic: Fix memleak on ERESTARTSYS during non-blocking commits

2018-01-10 Thread Maarten Lankhorst
Op 08-01-18 om 22:30 schreef Harry Wentland: > On 2018-01-04 02:47 PM, sunpeng...@amd.com wrote: >> From: "Leo (Sunpeng) Li" >> >> During a non-blocking commit, it is possible to return before the >> commit_tail work is queued (-ERESTARTSYS, for example). >> >> Since a reference on the crtc commit

Re: [PATCH v7 00/10] rockchip: kevin: Enable edp display

2018-01-10 Thread Archit Taneja
On 01/09/2018 08:18 PM, Thierry Escande wrote: Hi, This patchset makes edp display work on Chromebook kevin. This patchset has been originally posted by Jeffy Chen and the 2 first commits from the previous version (v6) are already merged in mainline. This v7 has been rebased on top of next-20

Re: [PATCH v7 3/3] drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver

2018-01-10 Thread Archit Taneja
On 12/12/2017 06:40 AM, Nickey Yang wrote: Add the ROCKCHIP DSI controller driver that uses the Synopsys DesignWare MIPI DSI host controller bridge. Reviewed-by: Archit Taneja Signed-off-by: Nickey Yang Signed-off-by: Brian Norris Reviewed-by: Brian Norris Reviewed-by: Sean Paul --- c

Re: [PATCH v7 4/8] drm/rockchip: dw-mipi-dsi: Fix error handling path

2018-01-10 Thread Archit Taneja
On 01/09/2018 08:18 PM, Thierry Escande wrote: From: Jeffy Chen Add missing pm_runtime_disable() in bind()'s error handling path. Also cleanup encoder & connector in unbind(). I guess you'll need to drop this commit if this patch goes in first: https://patchwork.kernel.org/patch/10106105/

Re: [PATCH] radeon: completely remove lut leftovers

2018-01-10 Thread Michel Dänzer
On 2018-01-10 09:18 AM, Daniel Vetter wrote: > This is an oversight from > > commit 42585395ebc1034a98937702849669f17eadb35f > Author: Peter Rosin > Date: Thu Jul 13 18:25:36 2017 +0200 > > drm: radeon: remove dead code and pointless local lut storage > > Cc: Peter Rosin > Cc: Alex Deuch

[PATCH] drm/atomic: Fix memleak on ERESTARTSYS during non-blocking commits, v2.

2018-01-10 Thread Maarten Lankhorst
From: "Leo (Sunpeng) Li" During a non-blocking commit, it is possible to return before the commit_tail work is queued (-ERESTARTSYS, for example). Since a reference on the crtc commit object is obtained for the pending vblank event when preparing the commit, the above situation will leave us wit

[PATCH] drm/tegra: sor: Fix hang on Tegra124 eDP

2018-01-10 Thread Thierry Reding
From: Thierry Reding The SOR0 found on Tegra124 and Tegra210 only supports eDP and LVDS and therefore has a slightly different clock tree than the SOR1 which does not support eDP, but HDMI and DP instead. Commit e1335e2f0cfc ("drm/tegra: sor: Reimplement pad clock") breaks setups with eDP becaus

Re: [RFC PATCH v2 1/1] drm/tegra: sor: Fix hang on tegra124 due to NULL clk_out

2018-01-10 Thread Thierry Reding
On Tue, Jan 02, 2018 at 06:32:11PM +, Jon Hunter wrote: > > On 20/12/17 18:15, Thierry Reding wrote: > > On Wed, Dec 20, 2017 at 11:32:23AM +, Guillaume Tucker wrote: > >> When neither HDMI nor DP is supported such as on the tegra124, the > >> sor->clk_out is not initialised and remains NU

Re: [Bug 198123] Console is the wrong color at boot with radeon 6670

2018-01-10 Thread Daniel Vetter
On Sun, Jan 07, 2018 at 07:14:41PM +, Deposite Pirate wrote: > December 22, 2017 4:35 PM, "Michel Dänzer" wrote: > > > "Deposite Pirate", do the attached (only compile tested) patches work? > > Hi, > > Sorry for the delay. I was not at home for a while. So, I've compiled and > booted a ker

Re: [Nouveau] [PATCH] drm/nouveau/bar/gk20a: Avoid bar teardown during init

2018-01-10 Thread Thierry Reding
On Thu, Jan 04, 2018 at 11:29:09AM +, Jon Hunter wrote: > Commit bbb163e18960 ("drm/nouveau/bar: implement bar1 teardown") > introduced add a teardown helper function for BAR1. During > initialisation of the Nouveau, initially all the teardown helpers are > called once, before calling their ini

[PATCH] dma-buf: make returning the exclusive fence optional

2018-01-10 Thread Christian König
Change reservation_object_get_fences_rcu to make the exclusive fence pointer optional. If not specified the exclusive fence is put into the fence array as well. This is helpful for a couple of cases where we need all fences in a single array. Signed-off-by: Christian König --- drivers/dma-buf/

Re: [Intel-gfx] [PATCH 7/8] drm: Check that the plane supports the request format+modifier combo

2018-01-10 Thread Daniel Vetter
On Fri, Dec 22, 2017 at 09:22:30PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Currently we only check that the plane supports the pixel format of the > fb we're about to feed to it. Extend it to check also the modifier, and > more specifically that the combination of the format and mod

Re: [Linaro-mm-sig] [PATCH] dma-buf: make returning the exclusive fence optional

2018-01-10 Thread Daniel Vetter
On Wed, Jan 10, 2018 at 01:53:41PM +0100, Christian König wrote: > Change reservation_object_get_fences_rcu to make the exclusive fence > pointer optional. > > If not specified the exclusive fence is put into the fence array as > well. > > This is helpful for a couple of cases where we need all f

Re: [Linaro-mm-sig] [PATCH] dma-buf: make returning the exclusive fence optional

2018-01-10 Thread Christian König
Am 10.01.2018 um 14:21 schrieb Daniel Vetter: On Wed, Jan 10, 2018 at 01:53:41PM +0100, Christian König wrote: Change reservation_object_get_fences_rcu to make the exclusive fence pointer optional. If not specified the exclusive fence is put into the fence array as well. This is helpful for a

Re: [PATCH] libdrm: intel/Android.mk: Filter libdrm_intel library requirements on x86

2018-01-10 Thread Rob Herring
On Tue, Jan 9, 2018 at 11:25 PM, John Stultz wrote: > When building AOSP after updating libdrm project to the > freedesktop/master branch, I've seen the following build errors: > > external/libdrm/intel/Android.mk: error: libdrm_intel This is only needed for i915 (not i965) now BTW. I'm not sure

Re: [Linaro-mm-sig] [PATCH] dma-buf: make returning the exclusive fence optional

2018-01-10 Thread Daniel Vetter
On Wed, Jan 10, 2018 at 02:46:32PM +0100, Christian König wrote: > Am 10.01.2018 um 14:21 schrieb Daniel Vetter: > > On Wed, Jan 10, 2018 at 01:53:41PM +0100, Christian König wrote: > > > Change reservation_object_get_fences_rcu to make the exclusive fence > > > pointer optional. > > > > > > If no

[PATCH 1/4 v6] drm/bridge: Add bindings for TI THS8134

2018-01-10 Thread Linus Walleij
This adds device tree bindings for the Texas Instruments THS8134, THS8134A and THS8134B VGA DACs by extending and renaming the existing bindings for THS8135. These DACs are used for the VGA outputs on the ARM reference designs such as Integrator, Versatile and RealView. Cc: devicet...@vger.kernel

[PATCH 4/4 v6] drm/pl111: Support handling bridge timings

2018-01-10 Thread Linus Walleij
If the bridge has a too strict setup time for the incoming signals, we may not be fast enough and then we need to compensate by outputting the signal on the inverse clock edge so it is for sure stable when the bridge samples it. Since bridges in difference to panels does not expose their connector

[PATCH 3/4 v6] drm/bridge: Add timing support to dumb VGA DAC

2018-01-10 Thread Linus Walleij
This extends the dumb VGA DAC bridge to handle the THS8134A and THS8134B VGA DACs in addition to those already handled. We assign the proper timing data to the pointer inside the bridge struct so display controllers that need to align their timings to the bridge can pick it up and work from there.

[PATCH 2/4 v6] drm/bridge: Provide a way to embed timing info in bridges

2018-01-10 Thread Linus Walleij
After some discussion and failed patch sets trying to convey the right timing information between the display engine and a bridge using the connector, I try instead to use an optional timing information container in the bridge itself, so that display engines can retrieve it from any bridge and use

Re: [PATCH] drm/vmwgfx: Potential off by one in vmw_view_add()

2018-01-10 Thread Thomas Hellstrom
Hi! On 01/10/2018 10:40 AM, Dan Carpenter wrote: The vmw_view_cmd_to_type() function returns vmw_view_max (3) on error. It's one element beyond the end of the vmw_view_cotables[] table. My read on this is that it's possible to hit this failure. header->id comes from vmw_cmd_check() and it's a

Re: [PATCH v2 2/2] drm/bridge/synopsys: dsi: handle endianness correctly in dw_mipi_dsi_write()

2018-01-10 Thread Andrzej Hajda
On 09.01.2018 21:32, Brian Norris wrote: > We're filling the "remainder" word with little-endian data, then writing > it out to IO registers with endian-correcting writel(). That probably > won't work on big-endian systems. > > Let's mark the "remainder" variable as LE32 (since we fill it with > me

Re: [-next PATCH 2/4] treewide: Use DEVICE_ATTR_RW

2018-01-10 Thread Peter Ujfalusi
On 2017-12-20 12:54, Jarkko Nikula wrote: > On Wed, Dec 20, 2017 at 10:32:11AM +0100, Greg Kroah-Hartman wrote: >> On Wed, Dec 20, 2017 at 01:24:44AM -0800, Joe Perches wrote: >>> On Wed, 2017-12-20 at 10:34 +0200, Jarkko Nikula wrote: On Tue, Dec 19, 2017 at 10:15:07AM -0800, Joe Perches wr

Re: [PATCH 2/4 v6] drm/bridge: Provide a way to embed timing info in bridges

2018-01-10 Thread Daniel Vetter
On Wed, Jan 10, 2018 at 03:12:24PM +0100, Linus Walleij wrote: > After some discussion and failed patch sets trying to convey > the right timing information between the display engine and > a bridge using the connector, I try instead to use an optional > timing information container in the bridge i

RE: [PATCH 2/3] drm: export gem dmabuf_ops for drivers to reuse

2018-01-10 Thread Li, Samuel
OK. I'll do it. Samuel Li > -Original Message- > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel > Vetter > Sent: Wednesday, January 10, 2018 3:17 AM > To: Alex Deucher > Cc: Deucher, Alexander ; Li, Samuel > ; Daniel Vetter ; Koenig, Christian > ; dri-devel@list

Re: AMD DC test results

2018-01-10 Thread Carlo Caione
On Thu, Dec 21, 2017 at 1:45 PM, Daniel Drake wrote: > Hi, Hi again, in Endless we are still actively working with DC on several laptops, so I just wanted to give you a quick update regarding the regressions indicated in Daniel's email. > 1. System hangs on S3 resume. > Bug can't be reproduced w

[PATCH] drm/vc4: Fix NULL pointer dereference in vc4_save_hang_state()

2018-01-10 Thread Boris Brezillon
When saving BOs in the hang state we skip one entry of the kernel_state->bo[] array, thus leaving it to NULL. This leads to a NULL pointer dereference when, later in this function, we iterate over all BOs to check their ->madv state. Fixes: ca26d28bbaa3 ("drm/vc4: improve throughput by pipelining

[git pull] vmwgfx-fixes-4.15

2018-01-10 Thread Thomas Hellstrom
Dave, Two important fixes for vmwgfx. The off-by-one fix could cause a malicious user to potentially crash the kernel. The framebuffer map cache fix can under some circumstances enable a user to read from or write to freed pages. The following changes since commit b0bb222440a5c8273f67dd37946707e6b

Re: next/master build: 198 builds: 1 failed, 197 passed, 1 error, 148 warnings (next-20180110)

2018-01-10 Thread Arnd Bergmann
On Wed, Jan 10, 2018 at 7:59 AM, kernelci.org bot wrote: > > next/master build: 198 builds: 1 failed, 197 passed, 1 error, 148 warnings > (next-20180110) > > Errors summary: > 1 drivers/perf/arm_dsu_pmu.c:661:2: error: implicit declaration of function > 'bitmap_from_u

Re: next/master build: 198 builds: 1 failed, 197 passed, 1 error, 148 warnings (next-20180110)

2018-01-10 Thread Christian König
Hi Arnd, Am 10.01.2018 um 16:45 schrieb Arnd Bergmann: 14 drivers/gpu/drm/ttm/ttm_page_alloc_dma.c:1186:2: warning: ignoring return value of 'register_shrinker', declared with attribute warn_unused_result [-Wunused-result] 14 drivers/gpu/drm/ttm/ttm_page_alloc.c:485:2: warning: ignoring return

[PATCH] drm/panel: lvds: Handle the optional regulator case properly

2018-01-10 Thread Maxime Ripard
The devm_regulator_get_optional function, unlike it was assumed in the commit a1c55bccf600 ("drm/panel: lvds: Add support for the power-supply property"), is actually returning an error pointer with -ENODEV instead of NULL when there's no regulator to find. Make sure we handle that case properly.

Re: next/master build: 198 builds: 1 failed, 197 passed, 1 error, 148 warnings (next-20180110)

2018-01-10 Thread Arnd Bergmann
On Wed, Jan 10, 2018 at 4:54 PM, Christian König wrote: > Hi Arnd, > > Am 10.01.2018 um 16:45 schrieb Arnd Bergmann: >>> >>> 14 drivers/gpu/drm/ttm/ttm_page_alloc_dma.c:1186:2: warning: ignoring >>> return value of 'register_shrinker', declared with attribute >>> warn_unused_result [-Wunused-resul

Re: [PATCH v5] drm/omap: plane zpos/zorder management improvements

2018-01-10 Thread Peter Ujfalusi
On 01/09/2018 04:40 PM, Daniel Vetter wrote: > On Tue, Jan 09, 2018 at 04:18:48PM +0200, Peter Ujfalusi wrote: >> Hi, >> >> On 2018-01-09 14:44, Daniel Vetter wrote: Changes since v4: - further simplify the zpos checking by using a mask and a single loop - Commit message has been ext

[PATCH] video: fbdev/mmp: add MODULE_LICENSE

2018-01-10 Thread Arnd Bergmann
Kbuild complains about the lack of a license tag in this driver: WARNING: modpost: missing MODULE_LICENSE() in drivers/video/fbdev/mmp/mmp_disp.o This adds the license, author and description tags. Signed-off-by: Arnd Bergmann --- drivers/video/fbdev/mmp/core.c | 5 + 1 file changed, 5 ins

[Bug 104306] Mesa 17.3 breaks Firefox and other Xwayland apps on AMD HD7750

2018-01-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104306 --- Comment #14 from eric vz --- Thanks, Michel. On a hanging call to glxinfo, dri2_validate_usage is being called from gbm_dri_bo_import, which gets parameters of a 100x100 FD image buffer for usage 5 (scanout | rendering). However, the image

Re: [RFC v2 6/8] drm: Handle fbdev emulation in core

2018-01-10 Thread Noralf Trønnes
Den 09.01.2018 11.38, skrev Daniel Vetter: On Wed, Jan 03, 2018 at 11:21:08PM +0100, Noralf Trønnes wrote: Prepare for generic fbdev emulation by letting DRM core work directly with the fbdev compatibility layer. This is done by adding new fbdev helper vtable callbacks for restore, hotplug_even

Re: [PATCH 0/3] Meson build system

2018-01-10 Thread Dylan Baker
I forgot to CC you on this like you asked, Dylan Quoting Dylan Baker (2018-01-05 12:00:57) > This is a fifth iteration of the meson build system for libdrm. This > version is significantly cleaned up from the last version and uses a > style more like the build system in mesa. > > It builds all o

[v2 PATCH] drm/msm: Add devfreq support for the GPU

2018-01-10 Thread Jordan Crouse
Add support for devfreq to dynamically control the GPU frequency. By default try to use the 'simple_ondemand' governor which can adjust the frequency based on GPU load. v2: Fix __aeabi_uldivmod issue from the 0 day bot and use devfreq_recommended_opp() as suggested by Rob. Signed-off-by: Jordan C

[radeon-alex:amd-17.50 2016/2100] drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/ci_smc.c:579:62: warning: 'tmp' may be used uninitialized in this function

2018-01-10 Thread kbuild test robot
Hi Rex, FYI, the error/warning still remains. tree: git://people.freedesktop.org/~agd5f/linux.git amd-17.50 head: 4b295aab3256d700354748dcd64017d76065d684 commit: 9c2014d08693830897cad6bbd359d905825d8a18 [2016/2100] drm/amd/powerplay: add CI asics support to smumgr config: i386-allyesconfig

[PATCH v8 2/8] drm/bridge: analogix_dp: Fix connector and encoder cleanup

2018-01-10 Thread Thierry Escande
From: Jeffy Chen Since we are initing connector in the core driver and encoder in the plat driver, let's clean them up in the right places. Signed-off-by: Jeffy Chen Signed-off-by: Thierry Escande Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 2 -- driv

[PATCH v8 3/8] drm/rockchip: analogix_dp: Add a sanity check for rockchip_drm_psr_register()

2018-01-10 Thread Thierry Escande
From: Jeffy Chen The rockchip_drm_psr_register() can fail, so add a sanity check for that. Also reorder the calls in unbind() to match bind(). Signed-off-by: Jeffy Chen Signed-off-by: Thierry Escande --- drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 15 +++ 1 file changed, 11

[PATCH v8 7/8] drm/bridge/synopsys: dw-hdmi: Do not use device's drvdata

2018-01-10 Thread Thierry Escande
From: Jeffy Chen Let plat drivers own the drvdata, so that they could cleanup resources in their unbind(). Signed-off-by: Jeffy Chen Signed-off-by: Thierry Escande Reviewed-by: Neil Armstrong --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 43 ++--- drivers/gpu/drm/

[PATCH] drm/amdkfd: Fix potential NULL pointer dereferences

2018-01-10 Thread Gustavo A. R. Silva
In case kfd_get_process_device_data returns null, there are some null pointer dereferences in functions kfd_bind_processes_to_device and kfd_unbind_processes_from_device. Fix this by null checking pdd before dereferencing it. Addresses-Coverity-ID: 1463794 ("Dereference null return value") Addres

[PATCH v8 0/8] rockchip: kevin: Enable edp display

2018-01-10 Thread Thierry Escande
Hi, This patchset makes edp display work on Chromebook kevin. This patchset has been originally posted by Jeffy Chen and the 2 first commits from a previous version (v6) are already merged in mainline. v8: Fixed compilation issue between patches #7 and #8 reported by Archit. v7: Rebased on top

[PATCH v8 8/8] drm/rockchip: dw_hdmi: Fix error handling path

2018-01-10 Thread Thierry Escande
From: Jeffy Chen Add missing clk_disable_unprepare() in bind()'s error handling path and unbind(). Also inline clk_prepare_enable() with bind(). Fixes: 12b9f204e804 ("drm: bridge/dw_hdmi: add rockchip rk3288 support") Signed-off-by: Jeffy Chen Signed-off-by: Thierry Escande --- drivers/gpu/d

[PATCH v8 4/8] drm/rockchip: dw-mipi-dsi: Fix error handling path

2018-01-10 Thread Thierry Escande
From: Jeffy Chen Add missing pm_runtime_disable() in bind()'s error handling path. Also cleanup encoder & connector in unbind(). Fixes: 80a9a059d4e4 ("drm/rockchip/dsi: add dw-mipi power domain support") Signed-off-by: Jeffy Chen Signed-off-by: Thierry Escande --- drivers/gpu/drm/rockchip/dw

[PATCH v8 5/8] drm/rockchip: inno_hdmi: Fix error handling path

2018-01-10 Thread Thierry Escande
From: Jeffy Chen Add missing error handling in bind(). Fixes: 412d4ae6b7a5 ("drm/rockchip: hdmi: add Innosilicon HDMI support") Signed-off-by: Jeffy Chen Signed-off-by: Thierry Escande --- drivers/gpu/drm/rockchip/inno_hdmi.c | 22 +- 1 file changed, 17 insertions(+), 5 de

Re: [PATCH] drm/stm: ltdc: add clut mode support

2018-01-10 Thread Peter Rosin
On 2018-01-09 12:28, Philippe CORNU wrote: > Hi all, > > Do you think the patch is "acceptable" or should I change it somehow? > Any opinion is welcomed : ) Maybe you should try Daniel Vetter? He was very helpful (thanks) when I worked on the clut changes... Cheers, Peter ___

[PATCH v8 6/8] drm/bridge/synopsys: dw-hdmi: Add missing bridge detach

2018-01-10 Thread Thierry Escande
From: Jeffy Chen We inited connector in attach(), so need a detach() to cleanup. Also fix wrong use of dw_hdmi_remove() in bind(). Signed-off-by: Jeffy Chen Signed-off-by: Thierry Escande --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 10 +- 1 file changed, 9 insertions(+), 1 deleti

[PATCH v8 1/8] drm/bridge: analogix: Do not use device's drvdata

2018-01-10 Thread Thierry Escande
From: Jeffy Chen The driver that instantiates the bridge should own the drvdata, as all driver model callbacks (probe, remove, shutdown, PM ops, etc.) are also owned by its driver struct. Moreover, storing two different pointer types in driver data depending on driver initialization status is bar

Re: [PATCH] drm/amdkfd: Fix potential NULL pointer dereferences

2018-01-10 Thread Felix Kuehling
Hi Gustavo, Thanks for catching that. When returning a fault, I think you also need to srcu_read_unlock(&kfd_processes_srcu, idx). However, instead of returning an error, I think I'd prefer to skip PDDs that can't be found with continue statements. That way others would still suspend and resume s

[PATCH v3 4/7] drm/tinydrm/mipi-dbi: Add poweron-reset functions

2018-01-10 Thread Noralf Trønnes
Split out common poweron-reset functionality. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/tinydrm/mi0283qt.c | 22 ++-- drivers/gpu/drm/tinydrm/mipi-dbi.c | 73 ++ drivers/gpu/drm/tinydrm/st7586.c | 9 ++--- drivers/gpu/drm/tinydrm/st7735r.c

[PATCH v3 2/7] drm/tinydrm/mi0283qt: Remove ili9341.h

2018-01-10 Thread Noralf Trønnes
No need for a public header file for the command macros. Just include the necessary ones in the driver. Also use the MIPI_DCS_PIXEL_FMT_16BIT macro. Signed-off-by: Noralf Trønnes Reviewed-by: David Lechner --- drivers/gpu/drm/tinydrm/mi0283qt.c | 28 ++-- include/drm/tinydrm/il

[PATCH v3 0/7] drm/tinydrm: Cleanup

2018-01-10 Thread Noralf Trønnes
Fix a few things that came up during the tinydrm review but wasn't addressed at the time. Noralf. Changes since version 2: - s/mipi_dbi_por_conditional/mipi_dbi_poweron_reset_conditional/ - Add sleep after soft reset to comply with spec. - Remove reset msleep from mi0283qt following the previous

[PATCH v3 7/7] drm/tinydrm/mipi-dbi: Change reset active time

2018-01-10 Thread Noralf Trønnes
The MIPI DBI spec states that reset active/low time should be more than 9us. Change from 20ms to 20us. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/tinydrm/mipi-dbi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tinydrm/mipi-dbi.c b/drivers/gpu/drm/ti

[PATCH v3 5/7] drm/tinydrm/mi0283qt: Let the display pipe handle power

2018-01-10 Thread Noralf Trønnes
It's better to leave power handling and controller init to the modesetting machinery using the simple pipe .enable and .disable callbacks. Remove unused mipi_dbi_pipe_enable(). Signed-off-by: Noralf Trønnes Reviewed-by: David Lechner --- drivers/gpu/drm/tinydrm/mi0283qt.c | 47 -

[PATCH v3 6/7] drm/tinydrm: Embed the mode in tinydrm_connector

2018-01-10 Thread Noralf Trønnes
Embed the mode in tinydrm_connector instead of doing an devm_ allocation. Remove unnecessary use of ret variable at the end of tinydrm_display_pipe_init(). Signed-off-by: Noralf Trønnes Reviewed-by: David Lechner --- drivers/gpu/drm/tinydrm/core/tinydrm-pipe.c | 34 +++--

[PATCH v3 1/7] drm/tinydrm/mi0283qt: Use common include order

2018-01-10 Thread Noralf Trønnes
Include linux headers before drm headers as it's commonly done. Signed-off-by: Noralf Trønnes Reviewed-by: David Lechner --- drivers/gpu/drm/tinydrm/mi0283qt.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/tinydrm/mi0283qt.c b/drivers/gpu/drm/t

[PATCH v3 3/7] drm/tinydrm/mipi-dbi: Add mipi_dbi_enable_flush()

2018-01-10 Thread Noralf Trønnes
Add and use a function for enabling, flushing and turning on backlight. Signed-off-by: Noralf Trønnes Reviewed-by: David Lechner --- drivers/gpu/drm/tinydrm/ili9225.c | 6 +- drivers/gpu/drm/tinydrm/mipi-dbi.c | 20 drivers/gpu/drm/tinydrm/st7586.c | 6 +- driv

Re: [PATCH] libdrm: intel/Android.mk: Filter libdrm_intel library requirements on x86

2018-01-10 Thread John Stultz
On Wed, Jan 10, 2018 at 5:48 AM, Rob Herring wrote: > On Tue, Jan 9, 2018 at 11:25 PM, John Stultz wrote: >> When building AOSP after updating libdrm project to the >> freedesktop/master branch, I've seen the following build errors: >> >> external/libdrm/intel/Android.mk: error: libdrm_intel > >

[radeon-alex:amd-staging-drm-next 374/952] sound/soc/amd/raven/acp3x.h:28:9: error: implicit declaration of function 'readl'; did you mean 'vread'?

2018-01-10 Thread kbuild test robot
Hi Maruthi, FYI, the error/warning still remains. tree: git://people.freedesktop.org/~agd5f/linux.git amd-staging-drm-next head: 95b5f448bf04b220423808df1bb36ca1bd07b270 commit: c1888183e1764d55d51ae051bd8651e634febe4d [374/952] ASoC: AMD: enable ACP3x drivers build config: arm-allmodconfig

Re: [PATCH] drm/atomic: Fix memleak on ERESTARTSYS during non-blocking commits, v2.

2018-01-10 Thread Alex Deucher
On Wed, Jan 10, 2018 at 6:00 AM, Maarten Lankhorst wrote: > From: "Leo (Sunpeng) Li" > > During a non-blocking commit, it is possible to return before the > commit_tail work is queued (-ERESTARTSYS, for example). > > Since a reference on the crtc commit object is obtained for the pending > vblank

Re: [PATCH] libdrm: intel/Android.mk: Filter libdrm_intel library requirements on x86

2018-01-10 Thread Rob Herring
On Wed, Jan 10, 2018 at 1:09 PM, John Stultz wrote: > On Wed, Jan 10, 2018 at 5:48 AM, Rob Herring wrote: >> On Tue, Jan 9, 2018 at 11:25 PM, John Stultz wrote: >>> When building AOSP after updating libdrm project to the >>> freedesktop/master branch, I've seen the following build errors: >>> >>

Re: [RFC][PATCH 1/5] drm_hwcomposer: provide a common gralloc handle definition

2018-01-10 Thread Rob Herring
On Wed, Jan 10, 2018 at 12:05 AM, John Stultz wrote: > From: Rob Herring > > EGL, gralloc, and HWC must all have a common definition of fd's and int's > in native_handle_t to share the fd and width, height, format, etc. of a > dmabuf. > > Move the definition into HWC so we aren't dependent on a s

[pull] drm/msm: msm-next for 4.16

2018-01-10 Thread Rob Clark
Hi Dave, Updates for 4.16.. fairly small this time around, main thing is devfreq support for the gpu. The following changes since commit 9428088c90b6f7d5edd2a1b0d742c75339b36f6e: drm/qxl: reapply cursor after resetting primary (2017-12-08 13:37:02 +1000) are available in the Git repository at

[pull] amdgpu, radeon, ttm drm-next-4.16

2018-01-10 Thread Alex Deucher
Hi Dave, A few fixes for 4.16: - Cleanup the the remains of ttm io_mem_pfn - A couple dpm quirks for SI - Add Chunming as another amdgpu maintainer - A few more huge page fixes - A few other misc fixes The following changes since commit fb8baefc7b2d7b93ad96abacbe63fa99e3d213d6: drm/amdgpu: use

Re: [PATCH] drm/amdkfd: Fix potential NULL pointer dereferences

2018-01-10 Thread Felix Kuehling
Yeah, this looks good to me. Regards,   Felix On 2018-01-10 04:58 PM, Gustavo A. R. Silva wrote: > Hi Felix, > > Quoting Felix Kuehling : > >> Hi Gustavo, >> >> Thanks for catching that. When returning a fault, I think you also need >> to srcu_read_unlock(&kfd_processes_srcu, idx). >> >> However

[Bug 99353] Kaveri 7400K shows random colored noise instead of GUI in X or Wayland

2018-01-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99353 --- Comment #14 from Bong Cosca --- I have the same setup and I'm experiencing the same symptoms. 7400K on Asus A68HM-K with VGA/DVI-D output on ArchLinux 4.14.12 Xorg 1.19.6, colored noise (sometimes tiled garbage). I tried every possible combin

Re: [RFC PATCH 01/60] hyper_dmabuf: initial working version of hyper_dmabuf drv

2018-01-10 Thread Dongwon Kim
On Wed, Dec 20, 2017 at 10:59:57AM +0100, Daniel Vetter wrote: > On Tue, Dec 19, 2017 at 03:27:31PM -0800, Dongwon Kim wrote: > > I forgot to include this brief information about this patch series. > > > > This patch series contains the implementation of a new device driver, > > hyper_dmabuf, whic

  1   2   >