Re: [PATCH 1/2] drm/blend: Account also the primary plane of the crtc for normalized_zpos

2018-01-09 Thread Laurent Pinchart
Hi Daniel, On Tuesday, 9 January 2018 14:42:55 EET Daniel Vetter wrote: > On Fri, Dec 22, 2017 at 05:15:05PM +0200, Peter Ujfalusi wrote: > > On 2017-12-22 12:12, Ville Syrjälä wrote: > > > On Fri, Dec 22, 2017 at 11:16:47AM +0200, Tomi Valkeinen wrote: > > >> On 21/12/17 17:12, Ville Syrjälä wrot

Re: [PATCH] drm/bridge/synopsis: stop clobbering drvdata

2018-01-09 Thread Andrzej Hajda
On 09.01.2018 14:37, Laurent Pinchart wrote: > Hi Philippe, > > On Tuesday, 9 January 2018 15:01:02 EET Philippe CORNU wrote: >> Hi Archit, Andrzej & Laurent, >> >> Regarding this patch from Brian, I think it could be nice to merge it >> (1xAcked-by, 2xReviewed-by). >> >> Could you please have a l

[Bug 104556] WARNING: CPU: 1 PID: 7288 at mm/slab_common.c:971 kmalloc_slab+0x5e/0x70

2018-01-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104556 --- Comment #3 from Christian König --- Please add your dmesg as attachment and not as inline comment. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing l

Re: [PATCH v14 0/3] Move backlight helper functions from tinydrm-helpers to linux/backlight

2018-01-09 Thread Rob Herring
On Thu, Dec 21, 2017 at 8:08 AM, Daniel Vetter wrote: > On Thu, Dec 21, 2017 at 2:44 PM, Noralf Trønnes wrote: >> >> Den 21.12.2017 14.05, skrev Daniel Vetter: >>> >>> On Thu, Dec 21, 2017 at 11:52:43AM +0100, Noralf Trønnes wrote: Den 11.12.2017 18.56, skrev Noralf Trønnes: > >

Re: [PATCH 06/19] drm/blend: Add a generic alpha property

2018-01-09 Thread Maxime Ripard
On Tue, Jan 09, 2018 at 01:32:41PM +0100, Daniel Vetter wrote: > On Tue, Jan 09, 2018 at 11:56:25AM +0100, Maxime Ripard wrote: > > Some drivers duplicate the logic to create a property to store a per-plane > > alpha. > > > > Let's create a helper in order to move that to the core. > > > > Cc: Bo

[Bug 104306] Mesa 17.3 breaks Firefox and other Xwayland apps on AMD HD7750

2018-01-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104306 --- Comment #13 from Michel Dänzer --- (In reply to eric vz from comment #12) > [...] gdb glxinfo and set a breakpoint on dri2_validate_usage, but that method > appears not to be called before the process hangs. It's not called in the client bu

[Bug 104556] WARNING: CPU: 1 PID: 7288 at mm/slab_common.c:971 kmalloc_slab+0x5e/0x70

2018-01-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104556 --- Comment #4 from Michel Dänzer --- The dmesg splat should be fixed with latest development kernels. The hang is probably not directly related. -- You are receiving this mail because: You are the assignee for the bug.

Re: [PATCH 06/19] drm/blend: Add a generic alpha property

2018-01-09 Thread Maxime Ripard
Hi Laurent, On Tue, Jan 09, 2018 at 02:34:47PM +0200, Laurent Pinchart wrote: > > Some drivers duplicate the logic to create a property to store a per-plane > > alpha. > > > > Let's create a helper in order to move that to the core. > > > > Cc: Boris Brezillon > > Cc: Laurent Pinchart > > Sign

Re: [PATCH v2 6/6] drm/tinydrm: Embed the mode in tinydrm_connector

2018-01-09 Thread Noralf Trønnes
Den 09.01.2018 11.08, skrev Daniel Vetter: On Mon, Jan 08, 2018 at 07:46:27PM -0600, David Lechner wrote: On 01/07/2018 11:44 AM, Noralf Trønnes wrote: Embed the mode in tinydrm_connector instead of doing an devm_ allocation. Remove unnecessary use of ret variable at the end of tinydrm_display

Re: [PATCH v5] drm/omap: plane zpos/zorder management improvements

2018-01-09 Thread Peter Ujfalusi
Hi, On 2018-01-09 14:44, Daniel Vetter wrote: >> Changes since v4: >> - further simplify the zpos checking by using a mask and a single loop >> - Commit message has been extended >> >> Changes since v3: >> - Use drm_plane_index() instead of storing the same index wothin omap_plane >> struct >> -

Re: [PATCH 06/19] drm/blend: Add a generic alpha property

2018-01-09 Thread Daniel Vetter
On Tue, Jan 09, 2018 at 02:53:22PM +0100, Maxime Ripard wrote: > On Tue, Jan 09, 2018 at 01:32:41PM +0100, Daniel Vetter wrote: > > On Tue, Jan 09, 2018 at 11:56:25AM +0100, Maxime Ripard wrote: > > > Some drivers duplicate the logic to create a property to store a per-plane > > > alpha. > > > > >

Re: [PATCH 1/2] drm/blend: Account also the primary plane of the crtc for normalized_zpos

2018-01-09 Thread Daniel Vetter
On Tue, Jan 09, 2018 at 03:40:36PM +0200, Laurent Pinchart wrote: > Hi Daniel, > > On Tuesday, 9 January 2018 14:42:55 EET Daniel Vetter wrote: > > On Fri, Dec 22, 2017 at 05:15:05PM +0200, Peter Ujfalusi wrote: > > > On 2017-12-22 12:12, Ville Syrjälä wrote: > > > > On Fri, Dec 22, 2017 at 11:16:

Re: [PATCH v5] drm/omap: plane zpos/zorder management improvements

2018-01-09 Thread Daniel Vetter
On Tue, Jan 09, 2018 at 04:18:48PM +0200, Peter Ujfalusi wrote: > Hi, > > On 2018-01-09 14:44, Daniel Vetter wrote: > >> Changes since v4: > >> - further simplify the zpos checking by using a mask and a single loop > >> - Commit message has been extended > >> > >> Changes since v3: > >> - Use drm_

Re: [RFC v2 3/8] drm: Export some ioctl functions

2018-01-09 Thread Laurent Pinchart
Hi Noralf, Thank you for the patch. On Thursday, 4 January 2018 00:21:05 EET Noralf Trønnes wrote: > Export the following functions so in-kernel users can allocate > dumb buffers: > - drm_file_alloc > - drm_file_free > - drm_prime_handle_to_fd_ioctl > - drm_mode_addfb2 > - drm_mode_create_dumb_io

Re: [RFC v2 2/8] drm/ioctl: Remove trailing whitespace

2018-01-09 Thread Laurent Pinchart
Hi Noralf, Thank you for the patch. On Thursday, 4 January 2018 00:21:04 EET Noralf Trønnes wrote: > Remove a couple of trailing spaces. > > Signed-off-by: Noralf Trønnes Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/drm_ioctl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletio

[Bug 104556] WARNING: CPU: 1 PID: 7288 at mm/slab_common.c:971 kmalloc_slab+0x5e/0x70

2018-01-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104556 --- Comment #5 from Paul Menzel --- (In reply to Christian König from comment #3) > Please add your dmesg as attachment and not as inline comment. Sorry, I’ll do so next time. -- You are receiving this mail because: You are the assignee for t

Re: [PATCH v2 4/6] drm/tinydrm/mipi-dbi: Add poweron-reset functions

2018-01-09 Thread Noralf Trønnes
Den 09.01.2018 02.38, skrev David Lechner: On 01/07/2018 11:44 AM, Noralf Trønnes wrote: Split out common poweron-reset functionality. Signed-off-by: Noralf Trønnes ---   drivers/gpu/drm/tinydrm/mi0283qt.c | 20 ++--   drivers/gpu/drm/tinydrm/mipi-dbi.c | 63 ++

Re: How to map depth=30 fb to XBGR instead of XRGB?

2018-01-09 Thread Ville Syrjälä
On Sun, Dec 31, 2017 at 01:03:39AM -0500, Ilia Mirkin wrote: > NVIDIA hardware, prior to Kepler, only supports XBGR2101010. However > drmAddFB with depth = 30 will use the mapping in > drm_mode_legacy_fb_format and pick the XRGB version of the format. > > One solution is to tell userspace "stop us

Re: How to map depth=30 fb to XBGR instead of XRGB?

2018-01-09 Thread Chris Wilson
Quoting Ville Syrjälä (2018-01-09 15:19:06) > On Sun, Dec 31, 2017 at 01:03:39AM -0500, Ilia Mirkin wrote: > > NVIDIA hardware, prior to Kepler, only supports XBGR2101010. However > > drmAddFB with depth = 30 will use the mapping in > > drm_mode_legacy_fb_format and pick the XRGB version of the for

Re: [PATCH 03/11] drm/bridge/synopsys: dw-hdmi: Enable workaround for v1.32a

2018-01-09 Thread Neil Armstrong
Hi, I think this question is for Jose. On 09/01/2018 13:56, Laurent Pinchart wrote: > Hi Jernej, > > Thank you for the patch. > > On Saturday, 30 December 2017 23:01:55 EET Jernej Skrabec wrote: >> Allwinner SoCs have dw hdmi controller v1.32a which exhibits same >> magenta line issue as i.MX6Q

[Bug 104216] Firefox quirks (black and/or white squares)

2018-01-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104216 --- Comment #8 from Germano Massullo --- (In reply to Marek Olšák from comment #6) > Have you tested the patch you linked? I applied the patch into a personal Fedora Copr repo https://copr.fedorainfracloud.org/coprs/germano/xorg_sRGB_patch_test

Re: [-next PATCH 3/4] treewide: Use DEVICE_ATTR_RO

2018-01-09 Thread Greg Kroah-Hartman
On Thu, Dec 21, 2017 at 11:34:10AM +0200, Sakari Ailus wrote: > Hi Joe, > > On Tue, Dec 19, 2017 at 10:15:08AM -0800, Joe Perches wrote: > > diff --git a/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c > > b/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c > > index a1c81c12718c..4338b8a

RE: [PATCH 2/3] drm: export gem dmabuf_ops for drivers to reuse

2018-01-09 Thread Li, Samuel
Yes, please hush this for me. Regards, Samuel Li > -Original Message- > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel > Vetter > Sent: Tuesday, January 09, 2018 4:22 AM > To: Koenig, Christian > Cc: Li, Samuel ; dri-devel@lists.freedesktop.org; amd- > g...@list

Re: [PATCH 04/11] drm/bridge/synopsys: dw-hdmi: Export some PHY related functions

2018-01-09 Thread Laurent Pinchart
Hello, On Tuesday, 9 January 2018 17:58:46 EET Jernej Škrabec wrote: > Dne torek, 09. januar 2018 ob 11:43:08 CET je Archit Taneja napisal(a): > > On 12/31/2017 02:31 AM, Jernej Skrabec wrote: > >> Parts of PHY code could be useful also for custom PHYs. For example, > >> Allwinner A83T has custom

Re: How to map depth=30 fb to XBGR instead of XRGB?

2018-01-09 Thread Daniel Vetter
On Tue, Jan 09, 2018 at 05:19:06PM +0200, Ville Syrjälä wrote: > On Sun, Dec 31, 2017 at 01:03:39AM -0500, Ilia Mirkin wrote: > > NVIDIA hardware, prior to Kepler, only supports XBGR2101010. However > > drmAddFB with depth = 30 will use the mapping in > > drm_mode_legacy_fb_format and pick the XRGB

Re: How to map depth=30 fb to XBGR instead of XRGB?

2018-01-09 Thread Daniel Vetter
On Tue, Jan 09, 2018 at 03:28:23PM +, Chris Wilson wrote: > Quoting Ville Syrjälä (2018-01-09 15:19:06) > > On Sun, Dec 31, 2017 at 01:03:39AM -0500, Ilia Mirkin wrote: > > > NVIDIA hardware, prior to Kepler, only supports XBGR2101010. However > > > drmAddFB with depth = 30 will use the mapping

[PATCH] drm/vmwgfx: Don't cache framebuffer maps

2018-01-09 Thread Thomas Hellstrom
Buffer objects need to be either pinned or reserved while a map is active, that's not the case here, so avoid caching the framebuffer map. This will cause increasing mapping activity mainly when we don't do page flipping. This fixes occasional garbage filled screens when the framebuffer has been e

Re: [PATCH 2/3] drm: export gem dmabuf_ops for drivers to reuse

2018-01-09 Thread Deucher, Alexander
I'll can push this and a few other misc patches today. Alex From: amd-gfx on behalf of Li, Samuel Sent: Tuesday, January 9, 2018 10:20 AM To: Daniel Vetter; Koenig, Christian Cc: amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org Subject: RE: [PATCH

Re: [PATCH 05/19] drm/vc4: Use the alpha format helper

2018-01-09 Thread Eric Anholt
Maxime Ripard writes: > Now that the core has a drm format helper to tell if a format embeds an > alpha component in it, let's use it. > > Cc: Eric Anholt > Signed-off-by: Maxime Ripard Reviewed-by: Eric Anholt signature.asc Description: PGP signature ___

Re: [PATCH 2/3] drm: export gem dmabuf_ops for drivers to reuse

2018-01-09 Thread Alex Deucher
On Tue, Jan 9, 2018 at 10:56 AM, Deucher, Alexander wrote: > I'll can push this and a few other misc patches today. > Pushed to drm-misc-next. Thanks, Alex > > Alex > > From: amd-gfx on behalf of Li, > Samuel > Sent: Tuesday, January 9, 2018 10:20 AM > To: D

Re: [PATCH] drm/atomic: Fix memleak on ERESTARTSYS during non-blocking commits

2018-01-09 Thread Alex Deucher
On Mon, Jan 8, 2018 at 4:30 PM, Harry Wentland wrote: > On 2018-01-04 02:47 PM, sunpeng...@amd.com wrote: >> From: "Leo (Sunpeng) Li" >> >> During a non-blocking commit, it is possible to return before the >> commit_tail work is queued (-ERESTARTSYS, for example). >> >> Since a reference on the c

[PATCH] drm/i915: Only disable HDCP when it's active

2018-01-09 Thread Sean Paul
Instead of always trying to disable HDCP. Only run hdcp_disable when the state is not UNDESIRED. This will catch cases where it's enabled and also cases where enable failed and the state is left in DESIRED mode. Note that things won't blow up if disable is attempted while already disabled, it's ju

[PATCH] drm/i915: Don't allow HDCP on PORT E/F

2018-01-09 Thread Sean Paul
Port E doesn't have HDCP support, and Port F is disabled. Don't setup the hdcp shim on those. Reviewed-by: Daniel Vetter Signed-off-by: Sean Paul --- drivers/gpu/drm/i915/intel_hdmi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/driv

Re: [PATCH] drm/bridge/synopsys: dsi: use common mipi_dsi_create_packet()

2018-01-09 Thread Brian Norris
Hi Philippe, On Tue, Jan 09, 2018 at 10:48:43AM +, Philippe CORNU wrote: > Hi Brian, > > And many thanks for implementing these TODOs. And thanks for adding them; it gave me a better option than just adding yet another switch case (MIPI_DSI_GENERIC_LONG_WRITE) ;) > On 01/06/2018 01:38 AM, B

[PATCH v2 2/2] drm/bridge/synopsys: dsi: handle endianness correctly in dw_mipi_dsi_write()

2018-01-09 Thread Brian Norris
We're filling the "remainder" word with little-endian data, then writing it out to IO registers with endian-correcting writel(). That probably won't work on big-endian systems. Let's mark the "remainder" variable as LE32 (since we fill it with memcpy()) and do the swapping explicitly. Some of thi

[PATCH] drm/bridge/synopsys: dsi: make dw_mipi_dsi_bridge_mode_set() static

2018-01-09 Thread Brian Norris
sparse complains: drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c:703:6: warning: symbol 'dw_mipi_dsi_bridge_mode_set' was not declared. Should it be static? Signed-off-by: Brian Norris --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[PATCH v2 1/2] drm/bridge/synopsys: dsi: use common mipi_dsi_create_packet()

2018-01-09 Thread Brian Norris
This takes care of 2 TODOs in this driver, by using the common DSI packet-marshalling code instead of our custom short/long write code. This both saves us some duplicated code and gets us free support for command types that weren't already part of our switch block (e.g., MIPI_DSI_GENERIC_LONG_WRITE

Re: [PATCH] drm/radeon: fill in rb backend map on evergreen/ni.

2018-01-09 Thread Roland Scheidegger
FWIW I was wrong that it was never filled in - when the backend map query was introduced, the data indeed got filled in. However that got lost very soon afterwards (over 6 years ago) by some fixes for backend map calculation. In any case, Reviewed-by: Roland Scheidegger Am 09.01.2018 um 04:43 sch

[PATCH libdrm] modetest: Fix to check return value of asprintf()

2018-01-09 Thread Seung-Woo Kim
There is warning about ignoring return value of 'asprintf'. Fix to check return value of asprintf(). Signed-off-by: Seung-Woo Kim --- tests/modetest/modetest.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c index

Re: [PATCH v2 4/6] drm/tinydrm/mipi-dbi: Add poweron-reset functions

2018-01-09 Thread David Lechner
On 01/09/2018 09:01 AM, Noralf Trønnes wrote: Den 09.01.2018 02.38, skrev David Lechner: On 01/07/2018 11:44 AM, Noralf Trønnes wrote: Split out common poweron-reset functionality. Signed-off-by: Noralf Trønnes ---   drivers/gpu/drm/tinydrm/mi0283qt.c | 20 ++--   drivers/gpu/drm/tiny

Re: [PATCH v2 6/6] drm/tinydrm: Embed the mode in tinydrm_connector

2018-01-09 Thread David Lechner
On 01/09/2018 08:05 AM, Noralf Trønnes wrote: Den 09.01.2018 11.08, skrev Daniel Vetter: On Mon, Jan 08, 2018 at 07:46:27PM -0600, David Lechner wrote: On 01/07/2018 11:44 AM, Noralf Trønnes wrote: Embed the mode in tinydrm_connector instead of doing an devm_ allocation. Remove unnecessary us

[PATCH] libdrm: intel/Android.mk: Filter libdrm_intel library requirements on x86

2018-01-09 Thread John Stultz
When building AOSP after updating libdrm project to the freedesktop/master branch, I've seen the following build errors: external/libdrm/intel/Android.mk: error: libdrm_intel (SHARED_LIBRARIES android-arm64) missing libpciaccess (SHARED_LIBRARIES android-arm64) You can set ALLOW_MISSING_DEPENDENCI

[RFC][PATCH 1/5] drm_hwcomposer: provide a common gralloc handle definition

2018-01-09 Thread John Stultz
From: Rob Herring EGL, gralloc, and HWC must all have a common definition of fd's and int's in native_handle_t to share the fd and width, height, format, etc. of a dmabuf. Move the definition into HWC so we aren't dependent on a specific gralloc implementation and so we don't have to create an i

[RFC][PATCH 2/5] drm_hwcomposer: glworker: Add build time options for certain shader feature names

2018-01-09 Thread John Stultz
In order to get the hikey960, which uses the mali bifrost driver working with drm_hwcomposer, its needed to tweak some extension and funciton names used in the shaders. Specifically: * GL_OES_EGL_image_external_essl3 instead of GL_OES_EGL_image_external * texture() instead of texture2D() Which

[RFC][PATCH 0/5] drm_hwcomposer: Changes to support HiKey/HiKey960

2018-01-09 Thread John Stultz
This patchset is an inital RFC I wanted to send out to get some early review and feedback. I've been working to enable the drm_hwcomposer for HiKey and HiKey960 boards in AOSP, and this patchset contains the required changes to the drm_hwcomposer code to get things working. I'm really quite naive

[RFC][PATCH 3/5] drm_hwcomposer: Add platformhisi buffer importer for hikey and hikey960

2018-01-09 Thread John Stultz
This allows for importing buffers allocated from the hikey and hikey960 gralloc implelementations. Change-Id: I81abdd4d1dc7d9f2ef31078c91679b532d3262fd Cc: Marissa Wall Cc: Sean Paul Cc: Dmitry Shmidt Cc: Robert Foss Cc: Matt Szczesiak Cc: Liviu Dudau Cc: David Hanna Cc: Rob Herring Signed

[RFC][PATCH 5/5] drm_hwcomposer: HACK: Fix tearing on hikey/hikey960

2018-01-09 Thread John Stultz
When using drm_hwcomposer with the hikey/hikey960 boards, the resulting display shows lots of tearing. I'm not much of an expert in how this code should work, but it seems that we never call sync_wait(), and thus don't seem to be handling the fences properly? I'm not sure. Anyway, in a daze, I st

[RFC][PATCH 4/5] drm_hwcomposer: HACK: force single plane

2018-01-09 Thread John Stultz
From: Rob Herring Change from Rob to force use of single plane. Without this we don't see anything on the screen. Suggestions for alternative solutions here would be greatly appreciated! Change-Id: Ic963c356ab1ef241d92fde6c890936b560f52051 Cc: Marissa Wall Cc: Sean Paul Cc: Dmitry Shmidt Cc

<    1   2