[PATCH] drm/exynos: remove unnecessary function declaration

2017-11-27 Thread Inki Dae
Removed exynos_drm_get_dma_device funtion declaration on top of exynos_drm_drv.c file. We can remove this declaration by moving the implementation of this function upwards. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 44 - 1 file changed

[PATCH] drm/exynos: remove unnecessary descrptions

2017-11-27 Thread Inki Dae
Removed two descriptions to 'da_start' and 'da_space_size' from exynos_drm_private structure. These members don't exist anymore. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_drv.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.h b

Re: RFC: page-flip with damage?

2017-11-27 Thread Daniel Vetter
On Mon, Nov 27, 2017 at 09:03:22AM +0100, Thomas Hellstrom wrote: > On 09/26/2017 10:18 AM, Daniel Vetter wrote: > > On Sun, Sep 24, 2017 at 07:41:45PM +0200, Thomas Hellstrom wrote: > > > Hi, list! > > > > > > Page flips, while efficient on real hardware, aren't that efficient in > > > other > >

[PATCH v7 1/7] fbcon: Add fbcon_rotate_hint to struct fb_info

2017-11-27 Thread Hans de Goede
On some hardware the LCD panel is not mounted upright in the casing, but upside-down or rotated 90 degrees. In this case we want the console to automatically be rotated to compensate. The fbdev-driver may know about the need to rotate. Add a new fbcon_rotate_hint field to struct fb_info, which get

[PATCH] drm: Fix modifiers_property kernel-doc comment

2017-11-27 Thread Hans de Goede
This fixes the following make kerneldocs messages: ./include/drm/drm_mode_config.h:772: warning: No description found for parameter 'modifiers_property' ./include/drm/drm_mode_config.h:772: warning: Excess struct member 'modifiers' description in 'drm_mode_config' Signed-off-by: Hans de Goede

[PATCH v7 6/7] efifb: Set info->fbcon_rotate_hint based on drm_get_panel_orientation_quirk

2017-11-27 Thread Hans de Goede
On some hardware the LCD panel is not mounted upright in the casing, but rotated by 90 degrees. In this case we want the console to automatically be rotated to compensate. The drm subsys has a quirk table for this, use the drm_get_panel_orientation_quirk function to get the panel orientation and s

[PATCH v7 2/7] drm: Add panel orientation quirks, v6.

2017-11-27 Thread Hans de Goede
Some x86 clamshell design devices use portrait tablet screens and a display engine which cannot rotate in hardware, so the firmware just leaves things as is and we cannot figure out that the display is oriented non upright from the hardware. So at least on x86, we need a quirk table for this. This

[PATCH v7 5/7] drm/i915: Add "panel orientation" property to the panel connector, v6.

2017-11-27 Thread Hans de Goede
Ideally we could use the VBT for this, that would be simple, in intel_dsi_init() check dev_priv->vbt.dsi.config->rotation, set connector->display_info.panel_orientation accordingly and call drm_connector_init_panel_orientation_property(), done. Unfortunately vbt.dsi.config->rotation is always 0 ev

[PATCH v7 3/7] drm: Add support for a panel-orientation connector property, v6

2017-11-27 Thread Hans de Goede
On some devices the LCD panel is mounted in the casing in such a way that the up/top side of the panel does not match with the top side of the device (e.g. it is mounted upside-down). This commit adds the necessary infra for lcd-panel drm_connector-s to have a "panel orientation" property to commu

[PATCH v7 7/7] fbcon: Remove dmi quirk table

2017-11-27 Thread Hans de Goede
This is now all handled in the drivers and communicated through fb_info.fbcon_rotate_hint. Signed-off-by: Hans de Goede --- drivers/video/fbdev/core/Makefile | 3 - drivers/video/fbdev/core/fbcon.c| 4 +- drivers/video/fbdev/core/fbcon.h| 6 -- drivers/vid

[PATCH v7 0/7] drm/fbdev: Panel orientation connector property support

2017-11-27 Thread Hans de Goede
Here is v7 of my series to add a "panel orientation" property to the drm-connector for the LCD panel to let userspace know about LCD panels which are not mounted upright, as well as detecting upside-down panels without needing quirks (like we do for 90 degree rotated screens). Bartlomiej, can we p

[PATCH 01/13] fbdev: show fbdev number for debugging

2017-11-27 Thread Michał Mirosław
Signed-off-by: Michał Mirosław --- drivers/video/fbdev/core/fbmem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/core/fbmem.c b/drivers/video/fbdev/core/fbmem.c index f741ba8df01b..30a18d4c9de4 100644 --- a/drivers/video/fbdev/core/fbmem.c +++ b/driv

[PATCH v7 4/7] drm/fb-helper: Apply panel orientation connector prop to the primary plane, v6.

2017-11-27 Thread Hans de Goede
Apply the "panel orientation" drm connector prop to the primary plane so that fbcon and fbdev using userspace programs display the right way up. Changes in v3: -Use a rotation member in struct drm_fb_helper_crtc and set that from drm_setup_crtcs instead of looping over all crtc's to find the righ

[PATCH 02/13] fbdev: add remove_conflicting_pci_framebuffers()

2017-11-27 Thread Michał Mirosław
Almost all drivers using remove_conflicting_framebuffers() wrap it with the same code. Extract common part from PCI drivers into separate remove_conflicting_pci_framebuffers(). Signed-off-by: Michał Mirosław --- drivers/video/fbdev/core/fbmem.c | 22 ++ include/drm/drm_fb_hel

[PATCH 03/13] drm/amdgpu: use simpler remove_conflicting_pci_framebuffers()

2017-11-27 Thread Michał Mirosław
Signed-off-by: Michał Mirosław --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 23 +-- 1 file changed, 1 insertion(+), 22 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c index dd2f060d62a8..b726222b7dd4 100644 --- a/d

[PATCH v2] drm/i915: Avoid enum conversion warning

2017-11-27 Thread Nick Desaulniers
Fixes the following enum conversion warning: drivers/gpu/drm/i915/intel_ddi.c:1481:30: error: implicit conversion from enumeration type 'enum port' to different enumeration type 'enum intel_dpll_id' [-Werror,-Wenum-conversion] enum intel_dpll_id pll_id = port; ~~

[PATCH 04/13] drm/bochs: use simpler remove_conflicting_pci_framebuffers()

2017-11-27 Thread Michał Mirosław
Signed-off-by: Michał Mirosław --- drivers/gpu/drm/bochs/bochs_drv.c | 18 +- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/drivers/gpu/drm/bochs/bochs_drv.c b/drivers/gpu/drm/bochs/bochs_drv.c index 7b20318483e4..c61b40c72b62 100644 --- a/drivers/gpu/drm/bochs/bo

Re: Regression in TTM driver w/Linus' master

2017-11-27 Thread Tobias Klausmann
On 11/24/17 3:54 PM, Daniel Vetter wrote: On Thu, Nov 23, 2017 at 03:24:38PM +0100, Tobias Klausmann wrote: On 11/23/17 2:58 AM, Dave Airlie wrote: On 23 November 2017 at 11:17, Laura Abbott wrote: Hi, Fedora QA testing reported a panic when booting up VMs using qmeu vga drivers (https://pa

AW: [PATCH 1/5] drm/panel: Add support for the EDT ETM0700G0BDH6

2017-11-27 Thread Türk , Jan
Hi Fabio, (and all others) > Von: Fabio Estevam [mailto:feste...@gmail.com] > Gesendet: Freitag, 24. November 2017 15:22 > Betreff: Re: [PATCH 1/5] drm/panel: Add support for the EDT ETM0700G0BDH6 > > Hi Jan, > > On Thu, Nov 23, 2017 at 1:18 PM, Türk, Jan wrote: > > Hi Fabio, > > > > I've used git

Re: [BUG] drm: vc4: refcount_t: increment on 0; use-after-free.

2017-11-27 Thread Kees Cook
On Wed, Nov 22, 2017 at 11:57 PM, Daniel Vetter wrote: > On Wed, Nov 22, 2017 at 07:21:00PM +0100, Boris Brezillon wrote: >> On Wed, 22 Nov 2017 19:13:09 +0100 >> Daniel Vetter wrote: >> >> > On Wed, Nov 22, 2017 at 6:51 PM, Boris Brezillon >> > wrote: >> > > Hi Stefan, >> > > >> > > On Wed, 22

Re: [PATCH] video/fbdev/stifb: Delete an error message for a failed memory allocation in stifb_init_fb()

2017-11-27 Thread Rolf Eike Beer
Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 24 Nov 2017 22:22:06 +0100 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/video/fbdev/stifb.c

[PATCH 11/13] drm/vc4: use simpler remove_conflicting_framebuffers(NULL)

2017-11-27 Thread Michał Mirosław
Use remove_conflicting_framebuffers(NULL) instead of open-coding it. Signed-off-by: Michał Mirosław --- drivers/gpu/drm/vc4/vc4_drv.c | 20 +--- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c index e3c29

Re: [PATCH] drm/stm: ltdc: add clut mode support

2017-11-27 Thread Peter Rosin
On 2017-11-24 14:54, Philippe CORNU wrote: > Hi Peter, > > On 11/13/2017 11:40 AM, Philippe CORNU wrote: >> Hi Peter, >> >> On 11/12/2017 01:31 PM, Peter Rosin wrote: >>> On 2017-11-10 17:12, Philippe CORNU wrote: Hi Peter, On 11/07/2017 05:34 PM, Peter Rosin wrote: > On 2017-11

Re: [PATCH v3] drm: bridge: synopsys/dw-hdmi: Enable cec clock

2017-11-27 Thread Pierre-Hugues Husson
Hi, >> On 11/20/2017 06:00 PM, Hans Verkuil wrote: >>> I didn't see this merged for 4.15, is it too late to include this? >>> All other changes needed to get CEC to work on rk3288 and rk3399 are all >>> merged. >> >> Sorry for the late reply. I was out last week. >> >> Dave recently sent the seco

[PATCH 08/13] drm/virtio: use simpler remove_conflicting_pci_framebuffers()

2017-11-27 Thread Michał Mirosław
Signed-off-by: Michał Mirosław --- drivers/gpu/drm/virtio/virtgpu_drm_bus.c | 24 +++- 1 file changed, 3 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_drm_bus.c b/drivers/gpu/drm/virtio/virtgpu_drm_bus.c index 7df8d0c9026a..115ed546ca4e 100644 --

[PATCH 12/13] drm/sun4i: use simpler remove_conflicting_framebuffers(NULL)

2017-11-27 Thread Michał Mirosław
Use remove_conflicting_framebuffers(NULL) instead of duplicating it. Signed-off-by: Michał Mirosław --- drivers/gpu/drm/sun4i/sun4i_drv.c | 18 +- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_drv.c b/drivers/gpu/drm/sun4i/sun4i_drv.c

[PATCH v4] drm: bridge: synopsys/dw-hdmi: Enable cec clock

2017-11-27 Thread Pierre-Hugues Husson
Support the "cec" optional clock. The documentation already mentions "cec" optional clock and it is used by several boards, but currently the driver doesn't enable it, thus preventing cec from working on those boards. And even worse: a /dev/cecX device will appear for those boards, but it won't be

Re: [PATCH 13/13] drm/tegra: kick out simplefb

2017-11-27 Thread Michał Mirosław
On Fri, Nov 24, 2017 at 09:50:50PM +0100, Thierry Reding wrote: > On Fri, Nov 24, 2017 at 06:53:34PM +0100, Michał Mirosław wrote: > > Kick out firmware fb when loading tegra driver. > Cool. Can you provide some background on how you tested this? What is > your firmware FB? That'd be useful informa

Re: glxgears on Etnaviv: couldn't get an RGB, Double-buffered visual

2017-11-27 Thread Alexey Brodkin
Hi Lucas, On Fri, 2017-11-24 at 18:11 +0100, Lucas Stach wrote: > Am Freitag, den 24.11.2017, 16:49 + schrieb Alexey Brodkin: > [...] > > > > > > > > Yes, a "core" in Vivante speak is a GPU with one DMA frontend. A > > > single > > > frontend can feed both 3D and 2D acceleration engines behi

glxgears on Etnaviv: couldn't get an RGB, Double-buffered visual

2017-11-27 Thread Alexey Brodkin
Hello, Being in the middle of bring-up of the new board with Vivante GPU (HSDK namely, see  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arc/plat-hsdk) I was looking at simple 3D test apps to see how Etnaviv works on the hardware. So far I was able to get kmscube w

[PATCH 05/13] drm/cirrus: use simpler remove_conflicting_pci_framebuffers()

2017-11-27 Thread Michał Mirosław
Signed-off-by: Michał Mirosław --- drivers/gpu/drm/cirrus/cirrus_drv.c | 23 +-- 1 file changed, 1 insertion(+), 22 deletions(-) diff --git a/drivers/gpu/drm/cirrus/cirrus_drv.c b/drivers/gpu/drm/cirrus/cirrus_drv.c index 69c4e352dd78..85ed8657c862 100644 --- a/drivers/gpu/d

[PATCH 13/13] drm/tegra: kick out simplefb

2017-11-27 Thread Michał Mirosław
Kick out firmware fb when loading tegra driver. Signed-off-by: Michał Mirosław --- drivers/gpu/drm/tegra/drm.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c index 943bdf88c4a2..1ec66ae29839 100644 --- a/drivers/gpu/drm/tegra/drm

[PATCH 06/13] drm/mgag200: use simpler remove_conflicting_pci_framebuffers()

2017-11-27 Thread Michał Mirosław
Remove duplicated call, while at it. Signed-off-by: Michał Mirosław --- drivers/gpu/drm/mgag200/mgag200_drv.c | 21 + drivers/gpu/drm/mgag200/mgag200_main.c | 9 - 2 files changed, 1 insertion(+), 29 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.c

Re: glxgears on Etnaviv: couldn't get an RGB, Double-buffered visual

2017-11-27 Thread Alexey Brodkin
Hi Lucas, On Fri, 2017-11-24 at 17:11 +0100, Lucas Stach wrote: > Hi Alexey, > > Am Freitag, den 24.11.2017, 16:02 + schrieb Alexey Brodkin: > > > > Hello, > > > > Being in the middle of bring-up of the new board with Vivante GPU (HSDK > > namely, > > see  > > https://urldefense.proofpoint

Re: glxgears on Etnaviv: couldn't get an RGB, Double-buffered visual

2017-11-27 Thread Alexey Brodkin
Hi Lucas, On Fri, 2017-11-24 at 17:38 +0100, Lucas Stach wrote: > Am Freitag, den 24.11.2017, 16:25 + schrieb Alexey Brodkin: > > > > Hi Lucas, > > > > On Fri, 2017-11-24 at 17:11 +0100, Lucas Stach wrote: > > > > > > Hi Alexey, > > > > > > Am Freitag, den 24.11.2017, 16:02 + schrieb A

[PATCH 09/13] staging: sm750fb: use simpler remove_conflicting_pci_framebuffers()

2017-11-27 Thread Michał Mirosław
Signed-off-by: Michał Mirosław --- drivers/staging/sm750fb/sm750.c | 22 +- 1 file changed, 1 insertion(+), 21 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index 67207b0554cd..0590fc45c493 100644 --- a/drivers/staging/sm750fb/sm7

[PATCH 00/13] remove_conflicting_framebuffers() cleanup

2017-11-27 Thread Michał Mirosław
This series cleans up duplicated code for replacing firmware FB driver with proper DRI driver and adds handover support to Tegra driver. The last patch is here because it uses new semantics of remove_conflicting_framebuffers() from this series. This can be considered independently, though. --- M

[PATCH 10/13] fbdev: allow apertures == NULL in remove_conflicting_framebuffers()

2017-11-27 Thread Michał Mirosław
Interpret (otherwise-invalid) NULL apertures argument to mean all-memory range. This will allow to remove several duplicates of this code from drivers in following patches. Signed-off-by: Michał Mirosław --- drivers/video/fbdev/core/fbmem.c | 14 ++ 1 file changed, 14 insertions(+)

Re: RFC: page-flip with damage?

2017-11-27 Thread Thomas Hellstrom
On 09/26/2017 10:18 AM, Daniel Vetter wrote: On Sun, Sep 24, 2017 at 07:41:45PM +0200, Thomas Hellstrom wrote: Hi, list! Page flips, while efficient on real hardware, aren't that efficient in other situations, like for virtual devices with local, or even worse, remote desktops. We might ending

Re: Regression in TTM driver w/Linus' master

2017-11-27 Thread Tobias Klausmann
On 11/24/17 4:35 PM, Christian König wrote: Am 24.11.2017 um 16:17 schrieb Tobias Klausmann: On 11/24/17 3:54 PM, Daniel Vetter wrote: On Thu, Nov 23, 2017 at 03:24:38PM +0100, Tobias Klausmann wrote: On 11/23/17 2:58 AM, Dave Airlie wrote: On 23 November 2017 at 11:17, Laura Abbott wrote:

[PATCH 07/13] drm/radeon: use simpler remove_conflicting_pci_framebuffers()

2017-11-27 Thread Michał Mirosław
Signed-off-by: Michał Mirosław --- drivers/gpu/drm/radeon/radeon_drv.c | 23 +-- 1 file changed, 1 insertion(+), 22 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c index 31dd04f6baa1..49f51b17ae81 100644 --- a/drivers/gpu/d

[PATCH] drm/sun4i: use sun4i_tcon_of_table to check if a device node is a TCON

2017-11-27 Thread Chen-Yu Tsai
The sun4i DRM driver maintains a list of compatible strings it uses to check if a device node within the display component graph is a TCON. The TCON driver also has this list, used to bind the TCON driver to the device. These two lists are identical. Instead of maintaining two identical lists, exp

Re: PROBLEM: Asus C201 video mode problems on HDMI hotplug (regression)

2017-11-27 Thread Laurent Pinchart
Hi Archit, Thank you for handling this, and sorry for missing the original bug report (and for breaking this in the first place). On Monday, 27 November 2017 06:05:03 EET Archit Taneja wrote: > On 11/16/2017 11:58 AM, Nick Bowler wrote: > > On 2017-11-05 11:41 -0500, Nick Bowler wrote: > >> On 2

[PATCH] video: fsl-diu-fb: Delete an error message for a failed memory allocation in fsl_diu_init()

2017-11-27 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 27 Nov 2017 09:56:09 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/video/fbdev/fsl-diu-fb.c | 6 +- 1 file changed, 1 inserti

[PATCH] video: fb_ddc: Delete an error message for a failed memory allocation in fb_do_probe_ddc_edid()

2017-11-27 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 27 Nov 2017 10:12:26 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/video/fbdev/core/fb_ddc.c | 5 + 1 file changed, 1 inserti

[Bug 103924] [CI] igt@perf_pmu@other-* - fail - Test assertion failure function read_other - Failed assertion: fd >= 0

2017-11-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103924 Chris Wilson changed: What|Removed |Added Resolution|--- |FIXED QA Contact|intel-gfx-bugs@

[PATCH] video: adv7393fb: Delete two error messages for a failed memory allocation in bfin_adv7393_fb_probe()

2017-11-27 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 27 Nov 2017 10:33:19 +0100 Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/video/fbdev/bfin_adv7393fb.c | 5 + 1 file changed, 1 insert

[PATCH 0/2] drm/tegra: Sanitize format modifiers

2017-11-27 Thread Thierry Reding
From: Thierry Reding Hi, This series is preparatory work in order to enable format modifiers on both Tegra and Nouveau drivers to allow drivers to exchange tiling mode information. I also have the corresponding libdrm changes that I can send out as soon as these patches have been merged. Techni

[PATCH 1/2] drm/fourcc: Fix fourcc_mod_code() definition

2017-11-27 Thread Thierry Reding
From: Thierry Reding Avoid compiler warnings when the val parameter is an expression. Signed-off-by: Thierry Reding --- include/uapi/drm/drm_fourcc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h index 3ad838d3

[PATCH 2/2] drm/tegra: Sanitize format modifiers

2017-11-27 Thread Thierry Reding
From: Thierry Reding The existing format modifier definitions were merged prematurely, and recent work has unveiled that the definitions are suboptimal in several ways: - The format specifiers, except for one, are not Tegra specific, but the names don't reflect that. - The number space i

[GIT PULL v2] hdlcd: fixes for drm-next

2017-11-27 Thread Liviu Dudau
On Fri, Nov 24, 2017 at 04:10:14PM +, Liviu Dudau wrote: Hi Dave, I've managed to push one of the patches without my Signed-off-by, Stephen caught that, so I'm sending a v2. Cleaning up the backlog of patches that I have in my tree, they have all been baking in linux-next for weeks. Minor fix

Re: RFC: page-flip with damage?

2017-11-27 Thread Thomas Hellstrom
On 11/27/2017 09:25 AM, Daniel Vetter wrote: On Mon, Nov 27, 2017 at 09:03:22AM +0100, Thomas Hellstrom wrote: On 09/26/2017 10:18 AM, Daniel Vetter wrote: On Sun, Sep 24, 2017 at 07:41:45PM +0200, Thomas Hellstrom wrote: Hi, list! Page flips, while efficient on real hardware, aren't that eff

[PATCH 02/13] drm/tegra: dsi: Move register definitions into a table

2017-11-27 Thread Thierry Reding
From: Thierry Reding After commit 75af8fa7fd47 ("drm/tegra: dsi: Trace register accesses"), the debugfs register dump implementation causes excessive stack usage and can result in build warnings. To fix this, move the register definitions into a table and iterate over the table while dumping the

[PATCH 00/13] drm/tegra: Miscellaneous cleanups

2017-11-27 Thread Thierry Reding
From: Thierry Reding This series has some cleanup patches to fix up various, mostly minor issues with the Tegra DRM driver. Patches 1-4 move register definitions into a table, which is necessary in order to prevent the stack from growing excessively large in the debugfs support. Patches 5-10 mo

[PATCH 01/13] drm/tegra: dc: Move register definitions into a table

2017-11-27 Thread Thierry Reding
From: Thierry Reding After commit 67e04d1ab19b ("drm/tegra: dc: Trace register accesses"), the debugfs register dump implementation causes excessive stack usage and can result in build warnings. To fix this, move the register definitions into a table and iterate over the table while dumping the r

[PATCH 04/13] drm/tegra: sor: Move register definitions into a table

2017-11-27 Thread Thierry Reding
From: Thierry Reding After commit 932f6529139e ("drm/tegra: sor: Trace register accesses"), the debugfs register dump implementation causes excessive stack usage and can result in build warnings. To fix this, move the register definitions into a table and iterate over the table while dumping the

[PATCH 03/13] drm/tegra: hdmi: Move register definitions into a table

2017-11-27 Thread Thierry Reding
From: Thierry Reding After commit 07a8aab89927 ("drm/tegra: hdmi: Trace register accesses"), the debugfs register dump implementation causes excessive stack usage and can result in build warnings. To fix this, move the register definitions into a table and iterate over the table while dumping the

[PATCH 06/13] drm/tegra: dc: Register debugfs in ->late_register()

2017-11-27 Thread Thierry Reding
From: Thierry Reding The ->late_register() and ->early_unregister() callbacks are called at the right time to make sure userspace only accesses interfaces when it should. Move debugfs registration and unregistration to these callback functions to avoid potential races with userspace. Signed-off-

[PATCH 07/13] drm/tegra: dsi: Register debugfs in ->late_register()

2017-11-27 Thread Thierry Reding
From: Thierry Reding The ->late_register() and ->early_unregister() callbacks are called at the right time to make sure userspace only accesses interfaces when it should. Move debugfs registration and unregistration to these callback functions to avoid potential races with userspace. Signed-off-

[PATCH 11/13] drm/tegra: Do not wrap lines unnecessarily

2017-11-27 Thread Thierry Reding
From: Thierry Reding The tegra_drm_alloc() function signature fits on a single line, no need to wrap it. Signed-off-by: Thierry Reding --- drivers/gpu/drm/tegra/drm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c

[PATCH 05/13] drm/tegra: dc: Reshuffle some code

2017-11-27 Thread Thierry Reding
From: Thierry Reding Reshuffle some code so that functions are defined closer to where they are used. Signed-off-by: Thierry Reding --- drivers/gpu/drm/tegra/dc.c | 152 ++--- 1 file changed, 76 insertions(+), 76 deletions(-) diff --git a/drivers/gpu/dr

[PATCH 13/13] drm/tegra: dc: Support background color

2017-11-27 Thread Thierry Reding
From: Thierry Reding Starting with Tegra124, the interface to set the background color (the value generated for pixels that are not sourced from any window) is via a different register. Earlier generations called this the border color. Reverse the feature flag and assume that IP revisions that do

[PATCH 08/13] drm/tegra: hdmi: Register debugfs in ->late_register()

2017-11-27 Thread Thierry Reding
From: Thierry Reding The ->late_register() and ->early_unregister() callbacks are called at the right time to make sure userspace only accesses interfaces when it should. Move debugfs registration and unregistration to these callback functions to avoid potential races with userspace. Signed-off-

[PATCH 09/13] drm/tegra: sor: Root debugfs files at the connector

2017-11-27 Thread Thierry Reding
From: Thierry Reding Rather create new files within the top-level DRM device's debugfs node, add the SOR specific files to the connector's debugfs node. This avoids the need to come up with subdirectory names and is also more intuitive. Signed-off-by: Thierry Reding --- drivers/gpu/drm/tegra/s

[PATCH 10/13] drm/tegra: sor: Register debugfs in ->late_register()

2017-11-27 Thread Thierry Reding
From: Thierry Reding The ->late_register() and ->early_unregister() callbacks are called at the right time to make sure userspace only accesses interfaces when it should. Move debugfs registration and unregistration to these callback functions to avoid potential races with userspace. Signed-off-

[PATCH 12/13] drm/tegra: vic: Properly align arguments

2017-11-27 Thread Thierry Reding
From: Thierry Reding Properly align function arguments on subsequent lines with the first argument on the first line. Signed-off-by: Thierry Reding --- drivers/gpu/drm/tegra/vic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tegra/vic.c b/drivers/gpu/drm/

Re: RFC: page-flip with damage?

2017-11-27 Thread Daniel Vetter
On Mon, Nov 27, 2017 at 10:59:49AM +0100, Thomas Hellstrom wrote: > On 11/27/2017 09:25 AM, Daniel Vetter wrote: > > On Mon, Nov 27, 2017 at 09:03:22AM +0100, Thomas Hellstrom wrote: > > > On 09/26/2017 10:18 AM, Daniel Vetter wrote: > > > > On Sun, Sep 24, 2017 at 07:41:45PM +0200, Thomas Hellstro

[PATCH 00/12] drm/tegra: Basic Tegra186 support

2017-11-27 Thread Thierry Reding
From: Thierry Reding Hi, this series adds support for display and HDMI on Tegra186. The initial 6 patches are preparatory work to move code around and make the subsequent patches easier to review. Patch 7 introduces the display hub driver which controls resources shared between all display cont

[PATCH 02/12] drm/tegra: dc: Remove duplicate plane funcs

2017-11-27 Thread Thierry Reding
From: Thierry Reding Both tegra_primary_plane_funcs and tegra_cursor_plane_funcs are identical. Get rid of the duplicate and use one set of function pointers for all planes. Signed-off-by: Thierry Reding --- drivers/gpu/drm/tegra/dc.c | 15 +++ 1 file changed, 3 insertions(+), 12 d

[PATCH 03/12] drm/tegra: dc: Remove tegra_overlay_plane_destroy()

2017-11-27 Thread Thierry Reding
From: Thierry Reding This function is a simple wrapper around tegra_plane_destroy(), so it can be dropped. Signed-off-by: Thierry Reding --- drivers/gpu/drm/tegra/dc.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/d

[PATCH 05/12] drm/tegra: dc: Move state definition to header

2017-11-27 Thread Thierry Reding
From: Thierry Reding Move the display controller state definition to the header file so that it can be referenced by other files. Signed-off-by: Thierry Reding --- drivers/gpu/drm/tegra/dc.c | 18 -- drivers/gpu/drm/tegra/dc.h | 18 ++ 2 files changed, 18 insert

[PATCH 06/12] drm/tegra: Move common plane code to separate file

2017-11-27 Thread Thierry Reding
From: Thierry Reding Subsequent patches will add support for Tegra186 which has a different architecture and needs different plane code but which can share a lot of code with earlier Tegra support. Signed-off-by: Thierry Reding --- drivers/gpu/drm/tegra/Makefile | 1 + drivers/gpu/drm/tegra/

[PATCH 04/12] drm/tegra: dc: Remove duplicate plane funcs

2017-11-27 Thread Thierry Reding
From: Thierry Reding Both tegra_overlay_plane_funcs is identical to tegra_plane_funcs. Get rid of the duplicate and use one set of function pointers for all planes. Signed-off-by: Thierry Reding --- drivers/gpu/drm/tegra/dc.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) d

[PATCH 08/12] drm/tegra: dc: Add Tegra186 support

2017-11-27 Thread Thierry Reding
From: Thierry Reding The display architecture has changed in several signifcant ways with the new Tegra186 SoC. Display controllers are a completely different design, but have been given a frontend that simulates the register interface for earlier chips. Unfortunately the frontend isn't complete

[PATCH 01/12] drm/tegra: dc: Remove tegra_primary_plane_destroy()

2017-11-27 Thread Thierry Reding
From: Thierry Reding This function is a simple wrapper around tegra_plane_destroy(), so it can be dropped. Signed-off-by: Thierry Reding --- drivers/gpu/drm/tegra/dc.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/d

[PATCH 07/12] drm/tegra: Add Tegra186 display hub support

2017-11-27 Thread Thierry Reding
From: Thierry Reding The display architecture has changed in several significant ways with the new Tegra186 SoC. Shared between all display controllers is a set of common resources referred to as the display hub. The hub generates accesses to memory and feeds them into various composition pipelin

[PATCH 11/12] drm/tegra: sor: Add Tegra186 support

2017-11-27 Thread Thierry Reding
From: Thierry Reding The SOR found on Tegra186 is very similar to the one found on Tegra210 and earlier. However, due to some changes in the display architecture, some programming sequences have changed and some register have moved around. Signed-off-by: Thierry Reding --- drivers/gpu/drm/tegr

[PATCH 12/12] drm/tegra: sor: Support HDMI 2.0 modes

2017-11-27 Thread Thierry Reding
From: Thierry Reding Signed-off-by: Thierry Reding --- drivers/gpu/drm/tegra/sor.c | 121 +--- drivers/gpu/drm/tegra/sor.h | 4 ++ 2 files changed, 119 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/tegra/sor.c b/drivers/gpu/drm/tegra/sor.c

[PATCH 10/12] drm/tegra: sor: Parameterize register offsets

2017-11-27 Thread Thierry Reding
From: Thierry Reding Future Tegra generations have an increased number of display controllers that can drive individual SORs. In order to support that, the offset and layout of some registers has changed in backwards-incompatible ways. Use parameterized register offsets to support this. Signed-o

[PATCH 09/12] drm/tegra: Support ARGB and ABGR formats

2017-11-27 Thread Thierry Reding
From: Thierry Reding These formats can easily be supported on all generations of Tegra. Note that the XRGB and XBGR formats that we supported were in fact using the ARGB and ABGR Tegra formats. This happened to work in cases where no alpha was being considered. This change is also a fix for thos

[PATCH] gpu: host1x: Cleanup on initialization failure

2017-11-27 Thread Thierry Reding
From: Thierry Reding When an error happens during the initialization of one of the sub- devices, make sure to properly cleanup all sub-devices that have been initialized up to that point. Signed-off-by: Thierry Reding --- drivers/gpu/host1x/bus.c | 11 +-- 1 file changed, 9 insertions(

Re: Build regressions/improvements in v4.15-rc1

2017-11-27 Thread Geert Uytterhoeven
On Mon, Nov 27, 2017 at 11:01 AM, Geert Uytterhoeven wrote: > Below is the list of build error/warning regressions/improvements in > v4.15-rc1[1] compared to v4.14[2]. > > Summarized: > - build errors: +2/-5 > [1] > http://kisskb.ellerman.id.au/kisskb/head/4fbd8d194f06c8a3fd2af1ce560ddb31f7ec8

Re: [PATCH v2] drm/atomic: Use DRM_DEBUG_KMS instead of DRM_DEBUG_ATOMIC in error paths

2017-11-27 Thread Daniel Vetter
On Fri, Nov 24, 2017 at 06:13:56PM +0200, Ville Syrjälä wrote: > On Wed, Nov 15, 2017 at 08:38:41PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > DRM_DEBUG_ATOMIC generates a lot of noise that no one normally cares > > about. However error paths everyone cares about, so hiding thea

[PATCH] video: bf54x-lq043fb: Delete an error message for a failed memory allocation in bfin_bf54x_probe()

2017-11-27 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 27 Nov 2017 11:04:22 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/video/fbdev/bf54x-lq043fb.c | 3 --- 1 file changed, 3 deletio

Re: [PATCH v2] drm/i915: Avoid enum conversion warning

2017-11-27 Thread Daniel Vetter
On Sun, Nov 26, 2017 at 07:49:14PM -0800, Nick Desaulniers wrote: > Fixes the following enum conversion warning: > > drivers/gpu/drm/i915/intel_ddi.c:1481:30: error: implicit conversion > from enumeration type 'enum port' to different enumeration type 'enum > intel_dpll_id' [-Werror,-Wenum-convers

Re: [PATCH 09/13] staging: sm750fb: use simpler remove_conflicting_pci_framebuffers()

2017-11-27 Thread Daniel Vetter
On Fri, Nov 24, 2017 at 06:53:33PM +0100, Michał Mirosław wrote: > Signed-off-by: Michał Mirosław > --- Why exactly do we have an fbdev driver in staging? Afaiui fbdev is entirely closed for new drivers (pls convert to an atomic drm driver instead, it likely will be smaller even). That's even wo

[Bug 103769] Unity based games do not start

2017-11-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103769 --- Comment #4 from Nicolai Hähnle --- Thanks for the report. Is this still an issue? The traces look subtly different... Do you have backtraces with symbols? Make sure you compile Mesa with debug symbols enabled. -- You are receiving this ma

[Bug 103917] [gfx9/Vega] Performance regression in master, 17.3 works fine

2017-11-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103917 --- Comment #1 from Michel Dänzer --- (In reply to Vedran Miletić from comment #0) > I tried to bisect, but wasn't able to figure out what commit exactly is > causing the problem. What was the problem? Were you able to narrow it down at least?

Re: [PATCH 02/13] fbdev: add remove_conflicting_pci_framebuffers()

2017-11-27 Thread Daniel Vetter
On Fri, Nov 24, 2017 at 06:53:31PM +0100, Michał Mirosław wrote: > Almost all drivers using remove_conflicting_framebuffers() wrap it with > the same code. Extract common part from PCI drivers into separate > remove_conflicting_pci_framebuffers(). > > Signed-off-by: Michał Mirosław Since the onl

[Bug 103817] [bisected] Heavy flickering in Wine

2017-11-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103817 --- Comment #2 from Nicolai Hähnle --- Thanks for the report. Do you see anything in dmesg while the flickering is happening? -- You are receiving this mail because: You are the assignee for the bug.

Re: [PATCH 10/13] fbdev: allow apertures == NULL in remove_conflicting_framebuffers()

2017-11-27 Thread Daniel Vetter
On Fri, Nov 24, 2017 at 06:53:33PM +0100, Michał Mirosław wrote: > Interpret (otherwise-invalid) NULL apertures argument to mean all-memory > range. This will allow to remove several duplicates of this code from > drivers in following patches. > > Signed-off-by: Michał Mirosław > --- > drivers/v

Re: [PATCH 00/13] remove_conflicting_framebuffers() cleanup

2017-11-27 Thread Daniel Vetter
On Fri, Nov 24, 2017 at 06:53:25PM +0100, Michał Mirosław wrote: > This series cleans up duplicated code for replacing firmware FB > driver with proper DRI driver and adds handover support to > Tegra driver. > > The last patch is here because it uses new semantics of > remove_conflicting_framebuff

[Bug 100726] [REGRESSION][BISECTED] Severe flickering with an R9 290

2017-11-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100726 Michel Dänzer changed: What|Removed |Added Attachment #135725|text/x-log |text/plain mime type|

[Bug 103817] [bisected] Heavy flickering in Wine

2017-11-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103817 Nicolai Hähnle changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 103808] [radeonsi, bisected] World of Warcraft scribbling all over screen

2017-11-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103808 Nicolai Hähnle changed: What|Removed |Added CC||bartos.p...@gmail.com --- Comment #4 f

Re: [PATCH 00/13] remove_conflicting_framebuffers() cleanup

2017-11-27 Thread Thierry Reding
On Mon, Nov 27, 2017 at 11:30:44AM +0100, Daniel Vetter wrote: > On Fri, Nov 24, 2017 at 06:53:25PM +0100, Michał Mirosław wrote: > > This series cleans up duplicated code for replacing firmware FB > > driver with proper DRI driver and adds handover support to > > Tegra driver. > > > > The last pa

[Bug 100726] [REGRESSION][BISECTED] Severe flickering with an R9 290

2017-11-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100726 --- Comment #6 from Michel Dänzer --- None of those commits look even remotely related, so I'm afraid you still incorrectly labelled at least one bad commit as good. -- You are receiving this mail because: You are the assignee for the bug.

Re: [PATCH 1/2] drm/fourcc: Fix fourcc_mod_code() definition

2017-11-27 Thread Daniel Vetter
On Mon, Nov 27, 2017 at 10:39:47AM +0100, Thierry Reding wrote: > From: Thierry Reding > > Avoid compiler warnings when the val parameter is an expression. > > Signed-off-by: Thierry Reding Reviewed-by: Daniel Vetter > --- > include/uapi/drm/drm_fourcc.h | 2 +- > 1 file changed, 1 insertio

[Bug 103838] Random segfaults in applications from radeonsi_dri.so

2017-11-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103838 --- Comment #3 from Nicolai Hähnle --- Thanks for the report. Maybe try a clean rebuild? Failing that, please provide a backtrace with debug symbols, otherwise there's no hope of fixing this if it is a real bug. -- You are receiving this mail

Re: [PATCH 2/2] drm/tegra: Sanitize format modifiers

2017-11-27 Thread Daniel Vetter
On Mon, Nov 27, 2017 at 10:39:48AM +0100, Thierry Reding wrote: > From: Thierry Reding > > The existing format modifier definitions were merged prematurely, and > recent work has unveiled that the definitions are suboptimal in several > ways: > > - The format specifiers, except for one, are no

  1   2   3   >