[PATCH v5 3/7] drm: Add support for a panel-orientation connector property

2017-11-06 Thread Hans de Goede
On some devices the LCD panel is mounted in the casing in such a way that the up/top side of the panel does not match with the top side of the device (e.g. it is mounted upside-down). This commit adds the necessary infra for lcd-panel drm_connector-s to have a "panel orientation" property to commu

Re: [PATCH 08/10] drm/tegra: Implement dynamic channel allocation model

2017-11-06 Thread Dmitry Osipenko
On 05.11.2017 14:01, Mikko Perttunen wrote: > In the traditional channel allocation model, a single hardware channel > was allocated for each client. This is simple from an implementation > perspective but prevents use of hardware scheduling. > > This patch implements a channel allocation model wh

[PATCH v5 4/7] drm/fb-helper: Apply panel orientation connector prop to the primary plane

2017-11-06 Thread Hans de Goede
Apply the "panel orientation" drm connector prop to the primary plane so that fbcon and fbdev using userspace programs display the right way up. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=94894 Signed-off-by: Hans de Goede --- Changes in v2: -New patch in v2 of this patch-set Changes in

Re: [PATCH 04/10] gpu: host1x: Lock classes during job submission

2017-11-06 Thread Dmitry Osipenko
On 05.11.2017 14:01, Mikko Perttunen wrote: > Host1x has a feature called MLOCKs which allow a certain class > (~HW unit) to be locked (in the mutex sense) and unlocked during > command execution, preventing other channels from accessing the > class while it is locked. This is necessary to prevent

Re: [PATCH] drm/vc4: Convert timers to use timer_setup()

2017-11-06 Thread Kees Cook
On Mon, Oct 30, 2017 at 4:49 PM, Eric Anholt wrote: > Kees Cook writes: > >> In preparation for unconditionally passing the struct timer_list pointer to >> all timer callbacks, switch to using the new timer_setup() and from_timer() >> to pass the timer pointer explicitly. > > Reviewed and applied

[PATCH v5 6/7] efifb: Set info->fbcon_rotate_hint based on drm_get_panel_orientation_quirk

2017-11-06 Thread Hans de Goede
On some hardware the LCD panel is not mounted upright in the casing, but rotated by 90 degrees. In this case we want the console to automatically be rotated to compensate. The drm subsys has a quirk table for this, use the drm_get_panel_orientation_quirk function to get the panel orientation and s

Re: PROBLEM: Asus C201 video mode problems on HDMI hotplug (regression)

2017-11-06 Thread Nick Bowler
Hi, I completed bisecting this issue. See below. On 2017-11-02, Nick Bowler wrote: > ~50% of the time after a hotplug, there is a vertical pink bar on the > left of the display area and audio is not working at all. According to > the sink device the display size is 1282x720 which seems pretty

Re: [PATCH 10/10] gpu: host1x: Optionally block when acquiring channel

2017-11-06 Thread Dmitry Osipenko
On 05.11.2017 14:01, Mikko Perttunen wrote: > Add an option to host1x_channel_request to interruptibly wait for a > free channel. This allows IOCTLs that acquire a channel to block > the userspace. > Wouldn't it be more optimal to request channel and block after job's pining, when all patching an

Re: [PATCH v3] display: panel: Add Mitsubishi aa070mc01 display support (800x480)

2017-11-06 Thread Lukasz Majewski
Dear All, > This commit adds support for Mitsubishi aa070mc01 TFT panel working > with 8 bit ISP mode (pin 19 "mode" HIGH for 20 pin TFT connector). Gentle ping... > > Signed-off-by: Lukasz Majewski > --- > Changes for v2: > - Place the code sorted alphabetically > - Add missing ./Documentatio

GM107GLM: kernel oops during link training when ior becomes NULL

2017-11-06 Thread Pavel Roskin
Hello! I'm using Dell Precision P7510 with up-to-date Fedora 27. Everything was working fine when I had two identical monitors (Dell 24") connected to the dock with DisplayPort cables. Various issues started when I replaced one of the monitors with a larger Dell 34" monitor. I could work them arou

[PATCH v5 5/7] drm/i915: Add "panel orientation" property to the panel connector

2017-11-06 Thread Hans de Goede
Ideally we could use the VBT for this, that would be simple, in intel_dsi_init() check dev_priv->vbt.dsi.config->rotation, set connector->display_info.panel_orientation accordingly and call drm_connector_init_panel_orientation_property(), done. Unfortunately vbt.dsi.config->rotation is always 0 ev

[PATCH v5 0/7] drm/fbdev: Panel orientation connector property support

2017-11-06 Thread Hans de Goede
Hi All, Here is v5 of my series to add a "panel orientation" property to the drm-connector for the LCD panel to let userspace know about LCD panels which are not mounted upright, as well as detecting upside-down panels without needing quirks (like we do for 90 degree rotated screens). New in v5:

Re: [PATCH] display: panel: Add Tianma tm070rvhg71 display support (800x480)

2017-11-06 Thread Lukasz Majewski
Hi Rob, > Hi Rob, > > > On Sat, Oct 21, 2017 at 12:10:03AM +0200, Lukasz Majewski wrote: > > > Signed-off-by: Lukasz Majewski > > > --- > > > .../bindings/display/panel/tianma,tm070rvhg71.txt | 7 ++ > > > drivers/gpu/drm/panel/panel-simple.c | 27 > > > +++

[PATCH v5 1/7] fbcon: Add fbcon_rotate_hint to struct fb_info

2017-11-06 Thread Hans de Goede
On some hardware the LCD panel is not mounted upright in the casing, but upside-down or rotated 90 degrees. In this case we want the console to automatically be rotated to compensate. The fbdev-driver may know about the need to rotate. Add a new fbcon_rotate_hint field to struct fb_info, which get

[PATCH v5 2/7] drm: Add panel orientation quirks

2017-11-06 Thread Hans de Goede
Some x86 clamshell design devices use portrait tablet screens and a display engine which cannot rotate in hardware, so the firmware just leaves things as is and we cannot figure out that the display is oriented non upright from the hardware. So at least on x86, we need a quirk table for this. This

[PATCH v5 7/7] fbcon: Remove dmi quirk table

2017-11-06 Thread Hans de Goede
This is now all handled in the drivers and communicated through fb_info.fbcon_rotate_hint. Signed-off-by: Hans de Goede --- drivers/video/fbdev/core/Makefile | 3 - drivers/video/fbdev/core/fbcon.c| 4 +- drivers/video/fbdev/core/fbcon.h| 6 -- drivers/vid

[PATCH v8 3/5] Documentation: Add device tree binding for Goldfish FB driver

2017-11-06 Thread Aleksandar Markovic
From: Aleksandar Markovic Add documentation for DT binding of Goldfish FB driver. The compatible string used by OS for binding the driver is "google,goldfish-fb". Signed-off-by: Miodrag Dinic Signed-off-by: Goran Ferenc Signed-off-by: Aleksandar Markovic Acked-by: Rob Herring --- .../device

Re: [PATCH] drm/vc4: Convert timers to use timer_setup()

2017-11-06 Thread Daniel Vetter
On Fri, Nov 03, 2017 at 01:07:57PM -0700, Eric Anholt wrote: > Kees Cook writes: > > > On Mon, Oct 30, 2017 at 4:49 PM, Eric Anholt wrote: > >> Kees Cook writes: > >> > >>> In preparation for unconditionally passing the struct timer_list pointer > >>> to > >>> all timer callbacks, switch to us

Re: [PATCH v2 00/10] Allwinner H3/H5/A64(DE2) SimpleFB support

2017-11-06 Thread Daniel Vetter
On Thu, Nov 02, 2017 at 04:44:47PM +0100, Maxime Ripard wrote: > On Thu, Nov 02, 2017 at 04:51:29PM +0800, Icenowy Zheng wrote: > > 在 2017-10-27 23:06,Icenowy Zheng 写道: > > > This patchset adds support for the SimpleFB on Allwinner SoCs with > > > "Display Engine 2.0". > > > > > > PATCH 1 to PATCH

Re: [PATCH 2/4] dma-buf/fence: Sparse wants __rcu on the object itself

2017-11-06 Thread Daniel Vetter
On Thu, Nov 02, 2017 at 10:03:34PM +0200, Ville Syrjala wrote: > From: Chris Wilson > > In order to silent sparse in dma_fence_get_rcu_safe(), we need to mark s/silent/silence/ On the series (assuming sparse is indeed happy now, I didn't check that): Reviewed-by: Daniel Vetter > the incoming

Re: [PATCH 1/6] drm/probe-helper: Fix drm_kms_helper_poll_enable() docs

2017-11-06 Thread Daniel Vetter
On Thu, Nov 02, 2017 at 09:09:04PM +0100, Noralf Trønnes wrote: > Fix docs to reflect code and drm_kms_helper_poll_disable() docs by saying > that calling drm_kms_helper_poll_enable() is fine even if output polling > is not enabled. > > Signed-off-by: Noralf Trønnes Reviewed-by: Daniel Vetter

Re: [PATCH 2/6] drm/modeset-helper: Add simple modeset suspend/resume helpers

2017-11-06 Thread Daniel Vetter
On Thu, Nov 02, 2017 at 09:09:05PM +0100, Noralf Trønnes wrote: > Add drm_mode_config_helper_suspend/resume() which takes care of > atomic modeset suspend/resume for simple use cases. > The suspend state is stored in struct drm_mode_config. > > Signed-off-by: Noralf Trønnes It'd be great if we c

Re: [PATCH 6/6] drm/docs: Add todo entry for simple modeset suspend/resume

2017-11-06 Thread Daniel Vetter
On Thu, Nov 02, 2017 at 09:09:09PM +0100, Noralf Trønnes wrote: > Add entry for conversion of drivers to new helpers. > > Signed-off-by: Noralf Trønnes Reviewed-by: Daniel Vetter I think you can merge this one as soon as the code has landed, no need to wait for all the driver conversions to ge

Re: [PATCH] video: atmel_lcdfb: Use common error handling code in atmel_lcdfb_of_init()

2017-11-06 Thread Dan Carpenter
On Mon, Nov 06, 2017 at 09:40:19AM +0100, Nicolas Ferre wrote: > If you want to lower the size of strings in this driver, you can do it, > but not like this. Just so we're clear, GCC already detects and combines it when you use the same string constant twice. regards, dan carpenter __

Re: [PATCH 01/22] drm/gem-fb-helper: drm_gem_fbdev_fb_create() make funcs optional

2017-11-06 Thread Daniel Vetter
On Sat, Nov 04, 2017 at 02:03:55PM +0100, Noralf Trønnes wrote: > Make the drm_framebuffer_funcs argument optional for drivers that > don't need to set the dirty callback. > > Signed-off-by: Noralf Trønnes Looks like this patch ended up in the wrong patch series? Atm there's not much users of th

Re: [PATCH] drm/amd/display: small cleanup in destruct()

2017-11-06 Thread Christian König
Am 06.11.2017 um 08:07 schrieb Dan Carpenter: Static analysis tools get annoyed that we don't indent this if statement. Actually, the if statement isn't required because kfree() can handle NULL pointers just fine. The DCE110STRENC_FROM_STRENC() macro is a wrapper around container_of() but it's

Re: video: atmel_lcdfb: Use common error handling code in atmel_lcdfb_of_init()

2017-11-06 Thread SF Markus Elfring
>> If you want to lower the size of strings in this driver, you can do it, >> but not like this. > > Just so we're clear, GCC already detects and combines it when you use > the same string constant twice. Do you distinguish between merging of constants and the combination of statements for such a

Re: [PATCH 02/22] drm/cma-helper: Add drm_fb_cma_fbdev_init/fini()

2017-11-06 Thread Daniel Vetter
On Sat, Nov 04, 2017 at 02:03:56PM +0100, Noralf Trønnes wrote: > Add functions drm_fb_cma_fbdev_init(), drm_fb_cma_fbdev_fini() and > drm_fb_cma_fbdev_init_with_funcs(). These functions relies on the fact > that the drm_fb_helper struct is stored in dev->drm_fb_helper_private > so drivers don't ne

Re: [PATCH 03/22] drm/arc: Use drm_fb_cma_fbdev_init/fini()

2017-11-06 Thread Daniel Vetter
On Sat, Nov 04, 2017 at 02:03:57PM +0100, Noralf Trønnes wrote: > Use drm_fb_cma_fbdev_init() and drm_fb_cma_fbdev_fini() which relies on > the fact that drm_device holds a pointer to the drm_fb_helper structure. > This means that the driver doesn't have to keep track of that. > Also use the drm_fb

Re: [PATCH 22/22] drm/cma-helper: Remove drm_fbdev_cma* functions

2017-11-06 Thread Daniel Vetter
On Sat, Nov 04, 2017 at 02:04:16PM +0100, Noralf Trønnes wrote: > Remove the unused struct drm_fbdev_cma functions. > > Cc: Laurent Pinchart > Signed-off-by: Noralf Trønnes On patches 22&21: Acked-by: Daniel Vetter > --- > drivers/gpu/drm/drm_fb_cma_helper.c | 158 >

Re: [Intel-gfx] [PATCH v5 2/7] drm: Add panel orientation quirks

2017-11-06 Thread Daniel Vetter
On Sat, Nov 04, 2017 at 03:08:23PM +0100, Hans de Goede wrote: > Some x86 clamshell design devices use portrait tablet screens and a display > engine which cannot rotate in hardware, so the firmware just leaves things > as is and we cannot figure out that the display is oriented non upright > from

Re: [Intel-gfx] [PATCH v5 3/7] drm: Add support for a panel-orientation connector property

2017-11-06 Thread Daniel Vetter
On Sat, Nov 04, 2017 at 03:08:24PM +0100, Hans de Goede wrote: > On some devices the LCD panel is mounted in the casing in such a way that > the up/top side of the panel does not match with the top side of the > device (e.g. it is mounted upside-down). > > This commit adds the necessary infra for

Re: [Intel-gfx] [PATCH v5 4/7] drm/fb-helper: Apply panel orientation connector prop to the primary plane

2017-11-06 Thread Daniel Vetter
On Sat, Nov 04, 2017 at 03:08:25PM +0100, Hans de Goede wrote: > Apply the "panel orientation" drm connector prop to the primary plane so > that fbcon and fbdev using userspace programs display the right way up. > > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=94894 > Signed-off-by: Hans de

Re: video: atmel_lcdfb: Use common error handling code in atmel_lcdfb_of_init()

2017-11-06 Thread SF Markus Elfring
> Sorry but NACK: the message was malformed and resulted in the > duplication of the error log that you spotted. > > The proper way to fix this is to modify the second occurrence of this message. * Would you like to achieve that a corresponding message will mention anything around a property “a

Re: video: atmel_lcdfb: Use common error handling code in atmel_lcdfb_of_init()

2017-11-06 Thread Dan Carpenter
On Mon, Nov 06, 2017 at 10:00:25AM +0100, SF Markus Elfring wrote: > >> If you want to lower the size of strings in this driver, you can do it, > >> but not like this. > > > > Just so we're clear, GCC already detects and combines it when you use > > the same string constant twice. > > Do you dist

Re: [PATCH 07/22] drm/imx: Use drm_fb_cma_fbdev_init/fini()

2017-11-06 Thread Philipp Zabel
On Sat, 2017-11-04 at 14:04 +0100, Noralf Trønnes wrote: > Use drm_fb_cma_fbdev_init() and drm_fb_cma_fbdev_fini() which relies on > the fact that drm_device holds a pointer to the drm_fb_helper structure. > This means that the driver doesn't have to keep track of that. > Also use the drm_fb_helper

[Bug 99843] Geometry Shader - Incorrect Output

2017-11-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99843 --- Comment #14 from d...@jerber.co.uk --- The 4890 has a RV790 GPU. I've run the trace again and also see an error similar to the one Gert mentioned: 1639 Message api issue 1: FBO incomplete: no attachments and default width or height is 0 [-1]

Re: [PATCH 05/22] drm/atmel-hlcdc: Use drm_fb_cma_fbdev_init/fini()

2017-11-06 Thread Boris Brezillon
On Sat, 4 Nov 2017 14:03:59 +0100 Noralf Trønnes wrote: > Use drm_fb_cma_fbdev_init() and drm_fb_cma_fbdev_fini() which relies on > the fact that drm_device holds a pointer to the drm_fb_helper structure. > This means that the driver doesn't have to keep track of that. > Also use the drm_fb_help

Re: [Intel-gfx] [PATCH v5 5/7] drm/i915: Add "panel orientation" property to the panel connector

2017-11-06 Thread Daniel Vetter
On Sat, Nov 04, 2017 at 03:08:26PM +0100, Hans de Goede wrote: > Ideally we could use the VBT for this, that would be simple, in > intel_dsi_init() check dev_priv->vbt.dsi.config->rotation, set > connector->display_info.panel_orientation accordingly and call > drm_connector_init_panel_orientation_p

Re: [PATCHv1 00/14] omapdrm: DSI command mode panel support

2017-11-06 Thread Pavel Machek
Hi! > > P.S.: I got asked by different people about the status of this > > patchset, which is required for display support on N9, N950 and > > Droid 4. It's not just me and Tony, that are interested in this :) > > Ok. If you agree to help with the DSI part in the future, I have no > problems appl

Re: [PATCH hwc] Android: add CleanSpec.mk

2017-11-06 Thread Robert Foss
Hey Rob, On Fri, 2017-11-03 at 07:35 -0500, Rob Herring wrote: > On Thu, Nov 2, 2017 at 11:45 PM, Chih-Wei Huang org> wrote: > > The file contains rules that are executed on incremental builds. > > Since commit 4f7dc9b6 the library was moved to /vendor so > > the old file must be removed. > > >

AMD, please run Smatch on your driver

2017-11-06 Thread Dan Carpenter
Linux-next was offline for the last month and the AMD drm driver went through major changes. Anyway, I'm a bit overwhelmed by the number of warnings and I'm not going to be able to go through them all so I'm just sending them to you unfiltered. Part of the problem is that I'm not running the rele

Re: [PATCH] backlight: ili922x: remove redundant variable len

2017-11-06 Thread Daniel Thompson
On 05/11/17 11:53, Colin King wrote: From: Colin Ian King The variable len is assigned but never read, therefore it is redundant and can be removed. Cleans up clang warning: drivers/video/backlight/ili922x.c:276:2: warning: Value stored to 'len' is never read Signed-off-by: Colin Ian King

[PATCH] drm/amd/display: checking for NULL instead of IS_ERR()

2017-11-06 Thread Dan Carpenter
backlight_device_register() never returns NULL, it returns error pointers on error so the check here is wrong. Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index 33a15a1d818c..75f9383f5b9b 100644

[PATCH] drm/amd/display: remove some unneeded code

2017-11-06 Thread Dan Carpenter
We assign "v_init = asic_blank_start;" a few lines earlier so there is no need to do it again inside the if statements. Also "v_init" is unsigned so it can't be less than zero. Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_timing_generator.c b/drivers/gpu

[Bug 101483] A10-8780P (Carrizo) + R7 M260/M265 does not boot without any "workaround" parameter.

2017-11-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101483 --- Comment #22 from FFAB --- Upstream kernel test - kernel 4.14-rc8 Installation, on which upstream kernel was installed: ubuntu 16.04.3, kernel4.10.0-38, updated 2017-11-06 1. booting without any workaround parameters 2. booting with kernel

[Bug 101483] A10-8780P (Carrizo) + R7 M260/M265 does not boot without any "workaround" parameter.

2017-11-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101483 --- Comment #23 from FFAB --- Created attachment 135255 --> https://bugs.freedesktop.org/attachment.cgi?id=135255&action=edit dmesg upstream kernel 4.14-rc8, 2017-11-06 -- You are receiving this mail because: You are the assignee for the bug

[Bug 101483] A10-8780P (Carrizo) + R7 M260/M265 does not boot without any "workaround" parameter.

2017-11-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101483 FFAB changed: What|Removed |Added Attachment #135182|0 |1 is obsolete|

Re: [PATCH] drm/amd/display: remove some unneeded code

2017-11-06 Thread Christian König
Am 06.11.2017 um 12:44 schrieb Dan Carpenter: We assign "v_init = asic_blank_start;" a few lines earlier so there is no need to do it again inside the if statements. Also "v_init" is unsigned so it can't be less than zero. Signed-off-by: Dan Carpenter Acked-by: Christian König diff --git

Re: [PATCH] drm/amd/display: checking for NULL instead of IS_ERR()

2017-11-06 Thread Christian König
Am 06.11.2017 um 12:43 schrieb Dan Carpenter: backlight_device_register() never returns NULL, it returns error pointers on error so the check here is wrong. Signed-off-by: Dan Carpenter Acked-by: Christian König diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu

Re: [PATCH 3/6] drm/arm/mali: Use drm_mode_config_helper_suspend/resume()

2017-11-06 Thread Liviu Dudau
On Thu, Nov 02, 2017 at 09:09:06PM +0100, Noralf Trønnes wrote: > These helpers take care of output polling, fbdev and atomic state. Hmm, not much useful info here, tbh. Maybe something like: "Replace driver's code with the generic helpers that do the same thing" ? > > Cc: Liviu Dudau > Cc: Br

Re: [PATCH 01/22] drm/gem-fb-helper: drm_gem_fbdev_fb_create() make funcs optional

2017-11-06 Thread Noralf Trønnes
Den 06.11.2017 09.54, skrev Daniel Vetter: On Sat, Nov 04, 2017 at 02:03:55PM +0100, Noralf Trønnes wrote: Make the drm_framebuffer_funcs argument optional for drivers that don't need to set the dirty callback. Signed-off-by: Noralf Trønnes Looks like this patch ended up in the wrong patch s

Re: [PATCH 02/22] drm/cma-helper: Add drm_fb_cma_fbdev_init/fini()

2017-11-06 Thread Noralf Trønnes
Den 06.11.2017 10.04, skrev Daniel Vetter: On Sat, Nov 04, 2017 at 02:03:56PM +0100, Noralf Trønnes wrote: Add functions drm_fb_cma_fbdev_init(), drm_fb_cma_fbdev_fini() and drm_fb_cma_fbdev_init_with_funcs(). These functions relies on the fact that the drm_fb_helper struct is stored in dev->dr

Re: [PATCH 03/22] drm/arc: Use drm_fb_cma_fbdev_init/fini()

2017-11-06 Thread Noralf Trønnes
Den 06.11.2017 10.08, skrev Daniel Vetter: On Sat, Nov 04, 2017 at 02:03:57PM +0100, Noralf Trønnes wrote: Use drm_fb_cma_fbdev_init() and drm_fb_cma_fbdev_fini() which relies on the fact that drm_device holds a pointer to the drm_fb_helper structure. This means that the driver doesn't have to

[PATCH] video: fbdev: intelfb: remove redundant variables

2017-11-06 Thread Colin King
From: Colin Ian King Variables err_max, err_target and f_best are being assigned values but these are never read, hence they are redundant variables and can be removed. Cleans up clang warnings: drivers/video/fbdev/intelfb/intelfbhw.c:946:2: warning: Value stored to 'err_max' is never read drive

Re: [PATCH 10/22] drm/pl111: Use drm_fb_cma_fbdev_init/fini()

2017-11-06 Thread Linus Walleij
On Sat, Nov 4, 2017 at 2:04 PM, Noralf Trønnes wrote: > Use drm_fb_cma_fbdev_init() and drm_fb_cma_fbdev_fini() which relies on > the fact that drm_device holds a pointer to the drm_fb_helper structure. > This means that the driver doesn't have to keep track of that. > Also use the drm_fb_helper

Re: [PATCH 16/22] drm/tve200: Use drm_fb_cma_fbdev_init/fini()

2017-11-06 Thread Linus Walleij
On Sat, Nov 4, 2017 at 2:04 PM, Noralf Trønnes wrote: > Use drm_fb_cma_fbdev_init() and drm_fb_cma_fbdev_fini() which relies on > the fact that drm_device holds a pointer to the drm_fb_helper structure. > This means that the driver doesn't have to keep track of that. > Also use the drm_fb_helper

Re: [PATCH hwc] Android: add CleanSpec.mk

2017-11-06 Thread Rob Herring
On Mon, Nov 6, 2017 at 5:16 AM, Robert Foss wrote: > Hey Rob, > > On Fri, 2017-11-03 at 07:35 -0500, Rob Herring wrote: >> On Thu, Nov 2, 2017 at 11:45 PM, Chih-Wei Huang > org> wrote: >> > The file contains rules that are executed on incremental builds. >> > Since commit 4f7dc9b6 the library was

[PATCH] drm/rockchip: add CONFIG_OF dependency for lvds

2017-11-06 Thread Arnd Bergmann
Build-testing on randconfig kernels revealed a dependency in the newly added lvds sub-driver: drivers/gpu/drm/rockchip/rockchip_lvds.c: In function 'rockchip_lvds_bind': drivers/gpu/drm/rockchip/rockchip_lvds.c:380:24: error: 'struct drm_bridge' has no member named 'of_node' remote = lvds->bri

Re: [Intel-gfx] [PATCH] drm/atomic: Try to preserve the crtc enabled state in drm_atomic_remove_fb, v2.

2017-11-06 Thread Ville Syrjälä
On Thu, Nov 02, 2017 at 09:55:40AM +0100, Maarten Lankhorst wrote: > Op 01-11-17 om 18:00 schreef Ville Syrjälä: > > On Wed, Nov 01, 2017 at 04:55:06PM +0100, Maarten Lankhorst wrote: > >> Op 01-11-17 om 16:29 schreef Ville Syrjälä: > >>> On Wed, Nov 01, 2017 at 04:04:33PM +0100, Maarten Lankhorst

Re: [Intel-gfx] [PATCH] drm/atomic: Try to preserve the crtc enabled state in drm_atomic_remove_fb, v2.

2017-11-06 Thread Ville Syrjälä
On Mon, Nov 06, 2017 at 04:01:20PM +0200, Ville Syrjälä wrote: > On Thu, Nov 02, 2017 at 09:55:40AM +0100, Maarten Lankhorst wrote: > > Op 01-11-17 om 18:00 schreef Ville Syrjälä: > > > On Wed, Nov 01, 2017 at 04:55:06PM +0100, Maarten Lankhorst wrote: > > >> Op 01-11-17 om 16:29 schreef Ville Syrj

Re: [PATCH v3] display: panel: Add Mitsubishi aa070mc01 display support (800x480)

2017-11-06 Thread Rob Herring
On Fri, Oct 20, 2017 at 5:18 PM, Lukasz Majewski wrote: > This commit adds support for Mitsubishi aa070mc01 TFT panel working > with 8 bit ISP mode (pin 19 "mode" HIGH for 20 pin TFT connector). > > Signed-off-by: Lukasz Majewski > --- > Changes for v2: > - Place the code sorted alphabetically >

Re: [PATCH] display: panel: Add Tianma tm070rvhg71 display support (800x480)

2017-11-06 Thread Rob Herring
On Fri, Oct 27, 2017 at 3:18 AM, Lukasz Majewski wrote: > Hi Rob, > >> On Sat, Oct 21, 2017 at 12:10:03AM +0200, Lukasz Majewski wrote: >> > Signed-off-by: Lukasz Majewski >> > --- >> > .../bindings/display/panel/tianma,tm070rvhg71.txt | 7 ++ >> > drivers/gpu/drm/panel/panel-simple.c

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

2017-11-06 Thread Benjamin Gaignard
2017-11-02 12:10 GMT+01:00 Mark Brown : > On Thu, Nov 02, 2017 at 11:44:07AM +0100, Greg KH wrote: >> On Tue, Oct 31, 2017 at 07:11:53PM +, Mark Brown wrote: > >> > There was a discussion a while ago in the context of I2C/SPI MFDs >> > which concluded that if you need a bus and it's going to be

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

2017-11-06 Thread Greg KH
On Mon, Nov 06, 2017 at 03:42:04PM +0100, Benjamin Gaignard wrote: > 2017-11-02 12:10 GMT+01:00 Mark Brown : > > On Thu, Nov 02, 2017 at 11:44:07AM +0100, Greg KH wrote: > >> On Tue, Oct 31, 2017 at 07:11:53PM +, Mark Brown wrote: > > > >> > There was a discussion a while ago in the context of

Re: [PATCH 0/7] drm/edid and drivers: ELD refactoring

2017-11-06 Thread Thierry Reding
On Wed, Nov 01, 2017 at 04:20:56PM +0200, Jani Nikula wrote: > We were recently bitten by drm_edid_to_eld() clearing the connector > type, and us failing to set it back for DP. Here's a few ELD related > patches to try to unify ELD handling and make it a bit simpler for > drivers to get it right. >

i915: pipe B vblank wait timed out

2017-11-06 Thread Borislav Petkov
Hi, I see this on an 32-bit acer atom mini-laptop with -rc8+tip: [2.399416] pipe B vblank wait timed out [2.399506] [ cut here ] [2.399533] WARNING: CPU: 1 PID: 22 at /mnt/kernel/kernel/linux-2.6/drivers/gpu/drm/i915/intel_display.c:12176 intel_atomic_commit_

Re: [PATCH] drm/rockchip: add CONFIG_OF dependency for lvds

2017-11-06 Thread Sean Paul
On Mon, Nov 06, 2017 at 02:58:43PM +0100, Arnd Bergmann wrote: > Build-testing on randconfig kernels revealed a dependency in the > newly added lvds sub-driver: > > drivers/gpu/drm/rockchip/rockchip_lvds.c: In function 'rockchip_lvds_bind': > drivers/gpu/drm/rockchip/rockchip_lvds.c:380:24: error:

Re: [Intel-gfx] [PATCH] drm/atomic: Try to preserve the crtc enabled state in drm_atomic_remove_fb, v2.

2017-11-06 Thread Maarten Lankhorst
Op 06-11-17 om 15:06 schreef Ville Syrjälä: > On Mon, Nov 06, 2017 at 04:01:20PM +0200, Ville Syrjälä wrote: >> On Thu, Nov 02, 2017 at 09:55:40AM +0100, Maarten Lankhorst wrote: >>> Op 01-11-17 om 18:00 schreef Ville Syrjälä: On Wed, Nov 01, 2017 at 04:55:06PM +0100, Maarten Lankhorst wrote:

Re: [PATCH 1/3] ASoC: amd: Report accurate hw_ptr during dma

2017-11-06 Thread Mark Brown
On Fri, Nov 03, 2017 at 04:35:43PM -0400, Alex Deucher wrote: > Signed-off-by: Vijendar Mukunda > Signed-off-by: Akshu Agrawal > Reviewed-on: https://chromium-review.googlesource.com/659699 > Commit-Ready: Akshu Agrawal > Tested-by: Akshu Agrawal > Reviewed-by: Jason Clinton > Reviewed-on: ht

[PATCH v6 1/2] staging: ion: reorder include

2017-11-06 Thread Benjamin Gaignard
Put include in alphabetic order Signed-off-by: Benjamin Gaignard --- drivers/staging/android/ion/ion.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index a7d9b0e..fda9756 100644 --- a/dri

[PATCH v6 0/2] staging: ion: get one device per heap

2017-11-06 Thread Benjamin Gaignard
version 6: - add an ION bus so heap are show as devices in /sys/bus/ion/ instead of platform bus. - split the patch in two: one for include reordering and one for per heap device change - rebased on top of next-2017110 tag version 5: - create a configuration flag to keep legacy Ion misc device

[PATCH v6 2/2] staging: ion: create one device entry per heap

2017-11-06 Thread Benjamin Gaignard
Instead a getting only one common device "/dev/ion" for all the heaps this patch allow to create one device entry ("/dev/ionX") per heap. Getting an entry per heap could allow to set security rules per heap and global ones for all heaps. Allocation requests will be only allowed if the mask_id matc

[Bug 102358] WarThunder freezes at start, with activated vsync (vblank_mode=2)

2017-11-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102358 --- Comment #37 from har...@gmx.de --- Ok, thanks for clarification. I prefer not to add such tag, because this is my anonymous email address, dedicated to things like to games. /Jens -- You are receiving this mail because: You are the assign

Re: radeon_dp_aux_transfer_native: 74 callbacks suppressed

2017-11-06 Thread Lyude Paul
The main reason I added this was because the radeon driver's hotplugging paths for DP do a ton of unnessecary probing, and because the driver usually also checks all connectors every time there's a hotplug (there isn't much of a good reason for this, it's just an old driver) it's not at all difficu

Re: [PATCH 1/2] dma-buf: keep only not signaled fence in reservation_object_add_shared_replace v2

2017-11-06 Thread Chris Wilson
Quoting Christian König (2017-10-30 14:59:03) > From: Christian König > > The amdgpu issue to also need signaled fences in the reservation objects > should be fixed by now. > > Optimize the list by keeping only the not signaled yet fences around. > > v2: temporary put the signaled fences at the

Re: [PATCH 17/22] drm/vc4: Use drm_fb_cma_fbdev_init/fini()

2017-11-06 Thread Eric Anholt
Noralf Trønnes writes: > Use drm_fb_cma_fbdev_init() and drm_fb_cma_fbdev_fini() which relies on > the fact that drm_device holds a pointer to the drm_fb_helper structure. > This means that the driver doesn't have to keep track of that. > Also use the drm_fb_helper functions directly. Reviewed-b

Re: [Intel-gfx] [PATCH] drm/atomic: Try to preserve the crtc enabled state in drm_atomic_remove_fb, v2.

2017-11-06 Thread Ville Syrjälä
On Mon, Nov 06, 2017 at 04:43:17PM +0100, Maarten Lankhorst wrote: > Op 06-11-17 om 15:06 schreef Ville Syrjälä: > > On Mon, Nov 06, 2017 at 04:01:20PM +0200, Ville Syrjälä wrote: > >> On Thu, Nov 02, 2017 at 09:55:40AM +0100, Maarten Lankhorst wrote: > >>> Op 01-11-17 om 18:00 schreef Ville Syrjäl

Re: [PATCH 2/2] dma-buf: try to replace a signaled fence in reservation_object_add_shared_inplace

2017-11-06 Thread Chris Wilson
Quoting Christian König (2017-10-30 14:59:04) > From: Christian König > > The amdgpu issue to also need signaled fences in the reservation objects > should > be fixed by now. > > Optimize the handling by replacing a signaled fence when adding a new > shared one. > > Signed-off-by: Christian Kö

Re: [PATCH 3/3] ASoC: rt5645: Wait for 400msec before concluding on value of RT5645_VENDOR_ID2

2017-11-06 Thread Mark Brown
On Fri, Nov 03, 2017 at 04:35:45PM -0400, Alex Deucher wrote: > Minimum time required between power On of codec and read > of RT5645_VENDOR_ID2 is 400msec. We should wait and attempt > before erroring out. So the description says we have to wait 400ms before attempting a read... > BUG=b:66978383

Re: [gabbayo:amdkfd-next 5/8] drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v8.c:540:3: error: dereferencing pointer to incomplete type 'struct cik_sdma_rlc_registers'

2017-11-06 Thread Felix Kuehling
I messed up while rebasing patches and didn't test every intermediate patch as I should have. The next patch in the series fixes this. If anyone wants to fix this before merging further upstream, remove the offending line in this commit and reintroduce it in the next commit in the series. At this

Re: linux-next: Tree for Nov 6 (amdgpu_virt.c)

2017-11-06 Thread Alex Deucher
On Mon, Nov 6, 2017 at 12:20 PM, Randy Dunlap wrote: > On 11/05/2017 11:30 PM, Stephen Rothwell wrote: >> Hi all, >> >> Changes since 20171103: >> > > on i386, when CONFIG_MODULES is not set: > > CC drivers/gpu/drm/amd/amdgpu/amdgpu_virt.o > In file included from ../arch/x86/include/asm/ato

Re: [PATCH 13/22] drm/stm: Use drm_fb_cma_fbdev_init/fini()

2017-11-06 Thread Philippe CORNU
Hi Noralf, On 11/04/2017 02:04 PM, Noralf Trønnes wrote: > Use drm_fb_cma_fbdev_init() and drm_fb_cma_fbdev_fini() which relies on > the fact that drm_device holds a pointer to the drm_fb_helper structure. > This means that the driver doesn't have to keep track of that. > Also use the drm_fb_helpe

Re: [Intel-gfx] [PATCH 3/5] drm/vmwgfx: Try to fix plane clipping

2017-11-06 Thread Ville Syrjälä
On Thu, Nov 02, 2017 at 03:19:30PM +0200, Ville Syrjälä wrote: > On Thu, Nov 02, 2017 at 11:12:09AM +0100, Daniel Vetter wrote: > > On Wed, Nov 01, 2017 at 08:29:18PM +0200, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Try to fix the code to actually clip the plane to the crtc bound

[PATCH v2] video: atmel_lcdfb: Use unique error messages in atmel_lcdfb_of_init()

2017-11-06 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 6 Nov 2017 19:00:58 +0100 A duplicate error message was used so far in this function implementation. Thus use a consistent message format instead together with property names where constant merging can be applied by the compiler in four cases. This issue was detec

Re: radeon_dp_aux_transfer_native: 74 callbacks suppressed

2017-11-06 Thread Christian König
Additionally, we should also just fix this ratelimit macro anyway since it's intended purpose is not to print anything when debugging isn't enabled. What do you think Alex? Well, at least I think that the described behavior of the macro is a bug which should be fixed. But I think that is indepe

Re: [PATCH v2] video: atmel_lcdfb: Use unique error messages in atmel_lcdfb_of_init()

2017-11-06 Thread Joe Perches
On Mon, 2017-11-06 at 19:14 +0100, SF Markus Elfring wrote: > A duplicate error message was used so far in this function implementation. > Thus use a consistent message format instead together with property names > where constant merging can be applied by the compiler in four cases. [] > diff --git

Re: [PATCH 21/22] drm/tinydrm: Use drm_fb_cma_fbdev_init_with_funcs/fini()

2017-11-06 Thread David Lechner
On 11/04/2017 08:04 AM, Noralf Trønnes wrote: Use drm_fb_cma_fbdev_init_with_funcs() and drm_fb_cma_fbdev_fini() which relies on the fact that drm_device holds a pointer to the drm_fb_helper structure. This means that the driver doesn't have to keep track of that. Also use the drm_fb_helper funct

[PATCH v2 3/6] drm/arm/mali: Use drm_mode_config_helper_suspend/resume()

2017-11-06 Thread Noralf Trønnes
Replace driver's code with the generic helpers that do the same thing. Cc: Liviu Dudau Cc: Brian Starkey Signed-off-by: Noralf Trønnes Reviewed-by: Liviu Dudau --- drivers/gpu/drm/arm/malidp_drv.c | 24 +++- drivers/gpu/drm/arm/malidp_drv.h | 1 - 2 files changed, 3 inser

[PATCH v2 6/6] drm/docs: Add todo entry for simple modeset suspend/resume

2017-11-06 Thread Noralf Trønnes
Add entry for conversion of drivers to new helpers. Signed-off-by: Noralf Trønnes Reviewed-by: Daniel Vetter --- Documentation/gpu/todo.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst index a44f379d2b25..6bce1beafabe 10064

[PATCH v2 1/6] drm/probe-helper: Fix drm_kms_helper_poll_enable() docs

2017-11-06 Thread Noralf Trønnes
Fix docs to reflect code and drm_kms_helper_poll_disable() docs by saying that calling drm_kms_helper_poll_enable() is fine even if output polling is not enabled. Signed-off-by: Noralf Trønnes Reviewed-by: Daniel Vetter --- drivers/gpu/drm/drm_probe_helper.c | 3 +-- 1 file changed, 1 insertion

[PATCH v2 0/6] drm/: Add simple modeset suspend/resume helpers

2017-11-06 Thread Noralf Trønnes
This patchset adds some simple modeset suspend/resume helpers which probably most atomic drivers can use. For those that haven't followed dri-devel closely the past few days, this patch put in place the fbdev piece necessary to do this: drm: Add drm_device->fb_helper pointer https://cgit.freedeskt

[PATCH v2 2/6] drm/modeset-helper: Add simple modeset suspend/resume helpers

2017-11-06 Thread Noralf Trønnes
Add drm_mode_config_helper_suspend/resume() which takes care of atomic modeset suspend/resume for simple use cases. The suspend state is stored in struct drm_mode_config. Signed-off-by: Noralf Trønnes Reviewed-by: Daniel Vetter --- drivers/gpu/drm/drm_modeset_helper.c | 76 +

[PATCH v2 4/6] drm/fsl-dcu: Use drm_mode_config_helper_suspend/resume()

2017-11-06 Thread Noralf Trønnes
Replace driver's code with the generic helpers that do the same thing. Cc: Stefan Agner Cc: Alison Wang Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 24 ++-- drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.h | 1 - 2 files changed, 6 insertions(+),

[PATCH v2 5/6] drm/tinydrm: Use drm_mode_config_helper_suspend/resume()

2017-11-06 Thread Noralf Trønnes
Replace driver's code with the generic helpers that do the same thing. Remove todo entry. Signed-off-by: Noralf Trønnes --- Documentation/gpu/todo.rst | 5 --- drivers/gpu/drm/tinydrm/core/tinydrm-core.c | 67 - drivers/gpu/drm/tinydrm/mi0283qt.c

[Bug 99843] Geometry Shader - Incorrect Output

2017-11-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99843 --- Comment #15 from d...@jerber.co.uk --- I was reading about the R600 driver and came across a TODO page that suggested testing using piglit. I downloaded and compiled this. I ran the "shader.py" test and it gave the following results: skip: 2

[Bug 103544] Graphical glitches r600 in game this war of mine linux native

2017-11-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103544 --- Comment #11 from Roland Scheidegger --- (In reply to Ilia Mirkin from comment #10) > Patch is available at https://patchwork.freedesktop.org/patch/186599/ > (although I'll have to rework the description) Doesn't help, everything looks the s

[Bug 103544] Graphical glitches r600 in game this war of mine linux native

2017-11-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103544 --- Comment #12 from Roland Scheidegger --- Here's a apitrace for this (1GB, of course the corruption is only seen towards the end...), should be available a week (?): https://we.tl/EanuxRG7Yf -- You are receiving this mail because: You are th

Re: [PATCH] drm/amd/display: small cleanup in destruct()

2017-11-06 Thread Alex Deucher
On Mon, Nov 6, 2017 at 3:44 AM, Christian König wrote: > Am 06.11.2017 um 08:07 schrieb Dan Carpenter: >> >> Static analysis tools get annoyed that we don't indent this if >> statement. Actually, the if statement isn't required because kfree() >> can handle NULL pointers just fine. The DCE110STR

Re: [PATCH] drm/amd/display: checking for NULL instead of IS_ERR()

2017-11-06 Thread Alex Deucher
On Mon, Nov 6, 2017 at 6:51 AM, Christian König wrote: > Am 06.11.2017 um 12:43 schrieb Dan Carpenter: >> >> backlight_device_register() never returns NULL, it returns error >> pointers on error so the check here is wrong. >> >> Signed-off-by: Dan Carpenter > > > Acked-by: Christian König Appli

  1   2   >