[PATCH v4 3/7] drm: Add support for a panel-orientation connector property

2017-10-24 Thread Hans de Goede
On some devices the LCD panel is mounted in the casing in such a way that the up/top side of the panel does not match with the top side of the device (e.g. it is mounted upside-down). This commit adds the necessary infra for lcd-panel drm_connector-s to have a "panel orientation" property to commu

Re: Enabling peer to peer device transactions for PCIe devices

2017-10-24 Thread Petrosyan, Ludwig
Yes I agree it has to be started with the write transaction, according of PCIe standard all write transaction are address routed, and I agree with Logan: if in write transaction TLP the endpoint address written in header the TLP should not touch CPU, the PCIe Switch has to route it to endpoint. T

Re: [PATCHv1 00/14] omapdrm: DSI command mode panel support

2017-10-24 Thread Sebastian Reichel
Hi, On Fri, Oct 13, 2017 at 10:12:08AM -0700, Tony Lindgren wrote: > * Tomi Valkeinen [171012 01:46]: > > On 29/09/17 16:26, Sebastian Reichel wrote: > > > Hi Tomi & Laurent, > > > > > > ping? > > > > I've been having quick glances at this every now and then, but I'm not > > sure what to do wit

[PATCH v4 6/7] efifb: Set info->fbcon_rotate_hint based on drm_get_panel_orientation_quirk

2017-10-24 Thread Hans de Goede
On some hardware the LCD panel is not mounted upright in the casing, but rotated by 90 degrees. In this case we want the console to automatically be rotated to compensate. The drm subsys has a quirk table for this, use the drm_get_panel_orientation_quirk function to get the panel orientation and s

[PATCH v4 4/7] drm/fb-helper: Apply panel orientation connector prop to the primary plane

2017-10-24 Thread Hans de Goede
Apply the "panel orientation" drm connector prop to the primary plane so that fbcon and fbdev using userspace programs display the right way up. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=94894 Signed-off-by: Hans de Goede --- Changes in v2: -New patch in v2 of this patch-set Changes in

Re: [PATCH 15/23] drm/sun4i: Add LVDS support

2017-10-24 Thread Priit Laes
On Tue, Oct 17, 2017 at 11:06:22AM +0200, Maxime Ripard wrote: > The TCON supports the LVDS interface to output to a panel or a bridge. > Let's add support for it. > > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/sun4i/Makefile | 1 +- > drivers/gpu/drm/sun4i/sun4i_lvds.c | 183 +++

[PATCH v4 0/7] drm/fbdev: Panel orientation connector property support

2017-10-24 Thread Hans de Goede
Hi All, Here is v4 of my series to add a "panel orientation" property to the drm-connector for the LCD panel to let userspace know about LCD panels which are not mounted upright, as well as detecting upside-down panels without needing quirks (like we do for 90 degree rotated screens). New in v3:

Re: [14/23] drm/sun4i: Create minimal multipliers and dividers

2017-10-24 Thread Jonathan Liu
Hi Maxime, On 17 October 2017 at 20:06, Maxime Ripard wrote: > The various outputs the TCON can provide have different constraints on the > dotclock divider. Let's make them configurable by the various mode_set > functions. > > Signed-off-by: Maxime Ripard > Reviewed-by: Chen-Yu Tsai > --- > d

Re: [PATCH v3 1/7] fbcon: Add fbcon_rotate_hint to struct fb_info

2017-10-24 Thread Sebastian Reichel
Hi Hans, On Mon, Oct 23, 2017 at 09:14:19AM +0200, Hans de Goede wrote: > On some hardware the LCD panel is not mounted upright in the casing, > but upside-down or rotated 90 degrees. In this case we want the console > to automatically be rotated to compensate. > > The fbdev-driver may know about

drivers/gpu/drm/gma500/mdfld_intel_display.c:102:37: warning: bitwise comparison always evaluates to false [-Wtautological-compare]

2017-10-24 Thread David Binderman
Hello there, Source code is if ((temp & PIPEACONF_PIPE_STATE) == 1) break; but $ fgrep PIPEACONF_PIPE_STATE `find drivers/gpu/drm/gma500 -name \*.h -print` drivers/gpu/drm/gma500/psb_intel_reg.h:#define PIPEACONF_PIPE_STATE (1 << 30) $ Suggest new code

Re: Enabling peer to peer device transactions for PCIe devices

2017-10-24 Thread Logan Gunthorpe
On 23/10/17 10:08 AM, David Laight wrote: It is also worth checking that the hardware actually supports p2p transfers. Writes are more likely to be supported then reads. ISTR that some intel cpus support some p2p writes, but there could easily be errata against them. Ludwig mentioned a PCIe s

Re: [PATCH 05/15] drm/armada: Use drm_fb_helper_lastclose() and _poll_changed()

2017-10-24 Thread Russell King - ARM Linux
On Fri, Oct 20, 2017 at 01:02:03AM +0200, Noralf Trønnes wrote: > This driver can use drm_fb_helper_lastclose() as its .lastclose callback. > It can also use drm_fb_helper_output_poll_changed() as its > .output_poll_changed callback. > > Cc: Russell King Acked-by: Russell King Thanks. > Signe

RE: Enabling peer to peer device transactions for PCIe devices

2017-10-24 Thread David Laight
From: Petrosyan Ludwig > Sent: 22 October 2017 07:14 > Could be I have done is stupid... > But at first sight it has to be simple: > The PCIe Write transactions are address routed, so if in the packet header > the other endpoint address > is written the TLP has to be routed (by PCIe Switch to the

[PATCH v4 7/7] fbcon: Remove dmi quirk table

2017-10-24 Thread Hans de Goede
This is now all handled in the drivers and communicated through fb_info.fbcon_rotate_hint. Signed-off-by: Hans de Goede --- drivers/video/fbdev/core/Makefile | 3 - drivers/video/fbdev/core/fbcon.c| 4 +- drivers/video/fbdev/core/fbcon.h| 6 -- drivers/vid

[PATCH v4 5/7] drm/i915: Add "panel orientation" property to the panel connector

2017-10-24 Thread Hans de Goede
Ideally we could use the VBT for this, that would be simple, in intel_dsi_init() check dev_priv->vbt.dsi.config->rotation, set connector->display_info.panel_orientation accordingly and call drm_connector_init_panel_orientation_property(), done. Unfortunately vbt.dsi.config->rotation is always 0 ev

[PATCH] drm: virtio: replace reference/unreference with get/put

2017-10-24 Thread Aastha Gupta
DRM core uses reference/unreference suffixes for refcounting functions, but kernel uses get/put (e.g. kref_get/put()). Replace reference/unreference with get/put for consistency and also it's shorter. The following cocci script was used to generate the patch: @@ expression e; @@ ( -drm_gem_objec

RE: [PATCH 1/4] dt-bindings: display: rcar-du: Document R8A774[35] DU

2017-10-24 Thread Fabrizio Castro
Hello Laurent, thank you for getting back to me. > > Hi Fabrizio, > > Thank you for the patch. > > On Friday, 13 October 2017 18:22:19 EEST Fabrizio Castro wrote: > > Add device tree bindings for r8a7743 and r8a7745 DUs. > > r8a7743 DU is similar to the one from r8a7791, r8a7745 DU is similar > >

[PATCH v4 2/7] drm: Add panel orientation quirks

2017-10-24 Thread Hans de Goede
Some x86 clamshell design devices use portrait tablet screens and a display engine which cannot rotate in hardware, so the firmware just leaves things as is and we cannot figure out that the display is oriented non upright from the hardware. So at least on x86, we need a quirk table for this. This

[PATCH v4 1/7] fbcon: Add fbcon_rotate_hint to struct fb_info

2017-10-24 Thread Hans de Goede
On some hardware the LCD panel is not mounted upright in the casing, but upside-down or rotated 90 degrees. In this case we want the console to automatically be rotated to compensate. The fbdev-driver may know about the need to rotate. Add a new fbcon_rotate_hint field to struct fb_info, which get

Re: [RESEND PATCH] drm/hisilicon: Ensure LDI regs are properly configured.

2017-10-24 Thread Peter Griffin
Hi Xinliang, On 28 August 2017 at 10:27, Xinliang Liu wrote: > Hi Daniel, > > On 28 August 2017 at 16:51, Daniel Vetter wrote: > > On Mon, Aug 28, 2017 at 04:44:30PM +0800, Xinliang Liu wrote: > >> Hi, > >> > >> On 15 August 2017 at 22:14, Peter Griffin > wrote: > >> > >> > This patch fixes th

Re: [PATCH 2/4] dt-bindings: display: amlogic, meson-dw-hdmi: Add optional HDMI 5V regulator

2017-10-24 Thread Neil Armstrong
On 24/10/2017 00:46, Rob Herring wrote: > On Tue, Oct 17, 2017 at 10:07:42AM +0200, Neil Armstrong wrote: >> On reference boards and derivatives, the HDMI Logic is powered by an external >> 5V regulator. >> This regulator was set by the Vendor U-Boot, add optional support for it. >> >> Signed-off-b

Re: [PATCH v4] drm: bridge: Add THS8134A/B support to dumb VGA DAC

2017-10-24 Thread Laurent Pinchart
Hi Linus, Thank you for the patch. On Friday, 20 October 2017 15:54:12 EEST Linus Walleij wrote: > This extends the dumb VGA DAC bridge to handle the THS8134A > and THS8134B VGA DACs in addition to those already handled. > > The THS8134A, THS8134B and as it turns out also THS8135 need to > have

[PATCH 0/3] GPU-DRM-Exynos: Fine-tuning for six function implementations

2017-10-24 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 24 Oct 2017 10:34:56 +0200 Three update suggestions were taken into account from static source code analysis. Markus Elfring (3): Use common error handling code in exynos_dsi_enable() Use common error handling code in exynos_drm_gem_init() Fix typos in five

[PATCH 1/3] drm/exynos/dsi: Use common error handling code in exynos_dsi_enable()

2017-10-24 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 24 Oct 2017 09:32:18 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/gpu/drm/exynos/exynos_drm_dsi.

[PATCH 2/3] drm/exynos/gem: Use common error handling code in exynos_drm_gem_init()

2017-10-24 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 24 Oct 2017 09:50:54 +0200 Adjust jump targets so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/gpu/drm/exynos/exynos_drm_ge

Re: [PATCH 1/3] drm/exynos/dsi: Use common error handling code in exynos_dsi_enable()

2017-10-24 Thread Krzysztof Kozlowski
On Tue, Oct 24, 2017 at 10:49 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 24 Oct 2017 09:32:18 +0200 > > Add a jump target so that a bit of exception handling can be better reused > at the end of this function. > > This issue was detected by using the Coccinelle software. > >

[PATCH 3/3] drm/exynos: Fix typos in five comment lines

2017-10-24 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 24 Oct 2017 10:20:20 +0200 The script "checkpatch.pl" pointed misspelled words out. Thus fix the affected places. Signed-off-by: Markus Elfring --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 2 +- drivers/gpu/drm/exynos/exynos_drm_fimc.c | 2 +- drivers/gpu/drm/

Re: drivers/gpu/drm/gma500/mdfld_intel_display.c:102:37: warning: bitwise comparison always evaluates to false [-Wtautological-compare]

2017-10-24 Thread Jani Nikula
On Mon, 23 Oct 2017, David Binderman wrote: > Hello there, > > Source code is > > if ((temp & PIPEACONF_PIPE_STATE) == 1) > break; > > but > > $ fgrep PIPEACONF_PIPE_STATE `find drivers/gpu/drm/gma500 -name \*.h -print` > drivers/gpu/drm/gma500/psb_intel_reg.h:#define PIPEACONF

Re: [PATCH] drm/vblank: Tune drm_crtc_accurate_vblank_count() WARN down to a debug

2017-10-24 Thread Benjamin Gaignard
2017-10-23 17:25 GMT+02:00 Ville Syrjala : > From: Ville Syrjälä > > Since commit 632c6e4edef1 ("drm/vblank: Fix flip event vblank count") > even drivers that don't implement accurate vblank timestamps will end > up using drm_crtc_accurate_vblank_count(). That leads to a WARN every > time drm_crtc

Re: [PATCH 1/3] drm/exynos/dsi: Use common error handling code in exynos_dsi_enable()

2017-10-24 Thread SF Markus Elfring
>> @@ -1401,11 +1400,14 @@ static void exynos_dsi_enable(struct drm_encoder >> *encoder) >> dsi->state &= ~DSIM_STATE_ENABLED; >> exynos_dsi_set_display_enable(dsi, false); >> drm_panel_unprepare(dsi->panel); >> - pm_runtime_put_sync(ds

[Bug 103393] glDispatchComputeGroupSizeARB : gl_GlobalInvocationID.x != gl_WorkGroupID.x * gl_LocalGroupSizeARB.x + gl_LocalInvocationID.x

2017-10-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103393 Samuel Pitoiset changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[PATCH] drm/amd/powerplay: fix amd_powerplay_reset()

2017-10-24 Thread Dan Carpenter
We accidentally inverted an if statement and turned amd_powerplay_reset() into a no-op. Fixes: ae97988fc89e ("drm/amd/powerplay: tidy up ret checks in amd_powerplay.c (v3)") Signed-off-by: Dan Carpenter --- IMHO, tidying unreadable double negatives is tricky and error prone but still worth it in

Re: drivers/gpu/drm/gma500/mdfld_intel_display.c:102:37: warning: bitwise comparison always evaluates to false [-Wtautological-compare]

2017-10-24 Thread Jani Nikula
On Tue, 24 Oct 2017, David Binderman wrote: > Hello there, > > > Code I looked at is in linux-4.14-rc6, released 20171023, so reasonably > > up to date. > > > I did a further check on github.com/torvalds/linux and the code > > looks wrong there, too. > > > So I don't see the fix you mentioned in e

Re: [PATCH] drm/amd/powerplay: fix amd_powerplay_reset()

2017-10-24 Thread Jani Nikula
On Tue, 24 Oct 2017, Dan Carpenter wrote: > We accidentally inverted an if statement and turned amd_powerplay_reset() > into a no-op. > > Fixes: ae97988fc89e ("drm/amd/powerplay: tidy up ret checks in > amd_powerplay.c (v3)") For some reason I looked up that commit, and it has *two* cases where

Re: [RESEND PATCH] drm: panel: replace dev_info/dev_err/dev_warn with DRM_DEV_* equivalent

2017-10-24 Thread Sean Paul
On Mon, Oct 23, 2017 at 12:47 PM, Aastha Gupta wrote: > For drivers which could have multiple instances, it is necessary to > differentiate between which is which in the logs. Since > DRM_INFO/WARN/ERROR don’t do this, drivers used dev_info/warn/err to > make this differentiation. We now have DRM_

[Bug 103370] `DRI_PRIME=1 glxgears -info` halts the system with Intel Graphics [8086:5917] + AMD Graphics [1002:6665].

2017-10-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103370 --- Comment #9 from Shih-Yuan Lee --- I have tried acpi_osi="Windows 2009", "Windows 2012", "Windows 2013" and "Windows 2015" on the latest mainline kernel 4.14rc6, and they all have the same errors and halt the system. The BIOS is also up to da

[Bug 103370] `DRI_PRIME=1 glxgears -info` halts the system with Intel Graphics [8086:5917] + AMD Graphics [1002:6665].

2017-10-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103370 --- Comment #10 from Mike Lothian --- Did this ever work for you? -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.freedesktop.org h

[Bug 103370] `DRI_PRIME=1 glxgears -info` halts the system with Intel Graphics [8086:5917] + AMD Graphics [1002:6665].

2017-10-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103370 --- Comment #11 from Shih-Yuan Lee --- (In reply to Mike Lothian from comment #10) > Did this ever work for you? What do you mean by this? -- You are receiving this mail because: You are the assignee for the bug.__

Re: [PATCH] drm/amd/powerplay: fix amd_powerplay_reset()

2017-10-24 Thread Dan Carpenter
On Tue, Oct 24, 2017 at 01:11:07PM +0300, Jani Nikula wrote: > On Tue, 24 Oct 2017, Dan Carpenter wrote: > > We accidentally inverted an if statement and turned amd_powerplay_reset() > > into a no-op. > > > > Fixes: ae97988fc89e ("drm/amd/powerplay: tidy up ret checks in > > amd_powerplay.c (v3)"

[Bug 103370] `DRI_PRIME=1 glxgears -info` halts the system with Intel Graphics [8086:5917] + AMD Graphics [1002:6665].

2017-10-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103370 --- Comment #12 from Shih-Yuan Lee --- BTW, this is a new Dell laptop in the development. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel

[Bug 103370] `DRI_PRIME=1 glxgears -info` halts the system with Intel Graphics [8086:5917] + AMD Graphics [1002:6665].

2017-10-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103370 --- Comment #13 from Mike Lothian --- I was meaning, is this a regression, as in it used to work with an older kernel or mesa. If it's a new system perhaps not. -- You are receiving this mail because: You are the assignee for the bug._

[Bug 103370] `DRI_PRIME=1 glxgears -info` halts the system with Intel Graphics [8086:5917] + AMD Graphics [1002:6665].

2017-10-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103370 --- Comment #14 from Shih-Yuan Lee --- Yup, this is a new system. `DRI_PRIME=1 glxgears` never worked properly before. -- You are receiving this mail because: You are the assignee for the bug.___ dri

[Bug 103370] `DRI_PRIME=1 glxgears -info` halts the system with Intel Graphics [8086:5917] + AMD Graphics [1002:6665].

2017-10-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103370 --- Comment #15 from Mike Lothian --- Are there any changes when you boot the system with radeon.runpm=0, this will mean the card never powers down What distro are you running? You mention trying older kernel version, did you try older mesa ve

[Bug 103370] `DRI_PRIME=1 glxgears -info` halts the system with Intel Graphics [8086:5917] + AMD Graphics [1002:6665].

2017-10-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103370 --- Comment #16 from Mike Lothian --- Do you also see the issue with amdgpu rather than using the radeon kernel driver? -- You are receiving this mail because: You are the assignee for the bug.___ dr

Re: [PATCH 1/4] drm/msm/dsi: convert to msm_clk_get()

2017-10-24 Thread Sean Paul
On Tue, Oct 17, 2017 at 06:49:55AM -0400, Rob Clark wrote: > We already have, as a result of upstreaming the gpu bindings, > msm_clk_get() which will try to get the clock both without and with a > "_clk" suffix. Use this in DSI code so we can drop the "_clk" suffix > in bindings while maintaing ba

Re: [PATCH 2/4] drm/msm/edp: convert to msm_clk_get()

2017-10-24 Thread Sean Paul
On Tue, Oct 17, 2017 at 06:49:56AM -0400, Rob Clark wrote: > We already have, as a result of upstreaming the gpu bindings, > msm_clk_get() which will try to get the clock both without and with a > "_clk" suffix. Use this in eDP code so we can drop the "_clk" suffix > in bindings while maintaing ba

Re: [PATCH 3/4] drm/msm/hdmi: convert to msm_clk_get()

2017-10-24 Thread Sean Paul
On Tue, Oct 17, 2017 at 06:49:57AM -0400, Rob Clark wrote: > We already have, as a result of upstreaming the gpu bindings, > msm_clk_get() which will try to get the clock both without and with a > "_clk" suffix. Use this in HDMI code so we can drop the "_clk" suffix > in bindings while maintaing b

Re: [Outreachy kernel] [PATCH v13 2/3] drm/tinydrm: Move tinydrm_of_find_backlight to backlight.c

2017-10-24 Thread Sean Paul
On Mon, Oct 23, 2017 at 11:35:42AM +0100, Daniel Thompson wrote: > On 20/10/17 18:20, Sean Paul wrote: > > On Wed, Oct 18, 2017 at 1:11 PM, Meghana Madhyastha > > wrote: > > > On Mon, Oct 16, 2017 at 02:26:00PM -0400, Sean Paul wrote: > > > > On Fri, Oct 13, 2017 at 6:42 PM, Noralf Trønnes > > >

[PATCH] drm/i915/gvt: Use common error handling code in shadow_workload_ring_buffer()

2017-10-24 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 24 Oct 2017 14:20:06 +0200 Add a jump target so that a call of the function "gvt_vgpu_err" is stored only once at the end of this function implementation. Replace two calls by goto statements. This issue was detected by using the Coccinelle software. Signed-off-b

Re: [PATCH] drm/i915/gvt: Use common error handling code in shadow_workload_ring_buffer()

2017-10-24 Thread Jani Nikula
On Tue, 24 Oct 2017, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 24 Oct 2017 14:20:06 +0200 > > Add a jump target so that a call of the function "gvt_vgpu_err" is stored > only once at the end of this function implementation. > Replace two calls by goto statements. > > This issue

Re: [Outreachy kernel] [PATCH v13 2/3] drm/tinydrm: Move tinydrm_of_find_backlight to backlight.c

2017-10-24 Thread Daniel Thompson
On 24/10/17 13:16, Sean Paul wrote: On Mon, Oct 23, 2017 at 11:35:42AM +0100, Daniel Thompson wrote: On 20/10/17 18:20, Sean Paul wrote: On Wed, Oct 18, 2017 at 1:11 PM, Meghana Madhyastha wrote: On Mon, Oct 16, 2017 at 02:26:00PM -0400, Sean Paul wrote: On Fri, Oct 13, 2017 at 6:42 PM, Nora

Re: drm/i915/gvt: Use common error handling code in shadow_workload_ring_buffer()

2017-10-24 Thread SF Markus Elfring
>> Add a jump target so that a call of the function "gvt_vgpu_err" is stored >> only once at the end of this function implementation. >> Replace two calls by goto statements. >> >> This issue was detected by using the Coccinelle software. > > I don't think this is an issue or an improvement. Do y

[PATCH 2/6] drm/msm: add special _get_vaddr_active() for cmdstream dumps

2017-10-24 Thread Rob Clark
Prep work for adding a debugfs file that dumps just submits which trigger hangs/faults. In this case the bo may already be in the MADV_DONTNEED state, but will be still on the active list (since the submit hasn't completed yet). So the normal check that the bo is in the WILLNEED state does not ap

[PATCH 0/6] drm/msm: GPU debugging enhancements

2017-10-24 Thread Rob Clark
Something that I've been using locally for a while, and found quite helpful for debugging gallium driver issues: 1) Better messages about what process triggered a crash, which is in particular particularly useful for piglit 2) Mechanism to dump just submits which triggered GPU hangs. Eventu

[PATCH 3/6] drm/msm: split rd debugfs file

2017-10-24 Thread Rob Clark
Split into two instances, the existing $debugfs/rd which continues to dump all submits, and $debugfs/hangrd which will be used to dump just submits that cause gpu hangs (and eventually faults, but that will require some iommu framework enhancements). Signed-off-by: Rob Clark --- drivers/gpu/drm/

[PATCH 1/6] drm/msm: show task cmdline in gpu recovery messages

2017-10-24 Thread Rob Clark
Now that freedreno gallium driver defaults to using submit_queue task (render reordering), just showing task->comm is not so useful (ie. it is always "flush_queue:0"), so also dump the cmdline. This should also be more useful for piglit/shader_runner. Signed-off-by: Rob Clark --- drivers/gpu/dr

[PATCH 4/6] drm/msm/rd: allow adding addition msg to top of dump

2017-10-24 Thread Rob Clark
For faults or hangs, it is nice to be able to include a bit more information. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_drv.h | 3 ++- drivers/gpu/drm/msm/msm_gpu.c | 2 +- drivers/gpu/drm/msm/msm_rd.c | 15 +-- 3 files changed, 16 insertions(+), 4 deletions(-) diff --

[PATCH 5/6] drm/msm: preserve IOVAs in submit's bo table

2017-10-24 Thread Rob Clark
We need this if we want to dump the submit after cleanup (ie. from hang or fault). But in the backoff/unpin case we want to clear them. So add a flag so we can skip clearing the IOVAs in at cleanup. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem_submit.c | 11 ++- 1 file chan

[PATCH 6/6] drm/msm: dump submits which triggered gpu hang

2017-10-24 Thread Rob Clark
Note we need to move update_fences() to after msm_rd_dump_submit(), otherwise the bo's referenced by the submit may no longer be valid. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gpu.c | 52 +-- 1 file changed, 30 insertions(+), 22 deletions(-)

Re: drm/i915/gvt: Use common error handling code in shadow_workload_ring_buffer()

2017-10-24 Thread Garry Hurley
Markus, I normally keep quiet on threads like this. I half agree with you. Yes, perhaps a reportError function would be a good idea, but it seems that what you are suggesting is trading an inline subroutine call for a spaghetti-code vondition. The goto is used only if you do not have any code

[PATCH 2/2] dma-buf: try to replace a signaled fence in reservation_object_add_shared_inplace

2017-10-24 Thread Christian König
From: Christian König The amdgpu issue to also need signaled fences in the reservation objects should be fixed by now. Optimize the handling by replacing a signaled fence when adding a new shared one. Signed-off-by: Christian König --- drivers/dma-buf/reservation.c | 18 +++--- 1

[PATCH 1/2] dma-buf: keep only not signaled fence in reservation_object_add_shared_replace

2017-10-24 Thread Christian König
From: Christian König The amdgpu issue to also need signaled fences in the reservation objects should be fixed by now. Optimize the list by keeping only the not signaled yet fences around. Signed-off-by: Christian König --- drivers/dma-buf/reservation.c | 31 +-- 1

[PATCH 0/2] GPU-DRM-i915-DP: Fine-tuning for two function implementations

2017-10-24 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 24 Oct 2017 15:54:32 +0200 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an unnecessary goto statement in intel_dp_sink_crc() Use common error handling code in intel_dp_sink_crc_stop() drivers/gpu

[PATCH 1/2] drm/i915/dp: Delete an unnecessary goto statement in intel_dp_sink_crc()

2017-10-24 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 24 Oct 2017 15:15:20 +0200 A jump was specified for a location which was directly behind. Thus remove such an unnecessary goto statement. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/gpu/drm/i915/intel_dp.c

[PATCH 2/2] drm/i915/dp: Use common error handling code in intel_dp_sink_crc_stop()

2017-10-24 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 24 Oct 2017 15:40:47 +0200 Adjust jump targets so that a specific error code assignment will be in the implementation only at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/gpu/drm/i

Re: drm/i915/gvt: Use common error handling code in shadow_workload_ring_buffer()

2017-10-24 Thread Dan Carpenter
The point of unwind code is to undo what was done earlier. If a function allocates a list of things, using standard unwind style makes it simpler, safer and more readable. This isn't the case here. Instead of making the code more readable, we're making it more convoluted. It's just that two out

[Bug 103384] [UBUNTU 16.04] Poor performance after update video-driver (HD7790, radeonsi)

2017-10-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103384 --- Comment #4 from Max --- Created attachment 135021 --> https://bugs.freedesktop.org/attachment.cgi?id=135021&action=edit X.Org log file req -- You are receiving this mail because: You are the assignee for the bug._

Re: drm/i915/gvt: Use common error handling code in shadow_workload_ring_buffer()

2017-10-24 Thread SF Markus Elfring
> This isn't the case here. I find your view interesting for further clarification somehow. > Instead of making the code more readable, we're making it more convoluted. Can the shown software refactoring usually help here? > It's just that two out of three error messages happened to be the sa

Re: drm/i915/gvt: Use common error handling code in shadow_workload_ring_buffer()

2017-10-24 Thread Joe Perches
On Tue, 2017-10-24 at 17:26 +0300, Dan Carpenter wrote: > The point of unwind code is to undo what was done earlier. If a > function allocates a list of things, using standard unwind style makes > it simpler, safer and more readable. > > This isn't the case here. Instead of making the code more

Re: drm/i915/gvt: Use common error handling code in shadow_workload_ring_buffer()

2017-10-24 Thread SF Markus Elfring
>> … It's just that two out of three error >> messages happened to be the same and Markus wants to save a bit of >> memory by using the same string. The memory savings is not so big that >> it's worth making the code less readable. > > I agree with Dan. > > It doesn't save any real memory eithe

Re: drm/i915/gvt: Use common error handling code in shadow_workload_ring_buffer()

2017-10-24 Thread Joe Perches
On Tue, 2017-10-24 at 16:51 +0200, SF Markus Elfring wrote: > Do you prefer to delegate the proposed software refactoring > only to a corresponding optimiser? yes. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/m

Re: drm/i915/gvt: Use common error handling code in shadow_workload_ring_buffer()

2017-10-24 Thread SF Markus Elfring
>> Do you prefer to delegate the proposed software refactoring >> only to a corresponding optimiser? > > yes. Will any applications around the semantic patch language (Coccinelle software) fit also in the preferred tool category? Regards, Markus ___ dr

Re: [Outreachy kernel] [PATCH v13 2/3] drm/tinydrm: Move tinydrm_of_find_backlight to backlight.c

2017-10-24 Thread Sean Paul
On Tue, Oct 24, 2017 at 01:51:45PM +0100, Daniel Thompson wrote: > On 24/10/17 13:16, Sean Paul wrote: > > On Mon, Oct 23, 2017 at 11:35:42AM +0100, Daniel Thompson wrote: > > > On 20/10/17 18:20, Sean Paul wrote: > > > > On Wed, Oct 18, 2017 at 1:11 PM, Meghana Madhyastha > > > > wrote: > > > > >

Re: [Outreachy kernel] [PATCH v14 1/3] drm/tinydrm: Move helper functions from tinydrm-helpers to backlight.h

2017-10-24 Thread Sean Paul
On Sat, Oct 21, 2017 at 05:26:33PM +0530, Meghana Madhyastha wrote: > Move the helper functions enable_backlight and disable_backlight > from tinydrm-helpers.c to backlight.h as static inline functions so > that they can be used by other drivers. > > Signed-off-by: Meghana Madhyastha Reviewed-by

Re: [Outreachy kernel] [PATCH v14 2/3] drm/tinydrm: Move tinydrm_of_find_backlight to backlight.c

2017-10-24 Thread Sean Paul
On Sat, Oct 21, 2017 at 05:27:33PM +0530, Meghana Madhyastha wrote: > Rename tinydrm_of_find_backlight to of_find_backlight and move > it to linux/backlight.c so that it can be used by other drivers. > > Signed-off-by: Meghana Madhyastha > --- > Changes in v14: > -s/backlight_get/of_find_backlig

Re: [Outreachy kernel] [PATCH v14 2/3] drm/tinydrm: Move tinydrm_of_find_backlight to backlight.c

2017-10-24 Thread Sean Paul
On Sat, Oct 21, 2017 at 05:27:33PM +0530, Meghana Madhyastha wrote: > Rename tinydrm_of_find_backlight to of_find_backlight and move > it to linux/backlight.c so that it can be used by other drivers. > > Signed-off-by: Meghana Madhyastha > --- > Changes in v14: > -s/backlight_get/of_find_backlig

Re: [PATCH] drm/amd/display: assign fb_location only if bo is pinned

2017-10-24 Thread Michel Dänzer
[ Adding the dri-devel list ] On 24/10/17 04:58 PM, Andrey Grodzovsky wrote: > On 10/24/2017 10:36 AM, S, Shirish wrote: >> On 10/24/2017 7:48 PM, Andrey Grodzovsky wrote: >>> On 10/24/2017 09:51 AM, S, Shirish wrote: From: Shirish S On some systems amdgpu_bo_gpu_offset seems to b

Re: [PATCH 2/4] dt-bindings: display: amlogic, meson-dw-hdmi: Add optional HDMI 5V regulator

2017-10-24 Thread Rob Herring
On Tue, Oct 24, 2017 at 10:09:15AM +0200, Neil Armstrong wrote: > On 24/10/2017 00:46, Rob Herring wrote: > > On Tue, Oct 17, 2017 at 10:07:42AM +0200, Neil Armstrong wrote: > >> On reference boards and derivatives, the HDMI Logic is powered by an > >> external > >> 5V regulator. > >> This regulat

Re: [Outreachy kernel] [PATCH v14 2/3] drm/tinydrm: Move tinydrm_of_find_backlight to backlight.c

2017-10-24 Thread Daniel Thompson
On 24/10/17 16:38, Sean Paul wrote: On Sat, Oct 21, 2017 at 05:27:33PM +0530, Meghana Madhyastha wrote: Rename tinydrm_of_find_backlight to of_find_backlight and move it to linux/backlight.c so that it can be used by other drivers. Signed-off-by: Meghana Madhyastha --- Changes in v14: -s/bac

[PATCH 0/2] R-Car Display Unit: Fine-tuning for some function implementations

2017-10-24 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 24 Oct 2017 17:55:43 +0200 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Use common error handling code in rcar_du_encoders_init() Adjust 14 checks for null pointers drivers/gpu/drm/rcar-du/rcar_du_crtc.

Re: [PATCH 02/10] drm/sun4i: tcon: Add support for A10 TCON

2017-10-24 Thread Rob Herring
On Tue, Oct 17, 2017 at 08:17:59PM +0800, Chen-Yu Tsai wrote: > From: Jonathan Liu > > The A10 has two TCONs that are similar to the ones found on other SoCs. > Like the A31, TCON0 has a register used to mux the TCON outputs to the > downstream encoders. The bit fields are slightly different. >

[PATCH 1/2] drm/rcar-du: Use common error handling code in rcar_du_encoders_init()

2017-10-24 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 24 Oct 2017 17:16:09 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/gpu/drm/rcar-du/rcar_du_kms.c

[PATCH 2/2] drm/rcar-du: Adjust 14 checks for null pointers

2017-10-24 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 24 Oct 2017 17:47:37 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written !… Thus fix the affected source code pl

Re: [PATCH] drm/amd/display: assign fb_location only if bo is pinned

2017-10-24 Thread Michel Dänzer
On 24/10/17 06:00 PM, Andrey Grodzovsky wrote: > On 10/24/2017 11:43 AM, Michel Dänzer wrote: >> On 24/10/17 04:58 PM, Andrey Grodzovsky wrote: >>> On 10/24/2017 10:36 AM, S, Shirish wrote: On 10/24/2017 7:48 PM, Andrey Grodzovsky wrote: > On 10/24/2017 09:51 AM, S, Shirish wrote: >> F

Re: [PATCH 2/2] drm/i915/dp: Use common error handling code in intel_dp_sink_crc_stop()

2017-10-24 Thread Jani Nikula
On Tue, 24 Oct 2017, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 24 Oct 2017 15:40:47 +0200 > > Adjust jump targets so that a specific error code assignment > will be in the implementation only at the end of this function. This is not an issue that needs to be "fixed". > > This

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

2017-10-24 Thread Jordan Crouse
On Mon, Oct 23, 2017 at 05:55:37PM +0200, Benjamin Gaignard wrote: > Instead a getting only one common device "/dev/ion" for > all the heaps this patch allow to create one device > entry ("/dev/ionX") per heap. > Getting an entry per heap could allow to set security rules > per heap and global ones

Re: [PATCH] drm/amd/display: assign fb_location only if bo is pinned

2017-10-24 Thread Andrey Grodzovsky
On 10/24/2017 11:43 AM, Michel Dänzer wrote: [ Adding the dri-devel list ] On 24/10/17 04:58 PM, Andrey Grodzovsky wrote: On 10/24/2017 10:36 AM, S, Shirish wrote: On 10/24/2017 7:48 PM, Andrey Grodzovsky wrote: On 10/24/2017 09:51 AM, S, Shirish wrote: From: Shirish S On some systems am

Re: [PATCH] drm/i915/selftests: Convert timers to use timer_setup()

2017-10-24 Thread Chris Wilson
Quoting Kees Cook (2017-10-24 16:13:44) > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi

Re: [PATCH 03/10] drm/sun4i: hdmi: Support HDMI controller on A10

2017-10-24 Thread Rob Herring
On Tue, Oct 17, 2017 at 08:18:00PM +0800, Chen-Yu Tsai wrote: > The HDMI controller in the A10 SoC is the same as the one currently > supported in the A10s. It has slightly different setup parameters. > Since these parameters are not thoroughly understood, we add support > for this variant by copyi

Re: [PATCH 04/10] drm/sun4i: Add support for A10 display pipeline components

2017-10-24 Thread Rob Herring
On Tue, Oct 17, 2017 at 08:18:01PM +0800, Chen-Yu Tsai wrote: > The A10 display pipeline has 2 frontends, 2 backends, and 2 TCONs. > This patch adds support (or a compatible string in the frontend's > case) for these components. > > The TCONs support directly outputting to CPU/RGB/LVDS LCD panels,

Re: [PATCH 05/10] drm/sun4i: Add support for A20 display pipeline components

2017-10-24 Thread Rob Herring
On Tue, Oct 17, 2017 at 08:18:02PM +0800, Chen-Yu Tsai wrote: > From: Jonathan Liu > > The A20 display pipeline has 2 frontends, 2 backends, and 2 TCONs. > This patch adds support (or a compatible string in the frontend's > case) for these components. > > The TCONs support directly outputting to

Re: [PATCH 05/10] drm/sun4i: Add support for A20 display pipeline components

2017-10-24 Thread Rob Herring
On Tue, Oct 17, 2017 at 08:18:02PM +0800, Chen-Yu Tsai wrote: > From: Jonathan Liu > > The A20 display pipeline has 2 frontends, 2 backends, and 2 TCONs. > This patch adds support (or a compatible string in the frontend's > case) for these components. > > The TCONs support directly outputting to

Re: [PATCH 06/10] clk: sunxi-ng: sun4i: Export video PLLs

2017-10-24 Thread Rob Herring
On Tue, Oct 17, 2017 at 08:18:03PM +0800, Chen-Yu Tsai wrote: > From: Jonathan Liu > > The video PLLs are used directly by the HDMI controller. Export them so > that we can use them in our DT node. > > Signed-off-by: Jonathan Liu > Signed-off-by: Chen-Yu Tsai > --- > drivers/clk/sunxi-ng/ccu-

Re: [PATCH] drm/framebuffer: Add framebuffer debugfs file

2017-10-24 Thread Noralf Trønnes
Den 23.10.2017 23.32, skrev Kristian Høgsberg: On Mon, Oct 23, 2017 at 9:47 AM, Noralf Trønnes wrote: Add debugfs file that dumps info about the framebuffers and its planes. Also dump info about any connected gem object(s). Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_debugfs.c

Re: [Outreachy kernel] [PATCH v14 2/3] drm/tinydrm: Move tinydrm_of_find_backlight to backlight.c

2017-10-24 Thread Noralf Trønnes
Den 24.10.2017 17.42, skrev Sean Paul: On Sat, Oct 21, 2017 at 05:27:33PM +0530, Meghana Madhyastha wrote: Rename tinydrm_of_find_backlight to of_find_backlight and move it to linux/backlight.c so that it can be used by other drivers. Signed-off-by: Meghana Madhyastha --- Changes in v14: -s

[PATCH v2 1/2] drm: drm_vblank_cleanup: WARN when refcount > 0

2017-10-24 Thread PrasannaKumar Muralidharan
Warn when refcount > 0 in drm_vblank_cleanup. Signed-off-by: PrasannaKumar Muralidharan --- No change in v2. drivers/gpu/drm/drm_vblank.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/drm_vblank.c b/drivers/gpu/drm/drm_vblank.c index 70f2b95..3e61aeb 100644 --- a/drivers

[PATCH v2 2/2] Test case for drm_vblank_cleanup refcount validation patch

2017-10-24 Thread PrasannaKumar Muralidharan
In i915 driver unload drm_vblank_get is added to test whether drm_vblank_cleanup refcount validation patch is working. Signed-off-by: PrasannaKumar Muralidharan --- Changes in v2: Use drm_crtc_vblank_get instead of _put. In previous patch _put was wrongly used. drivers/gpu/drm/i915/i915_drv.c |

[Bug 193651] Amdgpu error messages at boot with Amd RX460

2017-10-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=193651 --- Comment #27 from Milo (milo...@gmail.com) --- i have added it /etc/default/grub as follows: GRUB_CMDLINE_LINUX_DEFAULT="nointremap quiet amdgpu.audio=0" and then ran update-grub however it still takes more than 5 minutes to boot On Mon, Oct

[PATCH 0/2] GPU-DRM-Tegra: Fine-tuning for tegra_output_probe()

2017-10-24 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 24 Oct 2017 19:29:39 +0200 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Use common error handling code Use an error code directly drivers/gpu/drm/tegra/output.c | 13 +++-- 1 file changed, 7 ins

[PATCH 1/2] drm/tegra: Use common error handling code in tegra_output_probe()

2017-10-24 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 24 Oct 2017 19:12:09 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/gpu/drm/tegra/output.c | 10 ++

  1   2   >