https://bugs.freedesktop.org/show_bug.cgi?id=100443
--- Comment #34 from Devin Prince ---
Having this same issue on kernel 4.13.5-1-ARCH.
CPU: AMD R7-1700X
Motherboard: AsRock Taichi X370
GPU: XFX RX-480 8GB
I have found a temporary solution that seems to allow me to actually boot and
use the c
Hello,
There are two checks for dm_444_16on line 2943.
julia
-- Forwarded message --
Date: Fri, 13 Oct 2017 08:24:34 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: [radeon-alex:amd-staging-drm-next 120/173]
drivers/gpu/drm/amd/amdgpu/../display/dc
On 12.10.2017 19:55, Sean Paul wrote:
> This patch adds state tracking to the drm_panel functions which keep
> track of enabled and prepared. If the calls are unbalanced, a WARNING is
> issued.
>
> The motivation for this change is that a number of panel drivers
> (including panel-simple) all do th
Hello Hans,
12.10.2017 20:10, Hans de Goede wrote:
> The x and y hints receives from the host are unsigned 32 bit integers and
> they get set to -1 (0x) when invalid. Before this commit the
> vboxvideo driver was storing them in an u16 causing the -1 to be truncated
> to 65535 which, once
On Thu, Oct 12, 2017 at 12:24:10PM +0100, Julien Thierry wrote:
> Hi Bjorn,
>
> On 06/10/17 23:24, Bjorn Helgaas wrote:
> >From: Bjorn Helgaas
> >
> >Daniel Axtens reported that on the HiSilicon D05 board, the VGA device is
> >behind a bridge that doesn't support PCI_BRIDGE_CTL_VGA, so the VGA ar
Hi Bjorn,
On 06/10/17 23:24, Bjorn Helgaas wrote:
From: Bjorn Helgaas
Daniel Axtens reported that on the HiSilicon D05 board, the VGA device is
behind a bridge that doesn't support PCI_BRIDGE_CTL_VGA, so the VGA arbiter
never selects it as the default, which means Xorg auto-detection doesn't
w
Prefer kcalloc over kzalloc to allocate an array.
This patch fixes checkcpatch issue.
Signed-off-by: Harsha Sharma
---
drivers/gpu/drm/drm_crtc_helper.c | 4 ++--
drivers/gpu/drm/drm_fb_helper.c| 2 +-
drivers/gpu/drm/drm_plane_helper.c | 2 +-
3 files changed, 4 insertions(+), 4 deletions(
Hi,
On Wed, Aug 23, 2017 at 12:33:08PM +0300, Tomi Valkeinen wrote:
> On 13/06/17 12:02, Tomi Valkeinen wrote:
> > Seems that on omap3 enabling a crtc without any planes causes a sync
> > lost flood. This only happens on the first enable, and after that it
> > works. This looks like an HW issue.
>
On Fri, Oct 06, 2017 at 05:24:20PM -0500, Bjorn Helgaas wrote:
> These patches are supposed to fix a problem Daniel Axtens found on the
> HiSilicon D05 board. The VGA device there is behind a bridge that doesn't
> support PCI_BRIDGE_CTL_VGA, so the arbiter never selects the device as the
> default
Fixed problem with DisplayLink and DisplayLink certified adapers in drm/udl
driver when adapter doesn't want to work if it was initialized with
disconnected DVI cable by enabling drm connectot polling and updating
current connector's state.
Signed-off-by: Robert Tarasov
---
drivers/gpu/drm/udl/u
Now DRM/UDL driver retreives all edid data blocks instead of only base one.
Previous approch could lead to improper initialization of video mode with
certain monitors.
Signed-off-by: Robert Tarasov
---
drivers/gpu/drm/udl/udl_connector.c | 106 +++-
1 file changed
On Thu, Oct 12, 2017 at 12:39:25PM +0300, Jyri Sarha wrote:
> We are using the vrefresh to check if we are too close to vertical
> sync to update the two framebuffer DMA registers and risk a
> collision. The vrefresh is coming from user space and normally it is
> not used for anything. For instance
Hi,
On Thu, 12 Oct 2017 12:24:10 +0100 Julien Thierry wrote:
> Hi Bjorn,
>
> On 06/10/17 23:24, Bjorn Helgaas wrote:
> > From: Bjorn Helgaas
> >
> > Daniel Axtens reported that on the HiSilicon D05 board, the VGA device is
> > behind a bridge that doesn't support PCI_BRIDGE_CTL_VGA, so the VGA
On 12/10/17 13:05, Lothar Waßmann wrote:
Hi,
On Thu, 12 Oct 2017 12:24:10 +0100 Julien Thierry wrote:
Hi Bjorn,
On 06/10/17 23:24, Bjorn Helgaas wrote:
From: Bjorn Helgaas
Daniel Axtens reported that on the HiSilicon D05 board, the VGA device is
behind a bridge that doesn't support PCI_BR
Fixed.
On Thu, Oct 12, 2017 at 12:56 PM, Alex Deucher
wrote:
> On Wed, Oct 11, 2017 at 4:41 PM, Robert Tarasov
> wrote:
> > Fixed problem with DisplayLink and DisplayLink certified adapters when
> they
> > didn't want to work if they were initialized with disconnected DVI
> cable. Now
> > udl d
On 12/10/17 07:49 PM, Alex Deucher wrote:
> On Thu, Oct 12, 2017 at 1:02 PM, Christian König
> wrote:
>> Am 12.10.2017 um 18:20 schrieb Michel Dänzer:
>>> On 12/10/17 05:58 PM, Alex Deucher wrote:
Hi Dave,
One memory management regression fix.
The following changes si
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
On 12/10/17 17:16, Jyri Sarha wrote:
> We need the frame refresh time to check if we are too close to
> vertical sync when updating the two framebuffer DMA registers an
On Fri, 13 Oct 2017, Dave Airlie wrote:
> On 13 October 2017 at 01:23, Jani Nikula wrote:
>> On Wed, 11 Oct 2017, Jani Nikula wrote:
>>> Hi Dave, more v4.15 features.
>>
>> Okay, so I suck and there's still one more batch to come after this. I'm
>> a bit out of rhythm here. When do you want the
On Fri, 13 Oct 2017, Harsha Sharma wrote:
> Prefer kcalloc over kzalloc to allocate an array.
> This patch fixes checkcpatch issue.
>
> Signed-off-by: Harsha Sharma
Reviewed-by: Jani Nikula
> ---
> Changes in v2:
> -kcalloc will take 3 arguments
>
> drivers/gpu/drm/drm_crtc_helper.c | 4 ++
Hi,
On 09/26/2017 01:25 PM, Nickey Yang wrote:
This patch correct Feedback divider setting:
1、Set Feedback divider [8:5] when HIGH_PROGRAM_EN
2、Due to the use of a "by 2 pre-scaler," the range of the
feedback multiplication Feedback divider is limited to even
division numbers, and Feedback divid
Hi,
Comment below.
On 09/26/2017 01:25 PM, Nickey Yang wrote:
This patch add dual mipi channel support:
1.add definition of dsi1 register and grf operation.
2.dsi0 and dsi1 will work in master and slave mode
when driving dual mipi panel.
@@ -1226,6 +1367,13 @@ static int rockchip_mipi_pa
Am 13.10.2017 um 09:41 schrieb Michel Dänzer:
On 12/10/17 07:49 PM, Alex Deucher wrote:
On Thu, Oct 12, 2017 at 1:02 PM, Christian König
wrote:
Am 12.10.2017 um 18:20 schrieb Michel Dänzer:
On 12/10/17 05:58 PM, Alex Deucher wrote:
Hi Dave,
One memory management regression fix.
The followi
On Thu, 12 Oct 2017, Shashank Sharma wrote:
> From the CI builds, its been observed that during a driver
> reload/insert, dp dual mode read function sometimes fails to
> read from LSPCON device over i2c-over-aux channel.
>
> This patch:
> - adds some delay and few retries, allowing a scope for the
We need the total frame refresh time to check if we are too close to
vertical sync when updating the two framebuffer DMA registers and risk
a collision. This new method is more accurate that the previous that
based on mode's vrefresh value, which itself is inaccurate or may not
even be initialized.
Move drm helper functions from tinydrm-helpers to linux/backlight for
ease of use by callers in other drivers.
Changes in v13:
-Rebase against drm-misc
-Put devm_backlight_put back
Meghana Madhyastha (3):
drm/tinydrm: Move helper functions from tinydrm-helpers to backlight.h
drm/tinydrm: Move
Move the helper functions enable_backlight and disable_backlight
from tinydrm-helpers.c to backlight.h as static inline functions so
that they can be used by other drivers.
Signed-off-by: Meghana Madhyastha
---
Changes in v13:
-None
drivers/gpu/drm/tinydrm/core/tinydrm-helpers.c | 55 -
Rename tinydrm_of_find_backlight to backlight_get and move it
to linux/backlight.c so that it can be used by other drivers.
Signed-off-by: Meghana Madhyastha
---
Changes in v13:
-Add backlight_put to backlight.h in this patch
drivers/gpu/drm/tinydrm/core/tinydrm-helpers.c | 40
Add devm_backlight_get and the corresponding release
function because some drivers use devres versions of functions
for requiring device resources.
Signed-off-by: Meghana Madhyastha
---
Changes in v13:
-Add devm_backlight_put to backlight.c
drivers/gpu/drm/tinydrm/mi0283qt.c | 2 +-
drivers/
Hi Dave,
A few fixes for 4.14..
The following changes since commit 545036a9944e9d6e50fed4ca03117147c880ff71:
Merge tag 'drm-misc-fixes-2017-10-11' of
git://anongit.freedesktop.org/drm/drm-misc into drm-fixes (2017-10-12
10:38:09 +1000)
are available in the git repository at:
git://people.f
Hi,
On 13-10-17 08:26, Michael Thayer wrote:
Hello Hans,
12.10.2017 20:10, Hans de Goede wrote:
The x and y hints receives from the host are unsigned 32 bit integers and
they get set to -1 (0x) when invalid. Before this commit the
vboxvideo driver was storing them in an u16 causing the
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
On 13/10/17 12:35, Jyri Sarha wrote:
> We need the total frame refresh time to check if we are too close to
> vertical sync when updating the two framebuffer DMA regist
Hi Dave,
this time around we have a bunch more patches, compared to the last
cycles.
Most notable addition this time is the support for the GPU performance
counters by Christian. This has been in the making for some time and it
has matured a lot. Since this is adding UAPI, the corresponding WIP
u
https://bugs.freedesktop.org/show_bug.cgi?id=100443
--- Comment #35 from Devin Prince ---
Upon further investigation, I would like to ammend my previous comment.
Setting amdgpu.dpm=0 will allow you to bypass those errors by disabling dpm
altogether, but the consequence is that the fans will stop
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
On 10/13/17 14:04, Tomi Valkeinen wrote:
>> +uint tilcdc_mode_hvtotal(const struct drm_display_mode *mode)
>> +{
>> +uint ret;
>> +
>> +ret = (uint) div_u64(100
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
On 10/13/17 10:47, Stephen Boyd wrote:
> of_fdt_unflatten_tree() already sets the flag on this node to
> OF_DETACHED, because of_fdt_unflatten_tree() calls
> __unflatte
Michel, gentle ping to you.
With that patch applied piglit seems to be stable on my Tonga (with a
bit older Mesa).
Christian.
Am 12.10.2017 um 19:30 schrieb Christian König:
From: Christian König
We don't use compound pages at the moment. Take this into account when
freeing them.
Signed-o
This message contains a digitally signed email which can be read by opening
the attachment.
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
--- Begin Message ---
On 13/10/17 15:00, Jyri Sarha wrote:
> On 10/13/17 14
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
On 10/13/17 15:32, Tomi Valkeinen wrote:
> Where does "uint" come from anyway? I don't think it's part of a C standard.
AFAIK, it is just a Linux commodity typedef for
On Fri, Sep 01, 2017 at 07:44:46PM +0200, Thierry Reding wrote:
> On Fri, Sep 01, 2017 at 07:53:26PM +0300, ville.syrj...@linux.intel.com wrote:
> > From: Ville Syrjälä
> >
> > 'user_handles' needs a __user annotation for fix the following sparse
> > warning:
> > drm_syncobj.c:813:37: warning: in
On 12/10/17 07:30 PM, Christian König wrote:
> From: Christian König
>
> We don't use compound pages at the moment. Take this into account when
> freeing them.
>
> Signed-off-by: Christian König
> ---
> drivers/gpu/drm/ttm/ttm_page_alloc.c | 21 -
> 1 file changed, 16 inser
From: Steven Rostedt (VMware)
Commit e941759c74 ("fence: dma-buf cross-device synchronization") added
trace event fence_annotate_wait_on, but never used it. It was renamed
to dma_fence_annotate_wait_on by commit f54d186700 ("dma-buf: Rename
struct fence to dma_fence") but still not used. As defin
Op 12-10-17 om 14:05 schreef Daniel Vetter:
> Hi Dave,
>
> drm-misc-next-2017-10-12:
> More 4.15 drm-misc stuff:
>
> Cross-subsystem Changes:
> - bridge cleanup refactor (Benjamin Gaignard)
>
> Core Changes:
> - less surprising atomic iterators (Maarten), fixes an oops introduced
> in drm-next
>
This ioctl will allow us to purge inactive userspace buffers when the
system is running out of contiguous memory.
For now, the purge logic is rather dumb in that it does not try to
release only the amount of BO needed to meet the last CMA alloc request
but instead purges all objects placed in the
2017-10-13 16:08 GMT+02:00 Maarten Lankhorst
:
> Op 12-10-17 om 14:05 schreef Daniel Vetter:
>> Hi Dave,
>>
>> drm-misc-next-2017-10-12:
>> More 4.15 drm-misc stuff:
>>
>> Cross-subsystem Changes:
>> - bridge cleanup refactor (Benjamin Gaignard)
>>
>> Core Changes:
>> - less surprising atomic itera
On 13/10/17 11:40, Meghana Madhyastha wrote:
Move the helper functions enable_backlight and disable_backlight
from tinydrm-helpers.c to backlight.h as static inline functions so
that they can be used by other drivers.
Signed-off-by: Meghana Madhyastha
---
diff --git a/include/linux/backlight.h
On 13/10/17 11:41, Meghana Madhyastha wrote:
Rename tinydrm_of_find_backlight to backlight_get and move it
to linux/backlight.c so that it can be used by other drivers.
Signed-off-by: Meghana Madhyastha
Acked-by: Daniel Thompson
---
Changes in v13:
-Add backlight_put to backlight.h in t
On 13/10/17 11:42, Meghana Madhyastha wrote:
Add devm_backlight_get and the corresponding release
function because some drivers use devres versions of functions
for requiring device resources.
s/requiring/acquiring/
Signed-off-by: Meghana Madhyastha
With the above fixed:
Acked-by: Daniel
Hi Meghana,
On Fri, Oct 13, 2017 at 04:09:27PM +0530, Meghana Madhyastha wrote:
> Move drm helper functions from tinydrm-helpers to linux/backlight for
> ease of use by callers in other drivers.
I've been a bit overloaded past few days, so didn't get around to looking
at any of your patches yet,
On Fri, Oct 13, 2017 at 08:03:59PM +0530, Harsha Sharma wrote:
> On Mon, Oct 9, 2017 at 5:36 PM, Harsha Sharma
> wrote:
> > Replace instances of drm_framebuffer_reference/unreference() with
> > *_get/put() suffixes and drm_dev_unref with *_put() suffix
> > because get/put is shorter and consistent
On Fri, Oct 13, 2017 at 04:51:38PM +0200, Daniel Vetter wrote:
> On Fri, Oct 13, 2017 at 08:03:59PM +0530, Harsha Sharma wrote:
> > On Mon, Oct 9, 2017 at 5:36 PM, Harsha Sharma
> > wrote:
> > > Replace instances of drm_framebuffer_reference/unreference() with
> > > *_get/put() suffixes and drm_de
There's no need to print an error message on probe deferral, that's a
normal situation. Probe deferral debugging can be performed by enabling
the related debug messages in the drivers core.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c | 3 ++-
1 file chan
The omap_dss_find_device() function is unused. Remove it.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/dss/display.c | 14 --
drivers/gpu/drm/omapdrm/dss/omapdss.h | 3 ---
2 files changed, 17 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/dss/display.c
b/drivers
The omap_gem_resume() function is internal to the driver. Pass it a
drm_device pointer that the caller already has instead of looking it up
from device data.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/omap_drv.c | 2 +-
drivers/gpu/drm/omapdrm/omap_drv.h | 2 +-
drivers/gpu/drm/
Hello,
This patch series merges the omapdrm and omapdss drivers into a single driver
called omapdrm. The split in two drivers was historical, in order to support
the FBDEV, V4L2 and DRM/KMS APIs. Now that the driver supports DRM/KMS only
there's no need to keep two seperate drivers.
The series st
The dpi_data structure port_initialized field is used to check in the
cleanup path whether the DPI has been initialized. This can be performed
through the associated device_node data field instead. Remove the
port_initialized field.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/dss
There's no need for the omapdss-base code to be part of a separate
module. Merge it with the omapdss module. This allows removing the
exports for internal symbols.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/dss/Kconfig | 4
drivers/gpu/drm/omapdrm/dss/Makefile | 19
The venc_probe_of() function has an error cleanup path that returns
success instead of an error code. Fix it.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/dss/venc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/dss/venc.c
b/drive
The function isn't used outside of its compilation unit, make it static.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/dss/dss.c | 4 +++-
drivers/gpu/drm/omapdrm/dss/dss.h | 1 -
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/dss/dss.c
b/dr
The number of function declarations in the omap_drv.h degrades
readability. To fix it, create new header files for each part of the
driver and move the related functions.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/omap_connector.h | 37 +
drivers/gpu/drm/omapdrm/omap_cr
The standard kernel integer types are [us]{8,16,32}. Use them instead of
the u?int{8,16,32}_t types.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/omap_crtc.c | 12 -
drivers/gpu/drm/omapdrm/omap_crtc.h | 2 +-
drivers/gpu/drm/omapdrm/omap_dmm_priv.h | 10 +++---
When merging the omapdrm and omapdss drivers the omapdrm virtual
platform device will disappear, and the omapdss platform device will be
used for DMA memory allocation. To prepare for that, set the DMA
coherent mask for the device.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/dss/
The kernel favours 'unsigned int' over plain 'unsigned'. Replace all
occurences of the latter by the former. This avoid lots of checkpatch
complaints in patches that touch lines where a plain 'unsigned' is used.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
The tvc_of_match variable is never referenced before its definition.
Remove the forward declaration.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/displays/connector-analog-t
When merging the omapdrm and omapdss drivers there will be not omapdrm
platform device anymore, and thus no associated probe and remove
functions. To prepare for that, split all the initialization code from
the probe function to make it usable without a platform device.
Similarly, split the cleanup
The connector drivers need a handle to the source they are connected to
in order to control the source.
All drivers get that handle at probe time, resulting in probe deferral
when the source hasn't been probed yet. However they don't need the
handle until their connect handler is called.
Move ret
The connector drivers need a handle to the source they are connected to
in order to control the source.
All drivers get that handle at probe time, resulting in probe deferral
when the source hasn't been probed yet. However they don't need the
handle until their connect handler is called.
Move ret
No encoder is instantiated through platform data anymore, there is no
need to check for OF node presence.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/displays/encoder-opa362.c| 5 -
drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c| 3 ---
drivers/gpu/drm/omapdrm/disp
No connector is instantiated through platform data anymore, there is no
need to check for OF node presence.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c | 3 ---
drivers/gpu/drm/omapdrm/displays/connector-dvi.c | 3 ---
drivers/gpu/drm/omapdrm/
No panel is instantiated through platform data anymore, there is no
need to check for OF node presence.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/displays/panel-dpi.c| 3 ---
drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 3 ---
drivers/gpu/drm/om
To simplify implementation of debugfs seq_file show handlers, the driver
passes the pointer to the show function through the debugfs_create_file
data pointer. This prevents using the pointer to pass driver private
data to the show handler, and requires all handlers to use global
variables to access
The encoder drivers need a handle to the source they are connected to in
order to control the source.
All drivers get that handle at probe time, resulting in probe deferral
when the source hasn't been probed yet. However they don't need the
handle until their connect handler is called.
Move retri
This removes the need to access the global DSS private data in those
functions (both for the current accesses and the future ones that will
be introduced when allocating the DSS device dynamically).
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/dss/dss.c | 8
drivers/gpu/
This removes the need to access the global DSS private data in those
functions (both for the current accesses and the future ones that will
be introduced when allocating the DSS device dynamically).
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/dss/dpi.c | 12 ---
drivers/gpu
To prepare for the removal of the global variable storing DSS private
data, pass its pointer to the dss_runtime_{get,put}() functions.
As this requires getting hold of the DSS private structure in the
callers, we expose the structure through an opaque pointer that can be
retrieved through a new ds
This removes the need to access the global DSS private data in those
functions (both for the current accesses and the future ones that will
be introduced when allocating the DSS device dynamically).
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/dss/dispc.c | 11 +++
drivers
This will allow accessing the PLL data to get the DSS device pointer,
removing the need to access the global DSS private data.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/dss/dss.c | 13 +++--
drivers/gpu/drm/omapdrm/dss/dss.h | 2 +-
drivers/gpu/drm/omapdrm/
This removes the need to access the global DSS private data in those
functions (both for the current accesses and the future ones that will
be introduced when allocating the DSS device dynamically).
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/dss/dispc.c | 2 +-
drivers/gpu/drm/
The split between the omapdss and omapdrm driver is historic and was due
to other userspace APIs (FBDEV and V4L2) being supported in addition to
DRM/KMS. Now that the drivers only supports the DRM/KMS API, there is no
need to keep them separate anymore.
Merge the two drivers and remove the now unn
The sdi private data structure is currently stored as a global
variable. While no platform with multiple SDI encoders currently exists
nor is planned, this doesn't comply with the kernel device model and
should thus be fixed.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/dss/sdi.c
The wait_for_bit_change() function returns the value of the bit it
polls. This requires the caller to compare the return value to the
expected bit value. As all the existing callers need is to check whether
the bit has reached the expected value, it's easier to return a boolean
status from the func
The omap_hdmi private data structure is currently stored as a global
variable. While no platform with multiple HDMI4 encoders currently
exists nor is planned, this doesn't comply with the kernel device model
and should thus be fixed.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/ds
The DSS private data structure is currently stored as a global variable.
While no platform with multiple DSS devices currently exists nor is
planned, this doesn't comply with the kernel device model and should
thus be fixed.
As a first step to the fix, allocate the DSS private data structure
dynam
The omap_hdmi private data structure is currently stored as a global
variable. While no platform with multiple HDMI5 encoders currently
exists nor is planned, this doesn't comply with the kernel device model
and should thus be fixed.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/ds
The dsi_get_dsidrv_data() and dsi_get_dsidev_from_dssdev() inline
functions convert a struct omap_dss_device pointer to the corresponding
struct platform_device, and a struct platform_device pointer to the
corresponding struct dsi_data. They are nearly always called together
without any use of the
The dss_mgr_*() functions take a channel argument to identify the
channel they operate on. This prevents the functions from accessing
driver data structures without resorting to global variables. In an
effort to remove global variables, pass the omap_dss_device pointer
associated with the channel i
Internal dsi functions take a pointer to the DSI platform_device and
then cast it to a dsi_data pointer. That's pointless as the caller
already has the dsi_data pointer. Pass it directly instead of the
platform_device pointer.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/dss/dsi.c
This removes the need to access the global DSS private data in those
functions (both for the current accesses and the future ones that will
be introduced when allocating the DSS device dynamically).
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/dss/dispc.c | 8
drivers/gp
The function is unused, remove it.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/dss/dss.c | 14 --
drivers/gpu/drm/omapdrm/dss/dss.h | 1 -
2 files changed, 15 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/dss/dss.c
b/drivers/gpu/drm/omapdrm/dss/dss.c
index 98a0
The dss_mgr_ops operations implemented by the omapdrm side have to look
up the omap_crtc objects from global variables as they are only passed a
channel number. In order to remove global variables pass the
omap_drm_private pointer to the dss_mgr_ops. This requires storing a
pointer to the dss_devic
The dsi_display_init_dispc() and dsi_display_uninit_dispc() functions
take a channel argument that is reduntant as it is always identical to
the dsi->output.dispc_channel. Remove the argument and use the field
directly in the functions to avoid misuse.
Signed-off-by: Laurent Pinchart
---
drivers
This removes the need to access the global DISPC private data in those
functions (both for the current accesses and the future ones that will
be introduced when allocating the DISPC private data dynamically).
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/dss/dispc.c | 101 +
As part of an effort to remove the usage of global variables in the
driver, store the debugfs root directory in the dss_device structure
instead of a global variable.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/dss/dispc.c | 2 +-
drivers/gpu/drm/omapdrm/dss/dsi.c | 8 ---
The dsi_data structure stores a pointer to a struct platform_device. The
driver only uses the dev member of the platform device structure. Store
the struct device pointer instead and use it directly.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/dss/dsi.c | 26 +
The dsi_bind() function receives a pointer to a struct device that it
casts to a struct platform_device, only to use the platform device's dev
field through the code. Use the dev pointer directly.
While at it rename the struct platform_device pointer dsidev to pdev to
make it more explicit.
Signe
The venc private data structure is currently stored as a global
variable. While no platform with multiple VENC encoders currently exists
nor is planned, this doesn't comply with the kernel device model and
should thus be fixed.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/dss/venc
The omap_dss_register_driver(), omap_dss_unregister_driver() and
dispc_enable_gamma_table() functions don't exist anymore, remove their
prototypes.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/dss/dss.h | 1 -
drivers/gpu/drm/omapdrm/dss/omapdss.h | 3 ---
2 files changed, 4 d
This removes the need to access the global DISPC private data in those
functions (both for the current accesses and the future ones that will
be introduced when allocating the DISPC private data dynamically).
In order to allow the omapdrm side to call the dispc_ops with a DISPC
pointer, we also in
As part of an effort to remove the usage of global variables in the
driver, store the registered plls array in the dss_device structure
instead of a global variable.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/dss/dispc.c | 4 ++--
drivers/gpu/drm/omapdrm/dss/dpi.c | 1
On Thu, Oct 12, 2017 at 8:13 PM, Robert Tarasov
wrote:
> Fixed problem with DisplayLink and DisplayLink certified adapers in drm/udl
> driver when adapter doesn't want to work if it was initialized with
> disconnected DVI cable by enabling drm connectot polling and updating
> current connector's s
On Thu, Oct 12, 2017 at 8:13 PM, Robert Tarasov
wrote:
> Now DRM/UDL driver retreives all edid data blocks instead of only base one.
> Previous approch could lead to improper initialization of video mode with
> certain monitors.
>
> Signed-off-by: Robert Tarasov
Reviewed-by: Alex Deucher
> ---
1 - 100 of 150 matches
Mail list logo