[PATCH v2 05/13] drm/sun4i: hdmi: create a regmap for later use

2017-09-26 Thread Chen-Yu Tsai
The HDMI driver is written with readl/writel I/O to the registers. However, to support the A31 variant, which has a different layout for the DDC registers, it was recommended to use regfields to have a cleaner implementation. To use regfields, we need to create an underlying regmap. This patch onl

[PATCH v2 00/13] drm/sun4i: hdmi: Support HDMI controller on A31

2017-09-26 Thread Chen-Yu Tsai
Hi everyone, This is v2 of my A31 HDMI support series. As it's been some time since the first version and I've rebased my series a couple times to merge newer changes done by others, the changelog might not be complete. Changes since v1: - Core changes to sun4i-drm to support two display pip

[PATCH v2 13/13] ARM: dts: sun6i: Enable HDMI support on some A31/A31s devices

2017-09-26 Thread Chen-Yu Tsai
All the A31/A31s devices I own have some kind of HDMI connector wired to the dedicated HDMI pins on the SoC: - A31 Hummingbird (standard HDMI connector, display already enabled) - Sinlinx SinA31s (standard HDMI connector) - MSI Primo81 tablet (micro HDMI connector) Enable the display pipeli

[PATCH v2 06/13] drm/sun4i: hdmi: Allow using second PLL as TMDS clk parent

2017-09-26 Thread Chen-Yu Tsai
Allwinner SoCs typically have two PLLs reserved for video related usage. At the moment we only support using the first one to feed the HDMI transmitter block's TMDS clock. Let the HDMI encoder's TMDS clock go through all of its parents when calculating possible clock rates. This allows usage of th

[PATCH v2 07/13] dt-bindings: display: sun4i: Add binding for A31 HDMI controller

2017-09-26 Thread Chen-Yu Tsai
The HDMI controller in the A31 SoC is slightly different from the earlier version. In addition to the TMDS clock and DDC controls, this version now takes a second DDC clock input. Add a compatible string for it, and add the DDC clock input to the list of clocks required. Signed-off-by: Chen-Yu Ts

[PATCH v2 09/13] drm/sun4i: hdmi: Add support for controller hardware variants

2017-09-26 Thread Chen-Yu Tsai
The HDMI controller found in earlier Allwinner SoCs have slight differences between the A10, A10s, and the A31: - Need different initial values for the PLL related registers - Different behavior of the DDC and TMDS clocks - Different register layout for the DDC portion - Separate DDC pa

[PATCH v2 01/13] clk: sunxi-ng: sun6i: Export video PLLs

2017-09-26 Thread Chen-Yu Tsai
The 2x outputs of the 2 video PLL clocks are directly used by the HDMI controller block. Export them so they can be referenced in the device tree. Fixes: c6e6c96d8fa6 ("clk: sunxi-ng: Add A31/A31s clocks") Signed-off-by: Chen-Yu Tsai --- drivers/clk/sunxi-ng/ccu-sun6i-a31.h | 8 ++-- i

[PATCH v2 11/13] drm/sun4i: hdmi: Add support for A31's HDMI controller

2017-09-26 Thread Chen-Yu Tsai
The HDMI controller found in the A31 SoCs is slightly different from the one already supported, which is found in the A10s: - Need different initial values for the PLL related registers - Different behavior of the DDC and TMDS clocks - Different register layout for the DDC portion - Sep

[PATCH v2 10/13] drm/sun4i: hdmi: Add A31 specific DDC register definitions

2017-09-26 Thread Chen-Yu Tsai
The DDC block for the HDMI controller is different on the A31. This patch adds the register definitions. Signed-off-by: Chen-Yu Tsai --- drivers/gpu/drm/sun4i/sun4i_hdmi.h | 31 +++ 1 file changed, 31 insertions(+) diff --git a/drivers/gpu/drm/sun4i/sun4i_hdmi.h b/

[PATCH v2 12/13] ARM: dts: sun6i: Add device node for HDMI controller

2017-09-26 Thread Chen-Yu Tsai
Now that we support the HDMI controller on the A31 SoC, we can add it to the device tree. This adds a device node for the HDMI controller, and the of_graph nodes connecting it to the 2 TCONs. Signed-off-by: Chen-Yu Tsai --- arch/arm/boot/dts/sun6i-a31.dtsi | 55 +

[PATCH v2 04/13] drm/sun4i: hdmi: Disable clks in bind function error path and unbind function

2017-09-26 Thread Chen-Yu Tsai
The HDMI driver enables the bus and mod clocks in the bind function, but does not disable them if it then bails our due to any errors. Neither does it disable the clocks in the unbind function. Fix this by adding a proper error path to the bind function, and clk_disable_unprepare calls to the unbi

RE: page-flip with damage?

2017-09-26 Thread Michal Lukaszek
Thomas Hellstrom wrote: > Page flips, while efficient on real hardware, aren't that efficient in > other situations, like for virtual devices with local, or even worse, > So I'd like to start looking at page-flips with damage This is funny, it's exactly what we pointed out during the lighting t

[RFC v1 1/6] drm: Add Plane Degamma properties

2017-09-26 Thread Uma Shankar
Add Plane Degamma as a blob property and plane degamma size as a range property. Signed-off-by: Uma Shankar --- drivers/gpu/drm/drm_atomic.c| 12 drivers/gpu/drm/drm_atomic_helper.c |6 ++ drivers/gpu/drm/drm_mode_config.c | 14 ++ include/drm/drm_m

[RFC V1 0/6] Add Plane Color Properties

2017-09-26 Thread Uma Shankar
This patch series adds properties for plane color features. It adds properties for degamma used to linearize data, CSC used for gamut conversion, and gamma used to again non-linearize data as per panel supported color space. These can be utilize by user space to convert planes from one format to an

[RFC v1 5/6] drm: Define helper to set legacy gamma table size

2017-09-26 Thread Uma Shankar
Define a helper function to set legacy gamma table size for planes. Signed-off-by: Uma Shankar --- drivers/gpu/drm/drm_color_mgmt.c | 41 ++ include/drm/drm_color_mgmt.h |3 +++ include/drm/drm_plane.h |4 3 files changed, 48 insert

[RFC v1 3/6] drm: Add Plane Gamma properties

2017-09-26 Thread Uma Shankar
Add plane gamma as blob property and size as a range property. Signed-off-by: Uma Shankar --- drivers/gpu/drm/drm_atomic.c|8 drivers/gpu/drm/drm_atomic_helper.c |3 +++ drivers/gpu/drm/drm_mode_config.c | 14 ++ include/drm/drm_mode_config.h | 11

[RFC v1 2/6] drm: Add Plane CTM property

2017-09-26 Thread Uma Shankar
Add a blob property for plane CSC usage. Signed-off-by: Uma Shankar --- drivers/gpu/drm/drm_atomic.c| 10 ++ drivers/gpu/drm/drm_atomic_helper.c |3 +++ drivers/gpu/drm/drm_mode_config.c |7 +++ include/drm/drm_mode_config.h |6 ++ include/drm/drm_pl

[RFC v1 4/6] drm: Define helper function for plane color enabling

2017-09-26 Thread Uma Shankar
Define helper function to enable Plane color features to attach plane color properties to plane structure. Signed-off-by: Uma Shankar --- drivers/gpu/drm/drm_plane.c | 48 ++ include/drm/drm_color_mgmt.h |5 + 2 files changed, 53 insertions(+)

[RFC v1 6/6] drm/i915: Enable plane color features

2017-09-26 Thread Uma Shankar
Enable and initilaize plane color features. Signed-off-by: Uma Shankar --- drivers/gpu/drm/i915/i915_drv.h |8 drivers/gpu/drm/i915/intel_color.c | 14 ++ drivers/gpu/drm/i915/intel_display.c |4 drivers/gpu/drm/i915/intel_drv.h |9 + dr

Re: [PATCH 02/22] drm/i915: introduce simple gemfs

2017-09-26 Thread Greg Kroah-Hartman
On Mon, Sep 25, 2017 at 07:47:17PM +0100, Matthew Auld wrote: > Not a fully blown gemfs, just our very own tmpfs kernel mount. Doing so > moves us away from the shmemfs shm_mnt, and gives us the much needed > flexibility to do things like set our own mount options, namely huge= > which should allow

[PATCH v2 1/8] drm/rockchip/dsi: correct Feedback divider setting

2017-09-26 Thread Nickey Yang
This patch correct Feedback divider setting: 1、Set Feedback divider [8:5] when HIGH_PROGRAM_EN 2、Due to the use of a "by 2 pre-scaler," the range of the feedback multiplication Feedback divider is limited to even division numbers, and Feedback divider must be greater than 12, less than 1000. 3、Make

[PATCH v2 5/8] drm/rockchip/dsi: Use DRM_DEV_ERROR instead of dev_err

2017-09-26 Thread Nickey Yang
Rockchip driver has been moved to using the DRM_DEV_ERROR log messages, so change all instances of dev_err. Signed-off-by: Nickey Yang --- drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 62 +- 1 file changed, 31 insertions(+), 31 deletions(-) diff --git a/drivers/gpu/d

[PATCH v2 2/8] drm/rockchip/dsi: add dual mipi channel support

2017-09-26 Thread Nickey Yang
This patch add dual mipi channel support: 1.add definition of dsi1 register and grf operation. 2.dsi0 and dsi1 will work in master and slave mode when driving dual mipi panel. Signed-off-by: Nickey Yang --- drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 390 drivers/g

[PATCH v2 6/8] arm64: dts: rockchip: rk3399: Correct MIPI DPHY PLL clock

2017-09-26 Thread Nickey Yang
Mipi-dphy's ref_clk connect to clk_dphy_pll inside rk3399. clk_24m -> Gate11[14] -> clk_mipidphy_ref -> Gate21[0] -> clk_dphy_pll So correct it. Signed-off-by: Nickey Yang --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/

[PATCH v2 4/8] drm/rockchip/dsi: correct phy parameter setting

2017-09-26 Thread Nickey Yang
As MIPI PHY document show, icpctrl<3..0> and lpfctrl<5..0> should depend on frequency,so fix it. Signed-off-by: Nickey Yang --- drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 98 -- 1 file changed, 70 insertions(+), 28 deletions(-) diff --git a/drivers/gpu/drm/rockchip

[PATCH v2 8/8] arm64: dts: rockchip: add mipi_dsi1 support for rk3399

2017-09-26 Thread Nickey Yang
This patch adds the mipi_dsi1 related needed information. e.g.: interrupts, grf, clocks, ports and so on. Signed-off-by: Nickey Yang --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 39 1 file changed, 39 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3

[PATCH v2 3/8] dt-bindings: add the rockchip, dual-channel for dw-mipi-dsi

2017-09-26 Thread Nickey Yang
Configure dsi slave channel when driving a panel which needs 2 DSI links. Signed-off-by: Nickey Yang --- .../devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_r

[PATCH v2 7/8] arm64: dts: rockchip: add a grf clk for dw-mipi-dsi

2017-09-26 Thread Nickey Yang
The clk of grf must be enabled before writing grf register for rk3399. Signed-off-by: Nickey Yang --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.d

Re: [Intel-gfx] [PATCH 1/2] drm/dp: Add defines for latency in sink

2017-09-26 Thread Daniel Vetter
On Mon, Sep 25, 2017 at 11:23:26AM +0300, Jani Nikula wrote: > On Sat, 23 Sep 2017, vathsala nagaraju wrote: > > Add defines for dpcd register 2009 (synchronization latency > > in sink). > > > > Cc: Rodrigo Vivi > > CC: Puthikorn Voravootivat > > Reviewed-by: Rodrigo Vivi > > Signed-off-by: Vat

Re: [PATCH] drm/nouveau/fbcon: fix oops without fbdev emulation

2017-09-26 Thread Daniel Vetter
On Sat, Sep 23, 2017 at 01:10:33PM -0700, Pavel Roskin wrote: > This is similar to an earlier commit 52dfcc5ccfbb ("drm/nouveau: fix for > disabled fbdev emulation"), but protects all occurrences of helper.fbdev > in the source. > > I see oops in nouveau_fbcon_accel_save_disable() called from > no

Re: [PATCH 7/7] drm/rockchip: Cocci spatch "vma_pages"

2017-09-26 Thread Daniel Vetter
On Tue, Sep 26, 2017 at 02:33:07PM +0800, Mark yao wrote: > On 2017年09月26日 13:12, Daniel Vetter wrote: > > On Thu, Sep 21, 2017 at 09:02:22AM +0800, Mark yao wrote: > > > On 2017年09月21日 06:29, Thomas Meyer wrote: > > > > Use vma_pages function on vma object instead of explicit computation. > > > >

[PATCH 1/8] drm/rockchip: dw_hdmi: update dw_hdmi_rockchip_dt_ids

2017-09-26 Thread Algea Cao
Add rk3328-dw-hdmi to support rk3328. Signed-off-by: Algea Cao --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c index ccd5d59..b031005 100644 --- a

[PATCH v2] drm/tegra: Replace dev_* with DRM_DEV_*

2017-09-26 Thread Harsha Sharma
Replace all occurences of dev_info/err/dbg with DRM_DEV_INFO/ ERROR/DEBUG as we have DRM_DEV_* variants of drm print macros Done using following coccinelle semantic patch @r@ @@ ( -dev_info +DRM_DEV_INFO | -dev_err +DRM_DEV_ERROR | -dev_dbg +DRM_DEV_DEBUG ) Signed-off-by: Harsha Sharma --- Chan

[PATCH 6/8] drm/rockchip: dw_hdmi: update dw-hdmi encoder enable

2017-09-26 Thread Algea Cao
Writing grf register according to device type. Signed-off-by: Algea Cao --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip

Re: [PATCH v2] drm/tegra: Replace dev_* with DRM_DEV_*

2017-09-26 Thread Allen
Harsha, > > @r@ > @@ > > ( > -dev_info > +DRM_DEV_INFO > | > -dev_err > +DRM_DEV_ERROR > | > -dev_dbg > +DRM_DEV_DEBUG > ) > > Signed-off-by: Harsha Sharma > --- > Changes in v2: > -Break line over 80 characters > -Changes in comments not required > > drivers/gpu/drm/tegra/dc.c | 53 +

Re: [PATCH v2 6/6] drm/atomic: Make async plane update checks work as intended, v2.

2017-09-26 Thread Dmitry Osipenko
On 04.09.2017 13:48, Maarten Lankhorst wrote: > By always keeping track of the last commit in plane_state, we know > whether there is an active update on the plane or not. With that > information we can reject the fast update, and force the slowpath > to be used as was originally intended. > > We

Re: [Outreachy kernel] [PATCH v2] drm/tegra: Replace dev_* with DRM_DEV_*

2017-09-26 Thread Harsha Sharma
Hi, Thanks a lot for your feedback. I will send another version for this patch. Thanks for your time. Regards, Harsha Sharma On Sun, Sep 24, 2017 at 10:30 PM, Julia Lawall wrote: > > > On Sun, 24 Sep 2017, Harsha Sharma wrote: > > > Replace all occurences of dev_info/err/dbg with DRM_DEV_INFO/

Re: [PATCH] drm/i915: Mark wait_for_engine() as maybe_unused

2017-09-26 Thread Nick Desaulniers
Signed-off-by: Nick Desaulniers ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 2/8] drm/rockchip: dw_hdmi: add device type

2017-09-26 Thread Algea Cao
To determine type of SOC, we add a parameter dev_type. Signed-off-by: Algea Cao --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 5 + include/drm/bridge/dw_hdmi.h| 10 ++ 2 files changed, 15 insertions(+) diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/

[PATCH] drm/gem: use new idr deletion interface to cleanup drm_gem_handle_delete()

2017-09-26 Thread Aishwarya Pant
The IDR deletion interface now returns the deleted entry or NULL if it was not present. So we don't have to do the extra work of checking if we have a reference on the drm_gem_object, this can be handled by checking the return value from idr_remove() and the extra locks can be dropped. Signed-off-

[PATCH 5/8] drm/rockchip: dw_hdmi: add hclk_vio

2017-09-26 Thread Algea Cao
Add clk hclk_vio and enable it when hdmi bind. Signed-off-by: Algea Cao --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c index 35b4

[PATCH 7/8] drm: bridge: dw-hdmi: get phy ops by device type

2017-09-26 Thread Algea Cao
Add device type to distinguish different chips.Different chips use different phy ops, get them by device type. Signed-off-by: Algea Cao --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c

Re: [PATCH] drm/atomic: Make async plane update checks actually work as intended.

2017-09-26 Thread Dmitry Osipenko
On 25.09.2017 09:43, Maarten Lankhorst wrote: > Op 24-09-17 om 16:33 schreef Dmitry Osipenko: >> On 04.09.2017 13:48, Maarten Lankhorst wrote: >>> By always keeping track of the last commit in plane_state, we know >>> whether there is an active update on the plane or not. With that >>> information

[next] drm/atomic: NULL pointer dereference

2017-09-26 Thread Sergey Senozhatsky
Hello, after commit 669c9215afea4e ("drm/atomic: Make async plane update checks work as intended") drm_atomic_helper_async_check() can NULL deference the `new_plane_state' pointer and crashe the kernel at 'new_plane_state->crtc': BUG: unable to handle kernel NULL pointer dereference at 00

[PATCH 0/8] Add support RK3328 drm hdmi

2017-09-26 Thread Algea Cao
These patches add support drm hdmi in RK3328 and has been tested in RK development board. Because RK3328 use inno hdmi phy, rockchip-inno-hdmi-phy driver should be added. We add dev_type to distinguish different rockchip chips. Hdmi phy or some regs configuration can't be switched according to de

[PATCH 3/8] drm: bridge: dw-hdmi: change hdmi phy hpd read function to export

2017-09-26 Thread Algea Cao
Change dw_hdmi_phy_read_hpd from static to export. inno hdmi phy ops will call this interface to get hpd status. Signed-off-by: Algea Cao --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 5 +++-- include/drm/bridge/dw_hdmi.h | 3 ++- 2 files changed, 5 insertions(+), 3 deletions(-)

Re: [PATCH 1/3] drm: rcar-du: Share plane atomic check code between Gen2 and Gen3

2017-09-26 Thread Kieran Bingham
Hi Laurent, On 16/08/17 00:03, Laurent Pinchart wrote: > The plane atomic check implementation is identical on Gen2 (DU planes) > and Gen3 (VSP planes), but two separate functions exist as they operate > on different data structures. Refactor the code to share the > implementation. > > Signed-off

Re: [PATCH] panel: display: Add support for Mitsubishi aa070mc01 TFT panel

2017-09-26 Thread Łukasz Majewski
On 09/08/2017 11:43 AM, Lukasz Majewski wrote: This commit adds support for Mitsubishi aa070mc01 TFT panel working with 8 bit ISP mode (pin 19 "mode" HIGH for 20 pin TFT connector). Signed-off-by: Lukasz Majewski Gentle ping on this patch. Anyone could express their opinion? Thanks in a

[PATCH 4/8] drm/rockchip: dw_hdmi: add inno hdmi phy ops

2017-09-26 Thread Algea Cao
Because some RK chips use inno hdmi phy, such as RK3328, we add inno hdmi phy ops. Ultimately, these ops will call functions in /drivers/phy/rockchip/phy-rockchip-inno-hdmi-phy.c. Signed-off-by: Algea Cao --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 110 +++- 1 file

[PATCH 8/8] phy: rockchip: add inno hdmi phy to makefile

2017-09-26 Thread Algea Cao
Support some SOCs,such as RK3328. Signed-off-by: Algea Cao --- drivers/phy/rockchip/Kconfig | 7 +++ drivers/phy/rockchip/Makefile | 1 + 2 files changed, 8 insertions(+) diff --git a/drivers/phy/rockchip/Kconfig b/drivers/phy/rockchip/Kconfig index f5325b2..b021dc7 100644 --- a/drivers/ph

Re: [PATCH v3 0/3] Split default display handling out from VGA arbiter

2017-09-26 Thread Bjorn Helgaas
On Fri, Sep 01, 2017 at 05:27:41PM +1000, Daniel Axtens wrote: > This patch set: > > - splits the default display handling out from VGA arbiter, into its >own file and behind its own Kconfig option (and gives the functions >better names). > > - adds extra detection of default devices. T

Re: [PATCH 0/8] Add support RK3328 drm hdmi

2017-09-26 Thread Kever Yang
Hi Algea, Pls also cc linux-rockc...@lists.infradead.org next time. Thanks, - Kever On 09/25/2017 07:39 PM, Algea Cao wrote: These patches add support drm hdmi in RK3328 and has been tested in RK development board. Because RK3328 use inno hdmi phy, rockchip-inno-hdmi-phy driver should be

Re: RFC: page-flip with damage?

2017-09-26 Thread Daniel Vetter
On Sun, Sep 24, 2017 at 07:41:45PM +0200, Thomas Hellstrom wrote: > Hi, list! > > Page flips, while efficient on real hardware, aren't that efficient in other > situations, like for virtual devices with local, or even worse, remote > desktops. > We might ending up forwarding or encoding a couple o

Re: [Outreachy kernel] [PATCH] drm/gem: use new idr deletion interface to cleanup drm_gem_handle_delete()

2017-09-26 Thread Daniel Vetter
On Tue, Sep 26, 2017 at 12:17:28AM +0530, Aishwarya Pant wrote: > The IDR deletion interface now returns the deleted entry or NULL if it was not > present. So we don't have to do the extra work of checking if we have a > reference on the drm_gem_object, this can be handled by checking the return >

Re: [Outreachy kernel] [PATCH] drm/gem: use new idr deletion interface to cleanup drm_gem_handle_delete()

2017-09-26 Thread Julia Lawall
On Tue, 26 Sep 2017, Daniel Vetter wrote: > On Tue, Sep 26, 2017 at 12:17:28AM +0530, Aishwarya Pant wrote: > > The IDR deletion interface now returns the deleted entry or NULL if it was > > not > > present. So we don't have to do the extra work of checking if we have a > > reference on the drm

Re: [Outreachy kernel] [PATCH] drm/gem: use new idr deletion interface to cleanup drm_gem_handle_delete()

2017-09-26 Thread Daniel Vetter
On Tue, Sep 26, 2017 at 10:38 AM, Julia Lawall wrote: > > > On Tue, 26 Sep 2017, Daniel Vetter wrote: > >> On Tue, Sep 26, 2017 at 12:17:28AM +0530, Aishwarya Pant wrote: >> > The IDR deletion interface now returns the deleted entry or NULL if it was >> > not >> > present. So we don't have to do

[Bug 100443] DMESG: [powerplay] Can't find requested voltage id in vdd_dep_on_sclk table!

2017-09-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100443 --- Comment #32 from takeshi ogasawara --- Hi After upgrading from kernel 4.12.5 to 4.13.3, the event recurred again. -- You are receiving this mail because: You are the assignee for the bug.___ dri

Re: [Outreachy kernel] [PATCH] drm/gem: use new idr deletion interface to cleanup drm_gem_handle_delete()

2017-09-26 Thread Daniel Vetter
On Tue, Sep 26, 2017 at 10:47 AM, Daniel Vetter wrote: > On Tue, Sep 26, 2017 at 10:38 AM, Julia Lawall wrote: >> >> >> On Tue, 26 Sep 2017, Daniel Vetter wrote: >> >>> On Tue, Sep 26, 2017 at 12:17:28AM +0530, Aishwarya Pant wrote: >>> > The IDR deletion interface now returns the deleted entry o

Re: [PATCH] drm/gem: use new idr deletion interface to cleanup drm_gem_handle_delete()

2017-09-26 Thread Chris Wilson
Quoting Aishwarya Pant (2017-09-25 19:47:28) > The IDR deletion interface now returns the deleted entry or NULL if it was not > present. So we don't have to do the extra work of checking if we have a > reference on the drm_gem_object, this can be handled by checking the return > value from idr_remo

Re: [PATCH v2 2/2] drm/tilcdc: replace reference/unreference() with get/put

2017-09-26 Thread Jyri Sarha
 Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki On 09/26/17 11:30, Aishwarya Pant wrote: > For maintaining consistency with kernel coding style replace > reference/unreference in ref counting functions with get/put.

Re: [PATCH v2 01/13] clk: sunxi-ng: sun6i: Export video PLLs

2017-09-26 Thread Maxime Ripard
On Tue, Sep 26, 2017 at 06:59:07AM +, Chen-Yu Tsai wrote: > The 2x outputs of the 2 video PLL clocks are directly used by the > HDMI controller block. > > Export them so they can be referenced in the device tree. > > Fixes: c6e6c96d8fa6 ("clk: sunxi-ng: Add A31/A31s clocks") > Signed-off-by:

Re: [PATCH v2 02/13] clk: sunxi-ng: sun6i: Rename HDMI DDC clock to avoid name collision

2017-09-26 Thread Maxime Ripard
On Tue, Sep 26, 2017 at 06:59:08AM +, Chen-Yu Tsai wrote: > The HDMI DDC clock found in the CCU is the parent of the actual DDC > clock within the HDMI controller. That clock is also named "hdmi-ddc". > > Rename the one in the CCU to "hdmi-ddc-parent". This makes more sense > than renaming the

[Bug 102981] [amdgpu][tahiti xt][vulkan][GL] dota2 tournament drafting screen misses skys when antialiasing is on

2017-09-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102981 Sylvain BERTRAND changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [PATCH v2 03/13] drm/sun4i: tcon: Add support for demuxing TCON output on A31

2017-09-26 Thread Maxime Ripard
Hi, On Tue, Sep 26, 2017 at 06:59:09AM +, Chen-Yu Tsai wrote: > On systems with 2 TCONs such as the A31, it is possible to demux the > output of the TCONs to one encoder. > > Add support for this for the A31. > > Signed-off-by: Chen-Yu Tsai > --- > drivers/gpu/drm/sun4i/sun4i_tcon.c | 61

Re: [PATCH v2 04/13] drm/sun4i: hdmi: Disable clks in bind function error path and unbind function

2017-09-26 Thread Maxime Ripard
On Tue, Sep 26, 2017 at 06:59:10AM +, Chen-Yu Tsai wrote: > The HDMI driver enables the bus and mod clocks in the bind function, but > does not disable them if it then bails our due to any errors. Neither > does it disable the clocks in the unbind function. > > Fix this by adding a proper erro

Re: [PATCH v2 05/13] drm/sun4i: hdmi: create a regmap for later use

2017-09-26 Thread Maxime Ripard
On Tue, Sep 26, 2017 at 06:59:11AM +, Chen-Yu Tsai wrote: > The HDMI driver is written with readl/writel I/O to the registers. > However, to support the A31 variant, which has a different layout > for the DDC registers, it was recommended to use regfields to have > a cleaner implementation. To

Re: [PATCH v2 06/13] drm/sun4i: hdmi: Allow using second PLL as TMDS clk parent

2017-09-26 Thread Maxime Ripard
On Tue, Sep 26, 2017 at 06:59:12AM +, Chen-Yu Tsai wrote: > Allwinner SoCs typically have two PLLs reserved for video related usage. > At the moment we only support using the first one to feed the HDMI > transmitter block's TMDS clock. > > Let the HDMI encoder's TMDS clock go through all of it

[PATCH 2/2] drm/i915/psr: Set frames before SU entry for psr2

2017-09-26 Thread vathsala nagaraju
Set frames before SU entry value for max resync frame count of dpcd register 2009, bit field 0:3. v2 : - add macro EDP_PSR2_FRAME_BEFORE_SU (Rodrigo) - remove EDP_FRAMES_BEFORE_SU_ENTRY (Rodrigo) - add check ==1 for dpcd_read call (ville) v3 : (Rodrigo) - move macro EDP_PSR2_FRAME_BEFORE_SU

[PATCH 1/2] drm/dp: Add defines for latency in sink

2017-09-26 Thread vathsala nagaraju
Add defines for dpcd register 2009 (synchronization latency in sink). v2: - add spec version (Daniel) - use register name as is in spec,only drop excess from end (jani) - add the full register contents (jani) Cc: Rodrigo Vivi CC: Puthikorn Voravootivat Reviewed-by: Rodrigo Vivi Signed-of

Re: [PATCH v2 10/13] drm/sun4i: hdmi: Add A31 specific DDC register definitions

2017-09-26 Thread Maxime Ripard
On Tue, Sep 26, 2017 at 06:59:16AM +, Chen-Yu Tsai wrote: > The DDC block for the HDMI controller is different on the A31. > > This patch adds the register definitions. > > Signed-off-by: Chen-Yu Tsai Acked-by: Maxime Ripard Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Ker

Re: [PATCH v2 09/13] drm/sun4i: hdmi: Add support for controller hardware variants

2017-09-26 Thread Maxime Ripard
On Tue, Sep 26, 2017 at 06:59:15AM +, Chen-Yu Tsai wrote: > The HDMI controller found in earlier Allwinner SoCs have slight > differences between the A10, A10s, and the A31: > > - Need different initial values for the PLL related registers > > - Different behavior of the DDC and TMDS cloc

Re: [PATCH v2 11/13] drm/sun4i: hdmi: Add support for A31's HDMI controller

2017-09-26 Thread Maxime Ripard
On Tue, Sep 26, 2017 at 06:59:17AM +, Chen-Yu Tsai wrote: > The HDMI controller found in the A31 SoCs is slightly different > from the one already supported, which is found in the A10s: > > - Need different initial values for the PLL related registers > > - Different behavior of the DDC a

Re: [RFC v1 5/6] drm: Define helper to set legacy gamma table size

2017-09-26 Thread Lankhorst, Maarten
Hey, Uma Shankar schreef op di 26-09-2017 om 13:32 [+0530]: > Define a helper function to set legacy gamma table > size for planes. > > Signed-off-by: Uma Shankar > --- > drivers/gpu/drm/drm_color_mgmt.c | 41 > ++ > include/drm/drm_color_mgmt.h |3

RE: [RFC v1 5/6] drm: Define helper to set legacy gamma table size

2017-09-26 Thread Shankar, Uma
>-Original Message- >From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of >Lankhorst, Maarten >Sent: Tuesday, September 26, 2017 3:36 PM >To: Shankar, Uma ; intel-...@lists.freedesktop.org; >dri-devel@lists.freedesktop.org >Cc: Syrjala, Ville >Subject: Re: [RFC v

Re: [RFC v1 5/6] drm: Define helper to set legacy gamma table size

2017-09-26 Thread Lankhorst, Maarten
Shankar, Uma schreef op di 26-09-2017 om 15:41 [+0530]: > > -Original Message- > > From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On > > Behalf Of > > Lankhorst, Maarten > > Sent: Tuesday, September 26, 2017 3:36 PM > > To: Shankar, Uma ; intel-gfx@lists.freedeskt > > op.o

Re: [Outreachy kernel] [PATCH] drm/gem: use new idr deletion interface to cleanup drm_gem_handle_delete()

2017-09-26 Thread Julia Lawall
On Tue, 26 Sep 2017, Daniel Vetter wrote: > On Tue, Sep 26, 2017 at 10:47 AM, Daniel Vetter wrote: > > On Tue, Sep 26, 2017 at 10:38 AM, Julia Lawall wrote: > >> > >> > >> On Tue, 26 Sep 2017, Daniel Vetter wrote: > >> > >>> On Tue, Sep 26, 2017 at 12:17:28AM +0530, Aishwarya Pant wrote: > >>>

RE: [RFC v1 5/6] drm: Define helper to set legacy gamma table size

2017-09-26 Thread Shankar, Uma
>-Original Message- >From: Lankhorst, Maarten >Sent: Tuesday, September 26, 2017 3:45 PM >To: Shankar, Uma ; intel-...@lists.freedesktop.org; >dri-devel@lists.freedesktop.org >Cc: Syrjala, Ville >Subject: Re: [RFC v1 5/6] drm: Define helper to set legacy gamma table size > >Shankar, Uma

Re: Kernel GPU subsytem: Better manual upload for atomic

2017-09-26 Thread Daniel Vetter
On Tue, Sep 26, 2017 at 03:47:56PM +0530, Harsha Sharma wrote: > Hello, > I am working on task "Better manual upload for atomic" in kernel gpu > subsystem. > When duplicating the crtc state I need to change drm_rect x2 and y2 to > MAX_INT. > I didn't get what is MAX_INT over here. Also, how am I su

Re: [PATCH v2 2/2] drm/tilcdc: replace reference/unreference() with get/put

2017-09-26 Thread Daniel Vetter
On Tue, Sep 26, 2017 at 12:18:06PM +0300, Jyri Sarha wrote: >  > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki > > On 09/26/17 11:30, Aishwarya Pant wrote: > > For maintaining consistency with kernel coding style

Re: [Intel-gfx] [RFC V1 0/6] Add Plane Color Properties

2017-09-26 Thread Daniel Vetter
On Tue, Sep 26, 2017 at 01:32:52PM +0530, Uma Shankar wrote: > This patch series adds properties for plane color features. It adds > properties for degamma used to linearize data, CSC used for gamut > conversion, and gamma used to again non-linearize data as per panel > supported color space. These

Re: [PATCH v2] drm/tinydrm: Move backlight helpers to a separate file

2017-09-26 Thread Meghana Madhyastha
On Mon, Sep 25, 2017 at 06:31:58PM +0200, Noralf Trønnes wrote: > > Den 25.09.2017 16.56, skrev Noralf Trønnes: > >Hi Meghana, > > > > > >Den 22.09.2017 17.09, skrev Meghana Madhyastha: > >>Move backlight helpers from tinydrm-helpers.c to > >>tinydrm-backlight.c. This is because it is organization

Re: [PATCH v2] drm/tinydrm: Move backlight helpers to a separate file

2017-09-26 Thread Daniel Vetter
On Tue, Sep 26, 2017 at 04:46:53PM +0530, Meghana Madhyastha wrote: > On Mon, Sep 25, 2017 at 06:31:58PM +0200, Noralf Trønnes wrote: > > > > Den 25.09.2017 16.56, skrev Noralf Trønnes: > > >Hi Meghana, > > > > > > > > >Den 22.09.2017 17.09, skrev Meghana Madhyastha: > > >>Move backlight helpers f

Re: [PATCH] drm/gem: use new idr deletion interface to cleanup drm_gem_handle_delete()

2017-09-26 Thread Aishwarya Pant
On Tue, Sep 26, 2017 at 10:12:12AM +0100, Chris Wilson wrote: > Quoting Aishwarya Pant (2017-09-25 19:47:28) > > The IDR deletion interface now returns the deleted entry or NULL if it was > > not > > present. So we don't have to do the extra work of checking if we have a > > reference on the drm_g

[PATCH v2 2/2] drm/tilcdc: replace reference/unreference() with get/put

2017-09-26 Thread Aishwarya Pant
For maintaining consistency with kernel coding style replace reference/unreference in ref counting functions with get/put. The following cocci script was used to generate the tilcdc patch: @@ expression ex; @@ ( -drm_framebuffer_unreference(ex); +drm_framebuffer_put(ex); | -drm_dev_unref(ex); +d

Re: [Outreachy kernel] [PATCH] drm/gem: use new idr deletion interface to cleanup drm_gem_handle_delete()

2017-09-26 Thread Aishwarya Pant
On Tue, Sep 26, 2017 at 10:20:47AM +0200, Daniel Vetter wrote: > On Tue, Sep 26, 2017 at 12:17:28AM +0530, Aishwarya Pant wrote: > > The IDR deletion interface now returns the deleted entry or NULL if it was > > not > > present. So we don't have to do the extra work of checking if we have a > > re

[PATCH v2 0/2] drm/tilcdc: replace reference/unreference with get/put

2017-09-26 Thread Aishwarya Pant
This patchset introduces drm_dev_get() and drm_dev_put() functions that are intented to be replacements for drm_dev_{ref/unref}. Then all usages of ref/reference and unref/unreference suffixes are replaced by get/put reference count functions in tilcdc. The following cocci script was used to make

Kernel GPU subsytem: Better manual upload for atomic

2017-09-26 Thread Harsha Sharma
Hello, I am working on task "Better manual upload for atomic" in kernel gpu subsystem. When duplicating the crtc state I need to change drm_rect x2 and y2 to MAX_INT. I didn't get what is MAX_INT over here. Also, how am I supposed to test my code? It will be really helpful if you can suggest someth

[PATCH v2 1/2] drm: introduce drm_dev_{get/put} functions

2017-09-26 Thread Aishwarya Pant
Reference counting functions in the kernel typically use get/put suffixes. For maintaining coding style consistency, introduce drm_dev_{get/put} functions. All callers of drm_dev_ref() API have been converted in this patch and hence it has been dropped while the drm_dev_unref() API with non-trivial

[PATCH v4 1/2] staging: ion: simplify ioctl args checking function

2017-09-26 Thread Benjamin Gaignard
Make arguments checking more easy to read. Signed-off-by: Benjamin Gaignard --- drivers/staging/android/ion/ion-ioctl.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/staging/android/ion/ion-ioctl.c b/drivers/staging/android/ion/ion-ioctl.c index d9f8b14

[PATCH v4 0/2] staging: ion: get one device per heap

2017-09-26 Thread Benjamin Gaignard
version 4: - add a configuration flag to switch between legacy Ion misc device and one device per heap version. This change has been suggested after Laura talks at XDC 2017. version 3: - change ion_device_add_heap prototype to return a possible error. version 2: - simplify ioctl check like pr

[PATCH v4 2/2] staging: ion: create one device entry per heap

2017-09-26 Thread Benjamin Gaignard
Instead a getting one common device "/dev/ion" for all the heaps this patch allow to create one device entry ("/dev/ionX") per heap. Getting an entry per heap could allow to set security rules per heap and global ones for all heaps. Allocation requests will be only allowed if the mask_id match wit

Re: [PATCH v2] drm/tinydrm: Move backlight helpers to a separate file

2017-09-26 Thread Meghana Madhyastha
On Tue, Sep 26, 2017 at 01:32:15PM +0200, Daniel Vetter wrote: > On Tue, Sep 26, 2017 at 04:46:53PM +0530, Meghana Madhyastha wrote: > > On Mon, Sep 25, 2017 at 06:31:58PM +0200, Noralf Trønnes wrote: > > > > > > Den 25.09.2017 16.56, skrev Noralf Trønnes: > > > >Hi Meghana, > > > > > > > > > > >

Re: [PATCH v2] drm/tinydrm: Move backlight helpers to a separate file

2017-09-26 Thread Noralf Trønnes
Den 26.09.2017 13.32, skrev Daniel Vetter: On Tue, Sep 26, 2017 at 04:46:53PM +0530, Meghana Madhyastha wrote: On Mon, Sep 25, 2017 at 06:31:58PM +0200, Noralf Trønnes wrote: Den 25.09.2017 16.56, skrev Noralf Trønnes: Hi Meghana, Den 22.09.2017 17.09, skrev Meghana Madhyastha: Move backli

Re: [PATCH 02/22] drm/i915: introduce simple gemfs

2017-09-26 Thread Joonas Lahtinen
On Tue, 2017-09-26 at 09:52 +0200, Greg Kroah-Hartman wrote: > On Mon, Sep 25, 2017 at 07:47:17PM +0100, Matthew Auld wrote: > > Not a fully blown gemfs, just our very own tmpfs kernel mount. Doing so > > moves us away from the shmemfs shm_mnt, and gives us the much needed > > flexibility to do thi

Re: [PATCH v2] drm/tinydrm: Move backlight helpers to a separate file

2017-09-26 Thread Noralf Trønnes
Den 26.09.2017 15.06, skrev Noralf Trønnes: Den 26.09.2017 13.32, skrev Daniel Vetter: On Tue, Sep 26, 2017 at 04:46:53PM +0530, Meghana Madhyastha wrote: On Mon, Sep 25, 2017 at 06:31:58PM +0200, Noralf Trønnes wrote: Den 25.09.2017 16.56, skrev Noralf Trønnes: Hi Meghana, Den 22.09.2017

Re: [PATCH v2 6/8] arm64: dts: rockchip: rk3399: Correct MIPI DPHY PLL clock

2017-09-26 Thread Heiko Stuebner
Am Dienstag, 26. September 2017, 15:55:21 CEST schrieb Nickey Yang: > Mipi-dphy's ref_clk connect to clk_dphy_pll inside rk3399. > clk_24m -> Gate11[14] -> clk_mipidphy_ref -> Gate21[0] -> clk_dphy_pll > So correct it. > > Signed-off-by: Nickey Yang I've already applied this patch from the previ

Re: [PATCH v2 7/8] arm64: dts: rockchip: add a grf clk for dw-mipi-dsi

2017-09-26 Thread Heiko Stuebner
Am Dienstag, 26. September 2017, 15:55:22 CEST schrieb Nickey Yang: > The clk of grf must be enabled before writing grf > register for rk3399. > > Signed-off-by: Nickey Yang applied as fix for 4.14 Thanks Heiko ___ dri-devel mailing list dri-devel@li

[PATCH v3] drm: exynos: Add driver for HDMI audio interface

2017-09-26 Thread Sylwester Nawrocki
The hdmi-codec interface added in this patch is required to properly support HDMI audio. Currently the audio part of the SoC internal HDMI transmitter is configured with fixed values, which makes HDMI audio working by chance, only on boards having an external audio codec connected in parallel with

Re: RFC: page-flip with damage?

2017-09-26 Thread Thomas Hellstrom
On 09/26/2017 01:18 AM, Daniel Vetter wrote: On Sun, Sep 24, 2017 at 07:41:45PM +0200, Thomas Hellstrom wrote: Hi, list! Page flips, while efficient on real hardware, aren't that efficient in other situations, like for virtual devices with local, or even worse, remote desktops. We might ending

Re: [PATCH 1/4] drm/amd/powerplay: Cocci spatch "alloc_cast"

2017-09-26 Thread Alex Deucher
On Thu, Sep 21, 2017 at 2:33 AM, Thomas Meyer wrote: > Remove casting the values returned by memory allocation functions like > kmalloc, kzalloc, kmem_cache_alloc, kmem_cache_zalloc etc." > Found by coccinelle spatch "api/alloc/alloc_cast.cocci" > > Signed-off-by: Thomas Meyer > --- > > diff -u -

  1   2   >