Re: [PATCH] powerpc/asm/cacheflush: Cleanup cacheflush function params

2017-07-20 Thread Geert Uytterhoeven
On Thu, Jul 20, 2017 at 8:28 AM, Matt Brown wrote: > The cacheflush prototypes currently use start and stop values and each > call requires typecasting the address to an unsigned long. > This patch changes the cacheflush prototypes to follow the x86 style of > using a base and size values, with ba

Re: [RFC 1/7] drm/gem: Add drm_gem_dumb_map_offset()

2017-07-20 Thread Daniel Vetter
On Thu, Jul 20, 2017 at 12:13:07AM +0200, Noralf Trønnes wrote: > > Den 19.07.2017 23.01, skrev Eric Anholt: > > Noralf Trønnes writes: > > > > > Add a common drm_driver.dumb_map_offset function for GEM backed drivers. > > > > > > Signed-off-by: Noralf Trønnes > > Instead of just introducing t

Re: [RFC 1/7] drm/gem: Add drm_gem_dumb_map_offset()

2017-07-20 Thread Daniel Vetter
On Tue, Jul 18, 2017 at 11:06:56PM +0200, Noralf Trønnes wrote: > > Den 12.07.2017 15.45, skrev Noralf Trønnes: > > Add a common drm_driver.dumb_map_offset function for GEM backed drivers. > > > > Signed-off-by: Noralf Trønnes > > --- > > drivers/gpu/drm/drm_gem.c | 35

Re: [RFC 2/7] drm: Add GEM backed framebuffer library

2017-07-20 Thread Daniel Vetter
On Tue, Jul 18, 2017 at 05:42:28PM +0200, Noralf Trønnes wrote: > > Den 12.07.2017 15.46, skrev Noralf Trønnes: > > Add a library for drivers that can use a simple representation > > of a GEM backed framebuffer. > > > > Signed-off-by: Noralf Trønnes > > --- > > This patch adds a gem backed drm_

Re: [Nouveau] [PATCH] drm: disable vblank only if it got previously enabled

2017-07-20 Thread Daniel Vetter
On Wed, Jul 19, 2017 at 04:10:50PM -0400, Ilia Mirkin wrote: > I believe the solution is to not call drm_crtc_vblank_off for atomic > modesetting in nouveau_display_fini. I think Ben's working on it. Yes, the goal of vblank_on/off was very much to not paper over driver bugs with clever tricks like

Re: [PATCH 09/14] drm/mgag200: Add missing drm_connector_unregister()

2017-07-20 Thread Daniel Vetter
On Wed, Jul 19, 2017 at 10:44:15AM +0200, Takashi Iwai wrote: > On Tue, 18 Jul 2017 16:43:15 +0200, > Takashi Iwai wrote: > > > > From: Egbert Eich > > > > When destroying connector unregister it. > > > > Signed-off-by: Egbert Eich > > Signed-off-by: Takashi Iwai > > This one should be also

Re: [PATCH v2 0/3] drm/mst: Fix sideband msg reception error path

2017-07-20 Thread Daniel Vetter
On Wed, Jul 19, 2017 at 02:16:35PM -0400, Lyude Paul wrote: > Also would you mind resending this with a Cc to sta...@vger.kernel.org > after seeing if this can be backported? This is probably something we > should get into the stable kernel as well. Applied to drm-misc-fixes with cc: stable on all

Re: [PATCH] drm: Prevent early NULL dereference of fb_helper->fb

2017-07-20 Thread Daniel Vetter
On Wed, Jul 19, 2017 at 04:24:50PM +0100, Chris Wilson wrote: > Prior to the fbdev being asynchronously configured on boot, the > fb_helper->fb may be unset. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101767 > Signed-off-by: Chris Wilson > Cc: Thierry Reding > Cc: Daniel Vetter

Re: [PATCH] drm/i915: Pass enum pipe to intel_set_pch_fifo_underrun_reporting()

2017-07-20 Thread Daniel Vetter
On Wed, Jul 19, 2017 at 10:39:28AM -0700, Matthias Kaehlcke wrote: > Commit a21960339c8c ("drm/i915: Consistently use enum pipe for PCH > transcoders") misses some pieces, due to a problem with the patch > format, this patch adds the remaining bits. > > Fixes: a21960339c8c ("drm/i915: Consistently

Re: [PATCH 9/9] drm/i915: Drop unpin stall in atomic_prepare_commit

2017-07-20 Thread Daniel Vetter
On Wed, Jul 19, 2017 at 04:01:03PM +0200, Maarten Lankhorst wrote: > Op 19-07-17 om 14:55 schreef Daniel Vetter: > > The core already does this in setup_commit(). With this we can also > > remove the unpin_work_count since it's the last user. > > > > Cc: Maarten Lankhorst > > Cc: Ville Syrjälä >

Re: [PATCH v2 0/3] drm/mst: Fix sideband msg reception error path

2017-07-20 Thread Imre Deak
On Wed, Jul 19, 2017 at 02:16:35PM -0400, Lyude Paul wrote: > On Wed, 2017-07-19 at 14:43 +0300, Imre Deak wrote: > > This is a resend of the last two patches from [1], addressing Lyude's > > comments and adding his R-bs. The first patch in [1] isn't needed any > It's "her" by the way :P. Ok, didn

Re: [PATCH] drm: Prevent early NULL dereference of fb_helper->fb

2017-07-20 Thread Chris Wilson
Quoting Daniel Vetter (2017-07-20 09:26:32) > On Wed, Jul 19, 2017 at 04:24:50PM +0100, Chris Wilson wrote: > > Prior to the fbdev being asynchronously configured on boot, the > > fb_helper->fb may be unset. > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101767 > > Signed-off-by: C

RE: [PATCH] drm/udl: Make page_flip asynchronous

2017-07-20 Thread Michal Lukaszek
On Thursday, July 13, 2017 7:11 PM, Daniel Vetter wrote: >>> Can't we roll this driver over to the atomic helpers instead? There >>> you get nonblocking pretty much for free ... I'm not sure extending >>> the old modeset code has all that much benefit really. >> This code certainly has value by i

Re: [RFC][PATCH v3] drm: kirin: Add mode_valid logic to avoid mode clocks we can't generate

2017-07-20 Thread Jose Abreu
On 19-07-2017 20:21, John Stultz wrote: > On Wed, Jul 19, 2017 at 3:16 AM, Jose Abreu wrote: >> Hi John, >> >> >> On 18-07-2017 18:59, John Stultz wrote: >>> Currently the hikey dsi logic cannot generate accurate byte >>> clocks values for all pixel clock values. Thus if a mode clock >>> is selec

Re: [PATCH v1 1/7] drm/stm: drv: Rename platform driver name

2017-07-20 Thread Benjamin Gaignard
2017-07-18 12:20 GMT+02:00 Philippe CORNU : > Rename the platform driver name from "stm" to "stm32-display" > for a better readability in /sys/bus/platform/drivers entries. > > Note: We keep "stm" as drm_driver.name because it is better > when using "modetest -M stm ..." (even if recent modetest pa

Re: [PATCH v1 4/7] drm/stm: ltdc: Constify funcs structures

2017-07-20 Thread Benjamin Gaignard
2017-07-18 12:20 GMT+02:00 Philippe CORNU : > Constify drm funcs structures. > > Signed-off-by: Philippe CORNU Reviewed-by: Benjamin Gaignard > --- > drivers/gpu/drm/stm/ltdc.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/g

Re: [PATCH v1 3/7] drm/stm: ltdc: Lindent and minor cleanups

2017-07-20 Thread Benjamin Gaignard
2017-07-18 12:20 GMT+02:00 Philippe CORNU : > Lindent then checkpatch --strict cleanups > > Signed-off-by: Philippe CORNU > --- > drivers/gpu/drm/stm/ltdc.c | 172 > ++--- > 1 file changed, 85 insertions(+), 87 deletions(-) > > diff --git a/drivers/gpu/dr

Re: [PATCH v1 2/7] drm/stm: ltdc: Cleanup signal polarity defines

2017-07-20 Thread Benjamin Gaignard
2017-07-18 12:20 GMT+02:00 Philippe CORNU : > The GCR_PCPOL/DEPOL/VSPOL/HSPOL defines are sufficient to > describe the HS, VS, DE & PC signal polarities. > > Signed-off-by: Philippe CORNU Reviewed-by: Benjamin Gaignard > --- > drivers/gpu/drm/stm/ltdc.c | 28 ++-- > 1 f

Re: [PATCH v1 5/7] drm/stm: ltdc: add devm_reset_control & platform_get_ressource

2017-07-20 Thread Benjamin Gaignard
2017-07-18 12:20 GMT+02:00 Philippe CORNU : > Use devm_reset_control_get to avoid resource leakage. > Also use platform_get_resource, which is more usual and > consistent with platform_get_irq called later. > > Signed-off-by: Fabien Dessenne > Signed-off-by: Philippe CORNU Note that could be con

Re: [PATCH v1 6/7] drm/stm: ltdc: Cleanup rename returned value

2017-07-20 Thread Benjamin Gaignard
2017-07-18 12:20 GMT+02:00 Philippe CORNU : Commit message is missing here > Signed-off-by: Philippe CORNU > --- > drivers/gpu/drm/stm/ltdc.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c > index f4ed

Re: [PATCH v1 7/7] drm/stm: dsi: Constify phy ops structure

2017-07-20 Thread Benjamin Gaignard
2017-07-18 12:20 GMT+02:00 Philippe CORNU : Please write a commit message > Signed-off-by: Philippe CORNU > --- > drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c > b/drivers/gpu/drm/stm/dw_mipi

[PATCH] drm/ast: Remove superfluous drm_connector_unregister() call

2017-07-20 Thread Takashi Iwai
At destroying the connector, we need no longer to call drm_connector_unregister() explicitly, as drm_dev_unregister() unregisters all connectors too. Keeping it may cause a confusion by a brainless copy-and-paste to other drivers, so let's rip it off now. Suggested-by: Daniel Vetter Signed-off-b

Re: [PATCHv2 3/3] drm/vc4: add HDMI CEC support

2017-07-20 Thread Hans Verkuil
Hi Eric, On 16/07/17 12:48, Hans Verkuil wrote: > From: Hans Verkuil > > This patch adds support to VC4 for CEC. > > Thanks to Eric Anholt for providing me with the CEC register information. > > To prevent the firmware from eating the CEC interrupts you need to add this to > your config.txt: >

Re: [PATCH 07/14] drm/mgag200: Add support for MATROX PCI device IDs 0x520 and 0x521

2017-07-20 Thread Takashi Iwai
On Thu, 20 Jul 2017 06:17:58 +0200, Dave Airlie wrote: > > On 19 July 2017 at 00:43, Takashi Iwai wrote: > > From: Egbert Eich > > > > Add two more models G200_PCI and G200 for PCI device IDs 0x520 and > > 0x521, respectively. They need to retrieve the reference clock and > > pclk min/max value

Re: [PATCH v1 2/2] drm/bridge/synopsys: dsi: Register list clean up

2017-07-20 Thread Laurent Pinchart
Hi Philippe, On Wednesday 19 Jul 2017 09:11:44 Philippe CORNU wrote: > On 07/18/2017 03:39 PM, Laurent Pinchart wrote: > > On Tuesday 18 Jul 2017 13:43:52 Philippe CORNU wrote: > > > >> This patch cleans up the Synopsys mipi dsi register list: > >> - remove unused registers > > > > Is the docume

Re: [PATCH 4/4] drm/sun4i: make sure we don't have a commit pending

2017-07-20 Thread Maxime Ripard
Hi Daniel, On Tue, Jul 18, 2017 at 09:35:03AM +0200, Daniel Vetter wrote: > On Tue, Jul 18, 2017 at 9:07 AM, Maxime Ripard > wrote: > > On Mon, Jul 17, 2017 at 02:57:19PM +0800, Chen-Yu Tsai wrote: > >> On Mon, Jul 17, 2017 at 2:55 PM, Maxime Ripard > >> wrote: > >> > On Fri, Jul 14, 2017 at 04:

Re: [PATCH 022/102] drm/sti: explicitly request exclusive reset control

2017-07-20 Thread Benjamin Gaignard
2017-07-19 17:25 GMT+02:00 Philipp Zabel : > Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting > reset lines") started to transition the reset control request API calls > to explicitly state whether the driver needs exclusive or shared reset > control behavior. Convert all dr

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Fix an error handling path in 'mock_gem_device()'

2017-07-20 Thread Tvrtko Ursulin
On 19/07/2017 23:35, Christophe JAILLET wrote: Goto the right label in case of error, otherwise there is a leak. This has been introduced by c5cf9a9147ff. In this patch a goto has not been updated. Fixes: c5cf9a9147ff ("drm/i915: Create a kmem_cache to allocate struct i915_priolist from") Sign

Re: [PATCH 4/4] drm/sun4i: make sure we don't have a commit pending

2017-07-20 Thread Daniel Vetter
On Thu, Jul 20, 2017 at 11:53:39AM +0200, Maxime Ripard wrote: > Hi Daniel, > > On Tue, Jul 18, 2017 at 09:35:03AM +0200, Daniel Vetter wrote: > > On Tue, Jul 18, 2017 at 9:07 AM, Maxime Ripard > > wrote: > > > On Mon, Jul 17, 2017 at 02:57:19PM +0800, Chen-Yu Tsai wrote: > > >> On Mon, Jul 17, 2

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Fix an error handling path in 'mock_gem_device()'

2017-07-20 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-07-20 11:09:53) > > On 19/07/2017 23:35, Christophe JAILLET wrote: > > Goto the right label in case of error, otherwise there is a leak. > > This has been introduced by c5cf9a9147ff. In this patch a goto has not been > > updated. > > > > Fixes: c5cf9a9147ff ("drm/i915

[PATCH] drm/i2c: tda998x: Fix lockdep warning about possible circular dependency

2017-07-20 Thread Liviu Dudau
When enabling lockdep debugging on Juno platform with HDLCD and TDA998x I get the following warning from the system: [ 25.990733] == [ 25.998637] WARNING: possible circular locking dependency detected [ 26.006531] 4.13.0-rc1-00284-g28c0a682

[Bug 101837] libdrm fails to get bus id

2017-07-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101837 --- Comment #3 from Emil Velikov --- DanielP an orthogonal solution is to simply not use drmOpen. While it works, sometimes, there's a lot of hidden gotchas. Simply replace the pciaccess + drmOpen with drmDevice2 - see libdrm/tests/drmdevice.c.

Re: [PATCH] xf86drm: continue after drmProcessPlatformDevice failure

2017-07-20 Thread Emil Velikov
On 19 July 2017 at 16:37, Gurchetan Singh wrote: > On ChromeOS devices, readdir() processes the directory in > the following order: > > -NAME- -TYPE- > .n/a > .. n/a > vgem n/a > card1 DRM_BUS_PLATFORM > renderD129 D

Re: [PATCH 11/14] drm/mgag200: Consolidate depth/bpp handling

2017-07-20 Thread Paul Menzel
Dear Takashi, Thank you for posting these patches for review. Am Dienstag, den 18.07.2017, 16:43 +0200 schrieb Takashi Iwai: > From: Egbert Eich > > The depth/bpp handling for chips with limited memory in commit > 918be888d613 ("drm/mgag200: on cards with < 2MB VRAM default to > 16-bit") was

[PATCH v2 0/7] drm/stm: Various cleanups

2017-07-20 Thread Philippe CORNU
Version 2: - Add devm_reset_control_get_exclusive to follow explicit reset API - Add missing commit messages & reviewed-by. Version 1: - Initial commit The purpose of this set of patches is to clean up the drm stm driver. Philippe CORNU (7): drm/stm: drv: Rename platform driver name drm/stm:

[PATCH v2 1/7] drm/stm: drv: Rename platform driver name

2017-07-20 Thread Philippe CORNU
Rename the platform driver name from "stm" to "stm32-display" for a better readability in /sys/bus/platform/drivers entries. Note: We keep "stm" as drm_driver.name because it is better when using "modetest -M stm ..." (even if recent modetest patch avoids using -M). Signed-off-by: Philippe CORNU

[PATCH v2 2/7] drm/stm: ltdc: Cleanup signal polarity defines

2017-07-20 Thread Philippe CORNU
The GCR_PCPOL/DEPOL/VSPOL/HSPOL defines are sufficient to describe the HS, VS, DE & PC signal polarities. Signed-off-by: Philippe CORNU Reviewed-by: Benjamin Gaignard --- drivers/gpu/drm/stm/ltdc.c | 28 ++-- 1 file changed, 10 insertions(+), 18 deletions(-) diff --git

[PATCH v2 5/7] drm/stm: ltdc: add devm_reset_control & platform_get_ressource

2017-07-20 Thread Philippe CORNU
Use devm_reset_control_get_exclusive to avoid resource leakage (based on patch "Convert drivers to explicit reset API" from Philipp Zabel). Also use platform_get_resource, which is more usual and consistent with platform_get_irq called later. Signed-off-by: Fabien Dessenne Signed-off-by: Philipp

[PATCH v2 4/7] drm/stm: ltdc: Constify funcs structures

2017-07-20 Thread Philippe CORNU
Constify drm funcs structures. Signed-off-by: Philippe CORNU Reviewed-by: Benjamin Gaignard --- drivers/gpu/drm/stm/ltdc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c index 628825b..92e58ba 100644 --- a/driver

[PATCH v2 3/7] drm/stm: ltdc: Lindent and minor cleanups

2017-07-20 Thread Philippe CORNU
Lindent then checkpatch --strict cleanups Signed-off-by: Philippe CORNU Reviewed-by: Benjamin Gaignard --- drivers/gpu/drm/stm/ltdc.c | 172 ++--- 1 file changed, 85 insertions(+), 87 deletions(-) diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm

[PATCH v2 6/7] drm/stm: ltdc: Cleanup rename returned value

2017-07-20 Thread Philippe CORNU
Rename the returned value from "res" to "ret" as it is more "readable". Signed-off-by: Philippe CORNU Reviewed-by: Benjamin Gaignard --- drivers/gpu/drm/stm/ltdc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltd

[PATCH v2 7/7] drm/stm: dsi: Constify phy ops structure

2017-07-20 Thread Philippe CORNU
Constify dw_mipi_dsi_stm_phy_ops as these ops are not supposed to change at runtime. Signed-off-by: Philippe CORNU Reviewed-by: Benjamin Gaignard --- drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c

Re: [PATCH] powerpc/asm/cacheflush: Cleanup cacheflush function params

2017-07-20 Thread Geert Uytterhoeven
On Thu, Jul 20, 2017 at 1:43 PM, Michael Ellerman wrote: > Matt Brown writes: >> The cacheflush prototypes currently use start and stop values and each >> call requires typecasting the address to an unsigned long. >> This patch changes the cacheflush prototypes to follow the x86 style of >> using

Re: [PATCH 11/14] drm/mgag200: Consolidate depth/bpp handling

2017-07-20 Thread Takashi Iwai
On Thu, 20 Jul 2017 13:58:14 +0200, Paul Menzel wrote: > > Dear Takashi, > > > Thank you for posting these patches for review. > > > Am Dienstag, den 18.07.2017, 16:43 +0200 schrieb Takashi Iwai: > > From: Egbert Eich > > > > The depth/bpp handling for chips with limited memory in commit > >

[PATCH v2 1/3] drm/bridge/synopsys: dsi: Constify funcs structures

2017-07-20 Thread Philippe CORNU
Constify dw_mipi_dsi_bridge_funcs as these functions are not supposed to change at runtime. Signed-off-by: Philippe CORNU Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/sy

[PATCH v2 3/3] drm/bridge/synopsys: dsi: explicitly request exclusive reset control

2017-07-20 Thread Philippe CORNU
Based on patch "Convert drivers to explicit reset API" from Philipp Zabel Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting reset lines") started to transition the reset control request API calls to explicitly state whether the driver needs exclusive or shared reset control

[PATCH v2 0/3] drm/bridge/synopsys: dsi: Various cleanups

2017-07-20 Thread Philippe CORNU
Version 2: - Put back Synopsys mipi dsi unused registers. - Add devm_reset_control_get_exclusive to follow explicit reset API. - Add a missing commit message & reviewed-by. Version 1: - Initial commit The purpose of this set of patches is to clean up the mipi dsi dw Synopsys drm bridge. Philippe

[PATCH v2 2/3] drm/bridge/synopsys: dsi: Register list clean up

2017-07-20 Thread Philippe CORNU
This patch cleans up the Synopsys mipi dsi register list: - rename registers according to the Synopsys documentation (1.30 & 1.31) - fix typos - re-order registers for a better coherency Signed-off-by: Philippe CORNU Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/bridge/synopsys/dw-mipi-ds

Re: [PATCH v2 5/7] drm/stm: ltdc: add devm_reset_control & platform_get_ressource

2017-07-20 Thread Philipp Zabel
Hi Philippe, On Thu, 2017-07-20 at 14:05 +0200, Philippe CORNU wrote: > Use devm_reset_control_get_exclusive to avoid resource leakage (based > on patch "Convert drivers to explicit reset API" from Philipp Zabel). > > Also use platform_get_resource, which is more usual and > consistent with platf

Re: [PATCH v2 3/3] drm/bridge/synopsys: dsi: explicitly request exclusive reset control

2017-07-20 Thread Philipp Zabel
Hi Philippe, On Thu, 2017-07-20 at 14:19 +0200, Philippe CORNU wrote: > Based on patch "Convert drivers to explicit reset API" from Philipp Zabel > > Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting > reset lines") started to transition the reset control request API calls

Re: [PATCH v2 0/7] drm/stm: Various cleanups

2017-07-20 Thread Benjamin Gaignard
2017-07-20 14:05 GMT+02:00 Philippe CORNU : > Version 2: > - Add devm_reset_control_get_exclusive to follow explicit reset API > - Add missing commit messages & reviewed-by. > > Version 1: > - Initial commit > > The purpose of this set of patches is to clean up the drm stm driver. > > Philippe CORN

[PATCH] dma-fence: Don't BUG_ON when not absolutely needed

2017-07-20 Thread Daniel Vetter
It makes debugging a massive pain. Signed-off-by: Daniel Vetter Cc: Sumit Semwal Cc: Gustavo Padovan Cc: linux-me...@vger.kernel.org Cc: linaro-mm-...@lists.linaro.org --- drivers/dma-buf/dma-fence.c | 4 ++-- include/linux/dma-fence.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(

Re: [PATCH] drm/i2c: tda998x: Fix lockdep warning about possible circular dependency

2017-07-20 Thread Liviu Dudau
On Thu, Jul 20, 2017 at 12:44:49PM +0100, Russell King - ARM Linux wrote: > On Thu, Jul 20, 2017 at 12:38:53PM +0100, Russell King - ARM Linux wrote: > > On Thu, Jul 20, 2017 at 12:04:50PM +0100, Liviu Dudau wrote: > > > When enabling lockdep debugging on Juno platform with HDLCD and TDA998x > > >

[PATCH v2 3/4] drm/sun4i: engine: Add commit_poll function

2017-07-20 Thread Maxime Ripard
On the earlier Allwinner chips, with the first iteration of the display engine, the backend commit bit needs to be polled before making any register access to the backend. Add an operation for that, that will be called in atomic_begin in order to be sure to have that bit cleared before we do any m

[PATCH v2 4/4] drm/sun4i: make sure we don't have a commit pending

2017-07-20 Thread Maxime Ripard
In the earlier display engine designs, any register access while a commit is pending is forbidden. One of the symptoms is that reading a register will return another, random, register value which can lead to register corruptions if we ever do a read/modify/write cycle. Signed-off-by: Maxime Ripar

[PATCH v2 2/4] drm/sun4i: Use the runtime_pm commit_tail variant

2017-07-20 Thread Maxime Ripard
The backend (planes) commit can only happen when the TCON (CRTC) is enabled, which is not guaranteed with the default commit_tail helper. Let's use the runtime_pm version that is designed specifically to deal with that case. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/sun4i/sun4i_framebuff

[PATCH v2 0/4] drm/sun4i: Fix a register access bug

2017-07-20 Thread Maxime Ripard
The Allwinner backend has a commit bit in order to push the new configuration to the actual hardware. We've always been using that bit. However, we also should poll for that bit to clear, which we don't. Accessing any register while a commit is pending is forbidden, and will for example show a sym

[PATCH v2 1/4] drm/atomic: implement drm_atomic_helper_commit_tail for runtime_pm users

2017-07-20 Thread Maxime Ripard
The current drm_atomic_helper_commit_tail helper works only if the CRTC is accessible, and documents an alternative implementation that is supposed to be used if that happens. That implementation is then duplicated by some drivers. Instead of documenting it, let's implement an helper that all the

Re: [PATCH 03/18] drm/sun4i: Realign Makefile padding and reorder it

2017-07-20 Thread Maxime Ripard
On Fri, Jul 14, 2017 at 11:13:53AM +0800, Chen-Yu Tsai wrote: > On Thu, Jul 13, 2017 at 10:12 PM, Maxime Ripard > wrote: > > Some options were not padded as they should, and the order in the Makefile > > was chaotic. Fix that. > > > > Signed-off-by: Maxime Ripard > > --- > > drivers/gpu/drm/sun4

Re: [PATCH 06/18] drm/sun4i: tcon: Don't rely on encoders to enable the TCON

2017-07-20 Thread Maxime Ripard
Hi Chen-Yu, On Fri, Jul 14, 2017 at 11:40:07AM +0800, Chen-Yu Tsai wrote: > > static void sun4i_rgb_encoder_mode_set(struct drm_encoder *encoder, > > diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c > > b/drivers/gpu/drm/sun4i/sun4i_tcon.c > > index d9791292553e..dc70bc2a42a5 100644 > > --- a/dri

Re: [PATCH 07/18] drm/sun4i: tcon: Don't rely on encoders to set the TCON mode

2017-07-20 Thread Maxime Ripard
On Fri, Jul 14, 2017 at 11:56:18AM +0800, Chen-Yu Tsai wrote: > On Thu, Jul 13, 2017 at 10:13 PM, Maxime Ripard > wrote: > > Just like we did for the TCON enable and disable, for historical reasons we > > used to rely on the encoders calling the TCON mode_set function, while the > > CRTC has a cal

Re: [PATCH 13/18] dt-bindings: vendor: Add Huarui Lighting

2017-07-20 Thread Maxime Ripard
Hi Chen-Yu, On Fri, Jul 14, 2017 at 03:53:40PM +0800, Chen-Yu Tsai wrote: > On Thu, Jul 13, 2017 at 10:13 PM, Maxime Ripard > wrote: > > Huarui Lighting makes display panel, add it to the list of panels. > > I could not find any information on "Huarui Lighting" within the > context of LCD panels

[Bug 101850] [PIGLIT] Piglit does not recognize some tests

2017-07-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101850 arkadiusz.hi...@intel.com changed: What|Removed |Added Component|tests |IGT QA Contact|pig.

[Bug 101850] [PIGLIT] Piglit does not recognize some tests

2017-07-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101850 arkadiusz.hi...@intel.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee

Re: [PATCH] xf86drm: continue after drmProcessPlatformDevice failure

2017-07-20 Thread Thierry Reding
On Wed, Jul 19, 2017 at 08:37:06AM -0700, Gurchetan Singh wrote: > On ChromeOS devices, readdir() processes the directory in > the following order: > > -NAME- -TYPE- > .n/a > .. n/a > vgem n/a > card1 DRM_BUS_PLATFORM > r

Re: [PATCH] gpu: Convert to using %pOF instead of full_name

2017-07-20 Thread Sean Paul
On Tue, Jul 18, 2017 at 04:43:04PM -0500, Rob Herring wrote: > Now that we have a custom printf format specifier, convert users of > full_name to use %pOF instead. This is preparation to remove storing > of the full path string for each node. > > Signed-off-by: Rob Herring Hi Rob, Thanks for sen

Re: [PATCH 10/18] drm/sun4i: tcon: Move out the tcon0 common setup

2017-07-20 Thread Maxime Ripard
On Tue, Jul 18, 2017 at 11:41:36AM +0800, Chen-Yu Tsai wrote: > On Thu, Jul 13, 2017 at 10:13 PM, Maxime Ripard > wrote: > > Some channel0 setup has to be done, no matter what the output interface is > > (RGB, CPU, LVDS). Move that code into a common function in order to avoid > > duplication. > >

Re: [Linaro-mm-sig] [PATCH] dma-fence: Don't BUG_ON when not absolutely needed

2017-07-20 Thread Lucas Stach
Am Donnerstag, den 20.07.2017, 14:51 +0200 schrieb Daniel Vetter: > It makes debugging a massive pain. It is also considered very bad style to BUG the kernel on anything other than filesystem eating catastrophic failures. Reviewed-by: Lucas Stach > Signed-off-by: Daniel Vetter > Cc: Sumit Semw

[maintainer-tools PATCH] Add flowchart to help determine appropriate branch

2017-07-20 Thread Sean Paul
This patch adds a flowchart to the drm-misc documentation to help committers decide which branch is most appropriate for a given patch. Signed-off-by: Sean Paul --- .gitignore | 1 + Makefile | 2 +- drm-misc-commit-flow.dot | 22 ++ drm-misc.r

Re: [PATCH] drm/i2c: tda998x: Fix lockdep warning about possible circular dependency

2017-07-20 Thread Liviu Dudau
On Thu, Jul 20, 2017 at 02:08:29PM +0100, Russell King - ARM Linux wrote: > On Thu, Jul 20, 2017 at 01:54:04PM +0100, Liviu Dudau wrote: > > On Thu, Jul 20, 2017 at 12:44:49PM +0100, Russell King - ARM Linux wrote: > > > Actually, scrub that idea - drm_helper_probe_single_connector_modes() > > > ca

Re: [PATCH 11/18] dt-bindings: display: Add Allwinner MIPI-DSI bindings

2017-07-20 Thread Maxime Ripard
Hi Rob, On Mon, Jul 17, 2017 at 01:41:49PM -0500, Rob Herring wrote: > On Thu, Jul 13, 2017 at 04:13:06PM +0200, Maxime Ripard wrote: > > The Allwinner SoCs usually come with a DSI encoder. Add a binding for it. > > > > Signed-off-by: Maxime Ripard > > --- > > Documentation/devicetree/bindings/

[PATCH v2] drm/i2c: tda998x: Fix lockdep warning about possible circular dependency

2017-07-20 Thread Liviu Dudau
When enabling lockdep debugging on Juno platform with HDLCD and TDA998x I get the following warning from the system: [ 25.990733] == [ 25.998637] WARNING: possible circular locking dependency detected [ 26.006531] 4.13.0-rc1-00284-g28c0a682

Re: [PATCH 11/18] dt-bindings: display: Add Allwinner MIPI-DSI bindings

2017-07-20 Thread Maxime Ripard
Hi Laurent On Tue, Jul 18, 2017 at 01:18:42PM +0300, Laurent Pinchart wrote: > On Monday 17 Jul 2017 13:41:49 Rob Herring wrote: > > On Thu, Jul 13, 2017 at 04:13:06PM +0200, Maxime Ripard wrote: > > > The Allwinner SoCs usually come with a DSI encoder. Add a binding for it. > > > > > > Signed-of

Re: [Intel-gfx] [PATCH] drm/i915: Synchronize connectors states when switching from poll to irq

2017-07-20 Thread Paul Kocialkowski
On Thu, 2017-07-20 at 01:04 +, Pandiyan, Dhinakaran wrote: > On Mon, 2017-06-26 at 15:32 +0300, Paul Kocialkowski wrote: > > After detecting an IRQ storm, hotplug detection will switch from > > irq-based detection to poll-based detection. After a short delay or > > when resetting storm detectio

Re: [PATCH] drm/i2c: tda998x: Fix lockdep warning about possible circular dependency

2017-07-20 Thread Liviu Dudau
On Thu, Jul 20, 2017 at 03:24:13PM +0100, Russell King - ARM Linux wrote: > On Thu, Jul 20, 2017 at 03:19:10PM +0100, Liviu Dudau wrote: > > On Thu, Jul 20, 2017 at 02:08:29PM +0100, Russell King - ARM Linux wrote: > > > On Thu, Jul 20, 2017 at 01:54:04PM +0100, Liviu Dudau wrote: > > > > On Thu, J

Re: [PATCH] drm/i915: Synchronize connectors states when switching from poll to irq

2017-07-20 Thread Paul Kocialkowski
On Wed, 2017-07-19 at 23:11 -0700, Manasi Navare wrote: > On Tue, Jul 18, 2017 at 03:11:42PM +0300, Paul Kocialkowski wrote: > > On Mon, 2017-06-26 at 15:32 +0300, Paul Kocialkowski wrote: > > > After detecting an IRQ storm, hotplug detection will switch from > > > irq-based detection to poll-based

Re: [PATCH 01/18] regmap: mmio: Add function to attach a clock

2017-07-20 Thread Maxime Ripard
On Tue, Jul 18, 2017 at 02:21:47PM +0100, Mark Brown wrote: > On Mon, Jul 17, 2017 at 11:01:07AM +0200, Maxime Ripard wrote: > > On Thu, Jul 13, 2017 at 05:01:42PM +0100, Mark Brown wrote: > > > > > This might be problematic if the clock to enable is stored in another > > > > node. > > > > Let's

Re: [PATCH 09/18] drm/sun4i: tcon: Adjust dotclock dividers range

2017-07-20 Thread Maxime Ripard
On Fri, Jul 14, 2017 at 12:14:37PM +0800, Chen-Yu Tsai wrote: > On Thu, Jul 13, 2017 at 10:13 PM, Maxime Ripard > wrote: > > It seems like the dotclock dividers are a bit less strict range, and can > > operate even with a smaller than 6 divider. Loose the boundaries a bit. > > > > Signed-off-by: M

Re: [PATCH] drm/i2c: tda998x: Fix lockdep warning about possible circular dependency

2017-07-20 Thread Daniel Vetter
On Thu, Jul 20, 2017 at 4:40 PM, Liviu Dudau wrote: > On Thu, Jul 20, 2017 at 03:24:13PM +0100, Russell King - ARM Linux wrote: >> On Thu, Jul 20, 2017 at 03:19:10PM +0100, Liviu Dudau wrote: >> > On Thu, Jul 20, 2017 at 02:08:29PM +0100, Russell King - ARM Linux wrote: >> > > On Thu, Jul 20, 2017

Re: [PATCH 07/14] drm/mgag200: Add support for MATROX PCI device IDs 0x520 and 0x521

2017-07-20 Thread Egbert Eich
Takashi Iwai writes: > On Thu, 20 Jul 2017 06:17:58 +0200, > Dave Airlie wrote: > > > > On 19 July 2017 at 00:43, Takashi Iwai wrote: > > > From: Egbert Eich > > > > > > Add two more models G200_PCI and G200 for PCI device IDs 0x520 and > > > 0x521, respectively. They need to retrieve t

Re: [PATCH] drm/i2c: tda998x: Fix lockdep warning about possible circular dependency

2017-07-20 Thread Liviu Dudau
On Thu, Jul 20, 2017 at 04:57:12PM +0200, Daniel Vetter wrote: > On Thu, Jul 20, 2017 at 4:40 PM, Liviu Dudau wrote: > > On Thu, Jul 20, 2017 at 03:24:13PM +0100, Russell King - ARM Linux wrote: > >> On Thu, Jul 20, 2017 at 03:19:10PM +0100, Liviu Dudau wrote: > >> > On Thu, Jul 20, 2017 at 02:08:

Re: [PATCH 09/18] drm/sun4i: tcon: Adjust dotclock dividers range

2017-07-20 Thread Chen-Yu Tsai
On Thu, Jul 20, 2017 at 10:55 PM, Maxime Ripard wrote: > On Fri, Jul 14, 2017 at 12:14:37PM +0800, Chen-Yu Tsai wrote: >> On Thu, Jul 13, 2017 at 10:13 PM, Maxime Ripard >> wrote: >> > It seems like the dotclock dividers are a bit less strict range, and can >> > operate even with a smaller than 6

[PATCH v3] drm/i2c: tda998x: Fix lockdep warning about possible circular dependency

2017-07-20 Thread Liviu Dudau
When enabling lockdep debugging on Juno platform with HDLCD and TDA998x I get the following warning from the system: [ 25.990733] == [ 25.998637] WARNING: possible circular locking dependency detected [ 26.006531] 4.13.0-rc1-00284-g28c0a682

[PATCH] drm: Improve kerneldoc for drm_modeset_lock

2017-07-20 Thread Liviu Dudau
Explain better when the drm_modeset_acquire_ctx parameter can be skipped for drm_modeset_lock() call. Signed-off-by: Liviu Dudau Cc: Daniel Vetter --- drivers/gpu/drm/drm_modeset_lock.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_modeset

Re: [PATCH] drm/i915: Pass enum pipe to intel_set_pch_fifo_underrun_reporting()

2017-07-20 Thread Matthias Kaehlcke
On Thu, Jul 20, 2017 at 1:27 AM, Daniel Vetter wrote: > On Wed, Jul 19, 2017 at 10:39:28AM -0700, Matthias Kaehlcke wrote: >> Commit a21960339c8c ("drm/i915: Consistently use enum pipe for PCH >> transcoders") misses some pieces, due to a problem with the patch >> format, this patch adds the remai

[PATCH 2/2] drm/dp: Don't trust drm_dp_downstream_id()

2017-07-20 Thread Chris Wilson
Before we interpret drm_dp_downstream_id() as a string, make sure it is NULL terminated, even when drm_dp_downtsream_id() fails. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101660 Signed-off-by: Chris Wilson --- drivers/gpu/drm/drm_dp_helper.c | 3 ++- 1 file changed, 2 insertions(+),

[PATCH 1/2] drm/dp: Fix read pointer for drm_dp_downsteam_debug()

2017-07-20 Thread Chris Wilson
Pass in the array and not a pointer to the array to drm_dp_dpcd_read(). Signed-off-by: Chris Wilson --- drivers/gpu/drm/drm_dp_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c index 213fb837e1c4..1d9e30

[PATCH 0/4] drm: Fix some warnings when building docs

2017-07-20 Thread Sean Paul
I noticed these warnings as part of my compile testing and decided to fix them. There are still a few warnings with the import/export prime helpers. They're partially documented in drm_prime.c, so suggestions welcome on how to resolve them without duplication (or perhaps duplication is best in thi

[PATCH 1/4] drm/modes: Fix drm_mode_is_420_only() comment

2017-07-20 Thread Sean Paul
Fixes the following warnings when building docs: ../drivers/gpu/drm/drm_modes.c:1623: warning: No description found for parameter 'display' ../drivers/gpu/drm/drm_modes.c:1623: warning: Excess function parameter 'connector' description in 'drm_mode_is_420_only' Signed-off-by: Sean Paul --- dri

[PATCH 2/4] drm: Fix warning when building docs for scdc_helper

2017-07-20 Thread Sean Paul
Fixes: ../drivers/gpu/drm/drm_scdc_helper.c:203: ERROR: Unexpected indentation. ../drivers/gpu/drm/drm_scdc_helper.c:204: WARNING: Block quote ends without a blank line; unexpected unindent. Signed-off-by: Sean Paul --- drivers/gpu/drm/drm_scdc_helper.c | 4 ++-- 1 file changed, 2 insertions(+)

[PATCH 3/4] gpu/host1x: Remove excess parameter in host1x_subdev_add docs

2017-07-20 Thread Sean Paul
Fixes the following warning when building docs: ../drivers/gpu/host1x/bus.c:50: warning: Excess function parameter 'driver' description in 'host1x_subdev_add' Signed-off-by: Sean Paul --- drivers/gpu/host1x/bus.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/host1x/bus.c b/driv

[PATCH 4/4] drm: Add a few missing descriptions in drm_driver docs

2017-07-20 Thread Sean Paul
Fixes the following warnings when building docs: ../include/drm/drm_drv.h:553: warning: No description found for parameter 'debugfs_init' ../include/drm/drm_drv.h:553: warning: No description found for parameter 'gem_open_object' ../include/drm/drm_drv.h:553: warning: No description found for par

Re: [Intel-gfx] [PATCH 5/5] drm/hisilicon: Remove custom FB helper deferred setup

2017-07-20 Thread Daniel Vetter
On Fri, Jul 07, 2017 at 09:28:11AM -0400, Sean Paul wrote: > On Thu, Jul 6, 2017 at 9:00 AM, Daniel Vetter wrote: > > From: Thierry Reding > > > > The FB helper core now supports deferred setup, so the driver's custom > > implementation can be removed. > > > > v2: Dont' resurrect drm_vblank_clean

Re: [PATCH] drm: Improve kerneldoc for drm_modeset_lock

2017-07-20 Thread Daniel Vetter
On Thu, Jul 20, 2017 at 05:07:48PM +0100, Liviu Dudau wrote: > Explain better when the drm_modeset_acquire_ctx parameter can > be skipped for drm_modeset_lock() call. > > Signed-off-by: Liviu Dudau > Cc: Daniel Vetter Applied, thanks. -Daniel > --- > drivers/gpu/drm/drm_modeset_lock.c | 12 ++

Re: [PATCH 1/4] drm/modes: Fix drm_mode_is_420_only() comment

2017-07-20 Thread Daniel Vetter
On Thu, Jul 20, 2017 at 01:47:40PM -0400, Sean Paul wrote: > Fixes the following warnings when building docs: > ../drivers/gpu/drm/drm_modes.c:1623: warning: No description found for > parameter 'display' > ../drivers/gpu/drm/drm_modes.c:1623: warning: Excess function parameter > 'connector' desc

[Bug 97942] [IGT] [BYT] [BXT] /gem_mmap_gtt subtest basic-wc fails due to Test assertion failure

2017-07-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97942 --- Comment #7 from Ricardo Madrigal --- The following tests fail on BYT with latest configuration Test list igt@gem_mmap_gtt@coherency ==

Re: [PATCH 2/4] drm: Fix warning when building docs for scdc_helper

2017-07-20 Thread Daniel Vetter
On Thu, Jul 20, 2017 at 01:47:41PM -0400, Sean Paul wrote: > Fixes: > ../drivers/gpu/drm/drm_scdc_helper.c:203: ERROR: Unexpected indentation. > ../drivers/gpu/drm/drm_scdc_helper.c:204: WARNING: Block quote ends without a > blank line; unexpected unindent. > > Signed-off-by: Sean Paul > --- >

[Bug 97942] [IGT] [BYT] [BXT] [BYT] /gem_mmap_gtt subtest basic-wc fails due to Test assertion failure

2017-07-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97942 Ricardo Madrigal changed: What|Removed |Added Summary|[IGT] [BYT] [BXT] |[IGT] [BYT] [BXT] [BYT]

Re: [PATCH 4/4] drm: Add a few missing descriptions in drm_driver docs

2017-07-20 Thread Daniel Vetter
On Thu, Jul 20, 2017 at 01:47:43PM -0400, Sean Paul wrote: > Fixes the following warnings when building docs: > ../include/drm/drm_drv.h:553: warning: No description found for parameter > 'debugfs_init' > ../include/drm/drm_drv.h:553: warning: No description found for parameter > 'gem_open_object

Re: [PATCH v2 1/4] drm/atomic: implement drm_atomic_helper_commit_tail for runtime_pm users

2017-07-20 Thread Daniel Vetter
On Thu, Jul 20, 2017 at 03:01:16PM +0200, Maxime Ripard wrote: > The current drm_atomic_helper_commit_tail helper works only if the CRTC is > accessible, and documents an alternative implementation that is supposed to > be used if that happens. > > That implementation is then duplicated by some dr

  1   2   >