Re: [PATCH 3/4] drm/qxl: Drop fbdev hwaccel flags

2017-07-19 Thread Daniel Vetter
On Thu, Jul 06, 2017 at 02:57:34PM +0200, Daniel Vetter wrote: > It's not accelarated, just system memory. Note we don't even need to > set the default flag since that's now always 0. > > Cc: Dave Airlie > Cc: Gerd Hoffmann > Cc: virtualizat...@lists.linux-foundation.org > Signed-off-by: Daniel

[PATCH 02/12] drm/atomic: Change drm_atomic_helper_swap_state to return an error.

2017-07-19 Thread Maarten Lankhorst
We want to change swap_state to wait indefinitely, but to do this swap_state should wait interruptibly. This requires propagating the error to each driver. Cc: dri-devel@lists.freedesktop.org Cc: linux-ker...@vger.kernel.org Cc: intel-...@lists.freedesktop.org Signed-off-by: Maarten Lankhorst Lin

[PATCH 01/12] drm/nouveau: Fix error handling in nv50_disp_atomic_commit

2017-07-19 Thread Maarten Lankhorst
Make it more clear that post commit return ret is really return 0, and add a missing drm_atomic_helper_cleanup_planes when drm_atomic_helper_wait_for_fences fails. Fixes: 839ca903f12e ("drm/nouveau/kms/nv50: transition to atomic interfaces internally") Cc: Ben Skeggs Cc: dri-devel@lists.freedes

[Bug 101837] libdrm fails to get bus id

2017-07-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101837 Bug ID: 101837 Summary: libdrm fails to get bus id Product: DRI Version: DRI git Hardware: Other OS: All Status: NEW Severity: normal Priority:

Re: [PATCH] gpu: Convert to using %pOF instead of full_name

2017-07-19 Thread Philipp Zabel
On Tue, 2017-07-18 at 16:43 -0500, Rob Herring wrote: > Now that we have a custom printf format specifier, convert users of > full_name to use %pOF instead. This is preparation to remove storing > of the full path string for each node. > > Signed-off-by: Rob Herring > Cc: Russell King > Cc: Davi

Re: [Intel-gfx] [PATCH i-g-t 1/2] tests/chamelium: Skip suspend/resume test with unreliable hotplug event

2017-07-19 Thread Paul Kocialkowski
On Tue, 2017-07-18 at 22:21 +0100, Chris Wilson wrote: > Quoting Paul Kocialkowski (2017-07-18 16:16:26) > > It may occur that a hotplug uevent is detected at resume, even > > though it > > does not indicate that an actual hotplug happened. This is the case > > when > > link training fails on any o

Re: [PATCH v2] drm/i915: Explicit the connector name for DP link training result

2017-07-19 Thread Paul Kocialkowski
On Tue, 2017-07-18 at 12:20 -0700, Manasi Navare wrote: > On Tue, Jul 18, 2017 at 05:25:36PM +0300, Paul Kocialkowski wrote: > > This adds the connector name when printing a debug message about the > > DP > > link training result. It is useful to figure out what connector is > > failing when multip

Re: [PATCH 00/11] drm/sun4i: add CEC support

2017-07-19 Thread Hans Verkuil
On 18/07/17 18:29, Maxime Ripard wrote: > Hi, > > On Tue, Jul 11, 2017 at 11:06:52PM +0200, Hans Verkuil wrote: >> On 11/07/17 22:39, Maxime Ripard wrote: >>> On Tue, Jul 11, 2017 at 08:30:33AM +0200, Hans Verkuil wrote: From: Hans Verkuil This patch series adds CEC support for the

Re: [PATCH] drm/cirrus: Add missing drm_connector_unregister()

2017-07-19 Thread Takashi Iwai
On Wed, 19 Jul 2017 08:35:08 +0200, Daniel Vetter wrote: > > On Tue, Jul 18, 2017 at 04:49:33PM +0200, Takashi Iwai wrote: > > From: Egbert Eich > > > > When destroying connector unregister it. > > > > Signed-off-by: Egbert Eich > > Signed-off-by: Takashi Iwai > > drm_dev_unregister unregist

Re: [PATCH 09/14] drm/mgag200: Add missing drm_connector_unregister()

2017-07-19 Thread Takashi Iwai
On Tue, 18 Jul 2017 16:43:15 +0200, Takashi Iwai wrote: > > From: Egbert Eich > > When destroying connector unregister it. > > Signed-off-by: Egbert Eich > Signed-off-by: Takashi Iwai This one should be also superfluous as Daniel pointed for the similar patch for cirrus. Please disregard th

Re: [PATCH] drm/radeon: Set depth on low mem to 16 bpp instead of 8 bpp

2017-07-19 Thread Takashi Iwai
On Tue, 18 Jul 2017 22:53:48 +0200, Michel D4nzer wrote: > > On 18/07/17 11:20 AM, Takashi Iwai wrote: > > From: Egbert Eich > > > > The radeon driver reduces the framebuffer resolution to 8bpp if a > > device with less than 32MB VRAM is found. This causes the framebuffer > > to run in 8 bit pal

Re: [PATCH v2] drm/i915: Explicit the connector name for DP link training result

2017-07-19 Thread Jani Nikula
On Wed, 19 Jul 2017, Paul Kocialkowski wrote: > On Tue, 2017-07-18 at 12:20 -0700, Manasi Navare wrote: >> On Tue, Jul 18, 2017 at 05:25:36PM +0300, Paul Kocialkowski wrote: >> > This adds the connector name when printing a debug message about the >> > DP >> > link training result. It is useful t

Re: [PATCH v5 2/6] drm/bridge: Add a devm_ allocator for panel bridge.

2017-07-19 Thread Philippe CORNU
On 07/18/2017 11:05 PM, Eric Anholt wrote: > This will let drivers reduce the error cleanup they need, in > particular the "is_panel_bridge" flag. > > v2: Slight cleanup of remove function by Andrzej > > Signed-off-by: Eric Anholt > Reviewed-by: Andrzej Hajda Reviewed-by: Philippe Cornu Tes

Re: [PATCH v2 0/5] arm64: dts: rockchip: support mail and IPA thermal for rk3399

2017-07-19 Thread Caesar Wang
Hi Rob & Heiko, Do we have the chance to merge these patches? I'm try to bring up the display and run webgl for testing with my github on https://github.com/Caesar-github/rockchip/commits/gru/next-stable-chromeos I believe the Rocky@RK will post patches to support the other SoCs after. -Caesar

Re: [PATCH v1 2/2] drm/bridge/synopsys: dsi: Register list clean up

2017-07-19 Thread Philippe CORNU
On 07/18/2017 03:39 PM, Laurent Pinchart wrote: > Hi Philippe, > > Thank you for the patch. > > On Tuesday 18 Jul 2017 13:43:52 Philippe CORNU wrote: >> This patch cleans up the Synopsys mipi dsi register list: >> - remove unused registers > > Is the documentation for the DSI transmitter core

Re: [PATCH 14/16] drm/msm: Convert to use new iterator macros, v2.

2017-07-19 Thread Archit Taneja
On 07/12/2017 04:15 PM, Maarten Lankhorst wrote: Op 12-07-17 om 11:48 schreef Daniel Vetter: On Wed, Jul 12, 2017 at 10:13:42AM +0200, Maarten Lankhorst wrote: for_each_obj_in_state is about to be removed, so convert to the new iterator macros. Just like in omap, use crtc_state->active inste

[ANNOUNCE] libdrm 2.4.82

2017-07-19 Thread Lucas Stach
Anusha Srivatsa (3): intel: PCI Ids for S SKU in CFL intel: PCI Ids for H SKU in CFL intel: PCI Ids for U SKU in CFL Ben Widawsky (1): intel/gen10: Add missed gen10 stuff Christian Gmeiner (1): etnaviv: submit full struct drm_etnaviv_gem_submit Dave Airlie (6):

Re: [PATCH libdrm] amdgpu: move asic id table to a separate file

2017-07-19 Thread Chih-Wei Huang
Sorry for reply late. 2017-07-05 19:05 GMT+08:00 Emil Velikov : > On 5 July 2017 at 11:44, Chih-Wei Huang wrote: >> >> Yep. The first problem to prepare the patch is, >> where to install amdgpu.ids on Android? >> Is /system/etc/amdgpu.ids OK? >> > Personally I'd stick it alongside the pci.ids/usb

Re: [Intel-gfx] [PATCH v2 00/12] drm/atomic: Make drm_atomic_helper_swap_state waiting interruptible.

2017-07-19 Thread Maarten Lankhorst
Op 14-07-17 om 17:01 schreef Sean Paul: > On Tue, Jul 11, 2017 at 04:33:02PM +0200, Maarten Lankhorst wrote: >> drm_atomic_helper_swap_state could previously never fail, in order to still >> continue it would set a limit of 10s on waiting for previous updates to >> complete, >> then it moved forwa

Re: [RFC][PATCH v2] drm: kirin: Add mode_valid logic to avoid mode clocks we can't generate

2017-07-19 Thread Jose Abreu
On 18-07-2017 17:56, John Stultz wrote: > On Tue, Jul 18, 2017 at 4:10 AM, Jose Abreu wrote: >> Hi John, >> >> >> On 18-07-2017 05:22, John Stultz wrote: >>> Currently the hikey dsi logic cannot generate accurate byte >>> clocks values for all pixel clock values. Thus if a mode clock >>> is selec

Re: [PATCH libdrm] libdrm_amdgpu: add kernel semaphore support

2017-07-19 Thread Michel Dänzer
On 18/07/17 09:55 PM, zhoucm1 wrote: On 2017年07月18日 21:57, Christian König wrote: Am 18.07.2017 um 04:29 schrieb zhoucm1: On 2017年07月18日 01:35, Christian König wrote: Am 17.07.2017 um 19:22 schrieb Marek Olšák: On Sun, Jul 16, 2017 at 11:36 PM, Dave Airlie wrote: I can take a look at it, I j

Re: [Intel-gfx] [PATCH] drm/atomic-helper: Fix leak in disable_all

2017-07-19 Thread Maarten Lankhorst
Op 17-07-17 om 17:21 schreef Daniel Vetter: > On Mon, Jul 17, 2017 at 11:39:56AM +0200, Maarten Lankhorst wrote: >> Op 15-07-17 om 11:31 schreef Daniel Vetter: >>> The legacy plane->fb pointer is refcounted by calling >>> drm_atomic_clean_old_fb(). >>> >>> In practice this isn't a real problem beca

Re: [RFC][PATCH v3] drm: kirin: Add mode_valid logic to avoid mode clocks we can't generate

2017-07-19 Thread Jose Abreu
Hi John, On 18-07-2017 18:59, John Stultz wrote: > Currently the hikey dsi logic cannot generate accurate byte > clocks values for all pixel clock values. Thus if a mode clock > is selected that cannot match the calculated byte clock, the > device will boot with a blank screen. > > This patch use

[PATCH 2/2] android: amdgpu: fix build break

2017-07-19 Thread Chih-Wei Huang
Define two macros to avoid building errors. Fixes: 7e6bf88cac (amdgpu: move asic id table to a separate file) Signed-off-by: Chih-Wei Huang --- amdgpu/Android.mk | 6 ++ 1 file changed, 6 insertions(+) diff --git a/amdgpu/Android.mk b/amdgpu/Android.mk index bf0611b..955bd53 100644 --- a/a

[PATCH 1/2] android: add rules to build amdgpu.ids

2017-07-19 Thread Chih-Wei Huang
Signed-off-by: Chih-Wei Huang --- data/Android.mk | 9 + 1 file changed, 9 insertions(+) create mode 100644 data/Android.mk diff --git a/data/Android.mk b/data/Android.mk new file mode 100644 index 000..3c1fd7c --- /dev/null +++ b/data/Android.mk @@ -0,0 +1,9 @@ +LOCAL_PATH := $(cal

[Bug 101832] [regression][bisect] sddm fails to start after f50aa21456d82c8cb6fbaa565835f1acc1720a5d

2017-07-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101832 --- Comment #1 from Laurent carlier --- mesa is built with: ./autogen.sh --prefix=/usr \ --sysconfdir=/etc \ --with-dri-driverdir=/usr/lib/xorg/modules/dri \ --with-gallium-drivers=r300,r600,radeonsi,nouveau,svga,swrast,virgl,swr \ --

[PATCH v12 0/6] drm/i915/gvt: Dma-buf support for GVT-g

2017-07-19 Thread Tina Zhang
v11->v12: 1) add drm_format_mod back. (Gerd and Zhenyu) 2) add region_index. (Gerd) 3) refine the lifecycle of dmabuf. 4) send to dri-devel@lists.freedesktop.org. (Ville) v10->v11: 1) rename plane_type to drm_plane_type. (Gerd) 2) move fields of vfio_device_query_gfx_plane to vfio_device_gfx_p

[PATCH v12 3/6] drm/i915/gvt: Add RGB 64-bit 16:16:16:16 float format support

2017-07-19 Thread Tina Zhang
The RGB 64-bit 16:16:16:16 float pixel format is needed by windows 10 guest VM. This patch is to add this pixel format support to gvt device model. Without this patch, some Apps, e.g. "DXGIGammaVM.exe", will crash and make guest screen black. Signed-off-by: Xiaoguang Chen Signed-off-by: Tina Zhan

[PATCH v12 1/6] drm/i915/gvt: Add framebuffer decoder support

2017-07-19 Thread Tina Zhang
Framebuffer decoder returns guest framebuffer information. Guest framebuffer includes primary, cursor and sprite plane. Signed-off-by: Xiaoguang Chen Signed-off-by: Tina Zhang --- drivers/gpu/drm/i915/gvt/Makefile | 3 +- drivers/gpu/drm/i915/gvt/display.c| 2 +- drivers/gpu/drm/i91

[PATCH v12 2/6] drm: Introduce RGB 64-bit 16:16:16:16 float format

2017-07-19 Thread Tina Zhang
The RGB 64-bit 16:16:16:16 float pixel format is needed by windows guest VM. This patch is to introduce the format to drm. v1: Suggested by Ville to submit this patch to dri-devel. Signed-off-by: Xiaoguang Chen Signed-off-by: Tina Zhang --- include/uapi/drm/drm_fourcc.h | 4 1 file change

Re: [PATCH] drm/msm/mdp5: Fix compilation warnings

2017-07-19 Thread Viresh Kumar
On 29-06-17, 14:49, Viresh Kumar wrote: > Following compilation warnings were observed for these files: > > CC [M] drivers/gpu/drm/msm/mdp/mdp5/mdp5_mdss.o > drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c: In function 'blend_setup': > drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c:223:7: warning: missing b

[PATCH 11/17] lib/interval_tree: fast overlap detection

2017-07-19 Thread Davidlohr Bueso
Allow interval trees to quickly check for overlaps to avoid unnecesary tree lookups in interval_tree_iter_first(). As of this patch, all interval tree flavors will require using a 'rb_root_cached' such that we can have the leftmost node easily available. While most users will make use of this feat

QXL hang with 4.12.0 kernel ("kernel BUG at drivers/gpu/drm/ttm/ttm_bo_util.c:589!")

2017-07-19 Thread David H. Gutteridge
Hello, As requested in https://bugs.freedesktop.org/show_bug.cgi?id=100725, I'm attaching a log with details concerning a freeze relating to the QXL driver that I'm encountering with the 4.12 kernel for i386. (Note in order to duplicate this, a graphical boot option must be enabled. In my case, I'

Re: [PATCH v5 4/5] arm64: dts: exynos: Remove the OF graph from DSI node

2017-07-19 Thread Krzysztof Kozlowski
On Wed, Mar 08, 2017 at 01:54:11PM +0900, Hoegeun Kwon wrote: > The OF graph is not needed because the panel is a child of dsi. Remove > the ports node in DSI node. > > Signed-off-by: Hoegeun Kwon > Reviewed-by: Andrzej Hajda > Reviewed-by: Andi Shyti > --- > arch/arm64/boot/dts/exynos/exynos5

drivers/gpu/drm/i915/intel_pm.c:4467: bad comparison ?

2017-07-19 Thread David Binderman
Hello there, drivers/gpu/drm/i915/intel_pm.c:4467]: (warning) Comparison of a boolean expression with an integer other than 0 or 1. Source code is else if ((ddb_allocation && ddb_allocation / fixed_16_16_to_u32_round_up(plane_blocks_per_line)) >= 1) Regards David Binderma

[PATCH v12 2/6] drm: Introduce RGB 64-bit 16:16:16:16 float format

2017-07-19 Thread Tina Zhang
The RGB 64-bit 16:16:16:16 float pixel format is needed by windows guest VM. This patch is to introduce the format to drm. v1: Suggested by Ville to submit this patch to dri-devel. Signed-off-by: Xiaoguang Chen Signed-off-by: Tina Zhang --- include/uapi/drm/drm_fourcc.h | 4 1 file change

[PATCH v12 1/6] drm/i915/gvt: Add framebuffer decoder support

2017-07-19 Thread Tina Zhang
Framebuffer decoder returns guest framebuffer information. Guest framebuffer includes primary, cursor and sprite plane. Signed-off-by: Xiaoguang Chen Signed-off-by: Tina Zhang --- drivers/gpu/drm/i915/gvt/Makefile | 3 +- drivers/gpu/drm/i915/gvt/display.c| 2 +- drivers/gpu/drm/i91

[PATCH v12 0/6] drm/i915/gvt: Dma-buf support for GVT-g

2017-07-19 Thread Tina Zhang
v11->v12: 1) add drm_format_mod back. (Gerd and Zhenyu) 2) add region_index. (Gerd) 3) refine the lifecycle of dmabuf. 4) send to dri-devel@lists.freedesktop.org. (Ville) v10->v11: 1) rename plane_type to drm_plane_type. (Gerd) 2) move fields of vfio_device_query_gfx_plane to vfio_device_gfx_p

[PATCH v12 3/6] drm/i915/gvt: Add RGB 64-bit 16:16:16:16 float format support

2017-07-19 Thread Tina Zhang
The RGB 64-bit 16:16:16:16 float pixel format is needed by windows 10 guest VM. This patch is to add this pixel format support to gvt device model. Without this patch, some Apps, e.g. "DXGIGammaVM.exe", will crash and make guest screen black. Signed-off-by: Xiaoguang Chen Signed-off-by: Tina Zhan

[Bug 101837] libdrm fails to get bus id

2017-07-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101837 --- Comment #1 from Michel Dänzer --- Please attach the corresponding dmesg output and Xorg log file. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing li

[PATCH v12 0/6] drm/i915/gvt: Dma-buf support for GVT-g

2017-07-19 Thread Tina Zhang
v11->v12: 1) add drm_format_mod back. (Gerd and Zhenyu) 2) add region_index. (Gerd) 3) refine the lifecycle of dmabuf. 4) send to dri-devel@lists.freedesktop.org. (Ville) v10->v11: 1) rename plane_type to drm_plane_type. (Gerd) 2) move fields of vfio_device_query_gfx_plane to vfio_device_gfx_p

[PATCH v12 2/6] drm: Introduce RGB 64-bit 16:16:16:16 float format

2017-07-19 Thread Tina Zhang
The RGB 64-bit 16:16:16:16 float pixel format is needed by windows guest VM. This patch is to introduce the format to drm. v1: Suggested by Ville to submit this patch to dri-devel. Signed-off-by: Xiaoguang Chen Signed-off-by: Tina Zhang --- include/uapi/drm/drm_fourcc.h | 4 1 file change

[PATCH v12 1/6] drm/i915/gvt: Add framebuffer decoder support

2017-07-19 Thread Tina Zhang
Framebuffer decoder returns guest framebuffer information. Guest framebuffer includes primary, cursor and sprite plane. Signed-off-by: Xiaoguang Chen Signed-off-by: Tina Zhang --- drivers/gpu/drm/i915/gvt/Makefile | 3 +- drivers/gpu/drm/i915/gvt/display.c| 2 +- drivers/gpu/drm/i91

[PATCH v12 3/6] drm/i915/gvt: Add RGB 64-bit 16:16:16:16 float format support

2017-07-19 Thread Tina Zhang
The RGB 64-bit 16:16:16:16 float pixel format is needed by windows 10 guest VM. This patch is to add this pixel format support to gvt device model. Without this patch, some Apps, e.g. "DXGIGammaVM.exe", will crash and make guest screen black. Signed-off-by: Xiaoguang Chen Signed-off-by: Tina Zhan

[PATCH v12 5/6] vfio: ABI for mdev display dma-buf operation

2017-07-19 Thread Tina Zhang
Add VFIO_DEVICE_QUERY_GFX_PLANE ioctl command to let user mode query and get the plan and its related information. The dma-buf's life cycle is handled by user mode and tracked by kernel. The returned fd in struct vfio_device_query_gfx_plane can be a new fd or an old fd of a re-exported dma-buf. Ho

[PATCH v12 4/6] drm/i915/gvt: add opregion support

2017-07-19 Thread Tina Zhang
Windows guest UPT driver can use operegion to configure the setting for display. Without the opregion support, the display registers won't be set and this blocks display model to get the correct information of the guest display plane. Signed-off-by: Bing Niu Signed-off-by: Xiaoguang Chen Signed-

[PATCH v12 6/6] drm/i915: Introduce GEM proxy

2017-07-19 Thread Tina Zhang
Signed-off-by: Tina Zhang --- drivers/gpu/drm/i915/i915_gem.c| 26 +- drivers/gpu/drm/i915/i915_gem_object.h | 9 + drivers/gpu/drm/i915/i915_gem_tiling.c | 5 + 3 files changed, 39 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_

Re: [PATCH v12 6/6] drm/i915: Introduce GEM proxy

2017-07-19 Thread Chris Wilson
s/GEM proxy/a GEM proxy object/ Quoting Tina Zhang (2017-07-19 11:59:05) Rationale goes here. > Signed-off-by: Tina Zhang > --- > drivers/gpu/drm/i915/i915_gem.c| 26 +- > drivers/gpu/drm/i915/i915_gem_object.h | 9 + > drivers/gpu/drm/i915/i915_gem_til

[PATCH v2 0/3] drm/mst: Fix sideband msg reception error path

2017-07-19 Thread Imre Deak
This is a resend of the last two patches from [1], addressing Lyude's comments and adding his R-bs. The first patch in [1] isn't needed any more. Patch 3 is a fix for a related issue I noticed since the original patchset. https://lists.freedesktop.org/archives/dri-devel/2016-May/107420.html Cc: D

[PATCH v2 1/3] drm/mst: Fix error handling during MST sideband message reception

2017-07-19 Thread Imre Deak
Handle any error due to partial reads, timeouts etc. to avoid parsing uninitialized data subsequently. Also bail out if the parsing itself fails. Cc: Dave Airlie Cc: Lyude Cc: Daniel Vetter Signed-off-by: Imre Deak Reviewed-by: Lyude --- drivers/gpu/drm/drm_dp_mst_topology.c | 10 --

[PATCH v2 3/3] drm/mst: Avoid processing partially received up/down message transactions

2017-07-19 Thread Imre Deak
Currently we may process up/down message transactions containing uninitialized data. This can happen if there was an error during the reception of any message in the transaction, but we happened to receive the last message correctly with the end-of-message flag set. To avoid this abort the recepti

[PATCH v2 2/3] drm/mst: Avoid dereferencing a NULL mstb in drm_dp_mst_handle_up_req()

2017-07-19 Thread Imre Deak
In case of an unknown broadcast message is sent mstb will remain unset, so check for this. Cc: Dave Airlie Cc: Lyude Cc: Daniel Vetter Signed-off-by: Imre Deak Reviewed-by: Lyude --- drivers/gpu/drm/drm_dp_mst_topology.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/

Re: [PATCH] drm/msm/mdp5: Fix compilation warnings

2017-07-19 Thread Chris Wilson
Quoting Viresh Kumar (2017-06-29 10:19:59) > Following compilation warnings were observed for these files: > > CC [M] drivers/gpu/drm/msm/mdp/mdp5/mdp5_mdss.o > drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c: In function 'blend_setup': > drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c:223:7: warning: missin

Re: [PATCH] drm/syncobj: Fix kerneldoc

2017-07-19 Thread Daniel Vetter
On Tue, Jul 18, 2017 at 09:41:13AM +0200, Daniel Vetter wrote: > make htmldocs helps with catching these. > > Cc: Dave Airlie > Signed-off-by: Daniel Vetter Applied with Dave's ack from irc. -Daniel > --- > Documentation/gpu/drm-mm.rst | 2 +- > drivers/gpu/drm/drm_syncobj.c | 2 -- > 2 file

[PATCH 1/9] drm/i915: Nuke legacy flip queueing code

2017-07-19 Thread Daniel Vetter
Just a very minimal patch to nuke that code. Lots of the flip interrupt handling stuff is still around. Cc: Maarten Lankhorst Cc: Ville Syrjälä Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/i915_drv.h | 5 - drivers/gpu/drm/i915/intel_display.c | 656

[PATCH 2/9] drm/i915: Unbreak gpu reset vs. modeset locking

2017-07-19 Thread Daniel Vetter
Taking the modeset locks unconditionally isn't the greatest idea, because atm that part is still broken and times out (and then atomic keels over). And there's really no reason to do so, the old code didn't do that either. To make the patch a bit simpler let's also nuke 2 cases that are only aroun

[PATCH 0/9] gpu reset vs modeset fix, plus page_flip removal

2017-07-19 Thread Daniel Vetter
Hi all, This fixes the dreaded gpu reset vs. modeset deadlocks. And since the defunct legacy page_flip code is the reason for a bunch of special cases I did remove that too, on Maarten's request. Please review, this is currently blocking extended CI runs on our haswell farm rather badly. The crit

[PATCH 3/9] drm/i915: Avoid the gpu reset vs. modeset deadlock

2017-07-19 Thread Daniel Vetter
... using the biggest hammer we have. This is essentially a weaponized version of the timeout-based wedging Chris added in commit 36703e79a982c8ce5a8e43833291f2719e92d0d1 Author: Chris Wilson Date: Thu Jun 22 11:56:25 2017 +0100 drm/i915: Break modeset deadlocks on reset Because defense-i

[PATCH 5/9] drm/i915: More surgically unbreak the modeset vs reset deadlock

2017-07-19 Thread Daniel Vetter
There's no reason to entirely wedge the gpu, for the minimal deadlock bugfix we only need to unbreak/decouple the atomic commit from the gpu reset. The simplest wait to fix that is by replacing the unconditional fence wait a the top of commit_tail by a wait which completes either when the fences ar

[PATCH 6/9] drm/i915: Rip out legacy page_flip completion/irq handling

2017-07-19 Thread Daniel Vetter
All these races and things are now solved through the vblank evasion trick, plus event handling is done using normal vblank even processing and drm_crtc_arm_vblank_event. We can get rid of all this complexity. Cc: Maarten Lankhorst Cc: Ville Syrjälä Signed-off-by: Daniel Vetter --- drivers/gpu

[PATCH 7/9] drm/i915: adjust has_pending_fb_unpin to atomic

2017-07-19 Thread Daniel Vetter
A bit an oversight - the current code did nothing, since only legacy flips used the unpin_work_count and assorted logic. Cc: Maarten Lankhorst Cc: Ville Syrjälä Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/intel_display.c | 27 ++- 1 file changed, 14 insertions

[PATCH 8/9] drm/i915: Remove intel_flip_work infrastructure

2017-07-19 Thread Daniel Vetter
This gets rid of all the interactions between the legacy flip code and the modeset code. Yay! Cc: Maarten Lankhorst Cc: Ville Syrjälä Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/i915_debugfs.c | 70 - drivers/gpu/drm/i915/i915_drv.c | 1 - drivers/gpu/drm

[PATCH 4/9] drm/i915: Push i915_sw_fence_wait into the nonblocking atomic commit

2017-07-19 Thread Daniel Vetter
Blocking in a worker is ok, that's what the unbound_wq is for. And it unifies the paths between the blocking and nonblocking commit, giving me just one path where I have to implement the deadlock avoidance trickery in the next patch. Cc: Chris Wilson Cc: Mika Kuoppala Cc: Joonas Lahtinen Signed

[PATCH 9/9] drm/i915: Drop unpin stall in atomic_prepare_commit

2017-07-19 Thread Daniel Vetter
The core already does this in setup_commit(). With this we can also remove the unpin_work_count since it's the last user. Cc: Maarten Lankhorst Cc: Ville Syrjälä Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/intel_display.c | 13 + drivers/gpu/drm/i915/intel_drv.h | 2

Re: [PATCH 4/9] drm/i915: Push i915_sw_fence_wait into the nonblocking atomic commit

2017-07-19 Thread Chris Wilson
Quoting Daniel Vetter (2017-07-19 13:54:57) > Blocking in a worker is ok, but needlessly inefficient, > that's what the unbound_wq is for. And it > unifies the paths between the blocking and nonblocking commit, giving > me just one path where I have to implement the deadlock avoidance > trickery

Re: [Intel-gfx] [PATCH 7/9] drm/i915: adjust has_pending_fb_unpin to atomic

2017-07-19 Thread Chris Wilson
Quoting Daniel Vetter (2017-07-19 13:55:00) > A bit an oversight - the current code did nothing, since only > legacy flips used the unpin_work_count and assorted logic. > > Cc: Maarten Lankhorst > Cc: Ville Syrjälä > Signed-off-by: Daniel Vetter There's a fence deadlock testcase for this, kms_

Re: [Intel-gfx] [PATCH 8/9] drm/i915: Remove intel_flip_work infrastructure

2017-07-19 Thread Chris Wilson
Quoting Daniel Vetter (2017-07-19 13:55:01) > This gets rid of all the interactions between the legacy flip code and > the modeset code. Yay! Including our missed vblank boosting. (That's been dead for a while.) -Chris ___ dri-devel mailing list dri-deve

Re: [Intel-gfx] [PATCH 9/9] drm/i915: Drop unpin stall in atomic_prepare_commit

2017-07-19 Thread Chris Wilson
Quoting Daniel Vetter (2017-07-19 13:55:02) > The core already does this in setup_commit(). With this we can also > remove the unpin_work_count since it's the last user. Also note that the loop only existed for the legacy pageflip support, with that removed it becomes entirely redundant. -Chris __

Re: [PATCH 4/9] drm/i915: Push i915_sw_fence_wait into the nonblocking atomic commit

2017-07-19 Thread Daniel Vetter
On Wed, Jul 19, 2017 at 02:04:25PM +0100, Chris Wilson wrote: > Quoting Daniel Vetter (2017-07-19 13:54:57) > > Blocking in a worker is ok, > > but needlessly inefficient, > > > that's what the unbound_wq is for. And it > > unifies the paths between the blocking and nonblocking commit, giving >

Re: [Intel-gfx] [PATCH 7/9] drm/i915: adjust has_pending_fb_unpin to atomic

2017-07-19 Thread Daniel Vetter
On Wed, Jul 19, 2017 at 02:06:43PM +0100, Chris Wilson wrote: > Quoting Daniel Vetter (2017-07-19 13:55:00) > > A bit an oversight - the current code did nothing, since only > > legacy flips used the unpin_work_count and assorted logic. > > > > Cc: Maarten Lankhorst > > Cc: Ville Syrjälä > > Sig

Re: [Intel-gfx] [PATCH 9/9] drm/i915: Drop unpin stall in atomic_prepare_commit

2017-07-19 Thread Daniel Vetter
On Wed, Jul 19, 2017 at 02:09:02PM +0100, Chris Wilson wrote: > Quoting Daniel Vetter (2017-07-19 13:55:02) > > The core already does this in setup_commit(). With this we can also > > remove the unpin_work_count since it's the last user. > > Also note that the loop only existed for the legacy page

[Bug 101832] [regression][bisect] sddm fails to start after f50aa21456d82c8cb6fbaa565835f1acc1720a5d

2017-07-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101832 --- Comment #2 from Laurent carlier --- building without swr fixes the problem -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.free

Re: [Intel-gfx] [PATCH 8/9] drm/i915: Remove intel_flip_work infrastructure

2017-07-19 Thread Daniel Vetter
On Wed, Jul 19, 2017 at 02:07:36PM +0100, Chris Wilson wrote: > Quoting Daniel Vetter (2017-07-19 13:55:01) > > This gets rid of all the interactions between the legacy flip code and > > the modeset code. Yay! > > Including our missed vblank boosting. (That's been dead for a while.) Hm right, but

Re: [PATCH 3/9] drm/i915: Avoid the gpu reset vs. modeset deadlock

2017-07-19 Thread Chris Wilson
Quoting Daniel Vetter (2017-07-19 13:54:56) > ... using the biggest hammer we have. This is essentially a weaponized > version of the timeout-based wedging Chris added in > > commit 36703e79a982c8ce5a8e43833291f2719e92d0d1 > Author: Chris Wilson > Date: Thu Jun 22 11:56:25 2017 +0100 > > d

Re: [PATCH 5/9] drm/i915: More surgically unbreak the modeset vs reset deadlock

2017-07-19 Thread Chris Wilson
Quoting Daniel Vetter (2017-07-19 13:54:58) > There's no reason to entirely wedge the gpu, for the minimal deadlock > bugfix we only need to unbreak/decouple the atomic commit from the gpu > reset. The simplest wait to fix that is by replacing the > unconditional fence wait a the top of commit_tail

Re: [PATCH 3/9] drm/i915: Avoid the gpu reset vs. modeset deadlock

2017-07-19 Thread Daniel Vetter
On Wed, Jul 19, 2017 at 3:32 PM, Chris Wilson wrote: > Quoting Daniel Vetter (2017-07-19 13:54:56) >> ... using the biggest hammer we have. This is essentially a weaponized >> version of the timeout-based wedging Chris added in >> >> commit 36703e79a982c8ce5a8e43833291f2719e92d0d1 >> Author: Chris

[PATCH v3 3/3] drm/mst: Avoid processing partially received up/down message transactions

2017-07-19 Thread Imre Deak
Currently we may process up/down message transactions containing uninitialized data. This can happen if there was an error during the reception of any message in the transaction, but we happened to receive the last message correctly with the end-of-message flag set. To avoid this abort the recepti

Re: [PATCH 9/9] drm/i915: Drop unpin stall in atomic_prepare_commit

2017-07-19 Thread Maarten Lankhorst
Op 19-07-17 om 14:55 schreef Daniel Vetter: > The core already does this in setup_commit(). With this we can also > remove the unpin_work_count since it's the last user. > > Cc: Maarten Lankhorst > Cc: Ville Syrjälä > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/i915/intel_display.c | 1

Re: [PATCH 5/9] drm/i915: More surgically unbreak the modeset vs reset deadlock

2017-07-19 Thread Daniel Vetter
On Wed, Jul 19, 2017 at 3:42 PM, Chris Wilson wrote: > Quoting Daniel Vetter (2017-07-19 13:54:58) >> diff --git a/drivers/gpu/drm/i915/intel_display.c >> b/drivers/gpu/drm/i915/intel_display.c >> index 5aa7ca1ab592..4762f158032d 100644 >> --- a/drivers/gpu/drm/i915/intel_display.c >> +++ b/drive

[Bug 101832] [regression][bisect] sddm fails to start after f50aa21456d82c8cb6fbaa565835f1acc1720a5d

2017-07-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101832 --- Comment #3 from Emil Velikov --- Seems like some binary is having unresolved symbols - unw_get_proc_name at least. AFAICT it cannot happen for the DRI module, and since you're not using SWR none of it backends should be attempted, let alone

Re: [Intel-gfx] [PATCH 7/9] drm/i915: adjust has_pending_fb_unpin to atomic

2017-07-19 Thread Chris Wilson
Quoting Daniel Vetter (2017-07-19 14:15:44) > On Wed, Jul 19, 2017 at 02:06:43PM +0100, Chris Wilson wrote: > > Quoting Daniel Vetter (2017-07-19 13:55:00) > > > A bit an oversight - the current code did nothing, since only > > > legacy flips used the unpin_work_count and assorted logic. > > > > >

Re: [PATCH 5/9] drm/i915: More surgically unbreak the modeset vs reset deadlock

2017-07-19 Thread Daniel Vetter
On Wed, Jul 19, 2017 at 4:05 PM, Daniel Vetter wrote: > On Wed, Jul 19, 2017 at 3:42 PM, Chris Wilson > wrote: >> Quoting Daniel Vetter (2017-07-19 13:54:58) >>> diff --git a/drivers/gpu/drm/i915/intel_display.c >>> b/drivers/gpu/drm/i915/intel_display.c >>> index 5aa7ca1ab592..4762f158032d 100

[Bug 101832] [regression][bisect] sddm fails to start after f50aa21456d82c8cb6fbaa565835f1acc1720a5d

2017-07-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101832 --- Comment #4 from Laurent carlier --- got this: [lordh@lordh-pc lib]$ ldd -r libswrAVX2.so.0.0.0 linux-vdso.so.1 (0x7ffefe1b9000) libstdc++.so.6 => /usr/lib/libstdc++.so.6 (0x7f8206c77000) libm.so.6 => /usr/lib/

Re: [Intel-gfx] [PATCH 8/9] drm/i915: Remove intel_flip_work infrastructure

2017-07-19 Thread Chris Wilson
Quoting Daniel Vetter (2017-07-19 14:24:20) > On Wed, Jul 19, 2017 at 02:07:36PM +0100, Chris Wilson wrote: > > Quoting Daniel Vetter (2017-07-19 13:55:01) > > > This gets rid of all the interactions between the legacy flip code and > > > the modeset code. Yay! > > > > Including our missed vblank

[PATCH v2 1/7] drm/atomic: Use new iterator macros in drm_atomic_helper_wait_for_flip_done, again.

2017-07-19 Thread Maarten Lankhorst
for_each_obj_in_state is about to be removed, so use the correct new iterator macro. I renamed the variable to 'unused', but forgot to convert drm_atomic_helper_wait_for_flip_done to the new iterator macro, so make it work this time. Signed-off-by: Maarten Lankhorst Cc: Daniel Vetter Cc: Jani N

[PATCH v2 4/7] drm/omapdrm: Fix omap_atomic_wait_for_completion

2017-07-19 Thread Maarten Lankhorst
Use the new iterator macro and look for crtc_state->active instead of enable, only crtc_state->enable implies that vblanks will happen. Signed-off-by: Maarten Lankhorst Cc: Tomi Valkeinen Reviewed-by: Daniel Vetter --- drivers/gpu/drm/omapdrm/omap_drv.c | 6 +++--- 1 file changed, 3 insertions

[PATCH v2 2/7] drm/atomic: Clean up drm_atomic_helper_async_check

2017-07-19 Thread Maarten Lankhorst
Instead of assigning plane to __plane, iterate over plane which is the same thing. Simplify the check for n_planes != 1, at that point we know plane != NULL as well. Rename obj_state to new_obj_state, and get rid of the bogus stuff. crtc->state->state is NEVER non-null, if it is, there is a bug. W

[PATCH v2 3/7] drm/rcar-du: Use new iterator macros, v2.

2017-07-19 Thread Maarten Lankhorst
for_each_obj_in_state is about to be removed, so use the correct new iterator macros. Also look at new_plane_state instead of plane->state when looking up the hw planes in use. They should be the same except when reallocating, (in which case this code is skipped) and we should really stop looking

[PATCH v2 6/7] drm/nouveau: Convert nouveau to use new iterator macros, v2.

2017-07-19 Thread Maarten Lankhorst
Use the new atomic iterator macros, the old ones are about to be removed. With the new macros, it's more easy to get old and new state so get them from the macros instead of from obj->state. Changes since v1: - Don't mix up old and new state. (danvet) - Rebase on top of interruptible swap_state ch

[PATCH v2 0/7] drm/atomic: Remove deprecated atomic iterator macros, v2.

2017-07-19 Thread Maarten Lankhorst
It's time to kill off for_each_obj_in_state, and convert the remainder to for_each_(old/new/both)_obj_in_state. Some patches have been upstreamed, these are the remaining few with compile fixes. Maarten Lankhorst (7): drm/atomic: Use new iterator macros in drm_atomic_helper_wait_for_flip_done

[PATCH v2 5/7] drm/msm: Convert to use new iterator macros, v2.

2017-07-19 Thread Maarten Lankhorst
for_each_obj_in_state is about to be removed, so convert to the new iterator macros. Just like in omap, use crtc_state->active instead of crtc_state->enable when waiting for completion. Changes since v1: - Fix compilation. Signed-off-by: Maarten Lankhorst Cc: Rob Clark Cc: Archit Taneja Cc: V

[PATCH v2 7/7] drm/atomic: Remove deprecated accessor macros

2017-07-19 Thread Maarten Lankhorst
Now that the last users have been converted, we can finally get rid of for_each_obj_in_state, we have better macros to replace them with. Signed-off-by: Maarten Lankhorst Cc: Daniel Vetter Cc: Jani Nikula Cc: Sean Paul Cc: David Airlie --- include/drm/drm_atomic.h| 75 ---

[GIT PULL] imx-drm: fix parallel-display regression and plane format list

2017-07-19 Thread Philipp Zabel
Hi Dave, This tag contains a regression fix for the parallel-display output on i.MX and a typo fix for the plane format list that replaces a duplicated entry with the correct format. regards Philipp The following changes since commit 6f7da290413ba713f0cdd9ff1a2a9bb129ef4f6c: Linux 4.12 (2017-

[GIT PULL] imx-drm: scanout burst lock support

2017-07-19 Thread Philipp Zabel
Hi Dave, please consider merging this tag which improvemes for scanout memory access patterns on i.MX and contains a small cleanup for ipu_plane_atomic_update. regards Philipp The following changes since commit 5771a8c08880cdca3bfb4a3fc6d309d6bba20877: Linux v4.13-rc1 (2017-07-15 15:22:10 -07

[PATCH] drm: Prevent early NULL dereference of fb_helper->fb

2017-07-19 Thread Chris Wilson
Prior to the fbdev being asynchronously configured on boot, the fb_helper->fb may be unset. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101767 Signed-off-by: Chris Wilson Cc: Thierry Reding Cc: Daniel Vetter --- This may not be necessary with the recent async rework? One hopes. ---

[PATCH 022/102] drm/sti: explicitly request exclusive reset control

2017-07-19 Thread Philipp Zabel
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting reset lines") started to transition the reset control request API calls to explicitly state whether the driver needs exclusive or shared reset control behavior. Convert all drivers requesting exclusive resets to the explicit A

[PATCH 025/102] drm/tegra: explicitly request exclusive reset control

2017-07-19 Thread Philipp Zabel
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting reset lines") started to transition the reset control request API calls to explicitly state whether the driver needs exclusive or shared reset control behavior. Convert all drivers requesting exclusive resets to the explicit A

[PATCH 023/102] drm/stm: explicitly request exclusive reset control

2017-07-19 Thread Philipp Zabel
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting reset lines") started to transition the reset control request API calls to explicitly state whether the driver needs exclusive or shared reset control behavior. Convert all drivers requesting exclusive resets to the explicit A

[PATCH 020/102] drm/nouveau/tegra: explicitly request exclusive reset control

2017-07-19 Thread Philipp Zabel
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting reset lines") started to transition the reset control request API calls to explicitly state whether the driver needs exclusive or shared reset control behavior. Convert all drivers requesting exclusive resets to the explicit A

[PATCH 026/102] gpu: host1x: explicitly request exclusive reset control

2017-07-19 Thread Philipp Zabel
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting reset lines") started to transition the reset control request API calls to explicitly state whether the driver needs exclusive or shared reset control behavior. Convert all drivers requesting exclusive resets to the explicit A

  1   2   >