Re: [PATCH 1/3] drm: Widen vblank count to 64 bits. Change vblank time precision to ns

2017-07-06 Thread Daniel Vetter
On Wed, Jul 05, 2017 at 03:10:11PM -0700, Keith Packard wrote: > This modifies the datatypes used by the vblank code to provide both 64 > bits of vblank count and to increase the resolution of the vblank > timestamp from microseconds to nanoseconds. > > The driver interfaces have also been changed

Re: [PATCH 2/3] drm: Reorganize drm_pending_event to support future event types

2017-07-06 Thread Daniel Vetter
On Wed, Jul 05, 2017 at 03:10:12PM -0700, Keith Packard wrote: > Place drm_event_vblank in a new union that includes that and a bare > drm_event structure. This will allow new members of that union to be > added in the future without changing code related to the existing vbl > event type. > > Assi

Re: [PATCH 1/3] drm: Widen vblank count to 64 bits. Change vblank time precision to ns

2017-07-06 Thread Michel Dänzer
On 06/07/17 07:10 AM, Keith Packard wrote: > This modifies the datatypes used by the vblank code to provide both 64 > bits of vblank count and to increase the resolution of the vblank > timestamp from microseconds to nanoseconds. > > The driver interfaces have also been changed to return 64-bits o

Re: [PATCH 3/3] drm: Add CRTC_GET_SEQUENCE and CRTC_QUEUE_SEQUENCE ioctls

2017-07-06 Thread Daniel Vetter
On Wed, Jul 05, 2017 at 03:10:13PM -0700, Keith Packard wrote: > These provide crtc-id based functions instead of pipe-number, while > also offering higher resolution time (ns) and wider frame count (64) > as required by the Vulkan API. > > Signed-off-by: Keith Packard I very much like this sinc

Re: [PATCH 12/14] drm/exynos: mic: clean up drm_bridge_add call

2017-07-06 Thread Archit Taneja
On 07/05/2017 04:42 PM, Emil Velikov wrote: On 5 July 2017 at 10:14, Archit Taneja wrote: On 07/05/2017 02:35 PM, Inki Dae wrote: 2017년 07월 05일 18:00에 Archit Taneja 이(가) 쓴 글: On 07/03/2017 02:12 PM, Inki Dae wrote: This patch removes unnecessary checking of return value. Ps. this

Re: [PATCH 1/3] drm: Widen vblank count to 64 bits. Change vblank time precision to ns

2017-07-06 Thread Michel Dänzer
On 06/07/17 04:45 PM, Michel Dänzer wrote: > On 06/07/17 07:10 AM, Keith Packard wrote: >> This modifies the datatypes used by the vblank code to provide both 64 >> bits of vblank count and to increase the resolution of the vblank >> timestamp from microseconds to nanoseconds. >> >> The driver inte

Re: [PATCH v3 05/16] drm/fb-helper: do a generic fb_setcmap helper in terms of crtc .gamma_set

2017-07-06 Thread Daniel Vetter
> >> @@ -1369,27 +1362,57 @@ int drm_fb_helper_setcmap(struct fb_cmap *cmap, > >> struct fb_info *info) > >>memcpy(g + cmap->start, cmap->green, cmap->len * sizeof(*g)); > >>memcpy(b + cmap->start, cmap->blue, cmap->len * sizeof(*b)); > >> > >> - for (j = 0; j <

Re: [PATCH v3 03/16] drm/fb-helper: remove drm_fb_helper_save_lut_atomic

2017-07-06 Thread Daniel Vetter
On Tue, Jul 04, 2017 at 12:36:59PM +0200, Peter Rosin wrote: > drm_fb_helper_save_lut_atomic is redundant since the .gamma_store is > now always kept up to date by drm_fb_helper_setcmap. > > Signed-off-by: Peter Rosin Merged up to this patch to drm-misc-next, thanks. Pleas base your next round o

Re: [PATCH 00/14] clean up drm_bridge_add

2017-07-06 Thread Archit Taneja
On 07/03/2017 02:12 PM, Inki Dae wrote: This patch series changes return type of drm_bridge_add function to void one and also removes unnecessary checking of the return type from relevant drivers. Ps. I had just build test so each maintainer may need to check this. I pushed all the bridge dr

Re: [PATCH libdrm 2/2] radeon: use asic id table to get chipset name

2017-07-06 Thread Emil Velikov
On 5 July 2017 at 22:31, Li, Samuel wrote: >> - above all, as-is make check will fail > Right, I did not check that. > >> - keeping the radeon API symmetrical to the amdgpu one would a good idea > The issue is Radeon does not have a struct similar to amdgpu_device_handle. Attach it to analogous

[PATCH][drm-next] drm/amdgpu: make arrays pctl0_data and pctl1_data static

2017-07-06 Thread Colin King
From: Colin Ian King The arrays pctl0_data and pctl1_data do not need to be in global scope, so them both static. Cleans up sparse warnings: symbol 'pctl0_data' was not declared. Should it be static? symbol 'pctl1_data' was not declared. Should it be static? Signed-off-by: Colin Ian King ---

Re: [PATCH 3/3] drm: Add CRTC_GET_SEQUENCE and CRTC_QUEUE_SEQUENCE ioctls

2017-07-06 Thread Ville Syrjälä
On Thu, Jul 06, 2017 at 09:53:13AM +0200, Daniel Vetter wrote: > On Wed, Jul 05, 2017 at 03:10:13PM -0700, Keith Packard wrote: > > These provide crtc-id based functions instead of pipe-number, while > > also offering higher resolution time (ns) and wider frame count (64) > > as required by the Vul

[PATCH] drm/bridge: dw_hdmi: add cec notifier support

2017-07-06 Thread Neil Armstrong
From: Russell King Add CEC notifier support to the HDMI bridge driver, so that the CEC part of the IP can receive its physical address. Tested-by: Neil Armstrong Acked-by: Neil Armstrong Acked-by: Hans Verkuil Signed-off-by: Russell King Signed-off-by: Neil Armstrong --- drivers/gpu/drm/br

Re: [PATCH 3/3] drm: Add CRTC_GET_SEQUENCE and CRTC_QUEUE_SEQUENCE ioctls

2017-07-06 Thread Daniel Vetter
On Thu, Jul 6, 2017 at 12:16 PM, Ville Syrjälä wrote: >> > + if (!dev->irq_enabled) >> > + return -EINVAL; >> > + >> > + crtc = drm_crtc_find(dev, get_seq->crtc_id); >> > + if (!crtc) >> > + return -ENOENT; >> > + >> > + pipe = drm_crtc_index(crtc); >> > + >> > + get_

Re: [Intel-gfx] [PATCH] drm/crc: Handle opening and closing crc better

2017-07-06 Thread Tomeu Vizoso
Looks good to me: Reviewed-by: Tomeu Vizoso I guess you have tested this with IGT? In any case, I think it would be good to mention how a patch has been tested in the changelog. That can be very useful to others if things go wrong at some point. Thanks, Tomeu On 21 June 2017 at 13:00, Maar

Re: [PATCH] drm/bridge: dw_hdmi: add cec notifier support

2017-07-06 Thread Neil Armstrong
On 07/06/2017 12:43 PM, Jose Abreu wrote: > Hi Neil, > > > On 06-07-2017 11:33, Neil Armstrong wrote: >> From: Russell King >> >> Add CEC notifier support to the HDMI bridge driver, so that the CEC >> part of the IP can receive its physical address. >> >> Tested-by: Neil Armstrong >> Acked-by:

Re: [PATCH] drm/bridge: dw_hdmi: add cec notifier support

2017-07-06 Thread Neil Armstrong
On 07/06/2017 01:05 PM, Russell King - ARM Linux wrote: > On Thu, Jul 06, 2017 at 12:33:06PM +0200, Neil Armstrong wrote: >> From: Russell King >> >> Add CEC notifier support to the HDMI bridge driver, so that the CEC >> part of the IP can receive its physical address. >> >> Tested-by: Neil Armstr

Re: [PATCH] drm/bridge: dw_hdmi: add cec notifier support

2017-07-06 Thread Neil Armstrong
e on it when it appears on drm-misc-next... > > Well, from what I can see in 4.12, the cec-notifier stuff is rather > broken (tda998x has stopped working as its stuck with a physical > address of f.f.f.f) so I think the whole thing is rather moot right > now. I don't yet know wh

[PATCH 0/4] Make fbcon a built-time depency for fbdev, take 2

2017-07-06 Thread Daniel Vetter
Hi all, So the original simple hack failed and we need to do a bit more. This time tested including depmod for all combos. And since I had the pleasure to read more fbdev code, 3 simple patches on top to clean up some more. Cheers, Daniel Daniel Vetter (4): fbcon: Make fbcon a built-time depen

[PATCH 1/4] fbcon: Make fbcon a built-time depency for fbdev

2017-07-06 Thread Daniel Vetter
There's a bunch of folks who're trying to make printk less contended and faster, but there's a problem: printk uses the console_lock, and the console lock has become the BKL for all things fbdev/fbcon, which in turn pulled in half the drm subsystem under that lock. That's awkward. There reasons fo

[PATCH 4/4] drm/: Drop fbdev info flags

2017-07-06 Thread Daniel Vetter
- FBINFO_CAN_FORCE_OUTPUT has been a lie ever since we nerfed&removed the entire panic handling code in our fbdev emulation. We might restore kms panic output, but not through the bazillion of legacy code layers called fbdev/fbcon, there's just no way to make that work safely. - With the m

[PATCH 3/4] drm/qxl: Drop fbdev hwaccel flags

2017-07-06 Thread Daniel Vetter
It's not accelarated, just system memory. Note we don't even need to set the default flag since that's now always 0. Cc: Dave Airlie Cc: Gerd Hoffmann Cc: virtualizat...@lists.linux-foundation.org Signed-off-by: Daniel Vetter --- drivers/gpu/drm/qxl/qxl_fb.c | 2 +- 1 file changed, 1 insertion

[PATCH 2/4] fbdev: Nuke FBINFO_MODULE

2017-07-06 Thread Daniel Vetter
Instead check info->ops->owner, which amounts to the same. Spotted because I want to remove the pile of broken and cargo-culted fb_info->flags assignments in drm drivers. Cc: Bartlomiej Zolnierkiewicz Cc: linux-fb...@vger.kernel.org Signed-off-by: Daniel Vetter --- drivers/video/fbdev/core/fbc

[PATCH 2/5] drm/i915: Protect against deferred fbdev setup

2017-07-06 Thread Daniel Vetter
We could probably hit this already with our current async fbdev init, but it's much easier to hit this with the new deferred fbdev setup that I'm working on polishing. Cc: Maarten Lankhorst Reported-by: Maarten Lankhorst Reviewed-by: Maarten Lankhorst Signed-off-by: Daniel Vetter --- drivers/

[PATCH 1/5] drm/i915/fbdev: Always forward hotplug events

2017-07-06 Thread Daniel Vetter
With deferred fbdev setup we always need to forward hotplug events, even if fbdev isn't fully set up yet. Otherwise the deferred setup will neer happen. Originally this check was added in commit c45eb4fed12d278d3619f1904885bd0d7bcbf036 (tag: drm-intel-next-fixes-2016-08-05) Author: Chris Wilson

[PATCH 3/5] drm/fb-helper: Support deferred setup

2017-07-06 Thread Daniel Vetter
FB helper code falls back to a 1024x768 mode if no outputs are connected or don't report back any modes upon initialization. This can be annoying because outputs that are added to FB helper later on can't be used with FB helper if they don't support a matching mode. The fallback is in place becaus

[PATCH 5/5] drm/hisilicon: Remove custom FB helper deferred setup

2017-07-06 Thread Daniel Vetter
From: Thierry Reding The FB helper core now supports deferred setup, so the driver's custom implementation can be removed. v2: Dont' resurrect drm_vblank_cleanup. Cc: Xinliang Liu Cc: Rongrong Zou Cc: Xinwei Kong Cc: Chen Feng Signed-off-by: Thierry Reding (v1) Signed-off-by: Daniel Vetter

[PATCH 4/5] drm/exynos: Remove custom FB helper deferred setup

2017-07-06 Thread Daniel Vetter
From: Thierry Reding The FB helper core now supports deferred setup, so the driver's custom implementation can be removed. v2: Drop NULL check, drm_fb_helper_hotplug_event handles that already. Cc: Inki Dae Cc: Joonyoung Shim Cc: Seung-Woo Kim Cc: Kyungmin Park Signed-off-by: Thierry Reding

[PATCH] drm/crc: Only open CRC on atomic drivers when the CRTC is active.

2017-07-06 Thread Maarten Lankhorst
Op 06-07-17 om 13:09 schreef Tomeu Vizoso: > Looks good to me: > > Reviewed-by: Tomeu Vizoso > > I guess you have tested this with IGT? In any case, I think it would > be good to mention how a patch has been tested in the changelog. That > can be very useful to others if things go wrong at some po

Re: [PATCH 1/5] drm/i915/fbdev: Always forward hotplug events

2017-07-06 Thread Maarten Lankhorst
Op 06-07-17 om 15:00 schreef Daniel Vetter: > With deferred fbdev setup we always need to forward hotplug events, > even if fbdev isn't fully set up yet. Otherwise the deferred setup > will neer happen. > > Originally this check was added in > > commit c45eb4fed12d278d3619f1904885bd0d7bcbf036 (tag:

RE: [PATCH libdrm 2/2] radeon: use asic id table to get chipset name

2017-07-06 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Emil Velikov > Sent: Thursday, July 06, 2017 5:21 AM > To: Li, Samuel > Cc: ML dri-devel; amd-gfx mailing list > Subject: Re: [PATCH libdrm 2/2] radeon: use asic id table to get chipset name >

Re: [PATCH 3/3] drm: Add CRTC_GET_SEQUENCE and CRTC_QUEUE_SEQUENCE ioctls

2017-07-06 Thread Ville Syrjälä
On Thu, Jul 06, 2017 at 01:04:18PM +0200, Daniel Vetter wrote: > On Thu, Jul 6, 2017 at 12:16 PM, Ville Syrjälä > wrote: > >> > + if (!dev->irq_enabled) > >> > + return -EINVAL; > >> > + > >> > + crtc = drm_crtc_find(dev, get_seq->crtc_id); > >> > + if (!crtc) > >> > + re

Re: [PATCH][drm-next] drm/amdgpu: make arrays pctl0_data and pctl1_data static

2017-07-06 Thread Alex Deucher
On Thu, Jul 6, 2017 at 5:58 AM, Colin King wrote: > From: Colin Ian King > > The arrays pctl0_data and pctl1_data do not need to be in global scope, > so them both static. > > Cleans up sparse warnings: > symbol 'pctl0_data' was not declared. Should it be static? > symbol 'pctl1_data' was not dec

[RESEND GIT PULL] mediatek drm next for 4.13

2017-07-06 Thread CK Hu
Hi, Dave: This include new color format support and some fixups. Please kindly let me know if there is any problem. Regards, CK The following changes since commit 6d61e70ccc21606ffb8a0a03bd3aba24f659502b: Backmerge tag 'v4.12-rc7' into drm-next (2017-06-27 08:28:30 +1000) are available in th

Re: [PATCH v1 2/3] dt-bindings: display: panel: Add support for Orise Tech otm8009a dsi panel

2017-07-06 Thread Philippe CORNU
On 07/04/2017 06:30 PM, Philippe CORNU wrote: > The Orise Tech OTM8009A is a 3.97" 480x800 TFT LCD panel connected using > a MIPI-DSI video interface. Its backlight is managed through the DSI link. > > Signed-off-by: Philippe CORNU > --- > .../bindings/display/panel/orisetech,otm8009a.txt

xilinx_drm vblank from VDMA callback

2017-07-06 Thread Jean-Francois Dagenais
> On Jul 5, 2017, at 18:56, Hyun Kwon wrote: > > For VDMA, I think you can use the DMA engine complete callback to generate > the vblank. > > But, please note that it's not a global solution, and it doesn't work for > some other pipelines. For example, the ZU+ DPDMA operation is synchronized

Re: [PATCH v1 3/3] drm/panel: Add support for otm8009a panel driver

2017-07-06 Thread Philippe CORNU
On 07/05/2017 11:28 AM, Andrzej Hajda wrote: > On 04.07.2017 18:30, Philippe CORNU wrote: >> This patch adds Orise Tech otm8009a 3.97" 480x800 TFT LCD >> panel driver (MIPI-DSI video mode). The panel backlight is >> managed through the DSI link. This panel driver is used in >> several STM32 board

Re: [PATCH 1/3] drm: Widen vblank count to 64 bits. Change vblank time precision to ns

2017-07-06 Thread Keith Packard
Daniel Vetter writes: > Extending the reported/sw vblank counter to u64 makes sense imo, but do we > have to extend the driver interfaces too? If there's no 64 bit hw vblank > currently I think I'd be good to postpone that part, simply because I'm > too lazy to audit all the drivers for correctly

Re: [PATCH 1/3] drm: Widen vblank count to 64 bits. Change vblank time precision to ns

2017-07-06 Thread Keith Packard
Michel Dänzer writes: > Subtle breakage here: vblwait->request.sequence must still get updated > for _DRM_VBLANK_RELATIVE, in case we're interrupted by a signal. Thanks for finding this. I think it might be better to just not modify the request.type field instead, so that on re-entry it gets re

Re: [PATCH 1/3] drm: Widen vblank count to 64 bits. Change vblank time precision to ns

2017-07-06 Thread Keith Packard
Michel Dänzer writes: > BTW, this got me thinking that we should probably treat > _DRM_VBLANK_NEXTONMISS the same way, i.e. clear the flag after updating > vblwait->request.sequence. Otherwise there could theoretically (though > unlikely) be an infinite loop: I was thinking that we should just r

[Bug 99801] Rx480 doesn't output properly onto z27q at 5120x2880

2017-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99801 --- Comment #13 from Matthew Treinish --- I was wondering if there was any update on this? I'm still seeing the same issue on a 4.11.7 kernel. I'm willing to test out any patches or provide any additional debug info that is needed. -- You are r

[Bug 194761] amdgpu driver breaks on Oland (SI)

2017-07-06 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=194761 Alexander Tsoy (alexan...@tsoy.me) changed: What|Removed |Added CC||alexan...@tsoy.me --

Re: [PATCH 2/3] drm: Reorganize drm_pending_event to support future event types

2017-07-06 Thread Keith Packard
Daniel Vetter writes: > A few nits below, but looks good otherwise. Thanks. >> static struct drm_pending_vblank_event *create_vblank_event( >> -struct drm_device *dev, uint64_t user_data) >> +struct drm_device *dev, struct drm_crtc *crtc, uint64_t >> user_data) > > Nit

[Bug 194761] amdgpu driver breaks on Oland (SI)

2017-07-06 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=194761 --- Comment #71 from Alexander Tsoy (alexan...@tsoy.me) --- (In reply to Alexander Tsoy from comment #70) > For me P4_8x16 config fixed this issue. > > $ sudo dmesg | egrep 'RAM width|OLAND' > [1.670667] [drm] initializing kernel modesetting

Re: [PATCH 3/3] drm: Add CRTC_GET_SEQUENCE and CRTC_QUEUE_SEQUENCE ioctls

2017-07-06 Thread Keith Packard
Daniel Vetter writes: > I very much like this since the old ioctl really is a rather bad horror > show. And since it's tied in with ums drivers everything is > complicated. Thanks for your kind words. > I started a discussion a while back whether these should be restricted to > DRM_MASTER (i.e.

Re: [PATCH 3/3] drm: Add CRTC_GET_SEQUENCE and CRTC_QUEUE_SEQUENCE ioctls

2017-07-06 Thread Keith Packard
Ville Syrjälä writes: > Maybe, or maybe we want to turn the interrupt on in that case? That's > what the old ioctl does. That's what I suggested in my reply to Daniel's review. Even if we add the accurate function, we'll still need the interrupt-enable case as a fallback for drivers which don't

[Bug 99292] GPU hang in High Fidelity

2017-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99292 --- Comment #5 from Christoph Haag --- I don't know if it's still the same problem but now it always happens *very* quickly after starting the app. Here's a fresh api trace: https://haagch.frickel.club/files/interface-2.trace.xz -- You are rece

Re: [PATCH 3/3] drm: Add CRTC_GET_SEQUENCE and CRTC_QUEUE_SEQUENCE ioctls

2017-07-06 Thread Ville Syrjälä
On Thu, Jul 06, 2017 at 09:28:40AM -0700, Keith Packard wrote: > Ville Syrjälä writes: > > > Maybe, or maybe we want to turn the interrupt on in that case? That's > > what the old ioctl does. > > That's what I suggested in my reply to Daniel's review. Even if we add > the accurate function, we'l

Re: [PATCH 3/3] drm: Add CRTC_GET_SEQUENCE and CRTC_QUEUE_SEQUENCE ioctls

2017-07-06 Thread Keith Packard
Ville Syrjälä writes: > I was mostly thinking of the 'seq = query(); wait(seq + n);' pattern > where we can avoid doing the full update more than once if we enable > the interrupt already during the query. Don't we still wait 5 seconds before disabling vblank? In that case, the chances of hittin

[Bug 99859] Glamor Crashes on big endian Hardware

2017-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99859 --- Comment #22 from intermedi...@hotmail.com --- last mesa xorg log just to report. different error. with last mesa dev OpenGL core profile version string: 3.3 (Core Profile) Mesa 17.2.0-devel (git-f78aa2c986) [ 5057.542] (II) glamor: OpenG

[Bug 196273] Loss of video output and system freezes *ERROR* Couldn't read SADs: 0

2017-07-06 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=196273 --- Comment #8 from Olaf H B (o...@seldiame.net) --- (In reply to Michel Dänzer from comment #6) > Is this a regression from older kernel versions? If yes, can you bisect? I don't think this is a regression because I had similar issues with kerne

[Bug 196273] Loss of video output and system freezes *ERROR* Couldn't read SADs: 0

2017-07-06 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=196273 --- Comment #9 from Olaf H B (o...@seldiame.net) --- Created attachment 257391 --> https://bugzilla.kernel.org/attachment.cgi?id=257391&action=edit kern.log -- You are receiving this mail because: You are watching the assignee of the bug.

Re: [PATCH 3/3] drm: Add CRTC_GET_SEQUENCE and CRTC_QUEUE_SEQUENCE ioctls

2017-07-06 Thread Ville Syrjälä
On Thu, Jul 06, 2017 at 11:22:43AM -0700, Keith Packard wrote: > Ville Syrjälä writes: > > > I was mostly thinking of the 'seq = query(); wait(seq + n);' pattern > > where we can avoid doing the full update more than once if we enable > > the interrupt already during the query. > > Don't we stil

[Bug 196273] Loss of video output and system freezes *ERROR* Couldn't read SADs: 0

2017-07-06 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=196273 --- Comment #10 from Alex Deucher (alexdeuc...@gmail.com) --- Can you get a log with symbols? -- You are receiving this mail because: You are watching the assignee of the bug. ___ dri-devel mailing lis

[PATCH v2 4/4] drm/i915: Acquire PUNIT->PMIC bus for intel_uncore_forcewake_reset()

2017-07-06 Thread Hans de Goede
intel_uncore_forcewake_reset() does forcewake puts and gets as such we need to make sure that no-one tries to access the PUNIT->PMIC bus (on systems where this bus is shared) while it runs, otherwise bad things happen. Normally this is taken care of by the i915_pmic_bus_access_notifier() which doe

[PATCH v2 1/4] drm/i915: Fix false-positive assert_rpm_wakelock_held in i915_pmic_bus_access_notifier

2017-07-06 Thread Hans de Goede
assert_rpm_wakelock_held is triggered from i915_pmic_bus_access_notifier even though it gets unregistered on (runtime) suspend, this is caused by a race happening under the following circumstances: intel_runtime_pm_put does: atomic_dec(&dev_priv->pm.wakeref_count); pm_runtime_mark_last_bus

[PATCH v2 2/4] drm/i915: Re-register PMIC bus access notifier on runtime resume

2017-07-06 Thread Hans de Goede
intel_uncore_suspend() unregisters the uncore code's PMIC bus access notifier and gets called on both normal and runtime suspend. intel_uncore_resume_early() re-registers the notifier, but only on normal resume. Add a new intel_uncore_runtime_resume() function which only re-registers the notifier

[PATCH v2 3/4] drm/i915: Call uncore_suspend before platform suspend handlers

2017-07-06 Thread Hans de Goede
Quoting Ville: "the forcewake timer might still be active until the uncore suspend, and having active forcewakes while we've already told the GT wake stuff to stop acting normally doesn't seem quite right to me." Reported-by: Ville Syrjälä Suggested-by: Imre Deak Signed-off-by: Hans de Goede --

Re: [PATCH 3/3] drm: Add CRTC_GET_SEQUENCE and CRTC_QUEUE_SEQUENCE ioctls

2017-07-06 Thread Keith Packard
Ville Syrjälä writes: > With the disable_immediate thing we only wait until the next vblank > before disabling the irq again. Ok, still sounds like we'll be doing fine if the application does a get immediately followed by a queue event. At least most of the time. -- -keith signature.asc Desc

[PATCH 01/22] drm/i915: Pass the new crtc state to color management code

2017-07-06 Thread ville . syrjala
From: Ville Syrjälä In an effort to eliminate the obj->state usage let's pass on the new crtc state pointer (which we already have!) to the color management code. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) di

[PATCH 03/22] drm/i915: Eliminate obj->state usage in g4x/vlv/chv wm computation

2017-07-06 Thread ville . syrjala
From: Ville Syrjälä Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_drv.h | 9 + drivers/gpu/drm/i915/intel_drv.h | 8 drivers/gpu/drm/i915/intel_pm.c | 30 +++--- 3 files changed, 32 insertions(+), 15 deletions(-) diff --git a/drivers/gp

[PATCH 02/22] drm/i915: Pass the crtc state explicitly to intel_pipe_update_start/end()

2017-07-06 Thread ville . syrjala
From: Ville Syrjälä Pass the appropriate new crtc state explicitly to intel_pipe_update_start/end() instead of of mucking around with crtc->state. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 18 +++--- drivers/gpu/drm/i915/intel_drv.h | 13 ++

[PATCH 05/22] drm/i915: Eliminate obj->state usage from pre/post plane update

2017-07-06 Thread ville . syrjala
From: Ville Syrjälä Dig up the appropriate new crtc and plane states from the top level atomic state in intel_pre_plane_update() and intel_post_plane_update(). Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-)

[PATCH v2 00/22] drm/i915: Fix pre-g4x GPU reset, again (v2)

2017-07-06 Thread ville . syrjala
From: Ville Syrjälä OK, so here's the full version of my rw_semaphore GPU vs. display reset fix. The only issue I'm aware of is that SKL watermark code still uses obj->state and thus I have no clue what would happen if one tries to run this on SKL. Untangling that would likely mean making the SK

[PATCH 04/22] drm/i915: Pass proper old/new states to intel_plane_atomic_check_with_state()

2017-07-06 Thread ville . syrjala
From: Ville Syrjälä Eliminate plane->state and crtc->state usage from intel_plane_atomic_check_with_state() and its callers. Instead pass the proper states in or dig them up from the top level atomic state. Note that intel_plane_atomic_check_with_state() itself isn't allowed to use the top level

[PATCH 07/22] drm/i915: Eliminate crtc->state usage from intel_atomic_commit_tail and .crtc_update()

2017-07-06 Thread ville . syrjala
From: Ville Syrjälä We already have the correct new crtc state so just use that instead of crtc->state. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/driver

[PATCH 06/22] drm/i915: Eliminate crtc->state usage from intel_update_pipe_config()

2017-07-06 Thread ville . syrjala
From: Ville Syrjälä Pass the correct new crtc state to intel_update_pipe_config() instead of using crtc->state. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/i915/in

[PATCH 08/22] drm: Add drm_dynarray

2017-07-06 Thread ville . syrjala
From: Ville Syrjälä Add a small helper that gives us dynamically growing arrays. We have a couple hand rolled implementations of this in the atomic code, which we can unify to use a common implementation. Signed-off-by: Ville Syrjälä --- Documentation/gpu/drm-utils.rst | 15 +++ Documentat

[PATCH 10/22] drm/atomic: Remove pointless private object NULL state check

2017-07-06 Thread ville . syrjala
From: Ville Syrjälä We will never add private objects with a NULL state into the atomic state, hence checking for that is pointless. Cc: Dhinakaran Pandiyan Reviewed-by: Daniel Vetter Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_atomic.c | 3 +-- 1 file changed, 1 insertion(+), 2 del

[PATCH 13/22] drm/atomic: Pass old state to __drm_atomic_helper_crtc_duplicate_state() & co. explicitly

2017-07-06 Thread ville . syrjala
From: Ville Syrjälä We'll be wanting to duplicate other states besides the one pointed to by crtc->state & co., so pass the duplicated state in explicitly. @r@ identifier F =~ "^__drm_atomic_helper_.*_duplicate_state$"; identifier O, S; type T, TS; @@ F(T O, TS *S + ,const TS *old_state ) { <.

[PATCH 09/22] drm/atomic: Convert state->connectors to drm_dynarray

2017-07-06 Thread ville . syrjala
From: Ville Syrjälä state->connectors[] can grows dynamically, so we can switch over to using the new drm_dynarray. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_atomic.c| 49 +++-- drivers/gpu/drm/drm_atomic_helper.c | 4 +-- include/drm/drm_ato

[PATCH 15/22] drm/mediatek: s/old_state/old_mtk_state/

2017-07-06 Thread ville . syrjala
From: Ville Syrjälä Rename the local 'old_state' variable to 'old_mtk_state' to get it out of the way of some cocci refactoring. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/mediatek/mtk_drm_plane.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/med

Re: [PATCH 1/6] drm: Add helper to check exporting driver of a DMA-buf

2017-07-06 Thread Christian König
Am 06.07.2017 um 22:16 schrieb Felix Kuehling: This allows drivers to check if a DMA-buf contains a GEM object and whether it comes from the same driver. It may be from the same or a different device. Signed-off-by: Felix Kuehling I think Daniel/Dave hadmore a function which returns the caste

[PATCH 11/22] drm/atomic: Convert private_objs to drm_dynarray

2017-07-06 Thread ville . syrjala
From: Ville Syrjälä state->private_objs grows dynamically, so switch it over to use the new drm_dynarray helper. Cc: Dhinakaran Pandiyan Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_atomic.c| 64 - drivers/gpu/drm/drm_atomic_helper.c | 2 +-

[PATCH 17/22] drm/atomic: Fix up the kernel docs for the state duplication functions

2017-07-06 Thread ville . syrjala
From: Ville Syrjälä Coccinelle doesn't fix up the docs for us, so let's do it manually. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_atomic_helper.c | 12 +--- include/drm/drm_connector.h | 2 +- include/drm/drm_crtc.h | 2 +- include/drm/drm_plane.h

[PATCH 16/22] drm/atomic: Pass old state explicitly to .atomic_duplicate_state()

2017-07-06 Thread ville . syrjala
From: Ville Syrjälä We'll be wanting to duplicate other states besides the one pointed to by crtc->state & co., so pass the duplicated state in explicitly. I wanted to make the old_state const, but that would have results in tons of new warnings because some drivers have their to_foo_state()s as

[PATCH 12/22] drm/atomic: Make private objs proper objects

2017-07-06 Thread ville . syrjala
From: Ville Syrjälä Make the atomic private object stuff less special by introducing proper base classes for the object and its state. Drivers can embed these in their own appropriate objects, after which these things will work exactly like the plane/crtc/connector states during atomic operations

[PATCH 20/22] drm/i915: Refactor __intel_atomic_commit_tail()

2017-07-06 Thread ville . syrjala
From: Ville Syrjälä Split intel_atomic_commit_tail() into a lower level function that does the actual commit, and a higher level one that waits for the dependencies and signals the commit as done. We'll reuse the lower level function to perform commits during GPU resets. Signed-off-by: Ville Syr

[PATCH 19/22] drm/i915% Store vma gtt offset in plane state

2017-07-06 Thread ville . syrjala
From: Ville Syrjälä To avoid having to deference plane_state->vma during the commit phase of plane updates, let's store the vma gtt offset (or the bus address when we need it) in the plane state. This is crucial for doing the modeset operations during GPU reset as as plane_state->vma gets cleared

[PATCH v3 21/22] drm/atomic: Introduce drm_atomic_helper_duplicate_commited_state()

2017-07-06 Thread ville . syrjala
From: Ville Syrjälä For i915 GPU reset handling we'll want to be able to duplicate the state that was last commited to the hardware. For that purpose let's start to track the commited state for each object and provide a way to duplicate the commmited state into a new drm_atomic_state. The locking

[PATCH 18/22] drm: Return the connector from drm_connector_get()

2017-07-06 Thread ville . syrjala
From: Ville Syrjälä Make drm_connector_get() return the connector. This allows the nice pattern of 'foo->connector = drm_connector_get(connector)' Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_atomic.c| 3 +-- drivers/gpu/drm/drm_fb_helper.c | 7 +++ include/drm/drm_connector.h

[PATCH 14/22] drm/arm: s/old_state/old_mali_state/

2017-07-06 Thread ville . syrjala
From: Ville Syrjälä Rename the local 'old_state' variable to 'old_mali_state' to get it out of the way of some cocci refactoring. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/arm/malidp_crtc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/ar

[PATCH v5 22/22] drm/i915: Solve the GPU reset vs. modeset deadlocks with an rw_semaphore

2017-07-06 Thread ville . syrjala
From: Ville Syrjälä Introduce an rw_semaphore to protect the display commits. All normal commits use down_read() and hence can proceed in parallel, but GPU reset will use down_write() making sure no other commits are in progress when we have to pull the plug on the display engine on pre-g4x platf

[PATCH 1/6] drm: Add helper to check exporting driver of a DMA-buf

2017-07-06 Thread Felix Kuehling
This allows drivers to check if a DMA-buf contains a GEM object and whether it comes from the same driver. It may be from the same or a different device. Signed-off-by: Felix Kuehling --- drivers/gpu/drm/drm_prime.c | 24 include/drm/drmP.h | 2 ++ 2 files chan

Re: [PATCH 3/3] drm: Add CRTC_GET_SEQUENCE and CRTC_QUEUE_SEQUENCE ioctls

2017-07-06 Thread Daniel Vetter
On Thu, Jul 6, 2017 at 6:27 PM, Keith Packard wrote: > Daniel Vetter writes: > >> I very much like this since the old ioctl really is a rather bad horror >> show. And since it's tied in with ums drivers everything is >> complicated. > > Thanks for your kind words. > >> I started a discussion a wh

Re: [PATCH libdrm] libdrm_amdgpu: add kernel semaphore support

2017-07-06 Thread Dave Airlie
Chrstian, you are probably the best person to ack this, I'd like to get the radv code landed and allow the GL code to get going. Dave. > This adds kernel semaphore support to the command submission > interface in what should be a backwards compatible manner, > it adds a new command submission AP

[Bug 101712] CPU lockup after ring 0 stalled

2017-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101712 guiscara...@gmail.com changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |dri-devel@lists.freedesktop

[PATCH v4 08/14] drm: gma500: remove dead code and pointless local lut storage

2017-07-06 Thread Peter Rosin
The redundant fb helpers .gamma_set and .gamma_get are no longer used. Remove the dead code and hook up the crtc .gamma_set to use the crtc gamma_store directly instead of duplicating that info locally. Signed-off-by: Peter Rosin --- drivers/gpu/drm/gma500/framebuffer.c | 22 --

[PATCH v4 11/14] drm: nouveau: remove dead code and pointless local lut storage

2017-07-06 Thread Peter Rosin
The redundant fb helpers .load_lut, .gamma_set and .gamma_get are no longer used. Remove the dead code and hook up the crtc .gamma_set to use the crtc gamma_store directly instead of duplicating that info locally. Signed-off-by: Peter Rosin --- drivers/gpu/drm/nouveau/dispnv04/crtc.c | 26 ++

[PATCH v4 12/14] drm: radeon: remove dead code and pointless local lut storage

2017-07-06 Thread Peter Rosin
The redundant fb helpers .load_lut, .gamma_set and .gamma_get are no longer used. Remove the dead code and hook up the crtc .gamma_set to use the crtc gamma_store directly instead of duplicating that info locally. Signed-off-by: Peter Rosin --- drivers/gpu/drm/radeon/atombios_crtc.c | 1 -

Re: [PATCH] drm/bridge: dw_hdmi: add cec notifier support

2017-07-06 Thread Russell King - ARM Linux
On Thu, Jul 06, 2017 at 12:33:06PM +0200, Neil Armstrong wrote: > From: Russell King > > Add CEC notifier support to the HDMI bridge driver, so that the CEC > part of the IP can receive its physical address. > > Tested-by: Neil Armstrong > Acked-by: Neil Armstrong > Acked-by: Hans Verkuil > S

Re: [PATCH v3 05/16] drm/fb-helper: do a generic fb_setcmap helper in terms of crtc .gamma_set

2017-07-06 Thread Peter Rosin
On 2017-07-06 07:55, Daniel Vetter wrote: > On Wed, Jul 5, 2017 at 7:50 PM, Peter Rosin wrote: +retry: +ret = drm_modeset_lock_all_ctx(dev, &ctx); >>> >>> With atomic you don't need to grab locks, this is done behind the scenes >>> (as long as you handle the retry/backoff correctly).

[PATCH v4 02/14] drm/atomic-helper: update lut props directly in ..._legacy_gamma_set

2017-07-06 Thread Peter Rosin
Do not waste cycles looking up the property id when we have the actual property already. Signed-off-by: Peter Rosin --- drivers/gpu/drm/drm_atomic_helper.c | 23 --- 1 file changed, 8 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/

[PATCH v4 06/14] drm: ast: remove dead code and pointless local lut storage

2017-07-06 Thread Peter Rosin
The redundant fb helpers .load_lut, .gamma_set and .gamma_get are no longer used. Remove the dead code and hook up the crtc .gamma_set to use the crtc gamma_store directly instead of duplicating that info locally. Signed-off-by: Peter Rosin --- drivers/gpu/drm/ast/ast_drv.h | 1 - drivers/gpu/

Re: [PATCH] drm/bridge: dw_hdmi: add cec notifier support

2017-07-06 Thread Russell King - ARM Linux
On Thu, Jul 06, 2017 at 02:38:41PM +0100, Russell King - ARM Linux wrote: > On Thu, Jul 06, 2017 at 12:56:43PM +0100, Russell King - ARM Linux wrote: > > On Thu, Jul 06, 2017 at 12:45:55PM +0100, Russell King - ARM Linux wrote: > > > Well, from what I can see in 4.12, the cec-notifier stuff is rath

Re: [PATCH] drm/bridge: dw_hdmi: add cec notifier support

2017-07-06 Thread Jose Abreu
Hi Neil, On 06-07-2017 11:33, Neil Armstrong wrote: > From: Russell King > > Add CEC notifier support to the HDMI bridge driver, so that the CEC > part of the IP can receive its physical address. > > Tested-by: Neil Armstrong > Acked-by: Neil Armstrong > Acked-by: Hans Verkuil > Signed-off-by

Re: [PATCH] drm/bridge: dw_hdmi: add cec notifier support

2017-07-06 Thread Russell King - ARM Linux
On Thu, Jul 06, 2017 at 01:55:58PM +0200, Neil Armstrong wrote: > On 07/06/2017 01:45 PM, Russell King - ARM Linux wrote: > > Well, from what I can see in 4.12, the cec-notifier stuff is rather > > broken (tda998x has stopped working as its stuck with a physical > > address of f.f.f.f) so I think t

[PATCH v4 03/14] drm/fb-helper: separate the fb_setcmap helper into atomic and legacy paths

2017-07-06 Thread Peter Rosin
The legacy path implements setcmap in terms of crtc .gamma_set. The atomic path implements setcmap by directly updating the crtc gamma_lut property. This has a couple of benefits: - it makes the redundant fb helpers .load_lut, .gamma_set and .gamma_get completely obsolete. They are now unused a

printk: Should console related code avoid __GFP_DIRECT_RECLAIM memory allocations?

2017-07-06 Thread Tetsuo Handa
-love.SAKURA.ne.jp/tmp/serial-20170706.txt.xz : [ 779.494100] Mem-Info: [ 779.495493] active_anon:846948 inactive_anon:5416 isolated_anon:0 [ 779.495493] active_file:33 inactive_file:13 isolated_file:47 [ 779.495493] unevictable:0 dirty:11

[PATCH v4 09/14] drm: i915: remove dead code and pointless local lut storage

2017-07-06 Thread Peter Rosin
The driver stores lut values from the fbdev interface, and is able to give them back, but does not appear to do anything with these lut values. The generic fb helpers have replaced this function, and may even have made the driver work for the C8 mode from the fbdev interface. But that is untested.

  1   2   >