On 24/05/17 09:46, Laurent Pinchart wrote:
> Hi Tomi,
>
> Thank you for the patch.
>
> On Wednesday 17 May 2017 10:56:44 Tomi Valkeinen wrote:
>> When rotating 90/270 + mirroring with YUV422, the end result will have
>> adjacent pixels swapped. The problem is that
>> dispc_ovl_set_rotation_attr
From: Dave Airlie
This interface will allow sync object to be used to back
Vulkan fences. This API is pretty much the vulkan fence waiting
API, and I've ported the code from amdgpu.
v2: accept relative timeout, pass remaining time back
to userspace.
v3: return to absolute timeouts.
Signed-off-b
From: Dave Airlie
Sync objects are new toplevel drm object, that contain a
pointer to a fence. This fence can be updated via command
submission ioctls via drivers.
There is also a generic wait obj API modelled on the vulkan
wait API (with code modelled on some amdgpu code).
These objects can be
From: Dave Airlie
This interface allows importing the fence from a sync_file into
an existing drm sync object, or exporting the fence attached to
an existing drm sync object into a new sync file object.
This should only be used to interact with sync files where necessary.
Reviewed-by: Sean Paul
I've fixed up a few things in here from Daniel's comments,
Daniel I didn't change things exactly as suggested but I removed
fd_flags from API completely.
Christian, I think I got the post deps hook in the right place
now in the amdgpu patch.
Would be nice if someone can validate the timeout stuff
From: Dave Airlie
This just splits out the fence depenency checking into it's
own function to make it easier to add semaphore dependencies.
Reviewed-by: Christian König
Signed-off-by: Dave Airlie
---
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 85 +++---
1 file change
From: Dave Airlie
This creates a new command submission chunk for amdgpu
to add in and out sync objects around the submission.
Sync objects are managed via the drm syncobj ioctls.
The command submission interface is enhanced with two new
chunks, one for syncobj pre submission dependencies,
and
tree: git://people.freedesktop.org/~airlied/linux.git drm-syncobj
head: e81b546d28fcd98cbb6179e7b4384fa356cb38c9
commit: 37e2e39a652546d13d21376778afcdfee9b40eb6 [1/6] drm: introduce sync
objects (v3)
reproduce: make htmldocs
All warnings (new ones prefixed by >>):
WARNING: convert(1) not
On 2017年05月24日 15:06, Dave Airlie wrote:
From: Dave Airlie
This creates a new command submission chunk for amdgpu
to add in and out sync objects around the submission.
Sync objects are managed via the drm syncobj ioctls.
The command submission interface is enhanced with two new
chunks, one
On Tue, May 23, 2017 at 09:00:59PM +0800, icen...@aosc.io wrote:
> 在 2017-05-23 20:53，Maxime Ripard 写道：
> > On Mon, May 22, 2017 at 07:55:56PM +0200, Jernej Škrabec wrote:
> > > Hi,
> > >
> > > Dne sobota, 20. maj 2017 ob 03:37:53 CEST je Chen-Yu Tsai napisal(a):
> > > > On Sat, May 20, 2017 at 2:
https://bugs.freedesktop.org/show_bug.cgi?id=85579
Samuel Pitoiset changed:
What|Removed |Added
Resolution|--- |FIXED
Status|NEW
https://bugs.freedesktop.org/show_bug.cgi?id=76241
Samuel Pitoiset changed:
What|Removed |Added
Resolution|--- |FIXED
Status|NEW
https://bugs.freedesktop.org/show_bug.cgi?id=79575
Samuel Pitoiset changed:
What|Removed |Added
Resolution|--- |FIXED
Status|NEW
On Tue, 23 May 2017, Puthikorn Voravootivat wrote:
> There are some panel that
> (1) does not support display backlight enable via AUX
> (2) support display backlight adjustment via AUX
> (3) support display backlight enable via eDP BL_ENABLE pin
>
> The current driver required that (1) must be su
On Sat, May 20, 2017 at 02:00:22AM +0800, Icenowy Zheng wrote:
>
>
> 于 2017年5月20日 GMT+08:00 上午1:57:53, Maxime Ripard
> 写到:
> >On Thu, May 18, 2017 at 12:43:46AM +0800, Icenowy Zheng wrote:
> >> Some SoC's DE2 has two mixers. Defaultly the mixer0 is connected to
> >> tcon0 and mixer1 is connecte
On Sat, May 20, 2017 at 02:10:35AM +0800, Icenowy Zheng wrote:
>
>
> 于 2017年5月20日 GMT+08:00 上午2:06:16, Maxime Ripard
> 写到:
> >On Thu, May 18, 2017 at 12:43:53AM +0800, Icenowy Zheng wrote:
> >> As we have already the support for the TV encoder on Allwinner H3,
> >add
> >> the display engine pip
On Tue, May 23, 2017 at 03:38:02PM -0700, Puthikorn Voravootivat wrote:
> Add option to allow choosing how to adjust brightness if
> panel supports both PWM pin and AUX channel.
>
> Signed-off-by: Puthikorn Voravootivat
> ---
> drivers/gpu/drm/i915/i915_params.c| 8 +---
> drive
On Tue, 23 May 2017, Puthikorn Voravootivat wrote:
> This patch adds the following definition
> - Bit mask for EDP_PWMGEN_BIT_COUNT and min/max cap
> register which only use bit 0:4
> - Base frequency (27 MHz) for backlight PWM frequency
> generator.
>
> Signed-off-by: Puthikorn Voravootivat
https://bugs.freedesktop.org/show_bug.cgi?id=79575
Samuel Pitoiset changed:
What|Removed |Added
Resolution|FIXED |WONTFIX
--- Comment #12 from Samuel Pi
Am 24.05.2017 um 09:25 schrieb zhoucm1:
On 2017年05月24日 15:06, Dave Airlie wrote:
From: Dave Airlie
This creates a new command submission chunk for amdgpu
to add in and out sync objects around the submission.
Sync objects are managed via the drm syncobj ioctls.
The command submission interf
Hi Tomi,
On Wednesday 24 May 2017 09:50:49 Tomi Valkeinen wrote:
> On 24/05/17 09:44, Laurent Pinchart wrote:
> >> b/drivers/gpu/drm/omapdrm/omap_fb.c index bd05976fc20b..e5cc13799e73
> >> 100644
> >> --- a/drivers/gpu/drm/omapdrm/omap_fb.c
> >> +++ b/drivers/gpu/drm/omapdrm/omap_fb.c
> >> @@ -184
On Tue, 2017-05-23 at 15:12 +0200, Daniel Vetter wrote:
> On Tue, May 23, 2017 at 05:28:15PM +0800, CK Hu wrote:
> > Hi, Bibby:
> >
> > I've applied this patch to my branch mediatek-drm-fixes-4.12-rc1,
> > thanks.
> >
> > Regards,
> > CK
> >
> > On Tue, 2017-01-24 at 13:10 +0800, Bibby Hsieh wro
On Wed, May 24, 2017 at 04:50:39PM +0800, changbin...@intel.com wrote:
> From: Changbin Du
>
> At least we need one MPT module (currently only have one) selected
> to get GVTg functional. When GVTg is enabled while no MPT selected,
> the build just includes useless GVTg code. This doesn't make se
On 2017.05.24 16:50:39 +0800, changbin...@intel.com wrote:
> From: Changbin Du
>
> At least we need one MPT module (currently only have one) selected
> to get GVTg functional. When GVTg is enabled while no MPT selected,
> the build just includes useless GVTg code. This doesn't make sense.
>
The
We can't check this when applying (since r-b/a-b tags often get added
afterwards), but we can check this when pushing. This only looks at
patches authored by the pusher.
Also update the docs to highlight that review requirements hold
especially also for bugfixes.
Cc: Patrik Jakobsson
Cc: Lukas W
Hi Tomi,
Thank you for the patch.
On Thursday 04 May 2017 13:23:22 Tomi Valkeinen wrote:
> We have three rotation methods supported by the SoCs with DSS: DMA,
> VRFB and TILER.
>
> DMA rotation works in theory on all DSS platforms, but in practice it's
> unusable due to the huge amount of memory
Hi Tomi,
Thank you for the patch.
On Thursday 04 May 2017 13:23:23 Tomi Valkeinen wrote:
> The code to calculate offset in dispc's calc_offset() is overly complex.
> Simplify it.
>
> Signed-off-by: Tomi Valkeinen
Reviewed-by: Laurent Pinchart
> ---
> drivers/gpu/drm/omapdrm/dss/dispc.c | 6
Hi Tomi,
Thank you for the patch.
On Thursday 04 May 2017 13:23:24 Tomi Valkeinen wrote:
> In a few places the dispc driver needs to know whether the pixel format
> is an YUV format. Add a helper to figure that out.
>
> Signed-off-by: Tomi Valkeinen
> ---
> drivers/gpu/drm/omapdrm/dss/dispc.c
On Wed, May 24, 2017 at 11:28:12AM +0200, Daniel Vetter wrote:
> We can't check this when applying (since r-b/a-b tags often get added
> afterwards), but we can check this when pushing. This only looks at
> patches authored by the pusher.
>
> Also update the docs to highlight that review requireme
Hi Tomi,
Thank you for the patch.
On Thursday 04 May 2017 13:23:25 Tomi Valkeinen wrote:
> omapdss.h contains prototypes for three functions, which are also
> defined in dss_features.h. Remove the extra prototypes from omapdss.h.
>
> Signed-off-by: Tomi Valkeinen
Reviewed-by: Laurent Pinchart
Hi Tomi,
On Thursday 04 May 2017 13:23:26 Tomi Valkeinen wrote:
> struct omap_overlay has 'supported_modes' field that is not used. Remove
> it.
This seems to conflict with "drm/omap: remove omap_overlay &
omap_overlay_manager" :-)
> Signed-off-by: Tomi Valkeinen
> ---
> drivers/gpu/drm/omapd
https://bugzilla.kernel.org/show_bug.cgi?id=194761
--- Comment #17 from flora@amd.com ---
I'll continue to check this issue. meanwhile you could revert the guilty commit
for quick fix. the tiling table is an optimization from hw team. btw, have u
try with amdgpu-pro driver? maybe that's the di
On 24/05/17 12:31, Laurent Pinchart wrote:
> Hi Tomi,
>
> Thank you for the patch.
>
> On Thursday 04 May 2017 13:23:22 Tomi Valkeinen wrote:
>> We have three rotation methods supported by the SoCs with DSS: DMA,
>> VRFB and TILER.
>>
>> DMA rotation works in theory on all DSS platforms, but in p
Hi Tomi,
Thank you for the patch.
On Thursday 04 May 2017 13:23:29 Tomi Valkeinen wrote:
> In this step we drop 'enum omap_color_mode', and use u32 instead.
>
> Signed-off-by: Tomi Valkeinen
I believe this should go before 12/16, otherwise you end up temporarily
storing DRM_FORMAT_* values in
Hi Tomi,
Thank you for the patch.
On Thursday 04 May 2017 13:23:30 Tomi Valkeinen wrote:
> We now get a fourcc array from dispc when asking for a plane's supported
> pixel formats, so we can drop omap_framebuffer_get_formats() which was
> used to convert between DSS and DRM pixel formats.
>
> Si
Hi Tomi,
Thank you for the patch.
On Thursday 04 May 2017 13:23:28 Tomi Valkeinen wrote:
> This patch changes omapdrm to use DRM_FORMAT_* values instead of
> OMAP_DSS_COLOR_* enum. This patch only changes the uses of
> OMAP_DSS_COLOR_*, so we still keep the enum omap_color_mode. I.e. we now
> tem
On 24/05/17 13:28, Laurent Pinchart wrote:
> Hi Tomi,
>
> Thank you for the patch.
>
> On Thursday 04 May 2017 13:23:29 Tomi Valkeinen wrote:
>> In this step we drop 'enum omap_color_mode', and use u32 instead.
>>
>> Signed-off-by: Tomi Valkeinen
>
> I believe this should go before 12/16, oth
Hi Tomi,
Thank you for the patch.
On Thursday 04 May 2017 13:23:27 Tomi Valkeinen wrote:
> enum omap_color_mode is a bitmask, so at the moment we present the
> supported color modes as mask. To be able to move to fourccs, we need to
> use an array to present the supported color modes.
>
> As a f
Hi Tomi,
On Wednesday 24 May 2017 13:37:48 Tomi Valkeinen wrote:
> On 24/05/17 13:28, Laurent Pinchart wrote:
> > On Thursday 04 May 2017 13:23:29 Tomi Valkeinen wrote:
> >> In this step we drop 'enum omap_color_mode', and use u32 instead.
> >>
> >> Signed-off-by: Tomi Valkeinen
> >
> > I belie
Hi Tomi,
Thank you for the patch.
Reviewed-by: Laurent Pinchart
On Thursday 04 May 2017 13:23:31 Tomi Valkeinen wrote:
> omap_fb.c has a table with DSS and DRM formats, used to convert between
> them. This is no longer needed, so we can change the array to a plain
> array of DRM_FORMAT_* values
Hi Tomi,
Thank you for the patch.
On Thursday 04 May 2017 13:23:32 Tomi Valkeinen wrote:
> Now that we use fourccs, we can also rename the 'color_mode' variables
> to 'fourcc'.
>
> Signed-off-by: Tomi Valkeinen
Reviewed-by: Laurent Pinchart
> ---
> drivers/gpu/drm/omapdrm/dss/dispc.c
Hi Tomi,
On Wednesday 24 May 2017 13:13:08 Tomi Valkeinen wrote:
> On 24/05/17 12:31, Laurent Pinchart wrote:
> > On Thursday 04 May 2017 13:23:22 Tomi Valkeinen wrote:
> >> We have three rotation methods supported by the SoCs with DSS: DMA,
> >> VRFB and TILER.
> >>
> >> DMA rotation works in th
https://bugs.freedesktop.org/show_bug.cgi?id=99851
--- Comment #37 from intermedi...@hotmail.com ---
Hi i can confirm the CAFEDEAD issue is present on AMDGPU too on Qoriq PPC64
Machine . Tested with a Radeon R7 250 2GB
This issue on this Machine is not present for r600.
Tested on 4.11.1
--
You
On 24/05/17 13:46, Laurent Pinchart wrote:
> Hi Tomi,
>
> On Wednesday 24 May 2017 13:37:48 Tomi Valkeinen wrote:
>> On 24/05/17 13:28, Laurent Pinchart wrote:
>>> On Thursday 04 May 2017 13:23:29 Tomi Valkeinen wrote:
In this step we drop 'enum omap_color_mode', and use u32 instead.
>
On Wed, 24 May 2017, changbin...@intel.com wrote:
> From: Changbin Du
>
> At least we need one MPT module (currently only have one) selected
> to get GVTg functional. When GVTg is enabled while no MPT selected,
> the build just includes useless GVTg code. This doesn't make sense.
>
> With this pat
https://bugzilla.kernel.org/show_bug.cgi?id=194761
--- Comment #18 from Jean Delvare (jdelv...@suse.de) ---
I did not try the amdgpu-pro driver. My distribution (SUSE) doesn't appear to
be supported, and the download page doesn't list my hardware (Radeon R5 240) as
supported by this driver anyway.
On Tue, May 23, 2017 at 03:40:24PM +0100, Jose Abreu wrote:
> Hi Daniel,
>
>
> On 22-05-2017 16:31, Daniel Vetter wrote:
> > On Mon, May 22, 2017 at 09:56:00AM +0200, Daniel Vetter wrote:
> >> On Fri, May 19, 2017 at 01:52:09AM +0100, Jose Abreu wrote:
> >>> This series is a follow up from the di
On Wed, May 24, 2017 at 09:47:49AM +1000, Dave Airlie wrote:
> On 28 April 2017 at 07:27, Gustavo Padovan wrote:
> > 2017-04-26 Christian König :
> >
> >> Am 26.04.2017 um 16:46 schrieb Andres Rodriguez:
> >> > When a timeout of zero is specified, the caller is only interested in
> >> > the fence
On Tue, May 23, 2017 at 09:47:56AM -0500, Rob Herring wrote:
> On Tue, May 16, 2017 at 11:19:04AM +0300, Baruch Siach wrote:
> > Fixes: 14da3ed8dd08 ("devicetree/bindings: display: Document common panel
> > properties")
> > Cc: Laurent Pinchart
> > Cc: Rob Herring
> > Signed-off-by: Baruch Siach
On Wed, May 24, 2017 at 05:20:45PM +0800, CK Hu wrote:
> On Tue, 2017-05-23 at 15:12 +0200, Daniel Vetter wrote:
> > On Tue, May 23, 2017 at 05:28:15PM +0800, CK Hu wrote:
> > > Hi, Bibby:
> > >
> > > I've applied this patch to my branch mediatek-drm-fixes-4.12-rc1,
> > > thanks.
> > >
> > > Rega
Hi Jose,
On 05/19/2017 02:52 AM, Jose Abreu wrote:
> Now that we have a callback to check if bridge supports a given mode
> we can use it in Synopsys Designware HDMI bridge so that we restrict
> the number of probbed modes to the ones we can actually display.
>
> Also, there is no need to use mod
Hi Tomi,
Thank you for the patch.
On Thursday 04 May 2017 13:23:18 Tomi Valkeinen wrote:
> The code that sets and clears DOUBLESTRIDE is only ran when using NV12.
> This is not correct, as we might first set the bith when using NV12, but
> never clear it when using other formats.
>
> Fix it so t
Hi Tomi,
Thank you for the patch.
On Thursday 04 May 2017 13:23:19 Tomi Valkeinen wrote:
> DSS IP versions 2 and 3 support CLUT modes (color lookup table), but the
> driver has never supported those. We still have had some code for CLUT
> modes. As the newer DSS IP versions have dropped CLUT supp
Hi Tomi,
Thank you for the patch.
On Thursday 04 May 2017 13:23:20 Tomi Valkeinen wrote:
> Use dev_err_ratelimited() when an OCP error happens, to slightly easen
> the flood.
>
> Signed-off-by: Tomi Valkeinen
Reviewed-by: Laurent Pinchart
> ---
> drivers/gpu/drm/omapdrm/omap_irq.c | 7 -
https://bugzilla.kernel.org/show_bug.cgi?id=194761
--- Comment #19 from Berg (b...@uralmail.com) ---
I confirm:
Checkerboard effect when using amdgpu on Oland is back.
On amdgpu-pro the same effect has been for a long time (despite the fact that
my R7 240 is in the list of supported devices), but
https://bugs.freedesktop.org/show_bug.cgi?id=99349
--- Comment #3 from Gert Wollny ---
I've had the same error output when I was playing with the Unreal Editor with
an HD6850 (BARTS) using the latest mesa-git.
In order to track it down I added some debugging to mesa and could get the
followi
> -Original Message-
> From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch]
> Sent: Wednesday, May 24, 2017 5:28 AM
> To: DRI Development
> Cc: Intel Graphics Development; Daniel Vetter; Patrik Jakobsson; Lukas
> Wunner; Deucher, Alexander; Christian König; Sean Paul; Daniel Vetter
> Subject
On Fri, May 5, 2017 at 4:29 AM, Ville Syrjälä
wrote:
> On Thu, May 04, 2017 at 02:52:09PM -0600, Daniel Drake wrote:
>> On Thu, May 4, 2017 at 2:37 PM, Ville Syrjälä
>> wrote:
>> > Please check if commit bb1d132935c2 ("drm/i915/vbt: split out defaults
>> > that are set when there is no VBT") fixe
Hi all,
So the first part of this patch series is the usual deal of decrufting some part
of drm and attempting to improve the docs. Mostly around vblank. I seem to be
the ever constant 5% of finally being able to document drm_driver/device
properly, oh well.
By patch count the bigger part is tryi
The magic switching between proper pci driver and shadow-attach isn't
useful anymore since there's no ums+kms drivers left. Let's split this
up properly, calling pci_register_driver for kms drivers and renaming
the shadow-attach init to drm_legacy_pci_init/exit.
Signed-off-by: Daniel Vetter
---
Since
commit ca8e2ad71013049bc88a10b11d83712bfe56cdd4
Author: Thierry Reding
Date: Fri Apr 11 15:23:00 2014 +0200
drm: Introduce drm_dev_set_unique()
the ->set_busid callback is optional. On top of that the udl one isn't
really fully compliant with the drm uabi, but since only modesetting
And document them lightly. Unfortunately kernel-doc isn't the most
awesome for documenting #defines that don't look like functions, it
makes functions out of them :-/
Signed-off-by: Daniel Vetter
---
include/drm/drmP.h | 17 -
include/drm/drm_modes.h | 17 +
This is a leftover from the drm_bus days, where we've had a
bus-specific device type for every bus type in drm_device. Except for
pci (which we can't remove because dri1 drivers) this is all gone. And
the virt driver also doesn't really need it, dev_to_virtio works
perfectly fine.
Cc: David Airlie
Pull a (much shorter) overview into drm_irq.c, and instead put the
callback documentation into in-line comments in drm_drv.h.
Signed-off-by: Daniel Vetter
---
Documentation/gpu/drm-internals.rst | 62 +
drivers/gpu/drm/drm_irq.c | 30 +++-
The only special-case is pci devices, and we can easily handle this in
the core. Do so and drop a pile of boilerplate from drivers.
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 -
drivers/gpu/drm/ast/ast_drv.c | 1 -
drivers/gpu/drm/bochs/bochs_drv.c
CRTC don't seem to get shut down in a controlled fashion, but no one
bothers to stop interrupts either so this races no matter what. Might
as well remove it. A call to drm_atomic_helper_shutdown would be
pretty sweet somewhere (and maybe getting rid of the load/unload
callbacks while at it).
Cc: A
We use drm_crtc_ for all the new-style vblank functions which directly
take a struct drm_crtc *. drm_accurate_vblank_count was the odd one
out, correct this to appease my OCD.
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/drm_vblank.c | 8
drivers/gpu/drm/i915/i915_irq.c
IRQs are properly shut down, so it almost works as race-free shutdown.
Except the irq is stopped after the vblank stuff, so boom anyway.
Proper way would be to call drm_atomic_helper_shutdown before any of
the kms things gets stopped. So no harm in removing the
drm_vblank_cleanup here really.
Same
So this seems to be the first driver that does it the right way round,
so fix it up by calling drm_atomic_helper_shutdown instead. We need to
do that before the last kms user is gone (fbdev emulation), but before
we start shutting down hw stuff like interrupts.
Cc: Xinliang Liu
Cc: Rongrong Zou
Again almost correct, but since interrupts are shut down after vblank
still a race. Proper cleanup would call drm_atomic_helper_shutdown to
make sure this really is safe.
v2: Remove misplace malidp hunk (Liviu).
Cc: Boris Brezillon
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/atmel-hlcdc/a
I'm fed up staring at the error message from kernel-doc that
it can't find anything.
Signed-off-by: Daniel Vetter
---
Documentation/gpu/drm-kms.rst | 3 ---
1 file changed, 3 deletions(-)
diff --git a/Documentation/gpu/drm-kms.rst b/Documentation/gpu/drm-kms.rst
index 2d77c9580164..0749000ab3d7
Either not relevant (in the load error paths) or done better already
(in the unload code, by calling drm_atomic_helper_shutdown). Drop it.
Cc: Mark Yao
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/d
It's only done in the driver load error path, where vblanks don't need
to be quiescent anyway. And that's all drm_vblank_cleanup does, since
the core will release the vblank allocations on its own already. So
drop it.
Cc: Philipp Zabel
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/imx/imx-dr
Again cleanup before irq disabling doesn't really stop the races,
so just drop it. Proper fix would be to put drm_atomic_helper_shutdown
before everything gets cleaned up.
Cc: Stefan Agner
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 2 --
1 file changed, 2 delet
Again we probably want a drm_atomic_helper_shutdown somewhere, but
that's a bit more analysis.
Cc: Xinliang Liu
Cc: Rongrong Zou
Cc: Xinwei Kong
Cc: Chen Feng
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/d
Seems entirely cargo-culted.
Cc: CK Hu
Cc: Philipp Zabel
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
index f6c8ec4c7dbc..56f802d0a51c
udl doesn't shut down the display, so stopping the vblank isn't going
to do much good either. Just drop it.
Cc: Dave Airlie
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/udl/udl_main.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/udl/udl_main.c b/drivers/gpu/drm/udl/u
Again, doesn't seem to serve a purpose.
Cc: Thierry Reding
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/tegra/drm.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c
index 51c48a8e00ec..0d8839244c3a 100644
--- a
I alwasy get confused about drm_wait_vblank for a split second until I
realize it's the ioctl handler. Unconfuse me, and do it for the legacy
modeset vblank control ioctl too.
While at it also noticed that I misplaced the irq ioctl handler in the
internal header file.
Signed-off-by: Daniel Vetter
nouveau_display_vblank_fini is called in the load error path (where it
doesn't matter) and module unload (where vblanks have been shut down
correctly already through drm_vblank_off), we can drop it.
Cc: Ben Skeggs
Cc: nouv...@lists.freedesktop.org
Signed-off-by: Daniel Vetter
---
drivers/gpu/dr
Again seems just cargo-culted.
Cc: Neil Armstrong
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/meson/meson_drv.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/meson/meson_drv.c
b/drivers/gpu/drm/meson/meson_drv.c
index 75382f5f0fce..2c605a406ad5 100644
--- a/drivers/gp
It doesn't do anything in the driver load error paths that the drm
core doesn't also do.
Cc: Laurent Pinchart
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/shmobile/shmob_drm_drv.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/shmobile/shmob_drm_drv.c
Again stopping the vblank before uninstalling the irq handler is kinda
the wrong way round, but the fb_off stuff should take care of
disabling the dsiplay at least in most cases. So drop the
drm_vblank_cleanup code since it's not really doing anything, it looks
all cargo-culted.
v2: Appease gcc be
Unify and review everything, plus make sure it's all correct markup.
Drop the kernel-doc for internal functions. Also rework the overview
section, it's become rather outdated.
Unfortuantely the kernel-doc in drm_driver isn't rendered yet, but
that will change as soon as drm_driver is kernel-docifi
Both drivers shut down all crtc beforehand already, which will shut up
any pending vblank (the only thing vblank_cleanup really does is
disable the disable timer). Hence we don't need this here and can
remove it.
Cc: Alex Deucher
Cc: Christian König
Signed-off-by: Daniel Vetter
---
drivers/gpu
The kernel doc explained what needs to happen, but not how to most
easily accomplish that using the functions. Fix that.
Cc: Boris Brezillon
Signed-off-by: Daniel Vetter
---
include/drm/drm_crtc.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/include/drm/drm_crtc.h b/in
I spotted a markup issue, plus adding the descriptions in drm_driver.
Plus a few more links while at it.
I'm still mildly unhappy with the split between fops and ioctls, but I
still think having the ioctls in the uapi chapter makes more sense. Oh
well ...
v2: Rebase.
Signed-off-by: Daniel Vetter
Only in the load failure path, where the hardware is quiet anyway.
Cc: Inki Dae
Cc: Joonyoung Shim
Cc: Seung-Woo Kim
Cc: Kyungmin Park
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/exynos/exynos_drm_drv.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/d
Almost right but still racy, it's called before the interrupts are
uninstalled. So let's just drop it.
Cc: Marek Vasut
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/mxsfb/mxsfb_drv.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
b/drivers/gpu/drm/mxsfb
Again seems just cargo-culted.
Cc: Yannick Fertre
Cc: Philippe Cornu
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/stm/ltdc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
index 700cc0800e51..1b9483d4f2a4 100644
--- a/drivers/gp
Seems entirely cargo-culted.
Cc: Benjamin Gaignard
Cc: Vincent Abriou
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/sti/sti_drv.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/sti/sti_drv.c b/drivers/gpu/drm/sti/sti_drv.c
index a4b574283269..06ef1e3886cf 100644
--- a/dr
On the load error path we can't have pending vblank interrupts, and on
unload we already call drm_atomic_helper_shutdown beforehand! So all
good to nuke it.
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/i915/i915_drv.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/d
Again seems just cargo-culted ... It's not ordered against any
irq/vblank/modeset shutdown.
Cc: Maxime Ripard
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/sun4i/sun4i_drv.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/sun4i/sun4i_drv.c
b/drivers/gpu/drm/sun4i/sun4i
It again looks all cargo-culted for no good reasons.
Cc: Shawn Guo
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/zte/zx_drm_drv.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/zte/zx_drm_drv.c b/drivers/gpu/drm/zte/zx_drm_drv.c
index 490aafc99610..696836303229 100644
-
There's no reason for drivers to call this, and all the ones I've
removed looked very fishy:
- Proper quiescenting of the vblank machinery should be done by
calling drm_crtc_vblank_off(), which is best done by shutting down
the entire display engine with drm_atomic_helper_shutdown.
- Releasing
On Wed, 24 May 2017 16:51:48 +0200
Daniel Vetter wrote:
> The kernel doc explained what needs to happen, but not how to most
> easily accomplish that using the functions. Fix that.
>
> Cc: Boris Brezillon
> Signed-off-by: Daniel Vetter
Reviewed-by: Boris Brezillon
> ---
> include/drm/drm_c
https://bugs.freedesktop.org/show_bug.cgi?id=99349
--- Comment #4 from Gert Wollny ---
The same problem also seems to be discussed in these mails
http://mesa-dev.freedesktop.narkive.com/cHAXj1eT/bug-50338-radeon-tgsi-takes-more-than-two-cfiles-from-r600-shader
It is very likely that this is ac
https://bugs.freedesktop.org/show_bug.cgi?id=96868
--- Comment #27 from Jonas ---
(In reply to Alex Deucher from comment #26)
> Created attachment 131453 [details] [review]
> possible fix 4/4
This time the issue seems to be completely fixed, at least for me. Even @144Hz
the screen works perfectl
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Adam Jackson (3):
Export drmDevicesEqual
configure: Fix the check
Fix stray caller of drmCompareDevices
Edward O'Callaghan (2):
amdgpu/: concisely && consistently check null ptrs in canonical form
amdgpu: Use the canoni
On Wed, May 24, 2017 at 04:51:35PM +0200, Daniel Vetter wrote:
> Hi all,
>
> So the first part of this patch series is the usual deal of decrufting some
> part
> of drm and attempting to improve the docs. Mostly around vblank. I seem to be
> the ever constant 5% of finally being able to document
1 - 100 of 153 matches
Mail list logo
