[PATCH] drm: Fix deadlock retry loop in page_flip_ioctl

2017-05-22 Thread Daniel Vetter
I failed to properly onion-wrap the unwind code: We acquire the vblank reference before we start with the wait-wound locking dance, hence we must make sure we retry before we drop the reference. Oops. Fixes: 29dc0d1de182 ("drm: Roll out acquire context for the page_flip ioctl") Cc: Harry Wentland

Re: (radeon?) WARNING: drivers/gpu/drm/drm_irq.c:1195 drm_vblank_put (v4.11-12441-g56868a4)

2017-05-22 Thread Daniel Vetter
On Thu, May 18, 2017 at 07:43:51PM +0300, Tommi Rantala wrote: > 2017-05-11 5:51 GMT+03:00 Michel Dänzer : > > On 11/05/17 04:33 AM, Tommi Rantala wrote: > >> Complete kernel log: > >> http://termbin.com/dzy5 > >> > >> [ 249.952546] [ cut here ] > >> [ 249.952593] WARNING:

Re: [PATCH v3 12/16] drm/stm: remove unneeded -Iinclude/drm compiler flag

2017-05-22 Thread Daniel Vetter
On Thu, May 18, 2017 at 01:29:49PM +0900, Masahiro Yamada wrote: > With the include directives under include/drm/ fixed, this flag is > no longer needed. > > Signed-off-by: Masahiro Yamada Ok, this and patch 1 applied, pls double-check I've done the right thing and it's all good now (well, once

Re: [PATCH] drm/amd: include instead of "linux/delay.h"

2017-05-22 Thread Daniel Vetter
On Thu, May 18, 2017 at 08:47:34AM +0200, Christian König wrote: > Am 18.05.2017 um 06:43 schrieb Masahiro Yamada: > > Use <...> notation to include headers located in include/linux. > > While we are here, tweak the includes order a bit to sort them > > alphabetically. > > > > Signed-off-by: Masah

Re: [PATCH 1/2] drm/atomic: Consitfy mode parameter to drm_atomic_set_mode_for_crtc()

2017-05-22 Thread Daniel Vetter
On Thu, May 18, 2017 at 10:38:36PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > drm_atomic_set_mode_for_crtc() doesn't modify the passed mode, so let's > make it const. > > Signed-off-by: Ville Syrjälä Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/drm_atomic.c

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Constify load detect mode

2017-05-22 Thread Daniel Vetter
On Thu, May 18, 2017 at 10:38:37PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Make the mode used for load detection const, and adjust all relevant > functions to accept a const mode. > > Signed-off-by: Ville Syrjälä Reviewed-by: Daniel Vetter > --- > drivers/gpu/d

Re: [PATCH v4 1/2] drm/blend: Fix comment typ-o

2017-05-22 Thread Daniel Vetter
On Fri, May 19, 2017 at 04:50:16PM -0400, Robert Foss wrote: > Fix DRM_REFELCT_Y -> DRM_REFLECT_Y. > > Signed-off-by: Robert Foss Applied, thanks. -Daniel > --- > drivers/gpu/drm/drm_blend.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_blend.c b

[Bug 100949] Power management problem on CIK/SI hybrid laptop

2017-05-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100949 --- Comment #3 from Michel Dänzer --- I'm seeing the same *ERROR* lines on suspend/resume on one of my laptops, and the laptop panel stays black. Does that match your problem, or what did you mean by "broke the handling of power management"? --

Re: [PATCH -next] drm/vgem: Fix return value check in vgem_init()

2017-05-22 Thread Daniel Vetter
On Sun, May 21, 2017 at 01:09:05PM +0100, Chris Wilson wrote: > On Sun, May 21, 2017 at 01:19:39AM +, Wei Yongjun wrote: > > From: Wei Yongjun > > > > In case of error, the function platform_device_register_simple() returns > > ERR_PTR() and never returns NULL. The NULL test in the return val

Re: [PATCH v4 2/2] drm: Add DRM_MODE_ROTATE_ and DRM_MODE_REFLECT_ to UAPI

2017-05-22 Thread Daniel Vetter
On Fri, May 19, 2017 at 04:50:17PM -0400, Robert Foss wrote: > Add DRM_MODE_ROTATE_ and DRM_MODE_REFLECT_ defines to the UAPI > as a convenience. > > Ideally the DRM_ROTATE_ and DRM_REFLECT_ property ids are looked up > through the atomic API, but realizing that userspace is likely to take > short

Re: [PATCH v4 03/10] drm: Use new mode_valid() helpers in connector probe helper

2017-05-22 Thread Daniel Vetter
On Fri, May 19, 2017 at 01:52:12AM +0100, Jose Abreu wrote: > This changes the connector probe helper function to use the new > encoder->mode_valid(), bridge->mode_valid() and crtc->mode_valid() > helper callbacks to validate the modes. > > The new callbacks are optional so the behaviour remains t

Re: [PATCH] drm/amd: include instead of "linux/delay.h"

2017-05-22 Thread Christian König
Am 22.05.2017 um 09:39 schrieb Daniel Vetter: On Thu, May 18, 2017 at 08:47:34AM +0200, Christian König wrote: Am 18.05.2017 um 06:43 schrieb Masahiro Yamada: Use <...> notation to include headers located in include/linux. While we are here, tweak the includes order a bit to sort them alphabeti

Re: [PATCH v4 00/10] Introduce new mode validation callbacks

2017-05-22 Thread Daniel Vetter
On Fri, May 19, 2017 at 01:52:09AM +0100, Jose Abreu wrote: > This series is a follow up from the discussion at [1]. We start by > introducing crtc->mode_valid(), encoder->mode_valid() and > bridge->mode_valid() callbacks which will be used in followup > patches and also by cleaning the documentati

Re: (radeon?) WARNING: drivers/gpu/drm/drm_irq.c:1195 drm_vblank_put (v4.11-12441-g56868a4)

2017-05-22 Thread Tommi Rantala
2017-05-22 10:32 GMT+03:00 Daniel Vetter : > Yeah I think the locking stuff we've fixed, at least if you don't see it > in 4.12 it should be all good. And I think I spotted the bug you've > bisected to, patch is on dri-devel, pls test. Thanks! I'll test it later today. -Tommi

Re: [PATCH] drm/amd: include instead of "linux/delay.h"

2017-05-22 Thread Daniel Vetter
On Mon, May 22, 2017 at 09:55:46AM +0200, Christian König wrote: > Am 22.05.2017 um 09:39 schrieb Daniel Vetter: > > On Thu, May 18, 2017 at 08:47:34AM +0200, Christian König wrote: > > > Am 18.05.2017 um 06:43 schrieb Masahiro Yamada: > > > > Use <...> notation to include headers located in includ

Re: [PATCH] drm/amd: include instead of "linux/delay.h"

2017-05-22 Thread Christian König
Am 22.05.2017 um 10:06 schrieb Daniel Vetter: On Mon, May 22, 2017 at 09:55:46AM +0200, Christian König wrote: Am 22.05.2017 um 09:39 schrieb Daniel Vetter: On Thu, May 18, 2017 at 08:47:34AM +0200, Christian König wrote: Am 18.05.2017 um 06:43 schrieb Masahiro Yamada: Use <...> notation to i

Re: drm: Primary display is recognized as secondary display

2017-05-22 Thread Chris Wilson
On Sat, May 20, 2017 at 10:02:32PM +0900, Hisao Tanabe wrote: > DELL 27-inch display is connected to ThinkPad 250 via DisplayPort cable, > and DELL 27-inch display is used as primary display. > > After upgrade kernel from 4.10 to 4.11, the DELL 27-inch display is now > recognized as a secondary di

[Bug 100400] Game Valhalla Hills crash on startup

2017-05-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100400 --- Comment #11 from Samuel Pitoiset --- Hi there, The crash at startup can no longer be reproduced. I have just tested with Mesa (4eb0411ed72) and LLVM (9031fd91990). Though, it still crashes with Mesa 17.1.0 and LLVM 4.0.0. Can you upgrade L

[Bug 100949] Power management problem on CIK/SI hybrid laptop

2017-05-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100949 --- Comment #4 from Luya Tshimbalanga --- > I'm seeing the same *ERROR* lines on suspend/resume on one of my laptops, and > the laptop panel stays black. Does that match your problem, or what did you > mean by "broke the handling of power mana

[Bug 100802] [regression] mostly blank graphics on Faeria

2017-05-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100802 --- Comment #6 from Samuel Pitoiset --- Same here, the trace replays fine with Mesa/LLVM from today on RX480. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel ma

[Bug 100949] Power management problem on CIK/SI hybrid laptop

2017-05-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100949 --- Comment #5 from Michel Dänzer --- And you're saying suspend/resume broke around May 2nd for you? Do you happen to remember a commit before that where it worked for you? -- You are receiving this mail because: You are the assignee for the b

[Bug 99859] Glamor Crashes on big endian Hardware

2017-05-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99859 --- Comment #20 from intermedi...@hotmail.com --- Thanks for the reply Michel, i hope will be fixed because all actual gpu are using SI and this made Linux unusable on BE host if a new machine (like is mine) . -- You are receiving this mail bec

Re: [PATCH] drm: Fix deadlock retry loop in page_flip_ioctl

2017-05-22 Thread Michel Dänzer
On 22/05/17 04:31 PM, Daniel Vetter wrote: > I failed to properly onion-wrap the unwind code: We acquire the vblank > reference before we start with the wait-wound locking dance, hence we > must make sure we retry before we drop the reference. Oops. > > Fixes: 29dc0d1de182 ("drm: Roll out acquire

Re: [PATCH v4 2/2] drm: Add DRM_MODE_ROTATE_ and DRM_MODE_REFLECT_ to UAPI

2017-05-22 Thread Daniel Vetter
On Mon, May 22, 2017 at 09:51:22AM +0200, Daniel Vetter wrote: > On Fri, May 19, 2017 at 04:50:17PM -0400, Robert Foss wrote: > > Add DRM_MODE_ROTATE_ and DRM_MODE_REFLECT_ defines to the UAPI > > as a convenience. > > > > Ideally the DRM_ROTATE_ and DRM_REFLECT_ property ids are looked up > > thr

Re: [PATCH v5] dma-buf/sync-file: Defer creation of sync_file->name

2017-05-22 Thread Chris Wilson
On Tue, May 16, 2017 at 12:10:42PM +0100, Chris Wilson wrote: > Constructing the name takes the majority of the time for allocating a > sync_file to wrap a fence, and the name is very rarely used (only via > the sync_file status user interface). To reduce the impact on the common > path (that of cr

[Bug 194761] amdgpu driver breaks on Oland (SI)

2017-05-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=194761 --- Comment #13 from Jean Delvare (jdelv...@suse.de) --- Assuming you mean "in comment #1", well no, they do not work for me. Have you tested? I naively trusted you, and as a result agreed not to get the problematic commit reverted upstream, and n

[Bug 194761] amdgpu driver breaks on Oland (SI)

2017-05-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=194761 --- Comment #14 from flora@amd.com --- I don't know why it fails on your side, at least it works with my test PC. anyway, you could revert it if this troubles you. -- You are receiving this mail because: You are watching the assignee of the

[Bug 101029] notebook does not work when not booted using nomodeset AMD APU

2017-05-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101029 --- Comment #25 from Julien Isorce --- Does the patch mentioned in comment 24 only allow '__queue_flush' to complete faster at boot time ? Or should we expect some performance gain after boot ? -- You are receiving this mail because: You are t

Re: [PATCH 1/3] drm/omap: Support for HDMI hot plug detection

2017-05-22 Thread Tomi Valkeinen
On 15/05/17 12:03, Peter Ujfalusi wrote: > The HPD signal can be used for detecting HDMI cable plug and unplug event > without the need for polling the status of the line. > This will speed up detecting such event because we do not need to wait for > the next poll event to notice the state change.

Re: [PATCH v2 5/5] drm: rcar-du: Map memory through the VSP device

2017-05-22 Thread Laurent Pinchart
Hi Kieran, On Monday 22 May 2017 13:16:11 Kieran Bingham wrote: > On 17/05/17 00:20, Laurent Pinchart wrote: > > For planes handled by a VSP instance, map the framebuffer memory through > > the VSP to ensure proper IOMMU handling. > > > > Signed-off-by: Laurent Pinchart > > > > Looks good excep

Re: [PATCH v1 2/3] dt-bindings: display: Add STM32 DSI host driver

2017-05-22 Thread Rob Herring
On Fri, May 19, 2017 at 11:25 AM, Philippe CORNU wrote: > > > On 05/18/2017 11:42 PM, Rob Herring wrote: >> On Fri, May 12, 2017 at 04:56:28PM +0200, Philippe CORNU wrote: >>> This patch adds documentation of device tree bindings for the STM32 >>> DSI host driver based on the Synopsys DW MIPI DSI

Re: [PATCH v2 5/5] drm: rcar-du: Map memory through the VSP device

2017-05-22 Thread Geert Uytterhoeven
On Mon, May 22, 2017 at 2:52 PM, Kieran Bingham wrote: > My only distaste there is having to then add the [i-1] index to the sg_tables. > > I have just experimented with: > > fail: > for (; i-- != 0;) { > struct sg_table *sgt = &rstate->sg_tables[i]; > ... >

Re: [PATCH v2 5/5] drm: rcar-du: Map memory through the VSP device

2017-05-22 Thread Laurent Pinchart
Hello Geert and Kieran, On Monday 22 May 2017 15:00:27 Geert Uytterhoeven wrote: > On Mon, May 22, 2017 at 2:52 PM, Kieran Bingham wrote: > > My only distaste there is having to then add the [i-1] index to the > > sg_tables. > > > > I have just experimented with: > > > > fail: > > for (;

Re: [PATCH v2 0/3] Cleanup evergreen/si IRQ handling code

2017-05-22 Thread Lyude Paul
On Sat, 2017-05-20 at 13:39 +0200, Christian König wrote: > Am 20.05.2017 um 01:48 schrieb Lyude: > > This is the first part of me going through and cleaning up the IRQ > > handling > > code for radeon, since after taking a look at it the other day > > while trying to > > debug something I realized

Re: [PATCH v3] drm: mxsfb_crtc: Reset the eLCDIF controller

2017-05-22 Thread Fabio Estevam
Hi Marek, On Fri, May 5, 2017 at 3:01 PM, Fabio Estevam wrote: > According to the eLCDIF initialization steps listed in the MX6SX > Reference Manual the eLCDIF block reset is mandatory. > > Without performing the eLCDIF reset the display shows garbage content > when the kernel boots. > > In earli

[Bug 99784] AMD 7470m When VGA plugged into laptop, only one monitor working at a time

2017-05-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99784 --- Comment #15 from lazane...@gmail.com --- Created attachment 131434 --> https://bugs.freedesktop.org/attachment.cgi?id=131434&action=edit Kernel oops at drm module (4.12.rc2 kernel) Just tested 4.12.rc2 kernel, and had another kernel oops in

Re: [PATCH] drm/radeon: Fix oops upon driver load on PowerXpress laptops

2017-05-22 Thread Lukas Wunner
On Sun, May 21, 2017 at 09:31:09AM +0200, Nicolai Stange wrote: > On Thu, May 18 2017, Lukas Wunner wrote: [snip] > > Reported-by: Nicolai Stange > > Fixes: 7ffb0ce31cf9 ("drm/radeon: Don't register Thunderbolt eGPU with > > vga_switcheroo") > > Signed-off-by: Lukas Wunner > > --- > > > > Awaiti

[PATCH] drm: Fix deadlock retry loop in page_flip_ioctl

2017-05-22 Thread Daniel Vetter
I failed to properly onion-wrap the unwind code: We acquire the vblank reference before we start with the wait-wound locking dance, hence we must make sure we retry before we drop the reference. Oops. v2: The vblank_put must be after the frambuffer_put (Michel). I suck at unwrapping code that does

[Bug 97882] [amdgpu SI] amdgpu on SI devices is much slower then radeon

2017-05-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97882 --- Comment #3 from Maxim Sheviakov --- Same here. Using Arch x86_64 with linux-ck 4.11.2 and mesa 17.1.0. AMDGPU's performance is about 60~70% of radeon's on MSI R7 370 Armor 2X. -- You are receiving this mail because: You are the assignee for

[Bug 97882] [amdgpu SI] amdgpu on SI devices is much slower then radeon

2017-05-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97882 --- Comment #4 from Maxim Sheviakov --- Created attachment 131435 --> https://bugs.freedesktop.org/attachment.cgi?id=131435&action=edit dmesg | egrep 'drm|amdgpu' -- You are receiving this mail because: You are the assignee for the bug.__

[Bug 93826] 2560x1440 @144Hz graphic glitches and bad refresh rate

2017-05-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93826 --- Comment #47 from Eike --- This problem also occurs on certain graphics & monitor driver combinations on Windows and is according to the linked thread a firmware problem of the Asus MG279Q. This almost only happens with GCN2 AMD cards. There

[Bug 93826] 2560x1440 @144Hz graphic glitches and bad refresh rate

2017-05-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93826 --- Comment #48 from Jonas --- I have an Asus MG278Q, which is the TN model, and the issue is not the same as explained in the thread you have linked. Under Archlinux what happens above 60Hz is a crazy flickering of almost all screen, which can b

[Bug 97882] [amdgpu SI] amdgpu on SI devices is much slower then radeon

2017-05-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97882 --- Comment #5 from Maxim Sheviakov --- Created attachment 131436 --> https://bugs.freedesktop.org/attachment.cgi?id=131436&action=edit dmesg | egrep 'drm|radeon' -- You are receiving this mail because: You are the assignee for the bug.__

[PATCH] drm/pl111: add ARM_AMBA dependency

2017-05-22 Thread Arnd Bergmann
The driver is written in a way to enable compile-testing without CONFIG_ARM_AMBA, but it just causes needless warnings: drivers/gpu/drm/pl111/pl111_drv.c:149:26: error: 'pl111_drm_driver' defined but not used [-Werror=unused-variable] drivers/gpu/drm/pl111/pl111_drv.c:81:12: error: 'pl111_modese

[Bug 97882] [amdgpu SI] amdgpu on SI devices is much slower then radeon

2017-05-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97882 --- Comment #6 from Trevor Davenport --- >From phoronix's data this appears to not happen on Tahiti chips. The 270x and 370 are always slower on amdgpu compared to radeon. See http://www.phoronix.com/scan.php?page=article&item=linux-411-gcn10&n

Re: [PATCH v4 00/10] Introduce new mode validation callbacks

2017-05-22 Thread Daniel Vetter
On Mon, May 22, 2017 at 09:56:00AM +0200, Daniel Vetter wrote: > On Fri, May 19, 2017 at 01:52:09AM +0100, Jose Abreu wrote: > > This series is a follow up from the discussion at [1]. We start by > > introducing crtc->mode_valid(), encoder->mode_valid() and > > bridge->mode_valid() callbacks which

[Bug 100949] Power management problem on CIK/SI hybrid laptop

2017-05-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100949 --- Comment #6 from Luya Tshimbalanga --- Last commit that worked prior to the breakage was on 20170410. I just updated to the recent 20170511 which seems partially resolving the issue but the error message below still remains. [22328.935171] [

Re: [PATCH libdrm] Android's major/minor/makedev live in

2017-05-22 Thread Emil Velikov
On 20 May 2017 at 19:24, enh wrote: > Bug: https://github.com/android-ndk/ndk/issues/398 > --- > Android.common.mk | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Android.common.mk b/Android.common.mk > index 35c0f02c..b45ca10f 100644 > --- a/Android.common.mk > +++ b/Android.common.mk >

Re: [PATCH v4 2/2] drm: Add DRM_MODE_ROTATE_ and DRM_MODE_REFLECT_ to UAPI

2017-05-22 Thread Ville Syrjälä
On Fri, May 19, 2017 at 04:50:17PM -0400, Robert Foss wrote: > Add DRM_MODE_ROTATE_ and DRM_MODE_REFLECT_ defines to the UAPI > as a convenience. > > Ideally the DRM_ROTATE_ and DRM_REFLECT_ property ids are looked up > through the atomic API, but realizing that userspace is likely to take > short

[Bug 93826] 2560x1440 @144Hz graphic glitches and bad refresh rate

2017-05-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93826 --- Comment #49 from Rodhos --- My monitor is Samsung SyncMaster 2032BW. It happens after Ubuntu changing the default drivers. -- You are receiving this mail because: You are the assignee for the bug.

Re: [PATCH] drm/pl111: add ARM_AMBA dependency

2017-05-22 Thread Eric Anholt
Arnd Bergmann writes: > The driver is written in a way to enable compile-testing without > CONFIG_ARM_AMBA, > but it just causes needless warnings: > > drivers/gpu/drm/pl111/pl111_drv.c:149:26: error: 'pl111_drm_driver' defined > but not used [-Werror=unused-variable] > drivers/gpu/drm/pl111/pl

[Bug 101145] Wine game needs GLSL override for fullscreen

2017-05-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101145 Bug ID: 101145 Summary: Wine game needs GLSL override for fullscreen Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Seve

[Bug 101145] Wine game needs GLSL override for fullscreen

2017-05-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101145 --- Comment #1 from wyrex --- Created attachment 131438 --> https://bugs.freedesktop.org/attachment.cgi?id=131438&action=edit without override -- You are receiving this mail because: You are the assignee for the bug._

[Bug 101145] Wine game needs GLSL override for fullscreen

2017-05-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101145 --- Comment #2 from wyrex --- Created attachment 131439 --> https://bugs.freedesktop.org/attachment.cgi?id=131439&action=edit log with override -- You are receiving this mail because: You are the assignee for the bug.

Re: [PATCH v3] drm: mxsfb_crtc: Reset the eLCDIF controller

2017-05-22 Thread Fabio Estevam
Hi Marek, On Mon, May 22, 2017 at 11:20 AM, Marek Vasut wrote: > IMO it's OK. > > Reviewed-by: Marek Vasut Thanks for the feedback. Do you plan to send Dave a pull request so that this one can reach 4.12-rc? Thanks ___ dri-devel mailing list dri-de

Re: [PATCH] drm: Fix deadlock retry loop in page_flip_ioctl

2017-05-22 Thread Tommi Rantala
2017-05-22 16:59 GMT+03:00 Daniel Vetter : > I failed to properly onion-wrap the unwind code: We acquire the vblank > reference before we start with the wait-wound locking dance, hence we > must make sure we retry before we drop the reference. Oops. > > v2: The vblank_put must be after the frambuff

[Bug 195743] Screen flicker and instability on hdmi monitors with AMDGPU, EDID problems

2017-05-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=195743 keziolio...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [PATCH] drm/radeon: Fix oops upon driver load on PowerXpress laptops

2017-05-22 Thread Daniel Vetter
On Thu, May 18, 2017 at 09:33:44PM +0200, Lukas Wunner wrote: > Nicolai Stange reports the following oops which is caused by > dereferencing rdev->pdev before it's subsequently set by > radeon_device_init(). Fix it. > > BUG: unable to handle kernel NULL pointer dereference at 07cb >

Re: [PATCH v5] dma-buf/sync-file: Defer creation of sync_file->name

2017-05-22 Thread Daniel Vetter
On Tue, May 16, 2017 at 12:10:42PM +0100, Chris Wilson wrote: > Constructing the name takes the majority of the time for allocating a > sync_file to wrap a fence, and the name is very rarely used (only via > the sync_file status user interface). To reduce the impact on the common > path (that of cr

Re: [PATCH] drm/radeon: Fix oops upon driver load on PowerXpress laptops

2017-05-22 Thread Sean Paul
On Mon, May 22, 2017 at 04:04:07PM +0200, Lukas Wunner wrote: > On Sun, May 21, 2017 at 09:31:09AM +0200, Nicolai Stange wrote: > > On Thu, May 18 2017, Lukas Wunner wrote: > [snip] > > > Reported-by: Nicolai Stange > > > Fixes: 7ffb0ce31cf9 ("drm/radeon: Don't register Thunderbolt eGPU with > >

[PATCH] gpu: drm: gma500: remove two more dead variable

2017-05-22 Thread Arnd Bergmann
The dead code removal left two unused variables: drivers/gpu/drm/gma500/mdfld_tpo_vid.c: In function 'tpo_vid_get_config_mode': drivers/gpu/drm/gma500/mdfld_tpo_vid.c:34:31: error: unused variable 'ti' [-Werror=unused-variable] This removes them as well. Fixes: 94d7fb4982d2 ("gpu: drm: gma500:

Re: [PATCH 2/4] dt-bindings: Document the Raspberry Pi Touchscreen nodes.

2017-05-22 Thread Eric Anholt
Laurent Pinchart writes: > Hi Eric, > > On Tuesday 16 May 2017 11:46:36 Eric Anholt wrote: > > [snip] > >> In terms of physical connections: >> >>[15-pin "DSI" connector on 2835] >> >> | I2C | DSI >>/ \SPI | >> [TS] [Atmel]--[TC358762] >>\

Re: [PATCH 2/4] dt-bindings: Document the Raspberry Pi Touchscreen nodes.

2017-05-22 Thread Eric Anholt
Laurent Pinchart writes: > Hi Archit, > > On Friday 19 May 2017 14:24:36 Archit Taneja wrote: >> On 05/18/2017 08:25 PM, Laurent Pinchart wrote: >> > On Thursday 18 May 2017 13:56:19 Archit Taneja wrote: >> >> On 05/17/2017 12:16 AM, Eric Anholt wrote: >> > >> > [snip] >> > >> >>> In terms of ph

[PATCH RESEND] drm: mxsfb_crtc: Reset the eLCDIF controller

2017-05-22 Thread Fabio Estevam
From: Fabio Estevam According to the eLCDIF initialization steps listed in the MX6SX Reference Manual the eLCDIF block reset is mandatory. Without performing the eLCDIF reset the display shows garbage content when the kernel boots. In earlier tests this issue has not been observed because the

[Bug 194761] amdgpu driver breaks on Oland (SI)

2017-05-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=194761 --- Comment #15 from Jean Delvare (jdelv...@suse.de) --- And it's not just me, see: https://bugzilla.opensuse.org/show_bug.cgi?id=1039806 -- You are receiving this mail because: You are watching the assignee of the bug.

Re: [PATCH] drm/pl111: add ARM_AMBA dependency

2017-05-22 Thread Arnd Bergmann
On Mon, May 22, 2017 at 6:32 PM, Krzysztof Kozlowski wrote: > On Mon, May 22, 2017 at 05:20:08PM +0200, Arnd Bergmann wrote: >> The driver is written in a way to enable compile-testing without >> CONFIG_ARM_AMBA, >> but it just causes needless warnings: >> >> drivers/gpu/drm/pl111/pl111_drv.c:149

Re: [PATCH] drm/pl111: add ARM_AMBA dependency

2017-05-22 Thread Arnd Bergmann
On Mon, May 22, 2017 at 6:23 PM, Eric Anholt wrote: > Arnd Bergmann writes: > >> The driver is written in a way to enable compile-testing without >> CONFIG_ARM_AMBA, >> but it just causes needless warnings: >> >> drivers/gpu/drm/pl111/pl111_drv.c:149:26: error: 'pl111_drm_driver' defined >> but

[Bug 100437] IO_PAGE_FAULT is spammed in dmesg

2017-05-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100437 --- Comment #9 from Greg Turner --- Just another datapoint on this... I have this disease with a (non-reference) Asus RX480 in an Asus Sabertooth Gen3 R2.0 (or something like that, I can never remember exactly what it's called). It does not fi

Re: [PATCH] drm/pl111: add ARM_AMBA dependency

2017-05-22 Thread Eric Anholt
Arnd Bergmann writes: > On Mon, May 22, 2017 at 6:23 PM, Eric Anholt wrote: >> Arnd Bergmann writes: >> >>> The driver is written in a way to enable compile-testing without >>> CONFIG_ARM_AMBA, >>> but it just causes needless warnings: >>> >>> drivers/gpu/drm/pl111/pl111_drv.c:149:26: error: '

Re: [PATCH -next] drm/pl111: Fix return value check in pl111_amba_probe()

2017-05-22 Thread Eric Anholt
Wei Yongjun writes: > From: Wei Yongjun > > In case of error, the function devm_ioremap_resource() returns ERR_PTR() > and never returns NULL. The NULL test in the return value check should > be replaced with IS_ERR(). > > Fixes: bed41005e617 ("drm/pl111: Initial drm/kms driver for pl111") > Sig

Re: [PATCH] gpu: drm: nouveau: add null check before pointer dereference

2017-05-22 Thread Ben Skeggs
On 05/23/2017 05:12 AM, Gustavo A. R. Silva wrote: Add null check before dereferencing pointer asyc I've taken the patch into my tree, thanks! Ben. Addresses-Coverity-ID: 1397932 Signed-off-by: Gustavo A. R. Silva --- drivers/gpu/drm/nouveau/nv50_display.c | 3 ++- 1 file changed, 2 inse

Re: [PATCH v2] gpu: drm: gma500: remove dead code

2017-05-22 Thread Patrik Jakobsson
On Fri, May 19, 2017 at 2:28 PM, Patrik Jakobsson wrote: > On Fri, May 19, 2017 at 11:19 AM, Gustavo A. R. Silva > wrote: >> Local variable use_gct is assigned to a constant value and it is never >> updated again. Remove this variable and the dead code it guards. >> >> Addresses-Coverity-ID: 1456

Re: [PATCH] gpu: drm: gma500: remove two more dead variable

2017-05-22 Thread Patrik Jakobsson
On Mon, May 22, 2017 at 10:30 PM, Arnd Bergmann wrote: > The dead code removal left two unused variables: > > drivers/gpu/drm/gma500/mdfld_tpo_vid.c: In function 'tpo_vid_get_config_mode': > drivers/gpu/drm/gma500/mdfld_tpo_vid.c:34:31: error: unused variable 'ti' > [-Werror=unused-variable] > >

Re: [PATCH 03/22] drm/tegra: Check whether page belongs to BO in tegra_bo_kmap()

2017-05-22 Thread Erik Faye-Lund
On Tue, May 23, 2017 at 2:14 AM, Dmitry Osipenko wrote: > This fixes an OOPS in case of out-of-bounds accessing of a kmap'ed cmdbuf > (non-IOMMU allocation) while patching the relocations in do_relocs(). > > Signed-off-by: Dmitry Osipenko > --- > drivers/gpu/drm/tegra/gem.c | 3 +++ > 1 file cha

Re: [PATCH 12/22] gpu: host1x: Correct host1x_job_pin() error handling

2017-05-22 Thread Erik Faye-Lund
On Tue, May 23, 2017 at 2:14 AM, Dmitry Osipenko wrote: > In case of relocations / waitchecks patching failure the jobs pins stay > referenced till DRM file get closed, wasting memory. Add the missed > unpinning. > > Signed-off-by: Dmitry Osipenko > --- > drivers/gpu/host1x/job.c | 16 +++---

Re: [PATCH v3 19/21] drm/sun4i: Add compatible for the A10s pipeline

2017-05-22 Thread Rob Herring
On Wed, May 17, 2017 at 09:40:48AM +0200, Maxime Ripard wrote: > The A10s has a slightly different display pipeline than the A13, with an > HDMI controller. > > Add a compatible for it. > > Signed-off-by: Maxime Ripard > --- > Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt | 1 +

Re: [PATCH 14/22] gpu: host1x: Forbid relocation address shifting in the firewall

2017-05-22 Thread Erik Faye-Lund
On Tue, May 23, 2017 at 2:14 AM, Dmitry Osipenko wrote: > Incorrectly shifted relocation address will cause a lower memory corruption > and likely a hang on a write or a read of an arbitrary data in case of IOMMU > absent. As of now there is no use for the address shifting (at least on > Tegra20)

Re: [PATCH 16/22] gpu: host1x: Forbid unrelated SETCLASS opcode in the firewall

2017-05-22 Thread Erik Faye-Lund
On Tue, May 23, 2017 at 2:14 AM, Dmitry Osipenko wrote: > Several channels could be made to write the same unit concurrently via the > SETCLASS opcode, trusting userspace is a bad idea. It should be possible to > drop the per-client channel reservation and add a per-unit locking by > inserting MLO

Re: [PATCH 18/22] gpu: host1x: Remove unused 'struct host1x_cmdbuf'

2017-05-22 Thread Erik Faye-Lund
On Tue, May 23, 2017 at 2:14 AM, Dmitry Osipenko wrote: > The struct host1x_cmdbuf is unused, let's remove it. > > Signed-off-by: Dmitry Osipenko > --- > drivers/gpu/host1x/job.h | 7 --- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/gpu/host1x/job.h b/drivers/gpu/host1x/job.h >

Re: [PATCH 19/22] gpu: host1x: Remove unused host1x_cdma_stop() definition

2017-05-22 Thread Erik Faye-Lund
On Tue, May 23, 2017 at 2:14 AM, Dmitry Osipenko wrote: > There is no host1x_cdma_stop() in the code, let's remove its definition > from the header file. > > Signed-off-by: Dmitry Osipenko > --- > drivers/gpu/host1x/cdma.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/host1

[PATCH] drm/stm: ltdc: fix duplicated arguments

2017-05-22 Thread Philippe CORNU
Fix COMPILE_TEST build issue detected with the rule: "duplicated argument to & or |" Signed-off-by: Philippe CORNU --- drivers/gpu/drm/stm/ltdc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c index a40418c..700cc08 100

[PATCH 01/22] drm/tegra: Fix lockup on a use of staging API

2017-05-22 Thread Dmitry Osipenko
Commit bdd2f9cd ("Don't leak kernel pointer to userspace") added a mutex around staging IOCTL's, some of those mutexes are taken twice. Fixes: bdd2f9cd10eb ("drm/tegra: Don't leak kernel pointer to userspace") Signed-off-by: Dmitry Osipenko Reviewed-by: Mikko Perttunen --- drivers/gpu/drm/tegra

Re: drm: Primary display is recognized as secondary display

2017-05-22 Thread Hisao Tanabe
On Mon, May 22, 2017 at 09:22:03AM +0100, Chris Wilson wrote: > On Sat, May 20, 2017 at 10:02:32PM +0900, Hisao Tanabe wrote: > > DELL 27-inch display is connected to ThinkPad 250 via DisplayPort cable, > > and DELL 27-inch display is used as primary display. > > > > After upgrade kernel from 4.10

Re: [linux-sunxi] Re: [RFC PATCH 07/11] drm: sun4i: add support for the TV encoder in H3 SoC

2017-05-22 Thread Jernej Škrabec
Hi, Dne sobota, 20. maj 2017 ob 03:37:53 CEST je Chen-Yu Tsai napisal(a): > On Sat, May 20, 2017 at 2:23 AM, Jernej Škrabec wrote: > > Hi, > > > > Dne petek, 19. maj 2017 ob 20:08:18 CEST je Icenowy Zheng napisal(a): > >> 于 2017年5月20日 GMT+08:00 上午2:03:30, Maxime Ripard > > > electrons.com> 写到

[PATCH 06/22] drm/tegra: Check syncpoint ID in the 'submit' IOCTL

2017-05-22 Thread Dmitry Osipenko
In case of invalid syncpoint ID, the host1x_syncpt_get() returns NULL and none of its users perform a check of the returned pointer later. Let's bail out until it's too late. Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/tegra/drm.c | 9 + 1 file changed, 9 insertions(+) diff --git

Re: [PATCH v2 5/5] drm: rcar-du: Map memory through the VSP device

2017-05-22 Thread Kieran Bingham
Hi Laurent, Thankyou for the patch. On 17/05/17 00:20, Laurent Pinchart wrote: > For planes handled by a VSP instance, map the framebuffer memory through > the VSP to ensure proper IOMMU handling. > > Signed-off-by: Laurent Pinchart Looks good except for a small unsigned int comparison causing

Re: [PATCH v2 3/5] v4l: vsp1: Map the DL and video buffers through the proper bus master

2017-05-22 Thread Kieran Bingham
Hi Laurent, Thanks for the patch: On 17/05/17 00:20, Laurent Pinchart wrote: > From: Magnus Damm > > On Gen2 hardware the VSP1 is a bus master and accesses the display list > and video buffers through DMA directly. On Gen3 hardware, however, > memory accesses go through a separate IP core calle

Re: [PATCH v3] drm: mxsfb_crtc: Reset the eLCDIF controller

2017-05-22 Thread Marek Vasut
On 05/22/2017 03:55 PM, Fabio Estevam wrote: > Hi Marek, > > On Fri, May 5, 2017 at 3:01 PM, Fabio Estevam wrote: >> According to the eLCDIF initialization steps listed in the MX6SX >> Reference Manual the eLCDIF block reset is mandatory. >> >> Without performing the eLCDIF reset the display show

Re: [PATCH v2 5/5] drm: rcar-du: Map memory through the VSP device

2017-05-22 Thread Kieran Bingham
On 22/05/17 14:23, Laurent Pinchart wrote: > Hello Geert and Kieran, > > On Monday 22 May 2017 15:00:27 Geert Uytterhoeven wrote: >> On Mon, May 22, 2017 at 2:52 PM, Kieran Bingham wrote: >>> My only distaste there is having to then add the [i-1] index to the >>> sg_tables. >>> >>> I have just exp

Re: [PATCH v3 12/16] drm/stm: remove unneeded -Iinclude/drm compiler flag

2017-05-22 Thread Masahiro Yamada
Hi Daniel, 2017-05-22 16:37 GMT+09:00 Daniel Vetter : > On Thu, May 18, 2017 at 01:29:49PM +0900, Masahiro Yamada wrote: >> With the include directives under include/drm/ fixed, this flag is >> no longer needed. >> >> Signed-off-by: Masahiro Yamada > > Ok, this and patch 1 applied, pls double-che

[PATCH 00/22] Tegra DRM fixes

2017-05-22 Thread Dmitry Osipenko
Hello, I have already sent some of the patches contained in this series and some of them got reviews. Later I added couple more patches and the dependencies started to form, so please ignore all the patches I sent before this series. The patches without r-b signatures require a review. Dmitry Osi

[PATCH v3 2/5] v4l: rcar-fcp: Add an API to retrieve the FCP device

2017-05-22 Thread Kieran Bingham
From: Laurent Pinchart The new rcar_fcp_get_device() function retrieves the struct device related to the FCP device. This is useful to handle DMA mapping through the right device. Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham Signed-off-by: Kieran Bingham --- drivers/media/plat

[PATCH 03/22] drm/tegra: Check whether page belongs to BO in tegra_bo_kmap()

2017-05-22 Thread Dmitry Osipenko
This fixes an OOPS in case of out-of-bounds accessing of a kmap'ed cmdbuf (non-IOMMU allocation) while patching the relocations in do_relocs(). Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/tegra/gem.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/tegra/gem.c b/driv

[PATCH 18/22] gpu: host1x: Remove unused 'struct host1x_cmdbuf'

2017-05-22 Thread Dmitry Osipenko
The struct host1x_cmdbuf is unused, let's remove it. Signed-off-by: Dmitry Osipenko --- drivers/gpu/host1x/job.h | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/gpu/host1x/job.h b/drivers/gpu/host1x/job.h index 0debd93a1849..4bda51d503ec 100644 --- a/drivers/gpu/host1x/job.h ++

Re: drm: Primary display is recognized as secondary display

2017-05-22 Thread Hisao Tanabe
On Mon, May 22, 2017 at 09:22:03AM +0100, Chris Wilson wrote: > On Sat, May 20, 2017 at 10:02:32PM +0900, Hisao Tanabe wrote: > > DELL 27-inch display is connected to ThinkPad 250 via DisplayPort cable, > > and DELL 27-inch display is used as primary display. > > > > After upgrade kernel from 4.10

Re: [PATCH v2 4/5] v4l: vsp1: Add API to map and unmap DRM buffers through the VSP

2017-05-22 Thread Kieran Bingham
Hi Laurent, On 17/05/17 00:20, Laurent Pinchart wrote: > The display buffers must be mapped for DMA through the device that > performs memory access. Expose an API to map and unmap memory through > the VSP device to be used by the DU. > > As all the buffers allocated by the DU driver are coherent

Re: [PATCH v2 1/5] v4l: rcar-fcp: Don't get/put module reference

2017-05-22 Thread Kieran Bingham
Hi Laurent, Thanks for the patch: On 17/05/17 00:20, Laurent Pinchart wrote: > Direct callers of the FCP API hold a reference to the FCP module due to > module linkage, there's no need to take another one manually. Take a > reference to the device instead to ensure that it won't disappear behind

[PATCH 20/22] gpu: host1x: Refactor channel allocation code

2017-05-22 Thread Dmitry Osipenko
From: Mikko Perttunen This is largely a rewrite of the Host1x channel allocation code, bringing several changes: - The previous code could deadlock due to an interaction between the 'reflock' mutex and CDMA timeout handling. This gets rid of the mutex. - Support for more than 32 channels, re

Re: [PATCH v2 2/5] v4l: rcar-fcp: Add an API to retrieve the FCP device

2017-05-22 Thread Kieran Bingham
Hi Laurent, Thankyou for the patch: On 17/05/17 00:20, Laurent Pinchart wrote: > The new rcar_fcp_get_device() function retrieves the struct device > related to the FCP device. This is useful to handle DMA mapping through > the right device. > > Signed-off-by: Laurent Pinchart Reviewed-by: Kie

[PATCH 14/22] gpu: host1x: Forbid relocation address shifting in the firewall

2017-05-22 Thread Dmitry Osipenko
Incorrectly shifted relocation address will cause a lower memory corruption and likely a hang on a write or a read of an arbitrary data in case of IOMMU absent. As of now there is no use for the address shifting (at least on Tegra20) and adding a proper shifting / sizes validation is much more work

  1   2   >