Re: [PATCH v3 1/6] drm: Add crtc/encoder/bridge->mode_valid() callbacks

2017-05-12 Thread Daniel Vetter
On Thu, May 11, 2017 at 10:05:57AM +0100, Jose Abreu wrote: > This adds a new callback to crtc, encoder and bridge helper functions > called mode_valid(). This callback shall be implemented if the > corresponding component has some sort of restriction in the modes > that can be displayed. A NULL ca

Re: [PATCH] drm/radeon: Unbreak HPD handling for r600+

2017-05-12 Thread Christian König
Am 12.05.2017 um 01:31 schrieb Lyude: We end up reading the interrupt register for HPD5, and then writing it to HPD6 which on systems without anything using HPD5 results in permanently disabling hotplug on one of the display outputs after the first time we acknowledge a hotplug interrupt from the

Re: [PATCH v2 00/29] Remove the omapdrm and omapdss devices from platform code

2017-05-12 Thread Tomi Valkeinen
On 11/05/17 17:16, Tony Lindgren wrote: >> pinctrl-single doesn't allow to freely set the bits, but requires the >> pins to have similar bit structure (function-mask). In CONTROL_DSIPHY, >> DSI1 and DSI2 have different bit structures. > > OK if the register mixes different types of controllers th

[PATCH] drm: Add crtc/encoder/bridge->mode_valid() callbacks

2017-05-12 Thread Daniel Vetter
From: Jose Abreu This adds a new callback to crtc, encoder and bridge helper functions called mode_valid(). This callback shall be implemented if the corresponding component has some sort of restriction in the modes that can be displayed. A NULL callback implicates that the component can display

Re: [PATCH v3 0/6] Introduce new mode validation callbacks

2017-05-12 Thread Daniel Vetter
On Thu, May 11, 2017 at 10:05:56AM +0100, Jose Abreu wrote: > This series is a follow up from the discussion at [1]. We start by > introducing crtc->mode_valid(), encoder->mode_valid() and > bridge->mode_valid() callbacks which will be used in followup > patches and also by cleaning the documentati

Re: [PATCH v2 1/7] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.

2017-05-12 Thread Boris Brezillon
On Thu, 11 May 2017 11:31:22 -0700 Eric Anholt wrote: > Many DRM drivers have common code to make a stub connector > implementation that wraps a drm_panel. By wrapping the panel in a DRM > bridge, all of the connector code (including calls during encoder > enable/disable) goes away. > > v2: Fix

Re: [PATCH v2 7/7] drm/atmel-hlcdc: Replace the panel usage with drm_panel_bridge.

2017-05-12 Thread Daniel Vetter
On Thu, May 11, 2017 at 09:15:23PM +0200, Boris Brezillon wrote: > Hi Eric, > > On Thu, 11 May 2017 11:31:28 -0700 > Eric Anholt wrote: > > > This cuts 135 lines of boilerplate, at the cost of losing the > > filtering of get_modes() using atmel_hlcdc_dc_mode_valid(). The > > atomic check will s

Re: [PATCH 1/8] drm/exynos: use drm_for_each_connector_iter()

2017-05-12 Thread Daniel Vetter
On Thu, May 11, 2017 at 04:10:42PM -0300, Gustavo Padovan wrote: > From: Gustavo Padovan > > Drop legacy drm_for_each_connector() in favor of the race-free > drm_for_each_connector_iter() > > Cc: Inki Dae > Cc: Joonyoung Shim > Signed-off-by: Gustavo Padovan > > --- > only built-tested! > --

Re: [PATCH 2/8] drm/rockchip: use drm_for_each_connector_iter()

2017-05-12 Thread Daniel Vetter
On Thu, May 11, 2017 at 04:10:43PM -0300, Gustavo Padovan wrote: > From: Gustavo Padovan > > Drop legacy drm_for_each_connector() in favor of the race-free > drm_for_each_connector_iter() > > Cc: Mark Yao > Signed-off-by: Gustavo Padovan > > --- > only built-tested! Reviewed-by: Daniel Vette

Re: [PATCH 3/8] drm/i915: use drm_for_each_connector_iter()

2017-05-12 Thread Daniel Vetter
On Thu, May 11, 2017 at 04:10:44PM -0300, Gustavo Padovan wrote: > From: Gustavo Padovan > > Drop legacy drm_for_each_connector() in favor of the race-free > drm_for_each_connector_iter(). > > Cc: Daniel Vetter > Cc: Jani Nikula > Signed-off-by: Gustavo Padovan > --- > drivers/gpu/drm/i915/i

Re: [PATCH 4/8] drm/mediatek: use drm_for_each_connector_iter()

2017-05-12 Thread Daniel Vetter
On Thu, May 11, 2017 at 04:10:45PM -0300, Gustavo Padovan wrote: > From: Gustavo Padovan > > Drop legacy drm_for_each_connector() in favor of the race-free > drm_for_each_connector_iter(). > > Cc: Philipp Zabel > Signed-off-by: Gustavo Padovan > > --- > only built-tested! > --- > drivers/gpu

Re: [PATCH 5/8] drm/nouveau: use drm_for_each_connector_iter()

2017-05-12 Thread Daniel Vetter
On Thu, May 11, 2017 at 04:10:46PM -0300, Gustavo Padovan wrote: > From: Gustavo Padovan > > Drop legacy drm_for_each_connector() in favor of the race-free > drm_for_each_connector_iter(). > > Cc: Ben Skeggs > Signed-off-by: Gustavo Padovan > > --- > only built-tested! > --- > drivers/gpu/dr

Re: [PATCH 6/8] drm/vc4: use drm_for_each_connector_iter()

2017-05-12 Thread Daniel Vetter
On Thu, May 11, 2017 at 04:10:47PM -0300, Gustavo Padovan wrote: > From: Gustavo Padovan > > Drop legacy drm_for_each_connector() in favor of the race-free > drm_for_each_connector_iter(). > > Cc: Eric Anholt > Signed-off-by: Gustavo Padovan > > --- > only built-tested! > --- > drivers/gpu/d

Re: [PATCH 7/8] drm: remove unsafe drm_for_each_connector()

2017-05-12 Thread Daniel Vetter
On Thu, May 11, 2017 at 04:10:48PM -0300, Gustavo Padovan wrote: > From: Gustavo Padovan > > After converting all users to drm_for_each_connector_iter() we no > longer need drm_for_each_connector() so we can go ahead and remove it. > > Signed-off-by: Gustavo Padovan Reviewed-by: Daniel Vetter

Re: [PATCH 8/8] drm: todo: remove task about switch to drm_connector_list_iter

2017-05-12 Thread Daniel Vetter
On Thu, May 11, 2017 at 04:10:49PM -0300, Gustavo Padovan wrote: > From: Gustavo Padovan > > This is now completed. > > Signed-off-by: Gustavo Padovan Reviewed-by: Daniel Vetter > --- > Documentation/gpu/todo.rst | 13 - > 1 file changed, 13 deletions(-) > > diff --git a/Docume

Re: [PATCH 0/8] remove unsafe drm_for_each_connector()

2017-05-12 Thread Daniel Vetter
On Thu, May 11, 2017 at 04:10:41PM -0300, Gustavo Padovan wrote: > From: Gustavo Padovan > > Hi all, > > Something ligth in the middle of all my other tasks. I removed > drm_for_each_connector() in favor of drm_for_each_connector_iter(). > > The i915 patch was tested, but I only *built-tested*

Re: [Intel-gfx] [PATCH 1/2] drm/dp: start a DPCD based DP sink/branch device quirk database

2017-05-12 Thread Jani Nikula
On Thu, 11 May 2017, Daniel Vetter wrote: > On Thu, May 11, 2017 at 12:57:20PM +0300, Jani Nikula wrote: >> Face the fact, there are Display Port sink and branch devices out there >> in the wild that don't follow the Display Port specifications, or they >> have bugs, or just otherwise require spec

Re: [PATCH 1/4] drm/vc4: Adjust modes in DSI to work around the integer PLL divider.

2017-05-12 Thread Daniel Vetter
On Thu, May 11, 2017 at 04:56:22PM -0700, Eric Anholt wrote: > BCM2835's PLLD_DSI1 divider doesn't give us many choices for our pixel > clocks, so to support panels on the Raspberry Pi we need to set a > higher pixel clock rate than requested and adjust the mode we program > to extend out the HFP s

Re: [PATCH 3/5] drm/syncobj: add sync_file interaction.

2017-05-12 Thread Daniel Vetter
On Fri, May 12, 2017 at 10:34:55AM +1000, Dave Airlie wrote: > From: Dave Airlie > > This interface allows importing the fence from a sync_file into > an existing drm sync object, or exporting the fence attached to > an existing drm sync object into a new sync file object. > > This should only b

Re: [PATCH v2 2/7] drm/vc4: Switch DSI to the panel-bridge layer, and support bridges.

2017-05-12 Thread Boris Brezillon
On Thu, 11 May 2017 11:31:23 -0700 Eric Anholt wrote: > The newer version of the RPi panel driver is going to be a combination > of a bridge and a panel, but we should also support panels without a > bridge, so the panel-bridge layer lets us do that cleanly. > > v2: Drop "dev" argument. > > Sig

Re: [PATCH v2 3/7] drm/vc4: Switch DPI to using the panel-bridge helper.

2017-05-12 Thread Boris Brezillon
On Thu, 11 May 2017 11:31:24 -0700 Eric Anholt wrote: > Another 100 lines of boilerplate gone, while allowing for bridges to > be connected in the display chain. > > Signed-off-by: Eric Anholt Reviewed-by: Boris Brezillon > --- > drivers/gpu/drm/vc4/vc4_dpi.c | 164 > --

Re: [PATCH v2 4/7] drm/mediatek: Use the panel-bridge helper.

2017-05-12 Thread Boris Brezillon
On Thu, 11 May 2017 11:31:25 -0700 Eric Anholt wrote: > Avoids a bunch of connector boilerplate. Note that this causes panel > prepare() to be moved before mtk_dsi_poweron() and unprepare() to be > after poweroff(). I think this is the expected usage of the panel API > (enable should be when yo

[PATCH 1/3] mdacon: align code in mda_detect properly

2017-05-12 Thread Jiri Slaby
This is just a whitespace cleanup. The code was a mess having multiple commands on one line like: scr_writew(0xAA55, p); if (scr_readw(p) == 0xAA55) count++; Indent that properly and make it nicer for reading. Signed-off-by: Jiri Slaby Cc: Tomi Valkeinen Cc: --- drivers/video/console/mdacon.c

[PATCH 2/3] mdacon: make mda_vram_base u16 *

2017-05-12 Thread Jiri Slaby
Given every user of mda_vram_base expects a pointer, let mda_vram_base be a pointer to u16. The offset calculation in mda_detect had to be adjusted by / 2 (due to different pointer arithmetic now). We introduce a cast to a value returned from VGA_MAP_MEM. But I will change VGA_MAP_MEM to return a

[PATCH 3/3] mdacon: replace MDA_ADDR macro by inline function

2017-05-12 Thread Jiri Slaby
MDA_ADDR is one of those macros which could be an inline function. So convert MDA_ADDR to mda_addr. Note that we take x and y as unsigned now. But they are absolute coordinates, so this is no problem. Signed-off-by: Jiri Slaby Cc: Tomi Valkeinen Cc: --- drivers/video/console/mdacon.c | 19 +++

Re: [PATCH 1/5] drm: introduce sync objects (v2)

2017-05-12 Thread Daniel Vetter
On Fri, May 12, 2017 at 10:34:53AM +1000, Dave Airlie wrote: > From: Dave Airlie > > Sync objects are new toplevel drm object, that contain a > pointer to a fence. This fence can be updated via command > submission ioctls via drivers. > > There is also a generic wait obj API modelled on the vulk

Re: [PATCH 2/5] drm/syncobj: add sync obj wait interface. (v2)

2017-05-12 Thread Daniel Vetter
On Fri, May 12, 2017 at 10:34:54AM +1000, Dave Airlie wrote: > From: Dave Airlie > > This interface will allow sync object to be used to back > Vulkan fences. This API is pretty much the vulkan fence waiting > API, and I've ported the code from amdgpu. > > v2: accept relative timeout, pass remai

Re: [PATCH v2 5/7] drm/ltdc: Use the panel-bridge helper.

2017-05-12 Thread Boris Brezillon
On Thu, 11 May 2017 11:31:26 -0700 Eric Anholt wrote: > Another 100 lines of boilerplate gone. Bridges aren't supported yet, > but will be trivial to add later. > > Signed-off-by: Eric Anholt > --- > [...] > @@ -1082,28 +993,13 @@ int ltdc_load(struct drm_device *ddev) > > DRM_INFO(

Re: [PATCH v2 1/8] drm: Add crtc/encoder/bridge->mode_valid() callbacks

2017-05-12 Thread Laurent Pinchart
Hi Daniel, On Wednesday 10 May 2017 10:03:37 Daniel Vetter wrote: > On Tue, May 09, 2017 at 06:00:08PM +0100, Jose Abreu wrote: > > This adds a new callback to crtc, encoder and bridge helper functions > > called mode_valid(). This callback shall be implemented if the > > corresponding component h

Re: [PATCH 5/5] amdgpu: use drm sync objects for shared semaphores (v4)

2017-05-12 Thread Christian König
Am 12.05.2017 um 02:34 schrieb Dave Airlie: From: Dave Airlie This creates a new command submission chunk for amdgpu to add in and out sync objects around the submission. Sync objects are managed via the drm syncobj ioctls. The command submission interface is enhanced with two new chunks, one

[PATCH 2/2] frv, mn10300, s390, sh: remove empty vga.h

2017-05-12 Thread Jiri Slaby
Provided the architectures do not need any special handling (they seem not to support vga at all, actually), there is no need to have an empty vga.h. Let them refer to the generic one instead. Signed-off-by: Jiri Slaby Acked-by: Geert Uytterhoeven Acked-by: Martin Schwidefsky Cc: David Howells

[PATCH 1/2] m32r, microblaze, x86, xtensa: use generic vga.h

2017-05-12 Thread Jiri Slaby
What these architectures declare is the same as what can be found in asm-generic/vga.h. So use that header instead. Signed-off-by: Jiri Slaby Acked-by: Max Filippov Cc: Michal Simek Cc: Thomas Gleixner Cc: Ingo Molnar Cc: "H. Peter Anvin" Cc: Chris Zankel Cc: x...@kernel.org Cc: linux-xte..

Re: [PATCH 2/5] drm/syncobj: add sync obj wait interface. (v2)

2017-05-12 Thread Chris Wilson
On Fri, May 12, 2017 at 10:34:54AM +1000, Dave Airlie wrote: > +static int drm_syncobj_wait_all_fences(struct drm_device *dev, > +struct drm_file *file_private, > +struct drm_syncobj_wait *wait, > +

Re: [PATCH 2/5] drm/syncobj: add sync obj wait interface. (v2)

2017-05-12 Thread Christian König
Am 12.05.2017 um 10:49 schrieb Chris Wilson: On Fri, May 12, 2017 at 10:34:54AM +1000, Dave Airlie wrote: +static int drm_syncobj_wait_all_fences(struct drm_device *dev, + struct drm_file *file_private, + struct drm_syncob

Re: [RFC v2 0/7] drm: asynchronous atomic plane update

2017-05-12 Thread Ville Syrjälä
On Thu, May 11, 2017 at 04:29:56PM -0300, Gustavo Padovan wrote: > 2017-05-09 Ville Syrjälä : > > > On Thu, Apr 27, 2017 at 12:15:12PM -0300, Gustavo Padovan wrote: > > > From: Gustavo Padovan > > > > > > Hi, > > > > > > Second take of Asynchronous Plane Updates over Atomic. Here I looked > > >

Re: [PATCH] drm: fourcc byteorder: brings header file comments in line with reality.

2017-05-12 Thread Ville Syrjälä
On Thu, May 11, 2017 at 11:23:11PM +0200, Pavel Machek wrote: > On Fri 2017-04-21 14:08:04, Ville Syrjälä wrote: > > On Fri, Apr 21, 2017 at 11:50:18AM +0200, Gerd Hoffmann wrote: > > > On Fr, 2017-04-21 at 12:25 +0300, Ville Syrjälä wrote: > > > > On Fri, Apr 21, 2017 at 09:58:24AM +0200, Gerd Hof

[Bug 96868] AMDGPU Tonga only does 2560x1440 at 120hz, switching to 144hz causes display errors, same thing used to happen with fglrx.

2017-05-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96868 --- Comment #22 from Jonas --- I use amdgpu driver, so I guessed I only need patch 1, 3 & 4. This is my first time patching a kernel, I hope I did it right. I tried patching 4.10.15 and 4.11, but the result is the same: with 120Hz the screen sta

Re: [PATCH v2 5/8] drm: Use new mode_valid() helpers in connector probe helper

2017-05-12 Thread Laurent Pinchart
Hi Jose, Thank you for the patch. On Tuesday 09 May 2017 18:00:12 Jose Abreu wrote: > This changes the connector probe helper function to use the new > encoder->mode_valid() and crtc->mode_valid() helper callbacks to > validate the modes. > > The new callbacks are optional so the behaviour remai

Re: [PATCH v2 6/8] drm: Introduce drm_bridge_mode_valid()

2017-05-12 Thread Laurent Pinchart
Hi Daniel, On Wednesday 10 May 2017 17:14:33 Daniel Vetter wrote: > On Wed, May 10, 2017 at 04:41:09PM +0300, Ville Syrjälä wrote: > > On Tue, May 09, 2017 at 06:00:13PM +0100, Jose Abreu wrote: > > > Introduce a new helper function which calls mode_valid() callback > > > for all bridges in an enc

Re: [PATCH v2 7/8] drm: Use mode_valid() in atomic modeset

2017-05-12 Thread Laurent Pinchart
Hi Daniel, On Wednesday 10 May 2017 19:55:56 Daniel Vetter wrote: > On Wed, May 10, 2017 at 09:38:00PM +0530, Archit Taneja wrote: > > On 5/9/2017 10:30 PM, Jose Abreu wrote: > > > This patches makes use of the new mode_valid() callbacks introduced > > > previously to validate the full video pipel

Re: [PATCH v2 8/8] drm: arc: Use crtc->mode_valid() callback

2017-05-12 Thread Laurent Pinchart
Hi Jose, Thank you for the patch. On Tuesday 09 May 2017 18:00:15 Jose Abreu wrote: > Now that we have a callback to check if crtc supports a given mode > we can use it in arcpgu so that we restrict the number of probbed > modes to the ones we can actually display. > > This is specially useful b

Re: [PATCH v2 1/7] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.

2017-05-12 Thread Archit Taneja
Hi, On 05/12/2017 12:01 AM, Eric Anholt wrote: Many DRM drivers have common code to make a stub connector implementation that wraps a drm_panel. By wrapping the panel in a DRM bridge, all of the connector code (including calls during encoder enable/disable) goes away. v2: Fix build with CONFIG

[PATCH 04/13] drm/omap: connector-dvi/hdmi: remove extra include

2017-05-12 Thread Tomi Valkeinen
Remove extra includes related to non-DT boot. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/displays/connector-dvi.c | 1 - drivers/gpu/drm/omapdrm/displays/connector-hdmi.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/displays/connector-dvi.c b/driv

[PATCH 01/13] drm/omap: panel-dpi: remove non-DT support

2017-05-12 Thread Tomi Valkeinen
Non-DT booting is no longer supported, so remove legacy code. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/displays/panel-dpi.c | 78 +++- 1 file changed, 6 insertions(+), 72 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dpi.c b/drivers/g

[PATCH 00/13] drm/omap: legacy cleanup

2017-05-12 Thread Tomi Valkeinen
This series removes a bunch of code that is not used anymore. Some of it was for non-DT booting, some for omapfb. I picked the RFBI removal to this series from the other series I have sent, as it allowed me to remove a bit more here. Tomi Tomi Valkeinen (13): drm/omap: panel-dpi: remove non-D

[PATCH 05/13] drm/omap: sdi: remove legacy set_datapairs

2017-05-12 Thread Tomi Valkeinen
Non-DT booting is no longer supported, so remove legacy code. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/omapdss.h | 6 -- drivers/gpu/drm/omapdrm/dss/sdi.c | 7 --- 2 files changed, 13 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h b/drivers/gpu

[PATCH 10/13] drm/omap: remove unused get_dimensions()

2017-05-12 Thread Tomi Valkeinen
get_dimensions function pointer is not used, remove it. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/omapdss.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h b/drivers/gpu/drm/omapdrm/dss/omapdss.h index 8eb8315a6c95..4909ea11cb71 100

[PATCH 06/13] drm/omap: venc: remove set_type & invert_vid_out_polarity

2017-05-12 Thread Tomi Valkeinen
Non-DT booting is no longer supported, so remove legacy code. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/displays/encoder-opa362.c | 10 -- drivers/gpu/drm/omapdrm/dss/omapdss.h | 10 -- drivers/gpu/drm/omapdrm/dss/venc.c| 23 ---

[PATCH 03/13] drm/omap: connector-analog-tv: remove non-DT support

2017-05-12 Thread Tomi Valkeinen
Non-DT booting is no longer supported, so remove legacy code. Signed-off-by: Tomi Valkeinen --- .../gpu/drm/omapdrm/displays/connector-analog-tv.c | 52 +++--- 1 file changed, 6 insertions(+), 46 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c b

[PATCH 12/13] drm/omap: remove unused fields

2017-05-12 Thread Tomi Valkeinen
Remove unused fields in struct omap_dss_device. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/omapdss.h | 17 - 1 file changed, 17 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h b/drivers/gpu/drm/omapdrm/dss/omapdss.h index 74408b0ece26..3cf42e5

[PATCH 08/13] drm/omap: dpi: remove legacy data_lines

2017-05-12 Thread Tomi Valkeinen
Remove DPI's legacy data_lines code. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c | 4 drivers/gpu/drm/omapdrm/displays/panel-dpi.c| 5 - drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c | 5 - drivers/gp

[PATCH 13/13] drm/omap: remove omap_overlay & omap_overlay_manager

2017-05-12 Thread Tomi Valkeinen
Structs omap_overlay and omap_overlay_manager are not used, remove them. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/omapdss.h | 87 --- 1 file changed, 87 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h b/drivers/gpu/drm/omapdr

[PATCH 09/13] drm/omap: remove rfbi

2017-05-12 Thread Tomi Valkeinen
The RFBI driver has not worked nor compiled for many years. There are very few boards out there that use RFBI, and no one has stepped up to fix it. So let's remove the RFBI code that doesn't even compile. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/Kconfig | 13 - drivers/

[PATCH 02/13] drm/omap: acx565akm: remove non-DT support

2017-05-12 Thread Tomi Valkeinen
Non-DT booting is no longer supported, so remove legacy code. Signed-off-by: Tomi Valkeinen --- .../drm/omapdrm/displays/panel-sony-acx565akm.c| 50 +++--- 1 file changed, 6 insertions(+), 44 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/displays/panel-sony-acx565akm.c

[PATCH 07/13] drm/omap: remove recommended_bpp

2017-05-12 Thread Tomi Valkeinen
recommended_bpp hasn't been used for ages, remove the code. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 1 - drivers/gpu/drm/omapdrm/dss/display.c | 33 - drivers/gpu/drm/omapdrm/dss/omapdss.h | 2 -- 3 files c

[PATCH 11/13] drm/omap: remove legacy get_resolution

2017-05-12 Thread Tomi Valkeinen
get_resolution is not used, remove it. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c | 2 -- drivers/gpu/drm/omapdrm/displays/connector-dvi.c| 2 -- drivers/gpu/drm/omapdrm/displays/connector-hdmi.c | 2 -- drivers/gpu/drm/

Re: [PATCH v2 6/8] drm: Introduce drm_bridge_mode_valid()

2017-05-12 Thread Archit Taneja
On 05/12/2017 03:08 PM, Laurent Pinchart wrote: Hi Daniel, On Wednesday 10 May 2017 17:14:33 Daniel Vetter wrote: On Wed, May 10, 2017 at 04:41:09PM +0300, Ville Syrjälä wrote: On Tue, May 09, 2017 at 06:00:13PM +0100, Jose Abreu wrote: Introduce a new helper function which calls mode_valid

Re: [PATCH 1/4] drm/vc4: Adjust modes in DSI to work around the integer PLL divider.

2017-05-12 Thread Noralf Trønnes
Den 12.05.2017 01.56, skrev Eric Anholt: BCM2835's PLLD_DSI1 divider doesn't give us many choices for our pixel clocks, so to support panels on the Raspberry Pi we need to set a higher pixel clock rate than requested and adjust the mode we program to extend out the HFP so that the refresh rate m

Re: [PATCH v2 6/8] drm: Introduce drm_bridge_mode_valid()

2017-05-12 Thread Laurent Pinchart
Hi Archit, On Friday 12 May 2017 16:20:07 Archit Taneja wrote: > On 05/12/2017 03:08 PM, Laurent Pinchart wrote: > > On Wednesday 10 May 2017 17:14:33 Daniel Vetter wrote: > >> On Wed, May 10, 2017 at 04:41:09PM +0300, Ville Syrjälä wrote: > >>> On Tue, May 09, 2017 at 06:00:13PM +0100, Jose Abreu

Re: [PATCH] drm: Add crtc/encoder/bridge->mode_valid() callbacks

2017-05-12 Thread Laurent Pinchart
Hi Daniel, On Friday 12 May 2017 09:31:00 Daniel Vetter wrote: > From: Jose Abreu > > This adds a new callback to crtc, encoder and bridge helper functions > called mode_valid(). This callback shall be implemented if the > corresponding component has some sort of restriction in the modes > that

[PATCH] dma-buf/sync-file: Defer creation of sync_file->name

2017-05-12 Thread Chris Wilson
Constructing the name takes the majority of the time for allocating a sync_file to wrap a fence, and the name is very rarely used (only via the sync_file status user interface). To reduce the impact on the common path (that of creating sync_file to pass around), defer the construction of the name u

Re: [PATCH 0/3] GPU-DRM-Radeon: Fine-tuning for three function implementations

2017-05-12 Thread Laurent Pinchart
Hi Christian, On Wednesday 10 May 2017 13:30:37 Christian König wrote: > Am 10.05.2017 um 02:23 schrieb Michel Dänzer: > > On 03/05/17 09:46 PM, Christian König wrote: > >> Am 02.05.2017 um 22:04 schrieb SF Markus Elfring: > >>> From: Markus Elfring > >>> Date: Tue, 2 May 2017 22:00:02 +0200 > >>

[Bug 101003] segfault with ideas test of glmark2

2017-05-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101003 --- Comment #4 from José Jorge --- Created attachment 131335 --> https://bugs.freedesktop.org/attachment.cgi?id=131335&action=edit Backtrace with mesa 17.1.0 I could update to mesa 17.1.0, so I did this backtrace with it. -- You are receivi

Re: [PATCH 01/13] drm/omap: panel-dpi: remove non-DT support

2017-05-12 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Friday 12 May 2017 13:41:30 Tomi Valkeinen wrote: > Non-DT booting is no longer supported, so remove legacy code. > > Signed-off-by: Tomi Valkeinen > --- > drivers/gpu/drm/omapdrm/displays/panel-dpi.c | 78 +++-- > 1 file changed, 6 inse

Re: [PATCH 02/13] drm/omap: acx565akm: remove non-DT support

2017-05-12 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Friday 12 May 2017 13:41:31 Tomi Valkeinen wrote: > Non-DT booting is no longer supported, so remove legacy code. > > Signed-off-by: Tomi Valkeinen > --- > .../drm/omapdrm/displays/panel-sony-acx565akm.c| 50 +++ > 1 file changed, 6 inse

Re: [PATCH 04/13] drm/omap: connector-dvi/hdmi: remove extra include

2017-05-12 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Friday 12 May 2017 13:41:33 Tomi Valkeinen wrote: > Remove extra includes related to non-DT boot. > > Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/omapdrm/displays/connector-dvi.c | 1 - > drivers/gpu/drm/omapdrm/d

Re: [PATCH 06/13] drm/omap: venc: remove set_type & invert_vid_out_polarity

2017-05-12 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Friday 12 May 2017 13:41:35 Tomi Valkeinen wrote: > Non-DT booting is no longer supported, so remove legacy code. > > Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/omapdrm/displays/encoder-opa362.c | 10 -- >

Re: [PATCH 05/13] drm/omap: sdi: remove legacy set_datapairs

2017-05-12 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Friday 12 May 2017 13:41:34 Tomi Valkeinen wrote: > Non-DT booting is no longer supported, so remove legacy code. > > Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/omapdrm/dss/omapdss.h | 6 -- > drivers/gpu/drm/

Re: [PATCH 07/13] drm/omap: remove recommended_bpp

2017-05-12 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Friday 12 May 2017 13:41:36 Tomi Valkeinen wrote: > recommended_bpp hasn't been used for ages, remove the code. > > Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 1 - > drivers/gpu/

Re: [PATCH 08/13] drm/omap: dpi: remove legacy data_lines

2017-05-12 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Friday 12 May 2017 13:41:37 Tomi Valkeinen wrote: > Remove DPI's legacy data_lines code. > > Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c | 4 > drivers/gpu/drm/omap

Re: [PATCH 09/13] drm/omap: remove rfbi

2017-05-12 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Friday 12 May 2017 13:41:38 Tomi Valkeinen wrote: > The RFBI driver has not worked nor compiled for many years. There are > very few boards out there that use RFBI, and no one has stepped up to > fix it. > > So let's remove the RFBI code that doesn't even com

Re: [PATCH 10/13] drm/omap: remove unused get_dimensions()

2017-05-12 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Friday 12 May 2017 13:41:39 Tomi Valkeinen wrote: > get_dimensions function pointer is not used, remove it. > > Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/omapdrm/dss/omapdss.h | 2 -- > 1 file changed, 2 deletion

Re: [PATCH 11/13] drm/omap: remove legacy get_resolution

2017-05-12 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Friday 12 May 2017 13:41:40 Tomi Valkeinen wrote: > get_resolution is not used, remove it. > > Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c | 2 -- > drivers/gpu/drm/omap

Re: [PATCH 12/13] drm/omap: remove unused fields

2017-05-12 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Friday 12 May 2017 13:41:41 Tomi Valkeinen wrote: > Remove unused fields in struct omap_dss_device. > > Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/omapdrm/dss/omapdss.h | 17 - > 1 file changed, 17

Re: [PATCH 13/13] drm/omap: remove omap_overlay & omap_overlay_manager

2017-05-12 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Friday 12 May 2017 13:41:42 Tomi Valkeinen wrote: > Structs omap_overlay and omap_overlay_manager are not used, remove them. > > Signed-off-by: Tomi Valkeinen You can also remove enum omap_overlay_manager_caps in the same patch. With that fixed, Reviewed-

Re: [PATCH 01/13] drm/omap: panel-dpi: remove non-DT support

2017-05-12 Thread Tomi Valkeinen
Hi, On 12/05/17 15:08, Laurent Pinchart wrote: > Hi Tomi, > > Thank you for the patch. > > On Friday 12 May 2017 13:41:30 Tomi Valkeinen wrote: >> Non-DT booting is no longer supported, so remove legacy code. >> >> Signed-off-by: Tomi Valkeinen >> --- >> drivers/gpu/drm/omapdrm/displays/panel-

Re: [PATCH 01/13] drm/omap: panel-dpi: remove non-DT support

2017-05-12 Thread Laurent Pinchart
Hi Tomi, On Friday 12 May 2017 15:29:38 Tomi Valkeinen wrote: > On 12/05/17 15:08, Laurent Pinchart wrote: > > On Friday 12 May 2017 13:41:30 Tomi Valkeinen wrote: > >> Non-DT booting is no longer supported, so remove legacy code. > >> > >> Signed-off-by: Tomi Valkeinen > >> --- > >> > >> driv

[PATCH 14/13] drm: omapdrm: Remove unused omap_dss_find_output() function

2017-05-12 Thread Laurent Pinchart
The omap_dss_find_output() function is unused, remove it. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/dss/omapdss.h | 1 - drivers/gpu/drm/omapdrm/dss/output.c | 13 - 2 files changed, 14 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h b/drivers/gp

Re: [PATCH] drm: Add crtc/encoder/bridge->mode_valid() callbacks

2017-05-12 Thread Andrzej Hajda
On 12.05.2017 09:31, Daniel Vetter wrote: > From: Jose Abreu > > This adds a new callback to crtc, encoder and bridge helper functions > called mode_valid(). This callback shall be implemented if the > corresponding component has some sort of restriction in the modes > that can be displayed. A NUL

Re: [PATCH 14/13] drm: omapdrm: Remove unused omap_dss_find_output() function

2017-05-12 Thread Tomi Valkeinen
On 12/05/17 15:33, Laurent Pinchart wrote: > The omap_dss_find_output() function is unused, remove it. > > Signed-off-by: Laurent Pinchart > --- > drivers/gpu/drm/omapdrm/dss/omapdss.h | 1 - > drivers/gpu/drm/omapdrm/dss/output.c | 13 - > 2 files changed, 14 deletions(-) Thanks,

Re: [PATCH] dma-buf/sync-file: Defer creation of sync_file->name

2017-05-12 Thread kbuild test robot
Hi Chris, [auto build test WARNING on linus/master] [also build test WARNING on v4.11 next-20170512] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Chris-Wilson/dma-buf-sync-file-Defer-creation

Re: [PATCH v7 3/9] drm/i915: Drop AUX backlight enable check for backlight control

2017-05-12 Thread Jani Nikula
On Fri, 12 May 2017, "Pandiyan, Dhinakaran" wrote: > On Thu, 2017-05-11 at 16:02 -0700, Puthikorn Voravootivat wrote: >> There are some panel that >> (1) does not support display backlight enable via AUX >> (2) support display backlight adjustment via AUX >> (3) support display backlight enable v

Re: [PATCH 1/5] drm: introduce sync objects (v2)

2017-05-12 Thread Sean Paul
On Fri, May 12, 2017 at 10:34:53AM +1000, Dave Airlie wrote: > From: Dave Airlie > > Sync objects are new toplevel drm object, that contain a > pointer to a fence. This fence can be updated via command > submission ioctls via drivers. > > There is also a generic wait obj API modelled on the vulk

Re: [PATCH 2/5] drm/syncobj: add sync obj wait interface. (v2)

2017-05-12 Thread Sean Paul
On Fri, May 12, 2017 at 10:34:54AM +1000, Dave Airlie wrote: > From: Dave Airlie > > This interface will allow sync object to be used to back > Vulkan fences. This API is pretty much the vulkan fence waiting > API, and I've ported the code from amdgpu. > > v2: accept relative timeout, pass remai

Re: [PATCH v3 0/6] Introduce new mode validation callbacks

2017-05-12 Thread Andrzej Hajda
On 12.05.2017 09:32, Daniel Vetter wrote: > On Thu, May 11, 2017 at 10:05:56AM +0100, Jose Abreu wrote: >> This series is a follow up from the discussion at [1]. We start by >> introducing crtc->mode_valid(), encoder->mode_valid() and >> bridge->mode_valid() callbacks which will be used in followup

Re: [PATCH 3/5] drm/syncobj: add sync_file interaction.

2017-05-12 Thread Sean Paul
On Fri, May 12, 2017 at 10:34:55AM +1000, Dave Airlie wrote: > From: Dave Airlie > > This interface allows importing the fence from a sync_file into > an existing drm sync object, or exporting the fence attached to > an existing drm sync object into a new sync file object. > > This should only b

Re: [PATCH] dma-buf/sync-file: Defer creation of sync_file->name

2017-05-12 Thread Gustavo Padovan
Hi Chris, Thanks for the patch! 2017-05-12 Chris Wilson : > Constructing the name takes the majority of the time for allocating a > sync_file to wrap a fence, and the name is very rarely used (only via > the sync_file status user interface). To reduce the impact on the common > path (that of cre

Re: Requests for Proposal for hosting XDC 2018

2017-05-12 Thread Daniel Vetter
On Fri, May 12, 2017 at 12:08 AM, Daniel Vetter wrote: > The X.org board is soliciting proposals to host XDC in 2017 That's meant to read 2018 too of course, I missed one date ... -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch __

[PATCH v2] drm/vc4: use drm_for_each_connector_iter()

2017-05-12 Thread Gustavo Padovan
From: Gustavo Padovan Drop legacy drm_for_each_connector() in favor of the race-free drm_for_each_connector_iter(). v2: add missing drm_connector_list_iter_end(Daniel Vetter) Cc: Eric Anholt Signed-off-by: Gustavo Padovan Reviewed-by: Daniel Vetter --- only built-tested! --- drivers/gpu/dr

[Bug 99923] HITMAN (2016) having lighting and artefacting, and overly light room.

2017-05-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99923 --- Comment #15 from Christoph Schwerdtfeger --- The issue is still present using mesa 17.1.0-1 (Debian/experimental) and llvm 4.0.1~+rc1 (also Debian/experimental). I also have llvm 5.0 (5.0~svn301421; Debian/experimental) installed. -- You ar

Re: [PATCH 3/8] drm/i915: use drm_for_each_connector_iter()

2017-05-12 Thread Ville Syrjälä
On Fri, May 12, 2017 at 09:42:20AM +0200, Daniel Vetter wrote: > On Thu, May 11, 2017 at 04:10:44PM -0300, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > Drop legacy drm_for_each_connector() in favor of the race-free > > drm_for_each_connector_iter(). > > > > Cc: Daniel Vetter > > Cc:

[Bug 101011] Shadow of Mordor crashes with mesa from 08.05.2017.

2017-05-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101011 --- Comment #1 from Gilles --- I have the exact same problem with the same driver versions. Platform: Linux Mint 18.1 x64 Kernel 4.11.0-041100-generic Mesa package: 17.2~git170508140100.b84979d~ LLVM package: 5.0~svn301901-0~x~padoka0 AMD Ryzen

[PATCH v3] dma-buf/sync-file: Defer creation of sync_file->name

2017-05-12 Thread Chris Wilson
Constructing the name takes the majority of the time for allocating a sync_file to wrap a fence, and the name is very rarely used (only via the sync_file status user interface). To reduce the impact on the common path (that of creating sync_file to pass around), defer the construction of the name u

Re: [git pull] drm fixes for v4.12-rc1

2017-05-12 Thread Linus Torvalds
.. and here's the email repeated for the new dri-devel list, since apparently Dave sent the pull request to the old no-longer-working one that just sends annoying bounces. Dave, time to update your scripts and address book.. Linus On Fri, May 12, 2017 at 11:54 AM, Linus Torvalds w

Re: [PATCH 3/3] drm/tegra: Check size of a submitted command buffer

2017-05-12 Thread Erik Faye-Lund
On Fri, May 12, 2017 at 9:02 PM, Dmitry Osipenko wrote: > If command buffer claims a number of words that is higher than its BO can > fit and a relocation lays past the BO, a kernel OOPS will be fired on that > relocation address patching. This was triggered by an opentegra Xorg driver > that erro

[RFC v3 3/8] drm/i915: update cursors asynchronously through atomic

2017-05-12 Thread Gustavo Padovan
From: Gustavo Padovan Add support to async updates of cursors by using the new atomic interface for that. Basically what this commit does is do what intel_legacy_cursor_update() did but through atomic. v3: - set correct vma to new state for cleanup - move size checks back to driv

[RFC v3 1/8] drm/atomic: initial support for asynchronous plane update

2017-05-12 Thread Gustavo Padovan
From: Gustavo Padovan In some cases, like cursor updates, it is interesting to update the plane in an asynchronous fashion to avoid big delays. The current queued update could be still waiting for a fence to signal and thus block any subsequent update until its scan out. In cases like this if we

[RFC v3 4/8] drm/i915: remove intel_cursor_plane_funcs

2017-05-12 Thread Gustavo Padovan
From: Gustavo Padovan After converting legacy cursor updates to atomic async commits intel_cursor_plane_funcs just duplicates intel_plane_funcs now. Cc: Daniel Vetter Signed-off-by: Gustavo Padovan --- drivers/gpu/drm/i915/intel_display.c | 13 + 1 file changed, 1 insertion(+), 12

[RFC v3 2/8] drm/virtio: support async cursor updates

2017-05-12 Thread Gustavo Padovan
From: Gustavo Padovan Short circuit the update path for cursors and use the drm async update infrastructure. v2: move fb setting to core and use new state (Eric Anholt) Signed-off-by: Gustavo Padovan --- I wrote this mostly for testing purposes, not sure if its something that we actually need

[RFC v3 6/8] drm/msm: remove mdp5_cursor_plane_funcs

2017-05-12 Thread Gustavo Padovan
From: Gustavo Padovan After converting legacy cursor updates to atomic async commits mdp5_cursor_plane_funcs just duplicates mdp5_plane_funcs now. Cc: Rob Clark Signed-off-by: Gustavo Padovan --- drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c | 26 +++--- 1 file changed, 3 inse

  1   2   >