Re: [PATCH v3 8/9] drm/rockchip: gem: Don't alloc/free gem buf when dev_private is invalid

2017-04-07 Thread Daniel Vetter
On Fri, Apr 07, 2017 at 02:44:05PM +0800, jeffy wrote: > Hi Daniel, > > On 04/07/2017 02:30 PM, Daniel Vetter wrote: > > On Thu, Apr 6, 2017 at 1:09 PM, jeffy wrote: > > > > > > On 04/06/2017 04:26 PM, Daniel Vetter wrote: > > > > > > > > On Wed, Apr 05, 2017 at 12:28:40PM -0400, Sean Paul wrot

Re: [PATCH v5 12/12] drm/drm_ioctl.c: Break ioctl when drm device not registered

2017-04-07 Thread Daniel Vetter
On Thu, Apr 06, 2017 at 08:31:25PM +0800, Jeffy Chen wrote: > After unbinding drm, the user space may still owns the drm dev fd, > and may still be able to call drm ioctl. > > Add a sanity check here to prevent that from happening. > > Signed-off-by: Jeffy Chen > --- > > Changes in v5: None > C

Re: [RFC PATCH 2/2] drm/vgem: Enable dmabuf import interfaces

2017-04-07 Thread Chris Wilson
On Thu, Apr 06, 2017 at 04:18:33PM -0700, Laura Abbott wrote: > > Enable the GEM dma-buf import interfaces in addition to the export > interfaces. This lets vgem be used as a test source for other allocators > (e.g. Ion). > > +int vgem_gem_get_pages(struct drm_vgem_gem_object *obj) > +{ > + s

Re: Proposal for RandR version 1.6, Leases and EDID-based output grabs

2017-04-07 Thread Pekka Paalanen
On Thu, 06 Apr 2017 20:02:23 -0700 Keith Packard wrote: > Michel Dänzer writes: > > > When no such special client (Steam?) is running, the desktop environment > > will try to use the HMD anyway, right? So the expected use case would be > > for the user to start a special client first and only p

Re: [PATCH] drm/exynos: clean up description of exynos_drm_crtc

2017-04-07 Thread Inki Dae
Hello Tobias, 2017년 04월 07일 02:10에 Tobias Jakobi 이(가) 쓴 글: > Hello Inki, > > > Inki Dae wrote: >> This patch removes unnecessary descriptions on >> exynos_drm_crtc structure and adds one description >> which specifies what pipe_clk member does. >> >> pipe_clk support had been added by below pat

Re: DRM_FORMAT_* byte order (was: Re: [PATCH] drm: virtio: fix virtio_gpu_cursor_formats)

2017-04-07 Thread Gerd Hoffmann
Hi, > > So, bigendian guests assume that DRM_FORMAT_XRGB is big endian not > > little endian. And given that the fourcc codes are used in the > > userspace/kernel API too (see DRM_IOCTL_MODE_ADDFB2) I think we can't > > change that any more ... > > Sigh. That makes mixed endian systems pre

drm-tip/drm-tip build: 207 builds: 1 failed, 206 passed, 204 warnings (v4.11-rc5-1749-g60e3f75dfa48)

2017-04-07 Thread kernelci . org bot
drm-tip/drm-tip build: 207 builds: 1 failed, 206 passed, 204 warnings (v4.11-rc5-1749-g60e3f75dfa48) Full Build Summary: https://kernelci.org/build/drm-tip/branch/drm-tip/kernel/v4.11-rc5-1749-g60e3f75dfa48/ Tree: drm-tip Branch: drm-tip Git Describe: v4.11-rc5-1749-g60e3f75dfa48 Git Commit: 60

Re: DRM_FORMAT_* byte order (was: Re: [PATCH] drm: virtio: fix virtio_gpu_cursor_formats)

2017-04-07 Thread Gerd Hoffmann
Hi, > Hmm. Maybe it's still possible to salvage something by redefining the > BIG_ENDIAN format bit to mean the "the other endianness". Ugly but it > might still result in something usable. Also at least for the virtual machine use case this doesn't buy us much. The drm drivers (at least the on

Re: [PATCH] drm: bridge: dw-hdmi: fix input format/encoding from plat_data

2017-04-07 Thread Archit Taneja
On 04/06/2017 03:04 PM, Neil Armstrong wrote: The plat_data->input_bus_format and plat_data->input_bus_encoding are unsigned long and are alsways >=0, but the value 0 was still s/alsways/always considered as RGB888 like the default behaviour. Is RGB888 default behaviour for plat_data->inp

Re: [PATCH] drm: bridge: dw-hdmi: fix input format/encoding from plat_data

2017-04-07 Thread Neil Armstrong
On 04/07/2017 10:32 AM, Archit Taneja wrote: > > > On 04/06/2017 03:04 PM, Neil Armstrong wrote: >> The plat_data->input_bus_format and plat_data->input_bus_encoding >> are unsigned long and are alsways >=0, but the value 0 was still > > s/alsways/always > >> considered as RGB888 like the defau

Re: DRM_FORMAT_* byte order (was: Re: [PATCH] drm: virtio: fix virtio_gpu_cursor_formats)

2017-04-07 Thread Ville Syrjälä
On Fri, Apr 07, 2017 at 10:29:00AM +0200, Gerd Hoffmann wrote: > Hi, > > > Hmm. Maybe it's still possible to salvage something by redefining the > > BIG_ENDIAN format bit to mean the "the other endianness". Ugly but it > > might still result in something usable. > > Also at least for the virtua

Re: [PATCH] drm/vmwgfx: Fix fbdev emulation using legacy functions

2017-04-07 Thread Thomas Hellstrom
Hi, Daniel. It appears to work fine. Thanks! Do you want to take it through drm-misc or want me to take it throuch vmwgfx-next? Reviewed-by: Thomas Hellstrom /Thomas On 04/06/2017 10:02 PM, Daniel Vetter wrote: > I've broken this by removing the backoff handling from the > set_config2atomic

[ANNOUNCE] libdrm 2.4.78

2017-04-07 Thread Daniel Stone
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi, This libdrm-2.4.78 fixes some minor cosmetics, a build issue for GNU/kFreeBSD, and adds a new page_flip_handler2 event handler, which when run on a suitably capable kernel, can provide the CRTC ID to userspace for atomic completion events. Cheer

Re: [Intel-gfx] [PATCH 1/5] i915: avoid kernel hang caused by synchronize rcu struct_mutex deadlock

2017-04-07 Thread Joonas Lahtinen
On pe, 2017-04-07 at 01:23 +0200, Andrea Arcangeli wrote: > synchronize_rcu/synchronize_sched/synchronize_rcu_expedited() will > hang until its own workqueues are run. The i915 gem workqueues will > wait on the struct_mutex to be released. So we cannot wait for a > quiescent state using those rcu p

Re: [PATCH] drm: bridge: dw-hdmi: fix input format/encoding from plat_data

2017-04-07 Thread Neil Armstrong
On 04/07/2017 10:37 AM, Neil Armstrong wrote: > On 04/07/2017 10:32 AM, Archit Taneja wrote: >> >> >> On 04/06/2017 03:04 PM, Neil Armstrong wrote: >>> The plat_data->input_bus_format and plat_data->input_bus_encoding >>> are unsigned long and are alsways >=0, but the value 0 was still >> >> s/alsw

Re: [PATCH 5/5] i915: fence workqueue optimization

2017-04-07 Thread Chris Wilson
On Fri, Apr 07, 2017 at 01:23:47AM +0200, Andrea Arcangeli wrote: > Insist to run llist_del_all() until the free_list is found empty, this > may avoid having to schedule more workqueues. The work will already be scheduled (everytime we add the first element, the work is scheduled, and the schedule

Re: [PATCH 2/5] i915: flush gem obj freeing workqueues to add accuracy to the i915 shrinker

2017-04-07 Thread Chris Wilson
On Fri, Apr 07, 2017 at 01:23:44AM +0200, Andrea Arcangeli wrote: > Waiting a RCU grace period only guarantees the work gets queued, but > until after the queued workqueue returns, there's no guarantee the > memory was actually freed. So flush the work to provide better > guarantees to the reclaim

Re: DRM_FORMAT_* byte order (was: Re: [PATCH] drm: virtio: fix virtio_gpu_cursor_formats)

2017-04-07 Thread Gerd Hoffmann
On Fr, 2017-04-07 at 11:45 +0300, Ville Syrjälä wrote: > On Fri, Apr 07, 2017 at 10:29:00AM +0200, Gerd Hoffmann wrote: > > Hi, > > > > > Hmm. Maybe it's still possible to salvage something by redefining the > > > BIG_ENDIAN format bit to mean the "the other endianness". Ugly but it > > > might

drm-tip/drm-tip build: 207 builds: 1 failed, 206 passed, 204 warnings (v4.11-rc5-1776-g5aa5296d0b57)

2017-04-07 Thread kernelci . org bot
drm-tip/drm-tip build: 207 builds: 1 failed, 206 passed, 204 warnings (v4.11-rc5-1776-g5aa5296d0b57) Full Build Summary: https://kernelci.org/build/drm-tip/branch/drm-tip/kernel/v4.11-rc5-1776-g5aa5296d0b57/ Tree: drm-tip Branch: drm-tip Git Describe: v4.11-rc5-1776-g5aa5296d0b57 Git Commit: 5a

Re: [PATCH 3/5] i915: initialize the free_list of the fencing atomic_helper

2017-04-07 Thread Chris Wilson
On Fri, Apr 07, 2017 at 01:23:45AM +0200, Andrea Arcangeli wrote: > Just in case the llist model changes and NULL isn't valid > initialization. > > Signed-off-by: Andrea Arcangeli Applied, thanks. -Chris -- Chris Wilson, Intel Open Source Technology Centre _

[PATCH] drm: Don't allow interruptions when opening debugfs/crc

2017-04-07 Thread Chris Wilson
The code does not like to be interrupted when waiting for the first vblank after opening a debugfs/crc channel, so don't. [66285.716870] WARNING: CPU: 1 PID: 16615 at drivers/gpu/drm/drm_debugfs_crc.c:185 crtc_crc_open+0x1d0/0x1f0 [drm] [66285.716877] Modules linked in: i915 intel_powerclamp crct

drm-tip/drm-tip build: 207 builds: 1 failed, 206 passed, 204 warnings (v4.11-rc5-1777-gfdc0fa0d6347)

2017-04-07 Thread kernelci . org bot
drm-tip/drm-tip build: 207 builds: 1 failed, 206 passed, 204 warnings (v4.11-rc5-1777-gfdc0fa0d6347) Full Build Summary: https://kernelci.org/build/drm-tip/branch/drm-tip/kernel/v4.11-rc5-1777-gfdc0fa0d6347/ Tree: drm-tip Branch: drm-tip Git Describe: v4.11-rc5-1777-gfdc0fa0d6347 Git Commit: fd

Re: [PATCH v5 03/12] drm: bridge: analogix: Disable clock when unbinding

2017-04-07 Thread Andrzej Hajda
On 06.04.2017 14:31, Jeffy Chen wrote: > The clock is enabled when binding analogix dp. > > Signed-off-by: Jeffy Chen Reviewed-by: Andrzej Hajda -- Regards Andrzej > --- > > Changes in v5: None > Changes in v4: None > Changes in v3: None > Changes in v2: None > > drivers/gpu/drm/bridge/analogix/

Re: [PATCH] drm/exynos: clean up description of exynos_drm_crtc

2017-04-07 Thread Tobias Jakobi
Hello Inki, Inki Dae wrote: > Hello Tobias, > > > 2017년 04월 07일 02:10에 Tobias Jakobi 이(가) 쓴 글: >> Hello Inki, >> >> >> Inki Dae wrote: >>> This patch removes unnecessary descriptions on >>> exynos_drm_crtc structure and adds one description >>> which specifies what pipe_clk member does. >>> >>>

Re: [RFC, v2, 10/11] vb2: dma-contig: Let drivers decide DMA attrs of MMAP and USERPTR bufs

2017-04-07 Thread Laurent Pinchart
Hi Ricky, On Monday 26 Dec 2016 15:58:07 Ricky Liang wrote: > On Fri, Dec 16, 2016 at 9:24 AM, Laurent Pinchart wrote: > > From: Sakari Ailus > > > > The desirable DMA attributes are not generic for all devices using > > Videobuf2 contiguous DMA ops. Let the drivers decide. > > > > This change

drm-tip/drm-tip boot: 75 boots: 1 failed, 72 passed with 2 offline (v4.11-rc5-1749-g60e3f75dfa48)

2017-04-07 Thread kernelci . org bot
drm-tip/drm-tip boot: 75 boots: 1 failed, 72 passed with 2 offline (v4.11-rc5-1749-g60e3f75dfa48) Full Boot Summary: https://kernelci.org/boot/all/job/drm-tip/branch/drm-tip/kernel/v4.11-rc5-1749-g60e3f75dfa48/ Full Build Summary: https://kernelci.org/build/drm-tip/branch/drm-tip/kernel/v4.11-r

Re: [PATCH] drm: Don't allow interruptions when opening debugfs/crc

2017-04-07 Thread Tomeu Vizoso
On 04/07/2017 01:17 PM, Chris Wilson wrote: > The code does not like to be interrupted when waiting for the first > vblank after opening a debugfs/crc channel, so don't. > > [66285.716870] WARNING: CPU: 1 PID: 16615 at > drivers/gpu/drm/drm_debugfs_crc.c:185 crtc_crc_open+0x1d0/0x1f0 [drm] > [662

Re: [PATCH v5 04/12] drm: bridge: analogix: Destroy connector & encoder when unbinding

2017-04-07 Thread Andrzej Hajda
On 06.04.2017 14:31, Jeffy Chen wrote: > Normally we do this in drm_mode_config_cleanup. But: > 1/ analogix dp's connector is allocated in bind, and freed after unbind. > So we need to destroy it in unbind to avoid further access. > 2/ the drm bridge is attached in bind, and detached in encoder cle

[PATCH libdrm v2 2/2] etnaviv: add fence fd support

2017-04-07 Thread Philipp Zabel
Add etna_cmd_stream_flush2 with in-fence fd and out-fence fd support for explicit fencing. Signed-off-by: Philipp Zabel Reviewed-by: Eric Engestrom Reviewed-by: Christian Gmeiner --- v2: renamed etna_cmd_stream_flush_explicit to etna_cmd_stream_flush2 --- etnaviv/etnaviv_cmd_stream.c | 33

Re: [PATCHv6 03/10] exynos_hdmi: add CEC notifier support

2017-04-07 Thread Andrzej Hajda
On 31.03.2017 14:20, Hans Verkuil wrote: > From: Hans Verkuil > > Implement the CEC notifier support to allow CEC drivers to > be informed when there is a new physical address. > > Signed-off-by: Hans Verkuil > Tested-by: Marek Szyprowski > Acked-by: Daniel Vetter > Acked-by: Krzysztof Kozlowsk

[PATCH libdrm v2 1/2] etnaviv: sync uapi header

2017-04-07 Thread Philipp Zabel
Import the etnaviv header changes from kernel commits 9ad59fea162c ("drm/etnaviv: submit support for in-fences") and 78ec187f64fa ("drm/etnaviv: submit support for out-fences") for fence fd support. The drm_etnaviv_gem_submit structure was extended to include a flags field, new flags for in-fence

drm-tip/drm-tip build: 207 builds: 0 failed, 207 passed, 204 warnings (v4.11-rc5-1780-g7373a000996b)

2017-04-07 Thread kernelci . org bot
drm-tip/drm-tip build: 207 builds: 0 failed, 207 passed, 204 warnings (v4.11-rc5-1780-g7373a000996b) Full Build Summary: https://kernelci.org/build/drm-tip/branch/drm-tip/kernel/v4.11-rc5-1780-g7373a000996b/ Tree: drm-tip Branch: drm-tip Git Describe: v4.11-rc5-1780-g7373a000996b Git Commit: 73

Re: [RFC v2 07/11] vb2: dma-contig: Remove redundant sgt_base field

2017-04-07 Thread Sakari Ailus
Hi Shuah, On Mon, Mar 27, 2017 at 04:51:40PM -0600, Shuah Khan wrote: > On Thu, Dec 15, 2016 at 6:24 PM, Laurent Pinchart > wrote: > > From: Sakari Ailus > > > > The struct vb2_dc_buf contains two struct sg_table fields: sgt_base and > > dma_sgt. The former is used by DMA-BUF buffers whereas the

[Bug 99744] Bad crtc detection on Radeon Pro WX 4100

2017-04-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99744 Matt Corallo changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

drm-tip/drm-tip build: 207 builds: 1 failed, 206 passed, 204 warnings (v4.11-rc5-1782-g71610c69d4f3)

2017-04-07 Thread kernelci . org bot
drm-tip/drm-tip build: 207 builds: 1 failed, 206 passed, 204 warnings (v4.11-rc5-1782-g71610c69d4f3) Full Build Summary: https://kernelci.org/build/drm-tip/branch/drm-tip/kernel/v4.11-rc5-1782-g71610c69d4f3/ Tree: drm-tip Branch: drm-tip Git Describe: v4.11-rc5-1782-g71610c69d4f3 Git Commit: 71

Re: DRM_FORMAT_* byte order (was: Re: [PATCH] drm: virtio: fix virtio_gpu_cursor_formats)

2017-04-07 Thread Ville Syrjälä
On Fri, Apr 07, 2017 at 12:06:26PM +0200, Gerd Hoffmann wrote: > On Fr, 2017-04-07 at 11:45 +0300, Ville Syrjälä wrote: > > On Fri, Apr 07, 2017 at 10:29:00AM +0200, Gerd Hoffmann wrote: > > > Hi, > > > > > > > Hmm. Maybe it's still possible to salvage something by redefining the > > > > BIG_END

Re: [PATCH v2] dt-bindings: drm: rcar-du: Document optional reset properties

2017-04-07 Thread Laurent Pinchart
Hi Geert and Rob, On Thursday 16 Mar 2017 21:59:04 Geert Uytterhoeven wrote: > On Thu, Mar 16, 2017 at 9:56 PM, Rob Herring wrote: > > On Thu, Mar 16, 2017 at 09:13:16AM +0100, Geert Uytterhoeven wrote: > >> On Wed, Mar 15, 2017 at 6:01 PM, Rob Herring wrote: > >>> On Mon, Mar 06, 2017 at 05:25:

Re: [PATCH 2/5] i915: flush gem obj freeing workqueues to add accuracy to the i915 shrinker

2017-04-07 Thread Andrea Arcangeli
On Fri, Apr 07, 2017 at 11:02:11AM +0100, Chris Wilson wrote: > On Fri, Apr 07, 2017 at 01:23:44AM +0200, Andrea Arcangeli wrote: > > Waiting a RCU grace period only guarantees the work gets queued, but > > until after the queued workqueue returns, there's no guarantee the > > memory was actually f

[Bug 100611] [ALL][BAT][bisected] all systems on CI fails on certain test

2017-04-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100611 Bug ID: 100611 Summary: [ALL][BAT][bisected] all systems on CI fails on certain test Product: DRI Version: DRI git Hardware: Other OS: All Stat

[Bug 100611] [ALL][BAT][bisected] all systems on CI fails on certain test

2017-04-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100611 Jani Saarinen changed: What|Removed |Added Assignee|dri-devel@lists.freedesktop |conselv...@gmail.com

Re: [PATCH] drm: Don't allow interruptions when opening debugfs/crc

2017-04-07 Thread Ville Syrjälä
On Fri, Apr 07, 2017 at 12:17:12PM +0100, Chris Wilson wrote: > The code does not like to be interrupted when waiting for the first > vblank after opening a debugfs/crc channel, so don't. > > [66285.716870] WARNING: CPU: 1 PID: 16615 at > drivers/gpu/drm/drm_debugfs_crc.c:185 crtc_crc_open+0x1d0/

Re: [PATCH 5/5] i915: fence workqueue optimization

2017-04-07 Thread Andrea Arcangeli
On Fri, Apr 07, 2017 at 10:58:38AM +0100, Chris Wilson wrote: > On Fri, Apr 07, 2017 at 01:23:47AM +0200, Andrea Arcangeli wrote: > > Insist to run llist_del_all() until the free_list is found empty, this > > may avoid having to schedule more workqueues. > > The work will already be scheduled (eve

[Bug 100611] [ALL][BAT][bisected] all systems on CI fails on certain test

2017-04-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100611 Petri Latvala changed: What|Removed |Added Assignee|conselv...@gmail.com|dri-devel@lists.freedesktop

[Bug 100611] [ALL][BAT][bisected] all systems on CI fails on certain test

2017-04-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100611 Petri Latvala changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 100611] [ALL][BAT][bisected] all systems on CI fails on certain test

2017-04-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100611 --- Comment #3 from Jani Saarinen --- Whilelisted on CI. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.freedesktop.org https://li

drm-tip/drm-tip boot: 78 boots: 1 failed, 77 passed (v4.11-rc5-1776-g5aa5296d0b57)

2017-04-07 Thread kernelci . org bot
drm-tip/drm-tip boot: 78 boots: 1 failed, 77 passed (v4.11-rc5-1776-g5aa5296d0b57) Full Boot Summary: https://kernelci.org/boot/all/job/drm-tip/branch/drm-tip/kernel/v4.11-rc5-1776-g5aa5296d0b57/ Full Build Summary: https://kernelci.org/build/drm-tip/branch/drm-tip/kernel/v4.11-rc5-1776-g5aa529

drm-tip/drm-tip build: 207 builds: 1 failed, 206 passed, 204 warnings (v4.11-rc5-1784-gc5d424760e9a)

2017-04-07 Thread kernelci . org bot
drm-tip/drm-tip build: 207 builds: 1 failed, 206 passed, 204 warnings (v4.11-rc5-1784-gc5d424760e9a) Full Build Summary: https://kernelci.org/build/drm-tip/branch/drm-tip/kernel/v4.11-rc5-1784-gc5d424760e9a/ Tree: drm-tip Branch: drm-tip Git Describe: v4.11-rc5-1784-gc5d424760e9a Git Commit: c5

Re: [PATCH 1/2] drm: dw-hdmi: add specific I2S and AHB functions for stream handling

2017-04-07 Thread Neil Armstrong
On 04/07/2017 04:19 PM, Romain Perier wrote: > Currently, CTS+N is forced to zero as a workaround of the IP block for > i.MX platforms. This is requested in the datasheet of the corresponding > IP for AHB mode only. However, we have seen that it introduces glitches > or delays when playing a sound

Re: [PATCH 2/2] drm: dw-hdmi: Gate audio clock from the I2S enablement callbacks

2017-04-07 Thread Neil Armstrong
On 04/07/2017 04:19 PM, Romain Perier wrote: > Currently, the audio sampler clock is enabled from dw_hdmi_setup() at > step E. and is kept enabled for later use. This clock should be enabled > and disabled along with the actual audio stream and not always on (that > is bad for PM). Futhermore, as d

Re: [PATCH v2 4/4] drm: zte: add VGA driver support

2017-04-07 Thread Sean Paul
On Fri, Apr 07, 2017 at 11:02:33AM +0800, Shawn Guo wrote: > On Thu, Apr 06, 2017 at 01:12:51PM -0400, Sean Paul wrote: > > On Thu, Apr 06, 2017 at 11:01:10PM +0800, Shawn Guo wrote: > > > +static int zx_vga_connector_get_modes(struct drm_connector *connector) > > > +{ > > > + struct zx_vga *vga =

drm-tip/drm-tip boot: 97 boots: 1 failed, 96 passed (v4.11-rc5-1777-gfdc0fa0d6347)

2017-04-07 Thread kernelci . org bot
drm-tip/drm-tip boot: 97 boots: 1 failed, 96 passed (v4.11-rc5-1777-gfdc0fa0d6347) Full Boot Summary: https://kernelci.org/boot/all/job/drm-tip/branch/drm-tip/kernel/v4.11-rc5-1777-gfdc0fa0d6347/ Full Build Summary: https://kernelci.org/build/drm-tip/branch/drm-tip/kernel/v4.11-rc5-1777-gfdc0fa

Re: [PATCH] drm/vmwgfx: Fix fbdev emulation using legacy functions

2017-04-07 Thread Daniel Vetter
On Fri, Apr 07, 2017 at 10:31:29AM +0200, Thomas Hellstrom wrote: > Hi, Daniel. > > It appears to work fine. Thanks! Oh sweet, tbh I didn't expect this kind of blind typing without a clear theory to work out so well :-) Did you test this with CONFIG_DEBUG_WW_MUTEX_SLOWPATH? Just to make sure I di

Re: [PATCH 2/5] i915: flush gem obj freeing workqueues to add accuracy to the i915 shrinker

2017-04-07 Thread Chris Wilson
On Fri, Apr 07, 2017 at 03:06:00PM +0200, Andrea Arcangeli wrote: > On Fri, Apr 07, 2017 at 11:02:11AM +0100, Chris Wilson wrote: > > On Fri, Apr 07, 2017 at 01:23:44AM +0200, Andrea Arcangeli wrote: > > > Waiting a RCU grace period only guarantees the work gets queued, but > > > until after the qu

drm-tip/drm-tip boot: 104 boots: 1 failed, 103 passed (v4.11-rc5-1780-g7373a000996b)

2017-04-07 Thread kernelci . org bot
drm-tip/drm-tip boot: 104 boots: 1 failed, 103 passed (v4.11-rc5-1780-g7373a000996b) Full Boot Summary: https://kernelci.org/boot/all/job/drm-tip/branch/drm-tip/kernel/v4.11-rc5-1780-g7373a000996b/ Full Build Summary: https://kernelci.org/build/drm-tip/branch/drm-tip/kernel/v4.11-rc5-1780-g7373

drm-tip/drm-tip build: 207 builds: 1 failed, 206 passed, 204 warnings (v4.11-rc5-1785-g5a74def41941)

2017-04-07 Thread kernelci . org bot
drm-tip/drm-tip build: 207 builds: 1 failed, 206 passed, 204 warnings (v4.11-rc5-1785-g5a74def41941) Full Build Summary: https://kernelci.org/build/drm-tip/branch/drm-tip/kernel/v4.11-rc5-1785-g5a74def41941/ Tree: drm-tip Branch: drm-tip Git Describe: v4.11-rc5-1785-g5a74def41941 Git Commit: 5a

drm-tip/drm-tip boot: 119 boots: 2 failed, 117 passed (v4.11-rc5-1782-g71610c69d4f3)

2017-04-07 Thread kernelci . org bot
drm-tip/drm-tip boot: 119 boots: 2 failed, 117 passed (v4.11-rc5-1782-g71610c69d4f3) Full Boot Summary: https://kernelci.org/boot/all/job/drm-tip/branch/drm-tip/kernel/v4.11-rc5-1782-g71610c69d4f3/ Full Build Summary: https://kernelci.org/build/drm-tip/branch/drm-tip/kernel/v4.11-rc5-1782-g7161

Re: [RFC PATCH 2/2] drm/vgem: Enable dmabuf import interfaces

2017-04-07 Thread Laura Abbott
On 04/07/2017 12:39 AM, Chris Wilson wrote: > On Thu, Apr 06, 2017 at 04:18:33PM -0700, Laura Abbott wrote: >> >> Enable the GEM dma-buf import interfaces in addition to the export >> interfaces. This lets vgem be used as a test source for other allocators >> (e.g. Ion). >> >> +int vgem_gem_get_pag

Re: DRM Display driver for Intel FPGA Video and Image Processing Suite

2017-04-07 Thread Daniel Vetter
On Thu, Apr 6, 2017 at 8:29 AM, Ong, Hean Loong wrote: > Hi All, > > Any comments for the patch below? Seems the same version that I already reviewed. My comment about not sending inline was more for the next version, especially once it's about applying the patch, attached patches are a bit of a

[PATCH 03/11] drm: parse ycbcr 420 vdb block

2017-04-07 Thread Shashank Sharma
From: Jose Abreu HDMI 2.0 spec adds support for ycbcr420 subsampled output. CEA-861-F adds two new blocks in EDID, to provide information about sink's support for ycbcr420 output. These new blocks are: - ycbcr420 video data (vdb) block: video modes which can be supported only in ycbcr420 outpu

[PATCH 02/11] drm/edid: Complete CEA modedb(VIC 1-107)

2017-04-07 Thread Shashank Sharma
CEA-861-F specs defines new video modes to be used with HDMI 2.0 EDIDs. The VIC range has been extended from 1-64 to 1-107. Our existing CEA modedb contains only 64 modes (VIC=1 to VIC=64). Now to be able to parse new CEA modes using the existing methods, we have to complete the modedb (VIC=65 onw

[PATCH 00/11] HDMI YCBCR output handling in DRM layer

2017-04-07 Thread Shashank Sharma
This patch series adds DRM layer support for YCBCR HDMI output handling. The target HDMI YCBCR outputs are: - YCBCR444 - YCBCR422 - YCBCR420 As YCBCR420 output is added in HDMI 2.0, this patch series also contain few patches to handle new EDID extention blocks, added for YCBCR420 modes (CEA-861-F)

[PATCH 01/11] drm: Add HDMI 2.0 VIC support for AVI info-frames

2017-04-07 Thread Shashank Sharma
HDMI 1.4b support the CEA video modes as per range of CEA-861-D (VIC 1-64). For any other mode, the VIC filed in AVI infoframes should be 0. HDMI 2.0 sinks, support video modes range as per CEA-861-F spec, which is extended to (VIC 1-107). This patch adds a bool input variable, which indicates if

[PATCH 09/11] drm/i915: handle csc for ycbcr HDMI output

2017-04-07 Thread Shashank Sharma
To support ycbcr HDMI output, we need a pipe CSC block to do the RGB->YCBCR conversion, as the blender output is in RGB. Current Intel platforms have only one pipe CSC unit, so we can either do color correction using it, or we can perform RGB->YCBCR conversion. This function adds a csc handler, t

[PATCH 10/11] drm/i915: prepare ycbcr420 modeset

2017-04-07 Thread Shashank Sharma
To get a ycbcr420 output from intel platforms, there are two major steps: - RGB->YCBCR conversion using a pipe CSC. - Program PIPE_MISC register to generate a ycbcr420 output. - Scaling down YCBCR444 samples to YCBCR420 samples using a pipe scaler. This patch: - Does scaler allocation for HDMI y

[PATCH 08/11] drm/i915: handle ycbcr outputs

2017-04-07 Thread Shashank Sharma
This patch adds support for HDMI ycbcr outputs in i915 layer. HDMI output mode is a connector property, this patch checks if source and sink can support the HDMI output type selected by user. And if they both can, it commits the hdmi output type into crtc state, for further staging in driver. Cc:

[PATCH 07/11] drm: set output colorspace in AVI infoframe

2017-04-07 Thread Shashank Sharma
HDMI source must set output colorspace information in AVI infoframes, so that the sink can decode upcoming frames accordingly. As this patch series is adding support for HDMI output modes other than RGB, this patch adds a function in DRM layer, to add the output colorspace information in the AVI i

[PATCH 11/11] drm/i915: set colorspace for ycbcr outputs

2017-04-07 Thread Shashank Sharma
When HDMI output is other than RGB, we have to load the corresponding colorspace of output mode. This patch fills the colorspace of AVI infoframe as per the HDMI output mode. Cc: Ville Syrjala Cc: Ander Conselvan De Oliveira Signed-off-by: Shashank Sharma --- drivers/gpu/drm/i915/intel_hdmi.c

[PATCH 04/11] drm: parse ycbcr420 vcb block

2017-04-07 Thread Shashank Sharma
HDMI 2.0 spec adds support for ycbcr420 subsampled output. CEA-861-F adds two new blocks in EDID, to provide information about sink's support for ycbcr420 output. One of these new blocks is: ycbcr420 vcb - ycbcr420 video capability data (vcb) block: video modes which can be support in ycbcr420 o

[PATCH 05/11] drm: parse ycbcr 420 deep color information

2017-04-07 Thread Shashank Sharma
CEA-861-F spec adds ycbcr420 deep color support information in hf-vsdb block. This patch extends the existing hf-vsdb parsing function by adding parsing of ycbcr420 deep color support from the EDID and adding it into display information stored. Cc: Ville Syrjälä Cc: Jose Abreu Signed-off-by: Sha

[PATCH 06/11] drm: create hdmi output property

2017-04-07 Thread Shashank Sharma
HDMI displays can support various output types, based on the color space and subsampling type. The possible outputs from a HDMI 2.0 monitor could be: - RGB - YCBCR 444 - YCBCR 422 - YCBCR 420 This patch adds a drm property, using which, a userspace can specify its preference, for the HDMI outp

Re: [PATCH] drm: Don't allow interruptions when opening debugfs/crc

2017-04-07 Thread Daniel Vetter
On Fri, Apr 07, 2017 at 01:55:00PM +0200, Tomeu Vizoso wrote: > On 04/07/2017 01:17 PM, Chris Wilson wrote: > > The code does not like to be interrupted when waiting for the first > > vblank after opening a debugfs/crc channel, so don't. > > > > [66285.716870] WARNING: CPU: 1 PID: 16615 at > > dr

[GIT PULL] mediatek-drm-next for 4.12

2017-04-07 Thread CK Hu
Hi, Dave: This series is MT2701 DRM support. The following changes since commit 0168778115687486575a6831df865dbc4f5369fe: Merge branch 'drm-next-4.12' of git://people.freedesktop.org/~agd5f/linux into drm-next (2017-04-07 05:49:12 +1000) are available in the git repository at: https://git

[PATCH] drm: Only take cursor locks when the cursor plane exists

2017-04-07 Thread Daniel Vetter
I thought I've fixed this, but maybe not. Anyway, clearly broken, and easy fix. Cc: Tony Lindgren Reported-by: Tony Lindgren Fixes: b95ff0319a82 ("drm: Remove drm_modeset_(un)lock_crtc") Cc: Harry Wentland Cc: Maarten Lankhorst Cc: Daniel Vetter Cc: Jani Nikula Cc: Sean Paul Cc: David Airli

Re: [RFC PATCH 2/2] drm/vgem: Enable dmabuf import interfaces

2017-04-07 Thread Chris Wilson
On Fri, Apr 07, 2017 at 09:18:30AM -0700, Laura Abbott wrote: > On 04/07/2017 12:39 AM, Chris Wilson wrote: > > On Thu, Apr 06, 2017 at 04:18:33PM -0700, Laura Abbott wrote: > >> > >> Enable the GEM dma-buf import interfaces in addition to the export > >> interfaces. This lets vgem be used as a tes

[PULL] drm-intel-next

2017-04-07 Thread Daniel Vetter
Hi Dave, drm-intel-next-2017-04-03: Last 4.12 feature pile: GVT updates: - Add mdev attribute group for per-vgpu info - Time slice based vGPU scheduling QoS support (Gao Ping) - Initial KBL support for E3 server (Han Xu) - other misc. i915: - lots and lots of small fixes and improvements all ove

Re: [Intel-gfx] [PATCH] drm: Only take cursor locks when the cursor plane exists

2017-04-07 Thread Daniel Stone
Reviewed-by: Daniel Stone [mobile email formatting apology here] On Fri, 7 Apr 2017 at 5:48 pm, Daniel Vetter wrote: > I thought I've fixed this, but maybe not. Anyway, clearly broken, and > easy fix. > > Cc: Tony Lindgren > Reported-by: Tony Lindgren > Fixes: b95ff0319a82 ("drm: Remove drm_

Re: [PATCH v3 8/9] drm/rockchip: gem: Don't alloc/free gem buf when dev_private is invalid

2017-04-07 Thread jeffy
Hi Daniel, On 04/07/2017 02:30 PM, Daniel Vetter wrote: On Thu, Apr 6, 2017 at 1:09 PM, jeffy wrote: On 04/06/2017 04:26 PM, Daniel Vetter wrote: On Wed, Apr 05, 2017 at 12:28:40PM -0400, Sean Paul wrote: On Wed, Apr 05, 2017 at 04:29:26PM +0800, Jeffy Chen wrote: After unbinding drm, t

drm_modeset_lock oops in next

2017-04-07 Thread Tony Lindgren
-- Internal error: Oops: 5 [#1] SMP ARM ... CPU: 1 PID: 1637 Comm: X Not tainted 4.11.0-rc5-next-20170407+ #488 Hardware name: Generic OMAP4 (Flattened Device Tree) task: ec873180 task.stack: ec8b8000 PC is at __ww_mutex_lock.constprop.0+0x34/0x1054 LR is at lock_is_held_type+0x60/0xa8 pc

Re: [PATCH 2/2] drm: dw-hdmi: Gate audio clock from the I2S enablement callbacks

2017-04-07 Thread Romain Perier
Hello, Le 07/04/2017 à 16:23, Neil Armstrong a écrit : > On 04/07/2017 04:19 PM, Romain Perier wrote: >> Currently, the audio sampler clock is enabled from dw_hdmi_setup() at >> step E. and is kept enabled for later use. This clock should be enabled >> and disabled along with the actual audio str

Re: [PATCH] drm: Only take cursor locks when the cursor plane exists

2017-04-07 Thread Tony Lindgren
* Daniel Vetter [170407 09:50]: > I thought I've fixed this, but maybe not. Anyway, clearly broken, and > easy fix. > > Cc: Tony Lindgren > Reported-by: Tony Lindgren > Fixes: b95ff0319a82 ("drm: Remove drm_modeset_(un)lock_crtc") > Cc: Harry Wentland > Cc: Maarten Lankhorst > Cc: Daniel Vett

Re: [PATCH v5 12/12] drm/drm_ioctl.c: Break ioctl when drm device not registered

2017-04-07 Thread jeffy
Hi Daniel, On 04/07/2017 03:16 PM, Daniel Vetter wrote: On Thu, Apr 06, 2017 at 08:31:25PM +0800, Jeffy Chen wrote: After unbinding drm, the user space may still owns the drm dev fd, and may still be able to call drm ioctl. Add a sanity check here to prevent that from happening. Signed-off-by

Re: [PATCH] format-security: move static strings to const

2017-04-07 Thread Kees Cook
On Thu, Apr 6, 2017 at 1:48 AM, Jani Nikula wrote: > On Thu, 06 Apr 2017, Kees Cook wrote: >> While examining output from trial builds with -Wformat-security enabled, >> many strings were found that should be defined as "const", or as a char >> array instead of char pointer. This makes some stati

[PATCH 2/5] i915: flush gem obj freeing workqueues to add accuracy to the i915 shrinker

2017-04-07 Thread Andrea Arcangeli
Waiting a RCU grace period only guarantees the work gets queued, but until after the queued workqueue returns, there's no guarantee the memory was actually freed. So flush the work to provide better guarantees to the reclaim code in addition of waiting a RCU grace period to pass. Signed-off-by: An

Re: Proposal for RandR version 1.6, Leases and EDID-based output grabs

2017-04-07 Thread Keith Packard
Michel Dänzer writes: > When no such special client (Steam?) is running, the desktop environment > will try to use the HMD anyway, right? So the expected use case would be > for the user to start a special client first and only plug in the HMD > afterwards? That seems a bit inconvenient. I'd lov

[PATCH] drm: dw-hdmi: Implement the mode_fixup drm helper

2017-04-07 Thread Romain Perier
This helper is supposed to validate or reject the modeline before it applied by the mode setting. Currently this function has been dropped, it was previously set to a dummy function that always returned true. For both cases, this means that userspace can ask for a bad modeline that will be always a

[PATCH 1/2] drm: dw-hdmi: add specific I2S and AHB functions for stream handling

2017-04-07 Thread Romain Perier
Currently, CTS+N is forced to zero as a workaround of the IP block for i.MX platforms. This is requested in the datasheet of the corresponding IP for AHB mode only. However, we have seen that it introduces glitches or delays when playing a sound on HDMI for I2S mode. This proves that we cannot keep

[PATCH 2/2] drm: dw-hdmi: Gate audio clock from the I2S enablement callbacks

2017-04-07 Thread Romain Perier
Currently, the audio sampler clock is enabled from dw_hdmi_setup() at step E. and is kept enabled for later use. This clock should be enabled and disabled along with the actual audio stream and not always on (that is bad for PM). Futhermore, as described by the datasheet, the I2S variant need to ga

[PATCH 0/2] drm: dw-hdmi: various improvements

2017-04-07 Thread Romain Perier
This set of patches split the stream handling functions in two parts. It introduces new callbacks that are specific to each variant, one for I2S and one for AHB. Then, as requested by the datasheet for the I2S variant, it adds support for gating the audio sampler clock when the audio stream is ena

Re: [PATCH] drm: dw-hdmi: Implement the mode_fixup drm helper

2017-04-07 Thread Archit Taneja
Hi, On 4/7/2017 5:47 PM, Romain Perier wrote: This helper is supposed to validate or reject the modeline before it applied by the mode setting. Currently this function has been dropped, it was previously set to a dummy function that always returned true. For both cases, this means that userspace

Re: [PATCH] drm: Only take cursor locks when the cursor plane exists

2017-04-07 Thread Sean Paul
On Fri, Apr 07, 2017 at 06:48:17PM +0200, Daniel Vetter wrote: > I thought I've fixed this, but maybe not. Anyway, clearly broken, and > easy fix. > > Cc: Tony Lindgren > Reported-by: Tony Lindgren > Fixes: b95ff0319a82 ("drm: Remove drm_modeset_(un)lock_crtc") > Cc: Harry Wentland > Cc: Maarte

Re: [PATCH] drm/vmwgfx: Fix fbdev emulation using legacy functions

2017-04-07 Thread Sean Paul
On Fri, Apr 07, 2017 at 10:31:29AM +0200, Thomas Hellstrom wrote: > Hi, Daniel. > > It appears to work fine. Thanks! > > Do you want to take it through drm-misc or want me to take it throuch > vmwgfx-next? Applied to drm-misc Thanks, Sean > > Reviewed-by: Thomas Hellstrom > /Thomas > > >

Re: [PATCH v5 00/12] drm: rockchip: Fix rockchip drm unbind crash error

2017-04-07 Thread Sean Paul
On Thu, Apr 06, 2017 at 08:31:13PM +0800, Jeffy Chen wrote: > > Verified on rk3399 chromebook kevin: > 1/ stop ui && pkill -9 frecon > 2/ unbind/bind drm > > Changes in v5: > Fix wrong git account. > > Changes in v4: > Address Andrzej Hajda 's comments. > > Changes in v3: > Update commit messag

Re: [PATCH] drm: panels: Add MAINTAINERS entry for LVS panel driver

2017-04-07 Thread Thierry Reding
On Fri, Apr 07, 2017 at 05:44:15AM +1000, Dave Airlie wrote: > On 5 April 2017 at 16:51, Laurent Pinchart > wrote: > > As the DRM LVDS panel driver uses a different approach to DT bindings > > compared to what Thierry Reding advocates, add a specific MAINTAINERS > > entry to avoid bothering Thierr

drm-tip/drm-tip boot: 118 boots: 1 failed, 116 passed with 1 offline (v4.11-rc5-1784-gc5d424760e9a)

2017-04-07 Thread kernelci . org bot
drm-tip/drm-tip boot: 118 boots: 1 failed, 116 passed with 1 offline (v4.11-rc5-1784-gc5d424760e9a) Full Boot Summary: https://kernelci.org/boot/all/job/drm-tip/branch/drm-tip/kernel/v4.11-rc5-1784-gc5d424760e9a/ Full Build Summary: https://kernelci.org/build/drm-tip/branch/drm-tip/kernel/v4.11

drm-tip/drm-tip build: 207 builds: 1 failed, 206 passed, 204 warnings (v4.11-rc5-1786-g50ff2d4f1de4)

2017-04-07 Thread kernelci . org bot
drm-tip/drm-tip build: 207 builds: 1 failed, 206 passed, 204 warnings (v4.11-rc5-1786-g50ff2d4f1de4) Full Build Summary: https://kernelci.org/build/drm-tip/branch/drm-tip/kernel/v4.11-rc5-1786-g50ff2d4f1de4/ Tree: drm-tip Branch: drm-tip Git Describe: v4.11-rc5-1786-g50ff2d4f1de4 Git Commit: 50

Re: [GIT PULL FOR v4.12] Renesas R-Car Gen3 DU HDMI support

2017-04-07 Thread Thierry Reding
On Tue, Apr 04, 2017 at 06:03:13PM +0200, Daniel Vetter wrote: > On Tue, Apr 04, 2017 at 06:38:15PM +0300, Laurent Pinchart wrote: > > Hi Thierry, > > > > On Tuesday 04 Apr 2017 17:21:47 Thierry Reding wrote: > > > On Tue, Apr 04, 2017 at 05:17:44PM +0300, Laurent Pinchart wrote: > > > > Hi Dave,

Re: [RFC PATCH 2/2] drm/vgem: Enable dmabuf import interfaces

2017-04-07 Thread Laura Abbott
On 04/07/2017 09:58 AM, Chris Wilson wrote: > On Fri, Apr 07, 2017 at 09:18:30AM -0700, Laura Abbott wrote: >> On 04/07/2017 12:39 AM, Chris Wilson wrote: >>> On Thu, Apr 06, 2017 at 04:18:33PM -0700, Laura Abbott wrote: Enable the GEM dma-buf import interfaces in addition to the export >

Re: [PATCH] drm: dw-hdmi: Implement the mode_fixup drm helper

2017-04-07 Thread Daniel Vetter
On Fri, Apr 7, 2017 at 7:15 PM, Archit Taneja wrote: > On 4/7/2017 5:47 PM, Romain Perier wrote: >> >> This helper is supposed to validate or reject the modeline before it >> applied by the mode setting. Currently this function has been dropped, >> it was previously set to a dummy function that al

Re: [PATCH] drm: dw-hdmi: Implement the mode_fixup drm helper

2017-04-07 Thread Daniel Vetter
On Fri, Apr 07, 2017 at 02:17:43PM +0200, Romain Perier wrote: > This helper is supposed to validate or reject the modeline before it > applied by the mode setting. Currently this function has been dropped, > it was previously set to a dummy function that always returned true. For > both cases, thi

Re: [PATCH v5 12/12] drm/drm_ioctl.c: Break ioctl when drm device not registered

2017-04-07 Thread Daniel Vetter
On Fri, Apr 07, 2017 at 05:24:59PM +0800, jeffy wrote: > Hi Daniel, > > On 04/07/2017 03:16 PM, Daniel Vetter wrote: > > On Thu, Apr 06, 2017 at 08:31:25PM +0800, Jeffy Chen wrote: > > > After unbinding drm, the user space may still owns the drm dev fd, > > > and may still be able to call drm ioct

  1   2   >