[GIT PULL] exynos-drm-fixes

2017-03-21 Thread Inki Dae
Hi Dave, Just several fixups, - fix page fault and vblank timeout issues due to delayed vblank handling. - fix panel driver probing to fail without te-gpios property. - fix potential security hole by using "%pK" format. - fix wrong if statement condition. And one cleanup which r

Re: [PATCH v3 3/3] drm: Clarify the role of plane_state argument to drm_simple update().

2017-03-21 Thread Daniel Vetter
On Mon, Mar 20, 2017 at 04:36:15PM -0700, Eric Anholt wrote: > Like the atomic update hook it's wrapping, the plane_state is the old > one, and the new one is in plane->state. Both msxfb and tinydrm use > it correctly, but I mistook it for the new state in pl111 due to its > naming. > > Signed-of

[Bug 99403] Graphical glitches in witcher-1 with wine nine and r600g (rv740).

2017-03-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99403 --- Comment #1 from ilia --- Experienced the same problem on stock mesa from https://launchpad.net/~inferrna/+archive/ubuntu/featured-mesa/ (nine enabled) and wine from commendsarnex ppa. -- You are receiving this mail because: You are the assi

Re: [PATCH v2 2/2] drm/omap: Major omap_modeset_init() cleanup

2017-03-21 Thread Tomi Valkeinen
On 20/03/17 18:06, Jyri Sarha wrote: > Cleanup overly complex omap_modeset_init(). The function is trying to > support many unusual configuration, that have never been tested and > are not supported by other parts of the dirver. > > After cleanup the init function creates exactly one connector, >

Re: [PATCH] drm: bridge: dw-hdmi: add HDMI vendor specific infoframe config

2017-03-21 Thread Andrzej Hajda
On 20.03.2017 07:10, Nickey Yang wrote: > Vendor specific infoframe is mandatory for 4K2K resolution. > Without this, the HDMI protocol compliance fails. > > Signed-off-by: Nickey Yang > --- > drivers/gpu/drm/bridge/dw-hdmi.c | 50 > > drivers/gpu/drm/bri

Re: [PATCH v2] drm/bridge: dw_hdmi: support i2c extended read mode

2017-03-21 Thread Archit Taneja
On 03/20/2017 08:27 AM, Nickey Yang wrote: "I2C Master Interface Extended Read Mode" implements a segment pointer-based read operation using the Special Register configuration. This patch fix https://patchwork.kernel.org/patch/7098101/ mentioned "The current implementation does not support "I2

Re: [PATCH] drm: bridge: dw-hdmi: add HDMI vendor specific infoframe config

2017-03-21 Thread Archit Taneja
On 03/21/2017 01:17 PM, Andrzej Hajda wrote: On 20.03.2017 07:10, Nickey Yang wrote: Vendor specific infoframe is mandatory for 4K2K resolution. Without this, the HDMI protocol compliance fails. Signed-off-by: Nickey Yang --- drivers/gpu/drm/bridge/dw-hdmi.c | 50 +++

[PATCH 2/2] gpu: host1x: Support module reset

2017-03-21 Thread Thierry Reding
From: Thierry Reding Newer versions of Tegra come with early boot software that aggressively puts various modules in reset. Add support to the host1x driver to take the module out of reset on probe, and assert reset on removal. Signed-off-by: Thierry Reding --- drivers/gpu/host1x/dev.c | 18 ++

[PATCH 1/2] gpu: host1x: Sort includes alphabetically

2017-03-21 Thread Thierry Reding
From: Thierry Reding Sorting includes alphabetically makes it easier and less conflict-prone to add new includes subsequently. Signed-off-by: Thierry Reding --- drivers/gpu/host1x/dev.c | 12 ++-- drivers/gpu/host1x/dev.h | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff

[PATCH v3 02/10] drm/fb-helper: Reshuffle code for subsequent patches

2017-03-21 Thread Thierry Reding
From: Thierry Reding An unlocked version of the drm_fb_helper_add_one_connector() function will be added in a subsequent patch. Reshuffle the code separately to make the diff more readable later on. Tested-by: John Stultz Signed-off-by: Thierry Reding --- drivers/gpu/drm/drm_fb_helper.c | 59

[PATCH v3 01/10] drm/fb-helper: Cleanup checkpatch warnings

2017-03-21 Thread Thierry Reding
From: Thierry Reding Fix up a couple of checkpatch warnings, such as whitespace or coding style issues. Tested-by: John Stultz Signed-off-by: Thierry Reding --- drivers/gpu/drm/drm_fb_helper.c | 54 - 1 file changed, 32 insertions(+), 22 deletions(-) d

[PATCH v3 04/10] drm/fb-helper: Push down modeset lock into FB helpers

2017-03-21 Thread Thierry Reding
From: Thierry Reding Move the modeset locking from drivers into FB helpers. Tested-by: John Stultz Signed-off-by: Thierry Reding --- drivers/gpu/drm/drm_fb_helper.c| 39 -- drivers/gpu/drm/i915/intel_dp_mst.c| 3 --- drivers/gpu/drm/radeon/radeon_d

[PATCH v3 00/10] drm/fb-helper: Deferred setup support

2017-03-21 Thread Thierry Reding
From: Thierry Reding This set of patches adds support for deferring FB helper setup, which is useful to obtain a sane configuration even when no outputs are available during probe. One example is HDMI, where fbdev will currently fallback to a 1024x786 resolution if no monitor is connected, and w

[PATCH v3 07/10] drm/exynos: Remove custom FB helper deferred setup

2017-03-21 Thread Thierry Reding
From: Thierry Reding The FB helper core now supports deferred setup, so the driver's custom implementation can be removed. Signed-off-by: Thierry Reding --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 6 -- drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 2 -- 2 files changed, 4 insertions(+),

[PATCH v3 05/10] drm/fb-helper: Add top-level lock

2017-03-21 Thread Thierry Reding
From: Thierry Reding Introduce a new top-level lock for the FB helper code. This will allow better locking granularity and avoid the need to abuse modeset locking for this purpose instead. Tested-by: John Stultz Signed-off-by: Thierry Reding --- drivers/gpu/drm/drm_fb_helper.c | 27 ++

[PATCH v3 06/10] drm/fb-helper: Support deferred setup

2017-03-21 Thread Thierry Reding
From: Thierry Reding FB helper code falls back to a 1024x768 mode if no outputs are connected or don't report back any modes upon initialization. This can be annoying because outputs that are added to FB helper later on can't be used with FB helper if they don't support a matching mode. The fall

[PATCH v3 08/10] drm/hisilicon: Remove custom FB helper deferred setup

2017-03-21 Thread Thierry Reding
From: Thierry Reding The FB helper core now supports deferred setup, so the driver's custom implementation can be removed. Signed-off-by: Thierry Reding --- drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git

[PATCH v3 03/10] drm/fb-helper: Improve code readability

2017-03-21 Thread Thierry Reding
From: Thierry Reding Add a couple of temporary variables and use shorter names for existing variables in drm_fb_helper_add_one_connector() for better readability. Tested-by: John Stultz Signed-off-by: Thierry Reding --- drivers/gpu/drm/drm_fb_helper.c | 25 - 1 file ch

[PATCH v3 09/10] drm/atmel-hlcdc: Remove unnecessary NULL check

2017-03-21 Thread Thierry Reding
From: Thierry Reding drm_fbdev_cma_hotplug_event() already checks for NULL pointers before dereferencing, so callers don't need to do that. Signed-off-by: Thierry Reding --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drive

[PATCH v3 10/10] drm/rockchip: Remove unnecessary NULL check

2017-03-21 Thread Thierry Reding
From: Thierry Reding The expression &private->fbdev_helper can never be NULL, so the check is completely unnecessary. Signed-off-by: Thierry Reding --- drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/rockchip/roc

Re: [PATCH] drm/i915: use static const array for PICK macro

2017-03-21 Thread Jani Nikula
On Mon, 20 Mar 2017, Arnd Bergmann wrote: > The varargs macro trick in _PIPE3/_PHY3/_PORT3 was meant as an optimization > to shrink the i915 kernel module by around 1000 bytes. Really, I didn't care one bit about the size shrink, I only cared about making it easier and less error prone to increas

Re: [PATCH] drm/i915: use static const array for PICK macro

2017-03-21 Thread Arnd Bergmann
On Tue, Mar 21, 2017 at 9:26 AM, Jani Nikula wrote: > On Mon, 20 Mar 2017, Arnd Bergmann wrote: >> The varargs macro trick in _PIPE3/_PHY3/_PORT3 was meant as an optimization >> to shrink the i915 kernel module by around 1000 bytes. > > Really, I didn't care one bit about the size shrink, I only

Re: [PATCH v2] drm/exynos/dsi: make te-gpios optional

2017-03-21 Thread Andrzej Hajda
On 21.03.2017 06:10, Inki Dae wrote: > > 2017년 03월 15일 20:20에 Andrzej Hajda 이(가) 쓴 글: >> DSI forwards te-gpios interrupts to display controller, but if display >> controller works in HW-TRIGGER mode this interrupt is not necessary. >> Making te-gpios property optional allows to avoid generating spa

[PATCH] drm: zte: remove leftover 'inf' from struct zx_hdmi

2017-03-21 Thread Shawn Guo
From: Shawn Guo There is a leftover 'inf' field in struct zx_hdmi from commit '831a8d5e0bef ("drm: zte: move struct vou_inf into zx_vou driver")'. Remove it. Signed-off-by: Shawn Guo --- drivers/gpu/drm/zte/zx_hdmi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/zte/zx_hdm

[Bug 100270] power usage increase by approx 4W between kernel 4.7.8 and 4.8.5

2017-03-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100270 brett.hass...@gmail.com changed: What|Removed |Added Component|DRM/other |DRM/Radeon --- Comment #5 from

Re: [Intel-gfx] [PATCH v3 01/10] drm/fb-helper: Cleanup checkpatch warnings

2017-03-21 Thread Daniel Vetter
On Tue, Mar 21, 2017 at 09:13:49AM +0100, Thierry Reding wrote: > From: Thierry Reding > > Fix up a couple of checkpatch warnings, such as whitespace or coding > style issues. > > Tested-by: John Stultz > Signed-off-by: Thierry Reding Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/drm_

Re: [Intel-gfx] [PATCH v3 02/10] drm/fb-helper: Reshuffle code for subsequent patches

2017-03-21 Thread Daniel Vetter
On Tue, Mar 21, 2017 at 09:13:50AM +0100, Thierry Reding wrote: > From: Thierry Reding > > An unlocked version of the drm_fb_helper_add_one_connector() function > will be added in a subsequent patch. Reshuffle the code separately to > make the diff more readable later on. > > Tested-by: John Stu

Re: [PATCH v3 03/10] drm/fb-helper: Improve code readability

2017-03-21 Thread Daniel Vetter
On Tue, Mar 21, 2017 at 09:13:51AM +0100, Thierry Reding wrote: > From: Thierry Reding > > Add a couple of temporary variables and use shorter names for existing > variables in drm_fb_helper_add_one_connector() for better readability. > > Tested-by: John Stultz > Signed-off-by: Thierry Reding

Re: [Intel-gfx] [PATCH v3 04/10] drm/fb-helper: Push down modeset lock into FB helpers

2017-03-21 Thread Daniel Vetter
On Tue, Mar 21, 2017 at 09:13:52AM +0100, Thierry Reding wrote: > From: Thierry Reding > > Move the modeset locking from drivers into FB helpers. > > Tested-by: John Stultz > Signed-off-by: Thierry Reding Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/drm_fb_helper.c| 39 > +++

Re: [PATCHv2 00/10] Nokia N950 basic display support

2017-03-21 Thread Tomi Valkeinen
On 20/03/17 13:29, Tomi Valkeinen wrote: > Hi, > > On 05/03/17 01:50, Sebastian Reichel wrote: >> Hi, >> >> Some of you may remember, that I sent a series for the N950 display >> some time ago. N950 has command mode DSI panel, so the main part of >> the patchset takes care of adding manual display

Re: [PATCHv2 00/10] Nokia N950 basic display support

2017-03-21 Thread Tomi Valkeinen
On 21/03/17 11:38, Tomi Valkeinen wrote: > On 20/03/17 13:29, Tomi Valkeinen wrote: >> Hi, >> >> On 05/03/17 01:50, Sebastian Reichel wrote: >>> Hi, >>> >>> Some of you may remember, that I sent a series for the N950 display >>> some time ago. N950 has command mode DSI panel, so the main part of >>

Re: [PATCH v3 07/10] drm/exynos: Remove custom FB helper deferred setup

2017-03-21 Thread Andrzej Hajda
On 21.03.2017 09:13, Thierry Reding wrote: > From: Thierry Reding > > The FB helper core now supports deferred setup, so the driver's custom > implementation can be removed. > > Signed-off-by: Thierry Reding > --- > drivers/gpu/drm/exynos/exynos_drm_drv.c | 6 -- > drivers/gpu/drm/exynos/e

Re: [PATCH 2/3] drm/i915: split out check for noncontiguous pfn range

2017-03-21 Thread Chris Wilson
On Mon, Mar 20, 2017 at 10:40:28AM +0100, Arnd Bergmann wrote: > We get a warning with gcc-7 about a pointless comparison when > using a linear memmap: > > drivers/gpu/drm/i915/selftests/scatterlist.c: In function 'alloc_table': > drivers/gpu/drm/i915/selftests/scatterlist.c:219:66: error: self-co

Re: [PATCH v3 05/10] drm/fb-helper: Add top-level lock

2017-03-21 Thread Daniel Vetter
On Tue, Mar 21, 2017 at 09:13:53AM +0100, Thierry Reding wrote: > From: Thierry Reding > > Introduce a new top-level lock for the FB helper code. This will allow > better locking granularity and avoid the need to abuse modeset locking > for this purpose instead. > > Tested-by: John Stultz > Sig

Re: [PATCH v3 06/10] drm/fb-helper: Support deferred setup

2017-03-21 Thread Daniel Vetter
On Tue, Mar 21, 2017 at 09:13:54AM +0100, Thierry Reding wrote: > From: Thierry Reding > > FB helper code falls back to a 1024x768 mode if no outputs are connected > or don't report back any modes upon initialization. This can be annoying > because outputs that are added to FB helper later on can

Re: [PATCH v3 05/10] drm/fb-helper: Add top-level lock

2017-03-21 Thread Daniel Vetter
On Tue, Mar 21, 2017 at 11:00:23AM +0100, Daniel Vetter wrote: > On Tue, Mar 21, 2017 at 09:13:53AM +0100, Thierry Reding wrote: > > From: Thierry Reding > > > > Introduce a new top-level lock for the FB helper code. This will allow > > better locking granularity and avoid the need to abuse modes

Re: [PATCH 1/3] drm/i915: allocate mock file pointer dynamically

2017-03-21 Thread Chris Wilson
On Mon, Mar 20, 2017 at 10:40:27AM +0100, Arnd Bergmann wrote: > A struct file is a bit too large to put on the kernel stack in general > and triggers a warning for low settings of CONFIG_FRAME_WARN: > > drivers/gpu/drm/i915/selftests/mock_drm.c: In function 'mock_file': > drivers/gpu/drm/i915/sel

Re: [PATCH v3 07/10] drm/exynos: Remove custom FB helper deferred setup

2017-03-21 Thread Daniel Vetter
On Tue, Mar 21, 2017 at 10:58:43AM +0100, Andrzej Hajda wrote: > On 21.03.2017 09:13, Thierry Reding wrote: > > From: Thierry Reding > > > > The FB helper core now supports deferred setup, so the driver's custom > > implementation can be removed. > > > > Signed-off-by: Thierry Reding > > --- > >

Re: [Intel-gfx] [PATCH 2/3] drm/i915: split out check for noncontiguous pfn range

2017-03-21 Thread Chris Wilson
On Tue, Mar 21, 2017 at 09:56:52AM +, Chris Wilson wrote: > On Mon, Mar 20, 2017 at 10:40:28AM +0100, Arnd Bergmann wrote: > > We get a warning with gcc-7 about a pointless comparison when > > using a linear memmap: > > > > drivers/gpu/drm/i915/selftests/scatterlist.c: In function 'alloc_table

Re: [PATCH v3 10/10] drm/rockchip: Remove unnecessary NULL check

2017-03-21 Thread Daniel Vetter
On Tue, Mar 21, 2017 at 09:13:58AM +0100, Thierry Reding wrote: > From: Thierry Reding > > The expression &private->fbdev_helper can never be NULL, so the check is > completely unnecessary. > > Signed-off-by: Thierry Reding On the 3 drivers patches (all except exynos): Reviewed-by: Daniel Vet

Re: [PATCH v2 0/2] drm/omapdrm: Remove CONFIG_DRM_OMAP_NUM_CRTCS and cleanup

2017-03-21 Thread Daniel Vetter
On Mon, Mar 20, 2017 at 06:06:37PM +0200, Jyri Sarha wrote: > The first patch removes CONFIG_DRM_OMAP_NUM_CRTCS config option. The > rest cleans up the unnecessary complexity from omap_modeset_init(). > > Changes since first version: > - drm/omapdrm: Get rid of DRM_OMAP_NUM_CRTCS config option >

Re: [Intel-gfx] [PATCH] drm/i915: use static const array for PICK macro

2017-03-21 Thread Daniel Vetter
On Tue, Mar 21, 2017 at 09:44:07AM +0100, Arnd Bergmann wrote: > On Tue, Mar 21, 2017 at 9:26 AM, Jani Nikula > wrote: > > On Mon, 20 Mar 2017, Arnd Bergmann wrote: > >> The varargs macro trick in _PIPE3/_PHY3/_PORT3 was meant as an optimization > >> to shrink the i915 kernel module by around 100

Re: [PATCH v3 07/10] drm/exynos: Remove custom FB helper deferred setup

2017-03-21 Thread Andrzej Hajda
On 21.03.2017 11:20, Daniel Vetter wrote: > On Tue, Mar 21, 2017 at 10:58:43AM +0100, Andrzej Hajda wrote: >> On 21.03.2017 09:13, Thierry Reding wrote: >>> From: Thierry Reding >>> >>> The FB helper core now supports deferred setup, so the driver's custom >>> implementation can be removed. >>> >>

[Bug 92248] [KBL/SKL/BYT/BXT] igt/kms_plane_scaling fail

2017-03-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92248 --- Comment #31 from Rami --- Still reproduced on SKL and BXT with last setup: kernel:drm-tip: 2017y-03m-15d-21h-47m-56s UTC integration manifest commit: d7cb114e1327b50c609ee6e67122cc0293ea515f author: Chris Wilson authored_date: Wed Mar

Re: [PATCH v3 07/10] drm/exynos: Remove custom FB helper deferred setup

2017-03-21 Thread Thierry Reding
On Tue, Mar 21, 2017 at 11:42:21AM +0100, Andrzej Hajda wrote: > On 21.03.2017 11:20, Daniel Vetter wrote: > > On Tue, Mar 21, 2017 at 10:58:43AM +0100, Andrzej Hajda wrote: > >> On 21.03.2017 09:13, Thierry Reding wrote: > >>> From: Thierry Reding > >>> > >>> The FB helper core now supports defer

Re: [PATCH v3 10/10] drm/rockchip: Remove unnecessary NULL check

2017-03-21 Thread Thierry Reding
On Tue, Mar 21, 2017 at 11:27:04AM +0100, Daniel Vetter wrote: > On Tue, Mar 21, 2017 at 09:13:58AM +0100, Thierry Reding wrote: > > From: Thierry Reding > > > > The expression &private->fbdev_helper can never be NULL, so the check is > > completely unnecessary. > > > > Signed-off-by: Thierry Re

Re: [PATCH v3 07/10] drm/exynos: Remove custom FB helper deferred setup

2017-03-21 Thread Andrzej Hajda
On 21.03.2017 11:53, Thierry Reding wrote: > On Tue, Mar 21, 2017 at 11:42:21AM +0100, Andrzej Hajda wrote: >> On 21.03.2017 11:20, Daniel Vetter wrote: >>> On Tue, Mar 21, 2017 at 10:58:43AM +0100, Andrzej Hajda wrote: On 21.03.2017 09:13, Thierry Reding wrote: > From: Thierry Reding >>>

Re: [PATCH v3 07/10] drm/exynos: Remove custom FB helper deferred setup

2017-03-21 Thread Thierry Reding
On Tue, Mar 21, 2017 at 12:13:26PM +0100, Andrzej Hajda wrote: > On 21.03.2017 11:53, Thierry Reding wrote: > > On Tue, Mar 21, 2017 at 11:42:21AM +0100, Andrzej Hajda wrote: > >> On 21.03.2017 11:20, Daniel Vetter wrote: > >>> On Tue, Mar 21, 2017 at 10:58:43AM +0100, Andrzej Hajda wrote: > O

[PATCH] drm/atomic: Introduce drm_atomic_helper_shutdown

2017-03-21 Thread Daniel Vetter
The trouble here is that it does multiple atomic commits under one drm_modeset_lock_all, which breaks the behind-the-scenes acquire context magic that function pulls off. It's much better to have one overall atomic commit. That we still have multiple atomic commits prevents us from adding some pret

Re: [Intel-gfx] [PATCH] drm/i915: use static const array for PICK macro

2017-03-21 Thread Jani Nikula
On Tue, 21 Mar 2017, Daniel Vetter wrote: > On Tue, Mar 21, 2017 at 09:44:07AM +0100, Arnd Bergmann wrote: >> On Tue, Mar 21, 2017 at 9:26 AM, Jani Nikula >> wrote: >> > On Mon, 20 Mar 2017, Arnd Bergmann wrote: >> >> The varargs macro trick in _PIPE3/_PHY3/_PORT3 was meant as an >> >> optimiza

[PATCH 1/4] drm: zte: do not enable clock auto-gating by default

2017-03-21 Thread Shawn Guo
From: Shawn Guo Some VOU modules do not work well with clock auto-gating. For example, VGA I2C bus will fail to read EDID data from monitor. Let's not enable this feature by default, and leave it to the possible future low-power optimization. Signed-off-by: Shawn Guo --- drivers/gpu/drm/zte/

[PATCH 2/4] drm: zte: move CSC register definitions into a common header

2017-03-21 Thread Shawn Guo
From: Shawn Guo The CSC (Color Space Conversion) block in VOU is used by not only Graphic Layer (plane) but also channel (CRTC) module. Let's move its register definitions into a common header, so that CRTC driver can include it when needed. Signed-off-by: Shawn Guo --- drivers/gpu/drm/zte/zx

[PATCH 0/4] Add ZTE VGA driver support

2017-03-21 Thread Shawn Guo
From: Shawn Guo The series adds the driver for ZTE VGA device, which becomes the third VOU output device we support, besides the existing HDMI and TV Encoder. Shawn Guo (4): drm: zte: do not enable clock auto-gating by default drm: zte: move CSC register definitions into a common header dt

[PATCH 3/4] dt: add bindings for ZTE VGA device

2017-03-21 Thread Shawn Guo
From: Shawn Guo It adds bindings doc for ZTE VOU VGA output device. Signed-off-by: Shawn Guo --- .../devicetree/bindings/display/zte,vou.txt | 21 + 1 file changed, 21 insertions(+) diff --git a/Documentation/devicetree/bindings/display/zte,vou.txt b/Documentation

[PATCH 4/4] drm: zte: add VGA driver support

2017-03-21 Thread Shawn Guo
From: Shawn Guo It adds VGA driver support, which needs to configure corresponding VOU interface in RGB_888 format, and thus the following changes are needed on zx_vou. - Rename the CSC block of Graphic Layer a bit to make it more specific, and add CSC of Channel to support RGB output. - Bypas

Re: [PATCH v3 07/10] drm/exynos: Remove custom FB helper deferred setup

2017-03-21 Thread Daniel Vetter
On Tue, Mar 21, 2017 at 12:13:26PM +0100, Andrzej Hajda wrote: > On 21.03.2017 11:53, Thierry Reding wrote: > > On Tue, Mar 21, 2017 at 11:42:21AM +0100, Andrzej Hajda wrote: > >> On 21.03.2017 11:20, Daniel Vetter wrote: > >>> On Tue, Mar 21, 2017 at 10:58:43AM +0100, Andrzej Hajda wrote: > O

Re: [PATCH] drm/atomic: Introduce drm_atomic_helper_shutdown

2017-03-21 Thread Noralf Trønnes
Den 21.03.2017 12.22, skrev Daniel Vetter: The trouble here is that it does multiple atomic commits under one drm_modeset_lock_all, which breaks the behind-the-scenes acquire context magic that function pulls off. It's much better to have one overall atomic commit. That we still have multiple at

Re: [regression] Re: 4.11-rc0, thinkpad x220: GPU hang

2017-03-21 Thread Pavel Machek
Hi! > > > > > > mplayer stopped working after a while. Dmesg says: > > > > > > > > > > > > [ 3000.266533] cdc_ether 2-1.2:1.0 usb0: register 'cdc_ether' at > > > > > > > > Now I'm pretty sure it is a regression in v4.11-rc0. Any ideas what to > > > > try? Bisect will be slow and nasty :-(. > > >

[PATCH] gpu: ipu-v3: add DRM dependency

2017-03-21 Thread Arnd Bergmann
The new PRE/PRG driver code causes a link failure when DRM is disabled: drivers/gpu/ipu-v3/ipu-pre.o: In function `ipu_pre_configure': ipu-pre.c:(.text.ipu_pre_configure+0x18): undefined reference to `drm_format_info' drivers/gpu/ipu-v3/ipu-prg.o: In function `ipu_prg_format_supported': ipu-prg.c

[Bug 100242] radeon buffer allocation failure during startup of Factorio

2017-03-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100242 tnmailingli...@gmail.com changed: What|Removed |Added Resolution|NOTOURBUG |--- Status|RESOLV

Re: [RFC libdrm 0/2] Replace the build system with meson

2017-03-21 Thread Jani Nikula
On Thu, 16 Mar 2017, Dylan Baker wrote: > First it's written in python, [...] How does meson handle python 2 vs. 3? How do you avoid issues in the build files wrt this? On Debian meson seems to depend on python 3, so are they fully python 3? How does meson handle build file backwards compatibili

[PATCH v3 5/5] drm/omap: Major omap_modeset_init() cleanup

2017-03-21 Thread Jyri Sarha
Cleanup overly complex omap_modeset_init(). The function is trying to support many unusual configuration, that have never been tested and are not supported by other parts of the dirver. After cleanup the init function creates exactly one connector, encoder, crtc, and primary plane per each connect

[PATCH v3 4/5] drm/omap: Remove the obsolete #define omap_plane _omap_plane hack

2017-03-21 Thread Jyri Sarha
Remove the obsolete "#define omap_plane _omap_plane" hack and other related hacks to get around the enum omap_plane colliding with struct omap_plane. Signed-off-by: Jyri Sarha --- drivers/gpu/drm/omapdrm/omap_plane.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/driv

[PATCH v3 3/5] drm/omap: Fix ugliest indentation style breaks from previous patch

2017-03-21 Thread Jyri Sarha
Fix the most ugly indentation style breaks left by the previous coccilnelle patch. Signed-off-by: Jyri Sarha --- drivers/gpu/drm/omapdrm/dss/dispc.c | 5 ++--- drivers/gpu/drm/omapdrm/dss/omapdss.h | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/d

[PATCH v3 0/5] drm/omap: Remove CONFIG_DRM_OMAP_NUM_CRTCS and cleanup

2017-03-21 Thread Jyri Sarha
The first patch removes CONFIG_DRM_OMAP_NUM_CRTCS config option. The patches number 2-4 gets rid of annoying name collision between dss backend and omapdrm. The last patch cleans up the unnecessary complexity from omap_modeset_init(). Changes since v2: - drm/omap: Get rid of DRM_OMAP_NUM_CRTCS con

[Bug 100303] Adding a single, meaningless if-else to a shader source leads to different image

2017-03-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100303 Bug ID: 100303 Summary: Adding a single, meaningless if-else to a shader source leads to different image Product: Mesa Version: git Hardware: x86-64 (AMD64)

[PATCH v3 2/5] drm/omap: Rename enum omap_plane to enum omap_plane_id

2017-03-21 Thread Jyri Sarha
The enum omap_plane conflicted with the same struct name for omapdrm plane private data. This rename should solve the conflict. The rename was implement with this very simple coccinelle patch: @@ @@ enum -omap_plane +omap_plane_id The patch was app

[PATCH v3 1/5] drm/omap: Get rid of DRM_OMAP_NUM_CRTCS config option

2017-03-21 Thread Jyri Sarha
Allocate one CRTC for each connected output and get rid of DRM_OMAP_NUM_CRTCS config option. We still can not create more CRTCs than we have DSS display managers. We also reserve one overlay per CRTC for primary plane so we can not have more CRTCs than we have overlays either. Signed-off-by: Jyri

[PATCH v4 5/6] drm: bridge: dw-hdmi: Add Documentation on supported input formats

2017-03-21 Thread Neil Armstrong
This patch adds a new DRM documentation entry and links to the input format table added in the dw_hdmi header. Signed-off-by: Neil Armstrong --- Documentation/gpu/bridge/dw-hdmi.rst | 15 +++ Documentation/gpu/index.rst | 1 + 2 files changed, 16 insertions(+) create mode

[PATCH v4 2/6] media: uapi: Add RGB and YUV bus formats for Synopsys HDMI TX Controller

2017-03-21 Thread Neil Armstrong
In order to describe the RGB and YUV bus formats used to feed the Synopsys DesignWare HDMI TX Controller, add missing formats to the list of Bus Formats. Documentation for these formats is added in a separate patch. Reviewed-by: Archit Taneja Signed-off-by: Neil Armstrong --- include/uapi/linu

[PATCH v4 6/6] drm: bridge: dw-hdmi: Move HPD handling to PHY operations

2017-03-21 Thread Neil Armstrong
The HDMI TX controller support HPD and RXSENSE signaling from the PHY via it's STAT0 PHY interface, but some vendor PHYs can manage these signals independently from the controller, thus these STAT0 handling should be moved to PHY specific operations and become optional. The existing STAT0 HPD and

[PATCH v4 3/6] documentation: media: Add documentation for new RGB and YUV bus formats

2017-03-21 Thread Neil Armstrong
Add documentation for added Bus Formats to describe RGB and YUV formats used as input to the Synopsys DesignWare HDMI TX Controller. Signed-off-by: Neil Armstrong --- Documentation/media/uapi/v4l/subdev-formats.rst | 871 +++- 1 file changed, 857 insertions(+), 14 deletions(-

Re: [RFC libdrm 0/2] Replace the build system with meson

2017-03-21 Thread Grazvydas Ignotas
It might make sense to give more attention to cmake just because many mesa-related projects are already using it: llvm, piglit, vulkan loader and demos, mesa-demos, etc. Not sure how well it supports BSDs and windows, but everyone building graphics stacks or contributing to mesa should already be c

[PATCH v4 0/6] drm: bridge: dw-hdmi: Add support for Custom PHYs

2017-03-21 Thread Neil Armstrong
The Amlogic GX SoCs implements a Synopsys DesignWare HDMI TX Controller in combination with a very custom PHY. Thanks to Laurent Pinchart's changes, the HW report the following : Detected HDMI TX controller v2.01a with HDCP (meson_dw_hdmi_phy) The following differs from common PHY integration as

[PATCH v4 1/6] drm: bridge: dw-hdmi: Extract PHY interrupt setup to a function

2017-03-21 Thread Neil Armstrong
From: Laurent Pinchart In preparation for adding PHY operations to handle RX SENSE and HPD, group all the PHY interrupt setup code in a single location and extract it to a separate function. Signed-off-by: Laurent Pinchart Signed-off-by: Neil Armstrong --- drivers/gpu/drm/bridge/synopsys/dw-h

[PATCH v4 4/6] drm: bridge: dw-hdmi: Switch to V4L bus format and encodings

2017-03-21 Thread Neil Armstrong
Some display pipelines can only provide non-RBG input pixels to the HDMI TX Controller, this patch takes the pixel format from the plat_data if provided. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 326 +- include/drm/bridge/dw_hdmi.h

Re: [RFC libdrm 0/2] Replace the build system with meson

2017-03-21 Thread Ilia Mirkin
On Tue, Mar 21, 2017 at 11:13 AM, Grazvydas Ignotas wrote: > everyone building graphics stacks or contributing to > mesa should already be comfortable with cmake thanks to piglit and > llvm, which might not be the case for meson. Or they could be contributing to mesa because it's the last project

[PATCH v2 00/13] drm/meson: Initial support for HDMI Output

2017-03-21 Thread Neil Armstrong
The Amlogic GX SoCs implements a Synopsys DesignWare HDMI TX Controller in combination with a very custom PHY. This patchset depends on Laurent Pinchart patchset merged in drm-misc-next and my v4 patchset at [1] to permit PHY control from outside the dw-hdmi driver. The Synopsys DesignWare HDMI T

[PATCH v2 03/13] drm/meson: Add support for components

2017-03-21 Thread Neil Armstrong
This patch adds support for optional components connected through the Device Tree endpoints scheme. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_drv.c | 113 +- 1 file changed, 99 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/me

[PATCH v2 04/13] drm/meson: venc_cvbs: no more return -ENODEV if CVBS is not available

2017-03-21 Thread Neil Armstrong
Since this is managed now by the components code, if CVBS is not available and HDMI neither, the drm driver won't bind anyway. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_venc_cvbs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/meson/meson

[PATCH v2 06/13] drm/meson: Add support for HDMI venc modes and settings

2017-03-21 Thread Neil Armstrong
This patch adds support for the supported HDMI Venc modes and add the VPP mux value to switch to ENCP encoder. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_venc.c | 1245 +++- drivers/gpu/drm/meson/meson_venc.h |7 + drivers/gpu/drm/meson/meso

[PATCH v2 01/13] drm/meson: Use crtc_state for hdisplay and fix atomic flush/enable sync for vsync commit

2017-03-21 Thread Neil Armstrong
Clean the crtc_enable by using the proper crtc_state instead of the state of the primary plane state data. Also fix the dependency to commit the plane changes even if enable is called after the flush. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_crtc.c | 15 +++ 1 f

[PATCH v2 12/13] drm/meson: Add RST to bring together kerneldoc

2017-03-21 Thread Neil Armstrong
Signed-off-by: Neil Armstrong --- Documentation/gpu/index.rst | 1 + Documentation/gpu/meson.rst | 61 + 2 files changed, 62 insertions(+) create mode 100644 Documentation/gpu/meson.rst diff --git a/Documentation/gpu/index.rst b/Documentation/gpu/ind

[PATCH v2 07/13] drm/meson: Add support for HDMI encoder and DW-HDMI bridge + PHY

2017-03-21 Thread Neil Armstrong
The Amlogic Meson GXBB/GXL/GXM SoCs embeds a Synopsys DesignWare HDMI TX Controller with a custom Bridge + PHY around the Controller. This driver makes uses of all the custom PHY plat data callbacks and enables the compatible HDMI modes to be configured as a drm_encoder instance. Signed-off-by: N

[PATCH v2 10/13] dt-bindings: Add bindings for the Amlogic Meson dw-hdmi extension

2017-03-21 Thread Neil Armstrong
This binding describes the Amlogic Meson specific extension to the Synopsys Designware HDMI Controller. Acked-by: Rob Herring Signed-off-by: Neil Armstrong --- .../bindings/display/amlogic,meson-dw-hdmi.txt | 111 + 1 file changed, 111 insertions(+) create mode 100644

[PATCH v2 09/13] ARM64: dts: meson-gx: Add support for HDMI output

2017-03-21 Thread Neil Armstrong
Add HDMI output and connector nodes. Signed-off-by: Neil Armstrong --- .../arm64/boot/dts/amlogic/meson-gx-p23x-q20x.dtsi | 39 ++ arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 32 ++ .../boot/dts/amlogic/meson-gxbb-nexbox-a95x.dts| 23 +

[PATCH v2 05/13] drm/meson: add support for HDMI clock support

2017-03-21 Thread Neil Armstrong
This patchs adds support for the supported HDMI modes clocks frequencies. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_vclk.c | 624 +++- drivers/gpu/drm/meson/meson_vclk.h | 6 +- drivers/gpu/drm/meson/meson_venc_cvbs.c | 9 +- 3 files

[PATCH v2 08/13] ARM64: dts: meson-gx: Add shared CMA dma memory pool

2017-03-21 Thread Neil Armstrong
The HDMI modes needs more CMA memory to be reserved at boot-time. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi index 5

[PATCH v2 02/13] drm/meson: Add missing HDMI register

2017-03-21 Thread Neil Armstrong
Add missing VPU HDMI register. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_registers.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/meson/meson_registers.h b/drivers/gpu/drm/meson/meson_registers.h index 6adf9c1..2847381 100644 --- a/drivers/gpu/drm/meso

[PATCH] drm/atomic: Introduce drm_atomic_helper_shutdown

2017-03-21 Thread Daniel Vetter
The trouble here is that it does multiple atomic commits under one drm_modeset_lock_all, which breaks the behind-the-scenes acquire context magic that function pulls off. It's much better to have one overall atomic commit. That we still have multiple atomic commits prevents us from adding some pret

[PATCH v2 11/13] drm/meson: Convert existing documentation to actual kerneldoc

2017-03-21 Thread Neil Armstrong
Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_canvas.c | 4 +++- drivers/gpu/drm/meson/meson_drv.c | 5 +++-- drivers/gpu/drm/meson/meson_dw_hdmi.c | 25 + drivers/gpu/drm/meson/meson_vclk.c| 22 +++--- drivers/gpu/drm/meson/meson

[PATCH v2 13/13] MAINTAINERS: update files for Amlogic DRM Driver

2017-03-21 Thread Neil Armstrong
This patch adds the dw-hdmi bindings and RST kerneldoc to maintained files. Signed-off-by: Neil Armstrong --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index e88154f..3df68c73 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4256,6 +4256,8 @@ W:

Re: [PATCH] drm/atomic: Introduce drm_atomic_helper_shutdown

2017-03-21 Thread Maarten Lankhorst
Op 21-03-17 om 16:26 schreef Daniel Vetter: > The trouble here is that it does multiple atomic commits under one > drm_modeset_lock_all, which breaks the behind-the-scenes acquire > context magic that function pulls off. It's much better to have one > overall atomic commit. That we still have multi

Re: [PATCH] drm: add check for plane functions

2017-03-21 Thread Harry Wentland
On 2017-03-20 05:42 AM, Shirish S wrote: On Mon, Mar 20, 2017 at 1:51 PM, Daniel Vetter wrote: On Mon, Mar 20, 2017 at 09:58:01AM +0530, Shirish S wrote: First of all, thanks for your comments/insights. On Sat, Mar 18, 2017 at 12:59 AM, Eric Anholt wrote: Ville Syrjälä writes: On Fri,

[PATCH] drm/doc: Document feature merge deadlines

2017-03-21 Thread Daniel Vetter
The discussion pretty much concluded without objections, let's document what we agreed on. Cc'ing linux-doc for the new tag in Documentation/process/index.rst. Cc: Jonathan Corbet Cc: linux-...@vger.kernel.org Cc: Dave Airlie Cc: Sean Paul Cc: Jani Nikula Cc: Alex Deucher Cc: Lukas Wunner S

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

2017-03-21 Thread Matt Turner
On Mon, Mar 20, 2017 at 12:39 PM, Emil Velikov wrote: > On 20 March 2017 at 18:30, Matt Turner wrote: >> On Mon, Mar 20, 2017 at 6:55 AM, Emil Velikov >> wrote: >>> Seems like we ended up all over the place, so let me try afresh. >>> >>> Above all: >>> - Saying "I don't care" about your users

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

2017-03-21 Thread Matt Turner
On Mon, Mar 20, 2017 at 10:00 PM, Jonathan Gray wrote: > On Tue, Mar 21, 2017 at 08:28:22AM +1100, Timothy Arceri wrote: >> >> >> On 21/03/17 06:39, Emil Velikov wrote: >> > On 20 March 2017 at 18:30, Matt Turner wrote: >> > > On Mon, Mar 20, 2017 at 6:55 AM, Emil Velikov >> > > wrote: >> > > >

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

2017-03-21 Thread Matt Turner
On Mon, Mar 20, 2017 at 10:10 PM, Jonathan Gray wrote: > On Mon, Mar 20, 2017 at 11:30:25AM -0700, Matt Turner wrote: >> On Mon, Mar 20, 2017 at 6:55 AM, Emil Velikov >> wrote: >> > Seems like we ended up all over the place, so let me try afresh. >> > >> > Above all: >> > - Saying "I don't care

Re: [RFC libdrm 0/2] Replace the build system with meson

2017-03-21 Thread Dylan Baker
I would personally rather have scons and autotools than cmake. I've had the misfortune of using all three, and cmake is not an improvement in my opinion. Quoting Grazvydas Ignotas (2017-03-21 08:13:31) > It might make sense to give more attention to cmake just because many > mesa-related projects

Re: [RFC libdrm 0/2] Replace the build system with meson

2017-03-21 Thread Dylan Baker
Quoting Jani Nikula (2017-03-21 07:44:55) > On Thu, 16 Mar 2017, Dylan Baker wrote: > > First it's written in python, [...] > > How does meson handle python 2 vs. 3? How do you avoid issues in the > build files wrt this? On Debian meson seems to depend on python 3, so > are they fully python 3?

  1   2   >