Re: [PATCH 0/2] Documentation/EDID fixes

2017-03-08 Thread Jani Nikula
On Tue, 07 Mar 2017, Javi Merino wrote: > On Tue, Mar 07, 2017 at 06:16:51PM +0200, Jani Nikula wrote: >> On Mon, 06 Mar 2017, Javi Merino wrote: >> > I found these two minor issues while building an EDID. I'm not sure >> > whether the second patch (Add O= to support) is upstream material, but >

Re: linux-next: build failure after merge of the sunxi tree

2017-03-08 Thread Jani Nikula
On Tue, 07 Mar 2017, Maxime Ripard wrote: > I just rebased my tree on top of the latest drm-misc tag > (drm-misc-next-2017-03-06). It should compile, and not have merge > conflicts anymore. Conflicts happen. Rebasing should not be the standard operating procedure for fixing them. BR, Jani. --

0day 'make htmldocs' testing (was: Re: [PATCH] drm/dp: Add missing description to parameter)

2017-03-08 Thread Jani Nikula
On Wed, 08 Mar 2017, Sean Paul wrote: > On Tue, Mar 07, 2017 at 09:35:11PM +0100, Tomeu Vizoso wrote: >> Gabriel Krisman reported these warnings when building the documentation: >> >> ./drivers/gpu/drm/drm_dp_helper.c:1165: warning: No description found >> for parameter 'crtc' >> ./drivers/gpu/d

Re: 0day 'make htmldocs' testing (was: Re: [PATCH] drm/dp: Add missing description to parameter)

2017-03-08 Thread Jani Nikula
On Wed, 08 Mar 2017, Jani Nikula wrote: > On Wed, 08 Mar 2017, Sean Paul wrote: >> On Tue, Mar 07, 2017 at 09:35:11PM +0100, Tomeu Vizoso wrote: >>> Gabriel Krisman reported these warnings when building the documentation: >>> >>> ./drivers/gpu/drm/drm_dp_helper.c:1165: warning: No description f

Re: [PATCH 11/15] drm/sun4i: tcon: Fix tcon channel 1 backporch calculation

2017-03-08 Thread Maxime Ripard
On Wed, Mar 08, 2017 at 12:25:59PM +0800, Chen-Yu Tsai wrote: > On Tue, Mar 7, 2017 at 4:56 PM, Maxime Ripard > wrote: > > It seems like what's called a backporch in the datasheet is actually the > > backporch plus the sync period. Fix that in our driver. > > > > Signed-off-by: Maxime Ripard > >

Re: [linux-sunxi] [PATCH 5/15] clk: sunxi-ng: sun5i: Export video PLLs

2017-03-08 Thread Maxime Ripard
Hi Julian, On Tue, Mar 07, 2017 at 09:21:19PM +1100, Julian Calaby wrote: > Hi Maxime, > > On Tue, Mar 7, 2017 at 7:56 PM, Maxime Ripard > wrote: > > The video PLLs are used directly by the HDMI controller. Export them so > > that we can use them in our DT node. > > > > Signed-off-by: Maxime Rip

Re: linux-4.11-rc1/drivers/gpu/drm/exynos/exynos5433_drm_decon.c:681: suspicious mask ?

2017-03-08 Thread Andrzej Hajda
Hi David, Inki, Thanks for reporting. On 06.03.2017 11:05, David Binderman wrote: > Hello there, > > linux-4.11-rc1/drivers/gpu/drm/exynos/exynos5433_drm_decon.c:681]: (warning) > Result of operator '|' is always true if one operand is non-zero. Did you > intend to use '&'? > > Source code is >

[PATCH 1/4] qxl: drop mode_info.modes & related code.

2017-03-08 Thread Gerd Hoffmann
very old qxl hardware revisions (predating qxl ksm support by a few years) supported a fixed list of video modes only. The list is still provided by the virtual hardware, for backward compatibility reasons. The qxl kms driver never ever looks at it, except for dumping it to the kernel log at load

[PATCH 3/4] qxl: read monitors config at boot

2017-03-08 Thread Gerd Hoffmann
Try to read the client monitors config at driver load time, even without explicit notification. So in case that info was filled before the driver loaded and we've missed the notifications because of that the settings will still be used. With that place we now have to take care to properly handle

[PATCH 4/4] qxl: fix qxl_conn_get_modes

2017-03-08 Thread Gerd Hoffmann
Call qxl_add_monitors_config_modes() unconditionally. Do all sanity checks in that function. Fix sanity checks. monitors_config is the current monitor configuration, whereas client_monitors_config is the configuration requested by the spice client. So when filling the mode list, based on the sp

[PATCH 2/4] qxl: limit monitor config read retries

2017-03-08 Thread Gerd Hoffmann
When reading the monitor config fails, don't retry forever. If it fails ten times in a row just give up to avoid the driver hangs. Also add a small delay after each attempt, so the host has a chance to complete a partial update. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/qxl/qxl_display.

Re: [kbuild-all] 0day 'make htmldocs' testing (was: Re: [PATCH] drm/dp: Add missing description to parameter)

2017-03-08 Thread Fengguang Wu
Hi Jani, On Wed, Mar 08, 2017 at 10:41:37AM +0200, Jani Nikula wrote: On Wed, 08 Mar 2017, Jani Nikula wrote: On Wed, 08 Mar 2017, Sean Paul wrote: On Tue, Mar 07, 2017 at 09:35:11PM +0100, Tomeu Vizoso wrote: Gabriel Krisman reported these warnings when building the documentation: ./driv

Re: [PATCH v3 4/6] drm: bridge: dw-hdmi: Switch to V4L bus format and encodings

2017-03-08 Thread Neil Armstrong
On 03/07/2017 06:35 PM, Jose Abreu wrote: > Hi Neil, > > > On 07-03-2017 16:42, Neil Armstrong wrote: >> Some display pipelines can only provide non-RBG input pixels to the HDMI TX >> Controller, this patch takes the pixel format from the plat_data if provided. >> >> Signed-off-by: Neil Armstrong

Re: linux-next: build failure after merge of the sunxi tree

2017-03-08 Thread Daniel Vetter
On Wed, Mar 08, 2017 at 10:26:54AM +0200, Jani Nikula wrote: > On Tue, 07 Mar 2017, Maxime Ripard wrote: > > I just rebased my tree on top of the latest drm-misc tag > > (drm-misc-next-2017-03-06). It should compile, and not have merge > > conflicts anymore. > > Conflicts happen. Rebasing should

Re: [PATCH 3/3] drm/qxl: Remove qxl_debugfs_remove_files()

2017-03-08 Thread Daniel Vetter
On Wed, Mar 08, 2017 at 08:45:13AM +0100, Gerd Hoffmann wrote: > On Di, 2017-03-07 at 21:49 +0100, Noralf Trønnes wrote: > > drm_debugfs_cleanup() now removes all minor->debugfs_list entries > > automatically, so it's not necessary to call > > drm_debugfs_remove_files(). > > > > Cc: airl...@linux.

Re: linux-next: build failure after merge of the rcu tree

2017-03-08 Thread Daniel Vetter
On Wed, Mar 08, 2017 at 12:16:45PM +1100, Stephen Rothwell wrote: > Hi Paul, > > After merging the rcu tree, today's linux-next build (x86_64 allmodconfig) > failed like this: > > In file included from include/linux/resource_ext.h:19:0, > from include/linux/pci.h:32, >

[Bug 100109] Graphics Lockup if monitor disconnected and then set into standby

2017-03-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100109 Bug ID: 100109 Summary: Graphics Lockup if monitor disconnected and then set into standby Product: DRI Version: XOrg git Hardware: Other OS: All

Re: [PATCH v3 1/6] drm: bridge: dw-hdmi: Extract PHY interrupt setup to a function

2017-03-08 Thread Neil Armstrong
Hi Jose, On 03/07/2017 06:12 PM, Jose Abreu wrote: > Hi Neil, > > > On 07-03-2017 16:42, Neil Armstrong wrote: >> From: Laurent Pinchart >> >> In preparation for adding PHY operations to handle RX SENSE and HPD, >> group all the PHY interrupt setup code in a single location and extract >> it to

[Bug 100109] Graphics Lockup if monitor disconnected and then set into standby

2017-03-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100109 --- Comment #1 from Kieran Grant --- I just tried to quickly reproduce the problem using timer delayed xset usage and turning off monitor and unplugging it... but no oops and no graphics stack corruption... (Well... at least *that* is good news)

Re: [PATCH 2/3] drm/debugfs: Remove the drm_driver.debugfs_cleanup callback

2017-03-08 Thread Daniel Vetter
On Tue, Mar 07, 2017 at 09:49:23PM +0100, Noralf Trønnes wrote: > Remove the .debugfs_cleanup() callback now that all the users are gone. > > Signed-off-by: Noralf Trønnes First 2 patches merged to drm-misc, with Rob's irc ack on the first one. I'll leave the 3rd for Gerd. Thanks, Daniel > ---

Re: [PATCH 4/4] drm/exynos/decon5433: signal frame done interrupt at VSYNC

2017-03-08 Thread Andrzej Hajda
On 07.03.2017 10:14, Inki Dae wrote: > > 2017년 02월 23일 01:05에 Andrzej Hajda 이(가) 쓴 글: >> DECON in case of video mode generates interrupt by default at start >> of vertical back porch. As this interrupt is used to generate VBLANK >> events more optimal point is start of vertical front porch. >> >> S

Re: [PATCH 4/5] drm/radeon: Don't register Thunderbolt eGPU with vga_switcheroo

2017-03-08 Thread Peter Wu
On Wed, Mar 08, 2017 at 06:01:54AM +0100, Lukas Wunner wrote: > On Tue, Mar 07, 2017 at 03:30:30PM -0500, Alex Deucher wrote: > > On Fri, Feb 24, 2017 at 2:19 PM, Lukas Wunner wrote: > > > An external Thunderbolt GPU can neither drive the laptop's panel nor be > > > powered off by the platform, so

[PATCH v2 3/9] gpu: ipu-v3: add DT binding for the Prefetch Resolve Gasket

2017-03-08 Thread Lucas Stach
This adds the the devicetree binding for the Prefetch Resolve Gasket, as found on i.MX6 QuadPlus. The PRG is fairly simple in that it only has a configuration register range and two clocks, one for the AHB slave port and one for the AXI ports and the functional units. The PRE connections need to b

[PATCH v2 2/9] gpu: ipu-v3: add driver for Prefetch Resolve Engine

2017-03-08 Thread Lucas Stach
This adds support for the i.MX6 QuadPlus PRE units. Currently only linear prefetch into SRAM is supported, other modes of operation like the tiled-to-linear conversion will be added later. Signed-off-by: Lucas Stach --- v2: - adopt to changed DT binding - change name of the lookup functions as su

[PATCH v2 6/9] gpu: ipu-v3: hook up PRG unit

2017-03-08 Thread Lucas Stach
The i.MX6 QuadPlus IPU needs to PRG unit to gain access to the data bus. Make sure it is present and available to be used. Signed-off-by: Lucas Stach --- drivers/gpu/ipu-v3/ipu-common.c | 11 ++- drivers/gpu/ipu-v3/ipu-prv.h| 1 + 2 files changed, 11 insertions(+), 1 deletion(-) di

[PATCH v2 1/9] gpu: ipu-v3: add DT binding for the Prefetch Resolve Engine

2017-03-08 Thread Lucas Stach
The Prefetch Resolve Engine is a prefetch and tile resolve engine which prefetches display data from DRAM to an internal SRAM region. It has a single clock for configuration register access and the functional units. A single shared interrupt is used for status and error signaling. The only externa

[PATCH v2 7/9] gpu: ipu-v3: only set non-zero AXI ID for IC when PRG is absent

2017-03-08 Thread Lucas Stach
Using non-zero AXI IDs for anything other than the display channels collides with the PRG AXI snooping, so only do this if there is no PRG present. Signed-off-by: Lucas Stach --- drivers/gpu/ipu-v3/ipu-image-convert.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/driv

[PATCH v2 4/9] gpu: ipu-v3: add driver for Prefetch Resolve Gasket

2017-03-08 Thread Lucas Stach
This adds support for the i.MX6 QUadPlus PRG unit. It glues together the IPU and the PRE units. Signed-off-by: Lucas Stach --- v2: change name of the lookup function as suggested by Philipp --- drivers/gpu/ipu-v3/Makefile | 2 +- drivers/gpu/ipu-v3/ipu-prg.c | 418

[PATCH v2 8/9] drm/imx: enable/disable PRG on CRTC enable/disable

2017-03-08 Thread Lucas Stach
On i.MX6 QuadPlus the PRG needs to be clocked in order to pass through the data access requests from the IDMAC. This call is a no-op for other all other SoCs. Signed-off-by: Lucas Stach --- drivers/gpu/drm/imx/ipuv3-crtc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/imx

[PATCH v2 5/9] gpu: ipu-v3: document valid IPUv3 compatibles and extend for i.MX6 QuadPlus

2017-03-08 Thread Lucas Stach
Document the valid compatible strings for the IPUv3. On i.MX6 QuadPlus the IPU needs to know which PRG has to be used for this IPU instance. Add a "fsl,prg" property containing a phandle pointing to the correct PRG device. Signed-off-by: Lucas Stach --- Documentation/devicetree/bindings/display

[PATCH v2 9/9] drm/imx: use PRG/PRE when possible

2017-03-08 Thread Lucas Stach
Allow the planes to use the PRG/PRE units as linear prefetchers when possible. This improves DRAM efficiency a bit and reduces the chance for display underflow when the memory subsystem is under load. This does not yet support scanning out tiled buffers directly, as this needs more work, but it al

[Bug 62541] Kernel oops/panic during system boot with systemd - "Unable to handle kernel NULL pointer dereference"

2017-03-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=62541 --- Comment #4 from Jani Nikula (jani.nik...@intel.com) --- (In reply to Szőgyényi Gábor from comment #3) > Please try to reproduce this bug with latest kernel image & latest systemd. Sorry, what's the point? If you're scrubbing the bugs here, ple

[Bug 88861] [efi, i915, vgaswitcheroo, black screen, nouveau] Screen goes black when switching from dedicated nvidia graphics card (nouveau) to integrated

2017-03-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=88861 --- Comment #26 from Jani Nikula (jani.nik...@intel.com) --- *** Bug 194697 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___

Re: [PATCH 3/3] drm/qxl: Remove qxl_debugfs_remove_files()

2017-03-08 Thread Gerd Hoffmann
On Mi, 2017-03-08 at 10:52 +0100, Daniel Vetter wrote: > On Wed, Mar 08, 2017 at 08:45:13AM +0100, Gerd Hoffmann wrote: > > On Di, 2017-03-07 at 21:49 +0100, Noralf Trønnes wrote: > > > drm_debugfs_cleanup() now removes all minor->debugfs_list entries > > > automatically, so it's not necessary to c

[PATCH] drm/i915: Nuke skl_update_plane debug message from the pipe update critical section

2017-03-08 Thread Maarten Lankhorst
printks are slow so we should not be doing them from the vblank evade critical section. These could explain why we sometimes seem to blow past our 100 usec deadline. The problem has been there ever since commit bfd16b2a23dc ("drm/i915: Make updating pipe without modeset atomic.") but it may not ha

Re: [PATCH v3 4/6] drm: bridge: dw-hdmi: Switch to V4L bus format and encodings

2017-03-08 Thread Neil Armstrong
On 03/07/2017 06:35 PM, Jose Abreu wrote: > Hi Neil, > > > On 07-03-2017 16:42, Neil Armstrong wrote: >> Some display pipelines can only provide non-RBG input pixels to the HDMI TX >> Controller, this patch takes the pixel format from the plat_data if provided. >> >> Signed-off-by: Neil Armstrong

Re: [PATCH v4 1/7] drm: Add DRM support for tiny LCD displays

2017-03-08 Thread Noralf Trønnes
Den 07.03.2017 23.21, skrev Daniel Vetter: On Sat, Feb 11, 2017 at 07:48:52PM +0100, Noralf Trønnes wrote: +const struct file_operations tinydrm_fops = { + .owner = THIS_MODULE, + .open = drm_open, + .release= drm_release, + .unlocked_ioctl = d

Re: [PATCH 4/5] drm/radeon: Don't register Thunderbolt eGPU with vga_switcheroo

2017-03-08 Thread Lukas Wunner
On Wed, Mar 08, 2017 at 11:46:33AM +0100, Peter Wu wrote: > On Wed, Mar 08, 2017 at 06:01:54AM +0100, Lukas Wunner wrote: > > On Tue, Mar 07, 2017 at 03:30:30PM -0500, Alex Deucher wrote: > > > On Fri, Feb 24, 2017 at 2:19 PM, Lukas Wunner wrote: > > > > An external Thunderbolt GPU can neither dri

[PATCH 1/3] drm/etnaviv: submit support for in-fences

2017-03-08 Thread Philipp Zabel
Loosely based on commit f0a42bb5423a ("drm/msm: submit support for in-fences"). Unfortunately, struct drm_etnaviv_gem_submit doesn't have a flags field yet, so we have to extend the structure and trust that drm_ioctl will clear the flags for us if an older userspace only submits part of the struct.

[PATCH 2/3] drm/etnaviv: move fence allocation out of etnaviv_gpu_submit()

2017-03-08 Thread Philipp Zabel
The next patch will need the dma_fence to create the sync_file in etnaviv_ioctl_gem_submit, in case an out_fence_fd is requested. Signed-off-by: Philipp Zabel --- drivers/gpu/drm/etnaviv/etnaviv_gem.h| 3 ++- drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 8 +++- drivers/gpu/drm/et

[PATCH 3/3] drm/etnaviv: submit support for out-fences

2017-03-08 Thread Philipp Zabel
Based on commit 4cd0945901a6 ("drm/msm: submit support for out-fences"). We increment the minor driver version so userspace can detect explicit fence support. Signed-off-by: Philipp Zabel --- drivers/gpu/drm/etnaviv/etnaviv_drv.c| 2 +- drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 27

Re: [PATCH] drm/i915: Nuke skl_update_plane debug message from the pipe update critical section

2017-03-08 Thread Ville Syrjälä
On Wed, Mar 08, 2017 at 01:00:07PM +0100, Maarten Lankhorst wrote: > printks are slow so we should not be doing them from the vblank evade > critical section. These could explain why we sometimes seem to > blow past our 100 usec deadline. > > The problem has been there ever since commit bfd16b2a23

[PATCH v8 0/6] HDMI 2.0: Scrambling in DRM layer

2017-03-08 Thread Shashank Sharma
HDMI 2.0 spec defines a method to reduce the RF footprint while operating at higher pixel clocks, which is called Scrambling. Scrambling can be controlled over a new set of I2C registers which are accessible over existing DDC I2C lines, called SCDC register set. This patch series contains 6 patche

[PATCH v8 2/6] drm/edid: check for HF-VSDB block

2017-03-08 Thread Shashank Sharma
From: Thierry Reding This patch implements a small function that finds if a given CEA db is hdmi-forum vendor specific data block or not. V2: Rebase. V3: Added R-B from Jose. V4: Rebase V5: Rebase V6: Rebase V7: Rebase V8: Rebase Signed-off-by: Thierry Reding Signed-off-by: Shashank Sharma Re

[PATCH v8 4/6] drm/edid: detect SCDC support in HF-VSDB

2017-03-08 Thread Shashank Sharma
This patch does following: - Adds a new structure (drm_hdmi_info) in drm_display_info. This structure will be used to save and indicate if sink supports advanced HDMI 2.0 features - Adds another structure drm_scdc within drm_hdmi_info, to reflect scdc support and capabilities in connected HDM

[PATCH v8 1/6] drm: Add SCDC helpers

2017-03-08 Thread Shashank Sharma
From: Thierry Reding SCDC is a mechanism defined in the HDMI 2.0 specification that allows the source and sink devices to communicate. This commit introduces helpers to access the SCDC and provides the symbolic names for the various registers defined in the specification. V2: Rebase. V3: Added

[PATCH v8 3/6] drm/edid: detect SCDC support in HF-VSDB

2017-03-08 Thread Shashank Sharma
This patch does following: - Adds a new structure (drm_hdmi_info) in drm_display_info. This structure will be used to save and indicate if sink supports advanced HDMI 2.0 features - Adds another structure drm_scdc within drm_hdmi_info, to reflect scdc support and capabilities in connected HDM

[PATCH v8 6/6] drm/i915: allow HDMI 2.0 clock rates

2017-03-08 Thread Shashank Sharma
Geminilake has a native HDMI 2.0 controller, which is capable of driving clocks upto 594Mhz. This patch updates the max tmds clock limit for the same. V2: rebase V3: rebase V4: added r-b from Ander V5: rebase V6: rebase V7: rebase V8: rebase Cc: Ander Conselvan De Oliveira Signed-off-by: Shashan

[PATCH v8 5/6] drm/i915: enable scrambling

2017-03-08 Thread Shashank Sharma
Geminilake platform sports a native HDMI 2.0 controller, and is capable of driving pixel-clocks upto 594Mhz. HDMI 2.0 spec mendates scrambling for these higher clocks, for reduced RF footprint. This patch checks if the monitor supports scrambling, and if required, enables it during the modese

Re: [PATCH] drm/i915: Nuke skl_update_plane debug message from the pipe update critical section

2017-03-08 Thread Maarten Lankhorst
Op 08-03-17 om 14:12 schreef Ville Syrjälä: > On Wed, Mar 08, 2017 at 01:00:07PM +0100, Maarten Lankhorst wrote: >> printks are slow so we should not be doing them from the vblank evade >> critical section. These could explain why we sometimes seem to >> blow past our 100 usec deadline. >> >> The p

[PATCH 00/24] more docs and header splits

2017-03-08 Thread Daniel Vetter
Hi all, So I looked at drmP.h, thought "this is small, should finally be doable to split it all into sensible pieces and document things". Yes that joke was on me, only managed to do a few random things and then split out drm_file related things. Plus clean those up and give the docs a fresh-up.

[PATCH 03/24] drm: Move drm_lock_data out of drmP.h

2017-03-08 Thread Daniel Vetter
And remove the semi-kernel-doc stuff, to make sure no one uses this. Signed-off-by: Daniel Vetter --- include/drm/drmP.h | 15 --- include/drm/drm_auth.h | 17 + 2 files changed, 17 insertions(+), 15 deletions(-) diff --git a/include/drm/drmP.h b/include/drm/drmP

[PATCH 01/24] drm/doc: Add todo about connector_list_iter

2017-03-08 Thread Daniel Vetter
At least radeon, amdgpu and nouveau should be converted. We have patches for i915 already. Signed-off-by: Daniel Vetter --- Documentation/gpu/todo.rst | 13 + 1 file changed, 13 insertions(+) diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst index ce0f1a588e7f..63

[PATCH 05/24] drm: Remove drmP.h include from drm_kms_helper_common.c

2017-03-08 Thread Daniel Vetter
An easy one as a drive-by. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_kms_helper_common.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_kms_helper_common.c b/drivers/gpu/drm/drm_kms_helper_common.c index 45db36cd3d20..6e35a56a6102 100644 ---

[PATCH 06/24] drm/doc: document fallback behaviour for atomic events

2017-03-08 Thread Daniel Vetter
Worst case if the hw can't support completion signalling in a race-free way we want the event to be too late, not too early. Text adapted from a proposal from Laurent - the other side of how to make hw work correctly where it's possible is imo already sufficiently documented. v2: Review from Laur

[PATCH 02/24] drm: Extract drm_prime.h

2017-03-08 Thread Daniel Vetter
Plus a little bit more documentation. v2: Untangle the missing forward decls to make drm_prime|gem.h free-standing. Signed-off-by: Daniel Vetter --- Documentation/gpu/drm-mm.rst | 3 ++ drivers/gpu/drm/drm_prime.c | 3 +- include/drm/drmP.h| 32 ++ include/drm/d

[PATCH 09/24] drm: Extract drm_file.h

2017-03-08 Thread Daniel Vetter
I'm torn on whether drm_minor really should be here or somewhere else. Maybe with more clarity after untangling drmP.h more this is easier to decide, for now I've put a FIXME comment right next to it. Right now we need struct drm_minor for the inline drm_file type helpers, and so it does kinda make

[PATCH 08/24] drm: Remove DRM_MINOR_CNT

2017-03-08 Thread Daniel Vetter
This was originally added by David Herrmann for range checks, but entirely unused. It confused me, so let's remove it. Cc: David Herrmann Signed-off-by: Daniel Vetter --- include/drm/drmP.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/drm/drmP.h b/include/drm/drmP.h index 82610178

[PATCH 04/24] drm: Extract drm_pci.h

2017-03-08 Thread Daniel Vetter
Just another step in finally making drmP.h obsolete. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_pci.c | 7 + include/drm/drmP.h| 43 +++--- include/drm/drm_pci.h | 78 +++ 3 files changed, 89 insertions(+)

[PATCH 13/24] drm/msm: switch to postclose

2017-03-08 Thread Daniel Vetter
I didn't spot anything that would require ordering here (well not anywhere else either), and I'm trying to unify at least modern drivers on one close hook. Cc: Rob Clark Cc: linux-arm-...@vger.kernel.org Cc: freedr...@lists.freedesktop.org Signed-off-by: Daniel Vetter --- drivers/gpu/drm/msm/ms

[PATCH 12/24] drm/i915: Merge pre/postclose hooks

2017-03-08 Thread Daniel Vetter
There's really not a reason afaics that we can't just clean up everything at the end, in the terminal postclose hook: Since this is closing a file descriptor we know no one else can have a reference or a thread doing something with that drm_file except the close code. Ordering shouldn't matter, as

[PATCH 11/24] drm/doc: Document drm_file.[hc]

2017-03-08 Thread Daniel Vetter
Well, mostly drm_file.h, and clean up all related things: - I didnt' figure out the difference between preclose and postclose. The existing explanation in drm-internals.rst didn't convince me, since it's also really outdated - we clean up pending DRM events in the core nowadays. I put a FIXM

[PATCH 17/24] drm/vgem: switch to postclose

2017-03-08 Thread Daniel Vetter
I didn't spot anything that would require ordering here (well not anywhere else either), and I'm trying to unify at least modern drivers on one close hook. Cc: Chris Wilson Signed-off-by: Daniel Vetter --- drivers/gpu/drm/vgem/vgem_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH 15/24] drm/radeon: Merge pre/postclose hooks

2017-03-08 Thread Daniel Vetter
Again no apparent explanation for the split except hysterical raisins. Merging them also makes it a bit more obviuos what's going on wrt the runtime pm refdancing. Cc: Alex Deucher Cc: Christian König Cc: amd-...@lists.freedesktop.org Signed-off-by: Daniel Vetter --- drivers/gpu/drm/radeon/rad

[PATCH 10/24] drm: Remove drm_pending_event->pid

2017-03-08 Thread Daniel Vetter
We might as well dump the drm_file pointer, that's about as useful a cookie as the pid. Noticed while typing docs for drm_file and friends. Since the only consumer of this is the tracepoints I think we can safely change this - those tracepoints should not be uapi relevant at all. It all goes back

[PATCH 18/24] drm/etnaviv: switch to postclose

2017-03-08 Thread Daniel Vetter
I didn't spot anything that would require ordering here (well not anywhere else either), and I'm trying to unify at least modern drivers on one close hook. Cc: Lucas Stach Cc: Russell King Cc: Christian Gmeiner Cc: etna...@lists.freedesktop.org Signed-off-by: Daniel Vetter --- drivers/gpu/drm

[PATCH 21/24] drm/msm: Simplify vblank event delivery

2017-03-08 Thread Daniel Vetter
The core takes care of handling the send_event vs. close() issues, we can remove that driver code. Cc: Rob Clark Cc: linux-arm-...@vger.kernel.org Cc: freedr...@lists.freedesktop.org Signed-off-by: Daniel Vetter --- drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c | 12 +++- drivers/gpu/drm/msm

[PATCH 16/24] drm/tegra: switch to postclose

2017-03-08 Thread Daniel Vetter
I didn't spot anything that would require ordering here (well not anywhere else either), and I'm trying to unify at least modern drivers on one close hook. Cc: Thierry Reding Cc: linux-te...@vger.kernel.org Signed-off-by: Daniel Vetter --- drivers/gpu/drm/tegra/drm.c | 4 ++-- 1 file changed, 2

[PATCH 19/24] drm/amdgpu: Merge pre/postclose hooks

2017-03-08 Thread Daniel Vetter
Again no apparent explanation for the split except hysterical raisins. Merging them also makes it a bit more obviuos what's going on wrt the runtime pm refdancing. Cc: Alex Deucher Cc: Christian König Cc: amd-...@lists.freedesktop.org Signed-off-by: Daniel Vetter --- drivers/gpu/drm/amd/amdgpu

[PATCH 07/24] drm: rename drm_fops.c to drm_file.c

2017-03-08 Thread Daniel Vetter
It's not just file ops, but drm_file stuff in general. This is prep work to extracting a drm_file.h header in the next patch. Signed-off-by: Daniel Vetter --- Documentation/gpu/drm-internals.rst| 4 ++-- drivers/gpu/drm/Makefile | 2 +- drivers/gpu/drm/{drm_fops.c => dr

[PATCH 20/24] drm/exynos: Merge pre/postclose hooks

2017-03-08 Thread Daniel Vetter
Again no apparent explanation for the split except hysterical raisins. Merging them also makes it a bit more obviuos what's going on wrt the runtime pm refdancing. Cc: Inki Dae Cc: Joonyoung Shim Cc: Seung-Woo Kim Cc: Kyungmin Park Signed-off-by: Daniel Vetter --- drivers/gpu/drm/exynos/exyn

Re: [PATCH 08/24] drm: Remove DRM_MINOR_CNT

2017-03-08 Thread David Herrmann
Hi On Wed, Mar 8, 2017 at 3:12 PM, Daniel Vetter wrote: > This was originally added by David Herrmann for range checks, but > entirely unused. It confused me, so let's remove it. > > Cc: David Herrmann > Signed-off-by: Daniel Vetter > --- > include/drm/drmP.h | 1 - > 1 file changed, 1 deletio

[PATCH 14/24] drm/nouveau: Merge pre/postclose hooks

2017-03-08 Thread Daniel Vetter
Again no apparent explanation for the split except hysterical raisins. Merging them also makes it a bit more obviuos what's going on wrt the runtime pm refdancing. Cc: Ben Skeggs Cc: nouv...@lists.freedesktop.org Signed-off-by: Daniel Vetter --- drivers/gpu/drm/nouveau/nouveau_drm.c | 9 +--

[PATCH 23/24] drm: Create DEFINE_DRM_GEM_CMA_FOPS and roll it out to drivers

2017-03-08 Thread Daniel Vetter
Less code ftw. This converts all drivers except the tinydrm helper module. That one needs more work, since it gets the THIS_MODULE reference from tinydrm.ko instead of the actual driver module like it should. Probably needs a similar trick like I used here with generating the entire struct with a

[PATCH 22/24] drm: Nerf the preclose callback for modern drivers

2017-03-08 Thread Daniel Vetter
With all drivers converted there's only legacy dri1 drivers using it. Not going to touch those, instead just hide it like we've done with other dri1 driver hooks like firstopen. In all this I didn't find any real reason why we'd needed 2 hooks, and having symmetry between open and close just appea

Re: [PATCH 5/5] drm/amd/display: Allow HDMI capabilities over DVI connector (DC)

2017-03-08 Thread Jeffrey Smith
This did work for me, including stereo 3D, so that is rather disappointing. (DVI output of the card -> DVI/HDMI adapter -> HDMI Cable -> HDMI TV input) Is it that HDMI signaling passing through a DVI connector is dis-allowed on the whole, or is there something more subtle that I am missing? Would

[PATCH 24/24] drm/gem: Add DEFINE_DRM_GEM_FOPS

2017-03-08 Thread Daniel Vetter
Sadly there's only 1 driver which can use it, everyone else is special for some reason: - gma500 has a horrible runtime PM ioctl wrapper that probably doesn't really work but meh. - i915 needs special compat_ioctl handler because regrets. - arcgpu needs to fixup the pgprot because (no idea why i

Re: [PATCH 4/5] drm/amd/display: Add HDMI Stereo 3D (DC) support

2017-03-08 Thread Jeffrey Smith
I have easy access to an LG 3D television, though I do not have model information handy at the moment. This is the only display I have tested on so far. I have tested all three modes, and in each case the signal is recognized as 3D (the TV pops up a message to this effect), and the content is dis

Re: [PATCH 1/3] drm/etnaviv: submit support for in-fences

2017-03-08 Thread Gustavo Padovan
Hi Philipp, 2017-03-08 Philipp Zabel : > Loosely based on commit f0a42bb5423a ("drm/msm: submit support for > in-fences"). Unfortunately, struct drm_etnaviv_gem_submit doesn't have > a flags field yet, so we have to extend the structure and trust that > drm_ioctl will clear the flags for us if an

Re: [PATCH 2/3] drm/etnaviv: move fence allocation out of etnaviv_gpu_submit()

2017-03-08 Thread Gustavo Padovan
Hi Philipp, 2017-03-08 Philipp Zabel : > The next patch will need the dma_fence to create the sync_file in > etnaviv_ioctl_gem_submit, in case an out_fence_fd is requested. > > Signed-off-by: Philipp Zabel > --- > drivers/gpu/drm/etnaviv/etnaviv_gem.h| 3 ++- > drivers/gpu/drm/etnaviv

Re: [PATCH 3/3] drm/etnaviv: submit support for out-fences

2017-03-08 Thread Gustavo Padovan
Hi Philipp, 2017-03-08 Philipp Zabel : > Based on commit 4cd0945901a6 ("drm/msm: submit support for out-fences"). > We increment the minor driver version so userspace can detect explicit > fence support. > > Signed-off-by: Philipp Zabel > --- > drivers/gpu/drm/etnaviv/etnaviv_drv.c| 2

Re: [PATCH 02/24] drm: Extract drm_prime.h

2017-03-08 Thread Gustavo Padovan
Hi Daniel, 2017-03-08 Daniel Vetter : > Plus a little bit more documentation. > > v2: Untangle the missing forward decls to make drm_prime|gem.h > free-standing. > > Signed-off-by: Daniel Vetter > --- > Documentation/gpu/drm-mm.rst | 3 ++ > drivers/gpu/drm/drm_prime.c | 3 +- > include/

Re: [PATCH 06/24] drm/doc: document fallback behaviour for atomic events

2017-03-08 Thread Laurent Pinchart
Hi Daniel, Thank you for the patch. On Wednesday 08 Mar 2017 15:12:39 Daniel Vetter wrote: > Worst case if the hw can't support completion signalling in a > race-free way we want the event to be too late, not too early. > > Text adapted from a proposal from Laurent - the other side of how to > m

Re: [Intel-gfx] [PATCH 03/24] drm: Move drm_lock_data out of drmP.h

2017-03-08 Thread Gustavo Padovan
2017-03-08 Daniel Vetter : > And remove the semi-kernel-doc stuff, to make sure no one uses this. > > Signed-off-by: Daniel Vetter > --- > include/drm/drmP.h | 15 --- > include/drm/drm_auth.h | 17 + > 2 files changed, 17 insertions(+), 15 deletions(-) Reviewed

Re: [PATCH 15/24] drm/radeon: Merge pre/postclose hooks

2017-03-08 Thread Christian König
Reviewed-by: Christian König for this one and #19. Christian. Am 08.03.2017 um 15:12 schrieb Daniel Vetter: Again no apparent explanation for the split except hysterical raisins. Merging them also makes it a bit more obviuos what's going on wrt the runtime pm refdancing. Cc: Alex Deucher Cc

[PATCH v2 06/12] drm/exynos/fimd: signal frame done interrupt at front porch

2017-03-08 Thread Andrzej Hajda
VBLANK interrupt should be signalled as soon as scanout ends, front porch is the best moment. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/

[PATCH v2 04/12] drm/exynos/decon5433: implement frame counter

2017-03-08 Thread Andrzej Hajda
DECON in Exynos5433 has frame counter, it can be used to implement get_vblank_counter callback. Signed-off-by: Andrzej Hajda --- v2: - reuse decon_get_frame_count function already implemented in previous patch --- drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 12 drivers/gpu

[PATCH v2 00/12] drm/exynos: rework vblank handling

2017-03-08 Thread Andrzej Hajda
Hi Inki, This patchset fixes long standing issue with occassional page faults or vblank event timeouts on TM2 targets due to delayed vblank handling. DECON driver should now handle properly all scenarios described in drm docs [1][2], at least it was my intention. The patchset also: - adds frame c

[PATCH v2 05/12] drm/exynos/decon5433: signal frame done interrupt at front porch

2017-03-08 Thread Andrzej Hajda
DECON in case of video mode generates interrupt by default at start of vertical back porch. As this interrupt is used to generate VBLANK events more optimal point is start of vertical front porch. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 2 +- include/vide

[PATCH v2 01/12] drm/exynos: move crtc event handling to drivers callbacks

2017-03-08 Thread Andrzej Hajda
CRTC event is currently send with next vblank, or instantly in case crtc is being disabled. This approach usually works, but in corner cases it can result in premature event generation. Only device driver is able to verify if the event can be sent. This patch is a first step in that direction - it

[PATCH v2 02/12] drm/exynos: simplify completion event handling

2017-03-08 Thread Andrzej Hajda
All Exynos CRTC drivers shouldn't fail at referencing vblank events, alternate path is actually dead code. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/exynos/exynos_drm_crtc.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos

[PATCH v2 08/12] drm/exynos: kill exynos_drm_crtc::pipe

2017-03-08 Thread Andrzej Hajda
Since crtc index is stored in drm_crtc pipe field became redundant. The patch beside removing the field simplifies also exynos_drm_crtc_get_pipe_from_type. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 3 +-- drivers/gpu/drm/exynos/exynos7_drm_decon.c| 3

[PATCH v2 12/12] drm/exynos: kill mode_set_nofb callback

2017-03-08 Thread Andrzej Hajda
All Exynos CRTCs are fully configured by .enable callback. The only users of mode_set_nofb actually did nothing in their callbacks - they immediately returned because devices were in suspend state - mode_set_nofb is always called on disabled device. Signed-off-by: Andrzej Hajda --- drivers/gpu/d

[PATCH v2 09/12] drm/exynos: kill exynos_drm_private::pipe

2017-03-08 Thread Andrzej Hajda
The field duplicates drm_dev->mode_config.num_crtc. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 18 -- drivers/gpu/drm/exynos/exynos7_drm_decon.c| 11 ++- drivers/gpu/drm/exynos/exynos_drm_drv.h | 3 --- drivers/gpu/drm/exyn

[PATCH v2 07/12] drm/exynos/decon5433: fix software trigger mask

2017-03-08 Thread Andrzej Hajda
The patch fixes copy/paste bug introduced during code refactoring. Reported-by: Dan Carpenter Fixes: b93c2e8b5d9d ("drm/exynos/decon5433: configure sysreg in case of hardware trigger")Fixes: Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 4 ++-- 1 file changed

[PATCH v2 03/12] drm/exynos/decon5433: fix vblank event handling

2017-03-08 Thread Andrzej Hajda
Current implementation of event handling assumes that vblank interrupt is always called at the right time. It is not true, it can be delayed due to various reasons. As a result different races can happen. The patch fixes the issue by using hardware frame counter present in DECON to serialize vblank

[PATCH v2 10/12] drm/exynos: set plane possible_crtcs in exynos_plane_init

2017-03-08 Thread Andrzej Hajda
All Exynos planes are assigned to exactly one CRTC, it allows to simplify initialization by moving setting of possible_crtcs to exynos_plane_init. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 2 +- drivers/gpu/drm/exynos/exynos7_drm_decon.c| 2 +- drivers/

[PATCH v2 11/12] drm/exynos: kill pipe field from drivers contexts

2017-03-08 Thread Andrzej Hajda
Since possible_crtcs are set by Exynos core helper pipe fields have no raison d'etre. The only place it was used, as a hack, is fimd_clear_channels, to avoid calling drm_crtc_handle_vblank, but DRM core has already other protection mechanism (vblank->enabled), so it could be safely removed. Signed

Re: [Intel-gfx] [PATCH 04/24] drm: Extract drm_pci.h

2017-03-08 Thread Gustavo Padovan
2017-03-08 Daniel Vetter : > Just another step in finally making drmP.h obsolete. > > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/drm_pci.c | 7 + > include/drm/drmP.h| 43 +++--- > include/drm/drm_pci.h | 78 > +

Re: [Intel-gfx] [PATCH 05/24] drm: Remove drmP.h include from drm_kms_helper_common.c

2017-03-08 Thread Gustavo Padovan
2017-03-08 Daniel Vetter : > An easy one as a drive-by. > > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/drm_kms_helper_common.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_kms_helper_common.c > b/drivers/gpu/drm/drm_kms_helper_common

  1   2   >