Re: [PATCH v4 5/6] drm/i915: enable scrambling

2017-02-23 Thread Ander Conselvan De Oliveira
On Thu, 2017-02-23 at 10:01 +0530, Sharma, Shashank wrote: > Regards > > Shashank > > > On 2/22/2017 10:59 PM, Ville Syrjälä wrote: > > On Wed, Feb 22, 2017 at 06:48:30PM +0530, Shashank Sharma wrote: > > > Geminilake platform sports a native HDMI 2.0 controller, and is > > > capable of driving

[drm:drm-next 1199/1208] drivers/gpu/drm/tinydrm/core/tinydrm-helpers.c:198:26: error: redefinition of 'tinydrm_of_find_backlight'

2017-02-23 Thread kbuild test robot
tree: git://people.freedesktop.org/~airlied/linux.git drm-next head: f81fa767077bbc9ac49c61ed97d28de09f3d069d commit: 9f69eb5c36a644571cca6b2f8dc5f6a7cba04a8b [1199/1208] drm/tinydrm: Add helper functions config: i386-allmodconfig (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20

[Bug 99881] Lockup/Freezes on Laptop with switchable graphics

2017-02-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99881 --- Comment #31 from Michel Dänzer --- (In reply to Matthew Fox from comment #30) > Just to confirm, the freezes and hard lockups still occur and the > corresponding messages in dmesg which I also attached. Weird; the xrandr output and Xorg log

[Bug 99907] linux-firmware 2017-02-17 update causes varying breaks in AMDGPU for recent cards

2017-02-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99907 --- Comment #12 from saunders...@wright.edu --- Arch has a testing update (linux-firmware-20170217.12987ca-2) that's the same git revison that was causing problems with the troublesome AMD commits reverted, and this has fixed both my RX 460 GPU ha

Re: KMS backlight ABI proposition

2017-02-23 Thread Jani Nikula
On Wed, 22 Feb 2017, Stéphane Marchesin wrote: > On Fri, Feb 17, 2017 at 4:58 AM, Martin Peres > wrote: >> If the KMS property exposes a fixed number of steps (say 100), it becomes >> easy for the userspace to express the wanted brightness. However, on drivers >> exposing less than these 100 step

Re: KMS backlight ABI proposition

2017-02-23 Thread Jani Nikula
On Wed, 22 Feb 2017, Hans de Goede wrote: > My first thought was that your proposal is reasonable, but on second > thought I foresee trouble here with e.g. the backlight level save / restore > code in systemd still using the sysfs interface, while the desktop > environment has moved on to the prop

Re: [PATCH v3 2/2] drm/fb-helper: implement ioctl FBIO_WAITFORVSYNC

2017-02-23 Thread Stefan Lengfeld
Hi Maxime, Hi Ville, On Wed, Feb 22, 2017 at 04:52:33PM -0800, Maxime Ripard wrote: > Hi Ville, Stefan, > > On Tue, Feb 21, 2017 at 12:55:01PM +0200, Ville Syrjälä wrote: > > On Tue, Feb 21, 2017 at 11:00:59AM +0100, Stefan Lengfeld wrote: > > > > > > Furthmore most exiting userspace code just p

[Bug 99850] Tessellation bug on Carrizo

2017-02-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99850 --- Comment #11 from Tom St Denis --- Thanks Michel, I was a bit quick in closing the bug. Note the bug description mentions the offending commit hash so instead of pasting that everywhere I called that HEAD and the good commit HEAD~. Conventio

[patch] drm/i915: return false on failure in intel_dp_compute_config()

2017-02-23 Thread Dan Carpenter
This function is a bool type where we are supposed to return false on failure and true on success. Negative error codes are currently treated as true. Fixes: a1b2278e4dfc ("drm/i915: skylake panel fitting using shared scalers") Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/i915/inte

Re: [PATCH v4 5/6] drm/i915: enable scrambling

2017-02-23 Thread Sharma, Shashank
Thanks for the review Ander, my comments, inline. Regards Shashank On 2/23/2017 1:33 PM, Ander Conselvan De Oliveira wrote: On Thu, 2017-02-23 at 10:01 +0530, Sharma, Shashank wrote: Regards Shashank On 2/22/2017 10:59 PM, Ville Syrjälä wrote: On Wed, Feb 22, 2017 at 06:48:30PM +0530, S

Re: [Intel-gfx] [patch] drm/i915: return false on failure in intel_dp_compute_config()

2017-02-23 Thread Joonas Lahtinen
On to, 2017-02-23 at 13:39 +0300, Dan Carpenter wrote: > This function is a bool type where we are supposed to return false on > failure and true on success.  Negative error codes are currently treated > as true. > > Fixes: a1b2278e4dfc ("drm/i915: skylake panel fitting using shared scalers") > Si

Re: [Intel-gfx] [patch] drm/i915: return false on failure in intel_dp_compute_config()

2017-02-23 Thread Dan Carpenter
On Thu, Feb 23, 2017 at 01:09:14PM +0200, Joonas Lahtinen wrote: > On to, 2017-02-23 at 13:39 +0300, Dan Carpenter wrote: > > This function is a bool type where we are supposed to return false on > > failure and true on success.  Negative error codes are currently treated > > as true. > > > > Fixe

Re: [PATCH v4 1/6] drm: Add SCDC helpers

2017-02-23 Thread Ville Syrjälä
On Thu, Feb 23, 2017 at 08:51:03AM +0530, Sharma, Shashank wrote: > Thanks for the review Ville, my comments inline. > > Regards > > Shashank > > > On 2/22/2017 10:39 PM, Ville Syrjälä wrote: > > On Wed, Feb 22, 2017 at 06:48:26PM +0530, Shashank Sharma wrote: > >> From: Thierry Reding > >> >

Re: [PATCH v4 4/6] drm: scrambling support in drm layer

2017-02-23 Thread Ville Syrjälä
On Thu, Feb 23, 2017 at 09:05:16AM +0530, Sharma, Shashank wrote: > Regards > > Shashank > > > On 2/22/2017 10:54 PM, Ville Syrjälä wrote: > > On Wed, Feb 22, 2017 at 06:48:29PM +0530, Shashank Sharma wrote: > >> HDMI 2.0 spec mandates scrambling for modes with pixel clock higher > >> than 340 M

Re: [PATCH v4 1/6] drm: Add SCDC helpers

2017-02-23 Thread Sharma, Shashank
Regards Shashank On 2/23/2017 5:11 PM, Ville Syrjälä wrote: On Thu, Feb 23, 2017 at 08:51:03AM +0530, Sharma, Shashank wrote: Thanks for the review Ville, my comments inline. Regards Shashank On 2/22/2017 10:39 PM, Ville Syrjälä wrote: On Wed, Feb 22, 2017 at 06:48:26PM +0530, Shashank S

Re: [PATCH v4 4/6] drm: scrambling support in drm layer

2017-02-23 Thread Sharma, Shashank
Regards Shashank On 2/23/2017 5:15 PM, Ville Syrjälä wrote: On Thu, Feb 23, 2017 at 09:05:16AM +0530, Sharma, Shashank wrote: Regards Shashank On 2/22/2017 10:54 PM, Ville Syrjälä wrote: On Wed, Feb 22, 2017 at 06:48:29PM +0530, Shashank Sharma wrote: HDMI 2.0 spec mandates scrambling fo

Re: [PATCH v4 5/6] drm/i915: enable scrambling

2017-02-23 Thread Ander Conselvan De Oliveira
On Thu, 2017-02-23 at 16:33 +0530, Sharma, Shashank wrote: > Thanks for the review Ander, my comments, inline. > > > Regards > > Shashank > > > On 2/23/2017 1:33 PM, Ander Conselvan De Oliveira wrote: > > On Thu, 2017-02-23 at 10:01 +0530, Sharma, Shashank wrote: > > > Regards > > > > > > Sha

[Bug 97590] Fury X (Fiji) LEDs do not reflect GPU load

2017-02-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97590 --- Comment #7 from network...@rkmail.ru --- AFAIK, Sapphire RX480/470 Nitro boards also have LEDs that change colors depending on GPU Load / temperature (displaying mode can be switched with hardware button). Would it work for them too? -- You

Re: [PATCH v4 5/6] drm/i915: enable scrambling

2017-02-23 Thread Ville Syrjälä
On Thu, Feb 23, 2017 at 03:07:40PM +0200, Ander Conselvan De Oliveira wrote: > On Thu, 2017-02-23 at 16:33 +0530, Sharma, Shashank wrote: > > Thanks for the review Ander, my comments, inline. > > > > > > Regards > > > > Shashank > > > > > > On 2/23/2017 1:33 PM, Ander Conselvan De Oliveira wro

[PATCH 3/3] drm/tinydrm: helpers: Properly fix backlight dependency

2017-02-23 Thread Noralf Trønnes
BACKLIGHT_CLASS_DEVICE was selected in the last version of the tinydrm patchset to fix the backlight dependency, but the ifdef CONFIG_BACKLIGHT_CLASS_DEVICE was forgotten. Fix that. Signed-off-by: Noralf Trønnes --- include/drm/tinydrm/tinydrm-helpers.h | 19 --- 1 file changed,

[PATCH 1/3] drm/tinydrm: mipi-dbi: Silence: ‘cmd’ may be used uninitialized

2017-02-23 Thread Noralf Trønnes
Fix this warning: drivers/gpu/drm/tinydrm/mipi-dbi.c: In function ‘mipi_dbi_debugfs_command_write’: drivers/gpu/drm/tinydrm/mipi-dbi.c:905:8: warning: ‘cmd’ may be used uninitialized in this function [-Wmaybe-uninitialized] ret = mipi_dbi_command_buf(mipi, cmd, parameters, i); ^

[PATCH 2/3] drm/tinydrm: mipi-dbi: Fix field width specifier warning

2017-02-23 Thread Noralf Trønnes
This warning is seen on 64-bit builds in functions: 'mipi_dbi_typec1_command': 'mipi_dbi_typec3_command_read': 'mipi_dbi_typec3_command': >> drivers/gpu/drm/tinydrm/mipi-dbi.c:65:20: warning: field width specifier '*' >> expects argument of type 'int', but argument 5 has type 'size_t {ak

[PATCH 0/3] drm/tinydrm: Fix compiler warnings

2017-02-23 Thread Noralf Trønnes
Dave pulled tinydrm yesterday which triggered some compiler warnings: Dave Airlie: drivers/gpu/drm/tinydrm/mipi-dbi.c: In function ‘mipi_dbi_debugfs_command_write’: drivers/gpu/drm/tinydrm/mipi-dbi.c:905:8: warning: ‘cmd’ may be used uninitialized in this function [-Wmaybe-uninitialized] ret =

Re: KMS backlight ABI proposition

2017-02-23 Thread Hans de Goede
Hi, On 23-02-17 09:40, Jani Nikula wrote: On Wed, 22 Feb 2017, Stéphane Marchesin wrote: On Fri, Feb 17, 2017 at 4:58 AM, Martin Peres wrote: If the KMS property exposes a fixed number of steps (say 100), it becomes easy for the userspace to express the wanted brightness. However, on drivers

Re: KMS backlight ABI proposition

2017-02-23 Thread Hans de Goede
Hi, On 23-02-17 09:55, Jani Nikula wrote: On Wed, 22 Feb 2017, Hans de Goede wrote: My first thought was that your proposal is reasonable, but on second thought I foresee trouble here with e.g. the backlight level save / restore code in systemd still using the sysfs interface, while the deskto

[Bug 97590] Fury X (Fiji) LEDs do not reflect GPU load

2017-02-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97590 --- Comment #8 from Alex Deucher --- (In reply to network723 from comment #7) > AFAIK, Sapphire RX480/470 Nitro boards also have LEDs that change colors > depending on GPU Load / temperature (displaying mode can be switched with > hardware button

Re: [PULL] tinydrm

2017-02-23 Thread Noralf Trønnes
Den 23.02.2017 02.20, skrev Dave Airlie: On 19 February 2017 at 04:22, Noralf Trønnes wrote: Hi Dave, Please pull tinydrm. Pulled, just FYI I've seen this on my 32-bit arm builds. Thanks Dave. I've sent a patchset to fix that and a couple of other warnings. Noralf. CC [M] drivers/g

[Bug 99881] Lockup/Freezes on Laptop with switchable graphics

2017-02-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99881 --- Comment #32 from Alex Deucher --- Does your kernel have this patch? http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/drivers/gpu/drm/radeon/radeon_device.c?id=066f1f0b4719eb4573ef09bfc63c2bbb6f7676ca -- You are receiving

[Bug 97590] Fury X (Fiji) LEDs do not reflect GPU load

2017-02-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97590 --- Comment #9 from Adam Bolte --- I'm very excited to say that this patch is working great. Huge thanks! I know it's crazy but there's something very satisfying about having the LEDs show what the cards are doing. :) I noticed attachment 129828

Re: [PATCH] drm/radeon/dp_auxch: Ratelimit aux transfer debug messages

2017-02-23 Thread Alex Deucher
On Wed, Feb 22, 2017 at 4:34 PM, Lyude wrote: > Aux transfers always fail with non-zero status flags when there's > nothing connected on the port, so we don't usually need to see all of > the debugging information from it. Also, we try reprobing a -lot-, so > without ratelimiting most of the kerne

Re: [PATCH trivial 3/4] drm/amd: Spelling s/SDMA_WRTIE_SUB_OPCODE_TILED/SDMA_WRITE_SUB_OPCODE_TILED/

2017-02-23 Thread Alex Deucher
On Sat, Feb 18, 2017 at 4:17 AM, Christian König wrote: > Am 17.02.2017 um 16:36 schrieb Geert Uytterhoeven: >> >> Signed-off-by: Geert Uytterhoeven >> Cc: Alex Deucher >> Cc: Christian König >> Cc: dri-devel@lists.freedesktop.orgamd-...@lists.freedesktop.org > > > Reviewed-by: Christian König

Re: [PATCH 17/35] drivers/gpu: Convert remaining uses of pr_warning to pr_warn

2017-02-23 Thread Alex Deucher
On Sat, Feb 18, 2017 at 12:03 AM, Edward O'Callaghan wrote: > > > On 02/18/2017 01:22 AM, Christian König wrote: >> Am 17.02.2017 um 08:11 schrieb Joe Perches: >>> To enable eventual removal of pr_warning >>> >>> This makes pr_warn use consistent for drivers/gpu >>> >>> Prior to this patch, there

Re: [Intel-gfx] [PATCH 1/3] drm/atomic: Make disable_all helper fully disable the crtc.

2017-02-23 Thread Sean Paul
On Tue, Feb 21, 2017 at 02:51:40PM +0100, Maarten Lankhorst wrote: > It seems that nouveau requires this, so best to do this in the helper. > This allows nouveau to use the atomic suspend helper. Pardon the stupid question, but why can't nouveau just do the right thing when crtc_state->active beco

[Bug 99923] HITMAN (2016) having lighting and artefacting, and overly light room.

2017-02-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99923 Bug ID: 99923 Summary: HITMAN (2016) having lighting and artefacting, and overly light room. Product: Mesa Version: git Hardware: Other OS: All

[Bug 99923] HITMAN (2016) having lighting and artefacting, and overly light room.

2017-02-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99923 thedribbleo...@gmail.com changed: What|Removed |Added Hardware|Other |x86-64 (AMD64)

Re: [PATCH v4 5/6] drm/i915: enable scrambling

2017-02-23 Thread Sharma, Shashank
Think about two situations where:- - Monitor supports scrambling and scdc, but we will not enable it, as the current mode is 1080P@148 MHz - Monitor supports scrambling and scdc, and we will enable it, as the current mode is 4k@596 Mhz To differentiate between these two, we have: config->hdmi_s

Re: [PATCH 2/3] drm: Convert drm_framebuffer_remove to atomic, v4.

2017-02-23 Thread Sean Paul
On Tue, Feb 21, 2017 at 02:51:41PM +0100, Maarten Lankhorst wrote: > Instead of trying to do everything in 1 go, just do a basic safe > conversion first. We've been bitten by too many regressions in the > past. > > This patch only converts drm_framebuffer_remove to atomic. The > regression sensiti

Re: [PATCH 3/3] drm/atomic: Try to preserve the crtc enabled state in drm_atomic_remove_fb.

2017-02-23 Thread Sean Paul
On Tue, Feb 21, 2017 at 02:51:42PM +0100, Maarten Lankhorst wrote: > This introduces a slight behavioral change to rmfb. Instead of > disabling a crtc when the primary plane is disabled, we try to > preserve it. > > Apart from old versions of the vmwgfx xorg driver, there is > nothing depending on

[Bug 97590] Fury X (Fiji) LEDs do not reflect GPU load

2017-02-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97590 --- Comment #10 from Adam Bolte --- I found the repo (git://people.freedesktop.org/~agd5f/linux and the drm-next-4.12-wip branch with the commit already applied), so I built that for testing but didn't have any luck. The primary GPU LEDs were stu

[Bug 99923] HITMAN (2016) having lighting and artefacting, and overly light room.

2017-02-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99923 --- Comment #1 from Samuel Pitoiset --- Thanks for reporting this. Hitman used to work very nicely recently. I will have a look. -- You are receiving this mail because: You are the assignee for the bug.__

[Bug 97590] Fury X (Fiji) LEDs do not reflect GPU load

2017-02-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97590 --- Comment #11 from Alex Deucher --- Use whichever patch applies to your tree. They are identical other than some fuzz related to other changes in the same file depending on what kernel version you are using. -- You are receiving this mail be

Re: [PATCH RFC] drm/sun4i: rgb: Add 5% tolerance to dot clock frequency check

2017-02-23 Thread Sean Paul
On Wed, Dec 07, 2016 at 11:48:55AM +0200, Laurent Pinchart wrote: > Hello, > > On Wednesday 07 Dec 2016 10:26:25 Chen-Yu Tsai wrote: > > On Wed, Dec 7, 2016 at 1:29 AM, Maxime Ripard wrote: > > > On Thu, Nov 24, 2016 at 07:22:31PM +0800, Chen-Yu Tsai wrote: > > >> The panels shipped with Allwinner

[Bug 99923] HITMAN (2016) having lighting and artefacting, and overly light room.

2017-02-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99923 --- Comment #2 from Samuel Pitoiset --- Can you provide the following information, please. - Which mesa-git version? - Which LLVM version? - Which graphics settings in Hitman? After a quick try I can't reproduce right now. -- You are receivin

Re: [PATCH] drm/nouveau: gk20a: Turn instmem lock into mutex

2017-02-23 Thread Thierry Reding
On Mon, Jan 30, 2017 at 09:03:07PM +0100, Thierry Reding wrote: > From: Thierry Reding > > The gk20a implementation of instance memory uses vmap()/vunmap() to map > memory regions into the kernel's virtual address space. These functions > may sleep, so protecting them by a spin lock is not safe.

[Bug 99907] linux-firmware 2017-02-17 update causes varying breaks in AMDGPU for recent cards

2017-02-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99907 --- Comment #13 from Alex Deucher --- Does the new firmware work properly with kernel 4.10 or newer? -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list

[Bug 99907] linux-firmware 2017-02-17 update causes varying breaks in AMDGPU for recent cards

2017-02-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99907 --- Comment #14 from saunders...@wright.edu --- Which new firmware? The one you linked earlier in the discussion, or the new setup with the one git commit reverted? -- You are receiving this mail because: You are the assignee for the bug.___

[Bug 99907] linux-firmware 2017-02-17 update causes varying breaks in AMDGPU for recent cards

2017-02-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99907 --- Comment #15 from Alex Deucher --- (In reply to saunders.52 from comment #14) > Which new firmware? The one you linked earlier in the discussion, or the new > setup with the one git commit reverted? Either or both. -- You are receiving this

[Bug 99907] linux-firmware 2017-02-17 update causes varying breaks in AMDGPU for recent cards

2017-02-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99907 --- Comment #16 from saunders...@wright.edu --- (In reply to Alex Deucher from comment #15) > (In reply to saunders.52 from comment #14) > > Which new firmware? The one you linked earlier in the discussion, or the new > > setup with the one git co

[Bug 99907] linux-firmware 2017-02-17 update causes varying breaks in AMDGPU for recent cards

2017-02-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99907 --- Comment #17 from Alex Deucher --- (In reply to saunders.52 from comment #16) > > The GIT commit reversion should be similar enough to a manual change I tried > with both 4.9 and 4.10 I can almost certainly say it would work (trying the > old

[Bug 99907] linux-firmware 2017-02-17 update causes varying breaks in AMDGPU for recent cards

2017-02-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99907 --- Comment #18 from saunders...@wright.edu --- (In reply to Alex Deucher from comment #17) > (In reply to saunders.52 from comment #16) > > > > The GIT commit reversion should be similar enough to a manual change I tried > > with both 4.9 and 4.

[Bug 99907] linux-firmware 2017-02-17 update causes varying breaks in AMDGPU for recent cards

2017-02-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99907 --- Comment #20 from saunders...@wright.edu --- And I didn't check the one you linked in 4.10. I think. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing li

[Bug 99907] linux-firmware 2017-02-17 update causes varying breaks in AMDGPU for recent cards

2017-02-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99907 --- Comment #19 from saunders...@wright.edu --- Well, the one you linked above didn't work in 4.9. The one shipping in the repos that is getting reverted (20170217.12987ca-1) didn't work in 4.9 and 4.10. The oldest of the three (the one shipped or

[Bug 99907] linux-firmware 2017-02-17 update causes varying breaks in AMDGPU for recent cards

2017-02-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99907 --- Comment #21 from Alex Deucher --- (In reply to saunders.52 from comment #19) > Are there some version numbers I can refer to these by to make this less > insanely confusing? The 5th dword in each binary is the version. -- You are receiving

[Bug 99923] HITMAN (2016) having lighting and artefacting, and overly light room.

2017-02-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99923 --- Comment #3 from thedribbleo...@gmail.com --- (In reply to Samuel Pitoiset from comment #2) > Can you provide the following information, please. > > - Which mesa-git version? > - Which LLVM version? > - Which graphics settings in Hitman? > >

[PATCH] drm/tinydrm: fix semicolon.cocci warnings

2017-02-23 Thread kbuild test robot
drivers/gpu/drm/tinydrm/core/tinydrm-helpers.c:454:2-3: Unneeded semicolon Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci Signed-off-by: Fengguang Wu --- tinydrm-helpers.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/gpu/drm/tinyd

[drm-intel:drm-intel-nightly 1827/1945] drivers/gpu/drm/tinydrm/core/tinydrm-helpers.c:454:2-3: Unneeded semicolon

2017-02-23 Thread kbuild test robot
tree: git://anongit.freedesktop.org/drm-intel drm-intel-nightly head: 53a95c930ad728b11cc2b21e42b4bd9dcd306400 commit: 9f69eb5c36a644571cca6b2f8dc5f6a7cba04a8b [1827/1945] drm/tinydrm: Add helper functions coccinelle warnings: (new ones prefixed by >>) >> drivers/gpu/drm/tinydrm/core/tinydr

Re: [PATCH v2] drm/rockchip: cdn-dp: Fix error handling

2017-02-23 Thread Sean Paul
On Mon, Feb 20, 2017 at 08:08:15AM +0100, Christophe JAILLET wrote: > It is likely that both 'clk_disable_unprepare()' should be called if > 'pm_runtime_get_sync()' fails. > > Add a new label for that, because 'err_set_rate' is not meaningful in this > case. > > Add a missing call to 'pm_runtime_

Re: [PATCH] drm/rockchip: add extcon dependency for DP

2017-02-23 Thread Sean Paul
On Tue, Feb 14, 2017 at 10:31:51PM +0100, Arnd Bergmann wrote: > The newly added DP driver links against the extcon core, which fails when > extcon is a module and this driver is not: > > drivers/gpu/drm/rockchip/cdn-dp-core.o: In function `cdn_dp_get_port_lanes': > cdn-dp-core.c:(.text.cdn_dp_get

[Bug 99907] linux-firmware 2017-02-17 update causes varying breaks in AMDGPU for recent cards

2017-02-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99907 --- Comment #22 from saunders...@wright.edu --- Okay, assuming I'm reading this right with hexdump... On an RX 460 (4 GB): Old Committed Version (0080 ): Works on 4.9 and 4.10. New Committed Version, Now Uncommitted (0083 ): Does not work

[Bug 99923] HITMAN (2016) having lighting and artefacting, and overly light room.

2017-02-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99923 --- Comment #4 from Samuel Pitoiset --- Okay, that makes more sense. I only have a RX480, so I definitely can't help here. If you get a chance, can you try recording an apitrace which reproduces? That might other devs. Thanks. -- You are rece

[Bug 99917] Failure to load bonaire_k_smc.bin in kernels 4.8-4.10

2017-02-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99917 --- Comment #2 from Leonid --- Correct. What I needed: 1) update kernel; 2) update firmware; 3) update initrd; 4) reboot. Just in that sequence. This fixed the problem. Thank you for the helpful hint. -- You are receiving this mail because: You

[Bug 99923] HITMAN (2016) having lighting and artefacting, and overly light room.

2017-02-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99923 --- Comment #5 from thedribbleo...@gmail.com --- (In reply to Samuel Pitoiset from comment #4) > Okay, that makes more sense. I only have a RX480, so I definitely can't help > here. > > If you get a chance, can you try recording an apitrace which

Re: KMS backlight ABI proposition

2017-02-23 Thread Stéphane Marchesin
On Thu, Feb 23, 2017 at 12:40 AM, Jani Nikula wrote: > On Wed, 22 Feb 2017, Stéphane Marchesin wrote: >> On Fri, Feb 17, 2017 at 4:58 AM, Martin Peres >> wrote: >>> If the KMS property exposes a fixed number of steps (say 100), it becomes >>> easy for the userspace to express the wanted brightne

[GIT PULL] drm/tegra: Changes for v4.11-rc1

2017-02-23 Thread Thierry Reding
Hi Dave, The following changes since commit 7ce7d89f48834cefece7804d38fc5d85382edf77: Linux 4.10-rc1 (2016-12-25 16:13:08 -0800) are available in the git repository at: git://anongit.freedesktop.org/tegra/linux tags/drm/tegra/for-4.11-rc1 for you to fetch changes up to 7b1d4185050d204d6381

[GIT PULL] drm/panel: Changes for v4.11-rc1

2017-02-23 Thread Thierry Reding
Hi Dave, The following changes since commit 0c744ea4f77d72b3dcebb7a8f2684633ec79be88: Linux 4.10-rc2 (2017-01-01 14:31:53 -0800) are available in the git repository at: git://anongit.freedesktop.org/tegra/linux tags/drm/panel/for-4.11-rc1 for you to fetch changes up to eaeebffa90f35e0f9265

Re: KMS backlight ABI proposition

2017-02-23 Thread Jasper St. Pierre
On Thu, Feb 23, 2017 at 12:40 AM, Jani Nikula wrote: > On Wed, 22 Feb 2017, Stéphane Marchesin > wrote: > > On Fri, Feb 17, 2017 at 4:58 AM, Martin Peres > > wrote: > >> If the KMS property exposes a fixed number of steps (say 100), it > becomes > >> easy for the userspace to express the wanted

Re: [PATCH 4/8] drm/sun4i: add support for sun8i DE2 mixers and display engines

2017-02-23 Thread Emil Velikov
On 22 February 2017 at 15:18, Icenowy Zheng wrote: > Allwinner have a new "Display Engine 2.0" in there new SoCs, which comes > in a new "Display Engine" (mixers instead of old backends and > frontends). > > Add support for the mixer on Allwinner V3s SoC; it's the simplest one. > > Signed-off-by:

[Bug 99628] AMD Radeon HD 8600M graphics card doesn't work with amdgpu

2017-02-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99628 mohsen2120habibik...@gmail.com changed: What|Removed |Added Resolution|--- |FIXED Status

Re: [GIT PULL] drm/rockchip: some fixes

2017-02-23 Thread Sean Paul
On Thu, Feb 23, 2017 at 10:03:23AM +0800, Mark yao wrote: > On 2017年02月23日 00:09, Sean Paul wrote: > >On Tue, Feb 21, 2017 at 7:54 PM, Mark yao wrote: > >>Hi Dave > >> > >>Some fixes, looks good to me. > >> > >Hi Mark, > >As we discussed, rockchip patches should now go through -misc. Since > >4.10

Re: [PATCH 01/11] drm/sun4i: Make sunxi_rgb2yuv_coef constant

2017-02-23 Thread Maxime Ripard
On Thu, Feb 23, 2017 at 04:05:33PM +0800, Chen-Yu Tsai wrote: > sunxi_rgb2yuv_coef is a table of RGB-to-YUV conversion coefficients. > They are programmed into the hardware, and can be declared constant. > > Reported-by: Priit Laes > Signed-off-by: Chen-Yu Tsai Applied, thanks! Maxime -- Maxi

Re: [PATCH 02/11] drm/sun4i: Set drm_crtc.port to the underlying TCON's output port node

2017-02-23 Thread Maxime Ripard
On Thu, Feb 23, 2017 at 04:05:34PM +0800, Chen-Yu Tsai wrote: > The way drm_of_find_possible_crtcs is it tries to match the Aren't you missing "works" here ^ > remote-endpoint of the given node's various endpoints to all the > crtc's .port field. Thus we need to set drm_crtc.port to the outpu

Re: [PATCH 03/11] drm/sun4i: Add end of list element for sun4i_layers_init's returned list

2017-02-23 Thread Maxime Ripard
On Thu, Feb 23, 2017 at 04:05:35PM +0800, Chen-Yu Tsai wrote: > The number of defined planes in sun4i_layer is unknown to other parts > of the sun4i drm driver. Since the return value of sun4i_layers_init > is a list of layers, make it return 1 more empty layer as an end of > list guard value. > >

Re: [PATCH 04/11] drm/sun4i: Move layers from sun4i_drv to sun4i_crtc

2017-02-23 Thread Maxime Ripard
On Thu, Feb 23, 2017 at 04:05:36PM +0800, Chen-Yu Tsai wrote: > This patch moves the sun4i_layers_init call from sun4i_drv_bind to > sun4i_crtc_init, and the layers pointer from struct sun4i_drv to > struct sun4i_crtc. > > The layers are bound to a specific crtc, and they are not directly > used o

Re: [PATCH 05/11] drm/sun4i: Initialize crtc from tcon bind function

2017-02-23 Thread Maxime Ripard
On Thu, Feb 23, 2017 at 04:05:37PM +0800, Chen-Yu Tsai wrote: > The tcon provides part of the functionality of the crtc, and also > provides the device node for the output port of the crtc. To be able > to use drm_of_find_possible_crtcs(), all crtc must be initialized before > any downstream encode

Re: [PATCH 06/11] drm/sun4i: Drop primary layer pointer from sun4i_drv

2017-02-23 Thread Maxime Ripard
On Thu, Feb 23, 2017 at 04:05:38PM +0800, Chen-Yu Tsai wrote: > The current layer init code keeps a pointer to the primary plane layer > in sun4i_drv. When we eventually support multiple display pipelines, > this would force us to keep track of primary planes for all crtcs. And > these pointers onl

Re: [PATCH 11/11] drm/sun4i: Add backend and tcon pointers to sun4i_crtc

2017-02-23 Thread Maxime Ripard
On Thu, Feb 23, 2017 at 04:05:43PM +0800, Chen-Yu Tsai wrote: > sun4i_crtc controls the backend and tcon hardware blocks of the display > pipeline. Instead of doing so through the master drm structure, leave > pointers to the corresponding backend and tcon in itself. > > Also drop the drm_device p

[Bug 99907] linux-firmware 2017-02-17 update causes varying breaks in AMDGPU for recent cards

2017-02-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99907 --- Comment #23 from saunders...@wright.edu --- I was able to get back to the machine in question sooner than I thought. The version you have for download in Comment 2, (0086 ) does not work on 4.10, and has the same crash issue. -- You are

Re: [PATCH] drm: Add name for DRM_DP_DUAL_MODE_LSPCON

2017-02-23 Thread Sean Paul
On Wed, Feb 22, 2017 at 02:59:28PM +0200, Ander Conselvan de Oliveira wrote: > Handle DRM_DP_DUAL_MODE_LSPCON in drm_dp_get_dual_mode_type_name(), > otherwise a call to that function can theoretically trigger a WARN. > > Fixes: 056996b95686 ("drm: Helper for lspcon in drm_dp_dual_mode") > Cc: Shas

Re: [PATCH] drm/bridge/sii8620: add missing error handling in probe

2017-02-23 Thread Sean Paul
On Wed, Feb 22, 2017 at 12:47:37PM +0100, Andrzej Hajda wrote: > devm_request_threaded_irq result should be checked for errors. > > Signed-off-by: Andrzej Hajda Applied to -misc Thanks, Sean > --- > drivers/gpu/drm/bridge/sil-sii8620.c | 4 > 1 file changed, 4 insertions(+) > > diff --

[Bug 99679] DRI PRIME doesn't always work with intel/radeon

2017-02-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99679 --- Comment #2 from Levente Abrok --- It might sound lame, but since then I haven't encountered the situation. Maybe it was an update or I don't really know. For now, let's call this solved, hopefully it was truly something already fixed. Sorry f

[Bug 99136] Blood Effects Total War: Warhammer

2017-02-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99136 --- Comment #33 from siyia --- ok but do you have a fileserver where i can upload it? -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@list

[pull] amdgpu and ttm drm-next-4.11

2017-02-23 Thread Alex Deucher
Hi Dave, Just a few fixes for 4.11. The following changes since commit 9ca70356a9260403c1bda40d942935e55d00c11c: Revert "drm: Resurrect atomic rmfb code, v3" (2017-02-17 12:39:04 +1000) are available in the git repository at: git://people.freedesktop.org/~agd5f/linux drm-next-4.11 for you

Re: [Intel-gfx] [PATCH 1/3] drm/atomic: Make disable_all helper fully disable the crtc.

2017-02-23 Thread Maarten Lankhorst
Op 23-02-17 om 16:03 schreef Sean Paul: > On Tue, Feb 21, 2017 at 02:51:40PM +0100, Maarten Lankhorst wrote: >> It seems that nouveau requires this, so best to do this in the helper. >> This allows nouveau to use the atomic suspend helper. > Pardon the stupid question, but why can't nouveau just do

[Bug 99881] Lockup/Freezes on Laptop with switchable graphics

2017-02-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99881 --- Comment #33 from Matthew Fox --- Hi, With runpm enabled & radeon.audio=0, the computer locks up requiring a hard shutdown. With runpm enabled & radeon.audio=0 & xorg.conf workaround, ditto. Except sometimes instead the computer will lock up

[Bug 97590] Fury X (Fiji) LEDs do not reflect GPU load

2017-02-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97590 --- Comment #12 from Adam Bolte --- Good to know it doesn't matter for testing purposes. In that case, I'm happy for this to be marked as fixed - unless the policy on doing that is to wait until the patch is accepted upstream? -- You are receiv

[Bug 97590] Fury X (Fiji) LEDs do not reflect GPU load

2017-02-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97590 --- Comment #13 from Alex Deucher --- I've queued the patch for upstream. I'll close it once the patch makes it into Linus' tree. -- You are receiving this mail because: You are the assignee for the bug.

[Bug 99136] Blood Effects Total War: Warhammer

2017-02-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99136 --- Comment #34 from Pierre-Loup A. Griffais --- You can use this link: https://www.dropbox.com/request/mk4YGOBOp4oqX0TKciu7 When you're done uploading the trace I'll post the link to the trace in this bug report. Thanks! -- You are receivin

[PATCH 01/12] drm/ast: Fix AST2400 POST failure without BMC FW or VBIOS

2017-02-23 Thread Benjamin Herrenschmidt
From: "Y.C. Chen" The current POST code for the AST2300/2400 family doesn't work properly if the chip hasn't been initialized previously by either the BMC own FW or the VBIOS. This fixes it. Signed-off-by: Y.C. Chen Signed-off-by: Benjamin Herrenschmidt --- drivers/gpu/drm/ast/ast_post.c | 38

[PATCH 03/12] drm/ast: const'ify mode setting tables

2017-02-23 Thread Benjamin Herrenschmidt
And fix some comment alignment & space/tabs while at it Signed-off-by: Benjamin Herrenschmidt --- drivers/gpu/drm/ast/ast_drv.h| 4 +- drivers/gpu/drm/ast/ast_mode.c | 8 +-- drivers/gpu/drm/ast/ast_tables.h | 106 +++ 3 files changed, 59 insertions(

[PATCH 02/12] drm/ast: Handle configuration without P2A bridge

2017-02-23 Thread Benjamin Herrenschmidt
From: Russell Currey The ast driver configures a window to enable access into BMC memory space in order to read some configuration registers. If this window is disabled, which it can be from the BMC side, the ast driver can't function. Closing this window is a necessity for security if a machin

[PATCH 04/12] drm/ast: Remove spurrious include

2017-02-23 Thread Benjamin Herrenschmidt
Signed-off-by: Benjamin Herrenschmidt --- drivers/gpu/drm/ast/ast_main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/ast/ast_main.c b/drivers/gpu/drm/ast/ast_main.c index 36932a3..718c15b 100644 --- a/drivers/gpu/drm/ast/ast_main.c +++ b/drivers/gpu/drm/ast/ast_main.c @@

[PATCH 07/12] drm/ast: Fixed vram size incorrect issue on POWER

2017-02-23 Thread Benjamin Herrenschmidt
From: "Y.C. Chen" The default value of VGA scratch may incorrect. Should initial h/w before get vram info. Signed-off-by: Y.C. Chen --- drivers/gpu/drm/ast/ast_main.c | 6 +++--- drivers/gpu/drm/ast/ast_post.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/d

[PATCH 05/12] drm/ast: Fix calculation of MCLK

2017-02-23 Thread Benjamin Herrenschmidt
Some braces were missing causing an incorrect calculation. Y.C. Chen from Aspeed provided me with the right formula which I tested on AST2400 and 2500. The MCLK isn't currently used by the driver (it will eventually to filter modes) so the issue isn't catastrophic. Also make the printed value a

Re: [PATCH 3/8] mm: cma: Export a few symbols

2017-02-23 Thread Maxime Ripard
On Mon, Feb 20, 2017 at 01:35:50PM +0100, Michal Hocko wrote: > On Mon 13-02-17 14:44:16, Maxime Ripard wrote: > > Hi Michal, > > > > On Thu, Feb 09, 2017 at 08:20:47PM +0100, Michal Hocko wrote: > > > [CC CMA people] > > > > > > On Thu 09-02-17 17:39:17, Maxime Ripard wrote: > > > > Modules migh

[PATCH 10/12] drm/ast: POST code for the new AST2500

2017-02-23 Thread Benjamin Herrenschmidt
From: "Y.C. Chen" This is used when the BMC isn't running any code and thus has to be initialized by the host. The code originates from Aspeed (Y.C. Chen) and has been cleaned up for coding style purposes by BenH. Signed-off-by: Y.C. Chen Signed-off-by: Benjamin Herrenschmidt -- v2. - Fix bu

[PATCH 12/12] drm/ast: Call open_key before enable_mmio in POST code

2017-02-23 Thread Benjamin Herrenschmidt
From: "Y.C. Chen" open_key enables access the registers used by enable_mmio Signed-off-by: Y.C. Chen Signed-off-by: Benjamin Herrenschmidt --- drivers/gpu/drm/ast/ast_post.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ast/ast_post.c b/drivers/gpu/drm/as

Re: [PATCH 01/12] drm/ast: Fix AST2400 POST failure without BMC FW or VBIOS

2017-02-23 Thread Benjamin Herrenschmidt
Note: The whole series with the fixed cset comment for patch 11 can be also found there: https://github.com/ozbenh/linux-ast/commits/master Cheers, Ben. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/li

[PATCH 08/12] drm/ast: Factor mmc_test code in POST code

2017-02-23 Thread Benjamin Herrenschmidt
There's a some duplication for what's essentially copies of two loops, so factor it. The upcoming AST2500 POST code adds more of them. Also cleanup return types for the test functions, most of them return a boolean, some return a u32. Signed-off-by: Benjamin Herrenschmidt -- v2. - Keep the split

[PATCH 06/12] drm/ast: Base support for AST2500

2017-02-23 Thread Benjamin Herrenschmidt
From: "Y.C. Chen" Add detection and mode setting updates for AST2500 generation chip, code originally from Aspeed and slightly reworked for coding style mostly by Ben. This doesn't contain the BMC DRAM POST code which is in a separate patch. Signed-off-by: Y.C. Chen Signed-off-by: Benjamin Herr

[PATCH 09/12] drm/ast: Rename ast_init_dram_2300 to ast_post_chip_2300

2017-02-23 Thread Benjamin Herrenschmidt
The function does more than initializing the DRAM and in turns calls other functions to do the actual init. This will keeping things more consistent with the upcoming AST2500 POST code. Signed-off-by: Benjamin Herrenschmidt --- drivers/gpu/drm/ast/ast_post.c | 6 +++--- 1 file changed, 3 inserti

  1   2   >