Re: [PATCH v3] drm/edid: Complete CEA modedb(VIC 1-107)

2017-01-30 Thread Andrzej Hajda
On 29.01.2017 06:41, Shashank Sharma wrote: > CEA-861-F specs defines new 4k video modes to be used with > HDMI 2.0 EDIDs. These modes start at VIC=93 and go all the > way till VIC=107. > > Our existing CEA modedb contains only 64 modes (VIC=1 to VIC=64). Now > to be able to parse 4k modes using th

Re: make fbdev/fbcon switchable per driver?

2017-01-30 Thread Gerd Hoffmann
Hi, > The vgaarb code has a concept of a vga_default_device(), it's rather > PCI-centric, but maybe better than nothing. This is typically the > first VGA class code device found with I/O and MMIO enabled. If fbcon > defaulted to running on the vga_default_device(), a user could select > which

Re: [PATCH 1/4] drm: qxl: Drop misleading comment

2017-01-30 Thread Gerd Hoffmann
Hi, > Do you want to merge from drm-misc or should we push this one > directly via drm-misc? Merging through drm-misc is fine with me. cheers, Gerd ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/li

Re: [Intel-gfx] [PATCH 0/3] drm/i915: Handle hanging during nonblocking modeset correctly.

2017-01-30 Thread Daniel Vetter
On Fri, Jan 27, 2017 at 03:08:45PM +, Chris Wilson wrote: > On Fri, Jan 27, 2017 at 03:58:08PM +0100, Daniel Vetter wrote: > > On Fri, Jan 27, 2017 at 02:31:55PM +, Chris Wilson wrote: > > > On Fri, Jan 27, 2017 at 03:21:29PM +0100, Daniel Vetter wrote: > > > > On Fri, Jan 27, 2017 at 09:30

Re: RFC: drm-misc for small drivers?

2017-01-30 Thread Daniel Vetter
On Fri, Jan 27, 2017 at 11:50:42AM -0500, Alex Deucher wrote: > On Fri, Jan 27, 2017 at 1:52 AM, Daniel Vetter wrote: > > On Thu, Jan 26, 2017 at 8:48 PM, Eric Anholt wrote: > >>> - Should we require review or at least acks for patches committed by > >>> the author? We have a bunch of drivers wit

Re: [PATCH 1/4] drm: qxl: Drop misleading comment

2017-01-30 Thread Daniel Vetter
On Fri, Jan 27, 2017 at 02:41:29PM -0200, Gabriel Krisman Bertazi wrote: > Daniel Vetter writes: > > On Fri, Jan 27, 2017 at 09:20:42AM +0100, Gerd Hoffmann wrote: > >> On Do, 2017-01-26 at 23:05 -0200, Gabriel Krisman Bertazi wrote: > >> > No longer true since commit 07f8d9bdb235 ("drm/qxl: add s

Re: DRM Atomic property for color-space conversion

2017-01-30 Thread Daniel Vetter
On Fri, Jan 27, 2017 at 05:23:24PM +, Brian Starkey wrote: > Hi, > > We're looking to enable the per-plane color management hardware in > Mali-DP with atomic properties, which has sparked some conversation > around how to handle YCbCr formats. > > As it stands today, it's assumed that a drive

Re: [PATCH] MAINTAINERS: add dma-fence* files to Sync File maintainership

2017-01-30 Thread Daniel Vetter
On Fri, Jan 27, 2017 at 03:54:44PM -0200, Gustavo Padovan wrote: > From: Gustavo Padovan > > As Sync File is highly dependent on dma-fence* tracks it > under SYNC FILE_FRAMEWORK as well. > > Signed-off-by: Gustavo Padovan Acked-by: Daniel Vetter I guess wait for an ack from Sumit, then push.

Re: [PATCH libdrm 0/3] some -pro patches for integration

2017-01-30 Thread Christian König
Reviewed-by: Christian König . Am 29.01.2017 um 23:51 schrieb Edward O'Callaghan: This series is, Reviewed-by: Edward O'Callaghan On 01/29/2017 06:49 AM, Grazvydas Ignotas wrote: I've taken several patches from amdgpu-pro libdrm that look useful to me and I think can be applied already. The o

Re: [PATCH v2 0/2] drm: Add support for tiny LCD displays

2017-01-30 Thread Daniel Vetter
Hi Noralf, On Fri, Jan 27, 2017 at 08:56:29PM +0100, Noralf Trønnes wrote: > This is an attempt at providing a DRM version of drivers/staging/fbtft. > > The tinydrm library provides a very simplified view of DRM in particular > for tiny displays that has onboard video memory and is connected thro

Re: [PATCH v3] drm/edid: Complete CEA modedb(VIC 1-107)

2017-01-30 Thread Sharma, Shashank
Regards Shashank On 1/30/2017 1:30 PM, Andrzej Hajda wrote: On 29.01.2017 06:41, Shashank Sharma wrote: CEA-861-F specs defines new 4k video modes to be used with HDMI 2.0 EDIDs. These modes start at VIC=93 and go all the way till VIC=107. Our existing CEA modedb contains only 64 modes (VIC=

Re: [PATCH v3] drm/edid: Complete CEA modedb(VIC 1-107)

2017-01-30 Thread Sharma, Shashank
Fixed typo while adding Ville's mail address. Regards Shashank On 1/30/2017 2:15 PM, Sharma, Shashank wrote: Regards Shashank On 1/30/2017 1:30 PM, Andrzej Hajda wrote: On 29.01.2017 06:41, Shashank Sharma wrote: CEA-861-F specs defines new 4k video modes to be used with HDMI 2.0 EDIDs. The

Re: [PATCH 16/19] drm/vc4: Remove vc4_debugfs_cleanup()

2017-01-30 Thread Daniel Vetter
On Fri, Jan 27, 2017 at 09:56:07AM -0800, Eric Anholt wrote: > Noralf Trønnes writes: > > > drm_debugfs_cleanup() now removes all minor->debugfs_list entries > > automatically, so the drm_driver.debugfs_cleanup callback is not > > needed. > > Nice! > > Reviewed-by: Eric Anholt Applied to drm-

Re: [PATCH 1/2] Revert "drm: omapdrm: Let the DRM core skip plane commit on inactive CRTCs"

2017-01-30 Thread Tomi Valkeinen
On 28/01/17 18:11, Laurent Pinchart wrote: > Hi Jyri, > > Thank you for the patch. > > On Friday 27 Jan 2017 12:04:54 Jyri Sarha wrote: >> This reverts commit dadf4659d0608e034b6633f30300c2eff2dafb4c. >> >> If planes are not disabled when the they are not on any crtc anymore >> they will remain a

Re: [PATCH 2/2] drm/omapdrm: Move commit_modeset_enables() before commit_planes()

2017-01-30 Thread Tomi Valkeinen
On 28/01/17 18:17, Laurent Pinchart wrote: > Hi Jyri, > > Thank you for the patch. > > On Friday 27 Jan 2017 12:04:55 Jyri Sarha wrote: >> Move drm_atomic_helper_commit_modeset_enables() call to before >> drm_atomic_helper_commit_planes() call and have a >> omap_atomic_wait_for_completion() call

[PULL] drm-misc-next

2017-01-30 Thread Daniel Vetter
Hi Dave, Another round of -misc stuff: - Noralf debugfs cleanup cleanup (not yet everything, some more driver patches awaiting acks). - More doc work. - edid/infoframe fixes from Ville. - misc 1-patch fixes all over, as usual Noralf needs this for his tinydrm pull request. And as discussed las

Re: [PATCH 00/19] drm: debugfs: Remove all files automatically on cleanup

2017-01-30 Thread Thierry Reding
On Fri, Jan 27, 2017 at 03:05:46PM +0100, Daniel Vetter wrote: > On Fri, Jan 27, 2017 at 10:36:16AM +0100, Thierry Reding wrote: > > On Fri, Jan 27, 2017 at 08:49:34AM +0100, Daniel Vetter wrote: > > > On Thu, Jan 26, 2017 at 11:56:02PM +0100, Noralf Trønnes wrote: > > > > This patchset removes the

Re: [PATCH 00/19] drm: debugfs: Remove all files automatically on cleanup

2017-01-30 Thread Daniel Vetter
On Mon, Jan 30, 2017 at 09:58:48AM +0100, Thierry Reding wrote: > On Fri, Jan 27, 2017 at 03:05:46PM +0100, Daniel Vetter wrote: > > On Fri, Jan 27, 2017 at 10:36:16AM +0100, Thierry Reding wrote: > > > On Fri, Jan 27, 2017 at 08:49:34AM +0100, Daniel Vetter wrote: > > > > On Thu, Jan 26, 2017 at 1

Re: [PATCH 00/19] drm: debugfs: Remove all files automatically on cleanup

2017-01-30 Thread Thierry Reding
On Mon, Jan 30, 2017 at 10:03:44AM +0100, Daniel Vetter wrote: > On Mon, Jan 30, 2017 at 09:58:48AM +0100, Thierry Reding wrote: > > On Fri, Jan 27, 2017 at 03:05:46PM +0100, Daniel Vetter wrote: > > > On Fri, Jan 27, 2017 at 10:36:16AM +0100, Thierry Reding wrote: > > > > On Fri, Jan 27, 2017 at 0

Re: [PATCH] drm: Don't race connector registration

2017-01-30 Thread Daniel Vetter
On Thu, Jan 26, 2017 at 12:34:29PM -0800, Dave Hansen wrote: > On 01/25/2017 07:38 AM, Daniel Vetter wrote: > > On Wed, Jan 25, 2017 at 07:20:45AM -0800, Dave Hansen wrote: > >> On 01/24/2017 10:21 PM, Daniel Vetter wrote: > >>> Hi Dave, > >>> > >>> Still waiting for your testing results on this on

Re: [v3 PATCH 0/3] Allow ASYNC flip with atomic helpers.

2017-01-30 Thread Emil Velikov
Hi Andrey, Unrelated suggestion: A handy trick - to save yourself a bit of time (and "get it right") you can use `git format-patch -vX ...' [it also works with send-email] to have the version in the subject prefix. Feel free to share it with the team - it seems that many people manually edit the

Re: [PATCH v3] drm/edid: Complete CEA modedb(VIC 1-107)

2017-01-30 Thread Andrzej Hajda
On 30.01.2017 09:45, Sharma, Shashank wrote: > Regards > > Shashank > > > On 1/30/2017 1:30 PM, Andrzej Hajda wrote: >> On 29.01.2017 06:41, Shashank Sharma wrote: >>> CEA-861-F specs defines new 4k video modes to be used with >>> HDMI 2.0 EDIDs. These modes start at VIC=93 and go all the >>> way t

Re: RFC: drm-misc for small drivers?

2017-01-30 Thread Gerd Hoffmann
Hi, > https://01.org/linuxgraphics/gfx-docs/maintainer-tools/drm-misc.html > https://01.org/linuxgraphics/gfx-docs/maintainer-tools/dim.html apache throws 403. cheers, Gerd ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.f

Re: [PATCH 1/4] drm: qxl: Drop misleading comment

2017-01-30 Thread Gerd Hoffmann
Hi, > I guess I could ask Gerd whether we wants to be part of the experiment to > maintain small drivers in drm-misc, to avoid these kinds of coordination > issues? Sounds reasonable. There isn't much activity, that's why I've grouped all four qemu drivers into a single branch already. The do

Re: [PATCH v3] drm/edid: Complete CEA modedb(VIC 1-107)

2017-01-30 Thread Sharma, Shashank
Regards Shashank On 1/30/2017 2:52 PM, Andrzej Hajda wrote: On 30.01.2017 09:45, Sharma, Shashank wrote: Regards Shashank On 1/30/2017 1:30 PM, Andrzej Hajda wrote: On 29.01.2017 06:41, Shashank Sharma wrote: CEA-861-F specs defines new 4k video modes to be used with HDMI 2.0 EDIDs. Thes

Re: RFC: drm-misc for small drivers?

2017-01-30 Thread Daniel Vetter
On Mon, Jan 30, 2017 at 10:30:43AM +0100, Gerd Hoffmann wrote: > Hi, > > > https://01.org/linuxgraphics/gfx-docs/maintainer-tools/drm-misc.html > > https://01.org/linuxgraphics/gfx-docs/maintainer-tools/dim.html > > apache throws 403. We're looking into it. Adding Tomi, who's herding the autob

Re: [PATCH 1/4] drm: qxl: Drop misleading comment

2017-01-30 Thread Daniel Vetter
On Mon, Jan 30, 2017 at 10:41:18AM +0100, Gerd Hoffmann wrote: > Hi, > > > I guess I could ask Gerd whether we wants to be part of the experiment to > > maintain small drivers in drm-misc, to avoid these kinds of coordination > > issues? > > Sounds reasonable. There isn't much activity, that's

[PULL] drm/atmel-hlcdc: Changes for 4.11

2017-01-30 Thread Boris Brezillon
Hi Dave, Here is a tiny PR for 4.11. Regards, Boris The following changes since commit 7ce7d89f48834cefece7804d38fc5d85382edf77: Linux 4.10-rc1 (2016-12-25 16:13:08 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/bbrezillon/linux.git tags/drm

Re: RFC: drm-misc for small drivers?

2017-01-30 Thread Boris Brezillon
Hi Daniel, On Thu, 26 Jan 2017 18:08:42 +0100 Daniel Vetter wrote: > Hi all, > > We've discussed this a bit at LCA (with Dave and Eric), and it's > probably best if I just summarize all the questions and opens and > throw them out here for discussions: > > - When's a driver small enough for a

Re: [PATCH v3] drm/edid: Complete CEA modedb(VIC 1-107)

2017-01-30 Thread Andrzej Hajda
On 30.01.2017 10:42, Sharma, Shashank wrote: > Regards > > Shashank > > > On 1/30/2017 2:52 PM, Andrzej Hajda wrote: >> On 30.01.2017 09:45, Sharma, Shashank wrote: >>> Regards >>> >>> Shashank >>> >>> >>> On 1/30/2017 1:30 PM, Andrzej Hajda wrote: On 29.01.2017 06:41, Shashank Sharma wrote: >

[PATCH libdrm 2/3] tests/util: Make util_open() use drmDevice

2017-01-30 Thread Thierry Reding
From: Thierry Reding The util_open() helper is used in a couple of test programs to open an appropriate device. It takes a device path and a module name, both are optional, as parameters. If a device path is specified, it will try to open the given device. Otherwise it will try all available devi

[PATCH libdrm 1/3] tests/util: Reindent using editorconfig settings

2017-01-30 Thread Thierry Reding
From: Thierry Reding Apply editorconfig settings to the tests/util library code in order to facilitate making subsequent changes. Signed-off-by: Thierry Reding --- tests/util/format.c | 128 ++--- tests/util/format.h | 36 +- tests/util/kms.c | 186 +++ tests/util/pattern.c | 144

[PATCH libdrm 3/3] tests/util: Add some API documentation

2017-01-30 Thread Thierry Reding
From: Thierry Reding None of the helpers currently have any documentation. Add some to make it more obvious how these should be used. Signed-off-by: Thierry Reding --- tests/util/kms.c | 51 +++ 1 file changed, 51 insertions(+) diff --git a/test

Re: [PATCH libdrm 1/3] tests/util: Reindent using editorconfig settings

2017-01-30 Thread Thierry Reding
On Mon, Jan 30, 2017 at 11:29:21AM +0100, Thierry Reding wrote: > From: Thierry Reding > > Apply editorconfig settings to the tests/util library code in order to > facilitate making subsequent changes. > > Signed-off-by: Thierry Reding > --- > tests/util/format.c | 128 ++--- > tests/util/fo

Re: [PATCH 01/10] drm/etnaviv: add uapi for register read feature

2017-01-30 Thread Lucas Stach
Hi Christian, Am Freitag, den 09.12.2016, 12:21 +0100 schrieb Christian Gmeiner: > We need to readout some registers _after_ the submited command > buffer got executed in order to support perf counters. > There is no way to read register via command stream - even the > Vivante kernel driver does i

Re: [PATCH 09/10] drm/etnaviv: validate readback register address

2017-01-30 Thread Lucas Stach
Am Freitag, den 09.12.2016, 12:21 +0100 schrieb Christian Gmeiner: > Reading some registers end in a system crash ala: > > Unhandled fault: external abort on non-linefetch (0x1028) at 0xfe641000 > Internal error: : 1028 [#1] PREEMPT ARM > > Avoid those by register validation. Avoiding crashe

Re: [PATCH 08/10] drm/etnaviv: make it possible to reconfigure perf counter

2017-01-30 Thread Lucas Stach
Am Freitag, den 09.12.2016, 12:21 +0100 schrieb Christian Gmeiner: > Each perf counter 'unit' consits of a multipler configuration register > and a register to read the selected value. Extend the uapi to handle > this case gracefully. Before the readback is done the mux (config_reg) > get reconfigu

Re: [PATCH v3] drm/edid: Complete CEA modedb(VIC 1-107)

2017-01-30 Thread Sharma, Shashank
Regards Shashank On 1/30/2017 3:47 PM, Andrzej Hajda wrote: On 30.01.2017 10:42, Sharma, Shashank wrote: Regards Shashank On 1/30/2017 2:52 PM, Andrzej Hajda wrote: On 30.01.2017 09:45, Sharma, Shashank wrote: Regards Shashank On 1/30/2017 1:30 PM, Andrzej Hajda wrote: On 29.01.2017

[PATCH 4/4] drm: bridge: dw-hdmi: Take input format from plat_data

2017-01-30 Thread Neil Armstrong
Some display pipelines can only provide non-RBG input pixels to the HDMI TX Controller, this patch takes the pixel format from the plat_data if provided. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/bridge/dw-hdmi.c | 55 include/drm/bridge/dw_hdmi.h

Re: [v3 PATCH 1/3] drm/atomic: Save flip flags in drm_crtct_state

2017-01-30 Thread Laurent Pinchart
Hi Andrey, Thank you for the patch. On Saturday 28 Jan 2017 21:26:49 Andrey Grodzovsky wrote: > Allows using atomic flip helpers for drivers > using ASYNC flip. > Remove ASYNC_FLIP restriction in helpers and > caches the page flip flags in drm_crtc_state > to be used in the low level drivers. >

[PATCH 0/4] drm: bridge: dw-hdmi: Add support for Custom PHYs

2017-01-30 Thread Neil Armstrong
The Amlogic GX SoCs implements a Synopsys DesignWare HDMI TX Controller in combination with a very custom PHY. Thanks to Laurent Pinchart's changes, the HW report the following : Detected HDMI TX controller v2.01a with HDCP (Vendor PHY) The following differs from common PHY integration as manage

[PATCH 2/4] drm: bridge: dw-hdmi: Add support for custom PHY handling

2017-01-30 Thread Neil Armstrong
The Synopsys DesignWare HDMI TX Controller support various Transceivers (PHY) attached to the controller, but also allows fully custom PHYs to be connected. Add PHY init and disable functions in phy_ops structure passed in plat_data to handle fully custom PHY init or provide the default one. Some

[PATCH 1/4] drm: bridge: dw-hdmi: Switch to regmap for register access

2017-01-30 Thread Neil Armstrong
The Synopsys Designware HDMI TX Controller does not enforce register access on platforms instanciating it. The current driver supports two different types of memory-mapped flat register access, but in order to support the Amlogic Meson SoCs integration, and provide a more generic way to handle all

[PATCH 3/4] drm: bridge: dw-hdmi: Enable CSC even for DVI

2017-01-30 Thread Neil Armstrong
If the input pixel format is not RGB, the CSC must be enabled in order to provide valid pixel to DVI sinks. This patch removes the hdmi only dependency on the CSC enabling. Reviewed-by: Jose Abreu Reviewed-by: Laurent Pinchart Signed-off-by: Neil Armstrong --- drivers/gpu/drm/bridge/dw-hdmi.c

Re: [PATCH 2/2] drm/omapdrm: Move commit_modeset_enables() before commit_planes()

2017-01-30 Thread Jyri Sarha
On 01/28/17 18:17, Laurent Pinchart wrote: > Hi Jyri, > > Thank you for the patch. > > On Friday 27 Jan 2017 12:04:55 Jyri Sarha wrote: >> Move drm_atomic_helper_commit_modeset_enables() call to before >> drm_atomic_helper_commit_planes() call and have a >> omap_atomic_wait_for_completion() call

Re: [PATCH 2/2] drm/omapdrm: Move commit_modeset_enables() before commit_planes()

2017-01-30 Thread Laurent Pinchart
Hi Jyri, On Monday 30 Jan 2017 13:11:56 Jyri Sarha wrote: > On 01/28/17 18:17, Laurent Pinchart wrote: > > On Friday 27 Jan 2017 12:04:55 Jyri Sarha wrote: > >> Move drm_atomic_helper_commit_modeset_enables() call to before > >> drm_atomic_helper_commit_planes() call and have a > >> omap_atomic_wa

Re: [PATCH v3] drm/edid: Complete CEA modedb(VIC 1-107)

2017-01-30 Thread Sharma, Shashank
I just realized that the CEA spec talks about picking HDMI 2.0/861-F VIC over HDMI14b VIC in case of 3D side-by-side format (not in 2D), In this case, we might have to add a check while loading the VIC filed in AVI IF (as you suggested) Will come back with a V2 (if required), once I have more

Re: [PATCH 0/6] Etnaviv cmdbuf suballocator

2017-01-30 Thread Lucas Stach
Am Mittwoch, den 18.01.2017, 12:25 +0100 schrieb Lucas Stach: > Hi all, > > the following patches introduce a cmduf suballocator in the Etnaviv > kernel driver, which has the following benefits: > > 1. Allocating and freeing a CMA buffer for each user command submission >is taking a big toll

Re: [PATCH 0/6] Etnaviv cmdbuf suballocator

2017-01-30 Thread Christian Gmeiner
Hi Lucas, 2017-01-30 12:48 GMT+01:00 Lucas Stach : > Am Mittwoch, den 18.01.2017, 12:25 +0100 schrieb Lucas Stach: >> Hi all, >> >> the following patches introduce a cmduf suballocator in the Etnaviv >> kernel driver, which has the following benefits: >> >> 1. Allocating and freeing a CMA buffer f

Re: [PATCH 2/2] drm/omapdrm: Move commit_modeset_enables() before commit_planes()

2017-01-30 Thread Jyri Sarha
On 01/30/17 13:15, Laurent Pinchart wrote: >>> rebase (and retest) this patch on top of "[PATCH 0/5] omapdrm: fences and >>> zpos" ? >> Thanks, I'll do that. > If you intend on merging this patch as a v4.10 fix then there's no need to > rebase. If it targets v4.11, the above-mentioned series will

Re: [PATCH] Gpu: drm: exynos - Fix possible NULL derefrence.

2017-01-30 Thread Javier Martinez Canillas
Hello Shailendra, The subject line is wrong, please always use the convention used in previous commits, i.e: git log --oneline drivers/gpu/drm/exynos/ On 01/30/2017 02:02 AM, Shailendra Verma wrote: > of_device_get_match_data could return NULL, and so can cause > a NULL pointer dereference later.

[Bug 99368] Full aspect scaling introduces interlacing on specific resolutions

2017-01-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99368 Platin changed: What|Removed |Added Attachment #128898|0 |1 is obsolete|

Re: [PATCH v2 13/13] drm/i915: Acquire P-Unit access when modifying P-Unit settings

2017-01-30 Thread Ville Syrjälä
On Sat, Jan 28, 2017 at 06:18:45PM +0100, Hans de Goede wrote: > Hi, > > On 01/28/2017 05:25 PM, Hans de Goede wrote: > > Hi, > > > > On 01/27/2017 02:51 PM, Ville Syrjälä wrote: > >> On Mon, Jan 23, 2017 at 10:09:58PM +0100, Hans de Goede wrote: > >>> Make sure the P-Unit or the PMIC i2c bus is n

Re: [PATCH] MAINTAINERS: add dma-fence* files to Sync File maintainership

2017-01-30 Thread Sumit Semwal
Hi Gustavo, Daniel, On 30 January 2017 at 14:07, Daniel Vetter wrote: > On Fri, Jan 27, 2017 at 03:54:44PM -0200, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > As Sync File is highly dependent on dma-fence* tracks it > > under SYNC FILE_FRAMEWORK as well. > > > > Signed-off-by: Gusta

Re: DRM Atomic property for color-space conversion

2017-01-30 Thread Ville Syrjälä
On Fri, Jan 27, 2017 at 05:23:24PM +, Brian Starkey wrote: > Hi, > > We're looking to enable the per-plane color management hardware in > Mali-DP with atomic properties, which has sparked some conversation > around how to handle YCbCr formats. > > As it stands today, it's assumed that a drive

[Bug 193651] New: Amdgpu error messages at boot with Amd RX460

2017-01-30 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=193651 Bug ID: 193651 Summary: Amdgpu error messages at boot with Amd RX460 Product: Drivers Version: 2.5 Kernel Version: 4.11-wip Hardware: x86-64 OS: Linux Tree: M

Re: [Intel-gfx] [PATCH 0/3] drm/i915: Handle hanging during nonblocking modeset correctly.

2017-01-30 Thread Maarten Lankhorst
Op 30-01-17 om 09:17 schreef Daniel Vetter: > On Fri, Jan 27, 2017 at 03:08:45PM +, Chris Wilson wrote: >> On Fri, Jan 27, 2017 at 03:58:08PM +0100, Daniel Vetter wrote: >>> On Fri, Jan 27, 2017 at 02:31:55PM +, Chris Wilson wrote: On Fri, Jan 27, 2017 at 03:21:29PM +0100, Daniel Vette

Re: [PATCH v2 13/13] drm/i915: Acquire P-Unit access when modifying P-Unit settings

2017-01-30 Thread Hans de Goede
Hi, On 30-01-17 14:10, Ville Syrjälä wrote: On Sat, Jan 28, 2017 at 06:18:45PM +0100, Hans de Goede wrote: Hi, On 01/28/2017 05:25 PM, Hans de Goede wrote: Hi, On 01/27/2017 02:51 PM, Ville Syrjälä wrote: On Mon, Jan 23, 2017 at 10:09:58PM +0100, Hans de Goede wrote: Make sure the P-Unit o

Re: [PATCH v2 0/2] drm: Add support for tiny LCD displays

2017-01-30 Thread Noralf Trønnes
Den 30.01.2017 09.44, skrev Daniel Vetter: Hi Noralf, On Fri, Jan 27, 2017 at 08:56:29PM +0100, Noralf Trønnes wrote: This is an attempt at providing a DRM version of drivers/staging/fbtft. The tinydrm library provides a very simplified view of DRM in particular for tiny displays that has onb

Re: [PATCH v2 13/13] drm/i915: Acquire P-Unit access when modifying P-Unit settings

2017-01-30 Thread Ville Syrjälä
On Mon, Jan 30, 2017 at 04:02:19PM +0100, Hans de Goede wrote: > Hi, > > On 30-01-17 14:10, Ville Syrjälä wrote: > > On Sat, Jan 28, 2017 at 06:18:45PM +0100, Hans de Goede wrote: > >> Hi, > >> > >> On 01/28/2017 05:25 PM, Hans de Goede wrote: > >>> Hi, > >>> > >>> On 01/27/2017 02:51 PM, Ville Sy

[PATCH] drm/i915: Skip modeset locking when atomic pageflips are used.

2017-01-30 Thread Maarten Lankhorst
With the atomic helper for pageflips there are no CS flips when that require resetting, so on most platforms we can completely skip the locking. Because we may end up reverting the page_flip patch add an explicit function pointer check so that if someone reverts the page flip patch there will not

Re: [PATCH v3 24/24] drm/rockchip: dw-mipi-dsi: support read commands

2017-01-30 Thread Sean Paul
On Sun, Jan 29, 2017 at 01:24:44PM +, John Keeping wrote: > I haven't found any method for getting the length of a response, so this > just uses the requested rx_len > > Signed-off-by: John Keeping > --- > v3: > - Fix checkpatch warnings > Unchanged in v2 > > drivers/gpu/drm/rockchip/dw-mip

Re: [PATCH v2 13/13] drm/i915: Acquire P-Unit access when modifying P-Unit settings

2017-01-30 Thread Hans de Goede
Hi, On 30-01-17 16:11, Ville Syrjälä wrote: On Mon, Jan 30, 2017 at 04:02:19PM +0100, Hans de Goede wrote: Hi, On 30-01-17 14:10, Ville Syrjälä wrote: On Sat, Jan 28, 2017 at 06:18:45PM +0100, Hans de Goede wrote: Hi, On 01/28/2017 05:25 PM, Hans de Goede wrote: Hi, On 01/27/2017 02:51 PM

Re: [PATCH v2 13/13] drm/i915: Acquire P-Unit access when modifying P-Unit settings

2017-01-30 Thread Ville Syrjälä
On Mon, Jan 30, 2017 at 04:27:58PM +0100, Hans de Goede wrote: > Hi, > > On 30-01-17 16:11, Ville Syrjälä wrote: > > On Mon, Jan 30, 2017 at 04:02:19PM +0100, Hans de Goede wrote: > >> Hi, > >> > >> On 30-01-17 14:10, Ville Syrjälä wrote: > >>> On Sat, Jan 28, 2017 at 06:18:45PM +0100, Hans de Goe

Re: [PATCH v3 03/24] drm/rockchip: dw-mipi-dsi: remove mode_set hook

2017-01-30 Thread Sean Paul
On Sun, Jan 29, 2017 at 01:24:23PM +, John Keeping wrote: > This is not needed since we can access the mode via the CRTC from the > enable hook. Also remove the "mode" field that is no longer used. > Reviewed-by: Sean Paul > Signed-off-by: John Keeping > Reviewed-by: Chris Zhong > --- >

Re: [PATCH v3 04/24] drm/rockchip: dw-mipi-dsi: fix command header writes

2017-01-30 Thread Sean Paul
On Sun, Jan 29, 2017 at 01:24:24PM +, John Keeping wrote: > In a couple of places here we use "val" for the value that is about to > be written to a register but then reuse the same variable for the value > of a status register before we get around to writing it. Rename the > value to be writt

Re: [PATCH v3 02/24] drm/rockchip: dw-mipi-dsi: pass mode in where needed

2017-01-30 Thread Sean Paul
On Sun, Jan 29, 2017 at 01:24:22PM +, John Keeping wrote: > This shows that we only use the mode from the enable function and > prepares us to remove the "mode" field and the mode_set hook in the next > commit. > Reviewed-by: Sean Paul > Signed-off-by: John Keeping > Reviewed-by: Chris Zho

Re: [PATCH v3 01/24] drm/rockchip: dw-mipi-dsi: don't configure hardware in mode_set for MIPI

2017-01-30 Thread Sean Paul
On Sun, Jan 29, 2017 at 01:24:21PM +, John Keeping wrote: > With atomic modesetting the hardware will be powered off when the > mode_set function is called. We should configure the hardware in the > enable function, which is the atomic version of "commit" so let's use > the enable hook rather

[PATCH] drm: mali-dp: add custom plane ->reset hook

2017-01-30 Thread Mihail Atanassov
The reset hook needs to allocate space for a malidp_plane_state, which is larger than drm_plane_state. Otherwise, the hook is identical to the default one. Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/arm/malidp_planes.c | 23 ++- 1 file changed, 22 insertions(+), 1 de

Re: [PATCH] drm: mali-dp: add custom plane ->reset hook

2017-01-30 Thread Liviu Dudau
On Mon, Jan 30, 2017 at 03:42:26PM +, Mihail Atanassov wrote: > The reset hook needs to allocate space for a > malidp_plane_state, which is larger than drm_plane_state. > Otherwise, the hook is identical to the default one. > > Signed-off-by: Mihail Atanassov Acked-by: Liviu Dudau Thanks,

Re: [PATCH v2 13/13] drm/i915: Acquire P-Unit access when modifying P-Unit settings

2017-01-30 Thread Hans de Goede
Hi, On 30-01-17 16:38, Ville Syrjälä wrote: On Mon, Jan 30, 2017 at 04:27:58PM +0100, Hans de Goede wrote: Hi, On 30-01-17 16:11, Ville Syrjälä wrote: On Mon, Jan 30, 2017 at 04:02:19PM +0100, Hans de Goede wrote: Hi, On 30-01-17 14:10, Ville Syrjälä wrote: On Sat, Jan 28, 2017 at 06:18:45

[PATCH 0/4] drm/msm: cleanup gpu bindings

2017-01-30 Thread Rob Clark
Existing bindings for the gpu are based on the downstream android kgsl driver (a subset of the downstream bindings). But that isn't really how we want the upstream bindings to look. For now we have held off on adding gpu nodes to upstream dt files, but now that all the dependencies are in place f

[PATCH 2/4] drm/msm: drop qcom,chipid

2017-01-30 Thread Rob Clark
The original way we determined the gpu version was based on downstream bindings from android kernel. A cleaner way is to get the version from the compatible string. Note that no upstream dtb uses these bindings. But the code still supports falling back to the legacy bindings (with a warning), so

[PATCH 4/4] drm/msm: drop _clk suffix from clk names

2017-01-30 Thread Rob Clark
Suggested by Rob Herring. We still support the old names for compatibility with downstream android dt files. Cc: Rob Herring Signed-off-by: Rob Clark --- Documentation/devicetree/bindings/display/msm/gpu.txt | 12 ++-- drivers/gpu/drm/msm/msm_drv.c | 19

[PATCH 3/4] drm/msm: drop quirks binding

2017-01-30 Thread Rob Clark
This was never documented or used in upstream dtb. It is used by downstream bindings from android device kernels. But the quirks are a property of the gpu revision, and as such are redundant to be listed separately in dt. Instead, move the quirks to the device table. Signed-off-by: Rob Clark -

[PATCH 1/4] drm/msm: remove qcom,gpu-pwrlevels bindings

2017-01-30 Thread Rob Clark
The plan is to use the OPP bindings. For now, remove the documentation for qcom,gpu-pwrlevels, and make the driver fall back to a safe low clock if the node is not present. Note that no upstream dtb use this node. For now we keep compatibility with this node to avoid breaking compatibility with

Re: [PATCH 1/2] dt-bindings: Document the VC4 DSI module nodes.

2017-01-30 Thread Rob Herring
On Fri, Jan 27, 2017 at 8:41 PM, Eric Anholt wrote: > Rob Herring writes: > >> Need to cc DT list if you want it in my queue. >> >> On Mon, Jan 23, 2017 at 6:38 PM, Eric Anholt wrote: >>> These are part of the vc4 display pipeline. >>> >>> Signed-off-by: Eric Anholt >>> --- >>> .../devicetree/

Re: [v3 PATCH 3/3] drm/amd/display: Switch to using atomic_helper for flip.

2017-01-30 Thread Harry Wentland
On 2017-01-28 09:26 PM, Andrey Grodzovsky wrote: > Swicth to use atomic helper. > Start using actual user's given target_vblank value for flip > instead of current value. > > v3: > Update for movig pflip flags to crtc_state > > Change-Id: I25dae6d8c29de5d022a42aa99a18a32674b56cda > Signed-off-by

Re: [PATCH 1/4] drm: qxl: Drop misleading comment

2017-01-30 Thread Gerd Hoffmann
Hi, > drm-misc runs with the committer model, i.e. a few maintainers to do pull > requests and backmerges, a big pile of people directly pushing patches. [ looked at docs too meanwhile ] Sounds good. I guess switching over simplifies things for all of us. We'll avoid issues like the one at ha

Re: make fbdev/fbcon switchable per driver?

2017-01-30 Thread Alex Williamson
On Mon, 30 Jan 2017 09:15:50 +0100 Gerd Hoffmann wrote: > Hi, > > > The vgaarb code has a concept of a vga_default_device(), it's rather > > PCI-centric, but maybe better than nothing. This is typically the > > first VGA class code device found with I/O and MMIO enabled. If fbcon > > default

Re: [PATCH v3 05/24] drm/rockchip: dw-mipi-dsi: fix generic packet status check

2017-01-30 Thread Sean Paul
On Sun, Jan 29, 2017 at 01:24:25PM +, John Keeping wrote: > We want to check that both the GEN_CMD_EMPTY and GEN_PLD_W_EMPTY bits > are set so we can't just check "val & mask" because that will be true if > either bit is set. > Reviewed-by: Sean Paul > Signed-off-by: John Keeping > Reviewe

[PATCH] drm/atomic: Fix double kfree on crtc_state->event

2017-01-30 Thread Daniel Vetter
This is a bug Maarten reported, with the following slab debug backtrace: [IGT] kms_rotation_crc: starting subtest primary-rotation-180 = BUG kmalloc-128 (Tainted: G U ): Object already free

Re: [PATCH v3 06/24] drm/rockchip: dw-mipi-dsi: avoid out-of-bounds read on tx_buf

2017-01-30 Thread Sean Paul
On Sun, Jan 29, 2017 at 01:24:26PM +, John Keeping wrote: > As a side-effect of this, encode the endianness explicitly rather than > casting a u16. > > Signed-off-by: John Keeping > Reviewed-by: Chris Zhong > --- > v3: > - Add Chris' Reviewed-by > Unchanged in v2 > > drivers/gpu/drm/rockch

Re: [PATCH v3 07/24] drm/rockchip: dw-mipi-dsi: include bad value in error message

2017-01-30 Thread Sean Paul
On Sun, Jan 29, 2017 at 01:24:27PM +, John Keeping wrote: > As an aid to debugging. Reviewed-by: Sean Paul > > Signed-off-by: John Keeping > Reviewed-by: Chris Zhong > --- > v3: > - Add Chris' Reviewed-by > Unchanged in v2 > > drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 3 ++- > 1 file cha

Re: [PATCH v2 0/2] drm: Add support for tiny LCD displays

2017-01-30 Thread Daniel Vetter
On Mon, Jan 30, 2017 at 04:03:53PM +0100, Noralf Trønnes wrote: > > Den 30.01.2017 09.44, skrev Daniel Vetter: > > Hi Noralf, > > > > On Fri, Jan 27, 2017 at 08:56:29PM +0100, Noralf Trønnes wrote: > > > This is an attempt at providing a DRM version of drivers/staging/fbtft. > > > > > > The tiny

Re: [PATCH 2/4] drm/msm: drop qcom,chipid

2017-01-30 Thread Eric Anholt
Rob Clark writes: > The original way we determined the gpu version was based on downstream > bindings from android kernel. A cleaner way is to get the version from > the compatible string. > > Note that no upstream dtb uses these bindings. But the code still > supports falling back to the legac

Re: [PATCH 3/4] drm/msm: drop quirks binding

2017-01-30 Thread Eric Anholt
Rob Clark writes: > This was never documented or used in upstream dtb. It is used by > downstream bindings from android device kernels. But the quirks are > a property of the gpu revision, and as such are redundant to be listed > separately in dt. Instead, move the quirks to the device table.

Re: [PATCH v3 24/24] drm/rockchip: dw-mipi-dsi: support read commands

2017-01-30 Thread John Keeping
On Mon, 30 Jan 2017 10:26:11 -0500, Sean Paul wrote: > On Sun, Jan 29, 2017 at 01:24:44PM +, John Keeping wrote: > > I haven't found any method for getting the length of a response, so this > > just uses the requested rx_len > > > > Signed-off-by: John Keeping > > --- > > v3: > > - Fix check

Re: [PATCH 4/4] drm/msm: drop _clk suffix from clk names

2017-01-30 Thread Eric Anholt
Rob Clark writes: > Suggested by Rob Herring. We still support the old names for > compatibility with downstream android dt files. > > Cc: Rob Herring > Signed-off-by: Rob Clark Huh, I don't think I would have cleaned up DT bindings in exchange for adding driver code like this. But the code

Re: [PATCH v3 06/24] drm/rockchip: dw-mipi-dsi: avoid out-of-bounds read on tx_buf

2017-01-30 Thread John Keeping
On Mon, 30 Jan 2017 13:01:46 -0500, Sean Paul wrote: > On Sun, Jan 29, 2017 at 01:24:26PM +, John Keeping wrote: > > As a side-effect of this, encode the endianness explicitly rather than > > casting a u16. > > > > Signed-off-by: John Keeping > > Reviewed-by: Chris Zhong > > --- > > v3: > >

Re: [PATCH 2/4] drm/msm: drop qcom,chipid

2017-01-30 Thread Rob Clark
On Mon, Jan 30, 2017 at 1:09 PM, Eric Anholt wrote: > Rob Clark writes: > >> The original way we determined the gpu version was based on downstream >> bindings from android kernel. A cleaner way is to get the version from >> the compatible string. >> >> Note that no upstream dtb uses these bindi

Re: [PATCH v3 08/24] drm/rockchip: dw-mipi-dsi: respect message flags

2017-01-30 Thread Sean Paul
On Sun, Jan 29, 2017 at 01:24:28PM +, John Keeping wrote: > Instead of always sending commands in LP mode, respect the > MIPI_DSI_MSG_USE_LPM flag to decide how to send each message. Also > request acks if MIPI_DSI_MSG_REQ_ACK is set. > Reviewed-by: Sean Paul > Signed-off-by: John Keeping

Re: [PATCH v3 09/24] drm/rockchip: dw-mipi-dsi: only request HS clock when required

2017-01-30 Thread Sean Paul
On Sun, Jan 29, 2017 at 01:24:29PM +, John Keeping wrote: > Requesting the HS clock from the PHY before we initialize it causes an > invalid signal to be sent out since the input clock is not yet > configured. The PHY databook suggests only asserting this signal when > performing HS transfers,

Re: [PATCH 1/4] drm/msm: remove qcom,gpu-pwrlevels bindings

2017-01-30 Thread Eric Anholt
Rob Clark writes: > The plan is to use the OPP bindings. For now, remove the documentation > for qcom,gpu-pwrlevels, and make the driver fall back to a safe low > clock if the node is not present. > > Note that no upstream dtb use this node. For now we keep compatibility > with this node to avo

Re: [PATCH 4/4] drm/msm: drop _clk suffix from clk names

2017-01-30 Thread Rob Clark
On Mon, Jan 30, 2017 at 1:15 PM, Eric Anholt wrote: > Rob Clark writes: > >> Suggested by Rob Herring. We still support the old names for >> compatibility with downstream android dt files. >> >> Cc: Rob Herring >> Signed-off-by: Rob Clark > > Huh, I don't think I would have cleaned up DT bindi

Re: [PATCH 1/4] drm/msm: remove qcom,gpu-pwrlevels bindings

2017-01-30 Thread Rob Clark
On Mon, Jan 30, 2017 at 1:21 PM, Eric Anholt wrote: > Rob Clark writes: > >> The plan is to use the OPP bindings. For now, remove the documentation >> for qcom,gpu-pwrlevels, and make the driver fall back to a safe low >> clock if the node is not present. >> >> Note that no upstream dtb use this

Re: [PATCH v2 0/2] drm: Add support for tiny LCD displays

2017-01-30 Thread Noralf Trønnes
Den 30.01.2017 19.06, skrev Daniel Vetter: On Mon, Jan 30, 2017 at 04:03:53PM +0100, Noralf Trønnes wrote: Den 30.01.2017 09.44, skrev Daniel Vetter: Hi Noralf, On Fri, Jan 27, 2017 at 08:56:29PM +0100, Noralf Trønnes wrote: This is an attempt at providing a DRM version of drivers/staging/fb

Re: [PATCH 2/4] drm/msm: drop qcom,chipid

2017-01-30 Thread Eric Anholt
Rob Clark writes: > On Mon, Jan 30, 2017 at 1:09 PM, Eric Anholt wrote: >> Rob Clark writes: >> >>> The original way we determined the gpu version was based on downstream >>> bindings from android kernel. A cleaner way is to get the version from >>> the compatible string. >>> >>> Note that no

Re: [PATCH 1/4] drm/msm: remove qcom,gpu-pwrlevels bindings

2017-01-30 Thread Eric Anholt
Rob Clark writes: > On Mon, Jan 30, 2017 at 1:21 PM, Eric Anholt wrote: >> Rob Clark writes: >> >>> The plan is to use the OPP bindings. For now, remove the documentation >>> for qcom,gpu-pwrlevels, and make the driver fall back to a safe low >>> clock if the node is not present. >>> >>> Note

Re: [PATCH] MAINTAINERS: add dma-fence* files to Sync File maintainership

2017-01-30 Thread Gustavo Padovan
2017-01-30 Sumit Semwal : > Hi Gustavo, Daniel, > > On 30 January 2017 at 14:07, Daniel Vetter wrote: > > > On Fri, Jan 27, 2017 at 03:54:44PM -0200, Gustavo Padovan wrote: > > > From: Gustavo Padovan > > > > > > As Sync File is highly dependent on dma-fence* tracks it > > > under SYNC FILE_FR

  1   2   >