Re: [Intel-gfx] [PATCH 2/5] drm/edid: Introduce drm_default_rgb_quant_range()

2017-01-12 Thread Daniel Vetter
On Wed, Jan 11, 2017 at 06:31:52PM +0200, Ville Syrjälä wrote: > On Wed, Jan 11, 2017 at 05:16:54PM +0100, Daniel Vetter wrote: > > On Wed, Jan 11, 2017 at 02:57:22PM +0200, ville.syrj...@linux.intel.com > > wrote: > > > From: Ville Syrjälä > > > > > > Make the code selecting the RGB quantizatio

Re: [Intel-gfx] [PATCH 2/5] drm/edid: Introduce drm_default_rgb_quant_range()

2017-01-12 Thread Michel Dänzer
On 12/01/17 05:00 PM, Daniel Vetter wrote: > On Wed, Jan 11, 2017 at 06:31:52PM +0200, Ville Syrjälä wrote: >> On Wed, Jan 11, 2017 at 05:16:54PM +0100, Daniel Vetter wrote: >>> On Wed, Jan 11, 2017 at 02:57:22PM +0200, ville.syrj...@linux.intel.com >>> wrote: From: Ville Syrjälä M

Re: [PATCH 3/5] drm/exynos: Stop using drm_framebuffer_unregister_private

2017-01-12 Thread Inki Dae
Applied. Thanks. 2016년 12월 27일 19:49에 Daniel Vetter 이(가) 쓴 글: > This is the deprecated function for when you embedded the framebuffer > somewhere else (which breaks refcounting). But exynos is using > drm_framebuffer_remove and a free-standing fb, so this is rendundant. > > Cc: Inki Dae > Cc: J

Re: [PATCH] drm/atomic: Add target_vblank support in atomic helpers (v2)

2017-01-12 Thread Michel Dänzer
On 12/01/17 12:48 AM, Grodzovsky, Andrey wrote: >> From: Michel Dänzer [mailto:mic...@daenzer.net] >> On 09/01/17 06:59 PM, Daniel Vetter wrote: >>> On Fri, Jan 06, 2017 at 03:39:40PM -0500, Andrey Grodzovsky wrote: Allows usage of the new page_flip_target hook for drivers implementing th

Re: [PATCH 2/2] drm/nouveau: Handle fbcon suspend/resume in seperate worker

2017-01-12 Thread Hans de Goede
Hi, Good catch (both the previous patch as well as this one). I've one small comment inline: On 12-01-17 03:25, Lyude wrote: Resuming from RPM can happen while already holding dev->mode_config.mutex. This means we can't actually handle fbcon in any RPM resume workers, since restoring fbcon requ

Re: [PATCH] drm/atomic: Add target_vblank support in atomic helpers (v2)

2017-01-12 Thread Daniel Vetter
On Thu, Jan 12, 2017 at 9:28 AM, Michel Dänzer wrote: > On 12/01/17 12:48 AM, Grodzovsky, Andrey wrote: >>> From: Michel Dänzer [mailto:mic...@daenzer.net] >>> On 09/01/17 06:59 PM, Daniel Vetter wrote: On Fri, Jan 06, 2017 at 03:39:40PM -0500, Andrey Grodzovsky wrote: > Allows usage of t

[PATCH] drm: fix MMU dependencies

2017-01-12 Thread Benjamin Gaignard
DRM_VM and DRM_LEGACY shouldn't be selected if MMU isn't set. Fixes: 62a0d98a188c ("drm: allow to use mmuless SoC") Signed-off-by: Benjamin Gaignard Cc: Arnd Bergmann Cc: Daniel Vetter --- drivers/gpu/drm/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/g

[PATCH v5 1/4] drm/bridge: analogix_dp: set connector to drm_dp_aux

2017-01-12 Thread Tomeu Vizoso
Set the backpointer so that the DP helpers are able to access the connector that the drm_dp_aux is associated with. Signed-off-by: Tomeu Vizoso --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/

[PATCH v5 0/4] drm/dp: Implement CRC debugfs API

2017-01-12 Thread Tomeu Vizoso
Hi, this series builds up on the API for exposing captured CRCs through debugfs. It adds new DP helpers for starting and stopping CRC capture and gets the Rockchip driver to use it. Also had to add a connector backpointer to the drm_dp_aux struct so we could wait for the right vblank and store t

[PATCH v5 3/4] drm/bridge: analogix_dp: add helpers for capture of frame CRCs

2017-01-12 Thread Tomeu Vizoso
Add two simple functions that just take the drm_dp_aux from our struct and calls the corresponding DP helpers with it. Signed-off-by: Tomeu Vizoso --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 16 include/drm/bridge/analogix_dp.h | 3 +++ 2 files c

[PATCH v5 2/4] drm/dp: add helpers for capture of frame CRCs

2017-01-12 Thread Tomeu Vizoso
Adds helpers for starting and stopping capture of frame CRCs through the DPCD. When capture is on, a worker waits for vblanks and retrieves the frame CRC to put it in the queue on the CRTC that is using the eDP connector, so it's passed to userspace. v2: Reuse drm_crtc_wait_one_vblank Update l

[PATCH v5 4/4] drm/rockchip: Implement CRC debugfs API

2017-01-12 Thread Tomeu Vizoso
Implement the .set_crc_source() callback and call the DP helpers accordingly to start and stop CRC capture. This is only done if this CRTC is currently using the eDP connector. v3: Remove superfluous check on rockchip_crtc_state->output_type Signed-off-by: Tomeu Vizoso --- drivers/gpu/drm/roc

Re: [Intel-gfx] GPU hang with kernel 4.10rc3

2017-01-12 Thread Chris Wilson
On Thu, Jan 12, 2017 at 07:03:25AM +0100, Juergen Gross wrote: > On 11/01/17 18:08, Chris Wilson wrote: > > On Wed, Jan 11, 2017 at 05:33:34PM +0100, Juergen Gross wrote: > >> With kernel 4.10rc3 running as Xen dm0 I get at each boot: > >> > >> [ 49.213697] [drm] GPU HANG: ecode 7:0:0x3d1d3d3d, i

Re: [Intel-gfx] [PATCH 1/5] drm/edid: Have drm_edid.h include hdmi.h

2017-01-12 Thread Jani Nikula
On Wed, 11 Jan 2017, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > drm_edid.h depends on hdmi.h on account of enum hdmi_picture_aspect, > so let's just include hdmi.h and drop some useless struct declarations. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- >

Re: [PATCH] drm/exynos/decon5433: update shadow registers iff there are active windows

2017-01-12 Thread Inki Dae
Applied. Thanks. 2017년 01월 09일 23:33에 Andrzej Hajda 이(가) 쓴 글: > Improper usage of DECON_UPDATE register leads to subtle errors. > If it set in decon_commit when there are no active windows it results > in slow registry updates - all subsequent shadow registry updates takes more > than full vblank

[PATCH v2.1 6/7] drm/atomic: Convert get_existing_state callers to get_old/new_state, v2.

2017-01-12 Thread Maarten Lankhorst
This is a straightforward conversion that converts all the users of get_existing_state in atomic core to use get_old_state or get_new_state Changes since v1: - Fix using the wrong state in drm_atomic_helper_update_legacy_modeset_state. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/drm_at

Re: [Intel-gfx] [PATCH v2 2/5] drm/edid: Introduce drm_default_rgb_quant_range()

2017-01-12 Thread Jani Nikula
On Wed, 11 Jan 2017, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Make the code selecting the RGB quantization range a little less magicy > by wrapping it up in a small helper. > > v2: s/adjusted_mode/mode in vc4 to make it actually compile > > Signed-off-by: Ville Syrjälä > ---

Re: [PATCH 3/5] drm/edid: Introduce drm_hdmi_avi_infoframe_quant_range()

2017-01-12 Thread Jani Nikula
On Wed, 11 Jan 2017, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Pull the logic to populate the quantization range information > in the AVI infoframe into a small helper. We'll be adding a bit > more logic to it, and having it in a central place seems like a > good idea since it

Re: [Intel-gfx] [PATCH 1/3] drm: Add new DRM_IOCTL_MODE_GETPLANE2

2017-01-12 Thread Ville Syrjälä
On Wed, Jan 11, 2017 at 08:43:16PM -0500, Rob Clark wrote: > On Wed, Jan 11, 2017 at 7:51 PM, Ben Widawsky wrote: > > > > +struct drm_format_modifier { > > + /* Bitmask of formats in get_plane format list this info > > +* applies to. */ > > + uint64_t formats; > > re: the uabi

Re: [Intel-gfx] [PATCH 4/5] drm/edid: Set AVI infoframe Q even when QS=0

2017-01-12 Thread Jani Nikula
On Wed, 11 Jan 2017, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > HDMI 2.0 recommends that we set the Q bits in the AVI infoframe > even when the sink does not support quantization range selection (QS=0). > According to CEA-861 we can do that as long as the Q we send matches > th

Re: [PATCH 1/5] drm/msm: Stop using drm_framebuffer_unregister_private

2017-01-12 Thread Archit Taneja
On 12/27/2016 04:19 PM, Daniel Vetter wrote: This is the deprecated function for when you embedded the framebuffer somewhere else (which breaks refcounting). But msm is using drm_framebuffer_remove and a free-standing fb, so this is rendundant. Cc: Rob Clark Signed-off-by: Daniel Vetter Re

Re: [PATCH] drm: fix MMU dependencies

2017-01-12 Thread Daniel Vetter
On Thu, Jan 12, 2017 at 09:57:36AM +0100, Benjamin Gaignard wrote: > DRM_VM and DRM_LEGACY shouldn't be selected if MMU isn't set. > > Fixes: 62a0d98a188c ("drm: allow to use mmuless SoC") > Signed-off-by: Benjamin Gaignard > Cc: Arnd Bergmann > Cc: Daniel Vetter Let's see how much we're going

Re: [PATCH 4/5] drm/omap: Stop using drm_framebuffer_unregister_private

2017-01-12 Thread Laurent Pinchart
Hi Daniel, Thank you for the patch. On Tuesday 27 Dec 2016 11:49:24 Daniel Vetter wrote: > This is the deprecated function for when you embedded the framebuffer > somewhere else (which breaks refcounting). But omapdrm is using > drm_framebuffer_remove and a free-standing fb, so this is rendundant

Re: [PATCH 2/5] drm/cma-helper: Stop using drm_framebuffer_unregister_private

2017-01-12 Thread Laurent Pinchart
Hi Daniel, Thank you for the patch. On Tuesday 27 Dec 2016 11:49:22 Daniel Vetter wrote: > This is the deprecated function for when you embedded the framebuffer > somewhere else (which breaks refcounting). But cma helpers are using > drm_framebuffer_remove and a free-standing fb, so this is rendu

Re: [PATCH 5/5] drm/edid: Set YQ bits in the AVI infoframe according to CEA-861-F

2017-01-12 Thread Jani Nikula
On Wed, 11 Jan 2017, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > CEA-861-F tells us: > "When transmitting any RGB colorimetry, the Source should set the > YQ-field to match the RGB Quantization Range being transmitted > (e.g., when Limited Range RGB, set YQ=0 or when Full Rang

Re: [PATCH 5/5] drm/tegra: Stop using drm_framebuffer_unregister_private

2017-01-12 Thread Archit Taneja
On 12/27/2016 04:19 PM, Daniel Vetter wrote: This is the deprecated function for when you embedded the framebuffer somewhere else (which breaks refcounting). But tegra is using drm_framebuffer_remove and a free-standing fb, so this is rendundant. s/rendundant/redundant One caveat here is t

Re: [Intel-gfx] [PATCH 1/3] drm: Add new DRM_IOCTL_MODE_GETPLANE2

2017-01-12 Thread Ville Syrjälä
On Wed, Jan 11, 2017 at 04:51:16PM -0800, Ben Widawsky wrote: > Originally based off of a patch by Kristian. > > This new ioctl extends DRM_IOCTL_MODE_GETPLANE, by returning information > about the modifiers that will work with each format. > > It's modified from Kristian's patch in that the modi

Re: [PATCH 5/5] drm/edid: Set YQ bits in the AVI infoframe according to CEA-861-F

2017-01-12 Thread Ville Syrjälä
On Thu, Jan 12, 2017 at 12:13:47PM +0200, Jani Nikula wrote: > On Wed, 11 Jan 2017, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > CEA-861-F tells us: > > "When transmitting any RGB colorimetry, the Source should set the > > YQ-field to match the RGB Quantization Range being

Re: [PATCH 2/3] drm/i915: Add format modifiers for Intel

2017-01-12 Thread Ville Syrjälä
On Wed, Jan 11, 2017 at 04:51:17PM -0800, Ben Widawsky wrote: > This was based on a patch originally by Kristian. It has been modified > pretty heavily to use the new callbacks from the previous patch. > > Cc: Kristian H. Kristensen > Signed-off-by: Ben Widawsky > --- > drivers/gpu/drm/i915/int

[Bug 94900] HD6950 GPU lockup loop with various steam games (octodad[always], saints row 4[always], dead island[always], grid autosport[sometimes])

2017-01-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94900 Andreas Boll changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

Re: [PATCH 5/5] drm/edid: Set YQ bits in the AVI infoframe according to CEA-861-F

2017-01-12 Thread Jani Nikula
On Thu, 12 Jan 2017, Ville Syrjälä wrote: > On Thu, Jan 12, 2017 at 12:13:47PM +0200, Jani Nikula wrote: >> On Wed, 11 Jan 2017, ville.syrj...@linux.intel.com wrote: >> > From: Ville Syrjälä >> > >> > CEA-861-F tells us: >> > "When transmitting any RGB colorimetry, the Source should set the >> >

[PATCH] drm: tegra: shut up harmless warning on NOMMU

2017-01-12 Thread Arnd Bergmann
The tegra DRM driver is almost ok without an MMU, but there is one small warning that I get: drivers/gpu/drm/tegra/gem.c: In function 'tegra_drm_mmap': drivers/gpu/drm/tegra/gem.c:508:12: unused variable 'prot' This marks the variable as __maybe_unused instead. Signed-off-by: Arnd Bergmann ---

Re: [Intel-gfx] GPU hang with kernel 4.10rc3

2017-01-12 Thread Juergen Gross
On 11/01/17 18:08, Chris Wilson wrote: > On Wed, Jan 11, 2017 at 05:33:34PM +0100, Juergen Gross wrote: >> With kernel 4.10rc3 running as Xen dm0 I get at each boot: >> >> [ 49.213697] [drm] GPU HANG: ecode 7:0:0x3d1d3d3d, in gnome-shell >> [1431], reason: Hang on render ring, action: reset >> [

Re: [PATCH 1/3] drm: bridge: dw-hdmi: Define and use macros for PHY register addresses

2017-01-12 Thread Nickey.Yang
Hi Laurent, 在 2017年01月12日 07:49, Laurent Pinchart 写道: Replace the hardcoded register address numerical values with macros to clarify the code. This change has been tested by comparing the assembly code before and after the change. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/bridge/

[PATCH 2/2] drm/nouveau: Handle fbcon suspend/resume in seperate worker

2017-01-12 Thread Lyude
Resuming from RPM can happen while already holding dev->mode_config.mutex. This means we can't actually handle fbcon in any RPM resume workers, since restoring fbcon requires grabbing dev->mode_config.mutex again. So move the fbcon suspend/resume code into it's own worker, and rely on that instead

Re: Enabling peer to peer device transactions for PCIe devices

2017-01-12 Thread Stephen Bates
On Fri, January 6, 2017 4:10 pm, Logan Gunthorpe wrote: > > > On 06/01/17 11:26 AM, Jason Gunthorpe wrote: > > >> Make a generic API for all of this and you'd have my vote.. >> >> >> IMHO, you must support basic pinning semantics - that is necessary to >> support generic short lived DMA (eg filesys

[PATCH v2 1/2] drm/nouveau: Don't enabling polling twice on runtime resume

2017-01-12 Thread Lyude
As it turns out, on cards that actually have CRTCs on them we're already calling drm_kms_helper_poll_enable(drm_dev) from nouveau_display_resume() before we call it in nouveau_pmops_runtime_resume(). This leads us to accidentally trying to enable polling twice, which results in a potential deadlock

[PULL] drm-intel-fixes

2017-01-12 Thread Jani Nikula
Hi Dave - Mostly GVT-g fixes, with a couple of other fixes from Chris. BR, Jani. The following changes since commit a121103c922847ba5010819a3f250f1f7fc84ab8: Linux 4.10-rc3 (2017-01-08 14:18:17 -0800) are available in the git repository at: git://anongit.freedesktop.org/git/drm-intel tag

Re: [Intel-gfx] [PATCH v2 2/5] drm/edid: Introduce drm_default_rgb_quant_range()

2017-01-12 Thread Ville Syrjälä
On Thu, Jan 12, 2017 at 11:29:18AM +0200, Jani Nikula wrote: > On Wed, 11 Jan 2017, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Make the code selecting the RGB quantization range a little less magicy > > by wrapping it up in a small helper. > > > > v2: s/adjusted_mode/mode

Re: [PATCH 5/5] drm/tegra: Stop using drm_framebuffer_unregister_private

2017-01-12 Thread Thierry Reding
On Tue, Dec 27, 2016 at 11:49:25AM +0100, Daniel Vetter wrote: > This is the deprecated function for when you embedded the framebuffer > somewhere else (which breaks refcounting). But tegra is using > drm_framebuffer_remove and a free-standing fb, so this is rendundant. Nit: "Tegra", "redundant",

Re: [PATCH] drm/amdgpu/gfx8: fix bugon.cocci warnings

2017-01-12 Thread Alex Deucher
On Tue, Jan 10, 2017 at 4:38 AM, Yu, Xiangliang wrote: >> Use BUG_ON instead of a if condition followed by BUG. >> >> Generated by: scripts/coccinelle/misc/bugon.cocci >> >> CC: Xiangliang Yu >> Signed-off-by: Julia Lawall >> Signed-off-by: Fengguang Wu Applied. thanks! Alex >> --- >> >>

Re: [Intel-gfx] [PATCH 1/3] drm: Add new DRM_IOCTL_MODE_GETPLANE2

2017-01-12 Thread Rob Clark
On Thu, Jan 12, 2017 at 4:38 AM, Ville Syrjälä wrote: > On Wed, Jan 11, 2017 at 08:43:16PM -0500, Rob Clark wrote: >> On Wed, Jan 11, 2017 at 7:51 PM, Ben Widawsky wrote: >> > >> > +struct drm_format_modifier { >> > + /* Bitmask of formats in get_plane format list this info >> > +*

Re: Enabling peer to peer device transactions for PCIe devices

2017-01-12 Thread Jerome Glisse
On Wed, Jan 11, 2017 at 10:54:39PM -0600, Stephen Bates wrote: > On Fri, January 6, 2017 4:10 pm, Logan Gunthorpe wrote: > > > > > > On 06/01/17 11:26 AM, Jason Gunthorpe wrote: > > > > > >> Make a generic API for all of this and you'd have my vote.. > >> > >> > >> IMHO, you must support basic pinn

Re: [PATCH 1/3] drm: bridge: dw-hdmi: Define and use macros for PHY register addresses

2017-01-12 Thread Laurent Pinchart
Hi Nickey, On Thursday 12 Jan 2017 09:45:31 Nickey.Yang wrote: > 在 2017年01月12日 07:49, Laurent Pinchart 写道: > > Replace the hardcoded register address numerical values with macros to > > clarify the code. > > > > This change has been tested by comparing the assembly code before and > > after the c

[PATCH] drm: Don't race connector registration

2017-01-12 Thread Daniel Vetter
I was under the misconception that the sysfs dev stuff can be fully set up, and then registered all in one step with device_add. That's true for properties and property groups, but not for parents and child devices. Those must be fully registered before you can register a child. Add a bit of track

[PATCH 1/3] drm: qxl: Let DRM core handle connector registering

2017-01-12 Thread Gabriel Krisman Bertazi
Registering the connector explicitly right after creation is not necessary for modesetting drivers, because drm_dev_register already takes care of this on the core side, by calling drm_modeset_register_all. In addition, performing the initialization too early will get in the way of the load() hook

[PATCH 3/3] drm: qxl: Open code teardown function for qxl

2017-01-12 Thread Gabriel Krisman Bertazi
This avoids using the deprecated drm_put_dev() and unload() hook interfaces in the qxl driver. Signed-off-by: Gabriel Krisman Bertazi CC: Dave Airlie CC: Daniel Vetter CC: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/qxl/qxl_drv.c | 11 +-- drivers/gpu/drm/qxl/qxl_drv.h | 2 --

[PATCH 2/3] drm: qxl: Open code probing sequence for qxl

2017-01-12 Thread Gabriel Krisman Bertazi
This avoids using the deprecated drm_get_pci_dev() and load() hook interfaces in the qxl driver. The only tricky part is to ensure TTM debugfs initialization happens after the debugfs root node is created, which is done by moving that code into the debufs_init() hook. Since the hook is called 3 t

Re: [PATCH] drm: Don't race connector registration

2017-01-12 Thread Daniel Vetter
On Thu, Jan 12, 2017 at 05:15:56PM +0100, Daniel Vetter wrote: > I was under the misconception that the sysfs dev stuff can be fully > set up, and then registered all in one step with device_add. That's > true for properties and property groups, but not for parents and child > devices. Those must b

[PATCH 0/3] Use nonblocking atomic helpers

2017-01-12 Thread Fabien Dessenne
This series replaces the driver customized atomic_commit implementation with the drm core helpers (patch 1). The vblank event management is reworked (patch 2) and a side-effect is fixed (patch 3). Fabien ___ dri-devel mailing list dri-devel@lists.freed

[PATCH 1/3] drm/sti: use atomic_helper for commit

2017-01-12 Thread Fabien Dessenne
Since nonblocking atomic commits are now supported, the driver can now use drm_atomic_helper_commit(). Signed-off-by: Fabien Dessenne --- drivers/gpu/drm/sti/sti_drv.c | 83 +-- drivers/gpu/drm/sti/sti_drv.h | 6 2 files changed, 1 insertion(+), 88 d

[PATCH 3/3] drm/sti: do not check hw scaling if mode is not set

2017-01-12 Thread Fabien Dessenne
Fix a division by 0 case : in some cases, when the HQVDP plane is being disabled atomic_check() is called with "mode->clock = 0". In that case, do not check for scaling capabilities. Signed-off-by: Fabien Dessenne --- drivers/gpu/drm/sti/sti_hqvdp.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH 2/3] drm/sti: Fix up crtc_state->event handling

2017-01-12 Thread Fabien Dessenne
Use drm-core to handle event. This is required to be able to use the nonblocking helpers. Signed-off-by: Fabien Dessenne --- drivers/gpu/drm/sti/sti_crtc.c | 46 + drivers/gpu/drm/sti/sti_mixer.h | 2 -- 2 files changed, 14 insertions(+), 34 deletions(-)

Re: [PATCH] drm: Don't race connector registration

2017-01-12 Thread Chris Wilson
On Thu, Jan 12, 2017 at 05:15:56PM +0100, Daniel Vetter wrote: > I was under the misconception that the sysfs dev stuff can be fully > set up, and then registered all in one step with device_add. That's > true for properties and property groups, but not for parents and child > devices. Those must b

[Bug 99236] System (seems to) completely freeze when interacting with java swing applications.

2017-01-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99236 --- Comment #16 from Vitaly Ostrosablin --- Have successfully updated to latest mesa. Seems like issue was fixed recently. -- You are receiving this mail because: You are the assignee for the bug.___

Re: [Intel-gfx] [PATCH 1/3] drm: Add new DRM_IOCTL_MODE_GETPLANE2

2017-01-12 Thread Daniel Stone
Hi, On 12 January 2017 at 14:56, Rob Clark wrote: > On Thu, Jan 12, 2017 at 4:38 AM, Ville Syrjälä > wrote: >> Isn't an implicit offset enough? As in first mask for a specific >> modifier is for format indexes 0-63, second mask for the same modifier >> is for 64-127, and so on. > > hmm, hadn't t

Re: [Intel-gfx] [PATCH 1/3] drm: Add new DRM_IOCTL_MODE_GETPLANE2

2017-01-12 Thread Ville Syrjälä
On Thu, Jan 12, 2017 at 05:04:46PM +, Daniel Stone wrote: > Hi, > > On 12 January 2017 at 14:56, Rob Clark wrote: > > On Thu, Jan 12, 2017 at 4:38 AM, Ville Syrjälä > > wrote: > >> Isn't an implicit offset enough? As in first mask for a specific > >> modifier is for format indexes 0-63, seco

Re: [Intel-gfx] [PATCH 1/3] drm: Add new DRM_IOCTL_MODE_GETPLANE2

2017-01-12 Thread Daniel Stone
Hi, On 12 January 2017 at 17:45, Ville Syrjälä wrote: > On Thu, Jan 12, 2017 at 05:04:46PM +, Daniel Stone wrote: >> Implicit is clever but horrible. AFAICT, the only way to do it >> properly would be to have a nested forwards loop walk when you first >> hit a modifier, searching for further

Re: [PATCH 2/3] drm/i915: Add format modifiers for Intel

2017-01-12 Thread Ben Widawsky
On 17-01-12 12:51:20, Ville Syrjälä wrote: On Wed, Jan 11, 2017 at 04:51:17PM -0800, Ben Widawsky wrote: This was based on a patch originally by Kristian. It has been modified pretty heavily to use the new callbacks from the previous patch. Cc: Kristian H. Kristensen Signed-off-by: Ben Widawsk

Re: [Intel-gfx] [PATCH 1/3] drm: Add new DRM_IOCTL_MODE_GETPLANE2

2017-01-12 Thread Ville Syrjälä
On Thu, Jan 12, 2017 at 05:50:15PM +, Daniel Stone wrote: > Hi, > > On 12 January 2017 at 17:45, Ville Syrjälä > wrote: > > On Thu, Jan 12, 2017 at 05:04:46PM +, Daniel Stone wrote: > >> Implicit is clever but horrible. AFAICT, the only way to do it > >> properly would be to have a nested

RE: [PATCH] drm/atomic: Add target_vblank support in atomic helpers (v2)

2017-01-12 Thread Grodzovsky, Andrey
> -Original Message- > From: daniel.vet...@ffwll.ch [mailto:daniel.vet...@ffwll.ch] On Behalf Of > Daniel Vetter > Sent: Thursday, January 12, 2017 3:51 AM > To: Michel Dänzer > Cc: Grodzovsky, Andrey; Deucher, Alexander; dri- > de...@lists.freedesktop.org > Subject: Re: [PATCH] drm/atomic:

Re: [PATCH 2/3] drm/i915: Add format modifiers for Intel

2017-01-12 Thread Ville Syrjälä
On Thu, Jan 12, 2017 at 10:00:55AM -0800, Ben Widawsky wrote: > On 17-01-12 12:51:20, Ville Syrjälä wrote: > >On Wed, Jan 11, 2017 at 04:51:17PM -0800, Ben Widawsky wrote: > >> This was based on a patch originally by Kristian. It has been modified > >> pretty heavily to use the new callbacks from t

Re: [PATCH 03/10] drm/i915/psr: fix blank screen issue for psr2

2017-01-12 Thread Vivi, Rodrigo
Reviewed-by: Rodrigo Vivi On Thu, 2017-01-12 at 23:30 +0530, vathsala nagaraju wrote: > Psr1 and psr2 are mutually exclusive,ie when psr2 is enabled, > psr1 should be disabled.When psr2 is exited , bit 31 of reg > PSR2_CTL must be set to 0 but currently bit 31 of SRD_CTL > (psr1 control register)

[Bug 97025] flip queue failed: Device or resource busy

2017-01-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97025 --- Comment #24 from Kevin McCormack --- I am experiencing what I think may be a similar issue. When my display sleeps, it often does not wake up on keypress. I have to wait anywhere from a few seconds to a few minutes and then have errors in my

[Bug 97025] flip queue failed: Device or resource busy

2017-01-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97025 --- Comment #25 from Kevin McCormack --- Created attachment 128916 --> https://bugs.freedesktop.org/attachment.cgi?id=128916&action=edit Delayed recovery from display sleep logs -- You are receiving this mail because: You are the assignee for

Re: [PATCH 3/7] i2c: designware-baytrail: Take punit lock on bus acquire

2017-01-12 Thread Wolfram Sang
On Sun, Jan 08, 2017 at 02:44:23PM +0100, Hans de Goede wrote: > Take the punit lock to stop others from accessing the punit while the > pmic i2c bus is in use. This is necessary because accessing the punit > from the kernel may result in the punit trying to access the pmic i2c > bus, which results

Re: [PATCH 4/7] i2c: designware-baytrail: Call pmic_bus_access_notifier_chain

2017-01-12 Thread Wolfram Sang
On Sun, Jan 08, 2017 at 02:44:24PM +0100, Hans de Goede wrote: > Call the iosf_mbi pmic_bus_access_notifier_chain on bus acquire / release. > > BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=155241 > Signed-off-by: Hans de Goede > Tested-by: tagorereddy Acked-by: Wolfram Sang __

Re: [PATCH 2/3] drm/i915: Add format modifiers for Intel

2017-01-12 Thread Ben Widawsky
On 17-01-12 20:32:07, Ville Syrjälä wrote: On Thu, Jan 12, 2017 at 10:00:55AM -0800, Ben Widawsky wrote: On 17-01-12 12:51:20, Ville Syrjälä wrote: >On Wed, Jan 11, 2017 at 04:51:17PM -0800, Ben Widawsky wrote: >> This was based on a patch originally by Kristian. It has been modified >> pretty h

[Bug 99387] Kernel 4.9: Kaveri + Hainan choked on boot using amdgpu

2017-01-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99387 Bug ID: 99387 Summary: Kernel 4.9: Kaveri + Hainan choked on boot using amdgpu Product: DRI Version: DRI git Hardware: x86-64 (AMD64) OS: Linux (All)

Re: Why does OUT_FENCE_PTR point not to an fd (s32) but to an s64?

2017-01-12 Thread Gustavo Padovan
2017-01-10 Laurent Pinchart : > Hi Daniel, > > On Monday 09 Jan 2017 11:23:23 Daniel Vetter wrote: > > On Fri, Jan 06, 2017 at 01:04:55PM -0800, Chad Versace wrote: > > > Was this a mistake in the API? If so, can we fix this ABI mistake before > > > kernel consumers rely on this? > > > > > > I n

Re: Why does OUT_FENCE_PTR point not to an fd (s32) but to an s64?

2017-01-12 Thread Daniel Vetter
On Thu, Jan 12, 2017 at 05:17:26PM -0200, Gustavo Padovan wrote: > 2017-01-10 Laurent Pinchart : > > > Hi Daniel, > > > > On Monday 09 Jan 2017 11:23:23 Daniel Vetter wrote: > > > On Fri, Jan 06, 2017 at 01:04:55PM -0800, Chad Versace wrote: > > > > Was this a mistake in the API? If so, can we fi

Re: Why does OUT_FENCE_PTR point not to an fd (s32) but to an s64?

2017-01-12 Thread Laurent Pinchart
Hi Daniel, On Thursday 12 Jan 2017 20:26:40 Daniel Vetter wrote: > On Thu, Jan 12, 2017 at 05:17:26PM -0200, Gustavo Padovan wrote: > > 2017-01-10 Laurent Pinchart : > >> On Monday 09 Jan 2017 11:23:23 Daniel Vetter wrote: > >>> On Fri, Jan 06, 2017 at 01:04:55PM -0800, Chad Versace wrote: >

Re: Why does OUT_FENCE_PTR point not to an fd (s32) but to an s64?

2017-01-12 Thread Gustavo Padovan
2017-01-12 Laurent Pinchart : > Hi Daniel, > > On Thursday 12 Jan 2017 20:26:40 Daniel Vetter wrote: > > On Thu, Jan 12, 2017 at 05:17:26PM -0200, Gustavo Padovan wrote: > > > 2017-01-10 Laurent Pinchart : > > >> On Monday 09 Jan 2017 11:23:23 Daniel Vetter wrote: > > >>> On Fri, Jan 06, 2017 at

Re: [PATCH] drm/atomic: Add target_vblank support in atomic helpers (v2)

2017-01-12 Thread Daniel Vetter
On Thu, Jan 12, 2017 at 06:18:20PM +, Grodzovsky, Andrey wrote: > > -Original Message- > > From: daniel.vet...@ffwll.ch [mailto:daniel.vet...@ffwll.ch] On Behalf Of > > Daniel Vetter > > Sent: Thursday, January 12, 2017 3:51 AM > > To: Michel Dänzer > > Cc: Grodzovsky, Andrey; Deucher,

[Bug 99387] Kernel 4.9: Kaveri + Hainan choked on boot using amdgpu

2017-01-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99387 --- Comment #1 from Jeremy Newton --- FYI, this is build off of Alexander Deucher's freedesktop mirror, amd-staging-4.9 branch, with the 4.9.2 patch-set and Fedora's patchset (minus the amd patches that conflict or are already applied in this bra

Re: [PATCH 06/10] drm/i915/psr: set CHICKEN_TRANS for psr2

2017-01-12 Thread Vivi, Rodrigo
Reviewed-by: Rodrigo Vivi On Fri, 2017-01-13 at 00:31 +0530, vathsala nagaraju wrote: > As per bpsec, CHICKEN_TRANS_EDP bit 12 ,15 must be programmed in > psr2 enable sequence. > bit 12 : Program Transcoder EDP VSC DIP header with a valid setting for > PSR2 and Set CHICKEN_TRANS_EDP(0x420

[PATCH libdrm 1/2] xf86drmMode.h: Use consistent padding

2017-01-12 Thread Thierry Reding
From: Thierry Reding Signed-off-by: Thierry Reding --- xf86drmMode.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/xf86drmMode.h b/xf86drmMode.h index b68496787b84..00ad81d17ef3 100644 --- a/xf86drmMode.h +++ b/xf86drmMode.h @@ -123,13 +123,13 @@ extern "C

[PATCH libdrm 2/2] xf86drmMode.h: Add DisplayPort MST and DPI encoders/connectors

2017-01-12 Thread Thierry Reding
From: Thierry Reding This brings xf86drmMode.h in sync with include/drm/drm_mode.h. Eventually we really should only have a single set of definitions rather than duplicating this in two files. v2: add DPI encoder and connector types introduced in Linux v4.7 Signed-off-by: Thierry Reding --- x

Re: [PATCH libdrm 2/2] Add .editorconfig

2017-01-12 Thread Thierry Reding
On Sat, Dec 24, 2016 at 05:04:14PM +, Emil Velikov wrote: > On 23 December 2016 at 17:36, Thierry Reding wrote: > > From: Thierry Reding > > > > This encodes the indentation style for libdrm and can be used with > > various editors. See http://editorconfig.org for instructions. > > > Thanks f

[PATCH libdrm] xf86drm: Fix type-punned pointer build warning

2017-01-12 Thread Thierry Reding
From: Thierry Reding CC libdrm_la-xf86drmMode.lo ../xf86drmMode.c: In function 'drmHandleEvent': ../xf86drmMode.c:854:15: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] e = (struct drm_event *)(&buffer[i]);

[PATCH libdrm v2 0/4] xf86drm: Add USB, platform and host1x bus support

2017-01-12 Thread Thierry Reding
From: Thierry Reding This series enables support for USB, platform and host1x busses in the drmDevice infrastructure. The goal is to make use of these in Mesa for PRIME support (via the DRI_PRIME environment variable) for devices on one of these busses. Changes in v2: - add USB, platform and hos

[PATCH libdrm v2 1/4] xf86drm: Factor out drmDeviceAlloc()

2017-01-12 Thread Thierry Reding
From: Thierry Reding Subsequent patches will add support for other bus types to drmDevice and they will duplicate a lot of the code to allocate a drmDevice. Factor out the common code so it can be reused. Signed-off-by: Thierry Reding --- xf86drm.c | 78

[PATCH libdrm v2 2/4] xf86drm: Add USB support

2017-01-12 Thread Thierry Reding
Allow DRM/KMS devices hosted on USB to be detected by the drmDevice infrastructure. v2: - make sysfs_uevent_get() more flexible using a format string Signed-off-by: Thierry Reding --- xf86drm.c | 163 ++ xf86drm.h | 13 + 2 files

[PATCH libdrm v2 3/4] xf86drm: Add platform and host1x bus support

2017-01-12 Thread Thierry Reding
From: Thierry Reding ARM SoCs usually have their DRM/KMS devices on the platform bus, so add support for that to enable these devices to be used with the drmDevice infrastructure. NVIDIA Tegra SoCs have an additional level in the hierarchy and DRM/KMS devices can also be on the host1x bus. This

[PATCH libdrm v2 4/4] tests/drmdevice: Add USB, platform and host1x support

2017-01-12 Thread Thierry Reding
From: Thierry Reding Extend the drmdevice test with support for the newly added USB, platform and host1x busses. Signed-off-by: Thierry Reding --- tests/drmdevice.c | 37 + 1 file changed, 37 insertions(+) diff --git a/tests/drmdevice.c b/tests/drmdevice.c

Re: [Intel-gfx] [PATCH 1/3] drm: Add new DRM_IOCTL_MODE_GETPLANE2

2017-01-12 Thread Daniel Stone
Hi, On 12 January 2017 at 18:11, Ville Syrjälä wrote: > On Thu, Jan 12, 2017 at 05:50:15PM +, Daniel Stone wrote: >> struct drm_plane { >> struct { >> uint32_t format; >> uint64_t modifiers[]; >> } formats[]; >> } > > Flipping formats[] vs. modifiers[] here would seem

[Bug 99387] Kernel 4.9: Kaveri + Hainan choked on boot using amdgpu

2017-01-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99387 --- Comment #2 from Luya Tshimbalanga --- Checking the linux-firmware, the system was still on 20160923 snapshot. Koji has the lastest version so I upgrade to it. I will report if that fixes the issue. -- You are receiving this mail because: Yo

[Bug 99387] Kernel 4.9: Kaveri + Hainan choked on boot using amdgpu

2017-01-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99387 --- Comment #3 from Alex Deucher --- You don't need amdgpu.exp_hw_support=1 You just have to make sure SI and CIK support are enabled. -- You are receiving this mail because: You are the assignee for the bug.___

[Bug 98513] [REGRESSION][drm-next-4.10-wip][AMDGPU][CIK] Unable to suspend, hangs on hibernation bad commit 86f8c599b09c916f9aad30563271440dbd79213a

2017-01-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98513 --- Comment #4 from Shawn Starr --- As noted on IRC 4.10-rc2 w/ drm-next-4.10-wip and 4.10-rc3 w/ drm-next-4.11-wip do not require this commit to be reverted. Hibernate (freeze), Resume (thaw) seem to work fine here, keeping ticket open for furt

[Bug 99392] Ark survival evolved won't start

2017-01-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99392 Bug ID: 99392 Summary: Ark survival evolved won't start Product: Mesa Version: 13.0 Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: normal

[Bug 99393] mesa build failure when using config.status: sid_tables.h generation

2017-01-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99393 Bug ID: 99393 Summary: mesa build failure when using config.status: sid_tables.h generation Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (A

[PATCH -next] drm/hisilicon/hibmc: Fix wrong pointer passed to PTR_ERR()

2017-01-12 Thread Wei Yongjun
From: Wei Yongjun PTR_ERR should access the value just tested by IS_ERR, otherwise the wrong error code will be returned. Fixes: d1667b86795a ("drm/hisilicon/hibmc: Add support for frame buffer") Signed-off-by: Wei Yongjun --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_fbdev.c | 2 +- 1 file ch

[Bug 99393] mesa build failure when using config.status: sid_tables.h generation

2017-01-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99393 Ivan Fomin changed: What|Removed |Added Severity|normal |trivial -- You are receiving this mail bec

Re: [PATCH v2 7/7] uapi: export all headers under uapi directories

2017-01-12 Thread Nicolas Dichtel
Le 09/01/2017 à 13:56, Christoph Hellwig a écrit : > On Fri, Jan 06, 2017 at 10:43:59AM +0100, Nicolas Dichtel wrote: >> Regularly, when a new header is created in include/uapi/, the developer >> forgets to add it in the corresponding Kbuild file. This error is usually >> detected after the release

[PATCH 06/10] drm/i915/psr: set CHICKEN_TRANS for psr2

2017-01-12 Thread vathsala nagaraju
As per bpsec, CHICKEN_TRANS_EDP bit 12 ,15 must be programmed in psr2 enable sequence. bit 12 : Program Transcoder EDP VSC DIP header with a valid setting for PSR2 and Set CHICKEN_TRANS_EDP(0x420cc) bit 12 for programmable header packet. bit 15 : Set CHICKEN_TRANS_EDP(0x420cc) bit 1

[PATCH 07/10] drm/i915/psr: set PSR_MASK bits for deep sleep

2017-01-12 Thread vathsala nagaraju
Program EDP_PSR_DEBUG_CTL (PSR_MASK) to enable system to go to deep sleep while in psr2.PSR2_STATUS bit 31:28 should report value 8 , if system enters deep sleep state. Also, EDP_FRAMES_BEFORE_SU_ENTRY is set 1 , if not set, flickering is observed on psr2 panel. v2: (Ilia Mirkin) - Remove duplica

Re: Enabling peer to peer device transactions for PCIe devices

2017-01-12 Thread Jason Gunthorpe
On Thu, Jan 12, 2017 at 10:11:29AM -0500, Jerome Glisse wrote: > On Wed, Jan 11, 2017 at 10:54:39PM -0600, Stephen Bates wrote: > > > What we want is for RDMA, O_DIRECT, etc to just work with special VMAs > > > (ie. at least those backed with ZONE_DEVICE memory). Then > > > GPU/NVME/DAX/whatever dr

[PATCH 03/10] drm/i915/psr: fix blank screen issue for psr2

2017-01-12 Thread vathsala nagaraju
Psr1 and psr2 are mutually exclusive,ie when psr2 is enabled, psr1 should be disabled.When psr2 is exited , bit 31 of reg PSR2_CTL must be set to 0 but currently bit 31 of SRD_CTL (psr1 control register)is set to 0. Also ,PSR2_IDLE state is looked up from SRD_STATUS(psr1 register) instead of PSR2_S

Re: [PATCH v2 7/7] uapi: export all headers under uapi directories

2017-01-12 Thread Nicolas Dichtel
Le 12/01/2017 à 17:28, Jan Engelhardt a écrit : > On Thursday 2017-01-12 16:52, Nicolas Dichtel wrote: > >> Le 09/01/2017 à 13:56, Christoph Hellwig a écrit : >>> On Fri, Jan 06, 2017 at 10:43:59AM +0100, Nicolas Dichtel wrote: Regularly, when a new header is created in include/uapi/, the dev

[PATCH -next] drm/atomic: make release_crtc_commit() static

2017-01-12 Thread Wei Yongjun
From: Wei Yongjun Fixes the following sparse warning: drivers/gpu/drm/drm_atomic_helper.c:1360:6: warning: symbol 'release_crtc_commit' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- drivers/gpu/drm/drm_atomic_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

  1   2   >