[Bug 93826] 2560x1440 @144Hz graphic glitches and bad refresh rate

2016-10-14 Thread bugzilla-dae...@freedesktop.org
is report is about the radeon driver, let's not confuse things here by mixing in amdgpu-pro issues. -- You are receiving this mail because: You are the assignee for the bug. -- next part -- An HTML attachment was scrubbed... URL: <https://lists.freedesktop.org/archives/

mm: fix cache mode tracking in vm_insert_mixed() breaks AMDGPU [was: Re: Latest testing with drm-next-4.9-wip and latest LLVM/mesa stack - Regression in PowerPlay/DPM on CIK?]

2016-10-14 Thread Michel Dänzer
[ Adding Dan Williams and dri-devel ] On 14/10/16 03:28 AM, Shawn Starr wrote: > Hello AMD folks, > > I have discovered a problem in Linus master that affects AMDGPU, nobody would > notice this in drm-next-4.9-wip since its not in this repo. [...] > 87744ab3832b83ba71b931f86f9cfdb000d07da5 is

[Bug 93649] [radeonsi] Graphics lockup while playing tf2

2016-10-14 Thread bugzilla-dae...@freedesktop.org
g didn't happen. So I don't think our word is less valid just because *one* user claimed he/she disabled DPM and the hang still happened. -- You are receiving this mail because: You are the assignee for the bug. -- next part -- An HTML attachment was scrubbed... U

[PATCH v3 1/9] drm/hisilicon/hibmc: Add hisilicon hibmc drm master driver

2016-10-14 Thread Benjamin Gaignard
[snip] > --- /dev/null > +++ b/drivers/gpu/drm/hisilicon/hibmc/Kconfig > @@ -0,0 +1,15 @@ > +config DRM_HISI_HIBMC > + tristate "DRM Support for Hisilicon Hibmc" > + depends on DRM && PCI > + select DRM_KMS_HELPER > + select DRM_KMS_FB_HELPER > + select DRM_GEM_CMA_HE

[RFC] drm: add atomic state printing

2016-10-14 Thread Ville Syrjälä
On Thu, Oct 13, 2016 at 04:14:04PM -0400, Rob Clark wrote: > On Thu, Oct 13, 2016 at 2:24 PM, Ville Syrjälä > wrote: > > On Thu, Oct 13, 2016 at 01:16:29PM -0400, Rob Clark wrote: > >> Sometimes we just want to see the atomic state, without getting so many > >> other debug traces. So add a new

[Bug 96449] Dying Light reports OpenGL version 3.0 with mesa-git

2016-10-14 Thread bugzilla-dae...@freedesktop.org
n HTML attachment was scrubbed... URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20161014/a05b382d/attachment-0001.html>

[Intel-gfx] [PATCH] drm: Print device information again in debugfs

2016-10-14 Thread Jani Nikula
On Thu, 13 Oct 2016, Daniel Vetter wrote: > I was a bit over-eager in my cleanup in > > commit 95c081c17f284de50eaca60d4d55643a64d39019 > Author: Daniel Vetter > Date: Tue Jun 21 10:54:12 2016 +0200 > > drm: Move master pointer from drm_minor to drm_device > > Noticed by Chris Wilson. > > F

[Bug 97099] Regression in 9ef8537e6 "drm/radeon: don't use fractional dividers on RS[78]80 if SS is enabled" (RV620)

2016-10-14 Thread bugzilla-dae...@freedesktop.org
mail because: You are the assignee for the bug. -- next part -- An HTML attachment was scrubbed... URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20161014/6f916818/attachment.html>

[PATCH] drm/edid: Only print the bad edid when aborting

2016-10-14 Thread Ville Syrjälä
On Thu, Oct 13, 2016 at 08:43:55PM +0100, Chris Wilson wrote: > Currently, if drm.debug is enabled, we get a DRM_ERROR message on the > intermediate edid reads. This causes transient failures in CI which > flags up the sporadic EDID read failures, which are recovered by > rereading the EDID automat

[RFC PATCH 00/11] Introduce writeback connectors

2016-10-14 Thread Archit Taneja
Hi Brian, On 10/11/2016 08:23 PM, Brian Starkey wrote: > Hi, > > This RFC series introduces a new connector type: > DRM_MODE_CONNECTOR_WRITEBACK > It is a follow-on from a previous discussion: [1] > > Writeback connectors are used to expose the memory writeback engines > found in some display con

[PATCH] drm/edid: Only print the bad edid when aborting

2016-10-14 Thread Chris Wilson
On Fri, Oct 14, 2016 at 01:46:37PM +0300, Ville Syrjälä wrote: > On Thu, Oct 13, 2016 at 08:43:55PM +0100, Chris Wilson wrote: > > Currently, if drm.debug is enabled, we get a DRM_ERROR message on the > > intermediate edid reads. This causes transient failures in CI which > > flags up the sporadi

[Bug 98016] [bisected] Fury fails to boot on drm-next-4.9

2016-10-14 Thread bugzilla-dae...@freedesktop.org
hares initrd. -- You are receiving this mail because: You are the assignee for the bug. -- next part -- An HTML attachment was scrubbed... URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20161014/3e61ed33/attachment-0001.html>

[PATCH 26/41] drm: Add reference counting to drm_atomic_state

2016-10-14 Thread Chris Wilson
drm_atomic_state has a complicated single owner model that tracks the single reference from allocation through to destruction on another thread - or perhaps on a local error path. We can simplify this tracking by using reference counting (at a cost of a few more atomics). This is even more benefici

[PATCH] drm/msm/mdp5: handle non-fullscreen base plane case

2016-10-14 Thread Archit Taneja
On 10/13/2016 10:18 PM, Rob Clark wrote: > If the bottom-most layer is not fullscreen, we need to use the BASE > mixer stage for solid fill (ie. MDP5_CTL_BLEND_OP_FLAG_BORDER_OUT). The > blend_setup() code pretty much handled this already, we just had to > figure this out in _atomic_check() and

[RFC PATCH 00/11] Introduce writeback connectors

2016-10-14 Thread Brian Starkey
Hi Archit, On Fri, Oct 14, 2016 at 04:20:14PM +0530, Archit Taneja wrote: >Hi Brian, > >On 10/11/2016 08:23 PM, Brian Starkey wrote: >>Hi, >> >>This RFC series introduces a new connector type: >> DRM_MODE_CONNECTOR_WRITEBACK >>It is a follow-on from a previous discussion: [1] >> >>Writeback connec

[PATCH 1/2] devicetree/bindings: display: Add bindings for LVDS panels

2016-10-14 Thread Rob Herring
On Sun, Oct 9, 2016 at 11:33 AM, Laurent Pinchart wrote: > Hi Rob, > > On Saturday 08 Oct 2016 20:29:39 Rob Herring wrote: >> On Tue, Oct 04, 2016 at 07:23:29PM +0300, Laurent Pinchart wrote: >> > LVDS is a physical layer specification defined in ANSI/TIA/EIA-644-A. >> > Multiple incompatible data

[PATCH] drm/msm/mdp5: handle non-fullscreen base plane case

2016-10-14 Thread Ville Syrjälä
On Thu, Oct 13, 2016 at 12:48:46PM -0400, Rob Clark wrote: > If the bottom-most layer is not fullscreen, we need to use the BASE > mixer stage for solid fill (ie. MDP5_CTL_BLEND_OP_FLAG_BORDER_OUT). The > blend_setup() code pretty much handled this already, we just had to > figure this out in _ato

[PATCH] drm/amd/powerplay: don't give up if DPM is already running

2016-10-14 Thread Zhu, Rex
Hi Alex, Your new attached patch is Tested-by and Reviewed-by: Rex Zhu Just one question, Do we need to set clock_gate for smu? Best Regards Rex -Original Message- From: Alex Deucher [mailto:alexdeuc...@gmail.com] Sent: Thursday, October 13, 2016 11:29 PM To: Zhu, Rex Cc: Grazvyda

[RFC PATCH 00/11] Introduce writeback connectors

2016-10-14 Thread Ville Syrjälä
On Fri, Oct 14, 2016 at 01:39:15PM +0100, Brian Starkey wrote: > Hi Archit, > > On Fri, Oct 14, 2016 at 04:20:14PM +0530, Archit Taneja wrote: > >Hi Brian, > > > >On 10/11/2016 08:23 PM, Brian Starkey wrote: > >>Hi, > >> > >>This RFC series introduces a new connector type: > >> DRM_MODE_CONNECTOR_

[PATCH] drivers/gpu/vga: allocate vga_arb_write() buffer on stack

2016-10-14 Thread Ville Syrjälä
On Fri, Oct 14, 2016 at 02:54:59PM +0200, Dmitry Vyukov wrote: > Size of kmalloc() in vga_arb_write() is controlled by user. > Too large kmalloc() size triggers WARNING message on console. > Allocate the buffer on stack to avoid the WARNING. > The string must be small (e.g "target PCI:domain:bus:de

[PATCH] drm/arcpgu: Accommodate adv7511 switch to DRM bridge

2016-10-14 Thread Eugeniy Paltsev
ARC PGU driver starts crashing on initialization after 'commit e12c2f645557 ("drm/i2c: adv7511: Convert to drm_bridge")' This happenes because in "arcpgu_drm_hdmi_init" function we get pointer of "drm_i2c_encoder_driver" structure, which doesn't exist after adv7511 hdmi encoder interface changed fr

[PATCH] drm/amd/powerplay: don't give up if DPM is already running

2016-10-14 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-bounces at lists.freedesktop.org] On Behalf > Of Zhu, Rex > Sent: Friday, October 14, 2016 8:12 AM > To: Alex Deucher > Cc: Maling list - DRI developers; amd-gfx list > Subject: RE: [PATCH] drm/amd/powerplay: don't give up if DPM is alrea

[PATCH] drm/msm/mdp5: handle non-fullscreen base plane case

2016-10-14 Thread Rob Clark
On Fri, Oct 14, 2016 at 8:45 AM, Ville Syrjälä wrote: > On Thu, Oct 13, 2016 at 12:48:46PM -0400, Rob Clark wrote: >> If the bottom-most layer is not fullscreen, we need to use the BASE >> mixer stage for solid fill (ie. MDP5_CTL_BLEND_OP_FLAG_BORDER_OUT). The >> blend_setup() code pretty much

[PATCH v3 1/9] drm/hisilicon/hibmc: Add hisilicon hibmc drm master driver

2016-10-14 Thread Benjamin Gaignard
Just by curiosity, why using "old" TTM instead of GEM ? any particular reasons ? 2016-10-14 16:44 GMT+02:00 Rongrong Zou : > Hi Benjamin, > > Thanks for reviewing! > > Benjamin Gaignard 於 2016/10/14 16:29 寫道: >> >> [snip] >> >>> --- /dev/null >>> +++ b/drivers/gpu/drm/hisilicon/hibmc/Kconfig

[bug report] drm/amd/powerplay: implement smu7 hwmgr to manager asics with smu ip version 7.

2016-10-14 Thread Dan Carpenter
Hello Rex Zhu, The patch 599a7e9fe1b6: "drm/amd/powerplay: implement smu7 hwmgr to manager asics with smu ip version 7." from Sep 9, 2016, leads to the following static checker warning: drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/smu7_hwmgr.c:2125 smu7_patch_limits_vddc() warn:

[Bug 98016] [bisected] Fury fails to boot on drm-next-4.9

2016-10-14 Thread bugzilla-dae...@freedesktop.org
the bug. -- next part -- An HTML attachment was scrubbed... URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20161014/f43ab8f8/attachment.html>

[Bug 98016] [bisected] Fury fails to boot on drm-next-4.9

2016-10-14 Thread bugzilla-dae...@freedesktop.org
ktop.org/archives/dri-devel/attachments/20161014/65669c70/attachment.html>

[RFC PATCH 00/11] Introduce writeback connectors

2016-10-14 Thread Daniel Vetter
On Fri, Oct 14, 2016 at 2:39 PM, Brian Starkey wrote: >> - Besides the above property, writeback hardware can have provisions >> for scaling, color space conversion and rotation. This would mean that >> we'd eventually add more writeback specific props/params in >> drm_connector/drm_connector_stat

[bug report] drm/amd/powerplay: implement smu7 hwmgr to manager asics with smu ip version 7.

2016-10-14 Thread Alex Deucher
l at lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- next part -- A non-text attachment was scrubbed... Name: 0001-drm-amdgpu-powerplay-smu7-fix-static-checker-warning.patch Type: text/x-patch Size: 1557 bytes Desc: not available URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20161014/c36f0df1/attachment.bin>

[Bug 94354] R9285 Unigine Valley perf regression since radeonsi: use re-Z

2016-10-14 Thread bugzilla-dae...@freedesktop.org
tps://lists.freedesktop.org/archives/dri-devel/attachments/20161014/a4c6fc63/attachment.html>

[pull] radeon and amdgpu drm-next-4.9

2016-10-14 Thread Alex Deucher
Hi Dave, Fixes for radeon and amdgpu for 4.9: - allow an additional reg in the SI reg checker - fix thermal sensor readback on CZ/ST - misc bug fixes The following changes since commit 69405d3da98b48633b78a49403e4f9cdb7c6a0f5: Merge tag 'topic/drm-misc-2016-10-11' of git://anongit.freedesktop

[Bug 93826] 2560x1440 @144Hz graphic glitches and bad refresh rate

2016-10-14 Thread bugzilla-dae...@freedesktop.org
eceiving this mail because: You are the assignee for the bug. -- next part -- An HTML attachment was scrubbed... URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20161014/64c5df1d/attachment.html>

Hibernation broken since commit 274ad65c9d02 ("drm/radeon: hard reset r600 and newer GPU when hibernating.")

2016-10-14 Thread Sven Joachim
On 2016-09-15 11:04 -0400, Jerome Glisse wrote: >> On Mon, Sep 5, 2016 at 10:25 PM, Jerome Glisse wrote: >> >> Recently I got myself a new laptop with the following integrated GPU: >> >> >> >> 00:01.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI] >> >> Mullins [Radeon R3 Graph

[Bug 91880] Radeonsi on Grenada cards (r9 390) exceptionally unstable and poorly performing

2016-10-14 Thread bugzilla-dae...@freedesktop.org
.org/archives/dri-devel/attachments/20161014/f94f87d9/attachment-0001.html>

[PATCH v3 00/10] Start of skl watermark cleanup

2016-10-14 Thread Lyude
While it (mostly) works, the code for handling watermarks on Skylake has been kind of ugly for a while. As well a lot of it isn't that friendly to atomic transactions, Lots of copy paste, redundant wm values, etc. While this isn't a full cleanup, it's a good start. As well, we add a couple of featu

[PATCH v3 01/10] drm/i915/skl: Move per-pipe ddb allocations into crtc states

2016-10-14 Thread Lyude
First part of cleaning up all of the skl watermark code. This moves the structures for storing the ddb allocations of each pipe into intel_crtc_state, along with moving the structures for storing the current ddb allocations active on hardware into intel_crtc. Changes since v1: - Don't replace allo

[PATCH v3 03/10] drm/i915/gen9: Make skl_wm_level per-plane

2016-10-14 Thread Lyude
Having skl_wm_level contain all of the watermarks for each plane is annoying since it prevents us from having any sort of object to represent a single watermark level, something we take advantage of in the next commit to cut down on all of the copy paste code in here. Changes since v1: - Style nit

[PATCH v3 05/10] drm/i915/gen9: Get rid of redundant watermark values

2016-10-14 Thread Lyude
Now that we've make skl_wm_levels make a little more sense, we can remove all of the redundant wm information. Up until now we'd been storing two copies of all of the skl watermarks: one being the skl_pipe_wm structs, the other being the global wm struct in drm_i915_private containing the raw regis

[PATCH v3 06/10] drm/i915/gen9: Add ddb changes to atomic debug output

2016-10-14 Thread Lyude
Finally, add some debugging output for ddb changes in the atomic debug output. This makes it a lot easier to spot bugs from incorrect ddb allocations. Signed-off-by: Lyude Reviewed-by: Maarten Lankhorst Reviewed-by: Paulo Zanoni Cc: Ville Syrjälä Cc: Matt Roper --- drivers/gpu/drm/i915/int

[PATCH v2 09/10] drm/i915/gen9: Actually verify WM levels in verify_wm_state()

2016-10-14 Thread Lyude
Thanks to Paulo Zanoni for indirectly pointing this out. Looks like we never actually added any code for checking whether or not we actually wrote watermark levels properly. Let's fix that. Changes since v1: - Use %u instead of %d when printing WM state mismatches Signed-off-by: Lyude Reviewed-

[PATCH v2 08/10] drm/i915/gen9: Add skl_wm_level_equals()

2016-10-14 Thread Lyude
Helper we're going to be using for implementing verification of the wm levels in skl_verify_wm_level(). Signed-off-by: Lyude Reviewed-by: Paulo Zanoni Cc: Maarten Lankhorst Cc: Ville Syrjälä Cc: Matt Roper --- drivers/gpu/drm/i915/intel_drv.h | 2 ++ drivers/gpu/drm/i915/intel_pm.c | 14

[PATCH v3 02/10] drm/i915/skl: Remove linetime from skl_wm_values

2016-10-14 Thread Lyude
Next part of cleaning up the watermark code for skl. This is easy, since it seems that we never actually needed to keep track of the linetime in the skl_wm_values struct anyway. Signed-off-by: Lyude Reviewed-by: Paulo Zanoni Reviewed-by: Maarten Lankhorst Cc: Ville Syrjälä Cc: Matt Roper --

[PATCH v2 04/10] drm/i915/gen9: Cleanup skl_pipe_wm_active_state

2016-10-14 Thread Lyude
This function is a wreck, let's help it get its life back together and cleanup all of the copy pasta here. Signed-off-by: Lyude Reviewed-by: Maarten Lankhorst Reviewed-by: Paulo Zanoni Cc: Ville Syrjälä Cc: Matt Roper --- drivers/gpu/drm/i915/intel_pm.c | 52 +++

[PATCH v2 07/10] drm/i915/gen9: Make skl_pipe_wm_get_hw_state() reusable

2016-10-14 Thread Lyude
There's not much of a reason this should have the locations to read out the hardware state hardcoded, so allow the caller to specify the location and add this function to intel_drv.h. As well, we're going to need this function to be reusable for the next patch. Changes since v1: - Fix accidental b

[PATCH v2 10/10] drm/i915/gen9: Don't wrap strings in verify_wm_state()

2016-10-14 Thread Lyude
Wrapping strings is against the guidelines in Documentation/CodingStyle, chapter 2. Signed-off-by: Lyude Reviewed-by: Paulo Zanoni Cc: Maarten Lankhorst Cc: Ville Syrjälä Cc: Matt Roper --- drivers/gpu/drm/i915/intel_display.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) di

[Bug 98016] [bisected] Fury fails to boot on drm-next-4.9

2016-10-14 Thread bugzilla-dae...@freedesktop.org
mail because: You are the assignee for the bug. -- next part -- An HTML attachment was scrubbed... URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20161014/a9b8cd19/attachment.html>

[Bug 98016] [bisected] Fury fails to boot on drm-next-4.9

2016-10-14 Thread bugzilla-dae...@freedesktop.org
-- An HTML attachment was scrubbed... URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20161014/771ca970/attachment.html>

[PATCH] drm/msm/mdp5: expose "alpha" property

2016-10-14 Thread Rob Clark
We had this wired up already internally but initially did not expose the property pending bikeshed about alpha and color management properties. I noted that drm-hwc2 was looking for this property, and a couple other drivers already support it in the same way. So time to expose it! Signed-off-by:

[PATCH 0/6] drm: add atomic state logging and debugfs

2016-10-14 Thread Rob Clark
Bit more spiffed out version of the RFC. Now with Sean's suggestion to add vfuncs in plane/crtc/connector funcs for drivers that subclass the various state structs. Plus Ville's suggestion about helper macros for printing mode/rect structs (and alignment with how drm_rect printed the integer and

[PATCH 2/6] drm: add helper for printing to log or seq_file

2016-10-14 Thread Rob Clark
Sometimes it is nice not to duplicate equivalent printk() and seq_printf() code. Signed-off-by: Rob Clark --- drivers/gpu/drm/Makefile| 3 ++- drivers/gpu/drm/drm_print.c | 54 +++ include/drm/drm_print.h | 62 +

[PATCH 6/6] drm/msm/mdp5: add atomic_print_state support

2016-10-14 Thread Rob Clark
We subclass drm_plane_state, so add mdp5_plane_atomic_print_state() to dump out our own driver specific plane state. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.h | 12 drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c | 18 +- 2 files changed, 29 in

[PATCH 4/6] drm/atomic: add new drm_debug bit to dump atomic state before commit

2016-10-14 Thread Rob Clark
Signed-off-by: Rob Clark --- drivers/gpu/drm/drm_atomic.c | 93 include/drm/drmP.h | 1 + include/drm/drm_crtc.h | 37 ++ 3 files changed, 131 insertions(+) diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/d

[PATCH 5/6] drm/atomic: add debugfs file to dump out atomic state

2016-10-14 Thread Rob Clark
Signed-off-by: Rob Clark --- drivers/gpu/drm/drm_atomic.c | 40 drivers/gpu/drm/drm_debugfs.c | 9 + include/drm/drm_atomic.h | 4 3 files changed, 53 insertions(+) diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomi

[PATCH 3/6] drm: add helpers to go from plane state to drm_rect

2016-10-14 Thread Rob Clark
Signed-off-by: Rob Clark --- drivers/gpu/drm/drm_simple_kms_helper.c | 14 ++ drivers/gpu/drm/i915/intel_atomic_plane.c | 10 ++ drivers/gpu/drm/mediatek/mtk_drm_plane.c| 15 ++- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 10 ++ include/drm/drm

[PATCH 1/6] drm: helper macros to print composite types

2016-10-14 Thread Rob Clark
I'll want to print things in a similar way in a later patch. This will make it easier. TODO drm_rect_debug_print() doesn't have many call sites, and is kind of unnecessary now. Should we just drop it? Signed-off-by: Rob Clark --- drivers/gpu/drm/drm_modes.c | 8 +--- drivers/gpu/drm/drm_

[PATCH 0/6] drm: add atomic state logging and debugfs

2016-10-14 Thread Rob Clark
On Fri, Oct 14, 2016 at 7:55 PM, Rob Clark wrote: > Bit more spiffed out version of the RFC. Now with Sean's suggestion to > add vfuncs in plane/crtc/connector funcs for drivers that subclass the > various state structs. Plus Ville's suggestion about helper macros > for printing mode/rect struct

[PATCH v2] drivers/gpu/vga: allocate vga_arb_write() buffer on stack

2016-10-14 Thread Dmitry Vyukov
Size of kmalloc() in vga_arb_write() is controlled by user. Too large kmalloc() size triggers WARNING message on console. Allocate the buffer on stack to avoid the WARNING. The string must be small (e.g "target PCI:domain:bus:dev.fn"). Signed-off-by: Dmitry Vyukov Reviewed-by: Ville Syrjälä Cc

[PATCH] drivers/gpu/vga: allocate vga_arb_write() buffer on stack

2016-10-14 Thread Dmitry Vyukov
On Fri, Oct 14, 2016 at 3:06 PM, Ville Syrjälä wrote: > On Fri, Oct 14, 2016 at 02:54:59PM +0200, Dmitry Vyukov wrote: >> Size of kmalloc() in vga_arb_write() is controlled by user. >> Too large kmalloc() size triggers WARNING message on console. >> Allocate the buffer on stack to avoid the WARN

[PATCH] drivers/gpu/vga: allocate vga_arb_write() buffer on stack

2016-10-14 Thread Dmitry Vyukov
Size of kmalloc() in vga_arb_write() is controlled by user. Too large kmalloc() size triggers WARNING message on console. Allocate the buffer on stack to avoid the WARNING. The string must be small (e.g "target PCI:domain:bus:dev.fn"). Signed-off-by: Dmitry Vyukov Cc: Dave Airlie Cc: Ville SyrjÃ

[PATCH v3 1/9] drm/hisilicon/hibmc: Add hisilicon hibmc drm master driver

2016-10-14 Thread Rongrong Zou
Hi Benjamin, Thanks for reviewing! Benjamin Gaignard 於 2016/10/14 16:29 寫道: > [snip] > >> --- /dev/null >> +++ b/drivers/gpu/drm/hisilicon/hibmc/Kconfig >> @@ -0,0 +1,15 @@ >> +config DRM_HISI_HIBMC >> + tristate "DRM Support for Hisilicon Hibmc" >> + depends on DRM && PCI >> +

[PATCH v3 1/9] drm/hisilicon/hibmc: Add hisilicon hibmc drm master driver

2016-10-14 Thread Rongrong Zou
Benjamin Gaignard 於 2016/10/14 22:33 寫道: > Just by curiosity, why using "old" TTM instead of GEM ? any particular > reasons ? Do you mean i can manage the video memory visiable to pci without TTM, i found all the other simple gpu chips(eg: AST, mgag200) use TTM, so i chose TTM. > > 2016-1