On Sat, May 24, 2014 at 8:30 PM, Rob Clark wrote:
> @@ -8002,7 +8002,7 @@ bool intel_get_load_detect_pipe(struct drm_connector
> *connector,
> if (encoder->crtc) {
> crtc = encoder->crtc;
>
> - mutex_lock(&crtc->mutex);
> + drm_modeset_lock(&crt
> > {
> > > return dma_buf_export(obj, &armada_gem_prime_dmabuf_ops,
> > > obj->size,
> > > - O_RDWR);
> > > + O_RDWR, NULL);
> > > }
> > >
> > > struct drm_gem_object *
> > > --
> > > 2.0.0.rc2
--
Cheers,
Stephen Rothwellsfr at canb.auug.org.au
-- next part --
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20140526/1a2b69f8/attachment.sig>
is mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20140526/f9e900a3/attachment-0001.html>
On Thursday, May 22, 2014 6:02 PM, Lee Jones wrote:
> On Thursday, May 22, 2014 5:45 PM, Hans de Goede wrote:
> > On Thursday, May 22, 2014 8:31 AM, Rafael J. Wysocki wrote:
> > > On Wednesday, May 21, 2014 10:40 PM, Hans de Goede wrote:
> > >> Some firmware drivers, ie acpi-video want to get thems
https://bugzilla.kernel.org/show_bug.cgi?id=75841
Darren Salt changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
-
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20140526/f3e214d5/attachment.html>
On May-23-2014 4:18 PM, Vandana Kannan wrote:
> On May-22-2014 5:46 PM, Daniel Vetter wrote:
>> On Thu, May 22, 2014 at 04:50:48PM +0530, Vandana Kannan wrote:
>>> Added a property to enable user space to set aspect ratio.
>>> This patch contains declaration of the property and code to create the
>
On 23.05.2014 17:40, Alex Courbot wrote:
> On 05/23/2014 06:59 PM, Lucas Stach wrote:
> So after checking with more knowledgeable people, it turns out this is
> the expected behavior on ARM and BAR regions should be mapped uncached
> on GK20A. All the more reasons to avoid using the BAR at all.
Hi Inki,
Please review this patch.
Regards,
Rahul Sharma
On 23 May 2014 17:17, Rahul Sharma wrote:
> From: Rahul Sharma
>
> Fimd probe is accessing fimd Registers without enabling the fimd
> gate clocks. If FIMD clocks are kept disabled in Uboot or disbaled
> during kernel boottime, the system
ng this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20140526/479f33cc/attachment.html>
On Mon, May 26, 2014 at 2:59 PM, Rahul Sharma
wrote:
>
> Hi Inki,
>
> Please review this patch.
>
> Regards,
> Rahul Sharma
>
> On 23 May 2014 17:17, Rahul Sharma wrote:
> > From: Rahul Sharma
> >
> > Fimd probe is accessing fimd Registers without enabling the fimd
> > gate clocks. If FIMD cloc
https://bugzilla.kernel.org/show_bug.cgi?id=76861
--- Comment #1 from Christian K?nig ---
Created attachment 137371
--> https://bugzilla.kernel.org/attachment.cgi?id=137371&action=edit
Possible fix
Might be caused by the recent PLL changes. Does the attached patch helps?
Also please provide d
On Mon, May 26, 2014 at 11:00:41AM +0530, Vandana Kannan wrote:
> On May-23-2014 4:18 PM, Vandana Kannan wrote:
> > On May-22-2014 5:46 PM, Daniel Vetter wrote:
> >> On Thu, May 22, 2014 at 04:50:48PM +0530, Vandana Kannan wrote:
> >>> Added a property to enable user space to set aspect ratio.
> >>
--
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20140526/7646737a/attachment-0001.html>
/archives/dri-devel/attachments/20140526/5d50a899/attachment.html>
This is the next part of ipp improvement patches, this time made
by YoungJun Cho, I am posting them as he is on leave.
The patchset is based on drm-exynos/exynos-drm-next branch.
Regards
Andrzej
Andrzej Hajda (1):
drm/exynos: ipp: remove description of non-existing field
YoungJun Cho (8):
From: YoungJun Cho
list_for_each_entry() handles empty lists, so there is no
need to check whether the list is empty first.
Signed-off-by: YoungJun Cho
Acked-by: Seong-Woo Kim
Acked-by: Kyungmin Park
Tested-by: Andrzej Hajda
---
drivers/gpu/drm/exynos/exynos_drm_ipp.c | 61 +
From: YoungJun Cho
The ippdrv->cmd_list requires cmd_lock.
So renames cmd_lock to lock for context.
Signed-off-by: YoungJun Cho
Acked-by: Seong-Woo Kim
Acked-by: Kyungmin Park
Tested-by: Andrzej Hajda
---
drivers/gpu/drm/exynos/exynos_drm_ipp.c | 12 ++--
drivers/gpu/drm/exynos/exyn
From: YoungJun Cho
This patch removes duplicated setting.
Signed-off-by: YoungJun Cho
Acked-by: Seong-Woo Kim
Acked-by: Kyungmin Park
Tested-by: Andrzej Hajda
---
drivers/gpu/drm/exynos/exynos_drm_ipp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/exyn
From: YoungJun Cho
This patch adds ipp_remove_id() for idr resource free.
Signed-off-by: YoungJun Cho
Acked-by: Seong-Woo Kim
Acked-by: Kyungmin Park
Tested-by: Andrzej Hajda
---
drivers/gpu/drm/exynos/exynos_drm_ipp.c | 42 -
1 file changed, 31 insertions(+)
From: YoungJun Cho
The c_node->mem_list[] should be protected with
c_node->mem_lock.
Signed-off-by: YoungJun Cho
Acked-by: Seong-Woo Kim
Acked-by: Kyungmin Park
Tested-by: Andrzej Hajda
---
drivers/gpu/drm/exynos/exynos_drm_ipp.c | 86 ++---
1 file changed, 48 in
From: YoungJun Cho
This patch adds cmd_lock for cmd_list synchronization.
Signed-off-by: YoungJun Cho
Acked-by: Seong-Woo Kim
Acked-by: Kyungmin Park
Tested-by: Andrzej Hajda
---
drivers/gpu/drm/exynos/exynos_drm_ipp.c | 20 ++--
drivers/gpu/drm/exynos/exynos_drm_ipp.h | 2
From: YoungJun Cho
The attribute gem_objs in struct drm_exynos_ipp_buf_info was
changed to handles. So the comment needs to be updated also.
Signed-off-by: YoungJun Cho
Acked-by: Seong-Woo Kim
Acked-by: Kyungmin Park
Tested-by: Andrzej Hajda
---
drivers/gpu/drm/exynos/exynos_drm_ipp.h | 2 +
ipp_id field is removed from exynos_drm_ippdrv struct.
The patch removes its description as well.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/exynos/exynos_drm_ipp.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_ipp.h
b/drivers/gpu/drm/exynos/exynos_d
From: YoungJun Cho
The c_node->event_list should be protected with
c_node->event_lock.
Signed-off-by: YoungJun Cho
Acked-by: Seong-Woo Kim
Acked-by: Kyungmin Park
Tested-by: Andrzej Hajda
---
drivers/gpu/drm/exynos/exynos_drm_ipp.c | 25 ++---
1 file changed, 14 insertio
On Sun, May 25, 2014 at 07:16:43PM -0400, Rob Clark wrote:
> On Sun, May 25, 2014 at 6:10 PM, Daniel Vetter wrote:
> > On Sat, May 24, 2014 at 8:30 PM, Rob Clark wrote:
> >> @@ -8002,7 +8002,7 @@ bool intel_get_load_detect_pipe(struct drm_connector
> >> *connector,
> >> if (encoder->crtc
On Sat, May 24, 2014 at 02:30:13PM -0400, Rob Clark wrote:
> An object property is an id (idr) for a drm mode object. This
> will allow a property to be used set/get a framebuffer, CRTC, etc.
>
> Signed-off-by: Rob Clark
> ---
> drivers/gpu/drm/drm_crtc.c | 60
> ++
On Mon, May 26, 2014 at 10:29:47AM +0200, Daniel Vetter wrote:
> On Sat, May 24, 2014 at 02:30:13PM -0400, Rob Clark wrote:
> > + } else if (drm_property_type_is(property, DRM_MODE_PROP_OBJECT)) {
> > + /* a zero value for an object property translates to null: */
> > + if (va
On Sat, May 24, 2014 at 02:30:15PM -0400, Rob Clark wrote:
> Add a few more useful helpers to find mode objects.
>
> Signed-off-by: Rob Clark
There's a pile more in drivers for these. I like this, but imo we should
also convert drivers while at it. Also, docbook is missing. And since it's
a clea
On Sat, May 24, 2014 at 02:30:19PM -0400, Rob Clark wrote:
> We do actually want to permit FB's in atomic case, since FB will be
> looked up like any other object property value in a few code paths
> (like property value validation).
>
> So split out into an internal function without the WARN_ON()
https://bugzilla.kernel.org/show_bug.cgi?id=75401
--- Comment #14 from Pali Roh?r ---
Created attachment 137381
--> https://bugzilla.kernel.org/attachment.cgi?id=137381&action=edit
preffer current pci device
What about this patch? It will preffer to call ATRM method for current pci
device.
--
https://bugzilla.kernel.org/show_bug.cgi?id=75401
--- Comment #15 from Pali Roh?r ---
oups, it should be ACPI_HANDLE(&rdev->pdev->dev) and not
ACPI_HANDLE(&pdev->dev).
--
You are receiving this mail because:
You are watching the assignee of the bug.
Hi Daniel,
On 26 May 2014 13:11, Daniel Kurtz wrote:
> On Mon, May 26, 2014 at 2:59 PM, Rahul Sharma
> wrote:
>>
>> Hi Inki,
>>
>> Please review this patch.
[snip]
>> > +
>> > + ret = clk_prepare_enable(ctx->lcd_clk);
>
> Hi Rahul,
>
> Can you explain why exactly we are "clearing windows"
On Mon, May 26, 2014 at 10:37 AM, Daniel Vetter wrote:
> On Sat, May 24, 2014 at 02:30:15PM -0400, Rob Clark wrote:
>> Add a few more useful helpers to find mode objects.
>>
>> Signed-off-by: Rob Clark
>
> There's a pile more in drivers for these. I like this, but imo we should
> also convert dri
Hi YoungJun,
I am not famiilar with i80. Reading through this patch, it looks like
it works something like below for a page flip...
-> page_flip ioctl
exynos_drm_crtc_page_flip()
exynos_drm_crtc_mode_set_commit()
exynos_plane_mode_set()
exynos_drm_crtc_commit()
exynos_plane_commi
Am Freitag, den 23.05.2014, 18:58 -0700 schrieb St?phane Marchesin:
> The current code doesn't enable the EMC clock, without which the
> display cannot function, so let's enable this clock. We also need a
> bit of code to pick the right frequency for the EMC clock depending
> on the current video m
On Sat, May 24, 2014 at 02:30:20PM -0400, Rob Clark wrote:
> Break the mutable state of a plane out into a separate structure
> and use atomic properties mechanism to set plane attributes. This
> makes it easier to have some helpers for plane->set_property()
> and for checking for invalid params.
Am Montag, den 26.05.2014, 09:45 +0300 schrieb Terje Bergstr?m:
> On 23.05.2014 17:40, Alex Courbot wrote:
> > On 05/23/2014 06:59 PM, Lucas Stach wrote:
> > So after checking with more knowledgeable people, it turns out this is
> > the expected behavior on ARM and BAR regions should be mapped unc
t tegra_dc_remove(struct platform_device
> *pdev)
> > }
> >
> > clk_disable_unprepare(dc->clk);
> > + if (dc->emc_clk)
> > + clk_disable_unprepare(dc->emc_clk);
> >
> > return 0;
> > }
> > diff --git a/drivers/gpu/drm/tegra/drm.h b/drivers/gpu/drm/tegra/drm.h
> > index 6753598..30d91c0 100644
> > --- a/drivers/gpu/drm/tegra/drm.h
> > +++ b/drivers/gpu/drm/tegra/drm.h
> > @@ -101,6 +101,7 @@ struct tegra_dc {
> >
> > struct clk *clk;
> > struct reset_control *rst;
> > + struct clk *emc_clk;
> > void __iomem *regs;
> > int irq;
> >
>
> --
> Pengutronix e.K. | Lucas Stach |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
>
> ___
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
-- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20140526/8e89556e/attachment.html>
On Sat, May 24, 2014 at 02:30:21PM -0400, Rob Clark wrote:
> Break the mutable state of a crtc out into a separate structure
> and use atomic properties mechanism to set crtc attributes. This
> makes it easier to have some helpers for crtc->set_property()
> and for checking for invalid params. Th
On Sat, May 24, 2014 at 02:30:22PM -0400, Rob Clark wrote:
> All the call-sites save one need locking. By pushing it down and adding
> a lockless flag, we can use the new spiffy atomic ww_mutex crtc locking
> and simplify all the call-sites.
>
> Signed-off-by: Rob Clark
Yeah, makes sense. But I
Added a property to enable user space to set aspect ratio.
This patch contains declaration of the property and code to create the
property.
v2: Thierry's review comments.
- Made aspect ratio enum generic instead of HDMI/CEA specfic
- Removed usage of temporary aspect_ratio variable
t;regs = devm_ioremap_resource(&pdev->dev, regs);
> > > if (IS_ERR(dc->regs))
> > > @@ -1312,6 +1369,8 @@ static int tegra_dc_remove(struct
> platform_device *pdev)
> > > }
> > >
> > > clk_disable_unprepare(dc->clk);
> > > + if (dc->emc_clk)
> > > + clk_disable_unprepare(dc->emc_clk);
> > >
> > > return 0;
> > > }
> > > diff --git a/drivers/gpu/drm/tegra/drm.h b/drivers/gpu/drm/tegra/drm.h
> > > index 6753598..30d91c0 100644
> > > --- a/drivers/gpu/drm/tegra/drm.h
> > > +++ b/drivers/gpu/drm/tegra/drm.h
> > > @@ -101,6 +101,7 @@ struct tegra_dc {
> > >
> > > struct clk *clk;
> > > struct reset_control *rst;
> > > + struct clk *emc_clk;
> > > void __iomem *regs;
> > > int irq;
> > >
> >
> > --
> > Pengutronix e.K. | Lucas Stach |
> > Industrial Linux Solutions | http://www.pengutronix.de/ |
> >
> > ___
> > dri-devel mailing list
> > dri-devel at lists.freedesktop.org<mailto:dri-devel at
> > lists.freedesktop.org>
> > http://lists.freedesktop.org/mailman/listinfo/dri-devel
> >
>
-- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20140526/b63abaa3/attachment-0001.html>
In case user has specified an input for aspect ratio through the property,
then the user space value for PAR would take preference over the value from
CEA mode list.
v2: Thierry's review comments.
- Modified the comment "Populate..." as per review comments
Signed-off-by: Vandana Kannan
C
Create and attach the drm property to set aspect ratio. If there is no user
specified value, then PAR_NONE/Automatic option is set by default. User can
select aspect ratio 4:3 or 16:9. The aspect ratio selected by user would
come into effect with a mode set.
v2: Modifications made based on changes
Updated drm documentation to include description of aspect ratio property.
HTML table structure created by Sagar Kamble.
Signed-off-by: Vandana Kannan
Cc: Sagar Kamble
Cc: Daniel Vetter
Cc: Thierry Reding
---
Documentation/DocBook/drm.tmpl | 31 +++
1 file changed,
https://bugzilla.kernel.org/show_bug.cgi?id=76861
--- Comment #2 from Sven Dziadek ---
Created attachment 137401
--> https://bugzilla.kernel.org/attachment.cgi?id=137401&action=edit
dmesg output with patch applied
--
You are receiving this mail because:
You are watching the assignee of the bu
https://bugzilla.kernel.org/show_bug.cgi?id=76861
--- Comment #3 from Sven Dziadek ---
The patch did not change anything for me. The flickering lines are still
there..
Maybe the dmesg output will help?
Thanks
--
You are receiving this mail because:
You are watching the assignee of the bug.
t; + return NULL;
> +}
> +
> +void cmdmode_display_timings_release(struct cmdmode_display_timings *cmdts);
> +
> +#endif /* __LINUX_CMDDMODE_DISPLAY_TIMING_H */
> diff --git a/include/video/of_cmdmode.h b/include/video/of_cmdmode.h
> new file mode 100644
> index 000..fb7c6c7
> --- /dev/null
> +++ b/include/video/of_cmdmode.h
> @@ -0,0 +1,19 @@
> +/*
> + * Copyright 2014 YoungJun Cho
> + *
> + * cmdmode of-helpers
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */
> +
> +#ifndef __LINUX_OF_CMDMODE_H
> +#define __LINUX_OF_CMDMODE_H
> +
> +struct device_node;
> +struct cmdmode;
> +
> +int of_get_cmdmode(struct device_node *np, struct cmdmode *cm, int index);
> +
> +#endif /* __LINUX_OF_CMDMODE_H */
> diff --git a/include/video/of_cmdmode_display_timing.h
> b/include/video/of_cmdmode_display_timing.h
> new file mode 100644
> index 000..6be91ba
> --- /dev/null
> +++ b/include/video/of_cmdmode_display_timing.h
> @@ -0,0 +1,26 @@
> +/*
> + * Copyright 2014 YoungJun Cho
> + *
> + * cmdmode display timings of helpers
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */
> +
> +#ifndef __LINUX_OF_CMDMODE_DISPLAY_TIMING_H
> +#define __LINUX_OF_CMDMODE_DISPLAY_TIMING_H
> +
> +struct device_node;
> +struct cmdmode_display_timing;
> +struct cmdmode_display_timings;
> +
> +#define OF_USE_CMDMODE_NATIVE_MODE -1
> +
> +int of_get_cmdmode_display_timing(struct device_node *np, const char *name,
> + struct cmdmode_display_timing *cmdt);
> +struct cmdmode_display_timings*
> + of_get_cmdmode_display_timings(struct device_node *np);
> +int of_cmdmode_display_timings_exist(struct device_node *np);
> +
> +#endif /* __LINUX_OF_CMDMODE_DISPLAY_TIMING_H */
> --
> 1.7.9.5
>
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20140526/479b6a2b/attachment-0001.sig>
On Sat, May 24, 2014 at 02:30:09PM -0400, Rob Clark wrote:
> One more time, with feeling..
>
> Previous revision of series:
> http://lists.freedesktop.org/archives/dri-devel/2014-March/055806.html
>
> And if you prefer, in git form:
> http://cgit.freedesktop.org/~robclark/linux/log/?h=cold-fusion
On Mon, May 26, 2014 at 4:29 AM, Daniel Vetter wrote:
> On Sat, May 24, 2014 at 02:30:13PM -0400, Rob Clark wrote:
>> An object property is an id (idr) for a drm mode object. This
>> will allow a property to be used set/get a framebuffer, CRTC, etc.
>>
>> Signed-off-by: Rob Clark
>> ---
>> driv
On Mon, May 26, 2014 at 4:37 AM, Daniel Vetter wrote:
> On Sat, May 24, 2014 at 02:30:15PM -0400, Rob Clark wrote:
>> Add a few more useful helpers to find mode objects.
>>
>> Signed-off-by: Rob Clark
>
> There's a pile more in drivers for these. I like this, but imo we should
> also convert driv
On Mon, May 26, 2014 at 5:12 AM, Daniel Vetter wrote:
> On Sat, May 24, 2014 at 02:30:20PM -0400, Rob Clark wrote:
>> Break the mutable state of a plane out into a separate structure
>> and use atomic properties mechanism to set plane attributes. This
>> makes it easier to have some helpers for p
On Mon, May 26, 2014 at 5:31 AM, Daniel Vetter wrote:
>> +struct drm_crtc_state *
>> +drm_atomic_get_crtc_state(struct drm_crtc *crtc, struct drm_atomic_state *a)
>> +{
>> + struct drm_crtc_state *cstate;
>> + int ret;
>> +
>> + cstate = a->cstates[crtc->id];
>> +
>> + if (!cstate)
Hi Jean,
Thank you for the patch.
On Monday 26 May 2014 13:01:35 Jean Delvare wrote:
> The Renesas R-Car Display Unit driver is only useful on shmobile
> unless build testing. The LVDS output is useful on an even more
> reduced hardware set.
>
> Signed-off-by: Jean Delvare
> Cc: Laurent Pinchar
de
> > +
> > +/*
> > + * Single "mode" entry. This describes one set of signal timings a
> > display can + * have in one setting. This struct can later be converted
> > to struct cmdmode + * (see include/video/cmdmode.h).
> > + */
> > +struct cmdmode_display_timing {
> > + u32 pixelclock;
> > +
> > + u32 hactive;
> > + u32 vactive;
> > +
> > + u32 cs_setup;
> > + u32 wr_setup;
> > + u32 wr_active;
> > + u32 wr_hold;
> > +};
> > +
> > +/*
> > + * This describes all timing settings a display provides.
> > + * The native_mode is the default setting for this display.
> > + * Drivers that can handle multiple cmdmodes should work with this struct
> > + * and convert each entry to the desired end result.
> > + */
> > +struct cmdmode_display_timings {
> > + unsigned int num_timings;
> > + unsigned int native_mode;
> > +
> > + struct cmdmode_display_timing **timings;
> > +};
> > +
> > +/* get one entry from struct cmdmode_display_timings */
> > +static inline struct cmdmode_display_timing*
> > +cmdmode_display_timings_get(const struct cmdmode_display_timings *cmdts,
> > + unsigned int index)
> > +{
> > + if (cmdts->num_timings > index)
> > + return cmdts->timings[index];
> > + else
> > + return NULL;
> > +}
> > +
> > +void cmdmode_display_timings_release(struct cmdmode_display_timings
> > *cmdts); +
> > +#endif /* __LINUX_CMDDMODE_DISPLAY_TIMING_H */
> > diff --git a/include/video/of_cmdmode.h b/include/video/of_cmdmode.h
> > new file mode 100644
> > index 000..fb7c6c7
> > --- /dev/null
> > +++ b/include/video/of_cmdmode.h
> > @@ -0,0 +1,19 @@
> > +/*
> > + * Copyright 2014 YoungJun Cho
> > + *
> > + * cmdmode of-helpers
> > + *
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License version 2 as
> > + * published by the Free Software Foundation.
> > + */
> > +
> > +#ifndef __LINUX_OF_CMDMODE_H
> > +#define __LINUX_OF_CMDMODE_H
> > +
> > +struct device_node;
> > +struct cmdmode;
> > +
> > +int of_get_cmdmode(struct device_node *np, struct cmdmode *cm, int
> > index);
> > +
> > +#endif /* __LINUX_OF_CMDMODE_H */
> > diff --git a/include/video/of_cmdmode_display_timing.h
> > b/include/video/of_cmdmode_display_timing.h new file mode 100644
> > index 000..6be91ba
> > --- /dev/null
> > +++ b/include/video/of_cmdmode_display_timing.h
> > @@ -0,0 +1,26 @@
> > +/*
> > + * Copyright 2014 YoungJun Cho
> > + *
> > + * cmdmode display timings of helpers
> > + *
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License version 2 as
> > + * published by the Free Software Foundation.
> > + */
> > +
> > +#ifndef __LINUX_OF_CMDMODE_DISPLAY_TIMING_H
> > +#define __LINUX_OF_CMDMODE_DISPLAY_TIMING_H
> > +
> > +struct device_node;
> > +struct cmdmode_display_timing;
> > +struct cmdmode_display_timings;
> > +
> > +#define OF_USE_CMDMODE_NATIVE_MODE -1
> > +
> > +int of_get_cmdmode_display_timing(struct device_node *np, const char
> > *name, +struct cmdmode_display_timing
> > *cmdt);
> > +struct cmdmode_display_timings*
> > + of_get_cmdmode_display_timings(struct device_node *np);
> > +int of_cmdmode_display_timings_exist(struct device_node *np);
> > +
> > +#endif /* __LINUX_OF_CMDMODE_DISPLAY_TIMING_H */
-- next part --
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20140526/e9af7502/attachment-0001.sig>
From: Ville Syrj?l?
Another vblank series with the following features:
- Plug a race between drm_vblank_off() and marking the crtc inactive
- Don't send zeroed vblank evens to userspace at drm_vblank_off()
- Have the user visible vblank counter account the entire time
when the crtc was active,
From: Ville Syrj?l?
Signed-off-by: Ville Syrj?l?
---
drivers/gpu/drm/i915/intel_display.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index 3da73ef..da318a7 100644
--- a/drivers/gpu/drm/i915/in
From: Ville Syrj?l?
Make sure drm_vblank_get() never succeeds when called between
drm_vblank_off() and drm_vblank_on(). Borrow a trick from the
old drm_vblank_{pre,post}_modeset() functions and just bump
the refcount in drm_vblank_off() and drop it in drm_vblank_on().
Hopefully the use of inmode
From: Ville Syrj?l?
Clearing the timestamps causes us to send zeroed timestamps to userspace
if they get sent out in response to the drm_vblank_off(). It's better
to send the very latest timestamp and count instead.
Signed-off-by: Ville Syrj?l?
---
drivers/gpu/drm/drm_irq.c | 11 ---
1
From: Ville Syrj?l?
If the vblank irq has already been disabled (via the disable timer) when
we call drm_vblank_off() sample the counter and timestamp one last time.
This will make the sure that the user space visible counter will account
for time between vblank irq disable and drm_vblank_off().
From: Ville Syrj?l?
When drm_vblank_on() is called the hardware vblank counter may have
been reset, so we can't trust that the old values sampled prior to
drm_vblank_off() have anything to do with the new values.
So update the .last count in drm_vblank_on() to make the first
drm_vblank_enable()
From: Ville Syrj?l?
Declare a local struct drm_vblank_crtc * and use that
instead of having to do dig it out via 'dev->vblank[crtc]'
everywhere.
Performed with the following coccinelle incantation,
and a few manual whitespace cleanups:
@@
identifier func,member;
expression num_crtcs;
struct drm
From: Ville Syrj?l?
Move drm_update_vblank_count() to avoid forward a declaration.
No functional change.
Signed-off-by: Ville Syrj?l?
---
drivers/gpu/drm/drm_irq.c | 128 +++---
1 file changed, 64 insertions(+), 64 deletions(-)
diff --git a/drivers/gpu/
From: Ville Syrj?l?
The new watermaek update mechanism requires interrupts to work
correctly. Because of this we need interrupts while disabling crtcs
during suspend. So move the irq disable to happen a bit later.
This also avoid clobbering the vblank.last count in case the
vblank interrupt was
From: Ville Syrj?l?
Make drm_vblank_put() disable the vblank interrupt immediately when the
refcount drops to zero and drm_vblank_offdelay==0.
Currently drm_vblank_put() would just leave vblank interrupts enabled all
the time if drm_vblank_offdelay==0. In case someone might still want that
behav
after I post this comment.
--
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20140526/fe6d7813/attachment.html>
the bug.
-- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20140526/585222bb/attachment.html>
the bug.
-- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20140526/dff484b5/attachment-0001.html>
the bug.
-- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20140526/9a96736d/attachment.html>
On Mon, May 26, 2014 at 4:23 AM, Daniel Vetter wrote:
> On Sun, May 25, 2014 at 07:16:43PM -0400, Rob Clark wrote:
>> On Sun, May 25, 2014 at 6:10 PM, Daniel Vetter wrote:
>> > On Sat, May 24, 2014 at 8:30 PM, Rob Clark wrote:
>> >> @@ -8002,7 +8002,7 @@ bool intel_get_load_detect_pipe(struct
>
https://bugzilla.kernel.org/show_bug.cgi?id=76861
--- Comment #4 from Christian K?nig ---
(In reply to Sven Dziadek from comment #3)
> Maybe the dmesg output will help?
The logs show that your system indeed seems to be affected by the patch. Can
you try even lower values than 114 and see if it c
On Mon, May 26, 2014 at 6:40 AM, Daniel Vetter wrote:
> On Sat, May 24, 2014 at 02:30:09PM -0400, Rob Clark wrote:
>> One more time, with feeling..
>>
>> Previous revision of series:
>> http://lists.freedesktop.org/archives/dri-devel/2014-March/055806.html
>>
>> And if you prefer, in git form:
>>
Hi Jean,
On Monday 26 May 2014 14:21:30 Jean Delvare wrote:
> On Mon, 26 May 2014 13:36:11 +0200, Laurent Pinchart wrote:
> > On Monday 26 May 2014 13:01:35 Jean Delvare wrote:
> > > The Renesas R-Car Display Unit driver is only useful on shmobile
> > > unless build testing. The LVDS output is use
On Mon, May 26, 2014 at 02:46:30PM +0300, ville.syrjala at linux.intel.com
wrote:
> From: Ville Syrj?l?
>
> Make drm_vblank_put() disable the vblank interrupt immediately when the
> refcount drops to zero and drm_vblank_offdelay==0.
>
> Currently drm_vblank_put() would just leave vblank interru
On Mon, May 26, 2014 at 02:46:24PM +0300, ville.syrjala at linux.intel.com
wrote:
> From: Ville Syrj?l?
>
> Make sure drm_vblank_get() never succeeds when called between
> drm_vblank_off() and drm_vblank_on(). Borrow a trick from the
> old drm_vblank_{pre,post}_modeset() functions and just bump
On Mon, May 26, 2014 at 02:46:25PM +0300, ville.syrjala at linux.intel.com
wrote:
> From: Ville Syrj?l?
>
> Signed-off-by: Ville Syrj?l?
> ---
> drivers/gpu/drm/i915/intel_display.c | 15 +++
> 1 file changed, 15 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c
On Mon, May 26, 2014 at 02:46:26PM +0300, ville.syrjala at linux.intel.com
wrote:
> From: Ville Syrj?l?
>
> Clearing the timestamps causes us to send zeroed timestamps to userspace
> if they get sent out in response to the drm_vblank_off(). It's better
> to send the very latest timestamp and cou
On Mon, May 26, 2014 at 02:46:28PM +0300, ville.syrjala at linux.intel.com
wrote:
> From: Ville Syrj?l?
>
> If the vblank irq has already been disabled (via the disable timer) when
> we call drm_vblank_off() sample the counter and timestamp one last time.
> This will make the sure that the user
Hi Jean,
Thank you for the patch.
On Monday 26 May 2014 14:52:13 Jean Delvare wrote:
> The shmobile DRM driver is only useful on SuperH and shmobile unless
> build testing. I am dropping the SuperH dependencies though because
> the driver doesn't even build there, so in practice it is an arm-only
On Mon, May 26, 2014 at 02:46:29PM +0300, ville.syrjala at linux.intel.com
wrote:
> From: Ville Syrj?l?
>
> When drm_vblank_on() is called the hardware vblank counter may have
> been reset, so we can't trust that the old values sampled prior to
> drm_vblank_off() have anything to do with the new
On Mon, May 26, 2014 at 02:46:31PM +0300, ville.syrjala at linux.intel.com
wrote:
> From: Ville Syrj?l?
>
> Declare a local struct drm_vblank_crtc * and use that
> instead of having to do dig it out via 'dev->vblank[crtc]'
> everywhere.
>
> Performed with the following coccinelle incantation,
>
On Mon, May 26, 2014 at 03:21:41PM +0200, Daniel Vetter wrote:
> On Mon, May 26, 2014 at 02:46:24PM +0300, ville.syrjala at linux.intel.com
> wrote:
> > From: Ville Syrj?l?
> >
> > Make sure drm_vblank_get() never succeeds when called between
> > drm_vblank_off() and drm_vblank_on(). Borrow a tr
As requested by David [1],[2].
These are on top of drm-intel-nightly which carries the required core
patches adding ->name field to drm_connector and drm_encoder. The i915
patches could go in right away, the last patch need to wait for radeon
and nouveau patches to get merged, obviously.
BR,
Jani
Generated using semantic patch:
@@
expression E;
@@
- drm_get_connector_name(E)
+ E->name
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/i915_debugfs.c | 4 ++--
drivers/gpu/drm/i915/i915_irq.c | 8
drivers/gpu/drm/i915/intel_crt.c | 2 +-
drivers/gpu/drm/i915/intel_
Generated using semantic patch:
@@
expression E;
@@
- drm_get_connector_name(E)
+ E->name
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/radeon/radeon_connectors.c | 19 ---
drivers/gpu/drm/radeon/radeon_display.c| 2 +-
2 files changed, 13 insertions(+), 8 deletions(-)
d
Generated using semantic patch:
@@
expression E;
@@
- drm_get_connector_name(E)
+ E->name
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_crtc.c | 4 ++--
drivers/gpu/drm/drm_crtc_helper.c | 6 +++---
drivers/gpu/drm/drm_edid.c | 6 +++---
drivers/gpu/drm/drm_edid_load.c
Generated using semantic patch:
@@
expression E;
@@
- drm_get_encoder_name(E)
+ E->name
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/i915_debugfs.c | 2 +-
drivers/gpu/drm/i915/intel_display.c | 14 +++---
drivers/gpu/drm/i915/intel_dp.c | 2 +-
3 files changed, 9 insert
Generated using semantic patch:
@@
expression E;
@@
- drm_get_encoder_name(E)
+ E->name
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_crtc.c| 2 +-
drivers/gpu/drm/drm_crtc_helper.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_crtc.c b
Generated using semantic patch:
@@
expression E;
@@
- drm_get_connector_name(E)
+ E->name
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/nouveau/dispnv04/dac.c | 2 +-
drivers/gpu/drm/nouveau/dispnv04/dfp.c | 2 +-
drivers/gpu/drm/nouveau/dispnv04/disp.c | 2 +-
drivers/gpu/drm/n
No longer used or needed as the structs have a name field.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_crtc.c | 20
include/drm/drm_crtc.h | 2 --
2 files changed, 22 deletions(-)
diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
index d986b3f
On Mon, May 26, 2014 at 03:22:45PM +0200, Daniel Vetter wrote:
> On Mon, May 26, 2014 at 02:46:25PM +0300, ville.syrjala at linux.intel.com
> wrote:
> > From: Ville Syrj?l?
> >
> > Signed-off-by: Ville Syrj?l?
> > ---
> > drivers/gpu/drm/i915/intel_display.c | 15 +++
> > 1 file ch
next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20140526/600e460a/attachment-0001.sig>
https://bugzilla.kernel.org/show_bug.cgi?id=76861
--- Comment #5 from Sven Dziadek ---
Created attachment 137421
--> https://bugzilla.kernel.org/attachment.cgi?id=137421&action=edit
patched with value 107
Value 107 works for me. I am currently testing which is the highest value
working for me.
https://bugzilla.kernel.org/show_bug.cgi?id=76861
--- Comment #6 from Sven Dziadek ---
Created attachment 137431
--> https://bugzilla.kernel.org/attachment.cgi?id=137431&action=edit
dmesg output for (still working) Kernel 3.15-rc1
--
You are receiving this mail because:
You are watching the a
On Mon, May 26, 2014 at 04:32:02PM +0300, Ville Syrj?l? wrote:
> On Mon, May 26, 2014 at 03:21:41PM +0200, Daniel Vetter wrote:
> > On Mon, May 26, 2014 at 02:46:24PM +0300, ville.syrjala at linux.intel.com
> > wrote:
> > > From: Ville Syrj?l?
> > >
> > > Make sure drm_vblank_get() never succeed
On Mon, May 26, 2014 at 04:36:26PM +0300, Ville Syrj?l? wrote:
> On Mon, May 26, 2014 at 03:22:45PM +0200, Daniel Vetter wrote:
> > On Mon, May 26, 2014 at 02:46:25PM +0300, ville.syrjala at linux.intel.com
> > wrote:
> > > From: Ville Syrj?l?
> > >
> > > Signed-off-by: Ville Syrj?l?
> > > ---
From: Ville Syrj?l?
v2: Drop the drm_vblank_off() (Daniel)
Use drm_crtc_vblank_{get,put}()
Signed-off-by: Ville Syrj?l?
---
drivers/gpu/drm/i915/intel_display.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/inte
On Mon, May 26, 2014 at 04:35:39PM +0300, Jani Nikula wrote:
> As requested by David [1],[2].
>
> These are on top of drm-intel-nightly which carries the required core
> patches adding ->name field to drm_connector and drm_encoder. The i915
> patches could go in right away, the last patch need to w
On Mon, May 26, 2014 at 3:52 PM, Daniel Vetter wrote:
> On Mon, May 26, 2014 at 04:35:39PM +0300, Jani Nikula wrote:
>> As requested by David [1],[2].
>>
>> These are on top of drm-intel-nightly which carries the required core
>> patches adding ->name field to drm_connector and drm_encoder. The i9
1 - 100 of 163 matches
Mail list logo
