Re: [PATCH] drm: refactor call to request_module

2013-05-08 Thread Paul Menzel
Am Dienstag, den 07.05.2013, 12:32 -0700 schrieb Kees Cook: > This reduces the size of the stack frame when calling request_module(). > Performing the sprintf before the call is not needed. Good fine. Do you have any hard numbers for the record? Did you find this just by reading the code or are t

Re: [PATCH] radeon: Allow disabling UVD

2013-05-08 Thread Christian König
Am 07.05.2013 23:13, schrieb Parag Warudkar: On Tue, May 7, 2013 at 4:44 AM, Christian König wrote: The patch shouldn't be necessary because just removing the firmware should have pretty much the same effect. Soon distros will ship the UVD firmware by default and then users will need to manua

[PATCH 0/7] drm/i915: fbdev mode restoration improvements

2013-05-08 Thread ville . syrjala
This series attempts to make sure we turn off any cursor and sprite planes when we restore the fbdev mode. Some of this stuff depends on the other series I just posted: '[PATCH 0/6] drm/i915: Unfify some modeset sequences' I also noticed some crap when looking at the code, so I slapped on a few c

[PATCH 2/7] drm/i915: Don't enable cursors or sprites for fbdev

2013-05-08 Thread ville . syrjala
From: Ville Syrjälä Check if the CRTC framebuffer matches the fbdev helper's framebuffer, and if it does, doen't enable cursors/sprites. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/gpu/drm/i9

[PATCH 3/7] drm/i915: Fix fbdev sprite disable code

2013-05-08 Thread ville . syrjala
From: Ville Syrjälä plane->enabled is never set, so this code didn't do anything. If we end up doing a full modeset, sprites already get disabled. However if we end up doing a simple set_base, we still need to turn off the sprites manually. And do the same for cursors, since we only want to see

[PATCH 1/7] drm: Add fb_helper->restore_fbdev_mode hook

2013-05-08 Thread ville . syrjala
From: Ville Syrjälä Drivers may need to turn off overlay planes, cursors, etc. when restoring the fbdev mode. So allow drivers to provide their own version of drm_fb_helper_restore_fbdev_mode() that can take care of such details. Initially just plug in drm_fb_helper_restore_fbdev_mode for all dr

[PATCH 4/7] drm/i915: Use a custom restore_fbdev_mode hook

2013-05-08 Thread ville . syrjala
From: Ville Syrjälä Disable sprite planes and cursors when restoring the fbdev mode. This is actually only needed in case the modeset gets optimized into a set_base, but that's a fairly important case these days. Should makes oopses more readable if they're not covered by spriteas and cursors.

[PATCH 5/7] drm/i915: Use container_of() in the fbdev code

2013-05-08 Thread ville . syrjala
From: Ville Syrjälä Use container_of() instead of a cast to get struct intel_fbdev from struct drm_fb_helper. Also populate the fb_info->par correctly with the drm_fb_helper pointer instead of the intel_fbdev pointer. There's no actual functional change since the drm_fb_helper happens to be the

[PATCH 6/7] drm/i915: s/drm_i915_private_t/struct drm_i915_private/

2013-05-08 Thread ville . syrjala
From: Ville Syrjälä People don't like typedefs these days. Eliminate their use from intel_fb.c. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_fb.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_fb.c b/drivers/gpu/drm/i9

[PATCH 7/7] drm: Remove some unused stuff from drm_plane

2013-05-08 Thread ville . syrjala
From: Ville Syrjälä There's a bunch of unused members inside drm_plane, bloating the size of the structure needlessly. Eliminate them. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_crtc.c | 2 +- include/drm/drm_crtc.h | 10 -- 2 files changed, 1 insertion(+), 11 deletions(

Re: [PULL] drm-intel-fixes

2013-05-08 Thread Daniel Vetter
On Sat, May 04, 2013 at 08:11:25PM +0200, Daniel Vetter wrote: > Hi Dave, > > A few intel fixes for smaller issues and one revert for an sdv hack which > we've wanted to kill anyway. Plus two drm patches included for your > convenience, both regression fixers for mine own screw-ups. I've smashed

Re: DMA mapping API abuse in exynos-drm

2013-05-08 Thread Marek Szyprowski
Hello, On 5/6/2013 7:59 AM, Inki Dae wrote: 2013/5/5 Tomasz Figa > Hi, Recently I've been working a bit on a DRM driver for the GPU of Samsung S3C6410 SoCs, which required me to familiarize a bit with exynos-drm, as it already contains a KM

Re: [PATCH 7/7] drm: Remove some unused stuff from drm_plane

2013-05-08 Thread Laurent Pinchart
Hi Ville, Thank you for the patch. On Wednesday 08 May 2013 12:55:22 ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > There's a bunch of unused members inside drm_plane, bloating the size of > the structure needlessly. Eliminate them. > > Signed-off-by: Ville Syrjälä > --- > dr

Re: [PATCH 1/7] drm: Add fb_helper->restore_fbdev_mode hook

2013-05-08 Thread Laurent Pinchart
Hi Ville, Thank you for the patch. On Wednesday 08 May 2013 12:55:16 ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Drivers may need to turn off overlay planes, cursors, etc. when > restoring the fbdev mode. So allow drivers to provide their own > version of drm_fb_helper_restor

[PATCH 0/3] drm: kernel-doc fixes

2013-05-08 Thread ville . syrjala
Just a few misc. kernel-doc fixes I spotted while looking into the subject matter. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 1/3] drm: Add kernel-doc for drm_fb_helper_funcs->initial_config

2013-05-08 Thread ville . syrjala
From: Ville Syrjälä Signed-off-by: Ville Syrjälä --- include/drm/drm_fb_helper.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h index 8230b46..61ebd51 100644 --- a/include/drm/drm_fb_helper.h +++ b/include/drm/drm_fb_helper.h @@ -57

[PATCH 2/3] drm: Remove pointless '-' characters from drm_fb_helper documentation

2013-05-08 Thread ville . syrjala
From: Ville Syrjälä Signed-off-by: Ville Syrjälä --- include/drm/drm_fb_helper.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h index 61ebd51..471f276 100644 --- a/include/drm/drm_fb_helper.h +++ b/i

[PATCH 3/3] drm: Fix drm_rect documentation

2013-05-08 Thread ville . syrjala
From: Ville Syrjälä The 'struct' keyword was missing so struct drm_rect documentation never ended up in the generated docs. Also reorder drm_rect.h to become before drm_rect.c so that the struct documentation appears first in the docs. And change it to use the 'I' directive instead of 'F' while

[PATCH v2] drm: Add fb_helper->restore_fbdev_mode hook

2013-05-08 Thread ville . syrjala
From: Ville Syrjälä Drivers may need to turn off overlay planes, cursors, etc. when restoring the fbdev mode. So allow drivers to provide their own version of drm_fb_helper_restore_fbdev_mode() that can take care of such details. Initially just plug in drm_fb_helper_restore_fbdev_mode for all dr

[PATCH v2] drm: Remove some unused stuff from drm_plane

2013-05-08 Thread ville . syrjala
From: Ville Syrjälä There's a bunch of unused members inside drm_plane, bloating the size of the structure needlessly. Eliminate them. v2: Remove all of it from kernel-doc too Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_crtc.c | 2 +- include/drm/drm_crtc.h | 11 --- 2 f

Re: [PATCH v2] drm: Add fb_helper->restore_fbdev_mode hook

2013-05-08 Thread Ville Syrjälä
On Wed, May 08, 2013 at 04:39:58PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Drivers may need to turn off overlay planes, cursors, etc. when > restoring the fbdev mode. So allow drivers to provide their own > version of drm_fb_helper_restore_fbdev_mode() that can take

Re: [PATCH v2] drm: Remove some unused stuff from drm_plane

2013-05-08 Thread Laurent Pinchart
On Wednesday 08 May 2013 16:40:54 ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > There's a bunch of unused members inside drm_plane, bloating the size of > the structure needlessly. Eliminate them. > > v2: Remove all of it from kernel-doc too > > Signed-off-by: Ville Syrjälä R

Re: [PATCH v2] drm: Add fb_helper->restore_fbdev_mode hook

2013-05-08 Thread Laurent Pinchart
On Wednesday 08 May 2013 16:39:58 ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Drivers may need to turn off overlay planes, cursors, etc. when > restoring the fbdev mode. So allow drivers to provide their own > version of drm_fb_helper_restore_fbdev_mode() that can take care > o

Re: [Intel-gfx] [PATCH 3/3] drm: Fix drm_rect documentation

2013-05-08 Thread Daniel Vetter
On Wed, May 08, 2013 at 04:38:35PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > The 'struct' keyword was missing so struct drm_rect documentation never > ended up in the generated docs. > > Also reorder drm_rect.h to become before drm_rect.c so that the struct > document

[PATCH v2] drm: Fix drm_rect documentation

2013-05-08 Thread ville . syrjala
From: Ville Syrjälä The 'struct' keyword was missing so struct drm_rect documentation never ended up in the generated docs. Also move the drm_rect documentations to a new section alognside the various helper functions and add a short description about the intended purpose of drm_rect. v2: Move

Re: [PATCH v2] drm: Fix drm_rect documentation

2013-05-08 Thread Daniel Vetter
On Wed, May 08, 2013 at 05:16:45PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > The 'struct' keyword was missing so struct drm_rect documentation never > ended up in the generated docs. > > Also move the drm_rect documentations to a new section alognside the > various he

Some lost drm patches

2013-05-08 Thread Damien Lespiau
I just collected a few sad patches crying in the dark alley of the Internet that dri-devel can sometimes be. A few of them even have a r-b tag by benevolent and fatherly figures. All they want is to find a new home! -- Damien ___ dri-devel mailing list

[PATCH 1/5] drm: Add missing break in the command line mode parsing code

2013-05-08 Thread Damien Lespiau
As we parse the string given on the command line one char at a time, it seems that we do want a break at every case. Signed-off-by: Damien Lespiau Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/drm_modes.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/

[PATCH 2/5] drm: Make the HPD status updates debug logs more readable

2013-05-08 Thread Damien Lespiau
Instead of just printing "status updated from 1 to 2", make those enum numbers immediately readable. v2: Also patch output_poll_execute() (Daniel Vetter) Signed-off-by: Damien Lespiau Reviewed-by: Jesse Barnes --- drivers/gpu/drm/drm_crtc_helper.c | 22 ++ 1 file changed, 1

[PATCH 3/5] drm: Don't prune modes loudly when a connector is disconnected

2013-05-08 Thread Damien Lespiau
drm_helper_probe_single_connector_modes() is responsible for pruning the previously detected modes on a disconnected connector. We don't really need to log, again, the full list of modes that used to be valid when connected. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_crtc_helper.c | 4

[PATCH 4/5] drm: Fix a typo in the struct drm_plane_funcs documentation

2013-05-08 Thread Damien Lespiau
From: "Lespiau, Damien" Signed-off-by: Damien Lespiau --- include/drm/drm_crtc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index e3e0d65..23fb185 100644 --- a/include/drm/drm_crtc.h +++ b/include/drm/drm_crtc.h @@ -660,7

[PATCH 5/5] drm: Use names of ioctls in debug traces

2013-05-08 Thread Damien Lespiau
From: Chris Cummins The intention here is to make the output of dmesg with full verbosity a bit easier for a human to parse. This commit transforms: [drm:drm_ioctl], pid=699, cmd=0x6458, nr=0x58, dev 0xe200, auth=1 [drm:drm_ioctl], pid=699, cmd=0xc010645b, nr=0x5b, dev 0xe200, auth=1 [drm:drm_io

Re: [PATCH 2/5] drm: Make the HPD status updates debug logs more readable

2013-05-08 Thread Chris Wilson
On Wed, May 08, 2013 at 05:03:31PM +0100, Damien Lespiau wrote: > > Instead of just printing "status updated from 1 to 2", make those enum > numbers immediately readable. > > v2: Also patch output_poll_execute() (Daniel Vetter) For bonus points, only emit the message when it is updated. -Chris

Re: [PATCH 2/5] drm: Make the HPD status updates debug logs more readable

2013-05-08 Thread Ville Syrjälä
On Wed, May 08, 2013 at 05:03:31PM +0100, Damien Lespiau wrote: > Instead of just printing "status updated from 1 to 2", make those enum > numbers immediately readable. > > v2: Also patch output_poll_execute() (Daniel Vetter) > > Signed-off-by: Damien Lespiau > Reviewed-by: Jesse Barnes > --- >

Re: [Intel-gfx] [PATCH 4/5] drm: Fix a typo in the struct drm_plane_funcs documentation

2013-05-08 Thread Ville Syrjälä
On Wed, May 08, 2013 at 05:03:33PM +0100, Damien Lespiau wrote: > From: "Lespiau, Damien" > > Signed-off-by: Damien Lespiau > --- > include/drm/drm_crtc.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h > index e3e0d65..2

Re: [Intel-gfx] [PATCH 5/5] drm: Use names of ioctls in debug traces

2013-05-08 Thread Ville Syrjälä
On Wed, May 08, 2013 at 05:03:34PM +0100, Damien Lespiau wrote: > From: Chris Cummins > > The intention here is to make the output of dmesg with full verbosity a > bit easier for a human to parse. This commit transforms: > > [drm:drm_ioctl], pid=699, cmd=0x6458, nr=0x58, dev 0xe200, auth=1 > [dr

Re: [PATCH] drm/radeon: fix UPLL_REF_DIV_MASK definition

2013-05-08 Thread Paul Menzel
Dear Christian, Am Montag, den 29.04.2013, 10:20 +0200 schrieb Christian König: > From: Christian König > > Stupid copy & paste error over all generations. does this fix an error or was this found just by reading the code? Could please you add such information to commit message in the future?

Re: [PATCH] drm: refactor call to request_module

2013-05-08 Thread Kees Cook
On Wed, May 8, 2013 at 12:22 AM, Paul Menzel wrote: > Am Dienstag, den 07.05.2013, 12:32 -0700 schrieb Kees Cook: >> This reduces the size of the stack frame when calling request_module(). >> Performing the sprintf before the call is not needed. > > Good fine. Do you have any hard numbers for the

[Bug 63935] TURKS [drm:r600_uvd_init] *ERROR* UVD not responding, trying to reset the VCPU!!!

2013-05-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=63935 --- Comment #8 from Benjamin Lee --- I booted in Apple's BIOS emulation mode and found that UVD initializes successfully, so the problem is limited to EFI booting (like the former video BIOS issue). Is there any debugging output I can provide th

Re: [Intel-gfx] [PATCH 5/5] drm: Use names of ioctls in debug traces

2013-05-08 Thread Ben Widawsky
On Wed, May 08, 2013 at 07:55:18PM +0300, Ville Syrjälä wrote: > On Wed, May 08, 2013 at 05:03:34PM +0100, Damien Lespiau wrote: > > From: Chris Cummins > > > > The intention here is to make the output of dmesg with full verbosity a > > bit easier for a human to parse. This commit transforms: > >

[Bug 57831] New: radeon fatal error during GPU init (Radeon 5850, KVM GPU passthrough)

2013-05-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=57831 Summary: radeon fatal error during GPU init (Radeon 5850, KVM GPU passthrough) Product: Drivers Version: 2.5 Kernel Version: 3.9.0 Platform: All OS/Version: Linux

[PATCH] qxl: fix bug with object eviction and update area

2013-05-08 Thread Dave Airlie
From: Dave Airlie if the surface is evicted, this validation will happen to the wrong place, I noticed this with other work I was doing, haven't seen it go wrong in practice. Signed-off-by: Dave Airlie --- drivers/gpu/drm/qxl/qxl_ioctl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/driv

[Bug 64376] New: radeon fatal error during GPU init (Radeon 5850, KVM GPU passthrough)

2013-05-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64376 Priority: medium Bug ID: 64376 Assignee: dri-devel@lists.freedesktop.org Summary: radeon fatal error during GPU init (Radeon 5850, KVM GPU passthrough) Severity: normal C

Re: [PATCH] radeon: Allow disabling UVD

2013-05-08 Thread Parag Warudkar
On Wed, 8 May 2013, Christian König wrote: > Am 07.05.2013 23:13, schrieb Parag Warudkar: > > On Tue, May 7, 2013 at 4:44 AM, Christian König > > wrote: > > Without SUMO_uvd.bin - suspends fine and only wakes up when I want it to. > > Hui? Wait a second, the firmware doesn't work but still cau

linux-next: manual merge of the drm-intel tree with Linus' tree

2013-05-08 Thread Stephen Rothwell
-- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: not available URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20130508/41b5b541/attachment.pgp>

[Bug 64201] OpenCL usage result segmentation fault on r600g with HD6850.

2013-05-08 Thread bugzilla-dae...@freedesktop.org
was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20130508/fcaa2e86/attachment.html>

[PATCH] drm: refactor call to request_module

2013-05-08 Thread Paul Menzel
ed-by: Paul Menzel Thanks, Paul -- next part -- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 198 bytes Desc: This is a digitally signed message part URL: <http://lists.freedesktop.org/archives/dri-devel/attachme

[PATCH] radeon: Allow disabling UVD

2013-05-08 Thread Christian König
Am 07.05.2013 23:13, schrieb Parag Warudkar: > On Tue, May 7, 2013 at 4:44 AM, Christian K?nig > wrote: > >> The patch shouldn't be necessary because just removing the firmware should >> have pretty much the same effect. > Soon distros will ship the UVD firmware by default and then users will > n

[PATCH 0/7] drm/i915: fbdev mode restoration improvements

2013-05-08 Thread ville.syrj...@linux.intel.com
This series attempts to make sure we turn off any cursor and sprite planes when we restore the fbdev mode. Some of this stuff depends on the other series I just posted: '[PATCH 0/6] drm/i915: Unfify some modeset sequences' I also noticed some crap when looking at the code, so I slapped on a few c

[PATCH 2/7] drm/i915: Don't enable cursors or sprites for fbdev

2013-05-08 Thread ville.syrj...@linux.intel.com
From: Ville Syrj?l? Check if the CRTC framebuffer matches the fbdev helper's framebuffer, and if it does, doen't enable cursors/sprites. Signed-off-by: Ville Syrj?l? --- drivers/gpu/drm/i915/intel_display.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/gpu/drm/i9

[PATCH 3/7] drm/i915: Fix fbdev sprite disable code

2013-05-08 Thread ville.syrj...@linux.intel.com
From: Ville Syrj?l? plane->enabled is never set, so this code didn't do anything. If we end up doing a full modeset, sprites already get disabled. However if we end up doing a simple set_base, we still need to turn off the sprites manually. And do the same for cursors, since we only want to see

[PATCH 1/7] drm: Add fb_helper->restore_fbdev_mode hook

2013-05-08 Thread ville.syrj...@linux.intel.com
From: Ville Syrj?l? Drivers may need to turn off overlay planes, cursors, etc. when restoring the fbdev mode. So allow drivers to provide their own version of drm_fb_helper_restore_fbdev_mode() that can take care of such details. Initially just plug in drm_fb_helper_restore_fbdev_mode for all dr

[PATCH 4/7] drm/i915: Use a custom restore_fbdev_mode hook

2013-05-08 Thread ville.syrj...@linux.intel.com
From: Ville Syrj?l? Disable sprite planes and cursors when restoring the fbdev mode. This is actually only needed in case the modeset gets optimized into a set_base, but that's a fairly important case these days. Should makes oopses more readable if they're not covered by spriteas and cursors.

[PATCH 5/7] drm/i915: Use container_of() in the fbdev code

2013-05-08 Thread ville.syrj...@linux.intel.com
From: Ville Syrj?l? Use container_of() instead of a cast to get struct intel_fbdev from struct drm_fb_helper. Also populate the fb_info->par correctly with the drm_fb_helper pointer instead of the intel_fbdev pointer. There's no actual functional change since the drm_fb_helper happens to be the

[PATCH 6/7] drm/i915: s/drm_i915_private_t/struct drm_i915_private/

2013-05-08 Thread ville.syrj...@linux.intel.com
From: Ville Syrj?l? People don't like typedefs these days. Eliminate their use from intel_fb.c. Signed-off-by: Ville Syrj?l? --- drivers/gpu/drm/i915/intel_fb.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_fb.c b/drivers/gpu/drm/i9

[PATCH 7/7] drm: Remove some unused stuff from drm_plane

2013-05-08 Thread ville.syrj...@linux.intel.com
From: Ville Syrj?l? There's a bunch of unused members inside drm_plane, bloating the size of the structure needlessly. Eliminate them. Signed-off-by: Ville Syrj?l? --- drivers/gpu/drm/drm_crtc.c | 2 +- include/drm/drm_crtc.h | 10 -- 2 files changed, 1 insertion(+), 11 deletions(

[PULL] drm-intel-fixes

2013-05-08 Thread Daniel Vetter
On Sat, May 04, 2013 at 08:11:25PM +0200, Daniel Vetter wrote: > Hi Dave, > > A few intel fixes for smaller issues and one revert for an sdv hack which > we've wanted to kill anyway. Plus two drm patches included for your > convenience, both regression fixers for mine own screw-ups. I've smashed

DMA mapping API abuse in exynos-drm

2013-05-08 Thread Marek Szyprowski
Hello, On 5/6/2013 7:59 AM, Inki Dae wrote: > 2013/5/5 Tomasz Figa > > > Hi, > > Recently I've been working a bit on a DRM driver for the GPU of > Samsung > S3C6410 SoCs, which required me to familiarize a bit with > exynos-drm, as > it alr

[PATCH 7/7] drm: Remove some unused stuff from drm_plane

2013-05-08 Thread Laurent Pinchart
Hi Ville, Thank you for the patch. On Wednesday 08 May 2013 12:55:22 ville.syrjala at linux.intel.com wrote: > From: Ville Syrj?l? > > There's a bunch of unused members inside drm_plane, bloating the size of > the structure needlessly. Eliminate them. > > Signed-off-by: Ville Syrj?l? > --- >

[PATCH 1/7] drm: Add fb_helper->restore_fbdev_mode hook

2013-05-08 Thread Laurent Pinchart
Hi Ville, Thank you for the patch. On Wednesday 08 May 2013 12:55:16 ville.syrjala at linux.intel.com wrote: > From: Ville Syrj?l? > > Drivers may need to turn off overlay planes, cursors, etc. when > restoring the fbdev mode. So allow drivers to provide their own > version of drm_fb_helper_res

[PATCH 0/3] drm: kernel-doc fixes

2013-05-08 Thread ville.syrj...@linux.intel.com
Just a few misc. kernel-doc fixes I spotted while looking into the subject matter.

[PATCH 1/3] drm: Add kernel-doc for drm_fb_helper_funcs->initial_config

2013-05-08 Thread ville.syrj...@linux.intel.com
From: Ville Syrj?l? Signed-off-by: Ville Syrj?l? --- include/drm/drm_fb_helper.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h index 8230b46..61ebd51 100644 --- a/include/drm/drm_fb_helper.h +++ b/include/drm/drm_fb_helper.h @@ -57

[PATCH 2/3] drm: Remove pointless '-' characters from drm_fb_helper documentation

2013-05-08 Thread ville.syrj...@linux.intel.com
From: Ville Syrj?l? Signed-off-by: Ville Syrj?l? --- include/drm/drm_fb_helper.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h index 61ebd51..471f276 100644 --- a/include/drm/drm_fb_helper.h +++ b/i

[PATCH 3/3] drm: Fix drm_rect documentation

2013-05-08 Thread ville.syrj...@linux.intel.com
From: Ville Syrj?l? The 'struct' keyword was missing so struct drm_rect documentation never ended up in the generated docs. Also reorder drm_rect.h to become before drm_rect.c so that the struct documentation appears first in the docs. And change it to use the 'I' directive instead of 'F' while

[PATCH v2] drm: Add fb_helper->restore_fbdev_mode hook

2013-05-08 Thread ville.syrj...@linux.intel.com
From: Ville Syrj?l? Drivers may need to turn off overlay planes, cursors, etc. when restoring the fbdev mode. So allow drivers to provide their own version of drm_fb_helper_restore_fbdev_mode() that can take care of such details. Initially just plug in drm_fb_helper_restore_fbdev_mode for all dr

[PATCH v2] drm: Remove some unused stuff from drm_plane

2013-05-08 Thread ville.syrj...@linux.intel.com
From: Ville Syrj?l? There's a bunch of unused members inside drm_plane, bloating the size of the structure needlessly. Eliminate them. v2: Remove all of it from kernel-doc too Signed-off-by: Ville Syrj?l? --- drivers/gpu/drm/drm_crtc.c | 2 +- include/drm/drm_crtc.h | 11 --- 2 f

[PATCH v2] drm: Add fb_helper->restore_fbdev_mode hook

2013-05-08 Thread Ville Syrjälä
On Wed, May 08, 2013 at 04:39:58PM +0300, ville.syrjala at linux.intel.com wrote: > From: Ville Syrj?l? > > Drivers may need to turn off overlay planes, cursors, etc. when > restoring the fbdev mode. So allow drivers to provide their own > version of drm_fb_helper_restore_fbdev_mode() that can t

[PATCH v2] drm: Remove some unused stuff from drm_plane

2013-05-08 Thread Laurent Pinchart
On Wednesday 08 May 2013 16:40:54 ville.syrjala at linux.intel.com wrote: > From: Ville Syrj?l? > > There's a bunch of unused members inside drm_plane, bloating the size of > the structure needlessly. Eliminate them. > > v2: Remove all of it from kernel-doc too > > Signed-off-by: Ville Syrj?l?

[PATCH v2] drm: Add fb_helper->restore_fbdev_mode hook

2013-05-08 Thread Laurent Pinchart
On Wednesday 08 May 2013 16:39:58 ville.syrjala at linux.intel.com wrote: > From: Ville Syrj?l? > > Drivers may need to turn off overlay planes, cursors, etc. when > restoring the fbdev mode. So allow drivers to provide their own > version of drm_fb_helper_restore_fbdev_mode() that can take care

[Intel-gfx] [PATCH 3/3] drm: Fix drm_rect documentation

2013-05-08 Thread Daniel Vetter
On Wed, May 08, 2013 at 04:38:35PM +0300, ville.syrjala at linux.intel.com wrote: > From: Ville Syrj?l? > > The 'struct' keyword was missing so struct drm_rect documentation never > ended up in the generated docs. > > Also reorder drm_rect.h to become before drm_rect.c so that the struct > docu

[PATCH v2] drm: Fix drm_rect documentation

2013-05-08 Thread ville.syrj...@linux.intel.com
From: Ville Syrj?l? The 'struct' keyword was missing so struct drm_rect documentation never ended up in the generated docs. Also move the drm_rect documentations to a new section alognside the various helper functions and add a short description about the intended purpose of drm_rect. v2: Move

[PATCH v2] drm: Fix drm_rect documentation

2013-05-08 Thread Daniel Vetter
On Wed, May 08, 2013 at 05:16:45PM +0300, ville.syrjala at linux.intel.com wrote: > From: Ville Syrj?l? > > The 'struct' keyword was missing so struct drm_rect documentation never > ended up in the generated docs. > > Also move the drm_rect documentations to a new section alognside the > variou

Some lost drm patches

2013-05-08 Thread Damien Lespiau
I just collected a few sad patches crying in the dark alley of the Internet that dri-devel can sometimes be. A few of them even have a r-b tag by benevolent and fatherly figures. All they want is to find a new home! -- Damien

[PATCH 1/5] drm: Add missing break in the command line mode parsing code

2013-05-08 Thread Damien Lespiau
As we parse the string given on the command line one char at a time, it seems that we do want a break at every case. Signed-off-by: Damien Lespiau Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/drm_modes.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/

[PATCH 2/5] drm: Make the HPD status updates debug logs more readable

2013-05-08 Thread Damien Lespiau
Instead of just printing "status updated from 1 to 2", make those enum numbers immediately readable. v2: Also patch output_poll_execute() (Daniel Vetter) Signed-off-by: Damien Lespiau Reviewed-by: Jesse Barnes --- drivers/gpu/drm/drm_crtc_helper.c | 22 ++ 1 file changed, 1

[PATCH 3/5] drm: Don't prune modes loudly when a connector is disconnected

2013-05-08 Thread Damien Lespiau
drm_helper_probe_single_connector_modes() is responsible for pruning the previously detected modes on a disconnected connector. We don't really need to log, again, the full list of modes that used to be valid when connected. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_crtc_helper.c | 4

[PATCH 4/5] drm: Fix a typo in the struct drm_plane_funcs documentation

2013-05-08 Thread Damien Lespiau
From: "Lespiau, Damien" Signed-off-by: Damien Lespiau --- include/drm/drm_crtc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index e3e0d65..23fb185 100644 --- a/include/drm/drm_crtc.h +++ b/include/drm/drm_crtc.h @@ -660,7

[PATCH 5/5] drm: Use names of ioctls in debug traces

2013-05-08 Thread Damien Lespiau
From: Chris Cummins The intention here is to make the output of dmesg with full verbosity a bit easier for a human to parse. This commit transforms: [drm:drm_ioctl], pid=699, cmd=0x6458, nr=0x58, dev 0xe200, auth=1 [drm:drm_ioctl], pid=699, cmd=0xc010645b, nr=0x5b, dev 0xe200, auth=1 [drm:drm_io

[PATCH 2/5] drm: Make the HPD status updates debug logs more readable

2013-05-08 Thread Chris Wilson
On Wed, May 08, 2013 at 05:03:31PM +0100, Damien Lespiau wrote: > > Instead of just printing "status updated from 1 to 2", make those enum > numbers immediately readable. > > v2: Also patch output_poll_execute() (Daniel Vetter) For bonus points, only emit the message when it is updated. -Chris

[PATCH 2/5] drm: Make the HPD status updates debug logs more readable

2013-05-08 Thread Ville Syrjälä
On Wed, May 08, 2013 at 05:03:31PM +0100, Damien Lespiau wrote: > Instead of just printing "status updated from 1 to 2", make those enum > numbers immediately readable. > > v2: Also patch output_poll_execute() (Daniel Vetter) > > Signed-off-by: Damien Lespiau > Reviewed-by: Jesse Barnes > --- >

[Intel-gfx] [PATCH 4/5] drm: Fix a typo in the struct drm_plane_funcs documentation

2013-05-08 Thread Ville Syrjälä
On Wed, May 08, 2013 at 05:03:33PM +0100, Damien Lespiau wrote: > From: "Lespiau, Damien" > > Signed-off-by: Damien Lespiau > --- > include/drm/drm_crtc.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h > index e3e0d65..2

[Intel-gfx] [PATCH 5/5] drm: Use names of ioctls in debug traces

2013-05-08 Thread Ville Syrjälä
On Wed, May 08, 2013 at 05:03:34PM +0100, Damien Lespiau wrote: > From: Chris Cummins > > The intention here is to make the output of dmesg with full verbosity a > bit easier for a human to parse. This commit transforms: > > [drm:drm_ioctl], pid=699, cmd=0x6458, nr=0x58, dev 0xe200, auth=1 > [dr

[PATCH] drm: refactor call to request_module

2013-05-08 Thread Kees Cook
On Wed, May 8, 2013 at 12:22 AM, Paul Menzel wrote: > Am Dienstag, den 07.05.2013, 12:32 -0700 schrieb Kees Cook: >> This reduces the size of the stack frame when calling request_module(). >> Performing the sprintf before the call is not needed. > > Good fine. Do you have any hard numbers for the

[Bug 63935] TURKS [drm:r600_uvd_init] *ERROR* UVD not responding, trying to reset the VCPU!!!

2013-05-08 Thread bugzilla-dae...@freedesktop.org
ovide that would help identify what is different when EFI booting? -- You are receiving this mail because: You are the assignee for the bug. -- next part -- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20130508/

[Intel-gfx] [PATCH 5/5] drm: Use names of ioctls in debug traces

2013-05-08 Thread Ben Widawsky
On Wed, May 08, 2013 at 07:55:18PM +0300, Ville Syrj?l? wrote: > On Wed, May 08, 2013 at 05:03:34PM +0100, Damien Lespiau wrote: > > From: Chris Cummins > > > > The intention here is to make the output of dmesg with full verbosity a > > bit easier for a human to parse. This commit transforms: > >

[PATCH] radeon: Allow disabling UVD

2013-05-08 Thread Parag Warudkar
On Wed, 8 May 2013, Christian K?nig wrote: > Am 07.05.2013 23:13, schrieb Parag Warudkar: > > On Tue, May 7, 2013 at 4:44 AM, Christian K?nig > > wrote: > > Without SUMO_uvd.bin - suspends fine and only wakes up when I want it to. > > Hui? Wait a second, the firmware doesn't work but still cau

[PATCH 4/4] drm/mgag200: Fix framebuffer base address programming

2013-05-08 Thread Christopher Harvey
Higher bits of the base address of framebuffers weren't being programmed properly. This caused framebuffers that didn't happen to be allocated at a low enough address to not be displayed properly. Signed-off-by: Christopher Harvey Signed-off-by: Mathieu Larouche --- drivers/gpu/drm/mgag200/mgag

[PATCH v2 4/4] drm/mgag200: Fix framebuffer base address programming

2013-05-08 Thread Christopher Harvey
Higher bits of the base address of framebuffers weren't being programmed properly. This caused framebuffers that didn't happen to be allocated at a low enough address to not be displayed properly. Signed-off-by: Christopher Harvey Signed-off-by: Mathieu Larouche Acked-by: Julia Lemire Tested-by