Re: [PATCHv5,RESEND 3/8] gpu: host1x: Add channel support

2013-03-11 Thread Thierry Reding
On Mon, Mar 11, 2013 at 08:29:59AM +0200, Terje Bergström wrote: > On 08.03.2013 22:43, Thierry Reding wrote: > > A bo is just a buffer object, so I don't see why the name shouldn't > > be used. The name is in no way specific to DRM or GEM. But the point > > that I was trying to make was that there

Re: [PATCHv5,RESEND 3/8] gpu: host1x: Add channel support

2013-03-11 Thread Terje Bergström
On 11.03.2013 09:18, Thierry Reding wrote: > This sound a bit over-engineered at this point in time. DRM is currently > the only user. Is anybody working on any non-DRM drivers that would use > this? Well, this contains beginning of that: http://nv-tegra.nvidia.com/gitweb/?p=linux-2.6.git;a=blob;

Re: [PATCHv5,RESEND 3/8] gpu: host1x: Add channel support

2013-03-11 Thread Thierry Reding
On Mon, Mar 11, 2013 at 11:21:05AM +0200, Terje Bergström wrote: > On 11.03.2013 09:18, Thierry Reding wrote: > > This sound a bit over-engineered at this point in time. DRM is currently > > the only user. Is anybody working on any non-DRM drivers that would use > > this? > > Well, this contains b

re: drm/nouveau: port all engines to new engine module format

2013-03-11 Thread Dan Carpenter
Hello Ben Skeggs, The patch ebb945a94bba: "drm/nouveau: port all engines to new engine module format" from Jul 20, 2012, leads to the following warning: "drivers/gpu/drm/nouveau/core/engine/graph/nvc0.c:570 nvc0_graph_ctor() error: buffer overflow 'priv->tpc_nr' 4 <= 30" drivers/gpu/dr

Re: nouveau shuts the machine down with v3.9-rc1 (temperature (72 C) hit the 'shutdown' threshold).

2013-03-11 Thread Konrad Rzeszutek Wilk
> With that I am still getting the issues (even with an insance delay of 100 > seconds). > Here is the serial log with various runs. Any thoughts? > [ 13.523878] initcall init_sg+0x0/0x1000 [sg] returned 0 after 5355 usecs > ^G^G[ 13.621376] nouveau [ PTHERM][:00:0d.0] programmed thresh

[Bug 56139] [bisected] kernel 3.7.0-rc1 breaks 6950 (boot/grub2 and suspend/resume) (CAYMAN)

2013-03-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=56139 Alex Deucher changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 60439] Suspend/resume broken for cayman with 90a51a329258e3c868f6

2013-03-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=60439 Alex Deucher changed: What|Removed |Added CC||alexandre.f.dem...@gmail.co

[Bug 60439] Suspend/resume broken for cayman with 90a51a329258e3c868f6

2013-03-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=60439 --- Comment #9 from Alex Deucher --- Does switching to another VT before suspending help? -- You are receiving this mail because: You are the assignee for the bug. ___ dri-devel mailing list dri-devel

Re: [PATCH] drivers/gpu/drm/omapdrm: Makefile, only -Werror when no -W* in EXTRA_CFLAGS

2013-03-11 Thread Rob Clark
On Sat, Mar 9, 2013 at 11:21 PM, Chen Gang wrote: > > When make with EXTRA_CFLAGS=-W, it will report error. > so give a check in Makefile. > > Signed-off-by: Chen Gang > Signed-off-by: Vladimir Kondratiev Signed-off-by: Rob Clark > --- > drivers/gpu/drm/omapdrm/Makefile |5 - > 1

Re: [PATCH] drivers/gpu/drm/tilcdc: Makefile, only -Werror when no -W* in EXTRA_CFLAGS

2013-03-11 Thread Rob Clark
On Sun, Mar 10, 2013 at 12:04 AM, Chen Gang wrote: > > When make with EXTRA_CFLAGS=-W, it will report error. > so give a check in Makefile. > > Signed-off-by: Chen Gang > Signed-off-by: Vladimir Kondratiev Signed-off-by: Rob Clark > --- > drivers/gpu/drm/tilcdc/Makefile |5 - > 1

[Bug 60439] Suspend/resume broken for cayman with 90a51a329258e3c868f6

2013-03-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=60439 Christian König changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #10 from Christia

[Bug 62170] New: [bisected] R600 LLVM build broken

2013-03-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=62170 Priority: medium Bug ID: 62170 Assignee: dri-devel@lists.freedesktop.org Summary: [bisected] R600 LLVM build broken Severity: normal Classification: Unclassified OS: All

[Bug 60553] [trine2] wrong colors when executed fullscreen

2013-03-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=60553 --- Comment #3 from lethar...@gmail.com --- I can confirm I have the same issue. Works in windowed, colors wrong in fullscreen, and some objects fail to render completely during gameplay. Radeon HD 6550D Mesa 9.1 xf86-video-ati 7.1.0 -- You are

[Bug 62170] [bisected] R600 LLVM build broken

2013-03-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=62170 --- Comment #1 from maxi...@free.fr --- Oh, I'm using llvm from SVN at revision 176687 (fairly recent) -- You are receiving this mail because: You are the assignee for the bug. ___ dri-devel mailing li

[Bug 60439] Suspend/resume broken for cayman with 90a51a329258e3c868f6

2013-03-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=60439 --- Comment #11 from Dmitry Cherkassov --- Hi. I can't reproduce this bug on cayman with 3.8-rc3 (using pm-suspend). Resuming works. What software do you use? I've used xmonad launched via legacy startx while testing that. Can you fire up a s

[Bug 60439] Suspend/resume broken for cayman with 90a51a329258e3c868f6

2013-03-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=60439 --- Comment #12 from Alexandre Demers --- (In reply to comment #11) > Hi. > > I can't reproduce this bug on cayman with 3.8-rc3 (using pm-suspend). > Resuming works. > > What software do you use? > I've used xmonad launched via legacy startx w

[Bug 58372] [KMS][Cayman] Garbled screen and gpu crash with 6950 with drm-next

2013-03-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=58372 Serkan Hosca changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [PATCH 1/4] drm/tilcdc: Fix an incorrect condition

2013-03-11 Thread Sachin Kamat
Hi Rob, On 2 March 2013 20:40, Rob Clark wrote: > On Sat, Mar 2, 2013 at 5:23 AM, Sachin Kamat wrote: >> Instead of checking if num_encoders is zero, it is being assigned 0. >> Convert the assignment to a check. >> >> Signed-off-by: Sachin Kamat > > Signed-off-by: Rob Clark Just curious. Whic

Re: [PATCH 4/4] omapdss: features: fixed supported outputs for OMAP4

2013-03-11 Thread Tomi Valkeinen
On 2013-03-05 16:17, Archit Taneja wrote: > The support outputs struct for overlay managers is incorrect for OMAP4. Make > these changes: > > - DPI isn't supported via the LCD1 overlay manager, remove DPI as a supported > output. > - the TV manager can suppport DPI, but the omapdss driver doesn'

[Bug 62170] [bisected] R600 LLVM build broken

2013-03-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=62170 maxi...@free.fr changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 60439] Suspend/resume broken for cayman with 90a51a329258e3c868f6

2013-03-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=60439 --- Comment #13 from Alex Deucher --- Created attachment 76349 --> https://bugs.freedesktop.org/attachment.cgi?id=76349&action=edit possible fix This patch should fix the issue. -- You are receiving this mail because: You are the assignee fo

[Bug 57919] Visual glitches in unity with Radeon HD 7600M

2013-03-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=57919 --- Comment #4 from Thilo Cestonaro --- Tried with cdimage: http://cdimages.ubuntu.com/daily-live/20130311/raring-desktop-amd64.iso Still very ugly glitches! Please, if I can provide any more details or something, tell me! I added a glxinfo

[Bug 57919] Visual glitches in unity with Radeon HD 7600M

2013-03-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=57919 --- Comment #5 from Thilo Cestonaro --- Created attachment 76350 --> https://bugs.freedesktop.org/attachment.cgi?id=76350&action=edit LiveCD GlxInfo 03/11/13 another LIBGL_DEBUG=verbose glxinfo output. This time generated by binaries from the

[PATCH V3] get_maintainer: use filename-only regex match for Tegra

2013-03-11 Thread Stephen Warren
From: Stephen Warren Create a new N: entry type in MAINTAINERS which performs a regex match against filenames; either those extracted from patch +++ or --- lines, or those specified on the command-line using the -f option. This provides the same benefits as using a K: regex option to match a set

[PATCH] drm/i915: restrict kernel address leak in debugfs

2013-03-11 Thread Kees Cook
Masks kernel address info-leak in object dumps with the %pK suffix, so they cannot be used to target kernel memory corruption attacks if the kptr_restrict sysctl is set. Signed-off-by: Kees Cook Cc: sta...@vger.kernel.org --- drivers/gpu/drm/i915/i915_debugfs.c |2 +- 1 file changed, 1 inser

[PATCH] drivers: gpu: drm: exynos: Replaced kzalloc & memcpy with kmemdup

2013-03-11 Thread Alexandru Gheorghiu
Replaced calls to kzalloc followed by memcpy with call to kmemdup. Patch found using coccinelle. Signed-off-by: Alexandru Gheorghiu --- drivers/gpu/drm/exynos/exynos_drm_vidi.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_vidi.c

[PATCH] drm/i915: clarify reasoning for the access_ok call

2013-03-11 Thread Kees Cook
This clarifies the comment above the access_ok check so a missing VERIFY_READ doesn't alarm anyone. Signed-off-by: Kees Cook Cc: Daniel Vetter --- drivers/gpu/drm/i915/i915_gem_execbuffer.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_gem

[PATCH] drm/radeon: check incoming cliprects pointer

2013-03-11 Thread Kees Cook
The "boxes" parameter points into userspace memory. It should be verified like any other operation against user memory. Signed-off-by: Kees Cook Cc: sta...@vger.kernel.org --- drivers/gpu/drm/radeon/r300_cmdbuf.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/

[PATCH] drm/i915: bounds check execbuffer relocations

2013-03-11 Thread Kees Cook
It is possible to wrap the counter used to allocate the buffer for relocation copies. This could lead to heap writing overflows. Signed-off-by: Kees Cook Reported-by: Pinkie Pie Cc: sta...@vger.kernel.org --- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 10 -- 1 file changed, 8 inserti

[PATCH] drivers: gpu: drm: i915: Replaced calls to kmalloc & memcpy with kmemdup

2013-03-11 Thread Alexandru Gheorghiu
Replaced calls to kmalloc followed by memcpy with a single call to kmemdup. This patch was found using coccinelle. Signed-off-by: Alexandru Gheorghiu --- drivers/gpu/drm/i915/intel_dp.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/dri

[PATCH] drivers: gpu: drm: Replaced ERR_PTR & PTR_ERR with ERR_CAST

2013-03-11 Thread Alexandru Gheorghiu
Replaced ERR_PTR and PTR_ERR calls with ERR_CAST. Patch found using coccinelle. Signed-off-by: Alexandru Gheorghiu --- drivers/gpu/drm/drm_prime.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c index 366910d..4c8ad

[PATCH] drivers: gpu: drm: gma500: Replaced calls kzalloc & memcpy with kmemdup

2013-03-11 Thread Alexandru Gheorghiu
Replaced calls kzalloc followed by memcpy with call to kmemdup. Patch found using coccinelle. Signed-off-by: Alexandru Gheorghiu --- drivers/gpu/drm/gma500/intel_bios.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/gma500/intel_bios.c b/drivers/gpu/drm

Re: [PATCH V3] get_maintainer: use filename-only regex match for Tegra

2013-03-11 Thread Joe Perches
On Mon, 2013-03-11 at 14:19 -0600, Stephen Warren wrote: > Create a new N: entry type in MAINTAINERS which performs a regex match > against filenames; either those extracted from patch +++ or --- lines, > or those specified on the command-line using the -f option. [] > Switch the Tegra entry from u

Re: [PATCH] drm/i915: clarify reasoning for the access_ok call

2013-03-11 Thread Chris Wilson
On Mon, Mar 11, 2013 at 12:26:30PM -0700, Kees Cook wrote: > This clarifies the comment above the access_ok check so a missing > VERIFY_READ doesn't alarm anyone. Do we really need to copy the interface documentation? /** * access_ok: - Checks if a user space pointer is valid * @type: Type of a

Re: [PATCH] drm/i915: bounds check execbuffer relocations

2013-03-11 Thread Chris Wilson
On Mon, Mar 11, 2013 at 12:27:16PM -0700, Kees Cook wrote: > It is possible to wrap the counter used to allocate the buffer for > relocation copies. This could lead to heap writing overflows. Seems a sensible check, just in the wrong location. You need to do the checking upfront in validate_exec_l

Re: [PATCH] drivers: gpu: drm: gma500: Replaced calls kzalloc & memcpy with kmemdup

2013-03-11 Thread Patrik Jakobsson
On Mon, Mar 11, 2013 at 8:46 PM, Alexandru Gheorghiu wrote: > Replaced calls kzalloc followed by memcpy with call to kmemdup. > Patch found using coccinelle. > > Signed-off-by: Alexandru Gheorghiu > --- > drivers/gpu/drm/gma500/intel_bios.c |3 +-- > 1 file changed, 1 insertion(+), 2 deletio

[PATCH 0/2] Properly suspend/resume sub-allocator

2013-03-11 Thread alexdeucher
From: Alex Deucher This patch set is a bit of a heavy hammer, but I'm not sure it's worth the effort to create separate suspend functions for all sub-allocator users that basically just calls radeon_sa_bo_manager_suspend() and fix up all the sub allocator init functions to call radeon_sa_bo_manag

[PATCH 1/2] drm/radeon: fix S/R on VM systems (cayman/TN/SI)

2013-03-11 Thread alexdeucher
From: Alex Deucher We weren't properly tearing down the VM sub-alloctor on suspend leading to bogus VM PTs on resume. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=60439 Tested-by: Dmitry Cherkasov Signed-off-by: Alex Deucher Cc: sta...@vger.kernel.org --- drivers/gpu/drm/radeon/ni.c |

[PATCH 2/2] drm/radeon: tear down the IB pool on suspend

2013-03-11 Thread alexdeucher
From: Alex Deucher Otherwise we may end up with stale MC addresses after resume. Signed-off-by: Alex Deucher Cc: sta...@vger.kernel.org --- drivers/gpu/drm/radeon/evergreen.c |1 + drivers/gpu/drm/radeon/ni.c|1 + drivers/gpu/drm/radeon/r100.c |1 + drivers/gpu/drm/rad

Re: [PATCH] drivers: gpu: drm: i915: Replaced calls to kmalloc & memcpy with kmemdup

2013-03-11 Thread Andru Gheorghiu
You are right. I shall resend :) Thanks! On Mon, Mar 11, 2013 at 10:25 PM, Josh Triplett wrote: > On Mon, Mar 11, 2013 at 09:30:40PM +0200, Alexandru Gheorghiu wrote: > > Replaced calls to kmalloc followed by memcpy with a single call to > kmemdup. > > This patch was found using coccinelle. > >

[PATCH] drivers: gpu: drm: i915: Replaced calls to kmalloc & memcpy with kmemdup

2013-03-11 Thread Alexandru Gheorghiu
Replaced calls to kmalloc followed by memcpy with a single call to kmemdup. Also removed a now redundant if statement. Signed-off-by: Alexandru Gheorghiu --- drivers/gpu/drm/i915/intel_dp.c |5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c

Re: [PATCH] drm/i915: clarify reasoning for the access_ok call

2013-03-11 Thread Kees Cook
On Mon, Mar 11, 2013 at 1:51 PM, Chris Wilson wrote: > On Mon, Mar 11, 2013 at 12:26:30PM -0700, Kees Cook wrote: >> This clarifies the comment above the access_ok check so a missing >> VERIFY_READ doesn't alarm anyone. > > Do we really need to copy the interface documentation? > > /** > * access

Re: [PATCH] drm/i915: bounds check execbuffer relocations

2013-03-11 Thread Kees Cook
On Mon, Mar 11, 2013 at 1:52 PM, Chris Wilson wrote: > On Mon, Mar 11, 2013 at 12:27:16PM -0700, Kees Cook wrote: >> It is possible to wrap the counter used to allocate the buffer for >> relocation copies. This could lead to heap writing overflows. > > Seems a sensible check, just in the wrong loc

Re: [PATCH] drivers: gpu: drm: i915: Replaced calls to kmalloc & memcpy with kmemdup

2013-03-11 Thread Josh Triplett
On Mon, Mar 11, 2013 at 09:30:40PM +0200, Alexandru Gheorghiu wrote: > Replaced calls to kmalloc followed by memcpy with a single call to kmemdup. > This patch was found using coccinelle. > > Signed-off-by: Alexandru Gheorghiu > --- > drivers/gpu/drm/i915/intel_dp.c |3 +-- > 1 file changed,

Re: [PATCH] drm/i915: clarify reasoning for the access_ok call

2013-03-11 Thread Chris Wilson
On Mon, Mar 11, 2013 at 02:04:51PM -0700, Kees Cook wrote: > Probably not. It just seemed like the existing comment was > insufficient after the removal of the redundant VERIFY_READ check that > happened recently. That's certainly true, the remaining comment is a little cryptic. Something more lik

Re: [PATCH] drivers: gpu: drm: i915: Replaced calls to kmalloc & memcpy with kmemdup

2013-03-11 Thread Joe Perches
On Mon, 2013-03-11 at 22:39 +0200, Alexandru Gheorghiu wrote: > Replaced calls to kmalloc followed by memcpy with a single call to kmemdup. > Also removed a now redundant if statement. [] > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c [] > @@ -2335,11 +2335,8 @@ in

Re: [PATCH V3] get_maintainer: use filename-only regex match for Tegra

2013-03-11 Thread Marcin Ślusarz
11 mar 2013 21:19, "Stephen Warren" napisał(a): > > From: Stephen Warren > > Create a new N: entry type in MAINTAINERS which performs a regex match > against filenames; either those extracted from patch +++ or --- lines, > or those specified on the command-line using the -f option. > > This provi

[Bug 60439] Suspend/resume broken for cayman with 90a51a329258e3c868f6

2013-03-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=60439 --- Comment #14 from Alexandre Demers --- (In reply to comment #13) > Created attachment 76349 [details] [review] > possible fix > > This patch should fix the issue. It does over here. -- You are receiving this mail because: You are the assig

Re: [PATCH v2] drm/i915: bounds check execbuffer relocation count

2013-03-11 Thread Chris Wilson
On Mon, Mar 11, 2013 at 02:23:29PM -0700, Kees Cook wrote: > It is possible to wrap the counter used to allocate the buffer for > relocation copies. This could lead to heap writing overflows. I'd keep the return value as EINVAL so that we can continue to distinguish between the user passing garbag

Re: [PATCH V3] get_maintainer: use filename-only regex match for Tegra

2013-03-11 Thread Stephen Warren
On 03/11/2013 03:36 PM, Marcin Ślusarz wrote: > > 11 mar 2013 21:19, "Stephen Warren" > napisał(a): >> Create a new N: entry type in MAINTAINERS which performs a regex match >> against filenames; either those extracted from patch +++ or --- lines, >> or those specifi

[PATCH REPOST] drm: tegra: don't depend on OF

2013-03-11 Thread Stephen Warren
From: Stephen Warren ARCH_TEGRA always enabled OF, so there's no need for any driver to depend on it. Signed-off-by: Stephen Warren --- drivers/gpu/drm/tegra/Kconfig |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tegra/Kconfig b/drivers/gpu/drm/tegra/Kco

[PATCH v2] drm/i915: bounds check execbuffer relocation count

2013-03-11 Thread Kees Cook
It is possible to wrap the counter used to allocate the buffer for relocation copies. This could lead to heap writing overflows. Signed-off-by: Kees Cook Reported-by: Pinkie Pie Cc: sta...@vger.kernel.org --- v2: - move check into validate_exec_list --- drivers/gpu/drm/i915/i915_gem_execbuffer.

[PATCH v2] drm/i915: clarify reasoning for the access_ok call

2013-03-11 Thread Kees Cook
This clarifies the comment above the access_ok check so a missing VERIFY_READ doesn't alarm anyone. Signed-off-by: Kees Cook Cc: Daniel Vetter --- v2: - rewrote comment, thanks to Chris Wilson --- drivers/gpu/drm/i915/i915_gem_execbuffer.c |6 +- 1 file changed, 5 insertions(+), 1 dele

Re: [PATCH v2] drm/i915: bounds check execbuffer relocation count

2013-03-11 Thread Kees Cook
On Mon, Mar 11, 2013 at 3:00 PM, Chris Wilson wrote: > On Mon, Mar 11, 2013 at 02:23:29PM -0700, Kees Cook wrote: >> It is possible to wrap the counter used to allocate the buffer for >> relocation copies. This could lead to heap writing overflows. > > I'd keep the return value as EINVAL so that w

Re: [PATCH 01/14] x86, ACPI, mm: Kill max_low_pfn_mapped

2013-03-11 Thread Daniel Vetter
On Thu, Mar 07, 2013 at 10:09:26PM -0800, H. Peter Anvin wrote: > On 03/07/2013 09:28 PM, Tejun Heo wrote: > > On Thu, Mar 7, 2013 at 9:27 PM, Yinghai Lu wrote: > >> They are not using memblock_find_in_range(), so 1ULL<< will not help. > >> > >> Really hope i915 drm guys could clean that hacks. >

Re: [PATCH v2] drm/i915: bounds check execbuffer relocation count

2013-03-11 Thread Chris Wilson
On Mon, Mar 11, 2013 at 03:25:59PM -0700, Kees Cook wrote: > On Mon, Mar 11, 2013 at 3:00 PM, Chris Wilson > wrote: > > On Mon, Mar 11, 2013 at 02:23:29PM -0700, Kees Cook wrote: > >> It is possible to wrap the counter used to allocate the buffer for > >> relocation copies. This could lead to hea

Re: [PATCH] gpu: don't cast kzalloc() return value

2013-03-11 Thread Daniel Vetter
On Sun, Mar 10, 2013 at 02:22:48PM +0200, Mihnea Dobrescu-Balaur wrote: > Signed-off-by: Mihnea Dobrescu-Balaur Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch __

Re: nouveau shuts the machine down with v3.9-rc1 (temperature (72 C) hit the 'shutdown' threshold).

2013-03-11 Thread Martin Peres
On 11/03/2013 13:38, Konrad Rzeszutek Wilk wrote: With that I am still getting the issues (even with an insance delay of 100 seconds). Here is the serial log with various runs. Any thoughts? Sorry for taking so long to answer but I got a one-week flu and still had to do my research duties :s

Re: [PATCH] drm/i915: use simple attribute in debugfs routines

2013-03-11 Thread Daniel Vetter
On Sun, Mar 10, 2013 at 02:10:06PM -0700, Kees Cook wrote: > This replaces the manual read/write routines in debugfs with the common > simple attribute helpers. Doing this gets rid of repeated copy/pasting > of copy_from_user and value formatting code. > > Signed-off-by: Kees Cook > Cc: Daniel Ve

Re: [PATCH 01/14] x86, ACPI, mm: Kill max_low_pfn_mapped

2013-03-11 Thread Chris Wilson
On Mon, Mar 11, 2013 at 11:50:48PM +0100, Daniel Vetter wrote: > On Thu, Mar 07, 2013 at 10:09:26PM -0800, H. Peter Anvin wrote: > > On 03/07/2013 09:28 PM, Tejun Heo wrote: > > > On Thu, Mar 7, 2013 at 9:27 PM, Yinghai Lu wrote: > > >> They are not using memblock_find_in_range(), so 1ULL<< will n

Re: [PATCH v2] drm/i915: clarify reasoning for the access_ok call

2013-03-11 Thread Daniel Vetter
On Mon, Mar 11, 2013 at 02:37:35PM -0700, Kees Cook wrote: > This clarifies the comment above the access_ok check so a missing > VERIFY_READ doesn't alarm anyone. > > Signed-off-by: Kees Cook > Cc: Daniel Vetter > --- > v2: > - rewrote comment, thanks to Chris Wilson Queued for -next, thanks f

Re: [PATCH] drm/i915: restrict kernel address leak in debugfs

2013-03-11 Thread Daniel Vetter
On Mon, Mar 11, 2013 at 12:25:19PM -0700, Kees Cook wrote: > Masks kernel address info-leak in object dumps with the %pK suffix, > so they cannot be used to target kernel memory corruption attacks if > the kptr_restrict sysctl is set. > > Signed-off-by: Kees Cook > Cc: sta...@vger.kernel.org Pick

[PATCH] drm/radeon: fix backend map setup on 1 RB trinity boards

2013-03-11 Thread alexdeucher
From: Alex Deucher Need to adjust the backend map depending on which RB is enabled. This is the trinity equivalent of: f7eb97300832f4fe5fe916c5d84cd2e25169330e Signed-off-by: Alex Deucher Cc: sta...@vger.kernel.org --- drivers/gpu/drm/radeon/ni.c | 21 - 1 files changed,

[Bug 57919] Visual glitches in unity with Radeon HD 7600M

2013-03-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=57919 --- Comment #6 from Alex Deucher --- Created attachment 76354 --> https://bugs.freedesktop.org/attachment.cgi?id=76354&action=edit possible fix Does the attached kernel patch fix the issue? -- You are receiving this mail because: You are the

Re: [PATCH 01/14] x86, ACPI, mm: Kill max_low_pfn_mapped

2013-03-11 Thread H. Peter Anvin
The problem is that the code will be broken, and so it makes no sense. The #if 0 is really confusing. Daniel Vetter wrote: >On Thu, Mar 07, 2013 at 10:09:26PM -0800, H. Peter Anvin wrote: >> On 03/07/2013 09:28 PM, Tejun Heo wrote: >> > On Thu, Mar 7, 2013 at 9:27 PM, Yinghai Lu >wrote: >> >>

Re: [PATCH] drivers: gpu: drm: exynos: Replaced kzalloc & memcpy with kmemdup

2013-03-11 Thread 김승우
Good point. Acked-by: Seung-Woo Kim On 2013년 03월 12일 04:25, Alexandru Gheorghiu wrote: > Replaced calls to kzalloc followed by memcpy with call to kmemdup. > Patch found using coccinelle. > > Signed-off-by: Alexandru Gheorghiu > --- > drivers/gpu/drm/exynos/exynos_drm_vidi.c |6 ++ >

Re: [PATCH] drivers: gpu: drm: exynos: Replaced kzalloc & memcpy with kmemdup

2013-03-11 Thread Inki Dae
Applied. Thanks, Inki Dae 2013/3/12 Alexandru Gheorghiu : > Replaced calls to kzalloc followed by memcpy with call to kmemdup. > Patch found using coccinelle. > > Signed-off-by: Alexandru Gheorghiu > --- > drivers/gpu/drm/exynos/exynos_drm_vidi.c |6 ++ > 1 file changed, 2 insertions(+)

linux-next: build failure after merge of the final tree (drm-intel tree related)

2013-03-11 Thread Stephen Rothwell
Hi all, After merging the final tree, today's linux-next build (i386 defconfig) failed like this: drivers/built-in.o: In function `i915_min_freq_set': i915_debugfs.c:(.text+0xb1adc): undefined reference to `__udivdi3' drivers/built-in.o: In function `i915_max_freq_set': i915_debugfs.c:(.text+0xb1

sub function power management (gpu + audio device)

2013-03-11 Thread Dave Airlie
Hey guys, I've been writing dynamic power management code for the secondary GPUs, however a lot of these GPUs have audio codecs as a subfunction PCI device. So we get 01:00.0 as the GPU and 01:00.1 as the HDMI audio device. Now we have a single power switch for these devices, and generally the p

Re: [PATCH 4/4] omapdss: features: fixed supported outputs for OMAP4

2013-03-11 Thread Archit Taneja
On Monday 11 March 2013 05:58 PM, Tomi Valkeinen wrote: On 2013-03-05 16:17, Archit Taneja wrote: The support outputs struct for overlay managers is incorrect for OMAP4. Make these changes: - DPI isn't supported via the LCD1 overlay manager, remove DPI as a supported output. - the TV manager

[git pull] drm nouveau fixes

2013-03-11 Thread Dave Airlie
Hi Linus, this is just nouveau fixes from Ben, one fixes a nasty oops that some Fedora people have been seeing, so I'd like to get it out of the way. Dave. The following changes since commit f6161aa153581da4a3867a2d1a7caf4be19b6ec9: Linux 3.9-rc2 (2013-03-10 16:54:19 -0700) are available i

Re: sub function power management (gpu + audio device)

2013-03-11 Thread Takashi Iwai
At Tue, 12 Mar 2013 16:05:26 +1000, Dave Airlie wrote: > > Hey guys, > > I've been writing dynamic power management code for the secondary > GPUs, however a lot of these GPUs have audio codecs as a subfunction > PCI device. > > So we get 01:00.0 as the GPU and 01:00.1 as the HDMI audio device. >

Re: [PATCH REPOST] drm: tegra: don't depend on OF

2013-03-11 Thread Thierry Reding
On Mon, Mar 11, 2013 at 04:33:02PM -0600, Stephen Warren wrote: > From: Stephen Warren > > ARCH_TEGRA always enabled OF, so there's no need for any driver to > depend on it. > > Signed-off-by: Stephen Warren > --- > drivers/gpu/drm/tegra/Kconfig |2 +- > 1 file changed, 1 insertion(+), 1 d

Re: [PATCH] drivers/gpu/drm/tilcdc: Makefile, only -Werror when no -W* in EXTRA_CFLAGS

2013-03-11 Thread Chen Gang
于 2013年03月11日 22:02, Rob Clark 写道: > On Sun, Mar 10, 2013 at 12:04 AM, Chen Gang wrote: >> > >> > When make with EXTRA_CFLAGS=-W, it will report error. >> > so give a check in Makefile. >> > >> > Signed-off-by: Chen Gang >> > Signed-off-by: Vladimir Kondratiev > Signed-off-by: Rob Clark >

Re: [PATCH] drm/i915: use simple attribute in debugfs routines

2013-03-11 Thread Kees Cook
On Mon, Mar 11, 2013 at 4:03 PM, Daniel Vetter wrote: > On Sun, Mar 10, 2013 at 02:10:06PM -0700, Kees Cook wrote: >> This replaces the manual read/write routines in debugfs with the common >> simple attribute helpers. Doing this gets rid of repeated copy/pasting >> of copy_from_user and value for

[PATCH v3] drm/i915: bounds check execbuffer relocation count

2013-03-11 Thread Kees Cook
It is possible to wrap the counter used to allocate the buffer for relocation copies. This could lead to heap writing overflows. CVE-2013-0913 v3: collapse test, improve comment v2: move check into validate_exec_list Signed-off-by: Kees Cook Reported-by: Pinkie Pie Cc: sta...@vger.kernel.org --

[Bug 60802] Corruption with DMA ring on cayman

2013-03-11 Thread bugzilla-dae...@freedesktop.org
-- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20130311/54b4fb84/attachment.html>

[Bug 56139] [bisected] kernel 3.7.0-rc1 breaks 6950 (boot/grub2 and suspend/resume) (CAYMAN)

2013-03-11 Thread bugzilla-dae...@freedesktop.org
e receiving this mail because: You are the assignee for the bug. -- next part -- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20130311/b3f04470/attachment.html>

[Bug 56139] [bisected] kernel 3.7.0-rc1 breaks 6950 (boot/grub2 and suspend/resume) (CAYMAN)

2013-03-11 Thread bugzilla-dae...@freedesktop.org
org/archives/dri-devel/attachments/20130311/e65a0d79/attachment.html>

[PATCHv5,RESEND 3/8] gpu: host1x: Add channel support

2013-03-11 Thread Terje Bergström
On 08.03.2013 22:43, Thierry Reding wrote: > A bo is just a buffer object, so I don't see why the name shouldn't > be used. The name is in no way specific to DRM or GEM. But the point > that I was trying to make was that there is nothing to suggest that > we couldn't use drm_gem_object as the under

[PATCHv5,RESEND 3/8] gpu: host1x: Add channel support

2013-03-11 Thread Thierry Reding
ts instead of having to go through the memmgr API. The memory manager doesn't really exist anymore so keeping the name in the API is only confusing. Your current proposal deals with memory handles directly already so it's really just making the naming more consistent. Thierry -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: not available URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20130311/b61add17/attachment.pgp>

[PATCHv5,RESEND 3/8] gpu: host1x: Add channel support

2013-03-11 Thread Terje Bergström
On 11.03.2013 09:18, Thierry Reding wrote: > This sound a bit over-engineered at this point in time. DRM is currently > the only user. Is anybody working on any non-DRM drivers that would use > this? Well, this contains beginning of that: http://nv-tegra.nvidia.com/gitweb/?p=linux-2.6.git;a=blob;

[PATCHv5,RESEND 3/8] gpu: host1x: Add channel support

2013-03-11 Thread Thierry Reding
e above proposal. They could be inline, but it's probably also okay if they're not. They aren't meant to be used very frequently so the extra function call shouldn't matter much. It might be easier to do add some additional checks if they aren't inlined. I'm fine either way. Thierry -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: not available URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20130311/a9615687/attachment.pgp>

drm/nouveau: port all engines to new engine module format

2013-03-11 Thread Dan Carpenter
Hello Ben Skeggs, The patch ebb945a94bba: "drm/nouveau: port all engines to new engine module format" from Jul 20, 2012, leads to the following warning: "drivers/gpu/drm/nouveau/core/engine/graph/nvc0.c:570 nvc0_graph_ctor() error: buffer overflow 'priv->tpc_nr' 4 <= 30" drivers/gpu/dr

nouveau shuts the machine down with v3.9-rc1 (temperature (72 C) hit the 'shutdown' threshold).

2013-03-11 Thread Konrad Rzeszutek Wilk
> With that I am still getting the issues (even with an insance delay of 100 > seconds). > Here is the serial log with various runs. Any thoughts? > [ 13.523878] initcall init_sg+0x0/0x1000 [sg] returned 0 after 5355 usecs > ^G^G[ 13.621376] nouveau [ PTHERM][:00:0d.0] programmed thresh

[Bug 56139] [bisected] kernel 3.7.0-rc1 breaks 6950 (boot/grub2 and suspend/resume) (CAYMAN)

2013-03-11 Thread bugzilla-dae...@freedesktop.org
-- You are receiving this mail because: You are the assignee for the bug. -- next part -- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20130311/dfd87ec3/attachment.html>

[Bug 60439] Suspend/resume broken for cayman with 90a51a329258e3c868f6

2013-03-11 Thread bugzilla-dae...@freedesktop.org
: <http://lists.freedesktop.org/archives/dri-devel/attachments/20130311/23be5337/attachment.html>

[Bug 60439] Suspend/resume broken for cayman with 90a51a329258e3c868f6

2013-03-11 Thread bugzilla-dae...@freedesktop.org
: <http://lists.freedesktop.org/archives/dri-devel/attachments/20130311/84e85bd5/attachment.html>

[PATCH] drivers/gpu/drm/omapdrm: Makefile, only -Werror when no -W* in EXTRA_CFLAGS

2013-03-11 Thread Rob Clark
On Sat, Mar 9, 2013 at 11:21 PM, Chen Gang wrote: > > When make with EXTRA_CFLAGS=-W, it will report error. > so give a check in Makefile. > > Signed-off-by: Chen Gang > Signed-off-by: Vladimir Kondratiev Signed-off-by: Rob Clark > --- > drivers/gpu/drm/omapdrm/Makefile |5 - > 1

[PATCH] drivers/gpu/drm/tilcdc: Makefile, only -Werror when no -W* in EXTRA_CFLAGS

2013-03-11 Thread Rob Clark
On Sun, Mar 10, 2013 at 12:04 AM, Chen Gang wrote: > > When make with EXTRA_CFLAGS=-W, it will report error. > so give a check in Makefile. > > Signed-off-by: Chen Gang > Signed-off-by: Vladimir Kondratiev Signed-off-by: Rob Clark > --- > drivers/gpu/drm/tilcdc/Makefile |5 - > 1

[Bug 60439] Suspend/resume broken for cayman with 90a51a329258e3c868f6

2013-03-11 Thread bugzilla-dae...@freedesktop.org
ttp://lists.freedesktop.org/archives/dri-devel/attachments/20130311/dd35aa79/attachment-0001.html>

[Bug 62170] New: [bisected] R600 LLVM build broken

2013-03-11 Thread bugzilla-dae...@freedesktop.org
3d80a736c M src -- You are receiving this mail because: You are the assignee for the bug. -- next part -- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20130311/22be693b/attachment.html>

[Bug 60553] [trine2] wrong colors when executed fullscreen

2013-03-11 Thread bugzilla-dae...@freedesktop.org
are receiving this mail because: You are the assignee for the bug. -- next part -- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20130311/11afe4dc/attachment.html>

[Bug 62170] [bisected] R600 LLVM build broken

2013-03-11 Thread bugzilla-dae...@freedesktop.org
t was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20130311/f1b3d572/attachment.html>

[Bug 60439] Suspend/resume broken for cayman with 90a51a329258e3c868f6

2013-03-11 Thread bugzilla-dae...@freedesktop.org
RL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20130311/9b6c5335/attachment.html>

[Bug 60439] Suspend/resume broken for cayman with 90a51a329258e3c868f6

2013-03-11 Thread bugzilla-dae...@freedesktop.org
't trigger the bug. However, doing the same under KDE or Gnome-Shell does exhibit it. -- You are receiving this mail because: You are the assignee for the bug. -- next part -- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20130311/f39861c1/attachment.html>

[Bug 58372] [KMS][Cayman] Garbled screen and gpu crash with 6950 with drm-next

2013-03-11 Thread bugzilla-dae...@freedesktop.org
org/archives/dri-devel/attachments/20130311/b1ade6c8/attachment.html>

[PATCH 1/4] drm/tilcdc: Fix an incorrect condition

2013-03-11 Thread Sachin Kamat
Hi Rob, On 2 March 2013 20:40, Rob Clark wrote: > On Sat, Mar 2, 2013 at 5:23 AM, Sachin Kamat > wrote: >> Instead of checking if num_encoders is zero, it is being assigned 0. >> Convert the assignment to a check. >> >> Signed-off-by: Sachin Kamat > > Signed-off-by: Rob Clark Just curious. W

[PATCH 4/4] omapdss: features: fixed supported outputs for OMAP4

2013-03-11 Thread Tomi Valkeinen
e: application/pgp-signature Size: 899 bytes Desc: OpenPGP digital signature URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20130311/4a9ea618/attachment-0001.pgp>

nouveau lockdep splat

2013-03-11 Thread Arend van Spriel
On 03/07/13 12:20, Arend van Spriel wrote: > On 03/04/13 22:16, Borislav Petkov wrote: >> New -rc1, so let the stabilization games begin. >> >> I see the following on rc1, let me know if you need more info. >> >> >> [ 0.633617] = >> [ 0.633618] [ INFO: po

  1   2   >