On Fri, Jun 29, 2012 at 10:42 AM, Tom Stellard
wrote:
> On Fri, Jun 29, 2012 at 10:28:20AM -0400, alexdeucher at gmail.com wrote:
>> From: Alex Deucher
>>
>> This is something I've been wanting to do for a while and
>> I finally spent a little time getting a start on it. ?There
>> is still a lot
On Fri, Jun 29, 2012 at 10:39 AM, Christian K?nig
wrote:
> On 29.06.2012 16:28, alexdeucher at gmail.com wrote:
>>
>> From: Alex Deucher
>>
>> This is something I've been wanting to do for a while and
>> I finally spent a little time getting a start on it. ?There
>> is still a lot to do and not a
On Fri, Jun 29, 2012 at 10:28:20AM -0400, alexdeucher at gmail.com wrote:
> From: Alex Deucher
>
> This is something I've been wanting to do for a while and
> I finally spent a little time getting a start on it. There
> is still a lot to do and not all of my descriptions are great,
> but I think
Some minor comments spread over the whole file, see below:
On 29.06.2012 16:28, alexdeucher at gmail.com wrote:
> From: Alex Deucher
>
> Adds documentation to most of the functions in
> radeon_fence.c
>
> Signed-off-by: Alex Deucher
> ---
> drivers/gpu/drm/radeon/radeon_fence.c | 373
> +
On Fre, 2012-06-29 at 16:45 +0200, Christian K?nig wrote:
> Hold the ring lock the whole time the reset is in progress,
> otherwise another process can submit new jobs.
Sounds good, but doesn't this create other paths (e.g. initialization,
resume) where the ring is being accessed without holding
On Fre, 2012-06-29 at 16:45 +0200, Christian K?nig wrote:
> Waiting for a fence can fail for different reasons,
> the most common is a deadlock.
>
> Signed-off-by: Christian K?nig
Reviewed-by: Michel D?nzer
--
Earthling Michel D?nzer | http://www.amd.com
Libre so
On 29.06.2012 17:09, Michel D?nzer wrote:
> On Fre, 2012-06-29 at 16:45 +0200, Christian K?nig wrote:
>> Hold the ring lock the whole time the reset is in progress,
>> otherwise another process can submit new jobs.
> Sounds good, but doesn't this create other paths (e.g. initialization,
> resume) w
On Fre, 2012-06-29 at 16:45 +0200, Christian K?nig wrote:
> Instead of returning the error handle it directly
> and while at it fix the comments about the ring lock.
Sounds like this should really be two separate changes?
> Signed-off-by: Christian K?nig
Either way,
Reviewed-by: Michel D?nzer
On Fri, Jun 29, 2012 at 10:49 AM, Michel D?nzer wrote:
> On Don, 2012-06-28 at 17:53 -0400, alexdeucher at gmail.com wrote:
>> From: Alex Deucher
>>
>> Cayman and trinity allow for variable sized VM page
>> tables, but SI requires that all page tables be the
>> same size. ?The current code assume
On Fri, Jun 29, 2012 at 11:23 AM, Alex Deucher wrote:
> On Fri, Jun 29, 2012 at 10:49 AM, Michel D?nzer wrote:
>> On Don, 2012-06-28 at 17:53 -0400, alexdeucher at gmail.com wrote:
>>> From: Alex Deucher
>>>
>>> Cayman and trinity allow for variable sized VM page
>>> tables, but SI requires that
2012/6/29 :
> From: Alex Deucher
>
> This is something I've been wanting to do for a while and
> I finally spent a little time getting a start on it. ?There
> is still a lot to do and not all of my descriptions are great,
> but I think we can document the rest in bits and pieces. I
> also added a
On Fre, 2012-06-29 at 11:28 -0400, Jerome Glisse wrote:
> On Fri, Jun 29, 2012 at 11:23 AM, Alex Deucher
> wrote:
> > On Fri, Jun 29, 2012 at 10:49 AM, Michel D?nzer
> > wrote:
> >> On Don, 2012-06-28 at 17:53 -0400, alexdeucher at gmail.com wrote:
> >>> From: Alex Deucher
> >>>
> >>> Cayman
On Fre, 2012-06-29 at 17:18 +0200, Christian K?nig wrote:
> On 29.06.2012 17:09, Michel D?nzer wrote:
> > On Fre, 2012-06-29 at 16:45 +0200, Christian K?nig wrote:
> >> Hold the ring lock the whole time the reset is in progress,
> >> otherwise another process can submit new jobs.
> > Sounds good,
From: Alex Deucher
Adds documentation to most of the functions in
radeon_device.c
v2: split out general descriptions as per Christian's
comments.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/radeon/radeon_device.c | 313 +++-
1 files changed, 310 insertions(+),
From: Alex Deucher
Adds documentation to most of the functions in
radeon_kms.c
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/radeon/radeon_kms.c | 126 +++
1 files changed, 126 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_kms.c
b
From: Alex Deucher
Adds documentation to most of the functions in
radeon_irq_kms.c
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/radeon/radeon_irq_kms.c | 150 +++
1 files changed, 150 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_irq_
From: Alex Deucher
Adds documentation to most of the functions in
radeon_asic.c
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/radeon/radeon_asic.c | 46 ++
1 files changed, 46 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_asic.c
From: Alex Deucher
Adds documentation to most of the functions in
radeon_fence.c
v2: address Christian's comments:
- split common concept description into it's own comment
- fix description of intr parameter
- Improve description of -EDEADLK error
Signed-off-by: Alex Deucher
---
drivers/gpu/d
From: Alex Deucher
Adds documentation to most of the functions in
radeon_ring.c
v2: adjust per Christian's suggestions
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/radeon/radeon_ring.c | 216 +-
1 files changed, 213 insertions(+), 3 deletions(-)
diff --git
From: Alex Deucher
Document the non-VM functions in radeon_gart.c
v2: adjust per Christian's suggestions
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/radeon/radeon_gart.c | 125 +-
1 files changed, 122 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu
From: Alex Deucher
Document the VM functions in radeon_gart.c
v2: adjust per Christian's suggestions
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/radeon/radeon_gart.c | 159 ++
1 files changed, 159 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm
From: Alex Deucher
Still a lot more to do.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/radeon/r100.c | 127 -
1 files changed, 124 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/radeon/r100.c b/drivers/gpu/drm/radeon/r100.c
index d06c8d
From: Alex Deucher
Still a lot to do.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/radeon/evergreen.c | 120
1 files changed, 120 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/radeon/evergreen.c
b/drivers/gpu/drm/radeon/evergreen.c
index
On Fri, Jun 29, 2012 at 12:14 PM, Michel D?nzer wrote:
> On Fre, 2012-06-29 at 11:28 -0400, Jerome Glisse wrote:
>> On Fri, Jun 29, 2012 at 11:23 AM, Alex Deucher
>> wrote:
>> > On Fri, Jun 29, 2012 at 10:49 AM, Michel D?nzer
>> > wrote:
>> >> On Don, 2012-06-28 at 17:53 -0400, alexdeucher at
git send-email doesn't appear to be doing the right thing.
Begin forwarded message:
Date: Fri, 29 Jun 2012 11:17:47 -0700
From: Ben Widawsky
To: xorg-announce at lists.freedesktop.org
Cc: mesa-dev at lists.freedesktop.org, intel-gfx at lists.freedesktop.org,
dri-devel at lists.freedesktop.org Su
On Fri, 29 Jun 2012 11:48:29 -0700
Ben Widawsky wrote:
> git send-email doesn't appear to be doing the right thing.
>
> Begin forwarded message:
>
> Date: Fri, 29 Jun 2012 11:17:47 -0700
> From: Ben Widawsky
> To: xorg-announce at lists.freedesktop.org
> Cc: mesa-dev at lists.freedesktop.org,
From: Alex Deucher
Not used outside of si.c
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/radeon/si.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/radeon/si.c b/drivers/gpu/drm/radeon/si.c
index 4071858..148471c 100644
--- a/drivers/gpu/drm/ra
nding both.
Thanks,
Vladimir
-- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20120629/d3694050/attachment.html>
101 - 128 of 128 matches
Mail list logo