On Die, 2012-01-31 at 22:08 +0100, Marek Olšák wrote:
> 2012/1/31 Jerome Glisse :
> > On Tue, Jan 31, 2012 at 06:56:01PM +0100, Michel Dänzer wrote:
> >> On Die, 2012-01-31 at 16:59 +, Simon Farnsworth wrote:
> >> > Userspace currently busywaits for fences to complete; on my workload,
> >> >
Modes are created using drm_mode_create which does a
drm_mode_object_get, so use drm_mode_destroy in drm_mode_remove
which does a drm_mode_object_put.
Signed-off-by: Sascha Hauer
---
drivers/gpu/drm/drm_crtc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/
Several comments above functions say that the caller must hold the
mode_config lock, but the functions take the lock themselves. Fix
the comments.
Signed-off-by: Sascha Hauer
---
drivers/gpu/drm/drm_crtc.c | 21 +++--
1 files changed, 15 insertions(+), 6 deletions(-)
diff --gi
drm_mode_crtc_set_gamma_size returns boolean true for success
and false for failure. This is not very kernel conform, so
change it to return 0 for success and a propert error code
otherwise. Noone checks the return value, so no users have to
be fixed.
Signed-off-by: Sascha Hauer
---
drivers/gpu/
drm_fb_helper_single_add_all_connectors is always called in
conjunction with drm_fb_helper_initial_config, so call
drm_fb_helper_single_add_all_connectors inside
drm_fb_helper_initial_config and make
drm_fb_helper_single_add_all_connectors static.
Signed-off-by: Sascha Hauer
---
drivers/gpu/drm/
list_for_each_entry_safe is for walking a list safe against removal
of entries. Here, no entries are removed, so use list_for_each_entry.
Signed-off-by: Sascha Hauer
---
drivers/gpu/drm/drm_crtc_helper.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/
The fb helper uses fixed size arrays for the associated crtcs.
This is an unnecessary limitation, so instead use a list to
store the crtcs and allocate them dynamically.
Signed-off-by: Sascha Hauer
---
drivers/gpu/drm/drm_fb_helper.c | 129 ---
include/drm/dr
to add the missing drm_mode_object_put for that mode.
Signed-off-by: Sascha Hauer
---
drivers/gpu/drm/drm_edid.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index ece03fc..770d894 100644
--- a/drivers/gpu/drm/d
drm_fb_helper_on|off currently manually searches for encoders
to turn on/off. Make this simpler by using the helper function.
Signed-off-by: Sascha Hauer
---
drivers/gpu/drm/drm_fb_helper.c | 80 +--
1 files changed, 10 insertions(+), 70 deletions(-)
diff -
crtc_id is set but never used, so remove it from struct
drm_fb_helper_crtc.
Signed-off-by: Sascha Hauer
---
drivers/gpu/drm/drm_fb_helper.c |1 -
include/drm/drm_fb_helper.h |1 -
2 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers
info->fix.visual already is correctly set from drm_fb_helper_fill_fix.
info->fix.line_length is also set from drm_fb_helper_fill_fix,
so drm_fb_helper_set_par directly instead of a custom
exynos_drm_fbdev_set_par.
Signed-off-by: Sascha Hauer
Cc: Inki Dae
---
drivers/gpu/drm/exynos/exynos_drm_fb
As the crtcs are now allocated dynamically we don't need the
crtc_count parameter anymore.
Signed-off-by: Sascha Hauer
---
drivers/gpu/drm/drm_fb_helper.c |2 +-
drivers/gpu/drm/exynos/exynos_drm_fbdev.c |8 ++--
drivers/gpu/drm/gma500/framebuffer.c |3 +--
drivers
Storing the properties associated to a connector in a
list allows us to drop the current limitation on a
maximum number of properties per connector.
Signed-off-by: Sascha Hauer
---
drivers/gpu/drm/drm_crtc.c | 109 ---
include/drm/drm_crtc.h |5 +-
Creating a range property is a common pattern, so create
a convenience function for this and use it where appropriate.
Signed-off-by: Sascha Hauer
---
drivers/gpu/drm/drm_crtc.c| 69 -
drivers/gpu/drm/gma500/framebuffer.c |5 +--
drivers/gpu
The drm drivers set the fb_info->pixmap fields without setting
fb_info->pixmap.addr. If this is not set the fb core will overwrite
these all fb_info->pixmap fields anyway, so there is not much point
in setting them in the first place.
Signed-off-by: Sascha Hauer
---
drivers/gpu/drm/gma500/frameb
The drivers currently check in set_property whether the property is
unchanged. move this check into the core and do not bother the drivers
with checking for unchanged properties.
Signed-off-by: Sascha Hauer
---
drivers/gpu/drm/drm_crtc.c |5
drivers/gpu/drm/gma500/cdv_i
drm_mode_config_init initializes the idr with idr_init, so
add the missing counterparts in drm_mode_config_cleanup.
Signed-off-by: Sascha Hauer
---
drivers/gpu/drm/drm_crtc.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/d
Creating an enum property is a common pattern, so create
a convenience function for this and use it where appropriate.
Signed-off-by: Sascha Hauer
---
drivers/gpu/drm/drm_crtc.c| 100 +---
drivers/gpu/drm/i915/intel_modes.c| 28 +++-
drivers
If a property has changed successfully the core will call
drm_connector_property_set_value, so do not duplicate this
call in the drivers.
Signed-off-by: Sascha Hauer
---
drivers/gpu/drm/gma500/cdv_intel_hdmi.c |4
drivers/gpu/drm/gma500/cdv_intel_lvds.c | 23 ++-
d
The following patches contain some fixes and cleanups for the drm
core.
- fix memory holes
- make some initialization / deinitialization more symmetric
- add convenience functions for creating properties
- remove DRM_CONNECTOR_MAX_PROPERTY limitation
All patches tested on a GeForce 6200 LE with t
conn_limit is set but never used. Remove it from struct
drm_fb_helper.
Signed-off-by: Sascha Hauer
---
drivers/gpu/drm/drm_fb_helper.c |2 +-
include/drm/drm_fb_helper.h |1 -
2 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu
drm_setup_crtcs allocated modes using drm_mode_duplicate. Free
them in drm_fb_helper_crtc_free.
Signed-off-by: Sascha Hauer
---
drivers/gpu/drm/drm_fb_helper.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_he
From: Michel Dänzer
The value of this register is transferred to the V_COUNTER register at the
beginning of vertical blank. V_COUNTER is the reference for VLINE waits and
goes from VIEWPORT_Y_START to VIEWPORT_Y_START+VIEWPORT_HEIGHT during scanout,
so if VIEWPORT_Y_START is not 0, V_COUNTER actu
Christian,
You said elsewhere that you have half-finished patches that illustrate the
interface Jerome prefers - if you send them to me, I can work on finishing
them.
Responding to the rest of the message:
On Tuesday 31 January 2012, Jerome Glisse wrote:
> On Tue, Jan 31, 2012 at 01:55:43PM -05
On Wed, 1 Feb 2012 11:38:33 +0100, Sascha Hauer wrote:
> Creating a range property is a common pattern, so create
> a convenience function for this and use it where appropriate.
This is pure bikeshedding, but I would prefer
drm_property_create_range as the object being created is the
drm_propert
On Wed, 1 Feb 2012 11:38:32 +0100, Sascha Hauer wrote:
> Creating an enum property is a common pattern, so create
> a convenience function for this and use it where appropriate.
Similar naming comments apply as for drm_property_create_range. However,
I did spot something anomalous...
> diff --g
On Wed, Feb 01, 2012 at 11:48:53AM +, Chris Wilson wrote:
> On Wed, 1 Feb 2012 11:38:32 +0100, Sascha Hauer
> wrote:
> > Creating an enum property is a common pattern, so create
> > a convenience function for this and use it where appropriate.
>
> Similar naming comments apply as for drm_pr
On Wed, 1 Feb 2012 11:38:35 +0100, Sascha Hauer wrote:
> The drivers currently check in set_property whether the property is
> unchanged. move this check into the core and do not bother the drivers
> with checking for unchanged properties.
This patch seems to have functional side-effects beyond
On Wed, 1 Feb 2012 11:38:38 +0100, Sascha Hauer wrote:
> The drm drivers set the fb_info->pixmap fields without setting
> fb_info->pixmap.addr. If this is not set the fb core will overwrite
> these all fb_info->pixmap fields anyway, so there is not much point
> in setting them in the first place.
On Wed, Feb 01, 2012 at 11:55:44AM +, Chris Wilson wrote:
> On Wed, 1 Feb 2012 11:38:35 +0100, Sascha Hauer
> wrote:
> > The drivers currently check in set_property whether the property is
> > unchanged. move this check into the core and do not bother the drivers
> > with checking for unchan
Instead of busywaiting for the GPU to finish a fence, use the new kernel
interface to wait for fence completion.
If the new kernel interface is unavailable, fall back to busywaiting.
Signed-off-by: Simon Farnsworth
---
This is simply addressing Michel's review comments against the v1 patch.
The
On Wed, 1 Feb 2012 13:13:44 +0100, Sascha Hauer wrote:
> On Wed, Feb 01, 2012 at 11:55:44AM +, Chris Wilson wrote:
> > On Wed, 1 Feb 2012 11:38:35 +0100, Sascha Hauer
> > wrote:
> > > The drivers currently check in set_property whether the property is
> > > unchanged. move this check into t
Userspace currently busywaits for fences to complete; on my workload, this
busywait consumes 10% of the available CPU time.
Provide an ioctl so that userspace can wait for an EOP interrupt that
corresponds to a previous EVENT_WRITE_EOP.
Signed-off-by: Simon Farnsworth
---
There's debate ongoing
- Original Message -
> From: "Chris Wilson"
> To: "Sascha Hauer" , dri-devel@lists.freedesktop.org
> Cc: ker...@pengutronix.de
> Sent: Wednesday, 1 February, 2012 11:48:53 AM
> Subject: Re: [PATCH 14/20] drm: add convenience function to create an enum
> property
>
> On Wed, 1 Feb 2
On Wed, Feb 01, 2012 at 07:55:40AM -0500, David Airlie wrote:
>
>
> > > diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
> > > index 8d593ad..cdbbb40 100644
> > > --- a/include/drm/drm_crtc.h
> > > +++ b/include/drm/drm_crtc.h
> > > @@ -394,7 +394,7 @@ struct drm_crtc {
> > > s64 fr
2012/2/1 Michel Dänzer :
> On Die, 2012-01-31 at 22:08 +0100, Marek Olšák wrote:
>> 2012/1/31 Jerome Glisse :
>> > On Tue, Jan 31, 2012 at 06:56:01PM +0100, Michel Dänzer wrote:
>> >> On Die, 2012-01-31 at 16:59 +, Simon Farnsworth wrote:
>> >> > Userspace currently busywaits for fences to comp
On Wed, Feb 01, 2012 at 02:05:38PM +0100, Sascha Hauer wrote:
> On Wed, Feb 01, 2012 at 07:55:40AM -0500, David Airlie wrote:
> >
> >
> > > > diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
> > > > index 8d593ad..cdbbb40 100644
> > > > --- a/include/drm/drm_crtc.h
> > > > +++ b/inclu
2012/2/1 Michel Dänzer :
> From: Michel Dänzer
>
> The value of this register is transferred to the V_COUNTER register at the
> beginning of vertical blank. V_COUNTER is the reference for VLINE waits and
> goes from VIEWPORT_Y_START to VIEWPORT_Y_START+VIEWPORT_HEIGHT during scanout,
> so if VIEWP
On Tue, Jan 31, 2012 at 8:06 PM, Seth Forshee
wrote:
> On Fri, Jan 20, 2012 at 05:08:31PM -0600, Seth Forshee wrote:
>> > Can you track down who is calling the connector->detect() callbacks
>> > during suspend and resume?
>>
>> I got two different stack traces, see below.
>>
>> And to slightly ame
r300g is able to sleep until a fence completes rather than busywait because
it creates a special buffer object and relocation that stays busy until the
CS containing the fence is finished.
Copy the idea into r600g, and use it to sleep if the user asked for an
infinite wait, falling back to busywai
On Wednesday 1 February 2012, Simon Farnsworth
wrote:
> This is a userspace only fix for my problem, as suggested by Mark Olšák. It
My apologies, Marek; my typing appears to have failed me, and renamed you to
Mark. I shall try not to make that mistake again.
--
Simon Farnsworth
Software Enginee
https://bugs.freedesktop.org/show_bug.cgi?id=45503
Bug #: 45503
Summary: [drm:radeon_get_bios] *ERROR* Unable to locate a BIOS
ROM
Classification: Unclassified
Product: DRI
Version: unspecified
Platform: x86-64 (AMD64)
https://bugs.freedesktop.org/show_bug.cgi?id=45503
--- Comment #1 from mlam...@gmail.com 2012-02-01 07:57:27 PST ---
Created attachment 56456
--> https://bugs.freedesktop.org/attachment.cgi?id=56456
dmesg with kernel 3.3-rc2
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=
https://bugs.freedesktop.org/show_bug.cgi?id=45503
--- Comment #2 from Alex Deucher 2012-02-01 08:14:14 PST ---
Please make sure pci quirks are enabled in your kernel config. If it still
doesn't work with that enabled, can you bisect?
--
Configure bugmail: https://bugs.freedesktop.org/userpref
Polling the outputs when the device is suspended can result in erroneous
status updates. Disable output polling during suspend to prevent this
from happening.
Signed-off-by: Seth Forshee
Reviewed-by: Alex Deucher
Cc: sta...@vger.kernel.org
---
drivers/gpu/drm/radeon/radeon_device.c |4
https://bugs.freedesktop.org/show_bug.cgi?id=45503
--- Comment #3 from mlam...@gmail.com 2012-02-01 08:35:41 PST ---
Do you mean this option: CONFIG_PCI_QUIRKS=y ? It is enabled in my kernel
config.
I'm sorry, but I have never bisected a kernel bug before and I don't know the
kernel source very w
If a blit copy operation specifies a rectangle whose one dimension
is 16384 (max allowed by these chips), the chip will silently
drop all commands. Fixed by reducing the maximum dimension by
one rectangle unit size. In the mainline kernel, the problem is
exposed only when buffers are very large (1G
R600/700 and Evergreen/NI blit code have a few redundant
definitions in respective .c file. Move common definitions
into a separate (new) .h file.
Signed-off-by: Ilija Hadzic
---
drivers/gpu/drm/radeon/evergreen_blit_kms.c | 12 +---
drivers/gpu/drm/radeon/r600_blit_kms.c | 15 +
https://bugs.freedesktop.org/show_bug.cgi?id=41569
--- Comment #22 from Alex Deucher 2012-02-01 08:50:16 PST ---
Created attachment 56457
--> https://bugs.freedesktop.org/attachment.cgi?id=56457
fix travis setup
Does this patch do the right thing for everyone's platform? Patch should apply
ag
https://bugs.freedesktop.org/show_bug.cgi?id=45503
--- Comment #4 from Dave Airlie 2012-02-01 09:02:31
PST ---
Its most likely one of
211fa4fc4e13492151e698d92b0dff56b29928ec
a3f83ab1a717c0e6c2f59a4cfdaa10707cc35c55
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
-
Hello,
We're trying to use R600 DRM driver with big endian architecture. We
find the following error in R600 definition of interrupt handler swap.
Perhaps there's the same error in the evergreen definitions header file.
Cedric
Signed-off-by: Cédric Cano
Signed-off-by: Thomas Jourdan
---
di
[ Dropping dri-devel list ]
On Mit, 2012-02-01 at 15:01 +, Simon Farnsworth wrote:
> r300g is able to sleep until a fence completes rather than busywait because
> it creates a special buffer object and relocation that stays busy until the
> CS containing the fence is finished.
>
> Copy the i
On Mit, 2012-02-01 at 11:42 -0500, Ilija Hadzic wrote:
> If a blit copy operation specifies a rectangle whose one dimension
> is 16384 (max allowed by these chips), the chip will silently
> drop all commands.
What exactly does 'silently drop all commands' mean?
Did you notice the following in i2
On 01.02.2012 12:31, Simon Farnsworth wrote:
Christian,
You said elsewhere that you have half-finished patches that illustrate the
interface Jerome prefers - if you send them to me, I can work on finishing
them.
Responding to the rest of the message:
Well it's probably easier to type that down
https://bugs.freedesktop.org/show_bug.cgi?id=45503
--- Comment #5 from mlam...@gmail.com 2012-02-01 10:25:18 PST ---
Commit a3f83ab1a717c0e6c2f59a4cfdaa10707cc35c55 works, commit
211fa4fc4e13492151e698d92b0dff56b29928ec doesn't.
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?ta
https://bugs.freedesktop.org/show_bug.cgi?id=45503
--- Comment #6 from mlam...@gmail.com 2012-02-01 10:26:12 PST ---
Created attachment 56461
--> https://bugs.freedesktop.org/attachment.cgi?id=56461
dmesg with commit 211fa4f...
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?t
https://bugs.freedesktop.org/show_bug.cgi?id=45503
--- Comment #7 from mlam...@gmail.com 2012-02-01 10:26:45 PST ---
Created attachment 56462
--> https://bugs.freedesktop.org/attachment.cgi?id=56462
dmesg with commit a3f83ab...
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?t
On Tue, Jan 24, 2012 at 2:10 PM, Alex Deucher wrote:
> On Sun, Jan 22, 2012 at 9:43 AM, Igor Murzov
> wrote:
>> From 77c912ea1eca50a93a34d5be69f9dc96a8bef0d8 Mon Sep 17 00:00:00 2001
>> From: Igor Murzov
>> Date: Sun, 22 Jan 2012 19:02:27 +0400
>> Subject: [PATCH 1/2] drm/radeon: fix invalid mem
On Wed, 1 Feb 2012, Michel [ISO-8859-1] D�nzer wrote:
On Mit, 2012-02-01 at 11:42 -0500, Ilija Hadzic wrote:
If a blit copy operation specifies a rectangle whose one dimension
is 16384 (max allowed by these chips), the chip will silently
drop all commands.
What exactly does 'silently drop a
https://bugs.freedesktop.org/show_bug.cgi?id=41569
--- Comment #23 from Robert Nelson 2012-02-01
11:26:37 PST ---
Alex,
The patch (in comment 22) on top of v3.2.2 works fine with kms on my Asus
a53t..
Regards,
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
---
On Wed, Feb 1, 2012 at 4:33 AM, Cédric Cano wrote:
> Hello,
>
> We're trying to use R600 DRM driver with big endian architecture. We find
> the following error in R600 definition of interrupt handler swap.
>
> Perhaps there's the same error in the evergreen definitions header file.
The definition
On Mon, Jan 30, 2012 at 15:25:20 -0800, Jeremy Huddleston wrote:
> This fixes a failure in 'make check' found by the tinderbox when trying to
> build this code on Linux/ppc. This code is only designed to run on
> Intel platforms, so don't even bother building it if we're not in that set.
>
> Fou
https://bugs.freedesktop.org/show_bug.cgi?id=45503
--- Comment #8 from Dave Airlie 2012-02-01 12:49:24
PST ---
Created attachment 56468
--> https://bugs.freedesktop.org/attachment.cgi?id=56468
debugging patch
this is a debugging patch to apply on top of 3.3-rc2
can you get the dmesg with it
https://bugs.freedesktop.org/show_bug.cgi?id=44955
--- Comment #4 from Florian Mickler 2012-02-01 13:14:20
PST ---
A patch referencing this bug report has been merged in Linux v3.3-rc2:
commit 3a47824d85eeca122895646f027dc63480994199
Author: Alex Deucher
Date: Fri Jan 20 15:01:30 2012 -0500
https://bugs.freedesktop.org/show_bug.cgi?id=44955
Seth Forshee changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
https://bugs.freedesktop.org/show_bug.cgi?id=45503
--- Comment #9 from mlam...@gmail.com 2012-02-01 13:40:08 PST ---
Created attachment 56474
--> https://bugs.freedesktop.org/attachment.cgi?id=56474
dmesg with debug patch
Here's the dmesg output with your debugging patch applied.
--
Configure
On Wed, Feb 1, 2012 at 13:01:58 -0800, Jeremy Huddleston wrote:
> yeah, that's probably cleaner (I guess it'll avoid the -*), but it should
> have the same effect.
>
I get host_os=linux-gnu here afaict, so not really the same effect, no.
Cheers,
Julien
_
On 02/ 1/12 01:56 PM, Julien Cristau wrote:
On Wed, Feb 1, 2012 at 13:01:58 -0800, Jeremy Huddleston wrote:
yeah, that's probably cleaner (I guess it'll avoid the -*), but it should have
the same effect.
I get host_os=linux-gnu here afaict, so not really the same effect, no.
Jeremy was pr
Evergreen and NI blit copy was broken if the buffer maps to a rectangle
whose one dimension is 16384 (max dimension allowed by these chips).
In the mainline kernel, the problem is exposed only when buffers are
very large (1G), but it's still a problem. The problem could be exposed
for smaller buffe
https://bugs.freedesktop.org/show_bug.cgi?id=38010
--- Comment #7 from darkbasic 2012-02-01 14:44:30
PST ---
It does work with radeon.audio=1 and 3.2.2 :)
Thanks,
Darkbasic
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because:
Hi,
I plan to do a libdrm release on friday because ddx/mesa work i have
been doing depends on thing i added to libdrm/radeon. Is anybody else
working on some libdrm related code that would need a release ?
I can hold off the release a bit but i would really like not to.
Cheers,
Jerome
_
> -Original Message-
> From: Sascha Hauer [mailto:s.ha...@pengutronix.de]
> Sent: Wednesday, February 01, 2012 7:39 PM
> To: dri-devel@lists.freedesktop.org
> Cc: ker...@pengutronix.de; Sascha Hauer; Inki Dae
> Subject: [PATCH 19/20] drm exynos: use drm_fb_helper_set_par directly
>
> inf
https://bugzilla.kernel.org/show_bug.cgi?id=42716
Summary: Boot failure with KMS enabled (radeon)
Product: Drivers
Version: 2.5
Kernel Version: 3.2.x
Platform: All
OS/Version: Linux
Tree: Mainline
Status: NEW
Hi,
I've been trying all day to sync sources from anongit.freedesktop.org
(dri and mesa) and it always ends up by a time out. Is there a problem
with the server or the address?
Cheers,
--
Alexandre Demers
___
dri-devel mailing list
dri-devel@lists.fr
On 02/ 1/12 08:52 PM, Alexandre Demers wrote:
Hi,
I've been trying all day to sync sources from anongit.freedesktop.org
(dri and mesa) and it always ends up by a time out. Is there a problem
with the server or the address?
Yes. Others have reported on IRC that it works if you force the hostna
Modes are created using drm_mode_create which does a
drm_mode_object_get, so use drm_mode_destroy in drm_mode_remove
which does a drm_mode_object_put.
Signed-off-by: Sascha Hauer
---
drivers/gpu/drm/drm_crtc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/
Several comments above functions say that the caller must hold the
mode_config lock, but the functions take the lock themselves. Fix
the comments.
Signed-off-by: Sascha Hauer
---
drivers/gpu/drm/drm_crtc.c | 21 +++--
1 files changed, 15 insertions(+), 6 deletions(-)
diff --gi
drm_mode_crtc_set_gamma_size returns boolean true for success
and false for failure. This is not very kernel conform, so
change it to return 0 for success and a propert error code
otherwise. Noone checks the return value, so no users have to
be fixed.
Signed-off-by: Sascha Hauer
---
drivers/gpu/
drm_fb_helper_single_add_all_connectors is always called in
conjunction with drm_fb_helper_initial_config, so call
drm_fb_helper_single_add_all_connectors inside
drm_fb_helper_initial_config and make
drm_fb_helper_single_add_all_connectors static.
Signed-off-by: Sascha Hauer
---
drivers/gpu/drm/
list_for_each_entry_safe is for walking a list safe against removal
of entries. Here, no entries are removed, so use list_for_each_entry.
Signed-off-by: Sascha Hauer
---
drivers/gpu/drm/drm_crtc_helper.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/
The fb helper uses fixed size arrays for the associated crtcs.
This is an unnecessary limitation, so instead use a list to
store the crtcs and allocate them dynamically.
Signed-off-by: Sascha Hauer
---
drivers/gpu/drm/drm_fb_helper.c | 129 ---
include/drm/dr
to add the missing drm_mode_object_put for that mode.
Signed-off-by: Sascha Hauer
---
drivers/gpu/drm/drm_edid.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index ece03fc..770d894 100644
--- a/drivers/gpu/drm/d
drm_fb_helper_on|off currently manually searches for encoders
to turn on/off. Make this simpler by using the helper function.
Signed-off-by: Sascha Hauer
---
drivers/gpu/drm/drm_fb_helper.c | 80 +--
1 files changed, 10 insertions(+), 70 deletions(-)
diff -
crtc_id is set but never used, so remove it from struct
drm_fb_helper_crtc.
Signed-off-by: Sascha Hauer
---
drivers/gpu/drm/drm_fb_helper.c |1 -
include/drm/drm_fb_helper.h |1 -
2 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers
info->fix.visual already is correctly set from drm_fb_helper_fill_fix.
info->fix.line_length is also set from drm_fb_helper_fill_fix,
so drm_fb_helper_set_par directly instead of a custom
exynos_drm_fbdev_set_par.
Signed-off-by: Sascha Hauer
Cc: Inki Dae
---
drivers/gpu/drm/exynos/exynos_drm_fb
As the crtcs are now allocated dynamically we don't need the
crtc_count parameter anymore.
Signed-off-by: Sascha Hauer
---
drivers/gpu/drm/drm_fb_helper.c |2 +-
drivers/gpu/drm/exynos/exynos_drm_fbdev.c |8 ++--
drivers/gpu/drm/gma500/framebuffer.c |3 +--
drivers
Storing the properties associated to a connector in a
list allows us to drop the current limitation on a
maximum number of properties per connector.
Signed-off-by: Sascha Hauer
---
drivers/gpu/drm/drm_crtc.c | 109 ---
include/drm/drm_crtc.h |5 +-
Creating a range property is a common pattern, so create
a convenience function for this and use it where appropriate.
Signed-off-by: Sascha Hauer
---
drivers/gpu/drm/drm_crtc.c| 69 -
drivers/gpu/drm/gma500/framebuffer.c |5 +--
drivers/gpu
The drm drivers set the fb_info->pixmap fields without setting
fb_info->pixmap.addr. If this is not set the fb core will overwrite
these all fb_info->pixmap fields anyway, so there is not much point
in setting them in the first place.
Signed-off-by: Sascha Hauer
---
drivers/gpu/drm/gma500/frameb
The drivers currently check in set_property whether the property is
unchanged. move this check into the core and do not bother the drivers
with checking for unchanged properties.
Signed-off-by: Sascha Hauer
---
drivers/gpu/drm/drm_crtc.c |5
drivers/gpu/drm/gma500/cdv_i
drm_mode_config_init initializes the idr with idr_init, so
add the missing counterparts in drm_mode_config_cleanup.
Signed-off-by: Sascha Hauer
---
drivers/gpu/drm/drm_crtc.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/d
Creating an enum property is a common pattern, so create
a convenience function for this and use it where appropriate.
Signed-off-by: Sascha Hauer
---
drivers/gpu/drm/drm_crtc.c| 100 +---
drivers/gpu/drm/i915/intel_modes.c| 28 +++-
drivers
If a property has changed successfully the core will call
drm_connector_property_set_value, so do not duplicate this
call in the drivers.
Signed-off-by: Sascha Hauer
---
drivers/gpu/drm/gma500/cdv_intel_hdmi.c |4
drivers/gpu/drm/gma500/cdv_intel_lvds.c | 23 ++-
d
The following patches contain some fixes and cleanups for the drm
core.
- fix memory holes
- make some initialization / deinitialization more symmetric
- add convenience functions for creating properties
- remove DRM_CONNECTOR_MAX_PROPERTY limitation
All patches tested on a GeForce 6200 LE with t
conn_limit is set but never used. Remove it from struct
drm_fb_helper.
Signed-off-by: Sascha Hauer
---
drivers/gpu/drm/drm_fb_helper.c |2 +-
include/drm/drm_fb_helper.h |1 -
2 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu
drm_setup_crtcs allocated modes using drm_mode_duplicate. Free
them in drm_fb_helper_crtc_free.
Signed-off-by: Sascha Hauer
---
drivers/gpu/drm/drm_fb_helper.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_he
From: Michel D?nzer
The value of this register is transferred to the V_COUNTER register at the
beginning of vertical blank. V_COUNTER is the reference for VLINE waits and
goes from VIEWPORT_Y_START to VIEWPORT_Y_START+VIEWPORT_HEIGHT during scanout,
so if VIEWPORT_Y_START is not 0, V_COUNTER actu
int64_ttimeout_usec;
> >
> > Align things here, 64 then 64 then 32 32 32 and a 32 pad.
> >
Will do in v2.
--
Simon Farnsworth
Software Engineer
ONELAN Limited
http://www.onelan.com/
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20120201/91602f15/attachment.pgp>
On Wed, 1 Feb 2012 11:38:33 +0100, Sascha Hauer
wrote:
> Creating a range property is a common pattern, so create
> a convenience function for this and use it where appropriate.
This is pure bikeshedding, but I would prefer
drm_property_create_range as the object being created is the
drm_proper
On Wed, 1 Feb 2012 11:38:32 +0100, Sascha Hauer
wrote:
> Creating an enum property is a common pattern, so create
> a convenience function for this and use it where appropriate.
Similar naming comments apply as for drm_property_create_range. However,
I did spot something anomalous...
> diff --
1 - 100 of 158 matches
Mail list logo
