Hi Linus,
just a small fix for a possible oops in radeon.
Dave.
The following changes since commit 115e8e705e4be071b9e06ff72578e3b603f2ba65:
Merge branch 'devicetree/merge' of git://git.secretlab.ca/git/linux-2.6
(2012-01-02 12:34:03 -0800)
are available in the git repository at:
git://
https://bugs.freedesktop.org/show_bug.cgi?id=38473
--- Comment #10 from Michel Dänzer 2012-01-03 04:04:58 PST
---
(In reply to comment #9)
> Just tried to verify this for you
Not for me. I asked because it seems to work for me with upstream Git. I just
verified again it still does.
> with cur
https://bugs.freedesktop.org/show_bug.cgi?id=44422
Bug #: 44422
Summary: periodic slowdowns in every 30sec
Classification: Unclassified
Product: Mesa
Version: git
Platform: Other
OS/Version: All
Status: NEW
S
https://bugs.freedesktop.org/show_bug.cgi?id=44422
--- Comment #1 from Alex Deucher 2012-01-03 06:21:29 PST ---
Please attach your xorg log, dmesg output, and glxinfo output. If it happens
every 30 seconds, it may be your desktop environment polling the connectors on
your video card to see what
On Mon, Jan 2, 2012 at 5:07 PM, Helge Deller wrote:
> I'm facing the problem with the radeon drm driver, that I now manually need
> to set the kernel module parameter radeon.no_wb to 1 at bootup, else X just
> hangs in average up to 8 seconds per minute without any real activity (X or
> the video
From: Alex Deucher
We often end up missing fences on older asics with
writeback enabled which leads to delays in the userspace
accel code, so just disable it by default on those asics.
Reported-by: Helge Deller
Reported-by: Dave Airlie
Signed-off-by: Alex Deucher
Cc: sta...@vger.kernel.org
--
https://bugs.freedesktop.org/show_bug.cgi?id=44422
--- Comment #2 from almos 2012-01-03 07:02:44 PST ---
Created attachment 55083
--> https://bugs.freedesktop.org/attachment.cgi?id=55083
dmesg
Hmmm... I haven't noticed there are so many call traces in dmesg. Disturbing.
--
Configure bugmail:
https://bugs.freedesktop.org/show_bug.cgi?id=44422
--- Comment #3 from almos 2012-01-03 07:03:33 PST ---
Created attachment 55084
--> https://bugs.freedesktop.org/attachment.cgi?id=55084
Xorg.0.log
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are rece
https://bugs.freedesktop.org/show_bug.cgi?id=44422
--- Comment #4 from almos 2012-01-03 07:05:17 PST ---
Created attachment 55085
--> https://bugs.freedesktop.org/attachment.cgi?id=55085
glxinfo
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receivi
https://bugs.freedesktop.org/show_bug.cgi?id=42131
--- Comment #1 from ikrabbe@gmail.com 2012-01-03 07:05:34 PST ---
I can confirm this bug. It seems that there are some internal events, forwarded
to the DRI(2) module that get lost, as xcb doesn't use XEvents. That's why it
works, when you use
https://bugs.freedesktop.org/show_bug.cgi?id=42131
Alex Deucher changed:
What|Removed |Added
AssignedTo|dri-devel@lists.freedesktop |mesa-dev@lists.freedesktop.
https://bugs.freedesktop.org/show_bug.cgi?id=44422
--- Comment #5 from Alex Deucher 2012-01-03 07:18:22 PST ---
Does disabling output polling in your desktop environment fix the issue? Try
killing upowerd or knotify.
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--
From: Alex Deucher
vbios is missing a ddc entry for the DVI-D port.
Reported by ponyofdeath on IRC.
Signed-off-by: Alex Deucher
Cc: sta...@vger.kernel.org
---
drivers/gpu/drm/radeon/radeon_combios.c |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/dr
Sorry, ignore this one for now.
Alex
On Tue, Jan 3, 2012 at 11:19 AM, wrote:
> From: Alex Deucher
>
> vbios is missing a ddc entry for the DVI-D port.
> Reported by ponyofdeath on IRC.
>
> Signed-off-by: Alex Deucher
> Cc: sta...@vger.kernel.org
> ---
> drivers/gpu/drm/radeon/radeon_combios.
https://bugs.freedesktop.org/show_bug.cgi?id=44422
--- Comment #6 from almos 2012-01-03 09:06:19 PST ---
(In reply to comment #5)
> Does disabling output polling in your desktop environment fix the issue? Try
> killing upowerd or knotify.
I killed both, but the issue remains. How can I disable
https://bugs.freedesktop.org/show_bug.cgi?id=44422
--- Comment #7 from Alex Deucher 2012-01-03 09:24:43 PST ---
I'm not sure off hand. You might try some of these instructions:
http://linux-tipps.blogspot.com/2009/03/fixing-high-latency-with-kde4-display.html
Alternatively, you could try startin
From: Michel Dänzer
It can be called from atomic context, e.g. when switching to console for panic
output.
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=43941
Signed-off-by: Michel Dänzer
---
drivers/gpu/drm/radeon/atom.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff
https://bugs.freedesktop.org/show_bug.cgi?id=43941
--- Comment #14 from Michel Dänzer 2012-01-03 10:07:36 PST
---
(In reply to comment #13)
> Yes, this fixes the hang after and MCE, and it shows the error log on the
> screen.
Great, thanks for testing. Note that in general a bug report shouldn'
On Tue, 3 Jan 2012 19:04:00 +0100
Michel Dänzer wrote:
> From: Michel Dänzer
>
> It can be called from atomic context, e.g. when switching to console for panic
> output.
Is this only special cases like a panic - if so can it not be called in a
way that distinguishes between normality and nast
2012/1/3 Michel Dänzer :
> From: Michel Dänzer
>
> It can be called from atomic context, e.g. when switching to console for panic
> output.
>
> Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=43941
I wonder how ugly it would be to check for atomic context or not,
mdelay is quite a long busy d
On Die, 2012-01-03 at 18:09 +, Dave Airlie wrote:
> 2012/1/3 Michel Dänzer :
> > From: Michel Dänzer
> >
> > It can be called from atomic context, e.g. when switching to console for
> > panic
> > output.
> >
> > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=43941
>
> I wonder how ugly
On Die, 2012-01-03 at 18:09 +, Alan Cox wrote:
> On Tue, 3 Jan 2012 19:04:00 +0100
> Michel Dänzer wrote:
>
> > From: Michel Dänzer
> >
> > It can be called from atomic context, e.g. when switching to console for
> > panic
> > output.
>
> Is this only special cases like a panic - if so
https://bugs.freedesktop.org/show_bug.cgi?id=44365
--- Comment #4 from Michel Dänzer 2012-01-03 10:31:35 PST
---
(In reply to comment #3)
> Whilst much improved, there are frequent rendering glitches still.
Are those glitches a subset of the original ones, or new ones?
If the former, feel free
https://bugs.freedesktop.org/show_bug.cgi?id=44425
Bug #: 44425
Summary: Missing textures not being rendered in planeshift
game.
Classification: Unclassified
Product: Mesa
Version: git
Platform: Other
OS/Versio
https://bugs.freedesktop.org/show_bug.cgi?id=44405
Michel Dänzer changed:
What|Removed |Added
AssignedTo|dri-devel@lists.freedesktop |mesa-dev@lists.freedesktop.
https://bugs.freedesktop.org/show_bug.cgi?id=44425
--- Comment #1 from Alex Deucher 2012-01-03 11:45:55 PST ---
If the game uses compressed textures, you will need to install libtxc_dxtn.
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this m
On Tue, Jan 03, 2012 at 07:16:25PM +0100, Michel Dänzer wrote:
> On Die, 2012-01-03 at 18:09 +, Dave Airlie wrote:
> > 2012/1/3 Michel Dänzer :
> > > From: Michel Dänzer
> > >
> > > It can be called from atomic context, e.g. when switching to console for
> > > panic
> > > output.
> > >
> > >
https://bugs.freedesktop.org/show_bug.cgi?id=44425
--- Comment #2 from Mark 2012-01-03 12:28:01 UTC
---
Thats it working now!
I wish there had been a way I could have discovered that, perhaps it should
load some other stock texture than a fully transparent, so its at least visible
in a non scr
https://bugs.freedesktop.org/show_bug.cgi?id=44425
Alex Deucher changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
https://bugs.freedesktop.org/show_bug.cgi?id=44422
almos changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
On Fri, Dec 23, 2011 at 03:22:35PM +0530, Semwal, Sumit wrote:
> Hi Konrad,
>
> On Tue, Dec 20, 2011 at 10:06 PM, Konrad Rzeszutek Wilk
> wrote:
> > On Mon, Dec 19, 2011 at 02:03:30PM +0530, Sumit Semwal wrote:
> >> This is the first step in defining a dma buffer sharing mechanism.
> >>
> >> A ne
https://bugs.freedesktop.org/show_bug.cgi?id=43719
--- Comment #2 from Jerome Glisse 2012-01-03 14:40:19
PST ---
Created attachment 55095
--> https://bugs.freedesktop.org/attachment.cgi?id=55095
Fix agp on top of ttm tt rework
Should fix the bug let me know
--
Configure bugmail: https://bug
On Fri, Dec 23, 2011 at 01:19:43AM +, James Simmons wrote:
>
> > > Hi!
> > >
> > > I updated the openchrome tree and while testing on the AGP system
> > > discovered some interesting problems with the new TTM changes. The
> > > problems center around the ttm_tt_[un]populate which I mode
On Tue, Jan 03, 2012 at 05:43:40PM -0500, Jerome Glisse wrote:
> On Fri, Dec 23, 2011 at 01:19:43AM +, James Simmons wrote:
> >
> > > > Hi!
> > > >
> > > > I updated the openchrome tree and while testing on the AGP system
> > > > discovered some interesting problems with the new TTM cha
On Tue, Jan 3, 2012 at 6:12 PM, Helge Deller wrote:
> On 01/03/2012 03:27 PM, Alex Deucher wrote:
>>
>> On Mon, Jan 2, 2012 at 5:07 PM, Helge Deller wrote:
>>>
>>> I'm facing the problem with the radeon drm driver, that I now manually
>>> need
>>> to set the kernel module parameter radeon.no_wb t
On Tue, 03 Jan 2012 19:25:46 +0100
Michel Dänzer wrote:
> On Die, 2012-01-03 at 18:09 +, Alan Cox wrote:
> > On Tue, 3 Jan 2012 19:04:00 +0100
> > Michel Dänzer wrote:
> >
> > > From: Michel Dänzer
> > >
> > > It can be called from atomic context, e.g. when switching to console for
> >
on_each_cpu() returns as its own return value the return value of
smp_call_function(). smp_call_function() in turn returns a hard
coded value of zero.
Some callers to on_each_cpu() waste cycles and bloat code space
by checking the return value to on_each_cpu(), probably for
historical reasons.
on_each_cpu always returns a hard coded return code of zero.
Removing all tests based on this return value saves run time
cycles for compares and code bloat for branches.
CC: Michal Nazarewicz
CC: David Airlie
CC: dri-devel@lists.freedesktop.org
---
drivers/gpu/drm/drm_cache.c |3 +--
1 fi
on_each_cpu returns the retunr value of smp_call_function
which is hard coded to 0.
Refactor on_each_cpu to a void function and the few callers
that check the return value to save compares and branches.
CC: Michal Nazarewicz
CC: David Airlie
CC: dri-devel@lists.freedesktop.org
CC: Benjamin Herr
On Tue, 03 Jan 2012 15:19:04 +0100, Gilad Ben-Yossef
wrote:
on_each_cpu() returns as its own return value the return value of
smp_call_function(). smp_call_function() in turn returns a hard
coded value of zero.
Some callers to on_each_cpu() waste cycles and bloat code space
by checking the ret
2012/1/3 Michal Nazarewicz :
> On Tue, 03 Jan 2012 15:19:04 +0100, Gilad Ben-Yossef
> wrote:
>>
>> on_each_cpu() returns as its own return value the return value of
>> smp_call_function(). smp_call_function() in turn returns a hard
>> coded value of zero.
>>
>> Some callers to on_each_cpu() waste
On 01/03/2012 03:27 PM, Alex Deucher wrote:
On Mon, Jan 2, 2012 at 5:07 PM, Helge Deller wrote:
I'm facing the problem with the radeon drm driver, that I now manually need
to set the kernel module parameter radeon.no_wb to 1 at bootup, else X just
hangs in average up to 8 seconds per minute wit
calc_mclk() returns zero on success and negative on failure but clk is
a u32.
Signed-off-by: Dan Carpenter
diff --git a/drivers/gpu/drm/nouveau/nv50_pm.c
b/drivers/gpu/drm/nouveau/nv50_pm.c
index 0393721..3508de9 100644
--- a/drivers/gpu/drm/nouveau/nv50_pm.c
+++ b/drivers/gpu/drm/nouveau/nv50_
https://bugs.freedesktop.org/show_bug.cgi?id=44405
Bug #: 44405
Summary: Spring RTS crashes using r600g (5670, Redwood), kernel
rejects relocations
Classification: Unclassified
Product: Mesa
Version: git
Platform: Othe
https://bugs.freedesktop.org/show_bug.cgi?id=44405
--- Comment #1 from Marcin Baczy?ski 2012-01-02 16:24:22
PST ---
Created attachment 55061
--> https://bugs.freedesktop.org/attachment.cgi?id=55061
glxinfo
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You
Hi Linus,
just a small fix for a possible oops in radeon.
Dave.
The following changes since commit 115e8e705e4be071b9e06ff72578e3b603f2ba65:
Merge branch 'devicetree/merge' of git://git.secretlab.ca/git/linux-2.6
(2012-01-02 12:34:03 -0800)
are available in the git repository at:
git://
https://bugs.freedesktop.org/show_bug.cgi?id=38473
--- Comment #10 from Michel D?nzer 2012-01-03 04:04:58
PST ---
(In reply to comment #9)
> Just tried to verify this for you
Not for me. I asked because it seems to work for me with upstream Git. I just
verified again it still does.
> with cur
https://bugs.freedesktop.org/show_bug.cgi?id=44422
Bug #: 44422
Summary: periodic slowdowns in every 30sec
Classification: Unclassified
Product: Mesa
Version: git
Platform: Other
OS/Version: All
Status: NEW
S
https://bugs.freedesktop.org/show_bug.cgi?id=44422
--- Comment #1 from Alex Deucher 2012-01-03 06:21:29 PST
---
Please attach your xorg log, dmesg output, and glxinfo output. If it happens
every 30 seconds, it may be your desktop environment polling the connectors on
your video card to see what
On Mon, Jan 2, 2012 at 5:07 PM, Helge Deller wrote:
> I'm facing the problem with the radeon drm driver, that I now manually need
> to set the kernel module parameter radeon.no_wb to 1 at bootup, else X just
> hangs in average up to 8 seconds per minute without any real activity (X or
> the video
From: Alex Deucher
We often end up missing fences on older asics with
writeback enabled which leads to delays in the userspace
accel code, so just disable it by default on those asics.
Reported-by: Helge Deller
Reported-by: Dave Airlie
Signed-off-by: Alex Deucher
Cc: stable at vger.kernel.org
https://bugs.freedesktop.org/show_bug.cgi?id=44422
--- Comment #2 from almos 2012-01-03 07:02:44 PST ---
Created attachment 55083
--> https://bugs.freedesktop.org/attachment.cgi?id=55083
dmesg
Hmmm... I haven't noticed there are so many call traces in dmesg. Disturbing.
--
Configure bugmail:
https://bugs.freedesktop.org/show_bug.cgi?id=44422
--- Comment #3 from almos 2012-01-03 07:03:33 PST ---
Created attachment 55084
--> https://bugs.freedesktop.org/attachment.cgi?id=55084
Xorg.0.log
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are rece
https://bugs.freedesktop.org/show_bug.cgi?id=44422
--- Comment #4 from almos 2012-01-03 07:05:17 PST ---
Created attachment 55085
--> https://bugs.freedesktop.org/attachment.cgi?id=55085
glxinfo
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receivi
https://bugs.freedesktop.org/show_bug.cgi?id=42131
--- Comment #1 from ikrabbe.ask at gmail.com 2012-01-03 07:05:34 PST ---
I can confirm this bug. It seems that there are some internal events, forwarded
to the DRI(2) module that get lost, as xcb doesn't use XEvents. That's why it
works, when you
https://bugs.freedesktop.org/show_bug.cgi?id=42131
Alex Deucher changed:
What|Removed |Added
AssignedTo|dri-devel at lists.freedesktop |mesa-dev at
lists.freedesktop.
https://bugs.freedesktop.org/show_bug.cgi?id=44422
--- Comment #5 from Alex Deucher 2012-01-03 07:18:22 PST
---
Does disabling output polling in your desktop environment fix the issue? Try
killing upowerd or knotify.
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
-
From: Alex Deucher
vbios is missing a ddc entry for the DVI-D port.
Reported by ponyofdeath on IRC.
Signed-off-by: Alex Deucher
Cc: stable at vger.kernel.org
---
drivers/gpu/drm/radeon/radeon_combios.c |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu
Sorry, ignore this one for now.
Alex
On Tue, Jan 3, 2012 at 11:19 AM, wrote:
> From: Alex Deucher
>
> vbios is missing a ddc entry for the DVI-D port.
> Reported by ponyofdeath on IRC.
>
> Signed-off-by: Alex Deucher
> Cc: stable at vger.kernel.org
> ---
> ?drivers/gpu/drm/radeon/radeon_combi
https://bugs.freedesktop.org/show_bug.cgi?id=44422
--- Comment #6 from almos 2012-01-03 09:06:19 PST ---
(In reply to comment #5)
> Does disabling output polling in your desktop environment fix the issue? Try
> killing upowerd or knotify.
I killed both, but the issue remains. How can I disable
https://bugs.freedesktop.org/show_bug.cgi?id=44422
--- Comment #7 from Alex Deucher 2012-01-03 09:24:43 PST
---
I'm not sure off hand. You might try some of these instructions:
http://linux-tipps.blogspot.com/2009/03/fixing-high-latency-with-kde4-display.html
Alternatively, you could try starti
From: Michel D?nzer
It can be called from atomic context, e.g. when switching to console for panic
output.
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=43941
Signed-off-by: Michel D?nzer
---
drivers/gpu/drm/radeon/atom.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff
https://bugs.freedesktop.org/show_bug.cgi?id=43941
--- Comment #14 from Michel D?nzer 2012-01-03 10:07:36
PST ---
(In reply to comment #13)
> Yes, this fixes the hang after and MCE, and it shows the error log on the
> screen.
Great, thanks for testing. Note that in general a bug report shouldn'
On Tue, 3 Jan 2012 19:04:00 +0100
Michel D?nzer wrote:
> From: Michel D?nzer
>
> It can be called from atomic context, e.g. when switching to console for panic
> output.
Is this only special cases like a panic - if so can it not be called in a
way that distinguishes between normality and nast
2012/1/3 Michel D?nzer :
> From: Michel D?nzer
>
> It can be called from atomic context, e.g. when switching to console for panic
> output.
>
> Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=43941
I wonder how ugly it would be to check for atomic context or not,
mdelay is quite a long busy d
On Die, 2012-01-03 at 18:09 +, Dave Airlie wrote:
> 2012/1/3 Michel D?nzer :
> > From: Michel D?nzer
> >
> > It can be called from atomic context, e.g. when switching to console for
> > panic
> > output.
> >
> > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=43941
>
> I wonder how ugly
On Die, 2012-01-03 at 18:09 +, Alan Cox wrote:
> On Tue, 3 Jan 2012 19:04:00 +0100
> Michel D?nzer wrote:
>
> > From: Michel D?nzer
> >
> > It can be called from atomic context, e.g. when switching to console for
> > panic
> > output.
>
> Is this only special cases like a panic - if so
https://bugs.freedesktop.org/show_bug.cgi?id=44365
--- Comment #4 from Michel D?nzer 2012-01-03 10:31:35
PST ---
(In reply to comment #3)
> Whilst much improved, there are frequent rendering glitches still.
Are those glitches a subset of the original ones, or new ones?
If the former, feel free
https://bugs.freedesktop.org/show_bug.cgi?id=44425
Bug #: 44425
Summary: Missing textures not being rendered in planeshift
game.
Classification: Unclassified
Product: Mesa
Version: git
Platform: Other
OS/Versio
https://bugs.freedesktop.org/show_bug.cgi?id=44405
Michel D?nzer changed:
What|Removed |Added
AssignedTo|dri-devel at lists.freedesktop |mesa-dev at
lists.freedesktop.
https://bugs.freedesktop.org/show_bug.cgi?id=44425
--- Comment #1 from Alex Deucher 2012-01-03 11:45:55 PST
---
If the game uses compressed textures, you will need to install libtxc_dxtn.
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this
On Tue, Jan 03, 2012 at 07:16:25PM +0100, Michel D?nzer wrote:
> On Die, 2012-01-03 at 18:09 +, Dave Airlie wrote:
> > 2012/1/3 Michel D?nzer :
> > > From: Michel D?nzer
> > >
> > > It can be called from atomic context, e.g. when switching to console for
> > > panic
> > > output.
> > >
> > >
https://bugs.freedesktop.org/show_bug.cgi?id=44425
--- Comment #2 from Mark 2012-01-03 12:28:01
UTC ---
Thats it working now!
I wish there had been a way I could have discovered that, perhaps it should
load some other stock texture than a fully transparent, so its at least visible
in a non scr
https://bugs.freedesktop.org/show_bug.cgi?id=44425
Alex Deucher changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
https://bugs.freedesktop.org/show_bug.cgi?id=44422
almos changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
On Fri, Dec 23, 2011 at 03:22:35PM +0530, Semwal, Sumit wrote:
> Hi Konrad,
>
> On Tue, Dec 20, 2011 at 10:06 PM, Konrad Rzeszutek Wilk
> wrote:
> > On Mon, Dec 19, 2011 at 02:03:30PM +0530, Sumit Semwal wrote:
> >> This is the first step in defining a dma buffer sharing mechanism.
> >>
> >> A ne
https://bugs.freedesktop.org/show_bug.cgi?id=43719
--- Comment #2 from Jerome Glisse 2012-01-03
14:40:19 PST ---
Created attachment 55095
--> https://bugs.freedesktop.org/attachment.cgi?id=55095
Fix agp on top of ttm tt rework
Should fix the bug let me know
--
Configure bugmail: https://bug
On Fri, Dec 23, 2011 at 01:19:43AM +, James Simmons wrote:
>
> > > Hi!
> > >
> > > ? ? ? ?I updated the openchrome tree and while testing on the AGP system
> > > discovered some interesting problems with the new TTM changes. The
> > > problems center around the ttm_tt_[un]populate which I mode
ttm tt rework modified the way we allocate and populate the
ttm_tt structure, the AGP side was missing some bit to properly
work. Fix those and fix radeon and nouveau AGP support.
Tested on radeon only so far.
Signed-off-by: Jerome Glisse
---
drivers/gpu/drm/nouveau/nouveau_bo.c | 13 +++
On Tue, Jan 03, 2012 at 05:43:40PM -0500, Jerome Glisse wrote:
> On Fri, Dec 23, 2011 at 01:19:43AM +, James Simmons wrote:
> >
> > > > Hi!
> > > >
> > > > ? ? ? ?I updated the openchrome tree and while testing on the AGP system
> > > > discovered some interesting problems with the new TTM cha
On Tue, Jan 3, 2012 at 6:12 PM, Helge Deller wrote:
> On 01/03/2012 03:27 PM, Alex Deucher wrote:
>>
>> On Mon, Jan 2, 2012 at 5:07 PM, Helge Deller ?wrote:
>>>
>>> I'm facing the problem with the radeon drm driver, that I now manually
>>> need
>>> to set the kernel module parameter radeon.no_wb t
2012/1/3 Michal Nazarewicz :
> On Tue, 03 Jan 2012 15:19:04 +0100, Gilad Ben-Yossef
> wrote:
>>
>> on_each_cpu() returns as its own return value the return value of
>> smp_call_function(). smp_call_function() in turn returns a hard
>> coded value of zero.
>>
>> Some callers to on_each_cpu() waste
on_each_cpu() returns as its own return value the return value of
smp_call_function(). smp_call_function() in turn returns a hard
coded value of zero.
Some callers to on_each_cpu() waste cycles and bloat code space
by checking the return value to on_each_cpu(), probably for
historical reasons.
on_each_cpu always returns a hard coded return code of zero.
Removing all tests based on this return value saves run time
cycles for compares and code bloat for branches.
CC: Michal Nazarewicz
CC: David Airlie
CC: dri-devel at lists.freedesktop.org
---
drivers/gpu/drm/drm_cache.c |3 +--
1
on_each_cpu returns the retunr value of smp_call_function
which is hard coded to 0.
Refactor on_each_cpu to a void function and the few callers
that check the return value to save compares and branches.
CC: Michal Nazarewicz
CC: David Airlie
CC: dri-devel at lists.freedesktop.org
CC: Benjamin H
On Tue, 03 Jan 2012 15:19:04 +0100, Gilad Ben-Yossef
wrote:
> on_each_cpu() returns as its own return value the return value of
> smp_call_function(). smp_call_function() in turn returns a hard
> coded value of zero.
>
> Some callers to on_each_cpu() waste cycles and bloat code space
> by checkin
86 matches
Mail list logo