Re: [RFC libdrm] Use __sync_val_compare_and_swap to implement DRM_CAS

2010-10-29 Thread Michel Dänzer
On Don, 2010-10-28 at 19:59 -0400, Matt Turner wrote: > Can we use gcc's __sync_val_compare_and_swap to implement DRM_CAS? > (If so, do we actually need the __sync_val version, or can we use > __sync_bool?) > > I just threw the patch together in two minutes, so I've got no idea > if it's right, j

[Bug 28294] [r300g] Unigine Sanctuary v2.2: black glitches

2010-10-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=28294 --- Comment #51 from Pavel Ondračka 2010-10-29 00:55:52 PDT --- (In reply to comment #50) > In radeon_optimize.c starting at line 660, there are three optimization > functions: constant_folding, peephole, and copy_propagate. You could try > com

[Bug 31193] [regression] aa43176e break water reflections

2010-10-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=31193 --- Comment #2 from Fabio Pedretti 2010-10-29 01:37:42 PDT --- Created an attachment (id=39880) --> (https://bugs.freedesktop.org/attachment.cgi?id=39880) Correct rendering without aa43176e -- Configure bugmail: https://bugs.freedesktop.org/u

[Bug 31193] [regression] aa43176e break water reflections

2010-10-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=31193 --- Comment #3 from Fabio Pedretti 2010-10-29 01:38:11 PDT --- Created an attachment (id=39881) --> (https://bugs.freedesktop.org/attachment.cgi?id=39881) Broken rendering with aa43176e -- Configure bugmail: https://bugs.freedesktop.org/userp

[PATCH 0/6] Misc TTM patches for drm-next

2010-10-29 Thread Thomas Hellstrom
The patch series mainly contains minor optimizations and documentation, except for patch 5/6 which is really a bugfix, but the synchronization bug shouldn't affect x86 processors. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.fr

[PATCH 1/6] drm/ttm: Documentation update

2010-10-29 Thread Thomas Hellstrom
Remove an obsolete comment about mm nodes. Document the new bo range manager interface. Signed-off-by: Thomas Hellstrom --- drivers/gpu/drm/ttm/ttm_bo.c|8 include/drm/ttm/ttm_bo_driver.h | 79 -- 2 files changed, 74 insertions(+), 13 deletions(

[PATCH 2/6] drm/ttm: Use private locks for the default bo range manager

2010-10-29 Thread Thomas Hellstrom
Searching for a free block in the range manager may in some situations be a lenghty operation, and we want to avoid holding the global lru lock during that time. Instead use a per-manager spinlock. This leaves the global lru lock for quick lru list and swap list manipulation only, including list m

[PATCH 3/6] drm/ttm: Remove pointless list_empty check

2010-10-29 Thread Thomas Hellstrom
Signed-off-by: Thomas Hellstrom --- drivers/gpu/drm/ttm/ttm_bo.c |7 --- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index cf47978..e6cedf4 100644 --- a/drivers/gpu/drm/ttm/ttm_bo.c +++ b/drivers/gpu/drm/ttm/tt

[PATCH 4/6] drm/ttm: Remove mm init error printouts and checks

2010-10-29 Thread Thomas Hellstrom
Replace with BUG_ON(). These error messages remained from the time when TTM was initialized from user-space. Nowadays hitting one of those is really a kernel bug. Signed-off-by: Thomas Hellstrom --- drivers/gpu/drm/ttm/ttm_bo.c | 20 ++-- 1 files changed, 2 insertions(+), 18 de

[PATCH 5/6] drm/ttm: Add a barrier when unreserving

2010-10-29 Thread Thomas Hellstrom
Since we're doing this outside of a spinlock to provide the necessary barriers, add an explicit barrier. Signed-off-by: Thomas Hellstrom --- drivers/gpu/drm/ttm/ttm_bo.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/t

[PATCH 6/6] drm/ttm: remove failed ttm binding error printout

2010-10-29 Thread Thomas Hellstrom
The driver (for example vmwgfx) may want to silently deal with the error itself. Signed-off-by: Thomas Hellstrom --- drivers/gpu/drm/ttm/ttm_tt.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c index a7bab87.

[Bug 28402] random radeon/kms/drm related freezes with kernel 2.6.34

2010-10-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=28402 --- Comment #93 from Da Fox 2010-10-29 05:55:39 PDT --- (In reply to comment #87) > (In reply to comment #85) > > Created an attachment (id=39651) View: https://bugs.freedesktop.org/attachment.cgi?id=39651 Review: https://bugs.freedesktop.org/

[Bug 31213] New: [drm] *ERROR* with KMS (any kernels 2.6.3x.x) and ati mobility radeon X300

2010-10-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=31213 Summary: [drm] *ERROR* with KMS (any kernels 2.6.3x.x) and ati mobility radeon X300 Product: DRI Version: XOrg CVS Platform: x86 (IA32) OS/Version: Linux (All) Stat

[Bug 31213] [drm] *ERROR* with KMS (any kernels 2.6.3x.x) and ati mobility radeon X300

2010-10-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=31213 djnass...@hotmail.com changed: What|Removed |Added Priority|medium |high -- Configure bugmail: https

[Bug 28402] random radeon/kms/drm related freezes with kernel 2.6.34

2010-10-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=28402 Alex Deucher changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

[Bug 28402] random radeon/kms/drm related freezes with kernel 2.6.34

2010-10-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=28402 --- Comment #95 from Lukas Schneiderbauer 2010-10-29 10:24:19 PDT --- Thanks to all of you, guys! I'm looking forward to see the next (patched) kernel-release! -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ---

[PATCH] drm/radeon/kms: make the connector code less verbose

2010-10-29 Thread Alex Deucher
Make more of the connector code debug only to avoid spamming the kernel logs with detect and add modes messages. Signed-off-by: Alex Deucher --- drivers/gpu/drm/radeon/radeon_connectors.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/radeon/r

[Bug 31037] [r300g] Unwanted checkerboard effect on sprites / textures

2010-10-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=31037 --- Comment #2 from Gerwin 2010-10-29 10:51:00 PDT --- In nexuiz, the distortion and squares only appear when the "real dynamic lighting" setting is turned on (under settings / effects). -- Configure bugmail: https://bugs.freedesktop.org/userp

[Bug 28294] [r300g] Unigine Sanctuary v2.2: black glitches

2010-10-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=28294 --- Comment #52 from Tom Stellard 2010-10-29 16:55:26 PDT --- Created an attachment (id=39891) View: https://bugs.freedesktop.org/attachment.cgi?id=39891 Review: https://bugs.freedesktop.org/review?bug=28294&attachment=39891 Proposed Fix Doe

[Bug 31037] [r300g] Unwanted checkerboard effect on sprites / textures

2010-10-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=31037 --- Comment #3 from Tom Stellard 2010-10-29 17:23:57 PDT --- (In reply to comment #2) > In nexuiz, the distortion and squares only appear when the "real dynamic > lighting" setting is turned on (under settings / effects). Can you run nexuiz wit

[Bug 28623] [r300g] enemy territory: quake wars crashes

2010-10-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=28623 --- Comment #7 from Tom Stellard 2010-10-29 17:27:47 PDT --- Is this still an issue with Mesa 7.9 or the latest version from git? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail be

[Bug 28994] [r300c] [r300g] skybox in ut2004 is not seamless

2010-10-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=28994 --- Comment #3 from Tom Stellard 2010-10-29 17:30:22 PDT --- Is this still an issue in Mesa 7.9 or the latest version from git? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail beca

[RFC libdrm] Use __sync_val_compare_and_swap to implement DRM_CAS

2010-10-29 Thread Michel Dänzer
On Don, 2010-10-28 at 19:59 -0400, Matt Turner wrote: > Can we use gcc's __sync_val_compare_and_swap to implement DRM_CAS? > (If so, do we actually need the __sync_val version, or can we use > __sync_bool?) > > I just threw the patch together in two minutes, so I've got no idea > if it's right, j

[Bug 28294] [r300g] Unigine Sanctuary v2.2: black glitches

2010-10-29 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=28294 --- Comment #51 from Pavel Ondra?ka 2010-10-29 00:55:52 PDT --- (In reply to comment #50) > In radeon_optimize.c starting at line 660, there are three optimization > functions: constant_folding, peephole, and copy_propagate. You could try > com

[Bug 31193] [regression] aa43176e break water reflections

2010-10-29 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=31193 --- Comment #2 from Fabio Pedretti 2010-10-29 01:37:42 PDT --- Created an attachment (id=39880) --> (https://bugs.freedesktop.org/attachment.cgi?id=39880) Correct rendering without aa43176e -- Configure bugmail: https://bugs.freedesktop.org/u

[Bug 31193] [regression] aa43176e break water reflections

2010-10-29 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=31193 --- Comment #3 from Fabio Pedretti 2010-10-29 01:38:11 PDT --- Created an attachment (id=39881) --> (https://bugs.freedesktop.org/attachment.cgi?id=39881) Broken rendering with aa43176e -- Configure bugmail: https://bugs.freedesktop.org/userp

[PATCH 0/6] Misc TTM patches for drm-next

2010-10-29 Thread Thomas Hellstrom
The patch series mainly contains minor optimizations and documentation, except for patch 5/6 which is really a bugfix, but the synchronization bug shouldn't affect x86 processors.

[PATCH 1/6] drm/ttm: Documentation update

2010-10-29 Thread Thomas Hellstrom
Remove an obsolete comment about mm nodes. Document the new bo range manager interface. Signed-off-by: Thomas Hellstrom --- drivers/gpu/drm/ttm/ttm_bo.c|8 include/drm/ttm/ttm_bo_driver.h | 79 -- 2 files changed, 74 insertions(+), 13 deletions(

[PATCH 2/6] drm/ttm: Use private locks for the default bo range manager

2010-10-29 Thread Thomas Hellstrom
Searching for a free block in the range manager may in some situations be a lenghty operation, and we want to avoid holding the global lru lock during that time. Instead use a per-manager spinlock. This leaves the global lru lock for quick lru list and swap list manipulation only, including list m

[PATCH 3/6] drm/ttm: Remove pointless list_empty check

2010-10-29 Thread Thomas Hellstrom
Signed-off-by: Thomas Hellstrom --- drivers/gpu/drm/ttm/ttm_bo.c |7 --- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index cf47978..e6cedf4 100644 --- a/drivers/gpu/drm/ttm/ttm_bo.c +++ b/drivers/gpu/drm/ttm/tt

[PATCH 4/6] drm/ttm: Remove mm init error printouts and checks

2010-10-29 Thread Thomas Hellstrom
Replace with BUG_ON(). These error messages remained from the time when TTM was initialized from user-space. Nowadays hitting one of those is really a kernel bug. Signed-off-by: Thomas Hellstrom --- drivers/gpu/drm/ttm/ttm_bo.c | 20 ++-- 1 files changed, 2 insertions(+), 18 de

[PATCH 5/6] drm/ttm: Add a barrier when unreserving

2010-10-29 Thread Thomas Hellstrom
Since we're doing this outside of a spinlock to provide the necessary barriers, add an explicit barrier. Signed-off-by: Thomas Hellstrom --- drivers/gpu/drm/ttm/ttm_bo.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/t

[PATCH 6/6] drm/ttm: remove failed ttm binding error printout

2010-10-29 Thread Thomas Hellstrom
The driver (for example vmwgfx) may want to silently deal with the error itself. Signed-off-by: Thomas Hellstrom --- drivers/gpu/drm/ttm/ttm_tt.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c index a7bab87.

[Bug 28402] random radeon/kms/drm related freezes with kernel 2.6.34

2010-10-29 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=28402 --- Comment #93 from Da Fox 2010-10-29 05:55:39 PDT --- (In reply to comment #87) > (In reply to comment #85) > > Created an attachment (id=39651) View: https://bugs.freedesktop.org/attachment.cgi?id=39651 Review: https://bugs.freedesktop.org/

[Bug 31213] New: [drm] *ERROR* with KMS (any kernels 2.6.3x.x) and ati mobility radeon X300

2010-10-29 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=31213 Summary: [drm] *ERROR* with KMS (any kernels 2.6.3x.x) and ati mobility radeon X300 Product: DRI Version: XOrg CVS Platform: x86 (IA32) OS/Version: Linux (All) Stat

[Bug 31213] [drm] *ERROR* with KMS (any kernels 2.6.3x.x) and ati mobility radeon X300

2010-10-29 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=31213 djnass_18 at hotmail.com changed: What|Removed |Added Priority|medium |high -- Configure bugmail: ht

[Bug 28402] random radeon/kms/drm related freezes with kernel 2.6.34

2010-10-29 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=28402 Alex Deucher changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

[Bug 28402] random radeon/kms/drm related freezes with kernel 2.6.34

2010-10-29 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=28402 --- Comment #95 from Lukas Schneiderbauer 2010-10-29 10:24:19 PDT --- Thanks to all of you, guys! I'm looking forward to see the next (patched) kernel-release! -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ---

[PATCH] drm/radeon/kms: make the connector code less verbose

2010-10-29 Thread Alex Deucher
Make more of the connector code debug only to avoid spamming the kernel logs with detect and add modes messages. Signed-off-by: Alex Deucher --- drivers/gpu/drm/radeon/radeon_connectors.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/radeon/r

[Bug 31037] [r300g] Unwanted checkerboard effect on sprites / textures

2010-10-29 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=31037 --- Comment #2 from Gerwin 2010-10-29 10:51:00 PDT --- In nexuiz, the distortion and squares only appear when the "real dynamic lighting" setting is turned on (under settings / effects). -- Configure bugmail: https://bugs.freedesktop.org/userp

[Bug 28294] [r300g] Unigine Sanctuary v2.2: black glitches

2010-10-29 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=28294 --- Comment #52 from Tom Stellard 2010-10-29 16:55:26 PDT --- Created an attachment (id=39891) View: https://bugs.freedesktop.org/attachment.cgi?id=39891 Review: https://bugs.freedesktop.org/review?bug=28294&attachment=39891 Proposed Fix Doe

[Bug 31037] [r300g] Unwanted checkerboard effect on sprites / textures

2010-10-29 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=31037 --- Comment #3 from Tom Stellard 2010-10-29 17:23:57 PDT --- (In reply to comment #2) > In nexuiz, the distortion and squares only appear when the "real dynamic > lighting" setting is turned on (under settings / effects). Can you run nexuiz wit

[Bug 28623] [r300g] enemy territory: quake wars crashes

2010-10-29 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=28623 --- Comment #7 from Tom Stellard 2010-10-29 17:27:47 PDT --- Is this still an issue with Mesa 7.9 or the latest version from git? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail be

[Bug 28994] [r300c] [r300g] skybox in ut2004 is not seamless

2010-10-29 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=28994 --- Comment #3 from Tom Stellard 2010-10-29 17:30:22 PDT --- Is this still an issue in Mesa 7.9 or the latest version from git? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail beca

[PATCH] drm/i915/sdvo: Fix harmless build warning

2010-10-29 Thread Dongdong Deng
Removing the following harmless build warning to let compiler happy. drivers/gpu/drm/i915/intel_sdvo.c: In function 'intel_sdvo_mode_set': drivers/gpu/drm/i915/intel_sdvo.c:1097: warning: 'rate' may be used uninitialized in this function Signed-off-by: Dongdong Deng CC: David Airlie CC: dri-dev