[PATCH 1/2] drm/radeon/kms: track audio engine state, do not use not setup timer

2010-06-19 Thread Rafał Miłecki
This is needed to enable audio support on devices using polling. In case user decides to disable audio (module parameter) we still will try to use timer in r600_audio_enable_polling. This would lead to BUG in kernel/timer.c. Signed-off-by: Rafał Miłecki --- Dave: I think we should not hit this wi

[RFT][PATCH 2/2] drm/radeon/kms: enable HDMI audio on RS600/RS690.

2010-06-19 Thread Rafał Miłecki
We will need method of selecting encoder that should receive HDMI block. For now we assign HDMI block to first enabled encoder. Hopefully there are not many RS6x0 chips with two digital encoders. Signed-off-by: Rafał Miłecki --- Is there anyone with RS6x0 and HDMI audio received around? --- driv

[Bug 28611] New: [r300g] KSudoku crashes when trying to play Roxdoku game

2010-06-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=28611 Summary: [r300g] KSudoku crashes when trying to play Roxdoku game Product: Mesa Version: git Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: NEW

[Bug 28612] New: [r300g] View isn't permanent, menus/controls are corrupted in Blender

2010-06-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=28612 Summary: [r300g] View isn't permanent, menus/controls are corrupted in Blender Product: Mesa Version: git Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: N

[Bug 28612] [r300g] View isn't permanent, menus/controls are corrupted in Blender

2010-06-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=28612 --- Comment #1 from Jure Repinc 2010-06-19 04:10:11 PDT --- Created an attachment (id=36366) --> (https://bugs.freedesktop.org/attachment.cgi?id=36366) blender-corruption.png A screenshot of the corruption in Blender -- Configure bugmail: htt

Re: [PATCH] DRM / radeon / PM: Do not evict VRAM during freeze phase of hibernation

2010-06-19 Thread Rafael J. Wysocki
On Saturday, June 19, 2010, Dave Airlie wrote: > On Sat, 2010-06-19 at 01:23 +0200, Rafael J. Wysocki wrote: > > On Friday, June 18, 2010, Dave Airlie wrote: > > > On Fri, 2010-06-18 at 22:21 +0200, Rafael J. Wysocki wrote: > > > > From: Rafael J. Wysocki > > > > > > > > I have recently noticed a

Re: [PATCH] DRM / radeon / PM: Do not evict VRAM during freeze phase of hibernation

2010-06-19 Thread Rafael J. Wysocki
On Saturday, June 19, 2010, Dave Airlie wrote: > On Sat, 2010-06-19 at 01:23 +0200, Rafael J. Wysocki wrote: > > On Friday, June 18, 2010, Dave Airlie wrote: > > > On Fri, 2010-06-18 at 22:21 +0200, Rafael J. Wysocki wrote: > > > > From: Rafael J. Wysocki > > > > > > > > I have recently noticed a

[Bug 28614] New: [r300g] Hypertorus hack from XScreenSaver has triangles visible

2010-06-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=28614 Summary: [r300g] Hypertorus hack from XScreenSaver has triangles visible Product: Mesa Version: git Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: NEW

[Bug 28614] [r300g] Hypertorus hack from XScreenSaver has triangles visible

2010-06-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=28614 --- Comment #1 from Marek Olšák 2010-06-19 07:50:36 PDT --- Could you please bisect the regression? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assi

[Bug 28614] [r300g] Hypertorus hack from XScreenSaver has triangles visible

2010-06-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=28614 --- Comment #2 from Jure Repinc 2010-06-19 10:27:29 PDT --- The last commit that works fine is: 5d4d4b2134595c4ed8060d6d002a0cd54690c289 i965: Remove unnecessary header. Than there are two commits that don't compile: b85a361ccbac956d2842251395c0

[PATCH] drm/radeon/kms: return ret in cursor_set failure path

2010-06-19 Thread mattst88
From: Matt Turner We were returning 0 in both the success and failure paths. Noticed while investigating FDO bug 26403. Signed-off-by: Matt Turner --- drivers/gpu/drm/radeon/radeon_cursor.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_

[Bug 28612] [r300g] View isn't permanent, menus/controls are corrupted in Blender

2010-06-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=28612 --- Comment #2 from Marek Olšák 2010-06-19 11:42:04 PDT --- Fixed by the commit 9b2ebcaf4b94bfc8756f6b216e0e452013616f2c. Can you confirm? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this

[Bug 28614] [Gallium/Draw][r300g] Hypertorus hack from XScreenSaver has triangles visible

2010-06-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=28614 Marek Olšák changed: What|Removed |Added Summary|[r300g] Hypertorus hack |[Gallium/Draw][r300g] |f

[Bug 28612] [r300g] View isn't permanent, menus/controls are corrupted in Blender

2010-06-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=28612 --- Comment #3 from Jure Repinc 2010-06-19 12:22:29 PDT --- Controls and menus appear fine now, although the other problem with redrawing still remains. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are

Re: KMS:RV635:Radeon 3650HD graphics driver broken on a laptop when connected to a docking station and external display

2010-06-19 Thread Pasi Kärkkäinen
On Fri, Jun 18, 2010 at 09:45:22PM +0300, Pasi Kärkkäinen wrote: > > > > >> > > > > > >> > I wonder if that HDMI-0 is the key to the problem.. I don't have > > > > >> > anything connected > > > > >> > to the HDMI connector on the laptop. There's no HDMI connector on > > > > >> > the dock, it's on

[Bug 28615] New: [r300g] Hard freeze when running POP: Sands of time under wine

2010-06-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=28615 Summary: [r300g] Hard freeze when running POP: Sands of time under wine Product: Mesa Version: git Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: NEW

[Bug 28616] New: Xorg segfaults on 3d apps if KMS disabled

2010-06-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=28616 Summary: Xorg segfaults on 3d apps if KMS disabled Product: DRI Version: XOrg CVS Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: NEW Severity: normal Prio

[Bug 28284] [r300, r600] celestia core dumps - Assertion `dstRowStride' failed.

2010-06-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=28284 Maciej Cencora changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

[Bug 28033] [r300, r300g] World of Warcraft login screen is "blocky" with RV350

2010-06-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=28033 --- Comment #1 from mtm...@freemail.hu 2010-06-19 14:12:57 PDT --- This looks like a duplicate of #8056. Both r300c and r300g have problems setting up tiling on r3xx cards. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=ema

[Bug 28033] [r300, r300g] World of Warcraft login screen is "blocky" with RV350

2010-06-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=28033 --- Comment #2 from Marek Olšák 2010-06-19 14:28:31 PDT --- To my knowledge, tiling in r300g just works. Chris, can you try the game again with current mesa master? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ---

[Bug 28611] [Gallium/Draw][r300g] KSudoku crashes when trying to play Roxdoku game

2010-06-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=28611 Marek Olšák changed: What|Removed |Added Summary|[r300g] KSudoku crashes |[Gallium/Draw][r300g] |w

[Bug 28033] [r300, r300g] World of Warcraft login screen is "blocky" with RV350

2010-06-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=28033 --- Comment #3 from Chris Rankin 2010-06-19 15:47:06 PDT --- (In reply to comment #2) > Chris, can you try the game again with current mesa master? It's still broken with mesa master and a 2.6.33.5 kernel. Do I need a 2.6.34.x kernel instead?

[Bug 28033] [r300, r300g] World of Warcraft login screen is "blocky" with RV350

2010-06-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=28033 --- Comment #4 from Marek Olšák 2010-06-19 16:11:41 PDT --- No, you don't. I think I know that's wrong. I'll try to fix it soon. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail bec

[Bug 28033] [r300, r300g] World of Warcraft login screen is "blocky" with RV350

2010-06-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=28033 --- Comment #5 from Marek Olšák 2010-06-19 16:12:44 PDT --- s/that/what/ -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. _

Re: [PATCH] DRM / radeon / PM: Do not evict VRAM during freeze phase of hibernation

2010-06-19 Thread Rafael J. Wysocki
On Saturday, June 19, 2010, Rafael J. Wysocki wrote: > On Saturday, June 19, 2010, Dave Airlie wrote: > > On Sat, 2010-06-19 at 01:23 +0200, Rafael J. Wysocki wrote: > > > On Friday, June 18, 2010, Dave Airlie wrote: > > > > On Fri, 2010-06-18 at 22:21 +0200, Rafael J. Wysocki wrote: > > > > > From

[Bug 28033] [r300, r300g] World of Warcraft login screen is "blocky" with RV350

2010-06-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=28033 --- Comment #6 from Marek Olšák 2010-06-19 21:18:49 PDT --- I've pushed the fix to master. Can you test now? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are

[PATCH] DRM / radeon / PM: Do not evict VRAM during freeze phase of hibernation

2010-06-19 Thread Dave Airlie
On Fri, 2010-06-18 at 22:21 +0200, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > I have recently noticed a 55 sec. delay during the "device freeze" > phase of hibernation on my test-bed HP nx6325. Due to the 100% > reproducibility of it I was able to narrow it down to > radeon_suspend_k

[PATCH] DRM / radeon / PM: Do not evict VRAM during freeze phase of hibernation

2010-06-19 Thread Rafael J. Wysocki
On Friday, June 18, 2010, Rafa? Mi?ecki wrote: > 2010/6/18 Rafael J. Wysocki : > > From: Rafael J. Wysocki > > Thanks for you recent involvement in radeon driver! Well, I'm just trying to address the issues I see on my test boxes. > I can see you used way shorter commit title this time ;) Just

[PATCH] DRM / radeon / PM: Do not evict VRAM during freeze phase of hibernation

2010-06-19 Thread Rafael J. Wysocki
On Friday, June 18, 2010, Dave Airlie wrote: > On Fri, 2010-06-18 at 22:21 +0200, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > I have recently noticed a 55 sec. delay during the "device freeze" > > phase of hibernation on my test-bed HP nx6325. Due to the 100% > > reproducibility

[PATCH] DRM / radeon / PM: Do not evict VRAM during freeze phase of hibernation

2010-06-19 Thread Dave Airlie
On Sat, 2010-06-19 at 01:23 +0200, Rafael J. Wysocki wrote: > On Friday, June 18, 2010, Dave Airlie wrote: > > On Fri, 2010-06-18 at 22:21 +0200, Rafael J. Wysocki wrote: > > > From: Rafael J. Wysocki > > > > > > I have recently noticed a 55 sec. delay during the "device freeze" > > > phase of hi

[PATCH 1/2] drm/radeon/kms: track audio engine state, do not use not setup timer

2010-06-19 Thread Rafał Miłecki
This is needed to enable audio support on devices using polling. In case user decides to disable audio (module parameter) we still will try to use timer in r600_audio_enable_polling. This would lead to BUG in kernel/timer.c. Signed-off-by: Rafa? Mi?ecki --- Dave: I think we should not hit this wi

[RFT][PATCH 2/2] drm/radeon/kms: enable HDMI audio on RS600/RS690.

2010-06-19 Thread Rafał Miłecki
We will need method of selecting encoder that should receive HDMI block. For now we assign HDMI block to first enabled encoder. Hopefully there are not many RS6x0 chips with two digital encoders. Signed-off-by: Rafa? Mi?ecki --- Is there anyone with RS6x0 and HDMI audio received around? --- driv

[Bug 28611] New: [r300g] KSudoku crashes when trying to play Roxdoku game

2010-06-19 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=28611 Summary: [r300g] KSudoku crashes when trying to play Roxdoku game Product: Mesa Version: git Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: NEW

[Bug 28612] New: [r300g] View isn't permanent, menus/controls are corrupted in Blender

2010-06-19 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=28612 Summary: [r300g] View isn't permanent, menus/controls are corrupted in Blender Product: Mesa Version: git Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: N

[Bug 28612] [r300g] View isn't permanent, menus/controls are corrupted in Blender

2010-06-19 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=28612 --- Comment #1 from Jure Repinc 2010-06-19 04:10:11 PDT --- Created an attachment (id=36366) --> (https://bugs.freedesktop.org/attachment.cgi?id=36366) blender-corruption.png A screenshot of the corruption in Blender -- Configure bugmail: ht

[PATCH] DRM / radeon / PM: Do not evict VRAM during freeze phase of hibernation

2010-06-19 Thread Rafael J. Wysocki
On Saturday, June 19, 2010, Dave Airlie wrote: > On Sat, 2010-06-19 at 01:23 +0200, Rafael J. Wysocki wrote: > > On Friday, June 18, 2010, Dave Airlie wrote: > > > On Fri, 2010-06-18 at 22:21 +0200, Rafael J. Wysocki wrote: > > > > From: Rafael J. Wysocki > > > > > > > > I have recently noticed a

[PATCH] DRM / radeon / PM: Do not evict VRAM during freeze phase of hibernation

2010-06-19 Thread Rafael J. Wysocki
On Saturday, June 19, 2010, Dave Airlie wrote: > On Sat, 2010-06-19 at 01:23 +0200, Rafael J. Wysocki wrote: > > On Friday, June 18, 2010, Dave Airlie wrote: > > > On Fri, 2010-06-18 at 22:21 +0200, Rafael J. Wysocki wrote: > > > > From: Rafael J. Wysocki > > > > > > > > I have recently noticed a

[Bug 28614] New: [r300g] Hypertorus hack from XScreenSaver has triangles visible

2010-06-19 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=28614 Summary: [r300g] Hypertorus hack from XScreenSaver has triangles visible Product: Mesa Version: git Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: NEW

[Bug 28614] [r300g] Hypertorus hack from XScreenSaver has triangles visible

2010-06-19 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=28614 --- Comment #1 from Marek Ol??k 2010-06-19 07:50:36 PDT --- Could you please bisect the regression? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the ass

[Bug 28614] [r300g] Hypertorus hack from XScreenSaver has triangles visible

2010-06-19 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=28614 --- Comment #2 from Jure Repinc 2010-06-19 10:27:29 PDT --- The last commit that works fine is: 5d4d4b2134595c4ed8060d6d002a0cd54690c289 i965: Remove unnecessary header. Than there are two commits that don't compile: b85a361ccbac956d2842251395c

[PATCH] drm/radeon/kms: return ret in cursor_set failure path

2010-06-19 Thread matts...@gmail.com
From: Matt Turner We were returning 0 in both the success and failure paths. Noticed while investigating FDO bug 26403. Signed-off-by: Matt Turner --- drivers/gpu/drm/radeon/radeon_cursor.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_

[Bug 28612] [r300g] View isn't permanent, menus/controls are corrupted in Blender

2010-06-19 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=28612 --- Comment #2 from Marek Ol??k 2010-06-19 11:42:04 PDT --- Fixed by the commit 9b2ebcaf4b94bfc8756f6b216e0e452013616f2c. Can you confirm? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving thi

[Bug 28614] [Gallium/Draw][r300g] Hypertorus hack from XScreenSaver has triangles visible

2010-06-19 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=28614 Marek Ol??k changed: What|Removed |Added Summary|[r300g] Hypertorus hack |[Gallium/Draw][r300g] |f

[Bug 28612] [r300g] View isn't permanent, menus/controls are corrupted in Blender

2010-06-19 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=28612 --- Comment #3 from Jure Repinc 2010-06-19 12:22:29 PDT --- Controls and menus appear fine now, although the other problem with redrawing still remains. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are

KMS:RV635:Radeon 3650HD graphics driver broken on a laptop when connected to a docking station and external display

2010-06-19 Thread Pasi Kärkkäinen
On Fri, Jun 18, 2010 at 09:45:22PM +0300, Pasi K?rkk?inen wrote: > > > > >> > > > > > >> > I wonder if that HDMI-0 is the key to the problem.. I don't have > > > > >> > anything connected > > > > >> > to the HDMI connector on the laptop. There's no HDMI connector on > > > > >> > the dock, it's on

[Bug 28615] New: [r300g] Hard freeze when running POP: Sands of time under wine

2010-06-19 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=28615 Summary: [r300g] Hard freeze when running POP: Sands of time under wine Product: Mesa Version: git Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: NEW

[Bug 28616] New: Xorg segfaults on 3d apps if KMS disabled

2010-06-19 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=28616 Summary: Xorg segfaults on 3d apps if KMS disabled Product: DRI Version: XOrg CVS Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: NEW Severity: normal Prio

[Bug 28284] [r300, r600] celestia core dumps - Assertion `dstRowStride' failed.

2010-06-19 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=28284 Maciej Cencora changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

[Bug 28033] [r300, r300g] World of Warcraft login screen is "blocky" with RV350

2010-06-19 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=28033 --- Comment #1 from mtmkls at freemail.hu 2010-06-19 14:12:57 PDT --- This looks like a duplicate of #8056. Both r300c and r300g have problems setting up tiling on r3xx cards. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=

[Bug 28033] [r300, r300g] World of Warcraft login screen is "blocky" with RV350

2010-06-19 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=28033 --- Comment #2 from Marek Ol??k 2010-06-19 14:28:31 PDT --- To my knowledge, tiling in r300g just works. Chris, can you try the game again with current mesa master? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --

[Bug 28611] [Gallium/Draw][r300g] KSudoku crashes when trying to play Roxdoku game

2010-06-19 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=28611 Marek Ol??k changed: What|Removed |Added Summary|[r300g] KSudoku crashes |[Gallium/Draw][r300g] |w

[Bug 28033] [r300, r300g] World of Warcraft login screen is "blocky" with RV350

2010-06-19 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=28033 --- Comment #3 from Chris Rankin 2010-06-19 15:47:06 PDT --- (In reply to comment #2) > Chris, can you try the game again with current mesa master? It's still broken with mesa master and a 2.6.33.5 kernel. Do I need a 2.6.34.x kernel instead?

[Bug 28033] [r300, r300g] World of Warcraft login screen is "blocky" with RV350

2010-06-19 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=28033 --- Comment #4 from Marek Ol??k 2010-06-19 16:11:41 PDT --- No, you don't. I think I know that's wrong. I'll try to fix it soon. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail be

[Bug 28033] [r300, r300g] World of Warcraft login screen is "blocky" with RV350

2010-06-19 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=28033 --- Comment #5 from Marek Ol??k 2010-06-19 16:12:44 PDT --- s/that/what/ -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.

[Bug 28033] [r300, r300g] World of Warcraft login screen is "blocky" with RV350

2010-06-19 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=28033 --- Comment #6 from Marek Ol??k 2010-06-19 21:18:49 PDT --- I've pushed the fix to master. Can you test now? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You ar

[patch] i915: return -EFAULT if copy_to_user fails

2010-06-19 Thread Dan Carpenter
copy_to_user returns the number of bytes remaining to be copied, but we want to return a negative error code here. These are returned to userspace. Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c index 59a2bf8..5fd876e 100644 --- a/dri

[patch v2] i915: take struct_mutex lock in intel_setup_overlay()

2010-06-19 Thread Dan Carpenter
This patch never made it into 2.6.35 but it's still valid. Can you pick it up for 2.6.36? It still applies cleanly to 2.6.35-rc3 with fuzz (8 lines offset). regards, dan carpenter On Mon, May 03, 2010 at 09:58:32AM +0200, Dan Carpenter wrote: > I changed the drm_gem_object_unreference() to > dr