Re: video: atmel_lcdfb: Use common error handling code in atmel_lcdfb_of_init()

2017-11-07 Thread Nicolas Ferre
On 06/11/2017 at 10:32, SF Markus Elfring wrote: >> Sorry but NACK: the message was malformed and resulted in the >> duplication of the error log that you spotted. >> >> The proper way to fix this is to modify the second occurrence of this >> message. > > * Would you like to achieve that a corres

Re: [PATCH] video: atmel_lcdfb: Use common error handling code in atmel_lcdfb_of_init()

2017-11-07 Thread Nicolas Ferre
On 05/11/2017 at 14:10, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 5 Nov 2017 14:00:52 +0100 > > Add a jump target so that a specific error message is stored only once > at the end of this function implementation. > Replace two calls of the function "dev_err" by goto statements.

Re: video: atmel_lcdfb: Use common error handling code in atmel_lcdfb_of_init()

2017-11-06 Thread Dan Carpenter
On Mon, Nov 06, 2017 at 10:00:25AM +0100, SF Markus Elfring wrote: > >> If you want to lower the size of strings in this driver, you can do it, > >> but not like this. > > > > Just so we're clear, GCC already detects and combines it when you use > > the same string constant twice. > > Do you dist

Re: video: atmel_lcdfb: Use common error handling code in atmel_lcdfb_of_init()

2017-11-06 Thread SF Markus Elfring
> Sorry but NACK: the message was malformed and resulted in the > duplication of the error log that you spotted. > > The proper way to fix this is to modify the second occurrence of this message. * Would you like to achieve that a corresponding message will mention anything around a property “a

Re: video: atmel_lcdfb: Use common error handling code in atmel_lcdfb_of_init()

2017-11-06 Thread SF Markus Elfring
>> If you want to lower the size of strings in this driver, you can do it, >> but not like this. > > Just so we're clear, GCC already detects and combines it when you use > the same string constant twice. Do you distinguish between merging of constants and the combination of statements for such a

Re: [PATCH] video: atmel_lcdfb: Use common error handling code in atmel_lcdfb_of_init()

2017-11-06 Thread Dan Carpenter
On Mon, Nov 06, 2017 at 09:40:19AM +0100, Nicolas Ferre wrote: > If you want to lower the size of strings in this driver, you can do it, > but not like this. Just so we're clear, GCC already detects and combines it when you use the same string constant twice. regards, dan carpenter __

[PATCH] video: atmel_lcdfb: Use common error handling code in atmel_lcdfb_of_init()

2017-11-05 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 5 Nov 2017 14:00:52 +0100 Add a jump target so that a specific error message is stored only once at the end of this function implementation. Replace two calls of the function "dev_err" by goto statements. This issue was detected by using the Coccinelle software.