question regarding nvc0_instmem_suspend()

2010-08-16 Thread Ben Skeggs
On Fri, 2010-08-13 at 23:59 +0200, Luca Tettamanti wrote: > On Fri, Aug 13, 2010 at 11:39 PM, Dan Carpenter wrote: > > Smatch thinks there is a buffer overflow in nvc0_instmem_suspend() and > > I've looked at it, but I don't understand the code. > > > > drivers/gpu/drm/nouveau/nvc0_instmem.c +152

Re: question regarding nvc0_instmem_suspend()

2010-08-16 Thread Ben Skeggs
On Fri, 2010-08-13 at 23:59 +0200, Luca Tettamanti wrote: > On Fri, Aug 13, 2010 at 11:39 PM, Dan Carpenter wrote: > > Smatch thinks there is a buffer overflow in nvc0_instmem_suspend() and > > I've looked at it, but I don't understand the code. > > > > drivers/gpu/drm/nouveau/nvc0_instmem.c +152

question regarding nvc0_instmem_suspend()

2010-08-13 Thread Luca Tettamanti
On Fri, Aug 13, 2010 at 11:39 PM, Dan Carpenter wrote: > Smatch thinks there is a buffer overflow in nvc0_instmem_suspend() and > I've looked at it, but I don't understand the code. > > drivers/gpu/drm/nouveau/nvc0_instmem.c +152 nvc0_instmem_suspend(10) > ? ? ? ?error: buffer overflow 'dev_priv->

question regarding nvc0_instmem_suspend()

2010-08-13 Thread Dan Carpenter
Smatch thinks there is a buffer overflow in nvc0_instmem_suspend() and I've looked at it, but I don't understand the code. drivers/gpu/drm/nouveau/nvc0_instmem.c +152 nvc0_instmem_suspend(10) error: buffer overflow 'dev_priv->susres.ramin_copy' 16384 <= 1835008 141 int 142 nvc0_in

Re: question regarding nvc0_instmem_suspend()

2010-08-13 Thread Luca Tettamanti
On Fri, Aug 13, 2010 at 11:39 PM, Dan Carpenter wrote: > Smatch thinks there is a buffer overflow in nvc0_instmem_suspend() and > I've looked at it, but I don't understand the code. > > drivers/gpu/drm/nouveau/nvc0_instmem.c +152 nvc0_instmem_suspend(10) >        error: buffer overflow 'dev_priv->

question regarding nvc0_instmem_suspend()

2010-08-13 Thread Dan Carpenter
Smatch thinks there is a buffer overflow in nvc0_instmem_suspend() and I've looked at it, but I don't understand the code. drivers/gpu/drm/nouveau/nvc0_instmem.c +152 nvc0_instmem_suspend(10) error: buffer overflow 'dev_priv->susres.ramin_copy' 16384 <= 1835008 141 int 142 nvc0_in