question about drivers/gpu/drm/gma500/oaktrail_lvds.c

2012-07-09 Thread Julia Lawall
On Mon, 9 Jul 2012, Patrik Jakobsson wrote: > On Sun, Jul 8, 2012 at 10:16 PM, Alan Cox wrote: >> On Sun, 8 Jul 2012 10:39:43 +0200 (CEST) >> Julia Lawall wrote: >> >>> In the function oaktrail_lvds_mode_set, I don't think that the following >>> code makes any sense: >>> >>> /* Find the

question about drivers/gpu/drm/gma500/oaktrail_lvds.c

2012-07-09 Thread Patrik Jakobsson
On Sun, Jul 8, 2012 at 10:16 PM, Alan Cox wrote: > On Sun, 8 Jul 2012 10:39:43 +0200 (CEST) > Julia Lawall wrote: > >> In the function oaktrail_lvds_mode_set, I don't think that the following >> code makes any sense: >> >> /* Find the connector we're trying to set up */ >> list_

Re: question about drivers/gpu/drm/gma500/oaktrail_lvds.c

2012-07-09 Thread Julia Lawall
On Mon, 9 Jul 2012, Patrik Jakobsson wrote: On Sun, Jul 8, 2012 at 10:16 PM, Alan Cox wrote: On Sun, 8 Jul 2012 10:39:43 +0200 (CEST) Julia Lawall wrote: In the function oaktrail_lvds_mode_set, I don't think that the following code makes any sense: /* Find the connector we're tryi

Re: question about drivers/gpu/drm/gma500/oaktrail_lvds.c

2012-07-09 Thread Julia Lawall
On Sun, 8 Jul 2012, Alan Cox wrote: On Sun, 8 Jul 2012 10:39:43 +0200 (CEST) Julia Lawall wrote: In the function oaktrail_lvds_mode_set, I don't think that the following code makes any sense: /* Find the connector we're trying to set up */ list_for_each_entry(connector, &mo

question about drivers/gpu/drm/gma500/oaktrail_lvds.c

2012-07-08 Thread Julia Lawall
On Sun, 8 Jul 2012, Alan Cox wrote: > On Sun, 8 Jul 2012 10:39:43 +0200 (CEST) > Julia Lawall wrote: > >> In the function oaktrail_lvds_mode_set, I don't think that the following >> code makes any sense: >> >> /* Find the connector we're trying to set up */ >> list_for_each_entr

question about drivers/gpu/drm/gma500/oaktrail_lvds.c

2012-07-08 Thread Alan Cox
On Sun, 8 Jul 2012 10:39:43 +0200 (CEST) Julia Lawall wrote: > In the function oaktrail_lvds_mode_set, I don't think that the following > code makes any sense: > > /* Find the connector we're trying to set up */ > list_for_each_entry(connector, &mode_config->connector_list, he

Re: question about drivers/gpu/drm/gma500/oaktrail_lvds.c

2012-07-08 Thread Patrik Jakobsson
On Sun, Jul 8, 2012 at 10:16 PM, Alan Cox wrote: > On Sun, 8 Jul 2012 10:39:43 +0200 (CEST) > Julia Lawall wrote: > >> In the function oaktrail_lvds_mode_set, I don't think that the following >> code makes any sense: >> >> /* Find the connector we're trying to set up */ >> list_

Re: question about drivers/gpu/drm/gma500/oaktrail_lvds.c

2012-07-08 Thread Alan Cox
On Sun, 8 Jul 2012 10:39:43 +0200 (CEST) Julia Lawall wrote: > In the function oaktrail_lvds_mode_set, I don't think that the following > code makes any sense: > > /* Find the connector we're trying to set up */ > list_for_each_entry(connector, &mode_config->connector_list, he

question about drivers/gpu/drm/gma500/oaktrail_lvds.c

2012-07-08 Thread Julia Lawall
In the function oaktrail_lvds_mode_set, I don't think that the following code makes any sense: /* Find the connector we're trying to set up */ list_for_each_entry(connector, &mode_config->connector_list, head) { if (!connector->encoder || connector->encoder->crt

question about drivers/gpu/drm/gma500/oaktrail_lvds.c

2012-07-08 Thread Julia Lawall
In the function oaktrail_lvds_mode_set, I don't think that the following code makes any sense: /* Find the connector we're trying to set up */ list_for_each_entry(connector, &mode_config->connector_list, head) { if (!connector->encoder || connector->encoder->crtc