[PATCH 2/7] drm/i915/backlight: Use proper interface based on eDP version

2025-01-23 Thread Suraj Kandpal
eDP is supposed to use VESA interface when using revision 1.5 and above, use Intel interface for backlight control otherwise. Add check to use correct interface. Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 8 +++- 1 file changed, 7 insertions(+),

[PATCH 3/7] drm/i915/backlight: Check Nits based brightness control for VESA

2025-01-23 Thread Suraj Kandpal
Check if we are capable of controlling brightness via Nits which is dependant on PANEL_LUMINANCE_OVERRIDE and SMOOTH_BRIGHTNESS capablility being set. Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_display_types.h| 1 + drivers/gpu/drm/i915/display/intel_dp_aux_backlight

[PATCH 6/7] drm/i915/backlight: Setup NITS based brightness via VESA

2025-01-23 Thread Suraj Kandpal
Modify backlight setup function for VESA interface to take into account the NITS based brightness. Signed-off-by: Suraj Kandpal --- .../drm/i915/display/intel_dp_aux_backlight.c | 97 +++ 1 file changed, 57 insertions(+), 40 deletions(-) diff --git a/drivers/gpu/drm/i915/display

[PATCH 7/7] drm/i915/backlight: Enable Nits based brightness

2025-01-23 Thread Suraj Kandpal
Enable Nits based brightness by writing the PANEL_LUMINANCE_CONTROL bit and set the correct register to change brightness. Signed-off-by: Suraj Kandpal --- .../gpu/drm/i915/display/intel_dp_aux_backlight.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/gpu/drm/i915/

[PATCH 5/7] drm/i915/backlight: Add function to change brightness in NITS for VESA

2025-01-23 Thread Suraj Kandpal
Create a function that fills in the value for PANEL_TARGET_LUMINANCE_VALUE which helps in changing the brightness in NITS using VESA interface. Signed-off-by: Suraj Kandpal --- .../drm/i915/display/intel_dp_aux_backlight.c | 29 +++ 1 file changed, 29 insertions(+) diff --git a/

[PATCH 4/7] drm/i915/backlight: Modify function to get VESA brightness in NITS

2025-01-23 Thread Suraj Kandpal
Modify vesa_get_brightness function to take into account nits_support and based on that read the appropriate register and return the value. Signed-off-by: Suraj Kandpal --- .../drm/i915/display/intel_dp_aux_backlight.c | 20 +++ 1 file changed, 20 insertions(+) diff --git a/driv

Re: [PATCH v2] drm/i915/backlight: Return immediately when scale() finds invalid parameters

2025-01-21 Thread Linus Torvalds
On Tue, 21 Jan 2025 at 14:59, Rodrigo Vivi wrote: > > I'm pushing this soon to drm-intel-next, unless Linus want to take > this one directly to his tree Let's just go through the proper channels and go through the drm tree. Unless I've issed something, I think this is only an active issue on par

Re: [PATCH v2] drm/i915/backlight: Return immediately when scale() finds invalid parameters

2025-01-21 Thread Rodrigo Vivi
On Tue, Jan 21, 2025 at 06:52:03AM -0800, Guenter Roeck wrote: > The scale() functions detects invalid parameters, but continues > its calculations anyway. This causes bad results if negative values > are used for unsigned operations. Worst case, a division by 0 error > will be seen if source_min =

[PATCH v2] drm/i915/backlight: Return immediately when scale() finds invalid parameters

2025-01-21 Thread Guenter Roeck
The scale() functions detects invalid parameters, but continues its calculations anyway. This causes bad results if negative values are used for unsigned operations. Worst case, a division by 0 error will be seen if source_min == source_max. On top of that, after v6.13, the sequence of WARN_ON() f

Re: [PATCH] drm/i915/backlight: Return immediately when scale() finds invalid parameters

2025-01-21 Thread Jani Nikula
On Mon, 20 Jan 2025, Guenter Roeck wrote: > The scale() functions detects invalid parameters, but continues > its calculations anyway. This causes bad results if negative values > are used for unsigned operations. Worst case, a division by 0 error > will be seen if source_min == source_max. > > On

[PATCH] drm/i915/backlight: Return immediately when scale() finds invalid parameters

2025-01-20 Thread Guenter Roeck
The scale() functions detects invalid parameters, but continues its calculations anyway. This causes bad results if negative values are used for unsigned operations. Worst case, a division by 0 error will be seen if source_min == source_max. On top of that, after v6.13, the sequence of WARN_ON() f

Re: [PATCH] drm/i915/backlight: Remove a useless kstrdup_const()

2024-10-02 Thread Christophe JAILLET
Le 02/10/2024 à 13:51, Jani Nikula a écrit : On Tue, 01 Oct 2024, Christophe JAILLET wrote: Le 30/09/2024 à 09:48, Jani Nikula a écrit : On Sat, 28 Sep 2024, Christophe JAILLET wrote: "name" is allocated and freed in intel_backlight_device_register(). The initial allocation just duplicates "

Re: [PATCH] drm/i915/backlight: Remove a useless kstrdup_const()

2024-10-02 Thread Jani Nikula
On Tue, 01 Oct 2024, Christophe JAILLET wrote: > Le 30/09/2024 à 09:48, Jani Nikula a écrit : >> On Sat, 28 Sep 2024, Christophe JAILLET >> wrote: >>> "name" is allocated and freed in intel_backlight_device_register(). >>> The initial allocation just duplicates "intel_backlight". >>> >>> Later,

Re: [PATCH] drm/i915/backlight: Remove a useless kstrdup_const()

2024-10-01 Thread Christophe JAILLET
Le 30/09/2024 à 09:48, Jani Nikula a écrit : On Sat, 28 Sep 2024, Christophe JAILLET wrote: "name" is allocated and freed in intel_backlight_device_register(). The initial allocation just duplicates "intel_backlight". Later, if a device with this name has already been registered, another dynam

Re: [PATCH] drm/i915/backlight: Remove a useless kstrdup_const()

2024-09-30 Thread Jani Nikula
On Sat, 28 Sep 2024, Christophe JAILLET wrote: > "name" is allocated and freed in intel_backlight_device_register(). > The initial allocation just duplicates "intel_backlight". > > Later, if a device with this name has already been registered, another > dynamically generated one is allocated using

[PATCH] drm/i915/backlight: Remove a useless kstrdup_const()

2024-09-28 Thread Christophe JAILLET
"name" is allocated and freed in intel_backlight_device_register(). The initial allocation just duplicates "intel_backlight". Later, if a device with this name has already been registered, another dynamically generated one is allocated using kasprintf(). So at the end of the function, when "name"

Re: [PATCH 1/2] drm/i915/backlight: Drop duplicate intel_panel_actually_set_backlight()

2021-12-16 Thread Hans de Goede
Hi, On 11/21/21 12:00, Hans de Goede wrote: > After the recent refactoring of the backlight code the contents of > intel_panel_actually_set_backlight() is exactly the same (minus a > small wording difference in the drm_dbg_kms() as the contents if the > more widely used intel_backlight_set_pwm_lev

Re: [PATCH 2/2] drm/i915/backlight: Make ext_pwm_disable_backlight() call intel_backlight_set_pwm_level()

2021-11-22 Thread Lyude Paul
Reviewed-by: Lyude Paul On Sun, 2021-11-21 at 12:00 +0100, Hans de Goede wrote: > At least the Bay Trail LPSS PWM controller used with DSI panels on many > Bay Trail tablets seems to leave the PWM pin in whatever state it was > (high or low) ATM that the PWM gets disabled. Combined with some pane

Re: [PATCH 2/2] drm/i915/backlight: Make ext_pwm_disable_backlight() call intel_backlight_set_pwm_level()

2021-11-22 Thread Jani Nikula
On Sun, 21 Nov 2021, Hans de Goede wrote: > At least the Bay Trail LPSS PWM controller used with DSI panels on many > Bay Trail tablets seems to leave the PWM pin in whatever state it was > (high or low) ATM that the PWM gets disabled. Combined with some panels > not having a separate backlight-en

Re: [PATCH 1/2] drm/i915/backlight: Drop duplicate intel_panel_actually_set_backlight()

2021-11-22 Thread Jani Nikula
On Sun, 21 Nov 2021, Hans de Goede wrote: > After the recent refactoring of the backlight code the contents of > intel_panel_actually_set_backlight() is exactly the same (minus a > small wording difference in the drm_dbg_kms() as the contents if the > more widely used intel_backlight_set_pwm_level

[PATCH 2/2] drm/i915/backlight: Make ext_pwm_disable_backlight() call intel_backlight_set_pwm_level()

2021-11-21 Thread Hans de Goede
At least the Bay Trail LPSS PWM controller used with DSI panels on many Bay Trail tablets seems to leave the PWM pin in whatever state it was (high or low) ATM that the PWM gets disabled. Combined with some panels not having a separate backlight-enable pin this leads to the backlight sometimes stay

[PATCH 1/2] drm/i915/backlight: Drop duplicate intel_panel_actually_set_backlight()

2021-11-21 Thread Hans de Goede
After the recent refactoring of the backlight code the contents of intel_panel_actually_set_backlight() is exactly the same (minus a small wording difference in the drm_dbg_kms() as the contents if the more widely used intel_backlight_set_pwm_level() function. Drop the duplicate intel_panel_actual

Re: [PATCH v2 22/24] drm/i915: Backlight update

2020-09-02 Thread Jani Nikula
On Sun, 23 Aug 2020, Sam Ravnborg wrote: > Update backlight implementation to utilize newly added backlight > functionality. > > - Use macros for initialization > - Replace direct access to backlight_properties with get and set > operations > - Moved enable/disable after registering backlight de

[PATCH v2 22/24] drm/i915: Backlight update

2020-08-23 Thread Sam Ravnborg
Update backlight implementation to utilize newly added backlight functionality. - Use macros for initialization - Replace direct access to backlight_properties with get and set operations - Moved enable/disable after registering backlight device One side-effect of these changes is that the conf

[PATCH v1 20/22] drm/i915: Backlight update

2020-08-02 Thread Sam Ravnborg
Update backlight implementation to utilize newly added backlight functionality. - Use macros for initialization - Replace direct access to backlight_properties with get and set operations - Dropped extra checks as some methods accepts a NULL backlight device. One side-effect of these changes is

[v3 7/7] drm/i915: Backlight control using CRC PMIC based PWM driver

2015-06-26 Thread Shobhit Kumar
Use the CRC PWM device in intel_panel.c and add new MIPI backlight specififc callbacks v2: Modify to use pwm_config callback v3: Addressed Jani's comments - Renamed all function as pwm_* instead of vlv_* - Call intel_panel_actually_set_backlight in enable function - Return -ENODEV in c

[Intel-gfx] [v2 7/7] drm/i915: Backlight control using CRC PMIC based PWM driver

2015-06-26 Thread Jani Nikula
On Thu, 25 Jun 2015, Shobhit Kumar wrote: > On Thu, Jun 25, 2015 at 2:18 PM, Ville Syrjälä > wrote: >> On Mon, Jun 22, 2015 at 04:24:25PM +0530, Shobhit Kumar wrote: >>> Use the CRC PWM device in intel_panel.c and add new MIPI backlight >>> specififc callbacks >>> >>> v2: Modify to use pwm_conf

[Intel-gfx] [v2 7/7] drm/i915: Backlight control using CRC PMIC based PWM driver

2015-06-25 Thread Shobhit Kumar
On Thu, Jun 25, 2015 at 6:17 PM, Ville Syrjälä wrote: > On Thu, Jun 25, 2015 at 05:38:50PM +0530, Shobhit Kumar wrote: >> On Thu, Jun 25, 2015 at 2:18 PM, Ville Syrjälä >> wrote: >> > On Mon, Jun 22, 2015 at 04:24:25PM +0530, Shobhit Kumar wrote: >> >> Use the CRC PWM device in intel_panel.c

[Intel-gfx] [v2 7/7] drm/i915: Backlight control using CRC PMIC based PWM driver

2015-06-25 Thread Shobhit Kumar
On Thu, Jun 25, 2015 at 2:18 PM, Ville Syrjälä wrote: > On Mon, Jun 22, 2015 at 04:24:25PM +0530, Shobhit Kumar wrote: >> Use the CRC PWM device in intel_panel.c and add new MIPI backlight >> specififc callbacks >> >> v2: Modify to use pwm_config callback >> v3: Addressed Jani's comments >>

[Intel-gfx] [v2 7/7] drm/i915: Backlight control using CRC PMIC based PWM driver

2015-06-25 Thread Ville Syrjälä
On Thu, Jun 25, 2015 at 05:38:50PM +0530, Shobhit Kumar wrote: > On Thu, Jun 25, 2015 at 2:18 PM, Ville Syrjälä > wrote: > > On Mon, Jun 22, 2015 at 04:24:25PM +0530, Shobhit Kumar wrote: > >> Use the CRC PWM device in intel_panel.c and add new MIPI backlight > >> specififc callbacks > >> > >> v

[Intel-gfx] [v2 7/7] drm/i915: Backlight control using CRC PMIC based PWM driver

2015-06-25 Thread Ville Syrjälä
On Mon, Jun 22, 2015 at 04:24:25PM +0530, Shobhit Kumar wrote: > Use the CRC PWM device in intel_panel.c and add new MIPI backlight > specififc callbacks > > v2: Modify to use pwm_config callback > v3: Addressed Jani's comments > - Renamed all function as pwm_* instead of vlv_* > - Call in

[v2 7/7] drm/i915: Backlight control using CRC PMIC based PWM driver

2015-06-22 Thread Shobhit Kumar
Use the CRC PWM device in intel_panel.c and add new MIPI backlight specififc callbacks v2: Modify to use pwm_config callback v3: Addressed Jani's comments - Renamed all function as pwm_* instead of vlv_* - Call intel_panel_actually_set_backlight in enable function - Return -ENODEV in c

[PATCH 8/8] drm/i915: Backlight control using CRC PMIC based PWM driver

2015-05-06 Thread Jani Nikula
On Wed, 29 Apr 2015, Shobhit Kumar wrote: > Use the CRC PWM device in intel_panel.c and add new MIPI backlight > specififc callbacks > > v2: Modify to use pwm_config callback > > CC: Samuel Ortiz > Cc: Linus Walleij > Cc: Alexandre Courbot > Cc: Thierry Reding > Signed-off-by: Shobhit Kumar >

[PATCH 8/8] drm/i915: Backlight control using CRC PMIC based PWM driver

2015-04-29 Thread Shobhit Kumar
Use the CRC PWM device in intel_panel.c and add new MIPI backlight specififc callbacks v2: Modify to use pwm_config callback CC: Samuel Ortiz Cc: Linus Walleij Cc: Alexandre Courbot Cc: Thierry Reding Signed-off-by: Shobhit Kumar --- drivers/gpu/drm/i915/intel_drv.h | 5 +++ drivers/gpu/

[BUG] drm/i915: backlight off after resume

2015-01-09 Thread Jani Nikula
On Fri, 09 Jan 2015, Jeremiah Mahler wrote: > Jani, all, > > On a Lenovo X1 Carbon if the display is off when suspend is entered > it will be off when it is resumed. A key must be pressed to restore > normal brightness. Please file a bug on [1] and attach dmesg with drm.debug=14 set, from boot t

[BUG] drm/i915: backlight off after resume

2015-01-08 Thread Jeremiah Mahler
Jani, all, On a Lenovo X1 Carbon if the display is off when suspend is entered it will be off when it is resumed. A key must be pressed to restore normal brightness. xset dpms force off sleep 1 sudo systemctl suspend (resume) (screen off, press any key) The behavior I am accustomed to

i915 backlight

2013-08-05 Thread Daniel Vetter
On Fri, Aug 02, 2013 at 09:16:03AM +0800, Aaron Lu wrote: > Hi Jani & Daniel, > > It turned out there is an integer overflow problem, and the below patch > fixed this problem on Acer Aspire 4732Z and thinkpad R61i. > > From: Aaron Lu > Subject: [PATCH] drm/i915: avoid brightness overflow when do

Re: i915 backlight

2013-08-05 Thread Daniel Vetter
On Fri, Aug 02, 2013 at 09:16:03AM +0800, Aaron Lu wrote: > Hi Jani & Daniel, > > It turned out there is an integer overflow problem, and the below patch > fixed this problem on Acer Aspire 4732Z and thinkpad R61i. > > From: Aaron Lu > Subject: [PATCH] drm/i915: avoid brightness overflow when do

Re: i915 backlight

2013-08-03 Thread Josep Lladonosa
On 2 August 2013 23:25, Felipe Contreras wrote: > On Fri, Aug 2, 2013 at 3:11 PM, Josep Lladonosa wrote: >> "Before" means with previous kernels that worked with >> >> GRUB_CMDLINE_LINUX="acpi_osi=Linux acpi_backlight=vendor" > > That's probably a different issue. You would need to bisect the pro

Re: i915 backlight

2013-08-03 Thread Josep Lladonosa
"Before" means with previous kernels that worked with GRUB_CMDLINE_LINUX="acpi_osi=Linux acpi_backlight=vendor" I have not checked this issue with acpi_osi="!Windows 2012". Josep On 2 August 2013 22:08, Felipe Contreras wrote: > On Fri, Aug 2, 2013 at 3:03 PM, Josep Lladonosa wrote: >> With t

Re: i915 backlight

2013-08-03 Thread Josep Lladonosa
Hi, With this setup, something has happened: in xorg, when screen goes to screensaver and after, enters into Standby mode, when I press a key, it keeps black and, to recover screen, I have to adjust brightness manually (by increasing), as if it didn't remember previous value to standby mode. This

i915 backlight

2013-08-03 Thread Rafael J. Wysocki
On Friday, August 02, 2013 01:58:55 PM Felipe Contreras wrote: > On Fri, Aug 2, 2013 at 9:03 AM, Rafael J. Wysocki wrote: > > On Friday, August 02, 2013 01:48:37 AM Felipe Contreras wrote: > >> On Fri, Aug 2, 2013 at 1:25 AM, Josep Lladonosa > >> wrote: > >> > Hello, > >> > > >> > I am using a L

i915 backlight

2013-08-03 Thread Josep Lladonosa
On 2 August 2013 23:25, Felipe Contreras wrote: > On Fri, Aug 2, 2013 at 3:11 PM, Josep Lladonosa wrote: >> "Before" means with previous kernels that worked with >> >> GRUB_CMDLINE_LINUX="acpi_osi=Linux acpi_backlight=vendor" > > That's probably a different issue. You would need to bisect the pro

i915 backlight

2013-08-02 Thread Borislav Petkov
On Fri, Aug 02, 2013 at 10:11:27PM +0200, Josep Lladonosa wrote: > "Before" means with previous kernels that worked with > > GRUB_CMDLINE_LINUX="acpi_osi=Linux acpi_backlight=vendor" > > I have not checked this issue with acpi_osi="!Windows 2012". Hey Josep, would you please not top-post when y

i915 backlight

2013-08-02 Thread Josep Lladonosa
"Before" means with previous kernels that worked with GRUB_CMDLINE_LINUX="acpi_osi=Linux acpi_backlight=vendor" I have not checked this issue with acpi_osi="!Windows 2012". Josep On 2 August 2013 22:08, Felipe Contreras wrote: > On Fri, Aug 2, 2013 at 3:03 PM, Josep Lladonosa wrote: >> With t

i915 backlight

2013-08-02 Thread Josep Lladonosa
Hi, With this setup, something has happened: in xorg, when screen goes to screensaver and after, enters into Standby mode, when I press a key, it keeps black and, to recover screen, I have to adjust brightness manually (by increasing), as if it didn't remember previous value to standby mode. This

i915 backlight

2013-08-02 Thread Felipe Contreras
On Fri, Aug 2, 2013 at 6:35 PM, Rafael J. Wysocki wrote: > On Friday, August 02, 2013 01:58:55 PM Felipe Contreras wrote: >> On Fri, Aug 2, 2013 at 9:03 AM, Rafael J. Wysocki wrote: >> > On Friday, August 02, 2013 01:48:37 AM Felipe Contreras wrote: >> >> I think it's pretty obvious that for the

Re: i915 backlight

2013-08-02 Thread Felipe Contreras
On Fri, Aug 2, 2013 at 6:35 PM, Rafael J. Wysocki wrote: > On Friday, August 02, 2013 01:58:55 PM Felipe Contreras wrote: >> On Fri, Aug 2, 2013 at 9:03 AM, Rafael J. Wysocki wrote: >> > On Friday, August 02, 2013 01:48:37 AM Felipe Contreras wrote: >> >> I think it's pretty obvious that for the

Re: i915 backlight

2013-08-02 Thread Rafael J. Wysocki
On Friday, August 02, 2013 01:58:55 PM Felipe Contreras wrote: > On Fri, Aug 2, 2013 at 9:03 AM, Rafael J. Wysocki wrote: > > On Friday, August 02, 2013 01:48:37 AM Felipe Contreras wrote: > >> On Fri, Aug 2, 2013 at 1:25 AM, Josep Lladonosa wrote: > >> > Hello, > >> > > >> > I am using a Lenovo

i915 backlight

2013-08-02 Thread Felipe Contreras
On Fri, Aug 2, 2013 at 3:11 PM, Josep Lladonosa wrote: > "Before" means with previous kernels that worked with > > GRUB_CMDLINE_LINUX="acpi_osi=Linux acpi_backlight=vendor" That's probably a different issue. You would need to bisect the problem. > I have not checked this issue with acpi_osi="!Wi

i915 backlight

2013-08-02 Thread Rafael J. Wysocki
On Friday, August 02, 2013 01:48:37 AM Felipe Contreras wrote: > On Fri, Aug 2, 2013 at 1:25 AM, Josep Lladonosa wrote: > > Hello, > > > > I am using a Lenovo Edge E530 and, with kernel 3.11.0-rc3, I had to > > change to this parameter to the kernel boot: > > > > > > GRUB_CMDLINE_LINUX="acpi_osi=\

i915 backlight

2013-08-02 Thread Felipe Contreras
On Fri, Aug 2, 2013 at 3:03 PM, Josep Lladonosa wrote: > With this setup, something has happened: in xorg, when screen goes to > screensaver and after, enters into Standby mode, when I press a key, > it keeps black and, to recover screen, I have to adjust brightness > manually (by increasing), as

i915 backlight

2013-08-02 Thread Aaron Lu
On 08/02/2013 02:25 PM, Josep Lladonosa wrote: > Hello, > > I am using a Lenovo Edge E530 and, with kernel 3.11.0-rc3, I had to > change to this parameter to the kernel boot: > > > GRUB_CMDLINE_LINUX="acpi_osi=\"!Windows 2012\"" What if you remove the above from kernel command line, and add vid

Re: i915 backlight

2013-08-02 Thread Felipe Contreras
On Fri, Aug 2, 2013 at 3:11 PM, Josep Lladonosa wrote: > "Before" means with previous kernels that worked with > > GRUB_CMDLINE_LINUX="acpi_osi=Linux acpi_backlight=vendor" That's probably a different issue. You would need to bisect the problem. > I have not checked this issue with acpi_osi="!Wi

i915 backlight

2013-08-02 Thread Aaron Lu
On 08/01/2013 04:07 PM, Borislav Petkov wrote: > On Wed, Jul 31, 2013 at 11:16:52PM +0200, Rafael J. Wysocki wrote: >> Does reverting efaa14c help? > > Nope. > > But see my other reply to Aaron. Assume you have specified to use intel_backlight in xorg.conf, does booting with video.brightness_swi

i915 backlight

2013-08-02 Thread Felipe Contreras
On Fri, Aug 2, 2013 at 9:03 AM, Rafael J. Wysocki wrote: > On Friday, August 02, 2013 01:48:37 AM Felipe Contreras wrote: >> On Fri, Aug 2, 2013 at 1:25 AM, Josep Lladonosa >> wrote: >> > Hello, >> > >> > I am using a Lenovo Edge E530 and, with kernel 3.11.0-rc3, I had to >> > change to this par

Re: i915 backlight

2013-08-02 Thread Borislav Petkov
On Fri, Aug 02, 2013 at 10:11:27PM +0200, Josep Lladonosa wrote: > "Before" means with previous kernels that worked with > > GRUB_CMDLINE_LINUX="acpi_osi=Linux acpi_backlight=vendor" > > I have not checked this issue with acpi_osi="!Windows 2012". Hey Josep, would you please not top-post when y

Re: i915 backlight

2013-08-02 Thread Felipe Contreras
On Fri, Aug 2, 2013 at 3:03 PM, Josep Lladonosa wrote: > With this setup, something has happened: in xorg, when screen goes to > screensaver and after, enters into Standby mode, when I press a key, > it keeps black and, to recover screen, I have to adjust brightness > manually (by increasing), as

Re: i915 backlight

2013-08-02 Thread Felipe Contreras
On Fri, Aug 2, 2013 at 9:03 AM, Rafael J. Wysocki wrote: > On Friday, August 02, 2013 01:48:37 AM Felipe Contreras wrote: >> On Fri, Aug 2, 2013 at 1:25 AM, Josep Lladonosa wrote: >> > Hello, >> > >> > I am using a Lenovo Edge E530 and, with kernel 3.11.0-rc3, I had to >> > change to this paramet

i915 backlight

2013-08-02 Thread Borislav Petkov
On Fri, Aug 02, 2013 at 09:16:03AM +0800, Aaron Lu wrote: > Since the sysfs interface works on your system, I think your problem > should be different. Can you please file a bug for this? I can provide > you with a debug patch and then see what happened. Please attach > acpidump when filing the bug

i915 backlight

2013-08-02 Thread Borislav Petkov
On Fri, Aug 02, 2013 at 02:00:42PM +0800, Aaron Lu wrote: > Assume you have specified to use intel_backlight in xorg.conf Right, I have: Section "Device" Option "Backlight" "intel_backlight" Identifier "Card0" Driver "intel" BusID "PCI:0:2:0" EndSe

i915 backlight

2013-08-02 Thread Josep Lladonosa
Hello, Yes, it works! I get now 11 levels from all black to the brightest. acpi_listen shows messages Josep On 2 August 2013 08:36, Aaron Lu wrote: > On 08/02/2013 02:25 PM, Josep Lladonosa wrote: >> Hello, >> >> I am using a Lenovo Edge E530 and, with kernel 3.11.0-rc3, I had to >> change to

i915 backlight

2013-08-02 Thread Aaron Lu
On 08/01/2013 05:07 PM, Aaron Lu wrote: > On 08/01/2013 04:12 PM, Borislav Petkov wrote: >> On Thu, Aug 01, 2013 at 09:13:35AM +0800, Aaron Lu wrote: >>> Can you please run acpi_listen and then press the Fn-Fx key, see if the >>> events are correctly sent out? >> >> Like this? >> >> # acpi_listen >

i915 backlight

2013-08-02 Thread Josep Lladonosa
Hello, I am using a Lenovo Edge E530 and, with kernel 3.11.0-rc3, I had to change to this parameter to the kernel boot: GRUB_CMDLINE_LINUX="acpi_osi=\"!Windows 2012\"" instead of previous GRUB_CMDLINE_LINUX="acpi_osi=Linux acpi_backlight=vendor" to be able to change brightness. In some kerne

Re: i915 backlight

2013-08-02 Thread Aaron Lu
On 08/02/2013 02:25 PM, Josep Lladonosa wrote: > Hello, > > I am using a Lenovo Edge E530 and, with kernel 3.11.0-rc3, I had to > change to this parameter to the kernel boot: > > > GRUB_CMDLINE_LINUX="acpi_osi=\"!Windows 2012\"" What if you remove the above from kernel command line, and add vid

Re: i915 backlight

2013-08-02 Thread Aaron Lu
On 08/01/2013 04:07 PM, Borislav Petkov wrote: > On Wed, Jul 31, 2013 at 11:16:52PM +0200, Rafael J. Wysocki wrote: >> Does reverting efaa14c help? > > Nope. > > But see my other reply to Aaron. Assume you have specified to use intel_backlight in xorg.conf, does booting with video.brightness_swi

Re: i915 backlight

2013-08-02 Thread Josep Lladonosa
Hello, Yes, it works! I get now 11 levels from all black to the brightest. acpi_listen shows messages Josep On 2 August 2013 08:36, Aaron Lu wrote: > On 08/02/2013 02:25 PM, Josep Lladonosa wrote: >> Hello, >> >> I am using a Lenovo Edge E530 and, with kernel 3.11.0-rc3, I had to >> change to

Re: i915 backlight

2013-08-02 Thread Josep Lladonosa
Hello, I am using a Lenovo Edge E530 and, with kernel 3.11.0-rc3, I had to change to this parameter to the kernel boot: GRUB_CMDLINE_LINUX="acpi_osi=\"!Windows 2012\"" instead of previous GRUB_CMDLINE_LINUX="acpi_osi=Linux acpi_backlight=vendor" to be able to change brightness. In some kerne

Re: i915 backlight

2013-08-02 Thread Rafael J. Wysocki
On Friday, August 02, 2013 01:48:37 AM Felipe Contreras wrote: > On Fri, Aug 2, 2013 at 1:25 AM, Josep Lladonosa wrote: > > Hello, > > > > I am using a Lenovo Edge E530 and, with kernel 3.11.0-rc3, I had to > > change to this parameter to the kernel boot: > > > > > > GRUB_CMDLINE_LINUX="acpi_osi=\

i915 backlight

2013-08-02 Thread Felipe Contreras
On Fri, Aug 2, 2013 at 1:25 AM, Josep Lladonosa wrote: > Hello, > > I am using a Lenovo Edge E530 and, with kernel 3.11.0-rc3, I had to > change to this parameter to the kernel boot: > > > GRUB_CMDLINE_LINUX="acpi_osi=\"!Windows 2012\"" I think it's pretty obvious that for the time being we need

Re: i915 backlight

2013-08-02 Thread Borislav Petkov
On Fri, Aug 02, 2013 at 09:16:03AM +0800, Aaron Lu wrote: > Since the sysfs interface works on your system, I think your problem > should be different. Can you please file a bug for this? I can provide > you with a debug patch and then see what happened. Please attach > acpidump when filing the bug

Re: i915 backlight

2013-08-02 Thread Borislav Petkov
On Fri, Aug 02, 2013 at 02:00:42PM +0800, Aaron Lu wrote: > Assume you have specified to use intel_backlight in xorg.conf Right, I have: Section "Device" Option "Backlight" "intel_backlight" Identifier "Card0" Driver "intel" BusID "PCI:0:2:0" EndSe

Re: i915 backlight

2013-08-01 Thread Felipe Contreras
On Fri, Aug 2, 2013 at 1:25 AM, Josep Lladonosa wrote: > Hello, > > I am using a Lenovo Edge E530 and, with kernel 3.11.0-rc3, I had to > change to this parameter to the kernel boot: > > > GRUB_CMDLINE_LINUX="acpi_osi=\"!Windows 2012\"" I think it's pretty obvious that for the time being we need

Re: i915 backlight

2013-08-01 Thread Aaron Lu
On 08/01/2013 05:07 PM, Aaron Lu wrote: > On 08/01/2013 04:12 PM, Borislav Petkov wrote: >> On Thu, Aug 01, 2013 at 09:13:35AM +0800, Aaron Lu wrote: >>> Can you please run acpi_listen and then press the Fn-Fx key, see if the >>> events are correctly sent out? >> >> Like this? >> >> # acpi_listen >

Re: i915 backlight

2013-08-01 Thread Aaron Lu
On 08/01/2013 04:12 PM, Borislav Petkov wrote: > On Thu, Aug 01, 2013 at 09:13:35AM +0800, Aaron Lu wrote: >> Can you please run acpi_listen and then press the Fn-Fx key, see if the >> events are correctly sent out? > > Like this? > > # acpi_listen > video/brightnessdown BRTDN 0087 >

Re: i915 backlight

2013-08-01 Thread Aaron Lu
On 08/01/2013 12:36 AM, Borislav Petkov wrote: > On Wed, Jul 31, 2013 at 06:22:52PM +0200, Borislav Petkov wrote: >> Dudes, >> >> has anyone already reported this (happens on Linus of today + >> tip/master): > > Oh, one more thing: I can't control the backlight anymore on this x230 > with the Fn-F

i915 backlight

2013-08-01 Thread Aaron Lu
On 08/01/2013 04:12 PM, Borislav Petkov wrote: > On Thu, Aug 01, 2013 at 09:13:35AM +0800, Aaron Lu wrote: >> Can you please run acpi_listen and then press the Fn-Fx key, see if the >> events are correctly sent out? > > Like this? > > # acpi_listen > video/brightnessdown BRTDN 0087 >

i915 backlight

2013-08-01 Thread Borislav Petkov
On Thu, Aug 01, 2013 at 09:13:35AM +0800, Aaron Lu wrote: > Can you please run acpi_listen and then press the Fn-Fx key, see if the > events are correctly sent out? Like this? # acpi_listen video/brightnessdown BRTDN 0087 video/brightnessup BRTUP 0086 video/brightnessdow

i915 backlight

2013-08-01 Thread Borislav Petkov
On Wed, Jul 31, 2013 at 11:16:52PM +0200, Rafael J. Wysocki wrote: > Does reverting efaa14c help? Nope. But see my other reply to Aaron. Thanks.

i915 backlight

2013-08-01 Thread Aaron Lu
On 08/01/2013 12:36 AM, Borislav Petkov wrote: > On Wed, Jul 31, 2013 at 06:22:52PM +0200, Borislav Petkov wrote: >> Dudes, >> >> has anyone already reported this (happens on Linus of today + >> tip/master): > > Oh, one more thing: I can't control the backlight anymore on this x230 > with the Fn-F

Re: i915 backlight

2013-08-01 Thread Borislav Petkov
On Thu, Aug 01, 2013 at 09:13:35AM +0800, Aaron Lu wrote: > Can you please run acpi_listen and then press the Fn-Fx key, see if the > events are correctly sent out? Like this? # acpi_listen video/brightnessdown BRTDN 0087 video/brightnessup BRTUP 0086 video/brightnessdow

Re: i915 backlight

2013-08-01 Thread Borislav Petkov
On Wed, Jul 31, 2013 at 11:16:52PM +0200, Rafael J. Wysocki wrote: > Does reverting efaa14c help? Nope. But see my other reply to Aaron. Thanks. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dr

i915 backlight

2013-07-31 Thread Rafael J. Wysocki
On Wednesday, July 31, 2013 06:36:23 PM Borislav Petkov wrote: > On Wed, Jul 31, 2013 at 06:22:52PM +0200, Borislav Petkov wrote: > > Dudes, > > > > has anyone already reported this (happens on Linus of today + > > tip/master): > > Oh, one more thing: I can't control the backlight anymore on this

i915 backlight

2013-07-31 Thread Borislav Petkov
On Wed, Jul 31, 2013 at 06:22:52PM +0200, Borislav Petkov wrote: > Dudes, > > has anyone already reported this (happens on Linus of today + > tip/master): Oh, one more thing: I can't control the backlight anymore on this x230 with the Fn-Fx keys and this is most probably related to that recent ba

Re: i915 backlight

2013-07-31 Thread Rafael J. Wysocki
On Wednesday, July 31, 2013 06:36:23 PM Borislav Petkov wrote: > On Wed, Jul 31, 2013 at 06:22:52PM +0200, Borislav Petkov wrote: > > Dudes, > > > > has anyone already reported this (happens on Linus of today + > > tip/master): > > Oh, one more thing: I can't control the backlight anymore on this

Re: i915 backlight

2013-07-31 Thread Borislav Petkov
On Wed, Jul 31, 2013 at 06:22:52PM +0200, Borislav Petkov wrote: > Dudes, > > has anyone already reported this (happens on Linus of today + > tip/master): Oh, one more thing: I can't control the backlight anymore on this x230 with the Fn-Fx keys and this is most probably related to that recent ba

[i915] Backlight brighter since 3.9.0

2013-06-03 Thread Daniel Vetter
On Mon, Jun 3, 2013 at 9:42 PM, Aaron Plattner wrote: > On 06/03/2013 12:36 PM, Daniel Vetter wrote: >> >> On Mon, Jun 03, 2013 at 09:13:18AM -0700, Aaron Plattner wrote: >>> >>> On 05/20/2013 02:55 PM, Daniel Vetter wrote: On Sat, May 18, 2013 at 12:39:14AM +0200, Jan Hinnerk Stosch wro

[i915] Backlight brighter since 3.9.0

2013-06-03 Thread Daniel Vetter
On Mon, Jun 03, 2013 at 09:13:18AM -0700, Aaron Plattner wrote: > On 05/20/2013 02:55 PM, Daniel Vetter wrote: > >On Sat, May 18, 2013 at 12:39:14AM +0200, Jan Hinnerk Stosch wrote: > >>Hallo, > >> > >>I hope this is the right place to ask, because I actually don't know > >>whether it is a bug or a

[i915] Backlight brighter since 3.9.0

2013-06-03 Thread Alex Deucher
On Mon, Jun 3, 2013 at 4:03 PM, Daniel Vetter wrote: > On Mon, Jun 3, 2013 at 9:42 PM, Aaron Plattner > wrote: >> On 06/03/2013 12:36 PM, Daniel Vetter wrote: >>> >>> On Mon, Jun 03, 2013 at 09:13:18AM -0700, Aaron Plattner wrote: On 05/20/2013 02:55 PM, Daniel Vetter wrote: >

Re: [i915] Backlight brighter since 3.9.0

2013-06-03 Thread Alex Deucher
On Mon, Jun 3, 2013 at 4:03 PM, Daniel Vetter wrote: > On Mon, Jun 3, 2013 at 9:42 PM, Aaron Plattner wrote: >> On 06/03/2013 12:36 PM, Daniel Vetter wrote: >>> >>> On Mon, Jun 03, 2013 at 09:13:18AM -0700, Aaron Plattner wrote: On 05/20/2013 02:55 PM, Daniel Vetter wrote: > > O

Re: [i915] Backlight brighter since 3.9.0

2013-06-03 Thread Daniel Vetter
On Mon, Jun 3, 2013 at 9:42 PM, Aaron Plattner wrote: > On 06/03/2013 12:36 PM, Daniel Vetter wrote: >> >> On Mon, Jun 03, 2013 at 09:13:18AM -0700, Aaron Plattner wrote: >>> >>> On 05/20/2013 02:55 PM, Daniel Vetter wrote: On Sat, May 18, 2013 at 12:39:14AM +0200, Jan Hinnerk Stosch wro

Re: [i915] Backlight brighter since 3.9.0

2013-06-03 Thread Aaron Plattner
On 06/03/2013 12:36 PM, Daniel Vetter wrote: On Mon, Jun 03, 2013 at 09:13:18AM -0700, Aaron Plattner wrote: On 05/20/2013 02:55 PM, Daniel Vetter wrote: On Sat, May 18, 2013 at 12:39:14AM +0200, Jan Hinnerk Stosch wrote: Hallo, I hope this is the right place to ask, because I actually don't

[i915] Backlight brighter since 3.9.0

2013-06-03 Thread Aaron Plattner
On 06/03/2013 12:36 PM, Daniel Vetter wrote: > On Mon, Jun 03, 2013 at 09:13:18AM -0700, Aaron Plattner wrote: >> On 05/20/2013 02:55 PM, Daniel Vetter wrote: >>> On Sat, May 18, 2013 at 12:39:14AM +0200, Jan Hinnerk Stosch wrote: Hallo, I hope this is the right place to ask, because

Re: [i915] Backlight brighter since 3.9.0

2013-06-03 Thread Daniel Vetter
On Mon, Jun 03, 2013 at 09:13:18AM -0700, Aaron Plattner wrote: > On 05/20/2013 02:55 PM, Daniel Vetter wrote: > >On Sat, May 18, 2013 at 12:39:14AM +0200, Jan Hinnerk Stosch wrote: > >>Hallo, > >> > >>I hope this is the right place to ask, because I actually don't know > >>whether it is a bug or a

Re: [i915] Backlight brighter since 3.9.0

2013-06-03 Thread Aaron Plattner
On 05/20/2013 02:55 PM, Daniel Vetter wrote: On Sat, May 18, 2013 at 12:39:14AM +0200, Jan Hinnerk Stosch wrote: Hallo, I hope this is the right place to ask, because I actually don't know whether it is a bug or a feature that I'm experiencing since linux 3.9: When I boot my system the backligh

[i915] Backlight brighter since 3.9.0

2013-06-03 Thread Aaron Plattner
On 05/20/2013 02:55 PM, Daniel Vetter wrote: > On Sat, May 18, 2013 at 12:39:14AM +0200, Jan Hinnerk Stosch wrote: >> Hallo, >> >> I hope this is the right place to ask, because I actually don't know >> whether it is a bug or a feature that I'm experiencing since linux 3.9: >> When I boot my system

[i915] Backlight brighter since 3.9.0

2013-05-22 Thread Daniel Vetter
On Wed, May 22, 2013 at 6:08 PM, Joakim Plate wrote: >> 2013/5/20 Daniel Vetter ffwll.ch> >> Yeah, this is a feature. HDMI has (for oddball backwards compat with >> analog TV signals) a special mode which reduces the useable RGB value >> range by chopping off about 10% at the bottom and top end.

[i915] Backlight brighter since 3.9.0

2013-05-22 Thread Joakim Plate
Hi, > > 2013/5/20 Daniel Vetter ffwll.ch> > Yeah, this is a feature. HDMI has (for oddball backwards compat with > analog TV signals) a special mode which reduces the useable RGB value > range by chopping off about 10% at the bottom and top end. This results in > light colors getting brighter an

Re: [i915] Backlight brighter since 3.9.0

2013-05-22 Thread Daniel Vetter
On Wed, May 22, 2013 at 6:08 PM, Joakim Plate wrote: >> 2013/5/20 Daniel Vetter ffwll.ch> >> Yeah, this is a feature. HDMI has (for oddball backwards compat with >> analog TV signals) a special mode which reduces the useable RGB value >> range by chopping off about 10% at the bottom and top end.

Re: [i915] Backlight brighter since 3.9.0

2013-05-22 Thread Joakim Plate
Hi, > > 2013/5/20 Daniel Vetter ffwll.ch> > Yeah, this is a feature. HDMI has (for oddball backwards compat with > analog TV signals) a special mode which reduces the useable RGB value > range by chopping off about 10% at the bottom and top end. This results in > light colors getting brighter an

  1   2   >