i915/kms/backlight-combo mode problem

2011-05-17 Thread Michael Chang
Melchior, I want to double check with you. If you change brightness from lowest to highest, the LPBC value changes this way Highest Lowest 0x10 , 0x19 .. 0xe5 And vice versa, from Lowest to Highest Lowest Highest 0xe5 , .. 0x19 0x

i915/kms/backlight-combo mode problem

2011-05-17 Thread Michael Chang
2011/5/16 Melchior FRANZ : > I don't even know what an LBPC is, other than a variable named like that. > So I'd need a hint for how to test that. It resides at your vga adapter's pci configuration space, offset 0xf4. You can know your LPBC value by: $ lspci -xxx -s 00:02.0 | awk '/^f0:/ {print

i915/kms/backlight-combo mode problem

2011-05-17 Thread Melchior FRANZ
Hey, * Michael Chang -- Tuesday 17 May 2011: > If you change brightness from lowest to highest, the LPBC value changes > this way > > Highest Lowest > 0x10 , 0x19 .. 0xe5 Yes. (Though it's 0x01, not 0x10.) ---0xFF ... initial value and after closing/reopening l

i915/kms/backlight-combo mode problem

2011-05-17 Thread Melchior FRANZ
* Michael Chang -- Tuesday 17 May 2011: [LBPC] > You can know your LPBC value by: > $ lspci -xxx -s 00:02.0 | awk '/^f0:/ {print $6}' > > And alter it's value via setpci (assuming set it to max) > $ setpci -s 00:02.0 F4.B=ff > > I assume you've tried this .. as you report setpci works for you

Re: i915/kms/backlight-combo mode problem

2011-05-17 Thread Melchior FRANZ
Hey, * Michael Chang -- Tuesday 17 May 2011: > If you change brightness from lowest to highest, the LPBC value changes > this way > > Highest Lowest > 0x10 , 0x19 .. 0xe5 Yes. (Though it's 0x01, not 0x10.) ---0xFF ... initial value and after closing/reopening l

Re: i915/kms/backlight-combo mode problem

2011-05-17 Thread Michael Chang
Melchior, I want to double check with you. If you change brightness from lowest to highest, the LPBC value changes this way Highest Lowest 0x10 , 0x19 .. 0xe5 And vice versa, from Lowest to Highest Lowest Highest 0xe5 , .. 0x19 0x

Re: i915/kms/backlight-combo mode problem

2011-05-17 Thread Melchior FRANZ
* Michael Chang -- Tuesday 17 May 2011: [LBPC] > You can know your LPBC value by: > $ lspci -xxx -s 00:02.0 | awk '/^f0:/ {print $6}' > > And alter it's value via setpci (assuming set it to max) > $ setpci -s 00:02.0 F4.B=ff > > I assume you've tried this .. as you report setpci works for you

Re: i915/kms/backlight-combo mode problem

2011-05-17 Thread Michael Chang
2011/5/16 Melchior FRANZ : > I don't even know what an LBPC is, other than a variable named like that. > So I'd need a hint for how to test that. It resides at your vga adapter's pci configuration space, offset 0xf4. You can know your LPBC value by: $ lspci -xxx -s 00:02.0 | awk '/^f0:/ {print

i915/kms/backlight-combo mode problem

2011-05-16 Thread Melchior FRANZ
* Takashi Iwai -- Sunday 15 May 2011: > IIRC, you reported that the backlight gets normal when you revert my > commit in 2.6.38.x. So, this was regarded as a regression at first. Yes. And it *is* a regression, which is the whole point of my initial complaint, as reported by Maciej in https://bug

Re: i915/kms/backlight-combo mode problem

2011-05-16 Thread Melchior FRANZ
* Takashi Iwai -- Sunday 15 May 2011: > IIRC, you reported that the backlight gets normal when you revert my > commit in 2.6.38.x. So, this was regarded as a regression at first. Yes. And it *is* a regression, which is the whole point of my initial complaint, as reported by Maciej in https://bug

i915/kms/backlight-combo mode problem

2011-05-15 Thread Melchior FRANZ
Hey, * Michael Chang -- Friday 13 May 2011: > But there's more questions in my mind, made me feel not > able to proceed any further.. :( No problem. The reason for inconsistencies in my reports is simply that I've realized some properties only later. So here's a new error description, based on dd

i915/kms/backlight-combo mode problem

2011-05-15 Thread Takashi Iwai
At Tue, 10 May 2011 13:08:23 +0200, Melchior FRANZ wrote: > > * Michael Chang -- Tuesday 10 May 2011: > > Could you please try this patch and get the log ? We wonder why > > is_backlight_combination_mode () returns false. > > This information was already buried in the bugzilla thread: > > http

Re: i915/kms/backlight-combo mode problem

2011-05-15 Thread Melchior FRANZ
Hey, * Michael Chang -- Friday 13 May 2011: > But there's more questions in my mind, made me feel not > able to proceed any further.. :( No problem. The reason for inconsistencies in my reports is simply that I've realized some properties only later. So here's a new error description, based on dd

Re: i915/kms/backlight-combo mode problem

2011-05-15 Thread Takashi Iwai
At Tue, 10 May 2011 13:08:23 +0200, Melchior FRANZ wrote: > > * Michael Chang -- Tuesday 10 May 2011: > > Could you please try this patch and get the log ? We wonder why > > is_backlight_combination_mode () returns false. > > This information was already buried in the bugzilla thread: > > http

i915/kms/backlight-combo mode problem

2011-05-13 Thread Joey Lee
Forward to upstream for more discussion. ? ??2011-05-13 ? 17:27 +0800?Michael Chang ??? > Melchior, > > I tried to puzzle out the possible cause of the problem, but sorry > that no further progress to give you. I'd like to debug this issue, > also did Joey. But there's more questions in my mind,

Re: i915/kms/backlight-combo mode problem

2011-05-13 Thread Joey Lee
Forward to upstream for more discussion. 於 五,2011-05-13 於 17:27 +0800,Michael Chang 提到: > Melchior, > > I tried to puzzle out the possible cause of the problem, but sorry > that no further progress to give you. I'd like to debug this issue, > also did Joey. But there's more questions in my mind,

i915/kms/backlight-combo mode problem

2011-05-10 Thread Melchior FRANZ
* Michael Chang -- Tuesday 10 May 2011: > Could you please try this patch and get the log ? We wonder why > is_backlight_combination_mode () returns false. This information was already buried in the bugzilla thread: https://bugzilla.kernel.org/show_bug.cgi?id=31522 "It turned out that on this

i915/kms/backlight-combo mode problem

2011-05-10 Thread Michael Chang
Melchior, Could you please try this patch and get the log ? We wonder why is_backlight_combination_mode () returns false. We all knew that it returns true during booting (and takashi's fix works to fix the blackscreen for you) and it's unlikely to become false afterward. Perhaps it was changed wro

Re: i915/kms/backlight-combo mode problem

2011-05-10 Thread Melchior FRANZ
* Michael Chang -- Tuesday 10 May 2011: > Could you please try this patch and get the log ? We wonder why > is_backlight_combination_mode () returns false. This information was already buried in the bugzilla thread: https://bugzilla.kernel.org/show_bug.cgi?id=31522 "It turned out that on this

Re: i915/kms/backlight-combo mode problem

2011-05-09 Thread Michael Chang
Melchior, Could you please try this patch and get the log ? We wonder why is_backlight_combination_mode () returns false. We all knew that it returns true during booting (and takashi's fix works to fix the blackscreen for you) and it's unlikely to become false afterward. Perhaps it was changed wro

i915/kms/backlight-combo mode problem

2011-05-09 Thread Michael Chang

i915/kms/backlight-combo mode problem

2011-05-09 Thread Melchior FRANZ
* Joey Lee -- Monday 09 May 2011: > The following is debug patch, and please add kernel parameter > drm.debug=0x02 : The result is with acpi_osi=Linux: boot phase: [3.310274] [drm:intel_panel_get_backlight], get backlight val = 2890 [3.310280] [drm:intel_panel_get_backlight], get backlig

i915/kms/backlight-combo mode problem

2011-05-09 Thread Takashi Iwai
At Mon, 09 May 2011 02:50:50 -0600, Joey Lee wrote: > > Add Cc. Michael Chang for he is our i915 expert. > > Hi Melchior, > > ? ??2011-05-08 ? 16:05 +0200?Melchior FRANZ ??? > > > > > Does it work to you direct control brightness by access > > > by /sys/class/backlight/acer-wmi/brightness ? >

i915/kms/backlight-combo mode problem

2011-05-09 Thread Takashi Iwai
At Sat, 7 May 2011 22:22:40 +0200, Melchior FRANZ wrote: > > * Melchior FRANZ -- Friday 06 May 2011: > > last patch prevents the backlight from being turned off, but it also > > breaks the brightness adjustment keys at runtime with acpi_osi=Linux. > > It has turned out that acpi key events seem t

Re: i915/kms/backlight-combo mode problem

2011-05-09 Thread Michael Chang
>From the log, it looks like is_backlight_combination_mode is evaluated false which contradicts with the topic we are discussed. Regardless of the combination_mode, the log seems to work .. weird. 2011/5/9 Melchior FRANZ > * Joey Lee -- Monday 09 May 2011: > > The following is debug patch, and

i915/kms/backlight-combo mode problem

2011-05-09 Thread Joey Lee
? ??2011-05-09 ? 11:00 +0200?Takashi Iwai ??? > At Mon, 09 May 2011 02:50:50 -0600, > Joey Lee wrote: > > > > We need to know some run time value when intel_panel_set_backlight call by > > funciton key. > > Yes, that'll help understanding. > > > Please help to apply the attached debug patch to

Re: i915/kms/backlight-combo mode problem

2011-05-09 Thread Melchior FRANZ
* Joey Lee -- Monday 09 May 2011: > The following is debug patch, and please add kernel parameter > drm.debug=0x02 : The result is with acpi_osi=Linux: boot phase: [3.310274] [drm:intel_panel_get_backlight], get backlight val = 2890 [3.310280] [drm:intel_panel_get_backlight], get backlig

i915/kms/backlight-combo mode problem

2011-05-09 Thread Joey Lee
Add Cc. Michael Chang for he is our i915 expert. Hi Melchior, ? ??2011-05-08 ? 16:05 +0200?Melchior FRANZ ??? > > > Does it work to you direct control brightness by access > > by /sys/class/backlight/acer-wmi/brightness ? > > No. A number written to this virtual file is accepted and remembered

Re: i915/kms/backlight-combo mode problem

2011-05-09 Thread Joey Lee
於 一,2011-05-09 於 11:00 +0200,Takashi Iwai 提到: > At Mon, 09 May 2011 02:50:50 -0600, > Joey Lee wrote: > > > > We need to know some run time value when intel_panel_set_backlight call by > > funciton key. > > Yes, that'll help understanding. > > > Please help to apply the attached debug patch to

Re: i915/kms/backlight-combo mode problem

2011-05-09 Thread Takashi Iwai
At Mon, 09 May 2011 02:50:50 -0600, Joey Lee wrote: > > Add Cc. Michael Chang for he is our i915 expert. > > Hi Melchior, > > 於 日,2011-05-08 於 16:05 +0200,Melchior FRANZ 提到: > > > > > Does it work to you direct control brightness by access > > > by /sys/class/backlight/acer-wmi/brightness ? >

Re: i915/kms/backlight-combo mode problem

2011-05-09 Thread Takashi Iwai
At Sat, 7 May 2011 22:22:40 +0200, Melchior FRANZ wrote: > > * Melchior FRANZ -- Friday 06 May 2011: > > last patch prevents the backlight from being turned off, but it also > > breaks the brightness adjustment keys at runtime with acpi_osi=Linux. > > It has turned out that acpi key events seem t

Re: i915/kms/backlight-combo mode problem

2011-05-09 Thread Joey Lee
Add Cc. Michael Chang for he is our i915 expert. Hi Melchior, 於 日,2011-05-08 於 16:05 +0200,Melchior FRANZ 提到: > > > Does it work to you direct control brightness by access > > by /sys/class/backlight/acer-wmi/brightness ? > > No. A number written to this virtual file is accepted and remembered

i915/kms/backlight-combo mode problem

2011-05-08 Thread Melchior FRANZ
* Joey Lee -- Sunday 08 May 2011: > ? ??2011-05-07 ? 22:22 +0200?Melchior FRANZ ??? > > It has turned out that acpi key events seem to be handled correctly > > and even the state of /sys/class/backlight/acer-wmi/brightness is > > That's interesting for acer-wmi generated brightness interface when

i915/kms/backlight-combo mode problem

2011-05-08 Thread Joey Lee
? ??2011-05-07 ? 22:22 +0200?Melchior FRANZ ??? > * Melchior FRANZ -- Friday 06 May 2011: > > last patch prevents the backlight from being turned off, but it also > > breaks the brightness adjustment keys at runtime with acpi_osi=Linux. > > It has turned out that acpi key events seem to be handled

Re: i915/kms/backlight-combo mode problem

2011-05-08 Thread Melchior FRANZ
* Joey Lee -- Sunday 08 May 2011: > 於 六,2011-05-07 於 22:22 +0200,Melchior FRANZ 提到: > > It has turned out that acpi key events seem to be handled correctly > > and even the state of /sys/class/backlight/acer-wmi/brightness is > > That's interesting for acer-wmi generated brightness interface when

Re: i915/kms/backlight-combo mode problem

2011-05-08 Thread Joey Lee
於 六,2011-05-07 於 22:22 +0200,Melchior FRANZ 提到: > * Melchior FRANZ -- Friday 06 May 2011: > > last patch prevents the backlight from being turned off, but it also > > breaks the brightness adjustment keys at runtime with acpi_osi=Linux. > > It has turned out that acpi key events seem to be handled

i915/kms/backlight-combo mode problem

2011-05-07 Thread Melchior FRANZ
* Melchior FRANZ -- Friday 06 May 2011: > last patch prevents the backlight from being turned off, but it also > breaks the brightness adjustment keys at runtime with acpi_osi=Linux. It has turned out that acpi key events seem to be handled correctly and even the state of /sys/class/backlight/acer

Re: i915/kms/backlight-combo mode problem

2011-05-07 Thread Melchior FRANZ
* Melchior FRANZ -- Friday 06 May 2011: > last patch prevents the backlight from being turned off, but it also > breaks the brightness adjustment keys at runtime with acpi_osi=Linux. It has turned out that acpi key events seem to be handled correctly and even the state of /sys/class/backlight/acer

i915/kms/backlight-combo mode problem

2011-05-06 Thread Melchior FRANZ
* Joey Lee -- Friday 06 May 2011: > ? ??2011-05-06 ? 10:52 +0200?Melchior FRANZ ??? > > ... and changing backlight brightness worked with acpi_osi=Linux, too. > > Unfortunately, that does no longer work now, although I haven't changed > > anything. Pressing the brightness buttons causes some ACPI d

i915/kms/backlight-combo mode problem

2011-05-06 Thread Melchior FRANZ
* Melchior FRANZ -- Thursday 05 May 2011: > This revised patch works correctly for me. ... and changing backlight brightness worked with acpi_osi=Linux, too. Unfortunately, that does no longer work now, although I haven't changed anything. Pressing the brightness buttons causes some ACPI debug out

Re: i915/kms/backlight-combo mode problem

2011-05-06 Thread Melchior FRANZ
* Joey Lee -- Friday 06 May 2011: > 於 五,2011-05-06 於 10:52 +0200,Melchior FRANZ 提到: > > ... and changing backlight brightness worked with acpi_osi=Linux, too. > > Unfortunately, that does no longer work now, although I haven't changed > > anything. Pressing the brightness buttons causes some ACPI d

i915/kms/backlight-combo mode problem

2011-05-06 Thread Joey Lee
Hi Melchior, ? ??2011-05-06 ? 10:52 +0200?Melchior FRANZ ??? > * Melchior FRANZ -- Thursday 05 May 2011: > > This revised patch works correctly for me. > > ... and changing backlight brightness worked with acpi_osi=Linux, too. > Unfortunately, that does no longer work now, although I haven't cha

Re: i915/kms/backlight-combo mode problem

2011-05-06 Thread Joey Lee
Hi Melchior, 於 五,2011-05-06 於 10:52 +0200,Melchior FRANZ 提到: > * Melchior FRANZ -- Thursday 05 May 2011: > > This revised patch works correctly for me. > > ... and changing backlight brightness worked with acpi_osi=Linux, too. > Unfortunately, that does no longer work now, although I haven't cha

Re: i915/kms/backlight-combo mode problem

2011-05-06 Thread Melchior FRANZ
* Melchior FRANZ -- Thursday 05 May 2011: > This revised patch works correctly for me. ... and changing backlight brightness worked with acpi_osi=Linux, too. Unfortunately, that does no longer work now, although I haven't changed anything. Pressing the brightness buttons causes some ACPI debug out

i915/kms/backlight-combo mode problem (was: Re: Linux 2.6.39-rc5)

2011-05-05 Thread Melchior FRANZ
* Takashi Iwai -- Thursday 05 May 2011: > Try the fixed patch below. > --- > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h > index 456f404..4c6e187 100644 > --- a/drivers/gpu/drm/i915/i915_drv.h > +++ b/drivers/gpu/drm/i915/i915_drv.h > @@ -332,6 +332,7 @@ typedef

Re: i915/kms/backlight-combo mode problem (was: Re: Linux 2.6.39-rc5)

2011-05-05 Thread Melchior FRANZ
* Takashi Iwai -- Thursday 05 May 2011: > Try the fixed patch below. > --- > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h > index 456f404..4c6e187 100644 > --- a/drivers/gpu/drm/i915/i915_drv.h > +++ b/drivers/gpu/drm/i915/i915_drv.h > @@ -332,6 +332,7 @@ typedef

Re: i915/kms/backlight-combo mode problem (was: Re: Linux 2.6.39-rc5)

2011-05-04 Thread Joey Lee
Hi Melchior, 於 一,2011-05-02 於 14:08 +0200,Takashi Iwai 提到: > At Sat, 30 Apr 2011 13:34:51 +0200, > Melchior FRANZ wrote: > > > > Dropping Linus from the CC. > > > > > > * Takashi Iwai -- Saturday 30 April 2011: > > * * At Sat, 30 Apr 2011 10:32:04 +0200, Melchior FRANZ wrote: > > > > Yes, back

i915/kms/backlight-combo mode problem (was: Re: Linux 2.6.39-rc5)

2011-05-04 Thread Joey Lee
Hi Melchior, ? ??2011-05-02 ? 14:08 +0200?Takashi Iwai ??? > At Sat, 30 Apr 2011 13:34:51 +0200, > Melchior FRANZ wrote: > > > > Dropping Linus from the CC. > > > > > > * Takashi Iwai -- Saturday 30 April 2011: > > * * At Sat, 30 Apr 2011 10:32:04 +0200, Melchior FRANZ wrote: > > > > Yes, back

i915/kms/backlight-combo mode problem (was: Re: Linux 2.6.39-rc5)

2011-05-02 Thread Melchior FRANZ
* Takashi Iwai -- Monday 02 May 2011: * > At Sat, 30 Apr 2011 13:34:51 +0200, Melchior FRANZ wrote: > > * Takashi Iwai -- Saturday 30 April 2011: > > > acpi_osi quirk should be better added statically, then. > > > > No, I guess the problem here is that acer_wmi doesn't support this > > machine yet

i915/kms/backlight-combo mode problem (was: Re: Linux 2.6.39-rc5)

2011-05-02 Thread Takashi Iwai
At Sat, 30 Apr 2011 13:34:51 +0200, Melchior FRANZ wrote: > > Dropping Linus from the CC. > > > * Takashi Iwai -- Saturday 30 April 2011: > * * At Sat, 30 Apr 2011 10:32:04 +0200, Melchior FRANZ wrote: > > > Yes, backlight adjustment generally works on this notebook, but only > > > with "acpi_os

Re: i915/kms/backlight-combo mode problem (was: Re: Linux 2.6.39-rc5)

2011-05-02 Thread Melchior FRANZ
* Takashi Iwai -- Monday 02 May 2011: * > At Sat, 30 Apr 2011 13:34:51 +0200, Melchior FRANZ wrote: > > * Takashi Iwai -- Saturday 30 April 2011: > > > acpi_osi quirk should be better added statically, then. > > > > No, I guess the problem here is that acer_wmi doesn't support this > > machine yet

Re: i915/kms/backlight-combo mode problem (was: Re: Linux 2.6.39-rc5)

2011-05-02 Thread Takashi Iwai
At Sat, 30 Apr 2011 13:34:51 +0200, Melchior FRANZ wrote: > > Dropping Linus from the CC. > > > * Takashi Iwai -- Saturday 30 April 2011: > * * At Sat, 30 Apr 2011 10:32:04 +0200, Melchior FRANZ wrote: > > > Yes, backlight adjustment generally works on this notebook, but only > > > with "acpi_os

Re: i915/kms/backlight-combo mode problem (was: Re: Linux 2.6.39-rc5)

2011-05-01 Thread Joey Lee
Hi Melchior, 於 六,2011-04-30 於 13:34 +0200,Melchior FRANZ 提到: > Dropping Linus from the CC. > > > * Takashi Iwai -- Saturday 30 April 2011: > * * At Sat, 30 Apr 2011 10:32:04 +0200, Melchior FRANZ wrote: > > > Yes, backlight adjustment generally works on this notebook, but only > > > with "acpi_

i915/kms/backlight-combo mode problem (was: Re: Linux 2.6.39-rc5)

2011-04-30 Thread Melchior FRANZ
Dropping Linus from the CC. * Takashi Iwai -- Saturday 30 April 2011: * * At Sat, 30 Apr 2011 10:32:04 +0200, Melchior FRANZ wrote: > > Yes, backlight adjustment generally works on this notebook, but only > > with "acpi_osi=Linux" on the command line. > > acpi_osi quirk should be better added st

i915/kms/backlight-combo mode problem (was: Re: Linux 2.6.39-rc5)

2011-04-30 Thread Takashi Iwai
At Sat, 30 Apr 2011 10:32:04 +0200, Melchior FRANZ wrote: > > * Takashi Iwai -- Saturday 30 April 2011: > > I remember vaguely that the value zero could be interpreted as the max. > > > Also, with the patch, does the backlight level can be adjusted > > correctly to different values? I wonder whe

i915/kms/backlight-combo mode problem (was: Re: Linux 2.6.39-rc5)

2011-04-30 Thread Melchior FRANZ
* Takashi Iwai -- Saturday 30 April 2011: > I remember vaguely that the value zero could be interpreted as the max. > Also, with the patch, does the backlight level can be adjusted > correctly to different values? I wonder whether LBPC adjustment > really works or not on your machine. > +

i915/kms/backlight-combo mode problem (was: Re: Linux 2.6.39-rc5)

2011-04-30 Thread Takashi Iwai
At Fri, 29 Apr 2011 22:09:54 +0200, Melchior FRANZ wrote: > > * Takashi Iwai -- Friday 29 April 2011: > [https://bugzilla.kernel.org/show_bug.cgi?id=31522] > > Looking at bugzilla, the problem seems like the case lbpc=0. > > What about the patch below instead? > > > - val *= lbp

i915/kms/backlight-combo mode problem (was: Re: Linux 2.6.39-rc5)

2011-04-30 Thread Joey Lee
Hi Melchior, ? ??2011-04-30 ? 13:34 +0200?Melchior FRANZ ??? > Dropping Linus from the CC. > > > * Takashi Iwai -- Saturday 30 April 2011: > * * At Sat, 30 Apr 2011 10:32:04 +0200, Melchior FRANZ wrote: > > > Yes, backlight adjustment generally works on this notebook, but only > > > with "acpi_

Re: i915/kms/backlight-combo mode problem (was: Re: Linux 2.6.39-rc5)

2011-04-30 Thread Melchior FRANZ
Dropping Linus from the CC. * Takashi Iwai -- Saturday 30 April 2011: * * At Sat, 30 Apr 2011 10:32:04 +0200, Melchior FRANZ wrote: > > Yes, backlight adjustment generally works on this notebook, but only > > with "acpi_osi=Linux" on the command line. > > acpi_osi quirk should be better added st

Re: i915/kms/backlight-combo mode problem (was: Re: Linux 2.6.39-rc5)

2011-04-30 Thread Takashi Iwai
At Sat, 30 Apr 2011 10:32:04 +0200, Melchior FRANZ wrote: > > * Takashi Iwai -- Saturday 30 April 2011: > > I remember vaguely that the value zero could be interpreted as the max. > > > Also, with the patch, does the backlight level can be adjusted > > correctly to different values? I wonder whe

Re: i915/kms/backlight-combo mode problem (was: Re: Linux 2.6.39-rc5)

2011-04-30 Thread Melchior FRANZ
* Takashi Iwai -- Saturday 30 April 2011: > I remember vaguely that the value zero could be interpreted as the max. > Also, with the patch, does the backlight level can be adjusted > correctly to different values? I wonder whether LBPC adjustment > really works or not on your machine. > +

Re: i915/kms/backlight-combo mode problem (was: Re: Linux 2.6.39-rc5)

2011-04-30 Thread Takashi Iwai
At Fri, 29 Apr 2011 22:09:54 +0200, Melchior FRANZ wrote: > > * Takashi Iwai -- Friday 29 April 2011: > [https://bugzilla.kernel.org/show_bug.cgi?id=31522] > > Looking at bugzilla, the problem seems like the case lbpc=0. > > What about the patch below instead? > > > - val *= lbp

i915/kms/backlight-combo mode problem (was: Re: Linux 2.6.39-rc5)

2011-04-29 Thread Melchior FRANZ
* Takashi Iwai -- Friday 29 April 2011: [https://bugzilla.kernel.org/show_bug.cgi?id=31522] > Looking at bugzilla, the problem seems like the case lbpc=0. > What about the patch below instead? > - val *= lbpc; > + if (lbpc) > + va

i915/kms/backlight-combo mode problem (was: Re: Linux 2.6.39-rc5)

2011-04-29 Thread Takashi Iwai
At Fri, 29 Apr 2011 19:41:53 +0200, Melchior FRANZ wrote: > > * Takashi Iwai -- Friday 29 April 2011: > > Melchior FRANZ wrote: > > > The bug was introduced with commit > > > ba3820ade317ee36e496b9b40d2ec3987dd4aef0 > > > [...] when using KMS my notebook's[2] screen remains dark, because the > >

i915/kms/backlight-combo mode problem (was: Re: Linux 2.6.39-rc5)

2011-04-29 Thread Melchior FRANZ
* Takashi Iwai -- Friday 29 April 2011: > Melchior FRANZ wrote: > > The bug was introduced with commit ba3820ade317ee36e496b9b40d2ec3987dd4aef0 > > [...] when using KMS my notebook's[2] screen remains dark, because the > > backlight isn't turned on. > Could you check whether the patch below change

Re: i915/kms/backlight-combo mode problem (was: Re: Linux 2.6.39-rc5)

2011-04-29 Thread Melchior FRANZ
* Takashi Iwai -- Friday 29 April 2011: [https://bugzilla.kernel.org/show_bug.cgi?id=31522] > Looking at bugzilla, the problem seems like the case lbpc=0. > What about the patch below instead? > - val *= lbpc; > + if (lbpc) > + va

Re: i915/kms/backlight-combo mode problem (was: Re: Linux 2.6.39-rc5)

2011-04-29 Thread Takashi Iwai
At Fri, 29 Apr 2011 19:41:53 +0200, Melchior FRANZ wrote: > > * Takashi Iwai -- Friday 29 April 2011: > > Melchior FRANZ wrote: > > > The bug was introduced with commit > > > ba3820ade317ee36e496b9b40d2ec3987dd4aef0 > > > [...] when using KMS my notebook's[2] screen remains dark, because the > >

i915/kms/backlight-combo mode problem (was: Re: Linux 2.6.39-rc5)

2011-04-29 Thread Melchior FRANZ
* Takashi Iwai -- Friday 29 April 2011: > Melchior FRANZ wrote: > > The bug was introduced with commit ba3820ade317ee36e496b9b40d2ec3987dd4aef0 > > [...] when using KMS my notebook's[2] screen remains dark, because the > > backlight isn't turned on. > Could you check whether the patch below change