drm_open doesnt lock before increasing dev->open_count

2011-02-09 Thread adam zeira
perfect. the whole structure's much much clearer now thanks to just that comment. atleast that did it for me maybe move the "Typically we are called (via the driver) from drm_stub_open()" to the function annotation aswell but not strictly needed with the new comment On Tue, Feb 8, 2011 at 1:18 AM

Re: drm_open doesnt lock before increasing dev->open_count

2011-02-09 Thread adam zeira
perfect. the whole structure's much much clearer now thanks to just that comment. atleast that did it for me maybe move the "Typically we are called (via the driver) from drm_stub_open()" to the function annotation aswell but not strictly needed with the new comment On Tue, Feb 8, 2011 at 1:18 AM

drm_open doesnt lock before increasing dev->open_count

2011-02-07 Thread Chris Wilson
On Tue, 08 Feb 2011 08:52:52 +1000, Dave Airlie wrote: > On Sun, 2011-02-06 at 19:24 +0200, adam zeira wrote: > > is this a problem? before trying to submit a solution I wanted to make sure > > with the experts > > > > it seems open_count isn't locked and can cause problems > > > > and if it is

Re: drm_open doesnt lock before increasing dev->open_count

2011-02-07 Thread Chris Wilson
On Tue, 08 Feb 2011 08:52:52 +1000, Dave Airlie wrote: > On Sun, 2011-02-06 at 19:24 +0200, adam zeira wrote: > > is this a problem? before trying to submit a solution I wanted to make sure > > with the experts > > > > it seems open_count isn't locked and can cause problems > > > > and if it is