drm_open doesn't lock before increasing dev->open_count

2011-02-08 Thread Dave Airlie
On Sun, 2011-02-06 at 19:24 +0200, adam zeira wrote: > is this a problem? before trying to submit a solution I wanted to make sure > with the experts > > it seems open_count isn't locked and can cause problems > > and if it is a problem, and needs to be solved, should locking be done or is > it

Re: drm_open doesn't lock before increasing dev->open_count

2011-02-07 Thread Dave Airlie
On Sun, 2011-02-06 at 19:24 +0200, adam zeira wrote: > is this a problem? before trying to submit a solution I wanted to make sure > with the experts > > it seems open_count isn't locked and can cause problems > > and if it is a problem, and needs to be solved, should locking be done or is > it

drm_open doesn't lock before increasing dev->open_count

2011-02-07 Thread adam zeira
is this a problem? before trying to submit a solution I wanted to make sure with the experts it seems open_count isn't locked and can cause problems and if it is a problem, and needs to be solved, should locking be done or is it better implemented with the (as I understand standard) kref? ht

drm_open doesn't lock before increasing dev->open_count

2011-02-06 Thread adam zeira
is this a problem? before trying to submit a solution I wanted to make sure with the experts it seems open_count isn't locked and can cause problems and if it is a problem, and needs to be solved, should locking be done or is it better implemented with the (as I understand standard) kref? ht