Re: drm_atomic_helper_shutdown() doesn't drop ref on active fb

2017-08-28 Thread Daniel Vetter
On Mon, Aug 28, 2017 at 10:54 PM, Daniel Vetter wrote: > I don't see your code, but from the logs it sound like you're > replacing a call for this with the shutdown helper. That will ofcourse > the references the fb helper holds. You need both calls to clean up > everything in all cases. Oops, th

Re: drm_atomic_helper_shutdown() doesn't drop ref on active fb

2017-08-28 Thread Daniel Vetter
On Mon, Aug 28, 2017 at 7:25 PM, Noralf Trønnes wrote: > Hi, > > If I use drm_atomic_helper_shutdown() when there's no framebuffer > active, it works fine, but if there is, it fails to drop a reference and > drm_mode_config_cleanup() complains that there are framebuffers left. > > The difference b

drm_atomic_helper_shutdown() doesn't drop ref on active fb

2017-08-28 Thread Noralf Trønnes
Hi, If I use drm_atomic_helper_shutdown() when there's no framebuffer active, it works fine, but if there is, it fails to drop a reference and drm_mode_config_cleanup() complains that there are framebuffers left. The difference between using drm_atomic_helper_shutdown() and not using it, is a fb