Re: drm: mipi_dbi_hw_reset() keeps display in reset

2025-03-15 Thread Dmitry Baryshkov
On Sat, Feb 15, 2025 at 02:14:54PM -0500, Alex Lanzano wrote: > On Fri, Feb 14, 2025 at 08:04:41PM -0500, Alex Lanzano wrote: > > On Fri, Feb 14, 2025 at 10:29:29AM +0100, Josef Luštický wrote: > > > Hello Alex, > > > there is a bug in mipi_dbi_hw_reset() function that implements the logic > > > o

Re: drm: mipi_dbi_hw_reset() keeps display in reset

2025-03-15 Thread Alex Lanzano
On Sat, Mar 15, 2025 at 11:43:54AM +0100, Noralf Trønnes wrote: > > > On 15.03.2025 00:50, Alex Lanzano wrote: > > On Fri, Mar 14, 2025 at 12:57:27PM +0100, Josef Luštický wrote: > >> On Mon, Mar 10, 2025 at 7:33 PM Alex Lanzano > >> wrote: > >>> > >>> On Fri, Mar 07, 2025 at 10:25:18AM +0100,

Re: drm: mipi_dbi_hw_reset() keeps display in reset

2025-03-15 Thread Noralf Trønnes
On 15.03.2025 00:50, Alex Lanzano wrote: > On Fri, Mar 14, 2025 at 12:57:27PM +0100, Josef Luštický wrote: >> On Mon, Mar 10, 2025 at 7:33 PM Alex Lanzano wrote: >>> >>> On Fri, Mar 07, 2025 at 10:25:18AM +0100, Josef Luštický wrote: Ok, I'll implement the change and post it for a review.

Re: drm: mipi_dbi_hw_reset() keeps display in reset

2025-03-14 Thread Alex Lanzano
On Fri, Mar 14, 2025 at 12:57:27PM +0100, Josef Luštický wrote: > On Mon, Mar 10, 2025 at 7:33 PM Alex Lanzano wrote: > > > > On Fri, Mar 07, 2025 at 10:25:18AM +0100, Josef Luštický wrote: > > > Ok, I'll implement the change and post it for a review. > > > About the property naming, I tend to nam

Re: drm: mipi_dbi_hw_reset() keeps display in reset

2025-03-14 Thread Josef Luštický
On Mon, Mar 10, 2025 at 7:33 PM Alex Lanzano wrote: > > On Fri, Mar 07, 2025 at 10:25:18AM +0100, Josef Luštický wrote: > > Ok, I'll implement the change and post it for a review. > > About the property naming, I tend to name it something like > > "inverted-reset-gpio-fixed" to denote that it is a

Re: drm: mipi_dbi_hw_reset() keeps display in reset

2025-03-11 Thread Josef Luštický
Ok, I'll implement the change and post it for a review. About the property naming, I tend to name it something like "inverted-reset-gpio-fixed" to denote that it is assumed the code using the "reset-gpios" property was fixed. What are your thoughts? Best regards, Josef On Tue, Feb 25, 2025 at 2:4

Re: drm: mipi_dbi_hw_reset() keeps display in reset

2025-03-10 Thread Alex Lanzano
On Fri, Mar 07, 2025 at 10:25:18AM +0100, Josef Luštický wrote: > Ok, I'll implement the change and post it for a review. > About the property naming, I tend to name it something like > "inverted-reset-gpio-fixed" to denote that it is assumed the code > using the "reset-gpios" property was fixed. >

Re: drm: mipi_dbi_hw_reset() keeps display in reset

2025-02-25 Thread Alex Lanzano
On Tue, Feb 25, 2025 at 12:59:59PM +0100, Josef Luštický wrote: > On Mon, Feb 24, 2025 at 12:13 AM Alex Lanzano wrote: > > > > On Mon, Feb 17, 2025 at 12:39:01PM +0100, Josef Luštický wrote: > > > On Sat, Feb 15, 2025 at 8:14 PM Alex Lanzano > > > wrote: > > > > > > > > On Fri, Feb 14, 2025 at 0

Re: drm: mipi_dbi_hw_reset() keeps display in reset

2025-02-25 Thread Josef Luštický
I think it's a good idea if the current logic is about to be fixed. Another (probably not as good) idea is to introduce a new property named "nreset-gpios = ..." or something like that, but I realise that "reset-gpios" is the de-facto standard naming. Best regards, Josef On Mon, Feb 24, 2025 at 1

Re: drm: mipi_dbi_hw_reset() keeps display in reset

2025-02-24 Thread Alex Lanzano
On Mon, Feb 17, 2025 at 12:39:01PM +0100, Josef Luštický wrote: > On Sat, Feb 15, 2025 at 8:14 PM Alex Lanzano wrote: > > > > On Fri, Feb 14, 2025 at 08:04:41PM -0500, Alex Lanzano wrote: > > > On Fri, Feb 14, 2025 at 10:29:29AM +0100, Josef Luštický wrote: > > > > Hello Alex, > > > > there is a b

Re: drm: mipi_dbi_hw_reset() keeps display in reset

2025-02-17 Thread Josef Luštický
On Sat, Feb 15, 2025 at 8:14 PM Alex Lanzano wrote: > > On Fri, Feb 14, 2025 at 08:04:41PM -0500, Alex Lanzano wrote: > > On Fri, Feb 14, 2025 at 10:29:29AM +0100, Josef Luštický wrote: > > > Hello Alex, > > > there is a bug in mipi_dbi_hw_reset() function that implements the logic > > > of > > >

Re: drm: mipi_dbi_hw_reset() keeps display in reset

2025-02-15 Thread Alex Lanzano
On Fri, Feb 14, 2025 at 08:04:41PM -0500, Alex Lanzano wrote: > On Fri, Feb 14, 2025 at 10:29:29AM +0100, Josef Luštický wrote: > > Hello Alex, > > there is a bug in mipi_dbi_hw_reset() function that implements the logic of > > display reset contrary. > > It keeps the reset line activated which kee

Re: drm: mipi_dbi_hw_reset() keeps display in reset

2025-02-14 Thread Alex Lanzano
On Fri, Feb 14, 2025 at 10:29:29AM +0100, Josef Luštický wrote: > Hello Alex, > there is a bug in mipi_dbi_hw_reset() function that implements the logic of > display reset contrary. > It keeps the reset line activated which keeps displays in reset state. > > I reported the bug to > https://gitlab.

drm: mipi_dbi_hw_reset() keeps display in reset

2025-02-14 Thread Josef Luštický
Hello Alex, there is a bug in mipi_dbi_hw_reset() function that implements the logic of display reset contrary. It keeps the reset line activated which keeps displays in reset state. I reported the bug to https://gitlab.freedesktop.org/drm/misc/kernel/-/issues/63 Unfortunately, fixing the bug wou