Re: drm/tve200: Checking for a failed platform_get_irq() call in tve200_probe()

2020-04-11 Thread Markus Elfring
>> I found 20 source files from the software “Linux next-20200408” >> which seem to contain similar update candidates. >> Would you like to clarify any extensions for improved applications >> of scripts with the semantic patch language (Coccinelle software) >> for corresponding analysis and transfo

Re: drm/tve200: Checking for a failed platform_get_irq() call in tve200_probe()

2020-04-11 Thread Markus Elfring
> The right way to check for errors is to check if the return value is > less than 0. Thanks for your constructive feedback. I was unsure if I noticed another programming mistake. > Could you please audit all uses of platform_get_irq() in drivers/gpu/ I found 20 source files from the software

Re: drm/tve200: Checking for a failed platform_get_irq() call in tve200_probe()

2020-04-10 Thread Sam Ravnborg
Hi Markus. On Fri, Apr 10, 2020 at 12:56:25PM +0200, Markus Elfring wrote: > > The right way to check for errors is to check if the return value is > > less than 0. > > Thanks for your constructive feedback. > > I was unsure if I noticed another programming mistake. > > > > Could you please au

Re: drm/tve200: Checking for a failed platform_get_irq() call in tve200_probe()

2020-04-10 Thread Sam Ravnborg
Hi Markus. On Thu, Apr 09, 2020 at 03:05:17PM +0200, Markus Elfring wrote: > Hello, > > I have taken another look at the implementation of the function > “tve200_probe”. > A software analysis approach points the following source code out for > further development considerations. > https://elixir

drm/tve200: Checking for a failed platform_get_irq() call in tve200_probe()

2020-04-10 Thread Markus Elfring
Hello, I have taken another look at the implementation of the function “tve200_probe”. A software analysis approach points the following source code out for further development considerations. https://elixir.bootlin.com/linux/v5.6.3/source/drivers/gpu/drm/tve200/tve200_drv.c#L212 https://git.kerne